Re: Proposal: Make the domain part of the Email Message-ID configurable

2020-12-07 Thread Tim Graham
You don't need to announce a patch on the mailing list. Instead check 
"According to the ticket's flags 
,
 
the next step(s) to move this issue forward are" on the ticket and update 
it accordingly. Thanks.

On Monday, December 7, 2020 at 8:11:12 AM UTC-5 jacob...@gmail.com wrote:

> Here is a pull request to fix https://code.djangoproject.com/ticket/6989 
> https://github.com/django/django/pull/13728
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/4c9097e0-2a61-449e-9e76-cf26243213b3n%40googlegroups.com.


Re: Proposal: Make the domain part of the Email Message-ID configurable

2020-12-07 Thread Jacob Rief
Here is a pull request to fix https://code.djangoproject.com/ticket/6989 
https://github.com/django/django/pull/13728

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/d63bd685-ef45-4415-8fdf-d861f78843cfn%40googlegroups.com.


Re: Proposal: Make the domain part of the Email Message-ID configurable

2020-09-06 Thread Tim Graham
Hi, I think https://code.djangoproject.com/ticket/6989 has some discussion 
related to this.

On Sunday, September 6, 2020 at 7:30:15 AM UTC-4 jacob...@gmail.com wrote:

> When Django's mail subsystem generates an email, it creates a unique 
> Message-ID. This is a requirement specified in RFC2822.
> The domain part of that Message-ID is generated by the Python network 
> utilities. It defacto is the domain name determined by a reverse DNS lookup.
>
> This can cause some problems:
>
>1. Django web services often run on private networks and its DNS 
>resolution could make that name quite common, such as 
>1.0.0.10.in-addr.arpa. This reduces the entropy to the generated 
>Message-IDs.
>2. It may expose some details of the internal network setup. Not every 
>sysadmin wants that.
>
>
> Current state
> The Message-ID is generated by:
> django.core.mail.message.EmailMessage.message() 
> Currently there is no way to configure the domain part inside this method.
>
> Proposed state
> Therefore I would suggest to add a new configuration directive to Django, 
> say EMAIL_MESSAGEID_FQDN. Another possibility would be to allow to 
> replace the hard-coded Message-ID generator email.utils.make_msgid() with 
> a self-written callable.
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/f94782f9-739d-4902-a24d-763cbc249e12n%40googlegroups.com.


Proposal: Make the domain part of the Email Message-ID configurable

2020-09-06 Thread Jacob Rief
When Django's mail subsystem generates an email, it creates a unique 
Message-ID. This is a requirement specified in RFC2822 https://tools.ietf.org/html/rfc2822#section-3.6.4>.
The domain part of that Message-ID is generated by the Python network 
utilities. It defacto is the domain name determined by a reverse DNS lookup.

This can cause some problems:

   1. Django web services often run on private networks and its DNS 
   resolution could make that name quite common, such as 
   1.0.0.10.in-addr.arpa. This reduces the entropy to the generated 
   Message-IDs.
   2. It may expose some details of the internal network setup. Not every 
   sysadmin wants that.


Current state
The Message-ID is generated by:
django.core.mail.message.EmailMessage.message() 
Currently there is no way to configure the domain part inside this method.

Proposed state
Therefore I would suggest to add a new configuration directive to Django, 
say EMAIL_MESSAGEID_FQDN. Another possibility would be to allow to replace 
the hard-coded Message-ID generator email.utils.make_msgid() with a 
self-written callable.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/97aa38e5-31e9-40c7-878b-08f87c031e91n%40googlegroups.com.