Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

[charettes]

I'm also -1 on removing the form field for the same reasons as Adam.

Le vendredi 24 avril 2020 06:39:06 UTC-4, Mariusz Felisiak a écrit :
>
> `models.NullBooleanField` is now deprecated [1].
>
> I would like to ask again about opinions on deprecating `forms.
> NullBooleanField` because I'm not convinced that it's necessary and 
> expected. `forms.NullBooleanField` and `forms.BooleanField` use different 
> widgets and their behavior is slightly different. Personally, I agree with 
> Tim [2] that removing `forms.NullBooleanField` will needlessly increase 
> complexity.
>
> Best,
> Mariusz
>
> [1] 
> https://github.com/django/django/commit/a92cc84b4a206d18a5f1a0eaa47f19add40ff99b
> [2] 
> https://github.com/django/django/pull/12636#pullrequestreview-383329786
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/2cb62a54-6493-4acb-a75c-0b59fca23128%40googlegroups.com.

Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

[Adam Johnson]

I'm -1 on deprecating the form field. The different widgets make sense.
Forms are decoupled from models for reasons like this.

On Fri, 24 Apr 2020 at 11:39, Mariusz Felisiak 
wrote:

> `models.NullBooleanField` is now deprecated [1].
>
> I would like to ask again about opinions on deprecating `forms.
> NullBooleanField` because I'm not convinced that it's necessary and
> expected. `forms.NullBooleanField` and `forms.BooleanField` use different
> widgets and their behavior is slightly different. Personally, I agree with
> Tim [2] that removing `forms.NullBooleanField` will needlessly increase
> complexity.
>
> Best,
> Mariusz
>
> [1]
> https://github.com/django/django/commit/a92cc84b4a206d18a5f1a0eaa47f19add40ff99b
> [2]
> https://github.com/django/django/pull/12636#pullrequestreview-383329786
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/9a3fba1b-79e0-4ff1-8105-6ad5dd9e5458%40googlegroups.com
> 
> .
>


-- 
Adam

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMyDDM0f7O22zaSNyW%2Bj_q9HEeeLp88T4BvTff%3DeAfPRWSfypg%40mail.gmail.com.

Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

[Mariusz Felisiak]

`models.NullBooleanField` is now deprecated [1].

I would like to ask again about opinions on deprecating `forms.
NullBooleanField` because I'm not convinced that it's necessary and 
expected. `forms.NullBooleanField` and `forms.BooleanField` use different 
widgets and their behavior is slightly different. Personally, I agree with 
Tim [2] that removing `forms.NullBooleanField` will needlessly increase 
complexity.

Best,
Mariusz

[1] 
https://github.com/django/django/commit/a92cc84b4a206d18a5f1a0eaa47f19add40ff99b
[2] https://github.com/django/django/pull/12636#pullrequestreview-383329786

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/9a3fba1b-79e0-4ff1-8105-6ad5dd9e5458%40googlegroups.com.

Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

[Markus Holtermann]

Makes sense. We'd have the deprecation shims around for a while anyway.

/Markus

On Tue, Mar 17, 2020, at 11:10 AM, Carlton Gibson wrote:
> Ok, that’s pretty quick and conclusive, so let’s progress. Thanks all. 
> 
> On Tue, 17 Mar 2020 at 11:00, Shrawan Poudel  wrote:
> > +1 from me
> > 
> > On Tue, Mar 17, 2020 at 3:00 PM Adam Johnson  wrote:
> >> +1 from me.
> >> 
> >> On Tue, 17 Mar 2020 at 07:59, Aymeric Augustin 
> >>  wrote:
> >>> Hello,
> >>> 
> >>> I'm inclined to Accept as well.
> >>> 
> >>> -- 
> >>> Aymeric.
> >>> 
> >>> 
> >>> 
>  On 17 Mar 2020, at 08:49, Carlton Gibson  
>  wrote:
>  
>  Hi all. 
>  
>  
>  https://code.djangoproject.com/ticket/31369
>  Proposes to deprecate NullBooleanField. 
>  
>  
>  https://code.djangoproject.com/ticket/29227 
>  Allowed BooleanField to be null=True. 
>  Introduced in Django 2.1. 
>  
>  
>  I'm inclined to Accept. 
>  Wonder if folks consider it a little too fast? 
>  (We could defer for 5.0.) 
>  
>  
>  Kind Regards,
>  
>  Carlton
>  
>  
>   -- 
>   You received this message because you are subscribed to the Google 
>  Groups "Django developers (Contributions to Django itself)" group.
>   To unsubscribe from this group and stop receiving emails from it, send 
>  an email to django-developers+unsubscr...@googlegroups.com.
>   To view this discussion on the web visit 
>  https://groups.google.com/d/msgid/django-developers/02a4b01d-e47f-4092-826e-c0cfa074901f%40googlegroups.com
>   
>  .
> >>> 
> 
> >>>  -- 
> >>>  You received this message because you are subscribed to the Google 
> >>> Groups "Django developers (Contributions to Django itself)" group.
> >>>  To unsubscribe from this group and stop receiving emails from it, send 
> >>> an email to django-developers+unsubscr...@googlegroups.com.
> >>>  To view this discussion on the web visit 
> >>> https://groups.google.com/d/msgid/django-developers/6353F843-B61D-4C50-8A45-98DAD860301A%40polytechnique.org
> >>>  
> >>> .
> >> 
> >> 
> >> -- 
> >> Adam
> 
> >>  -- 
> >>  You received this message because you are subscribed to the Google Groups 
> >> "Django developers (Contributions to Django itself)" group.
> >>  To unsubscribe from this group and stop receiving emails from it, send an 
> >> email to django-developers+unsubscr...@googlegroups.com.
> >>  To view this discussion on the web visit 
> >> https://groups.google.com/d/msgid/django-developers/CAMyDDM3bCYzz3JMCVgXP1%2BmB56CCmTiHmw1ij%3Dbj_5aQSGWaZQ%40mail.gmail.com
> >>  
> >> .
> 
> >  -- 
> >  You received this message because you are subscribed to the Google Groups 
> > "Django developers (Contributions to Django itself)" group.
> >  To unsubscribe from this group and stop receiving emails from it, send an 
> > email to django-developers+unsubscr...@googlegroups.com.
> >  To view this discussion on the web visit 
> > https://groups.google.com/d/msgid/django-developers/CAPD6JmmfPwGKjQ_Zjet0SENz3Rk26UhfRL9TrpX0Kxo7HdMWtA%40mail.gmail.com
> >  
> > .
> 
>  -- 
>  You received this message because you are subscribed to the Google 
> Groups "Django developers (Contributions to Django itself)" group.
>  To unsubscribe from this group and stop receiving emails from it, send 
> an email to django-developers+unsubscr...@googlegroups.com.
>  To view this discussion on the web visit 
> https://groups.google.com/d/msgid/django-developers/CAJwKpyRU95YkyRYbyZi388GB-wx9EMjGOMRQ6-3-exS1s46%3Dyg%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/02c3cca0-ca87-4b56-a1ca-866b516a5e7d%40www.fastmail.com.

Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

[Carlton Gibson]

Ok, that’s pretty quick and conclusive, so let’s progress. Thanks all.

On Tue, 17 Mar 2020 at 11:00, Shrawan Poudel  wrote:

> +1 from me
>
> On Tue, Mar 17, 2020 at 3:00 PM Adam Johnson  wrote:
>
>> +1 from me.
>>
>> On Tue, 17 Mar 2020 at 07:59, Aymeric Augustin <
>> aymeric.augus...@polytechnique.org> wrote:
>>
>>> Hello,
>>>
>>> I'm inclined to Accept as well.
>>>
>>> --
>>> Aymeric.
>>>
>>>
>>>
>>> On 17 Mar 2020, at 08:49, Carlton Gibson 
>>> wrote:
>>>
>>> Hi all.
>>>
>>>
>>> https://code.djangoproject.com/ticket/31369
>>> Proposes to deprecate NullBooleanField.
>>>
>>>
>>> https://code.djangoproject.com/ticket/29227
>>> Allowed BooleanField to be null=True.
>>> Introduced in Django 2.1.
>>>
>>>
>>> I'm inclined to Accept.
>>> Wonder if folks consider it a little too fast?
>>> (We could defer for 5.0.)
>>>
>>>
>>> Kind Regards,
>>>
>>> Carlton
>>>
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Django developers (Contributions to Django itself)" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to django-developers+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/django-developers/02a4b01d-e47f-4092-826e-c0cfa074901f%40googlegroups.com
>>> 
>>> .
>>>
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Django developers (Contributions to Django itself)" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to django-developers+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/django-developers/6353F843-B61D-4C50-8A45-98DAD860301A%40polytechnique.org
>>> 
>>> .
>>>
>>
>>
>> --
>> Adam
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to django-developers+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/django-developers/CAMyDDM3bCYzz3JMCVgXP1%2BmB56CCmTiHmw1ij%3Dbj_5aQSGWaZQ%40mail.gmail.com
>> 
>> .
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/CAPD6JmmfPwGKjQ_Zjet0SENz3Rk26UhfRL9TrpX0Kxo7HdMWtA%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAJwKpyRU95YkyRYbyZi388GB-wx9EMjGOMRQ6-3-exS1s46%3Dyg%40mail.gmail.com.

Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

[Shrawan Poudel]

+1 from me

On Tue, Mar 17, 2020 at 3:00 PM Adam Johnson  wrote:

> +1 from me.
>
> On Tue, 17 Mar 2020 at 07:59, Aymeric Augustin <
> aymeric.augus...@polytechnique.org> wrote:
>
>> Hello,
>>
>> I'm inclined to Accept as well.
>>
>> --
>> Aymeric.
>>
>>
>>
>> On 17 Mar 2020, at 08:49, Carlton Gibson 
>> wrote:
>>
>> Hi all.
>>
>>
>> https://code.djangoproject.com/ticket/31369
>> Proposes to deprecate NullBooleanField.
>>
>>
>> https://code.djangoproject.com/ticket/29227
>> Allowed BooleanField to be null=True.
>> Introduced in Django 2.1.
>>
>>
>> I'm inclined to Accept.
>> Wonder if folks consider it a little too fast?
>> (We could defer for 5.0.)
>>
>>
>> Kind Regards,
>>
>> Carlton
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to django-developers+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/django-developers/02a4b01d-e47f-4092-826e-c0cfa074901f%40googlegroups.com
>> 
>> .
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Django developers (Contributions to Django itself)" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to django-developers+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/django-developers/6353F843-B61D-4C50-8A45-98DAD860301A%40polytechnique.org
>> 
>> .
>>
>
>
> --
> Adam
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/CAMyDDM3bCYzz3JMCVgXP1%2BmB56CCmTiHmw1ij%3Dbj_5aQSGWaZQ%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAPD6JmmfPwGKjQ_Zjet0SENz3Rk26UhfRL9TrpX0Kxo7HdMWtA%40mail.gmail.com.

Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

[Adam Johnson]

+1 from me.

On Tue, 17 Mar 2020 at 07:59, Aymeric Augustin <
aymeric.augus...@polytechnique.org> wrote:

> Hello,
>
> I'm inclined to Accept as well.
>
> --
> Aymeric.
>
>
>
> On 17 Mar 2020, at 08:49, Carlton Gibson  wrote:
>
> Hi all.
>
>
> https://code.djangoproject.com/ticket/31369
> Proposes to deprecate NullBooleanField.
>
>
> https://code.djangoproject.com/ticket/29227
> Allowed BooleanField to be null=True.
> Introduced in Django 2.1.
>
>
> I'm inclined to Accept.
> Wonder if folks consider it a little too fast?
> (We could defer for 5.0.)
>
>
> Kind Regards,
>
> Carlton
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/02a4b01d-e47f-4092-826e-c0cfa074901f%40googlegroups.com
> 
> .
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/6353F843-B61D-4C50-8A45-98DAD860301A%40polytechnique.org
> 
> .
>


-- 
Adam

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMyDDM3bCYzz3JMCVgXP1%2BmB56CCmTiHmw1ij%3Dbj_5aQSGWaZQ%40mail.gmail.com.

Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

[Mariusz Felisiak]

Agreed, it's time to deprecate NullBooleanField.

Best,
Mariusz

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/27a38539-336a-45e0-987c-6df6a1861621%40googlegroups.com.

Re: Proposal to deprecate NullBooleanField (and remove in Django 4.0)

[Aymeric Augustin]

Hello,

I'm inclined to Accept as well.

-- 
Aymeric.



> On 17 Mar 2020, at 08:49, Carlton Gibson  wrote:
> 
> Hi all. 
> 
> 
> https://code.djangoproject.com/ticket/31369
> Proposes to deprecate NullBooleanField. 
> 
> 
> https://code.djangoproject.com/ticket/29227 
> Allowed BooleanField to be null=True. 
> Introduced in Django 2.1. 
> 
> 
> I'm inclined to Accept. 
> Wonder if folks consider it a little too fast? 
> (We could defer for 5.0.) 
> 
> 
> Kind Regards,
> 
> Carlton
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to django-developers+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/django-developers/02a4b01d-e47f-4092-826e-c0cfa074901f%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/6353F843-B61D-4C50-8A45-98DAD860301A%40polytechnique.org.

Proposal to deprecate NullBooleanField (and remove in Django 4.0)

[Carlton Gibson]

Hi all. 


https://code.djangoproject.com/ticket/31369
Proposes to deprecate NullBooleanField. 


https://code.djangoproject.com/ticket/29227 
Allowed BooleanField to be null=True. 
Introduced in Django 2.1. 


I'm inclined to Accept. 
Wonder if folks consider it a little too fast? 
(We could defer for 5.0.) 


Kind Regards,

Carlton

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/02a4b01d-e47f-4092-826e-c0cfa074901f%40googlegroups.com.