Re: "Delete selected objects" in admin batch edit

[kmike]

It's a very good opinion. I don't want any actions from parent model
admin class too.
Maybe it is worth opening a dedicated ticket?

On 5 апр, 05:56, Alex Gaynor  wrote:
> On Sat, Apr 4, 2009 at 7:10 PM, kmike  wrote:
>
> > Totally agree, bulk delete shouldn't be enabled by default.
>
> > One more issue with that: it is nice to be able to define actions
> > order in drop-down list. It can be achieved with very simple patch,
> > seehttp://code.djangoproject.com/ticket/10734. But if we have delete
> > action (or any other action) enabled by default, this patch will
> > always put it at top and we will have to overload "get_actions" method
> > again to fix it.
>
> It seems to me that the default behavior of including items from every
> parent class is causing more harm than good.  I'm very tempted to say we
> might be better off just requiring users to either relist every item or do:
>
> class MyModelAdmin(ModelAdmin):
>     actions = ModelAdmin.actions + ['my_action']
>
> Alex
>
> --
> "I disapprove of what you say, but I will defend to the death your right to
> say it." --Voltaire
> "The people's good is the highest law."--Cicero
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---

Re: "Delete selected objects" in admin batch edit

[kmike]

Totally agree, bulk delete shouldn't be enabled by default.

One more issue with that: it is nice to be able to define actions
order in drop-down list. It can be achieved with very simple patch,
see http://code.djangoproject.com/ticket/10734 . But if we have delete
action (or any other action) enabled by default, this patch will
always put it at top and we will have to overload "get_actions" method
again to fix it.

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---

Re: "Delete selected objects" in admin batch edit

[Alex Gaynor]

On Sat, Apr 4, 2009 at 7:10 PM, kmike  wrote:

>
> Totally agree, bulk delete shouldn't be enabled by default.
>
> One more issue with that: it is nice to be able to define actions
> order in drop-down list. It can be achieved with very simple patch,
> see http://code.djangoproject.com/ticket/10734 . But if we have delete
> action (or any other action) enabled by default, this patch will
> always put it at top and we will have to overload "get_actions" method
> again to fix it.
>
> >
>
It seems to me that the default behavior of including items from every
parent class is causing more harm than good.  I'm very tempted to say we
might be better off just requiring users to either relist every item or do:

class MyModelAdmin(ModelAdmin):
actions = ModelAdmin.actions + ['my_action']

Alex

-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." --Voltaire
"The people's good is the highest law."--Cicero

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---

Re: "Delete selected objects" in admin batch edit

[Zachary Voase]

Don't forget, a lot of people also use a custom method of deletion on
their models; they may not want to remove a record from the database,
but instead set a 'deleted' flag; having deletion also there by
default means they would have two deletion actions. I'd say that
deletion should be there if no admin actions are specified in the
subclass, but that if you set your own then you should have to include
it yourself.

On Mar 27, 2:12 am, Elliott  wrote:
> If there's no objections by tomorrow I'm going to reopen http://
> code.djangoproject.com/ticket/10596
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---

Re: "Delete selected objects" in admin batch edit

[Elliott]

If there's no objections by tomorrow I'm going to reopen http://
code.djangoproject.com/ticket/10596
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---

Re: "Delete selected objects" in admin batch edit

[Jannis Leidel]

Am 24.03.2009 um 10:41 schrieb David Larlet:

>
>
> Le 24 mars 09 à 09:36, Elliott a écrit :
>> Given these reasons it only makes sense to me to leave delete off by
>> default and provide an easy way to enable it, both globally or for
>> each model.
>
> I agree with Elliott, admin actions are great and we were all
> impatients to see it in action - no pun intended - but enabling
> deletion by default is a bit "critical" (feedback from clients). Maybe
> we can work together on #10595?

I agree, it's a bit unfortunate to have deletion activated by default.  
Maby we should make it opt-in, instead of opt-out.

Jannis


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---

Re: "Delete selected objects" in admin batch edit

[Justin Lilly]

It would seem to me that the method we're using for context_processors
might be a good one. A list of things available by default, then you
can override it in settings.py in order to provide different ones or
remove some of the defaults. I think it could very well. Thoughts?

 -justin

-- 
Justin Lilly
Web Developer/Designer
http://justinlilly.com

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---

Re: "Delete selected objects" in admin batch edit

[David Larlet]

Le 24 mars 09 à 09:36, Elliott a écrit :
> Given these reasons it only makes sense to me to leave delete off by
> default and provide an easy way to enable it, both globally or for
> each model.

I agree with Elliott, admin actions are great and we were all  
impatients to see it in action - no pun intended - but enabling  
deletion by default is a bit "critical" (feedback from clients). Maybe  
we can work together on #10595?

Regards,
David



--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---