Re: Backporting ticket 25548 into 1.9.x

[charettes]

I confirm this is the reason it wasn't backported in the first place.

Le lundi 7 décembre 2015 08:20:19 UTC-5, Tim Graham a écrit :
>
> I've done the backport. I think the only reason it wasn't done initially 
> is that there's no indication on the ticket that the issue was a regression.
>
> On Sunday, December 6, 2015 at 11:34:47 AM UTC-5, Marc Tamlyn wrote:
>>
>> Agreed the reasoning is sound. This is a major bug as far as I'm 
>> concerned and I'd like to see it backported. Thanks for bringing it up.
>>
>> Marc
>> On 6 Dec 2015 1:05 p.m., "Shai Berger"  wrote:
>>
>>> On Sunday 06 December 2015 14:52:08 Aymeric Augustin wrote:
>>> > > On 6 déc. 2015, at 10:49, James Bennett  wrote:
>>> > >
>>> > > Thoughts?
>>> >
>>> > I don’t think anyone ever prevented a core dev who wanted to backport a
>>> > commit from doing so — unless it carried a risk of backwards
>>> > incompatibility, which doesn’t appear to be the case here.
>>>
>>> Not to my knowledge also, but we did have a policy change, about two 
>>> years
>>> ago, against arbitrary backports at a core-dev's judgment (which was the 
>>> norm
>>> until then). So, I find it very proper that James has brought this up on 
>>> the
>>> list.
>>>
>>> That said, the reasoning for backporting seems sound to me, so +1.
>>>
>>> Shai.
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/3dd88799-132e-4567-9d43-e8d233a9a040%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Backporting ticket 25548 into 1.9.x

[James Bennett]

Thanks to everyone for the quick consensus, and to Tim for backporting it
and fixing the docs before I could get around to it :)

On Mon, Dec 7, 2015 at 9:23 AM, Tim Graham  wrote:

> Done in
> https://github.com/django/django/commit/9c835990ea2911c06a877296fbc25157c1302e1d
> -- thanks for pointing it out.
>
> On Monday, December 7, 2015 at 8:42:09 AM UTC-5, Anssi Kääriäinen wrote:
>>
>> On Mon, Dec 7, 2015 at 3:20 PM, Tim Graham  wrote:
>> > I've done the backport. I think the only reason it wasn't done
>> initially is
>> > that there's no indication on the ticket that the issue was a
>> regression.
>>
>> For some reason we don't mention backporting of regression fixes in
>> https://docs.djangoproject.com/en/1.9/internals/release-process/.
>> Should we add an explicit bullet point for that?
>>
>>  - Anssi
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at http://groups.google.com/group/django-developers.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-developers/54d1599b-caca-4379-b017-657c8b6b4cae%40googlegroups.com
> 
> .
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAL13Cg_QERLt_RkXE3t7XV6hG5XntLhgWr0xUxVJyxOvkwRupg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Backporting ticket 25548 into 1.9.x

[Tim Graham]

Done in 
https://github.com/django/django/commit/9c835990ea2911c06a877296fbc25157c1302e1d
 
-- thanks for pointing it out.

On Monday, December 7, 2015 at 8:42:09 AM UTC-5, Anssi Kääriäinen wrote:
>
> On Mon, Dec 7, 2015 at 3:20 PM, Tim Graham  > wrote: 
> > I've done the backport. I think the only reason it wasn't done initially 
> is 
> > that there's no indication on the ticket that the issue was a 
> regression. 
>
> For some reason we don't mention backporting of regression fixes in 
> https://docs.djangoproject.com/en/1.9/internals/release-process/. 
> Should we add an explicit bullet point for that? 
>
>  - Anssi 
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/54d1599b-caca-4379-b017-657c8b6b4cae%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Backporting ticket 25548 into 1.9.x

[Anssi Kääriäinen]

On Mon, Dec 7, 2015 at 3:20 PM, Tim Graham  wrote:
> I've done the backport. I think the only reason it wasn't done initially is
> that there's no indication on the ticket that the issue was a regression.

For some reason we don't mention backporting of regression fixes in
https://docs.djangoproject.com/en/1.9/internals/release-process/.
Should we add an explicit bullet point for that?

 - Anssi

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CALMtK1H4a1U6%2Brmms_1Wdosgz99BN70RLn8n0U1qcf0Nc%2BMv6Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Backporting ticket 25548 into 1.9.x

[Tim Graham]

I've done the backport. I think the only reason it wasn't done initially is 
that there's no indication on the ticket that the issue was a regression.

On Sunday, December 6, 2015 at 11:34:47 AM UTC-5, Marc Tamlyn wrote:
>
> Agreed the reasoning is sound. This is a major bug as far as I'm concerned 
> and I'd like to see it backported. Thanks for bringing it up.
>
> Marc
> On 6 Dec 2015 1:05 p.m., "Shai Berger"  
> wrote:
>
>> On Sunday 06 December 2015 14:52:08 Aymeric Augustin wrote:
>> > > On 6 déc. 2015, at 10:49, James Bennett > > wrote:
>> > >
>> > > Thoughts?
>> >
>> > I don’t think anyone ever prevented a core dev who wanted to backport a
>> > commit from doing so — unless it carried a risk of backwards
>> > incompatibility, which doesn’t appear to be the case here.
>>
>> Not to my knowledge also, but we did have a policy change, about two years
>> ago, against arbitrary backports at a core-dev's judgment (which was the 
>> norm
>> until then). So, I find it very proper that James has brought this up on 
>> the
>> list.
>>
>> That said, the reasoning for backporting seems sound to me, so +1.
>>
>> Shai.
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/63e13481-afe3-407c-89d9-3dcd74bf0ad8%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Backporting ticket 25548 into 1.9.x

[Marc Tamlyn]

Agreed the reasoning is sound. This is a major bug as far as I'm concerned
and I'd like to see it backported. Thanks for bringing it up.

Marc
On 6 Dec 2015 1:05 p.m., "Shai Berger"  wrote:

> On Sunday 06 December 2015 14:52:08 Aymeric Augustin wrote:
> > > On 6 déc. 2015, at 10:49, James Bennett  wrote:
> > >
> > > Thoughts?
> >
> > I don’t think anyone ever prevented a core dev who wanted to backport a
> > commit from doing so — unless it carried a risk of backwards
> > incompatibility, which doesn’t appear to be the case here.
>
> Not to my knowledge also, but we did have a policy change, about two years
> ago, against arbitrary backports at a core-dev's judgment (which was the
> norm
> until then). So, I find it very proper that James has brought this up on
> the
> list.
>
> That said, the reasoning for backporting seems sound to me, so +1.
>
> Shai.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMwjO1F949HA_pZis54b7S55ZKbdUTLcdEMefOx2wa%2Bx3_dqwA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Backporting ticket 25548 into 1.9.x

[Shai Berger]

On Sunday 06 December 2015 14:52:08 Aymeric Augustin wrote:
> > On 6 déc. 2015, at 10:49, James Bennett  wrote:
> > 
> > Thoughts?
> 
> I don’t think anyone ever prevented a core dev who wanted to backport a
> commit from doing so — unless it carried a risk of backwards
> incompatibility, which doesn’t appear to be the case here.

Not to my knowledge also, but we did have a policy change, about two years 
ago, against arbitrary backports at a core-dev's judgment (which was the norm 
until then). So, I find it very proper that James has brought this up on the 
list.

That said, the reasoning for backporting seems sound to me, so +1.

Shai.

Re: Backporting ticket 25548 into 1.9.x

[Aymeric Augustin]

> On 6 déc. 2015, at 10:49, James Bennett  wrote:
> 
> Thoughts?

I don’t think anyone ever prevented a core dev who wanted to backport a commit
from doing so — unless it carried a risk of backwards incompatibility, which
doesn’t appear to be the case here.

-- 
Aymeric.




-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/353CACE3-7B62-49F1-BF49-F5DA4D542202%40polytechnique.org.
For more options, visit https://groups.google.com/d/optout.