Re: Logged out sessions are resurrected by concurrent requests (ticket 21608)
You could ask a friend or colleague to review the patch using the patch review checklist [1] and mark it "Ready for checkin" if it looks good. Otherwise, you just wait for someone to review it. [1] https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/#patch-review-checklist On Wednesday, February 24, 2016 at 10:18:26 AM UTC-5, Tore Lundqvist wrote: > > Is there something I can do to move this forward? > > > Den torsdag 11 februari 2016 kl. 09:56:15 UTC+1 skrev Tore Lundqvist: >> >> Thanks for all the help with the patch! I hope its close to being >> acceptable now. Can someone have a look at the PR? >> >> Den tisdag 2 februari 2016 kl. 13:08:51 UTC+1 skrev Tore Lundqvist: >>> >>> Ok, got that sorted now. How about the fix, is it reasonable? >>> >>> >>> Den tisdag 2 februari 2016 kl. 11:51:19 UTC+1 skrev is_null: Just click "Details" and then "Console output". You'll find this: + flake8 ./django/contrib/sessions/backends/db.py:91:30: E901 SyntaxError: invalid syntax ERROR: /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py Imports are incorrectly sorted. --- /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py:before 2016-02-01 16:04:24.701654 +++ /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py:after 2016-02-01 16:04:30.952126 @@ -1,8 +1,10 @@ import logging -from django.contrib.sessions.backends.base import CreateError, SessionBase, UpdateError +from django.contrib.sessions.backends.base import ( +CreateError, SessionBase, UpdateError, +) from django.core.exceptions import SuspiciousOperation -from django.db import IntegrityError, router, transaction, DatabaseError +from django.db import DatabaseError, IntegrityError, router, transaction from django.utils import timezone from django.utils.encoding import force_text from django.utils.functional import cached_property >>> -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/024a410c-7094-4fcd-991a-0a1d6bfba7ea%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Logged out sessions are resurrected by concurrent requests (ticket 21608)
Is there something I can do to move this forward? Den torsdag 11 februari 2016 kl. 09:56:15 UTC+1 skrev Tore Lundqvist: > > Thanks for all the help with the patch! I hope its close to being > acceptable now. Can someone have a look at the PR? > > Den tisdag 2 februari 2016 kl. 13:08:51 UTC+1 skrev Tore Lundqvist: >> >> Ok, got that sorted now. How about the fix, is it reasonable? >> >> >> Den tisdag 2 februari 2016 kl. 11:51:19 UTC+1 skrev is_null: >>> >>> Just click "Details" and then "Console output". You'll find this: >>> >>> + flake8 >>> ./django/contrib/sessions/backends/db.py:91:30: E901 SyntaxError: >>> invalid syntax >>> >>> ERROR: >>> /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py >>> Imports are incorrectly sorted. >>> --- >>> /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py:before >>> 2016-02-01 16:04:24.701654 >>> +++ >>> /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py:after >>> 2016-02-01 16:04:30.952126 >>> @@ -1,8 +1,10 @@ >>> import logging >>> >>> -from django.contrib.sessions.backends.base import CreateError, >>> SessionBase, UpdateError >>> +from django.contrib.sessions.backends.base import ( >>> +CreateError, SessionBase, UpdateError, >>> +) >>> from django.core.exceptions import SuspiciousOperation >>> -from django.db import IntegrityError, router, transaction, >>> DatabaseError >>> +from django.db import DatabaseError, IntegrityError, router, >>> transaction >>> from django.utils import timezone >>> from django.utils.encoding import force_text >>> from django.utils.functional import cached_property >>> >> -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/b0632afe-4828-401d-b350-80ba53f96969%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Logged out sessions are resurrected by concurrent requests (ticket 21608)
Thanks for all the help with the patch! I hope its close to being acceptable now. Can someone have a look at the PR? Den tisdag 2 februari 2016 kl. 13:08:51 UTC+1 skrev Tore Lundqvist: > > Ok, got that sorted now. How about the fix, is it reasonable? > > > Den tisdag 2 februari 2016 kl. 11:51:19 UTC+1 skrev is_null: >> >> Just click "Details" and then "Console output". You'll find this: >> >> + flake8 >> ./django/contrib/sessions/backends/db.py:91:30: E901 SyntaxError: invalid >> syntax >> >> ERROR: >> /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py >> Imports are incorrectly sorted. >> --- >> /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py:before >> 2016-02-01 16:04:24.701654 >> +++ >> /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py:after >> 2016-02-01 16:04:30.952126 >> @@ -1,8 +1,10 @@ >> import logging >> >> -from django.contrib.sessions.backends.base import CreateError, >> SessionBase, UpdateError >> +from django.contrib.sessions.backends.base import ( >> +CreateError, SessionBase, UpdateError, >> +) >> from django.core.exceptions import SuspiciousOperation >> -from django.db import IntegrityError, router, transaction, DatabaseError >> +from django.db import DatabaseError, IntegrityError, router, transaction >> from django.utils import timezone >> from django.utils.encoding import force_text >> from django.utils.functional import cached_property >> > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/b4e867e5-1dda-48a5-9a92-c7c647c42c0e%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Logged out sessions are resurrected by concurrent requests (ticket 21608)
Ok, got that sorted now. How about the fix, is it reasonable? Den tisdag 2 februari 2016 kl. 11:51:19 UTC+1 skrev is_null: > > Just click "Details" and then "Console output". You'll find this: > > + flake8 > ./django/contrib/sessions/backends/db.py:91:30: E901 SyntaxError: invalid > syntax > > ERROR: > /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py > Imports are incorrectly sorted. > --- > /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py:before > 2016-02-01 16:04:24.701654 > +++ > /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py:after > 2016-02-01 16:04:30.952126 > @@ -1,8 +1,10 @@ > import logging > > -from django.contrib.sessions.backends.base import CreateError, > SessionBase, UpdateError > +from django.contrib.sessions.backends.base import ( > +CreateError, SessionBase, UpdateError, > +) > from django.core.exceptions import SuspiciousOperation > -from django.db import IntegrityError, router, transaction, DatabaseError > +from django.db import DatabaseError, IntegrityError, router, transaction > from django.utils import timezone > from django.utils.encoding import force_text > from django.utils.functional import cached_property > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/5a408dcd-bc9b-47bf-913c-18b0fb528d24%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Logged out sessions are resurrected by concurrent requests (ticket 21608)
Just click "Details" and then "Console output". You'll find this: + flake8 ./django/contrib/sessions/backends/db.py:91:30: E901 SyntaxError: invalid syntax ERROR: /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py Imports are incorrectly sorted. --- /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py:before 2016-02-01 16:04:24.701654 +++ /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py:after 2016-02-01 16:04:30.952126 @@ -1,8 +1,10 @@ import logging -from django.contrib.sessions.backends.base import CreateError, SessionBase, UpdateError +from django.contrib.sessions.backends.base import ( +CreateError, SessionBase, UpdateError, +) from django.core.exceptions import SuspiciousOperation -from django.db import IntegrityError, router, transaction, DatabaseError +from django.db import DatabaseError, IntegrityError, router, transaction from django.utils import timezone from django.utils.encoding import force_text from django.utils.functional import cached_property -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CALC3Kadknk4-8N4CPPNC3_40rwQrSBrevqkKr9LE%2BswLMKG-3A%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: Logged out sessions are resurrected by concurrent requests (ticket 21608)
Thanks for the feedback! I have updated the PR, can someone have a look at it again? I noticed that there where failing checks (flake8, isort) but it does not say why that it, do I need to fix something? Cheers Tore Lundqvist Den fredag 29 januari 2016 kl. 15:20:11 UTC+1 skrev Tore Lundqvist: > > Hi, everyone! > > I confirmed this (21608) non critical security bug a while ago and have > sense then made a unit test and a fix for it. > I have not gotten any feedback on my PR yet, is there something more I > need to do to have someone look at this? > > Best Regards > Tore Lundqvist > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/438eb540-cf30-4858-85ed-bf18ec275075%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
