Re: contrib.staticfiles and runserver

2010-10-28 Thread Carl Meyer
On Oct 28, 9:45 pm, SmileyChris  wrote:
> My suggestion is that StaticFilesHandler only does its magic if
> 'django.contrib.staticfiles' is found in INSTALLED_APPS. Does that
> sound acceptable?

That seems like a very reasonable opt-in approach that solves the
backwards-compatibility problem. +1

Carl

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.



Re: contrib.staticfiles and runserver

2010-10-28 Thread Russell Keith-Magee
On Fri, Oct 29, 2010 at 9:45 AM, SmileyChris  wrote:
> It's cool that runserver takes away the hassle of needing to add in
> your static url (is this documented? I didn't find it in my skim) but
> doing it by default seems pretty backwards incompatible, even if we
> are just talking about the dev server.
>
> My suggestion is that StaticFilesHandler only does its magic if
> 'django.contrib.staticfiles' is found in INSTALLED_APPS. Does that
> sound acceptable?

A related ticket: http://code.djangoproject.com/ticket/14582

Yours,
Russ Magee %-)

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.



Re: contrib.staticfiles and runserver

2010-10-28 Thread SmileyChris
On Oct 29, 2:45 pm, SmileyChris  wrote:
> doing it by default seems pretty backwards incompatible, even if we

I was a bit terse, let me expand.
STATICFILES_URL defaults to '/static/'. The StaticFilesHandler (which
is now what is used by runserver) swallows requests to this url.

Yeah, that's about it. Easy to solve for my case (since I was just
using django-staticfiles anyway, I just needed to set
STATICFILES_DIRS) but still was a few minutes of head-scratching as to
what was going wrong.

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.