Re: rev 7920 fresh checkout fails tests?

2008-07-14 Thread Matt Wilson

On Jul 13, 11:50 pm, "Russell Keith-Magee" <[EMAIL PROTECTED]>
wrote:
> Looking at the failures you are getting, it looks like you might not
> have a completely clean checkout. At least some of the failures appear
> to be due to the recently added python 2.3 compatibility
> implementation of sorted(), and the tests of that function.

I figured the problem and it was in my setup.  I'm using virtualenv,
and I forgot to rerun python setup.py install after I checked out
7920.  So, the installed version of django was an older revision, and
itercompat.sorted wasn't defined.

Whoops!

Thanks to everyone for the help.

Matt
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---



Re: rev 7920 fresh checkout fails tests?

2008-07-14 Thread Karen Tracey
On Mon, Jul 14, 2008 at 12:57 AM, Russell Keith-Magee <
[EMAIL PROTECTED]> wrote:

>
> On Mon, Jul 14, 2008 at 12:25 PM, Karen Tracey <[EMAIL PROTECTED]> wrote:
> >
> > Speaking of 2.3 compatibility, the tests don't run for me on 2.3 (which I
> > just installed for testing purposes).  I get:
> ...
> > cmd += ''.join(' %s' % arg for arg in args)
> >  ^
> > SyntaxError: invalid syntax
>
> Generator syntax was added in Python 2.4. I've corrected this in
> [7921]. Thanks for the report, Karen.
>

Thanks, got farther but I ran into a couple of more problems which I
describe in ticket  #7745.

Karen

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---



Re: rev 7920 fresh checkout fails tests?

2008-07-13 Thread Russell Keith-Magee

On Mon, Jul 14, 2008 at 12:25 PM, Karen Tracey <[EMAIL PROTECTED]> wrote:
>
> Speaking of 2.3 compatibility, the tests don't run for me on 2.3 (which I
> just installed for testing purposes).  I get:
...
> cmd += ''.join(' %s' % arg for arg in args)
>  ^
> SyntaxError: invalid syntax

Generator syntax was added in Python 2.4. I've corrected this in
[7921]. Thanks for the report, Karen.

Yours
Russ Magee %-)

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---



Re: rev 7920 fresh checkout fails tests?

2008-07-13 Thread Waylan Limberg

On Mon, Jul 14, 2008 at 12:25 AM, Karen Tracey <[EMAIL PROTECTED]> wrote:
[snip]
>   File "D:\u\kmt\django\trunk\tests\regressiontests\admin_scripts\tests.py",
> line 56
> cmd += ''.join(' %s' % arg for arg in args)
>  ^
> SyntaxError: invalid syntax
>
> (the caret points to the 'r' in 'for' in fixed-pitch font)
>
> Same django checkout works if I just use python 2.5.1 instead.  Is this new
> syntax not supported by 2.3?
>

It would appear so:

Python 2.3.4 (#1, Nov 20 2007, 15:18:15)
[GCC 3.4.6 20060404 (Red Hat 3.4.6-9)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> [a for a in ['1','2','3']]
['1', '2', '3']
>>> ''.join(a for a in ['1','2','3'])
  File "", line 1
''.join(a for a in ['1','2','3'])
^
SyntaxError: invalid syntax
>>> ''.join([a for a in ['1','2','3']])
'123'

However in 2.4:

Python 2.4.3 (#3, Jun  8 2007, 04:52:26)
[GCC 3.4.6 20060404 (Red Hat 3.4.6-8)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> ''.join(a for a in ['1','2','3'])
'123'
>>> ''.join([a for a in ['1','2','3']])
'123'





-- 

Waylan Limberg
[EMAIL PROTECTED]

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---



Re: rev 7920 fresh checkout fails tests?

2008-07-13 Thread Karen Tracey
On Sun, Jul 13, 2008 at 11:50 PM, Russell Keith-Magee <
[EMAIL PROTECTED]> wrote:

>
> On Mon, Jul 14, 2008 at 10:55 AM, Matt Wilson <[EMAIL PROTECTED]> wrote:
> >
> > I'm trying to figure out if I'm running the tests incorrectly, or if
> > there are really are failed tests in the revision.
>
> I'm not seeing any failure in my checkout of [7920].
>

The tests run for me as well on r7920.


>
> Looking at the failures you are getting, it looks like you might not
> have a completely clean checkout. At least some of the failures appear
> to be due to the recently added python 2.3 compatibility
> implementation of sorted(), and the tests of that function.
>

Speaking of 2.3 compatibility, the tests don't run for me on 2.3 (which I
just installed for testing purposes).  I get:

D:\u\kmt\django\trunk\tests>d:\bin\Python2.3.5\python.exe runtests.py
--settings=testsettings
Traceback (most recent call last):
  File "runtests.py", line 183, in ?
django_tests(int(options.verbosity), options.interactive, args)
  File "runtests.py", line 153, in django_tests
failures = run_tests(test_labels, verbosity=verbosity,
interactive=interactive, extra_tests=extra_tests)
  File "d:\u\kmt\django\trunk\django\test\simple.py", line 136, in run_tests
suite.addTest(build_suite(app))
  File "d:\u\kmt\django\trunk\django\test\simple.py", line 59, in
build_suite
test_module = get_tests(app_module)
  File "d:\u\kmt\django\trunk\django\test\simple.py", line 17, in get_tests
test_module = __import__('.'.join(app_path + [TEST_MODULE]), {}, {},
TEST_MODULE)
  File "D:\u\kmt\django\trunk\tests\regressiontests\admin_scripts\tests.py",
line 56
cmd += ''.join(' %s' % arg for arg in args)
 ^
SyntaxError: invalid syntax

(the caret points to the 'r' in 'for' in fixed-pitch font)

Same django checkout works if I just use python 2.5.1 instead.  Is this new
syntax not supported by 2.3?

Karen

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---



Re: rev 7920 fresh checkout fails tests?

2008-07-13 Thread Russell Keith-Magee

On Mon, Jul 14, 2008 at 10:55 AM, Matt Wilson <[EMAIL PROTECTED]> wrote:
>
> I'm trying to figure out if I'm running the tests incorrectly, or if
> there are really are failed tests in the revision.

I'm not seeing any failure in my checkout of [7920].

Looking at the failures you are getting, it looks like you might not
have a completely clean checkout. At least some of the failures appear
to be due to the recently added python 2.3 compatibility
implementation of sorted(), and the tests of that function.

To check - the last function in django.utils.itercompat should be a
naive implementation of sorted(). If that method isn't there, your
checkout isn't complete (or is corrupted in some way). If it is there,
try running 'from django.utils.itercompat import sorted as
compat_sorted', and see what happens.

Yours,
Russ Magee %-)

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~--~~~~--~~--~--~---