[Changeset] r12702 - in django/branches/releases/1.1.X: django/db/models/sql tests/modeltests/many_to_one

[noreply]

Author: russellm
Date: 2010-03-07 01:18:46 -0600 (Sun, 07 Mar 2010)
New Revision: 12702

Modified:
   django/branches/releases/1.1.X/django/db/models/sql/query.py
   django/branches/releases/1.1.X/tests/modeltests/many_to_one/models.py
Log:
[1.1.X] Fixed #12876 -- Corrected a problem with recursive relations under 
deepcopy. Thanks to elachuni for the patch.

Backport of r12700 from trunk.

Modified: django/branches/releases/1.1.X/django/db/models/sql/query.py
===
--- django/branches/releases/1.1.X/django/db/models/sql/query.py
2010-03-07 07:13:55 UTC (rev 12701)
+++ django/branches/releases/1.1.X/django/db/models/sql/query.py
2010-03-07 07:18:46 UTC (rev 12702)
@@ -111,7 +111,7 @@
 return sql % params
 
 def __deepcopy__(self, memo):
-result= self.clone()
+result = self.clone(memo=memo)
 memo[id(self)] = result
 return result
 
@@ -173,7 +173,7 @@
 self.quote_cache[name] = r
 return r
 
-def clone(self, klass=None, **kwargs):
+def clone(self, klass=None, memo=None, **kwargs):
 """
 Creates a copy of the current instance. The 'kwargs' parameter can be
 used by clients to update attributes after copying has taken place.
@@ -198,19 +198,19 @@
 obj.dupe_avoidance = self.dupe_avoidance.copy()
 obj.select = self.select[:]
 obj.tables = self.tables[:]
-obj.where = deepcopy(self.where)
+obj.where = deepcopy(self.where, memo=memo)
 obj.where_class = self.where_class
 if self.group_by is None:
 obj.group_by = None
 else:
 obj.group_by = self.group_by[:]
-obj.having = deepcopy(self.having)
+obj.having = deepcopy(self.having, memo=memo)
 obj.order_by = self.order_by[:]
 obj.low_mark, obj.high_mark = self.low_mark, self.high_mark
 obj.distinct = self.distinct
 obj.select_related = self.select_related
 obj.related_select_cols = []
-obj.aggregates = deepcopy(self.aggregates)
+obj.aggregates = deepcopy(self.aggregates, memo=memo)
 if self.aggregate_select_mask is None:
 obj.aggregate_select_mask = None
 else:
@@ -231,7 +231,7 @@
 obj._extra_select_cache = self._extra_select_cache.copy()
 obj.extra_tables = self.extra_tables
 obj.extra_order_by = self.extra_order_by
-obj.deferred_loading = deepcopy(self.deferred_loading)
+obj.deferred_loading = deepcopy(self.deferred_loading, memo=memo)
 if self.filter_is_sticky and self.used_aliases:
 obj.used_aliases = self.used_aliases.copy()
 else:

Modified: django/branches/releases/1.1.X/tests/modeltests/many_to_one/models.py
===
--- django/branches/releases/1.1.X/tests/modeltests/many_to_one/models.py   
2010-03-07 07:13:55 UTC (rev 12701)
+++ django/branches/releases/1.1.X/tests/modeltests/many_to_one/models.py   
2010-03-07 07:18:46 UTC (rev 12702)
@@ -263,6 +263,13 @@
 >>> Reporter.objects.filter(article__reporter__exact=r).distinct()
 []
 
+# Regression for #12876 -- Model methods that include queries that
+# recursive don't cause recursion depth problems under deepcopy.
+>>> r.cached_query = Article.objects.filter(reporter=r)
+>>> from copy import deepcopy
+>>> deepcopy(r)
+
+
 # Check that implied __exact also works.
 >>> Reporter.objects.filter(article__reporter=r).distinct()
 []

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Changeset] r12701 - in django/trunk: django/db/models tests/regressiontests/multiple_database

[noreply]

Author: russellm
Date: 2010-03-07 01:13:55 -0600 (Sun, 07 Mar 2010)
New Revision: 12701

Modified:
   django/trunk/django/db/models/query.py
   django/trunk/tests/regressiontests/multiple_database/tests.py
Log:
Fixed #13003 -- Ensured that ._state.db is set correctly for select_related() 
queries. Thanks to Alex Gaynor for the report.

Modified: django/trunk/django/db/models/query.py
===
--- django/trunk/django/db/models/query.py  2010-03-07 07:11:22 UTC (rev 
12700)
+++ django/trunk/django/db/models/query.py  2010-03-07 07:13:55 UTC (rev 
12701)
@@ -267,7 +267,7 @@
 for row in compiler.results_iter():
 if fill_cache:
 obj, _ = get_cached_row(self.model, row,
-index_start, max_depth,
+index_start, using=self.db, max_depth=max_depth,
 requested=requested, offset=len(aggregate_select),
 only_load=only_load)
 else:
@@ -279,6 +279,9 @@
 # Omit aggregates in object creation.
 obj = self.model(*row[index_start:aggregate_start])
 
+# Store the source database of the object
+obj._state.db = self.db
+
 for i, k in enumerate(extra_select):
 setattr(obj, k, row[i])
 
@@ -286,9 +289,6 @@
 for i, aggregate in enumerate(aggregate_select):
 setattr(obj, aggregate, row[i+aggregate_start])
 
-# Store the source database of the object
-obj._state.db = self.db
-
 yield obj
 
 def aggregate(self, *args, **kwargs):
@@ -1112,7 +1112,7 @@
 value_annotation = False
 
 
-def get_cached_row(klass, row, index_start, max_depth=0, cur_depth=0,
+def get_cached_row(klass, row, index_start, using, max_depth=0, cur_depth=0,
requested=None, offset=0, only_load=None):
 """
 Helper function that recursively returns an object with the specified
@@ -1126,6 +1126,7 @@
  * row - the row of data returned by the database cursor
  * index_start - the index of the row at which data for this
object is known to start
+ * using - the database alias on which the query is being executed.
  * max_depth - the maximum depth to which a select_related()
relationship should be explored.
  * cur_depth - the current depth in the select_related() tree.
@@ -1170,6 +1171,7 @@
 obj = klass(**dict(zip(init_list, fields)))
 else:
 obj = klass(*fields)
+
 else:
 # Load all fields on klass
 field_count = len(klass._meta.fields)
@@ -1182,6 +1184,10 @@
 else:
 obj = klass(*fields)
 
+# If an object was retrieved, set the database state.
+if obj:
+obj._state.db = using
+
 index_end = index_start + field_count + offset
 # Iterate over each related object, populating any
 # select_related() fields
@@ -1193,8 +1199,8 @@
 else:
 next = None
 # Recursively retrieve the data for the related object
-cached_row = get_cached_row(f.rel.to, row, index_end, max_depth,
-cur_depth+1, next)
+cached_row = get_cached_row(f.rel.to, row, index_end, using,
+max_depth, cur_depth+1, next)
 # If the recursive descent found an object, populate the
 # descriptor caches relevant to the object
 if cached_row:
@@ -1222,8 +1228,8 @@
 continue
 next = requested[f.related_query_name()]
 # Recursively retrieve the data for the related object
-cached_row = get_cached_row(model, row, index_end, max_depth,
-cur_depth+1, next)
+cached_row = get_cached_row(model, row, index_end, using,
+max_depth, cur_depth+1, next)
 # If the recursive descent found an object, populate the
 # descriptor caches relevant to the object
 if cached_row:

Modified: django/trunk/tests/regressiontests/multiple_database/tests.py
===
--- django/trunk/tests/regressiontests/multiple_database/tests.py   
2010-03-07 07:11:22 UTC (rev 12700)
+++ django/trunk/tests/regressiontests/multiple_database/tests.py   
2010-03-07 07:13:55 UTC (rev 12701)
@@ -641,6 +641,20 @@
 val = Book.objects.raw('SELECT id FROM 
"multiple_database_book"').using('other')
 self.assertEqual(map(lambda o: o.pk, val), [dive.pk])
 
+def test_select_related(self):
+"Database assignment is retained if an object is retrieved with 
select_related()"
+# Create a book and author on the other database
+mark = Person.objects.using('other').create(name="Mark Pilgrim")
+dive = Book.objects.using('other').create(title="Dive into Python",
+

[Changeset] r12700 - in django/trunk: django/db/models/sql tests/modeltests/many_to_one

[noreply]

Author: russellm
Date: 2010-03-07 01:11:22 -0600 (Sun, 07 Mar 2010)
New Revision: 12700

Modified:
   django/trunk/django/db/models/sql/query.py
   django/trunk/tests/modeltests/many_to_one/models.py
Log:
Fixed #12876 -- Corrected a problem with recursive relations under deepcopy. 
Thanks to elachuni for the patch.

Modified: django/trunk/django/db/models/sql/query.py
===
--- django/trunk/django/db/models/sql/query.py  2010-03-07 04:06:23 UTC (rev 
12699)
+++ django/trunk/django/db/models/sql/query.py  2010-03-07 07:11:22 UTC (rev 
12700)
@@ -148,7 +148,7 @@
 return sql % params
 
 def __deepcopy__(self, memo):
-result= self.clone()
+result = self.clone(memo=memo)
 memo[id(self)] = result
 return result
 
@@ -199,7 +199,7 @@
 """
 return self.model._meta
 
-def clone(self, klass=None, **kwargs):
+def clone(self, klass=None, memo=None, **kwargs):
 """
 Creates a copy of the current instance. The 'kwargs' parameter can be
 used by clients to update attributes after copying has taken place.
@@ -223,19 +223,19 @@
 obj.dupe_avoidance = self.dupe_avoidance.copy()
 obj.select = self.select[:]
 obj.tables = self.tables[:]
-obj.where = deepcopy(self.where)
+obj.where = deepcopy(self.where, memo=memo)
 obj.where_class = self.where_class
 if self.group_by is None:
 obj.group_by = None
 else:
 obj.group_by = self.group_by[:]
-obj.having = deepcopy(self.having)
+obj.having = deepcopy(self.having, memo=memo)
 obj.order_by = self.order_by[:]
 obj.low_mark, obj.high_mark = self.low_mark, self.high_mark
 obj.distinct = self.distinct
 obj.select_related = self.select_related
 obj.related_select_cols = []
-obj.aggregates = deepcopy(self.aggregates)
+obj.aggregates = deepcopy(self.aggregates, memo=memo)
 if self.aggregate_select_mask is None:
 obj.aggregate_select_mask = None
 else:
@@ -256,7 +256,7 @@
 obj._extra_select_cache = self._extra_select_cache.copy()
 obj.extra_tables = self.extra_tables
 obj.extra_order_by = self.extra_order_by
-obj.deferred_loading = deepcopy(self.deferred_loading)
+obj.deferred_loading = deepcopy(self.deferred_loading, memo=memo)
 if self.filter_is_sticky and self.used_aliases:
 obj.used_aliases = self.used_aliases.copy()
 else:

Modified: django/trunk/tests/modeltests/many_to_one/models.py
===
--- django/trunk/tests/modeltests/many_to_one/models.py 2010-03-07 04:06:23 UTC 
(rev 12699)
+++ django/trunk/tests/modeltests/many_to_one/models.py 2010-03-07 07:11:22 UTC 
(rev 12700)
@@ -263,6 +263,13 @@
 >>> Reporter.objects.filter(article__reporter__exact=r).distinct()
 []
 
+# Regression for #12876 -- Model methods that include queries that
+# recursive don't cause recursion depth problems under deepcopy.
+>>> r.cached_query = Article.objects.filter(reporter=r)
+>>> from copy import deepcopy
+>>> deepcopy(r)
+
+
 # Check that implied __exact also works.
 >>> Reporter.objects.filter(article__reporter=r).distinct()
 []

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13049: debug 500 page incorrectly reports "extends" TemplateDoesNotExist errors.

[Django]

#13049: debug 500 page incorrectly reports "extends" TemplateDoesNotExist 
errors.
--+-
  Reporter:  jabapyth | Owner:  jabapyth
 
Status:  closed   | Milestone:  
 
 Component:  Template system  |   Version:  SVN 
 
Resolution:  duplicate|  Keywords:  template, error, debug, 
templatedoesnotexist, templatesyntaxerror
 Stage:  Unreviewed   | Has_patch:  1   
 
Needs_docs:  0|   Needs_tests:  0   
 
Needs_better_patch:  0|  
--+-
Changes (by kmtracey):

  * status:  new => closed
  * needs_better_patch:  => 0
  * resolution:  => duplicate
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 Sounds like #12787

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #13049: debug 500 page incorrectly reports "extends" TemplateDoesNotExist errors.

[Django]

#13049: debug 500 page incorrectly reports "extends" TemplateDoesNotExist 
errors.
---+
 Reporter:  jabapyth   
|   Owner:  jabapyth  
   Status:  new
|   Milestone:
Component:  Template system
| Version:  SVN   
 Keywords:  template, error, debug, templatedoesnotexist, templatesyntaxerror  
|   Stage:  Unreviewed
Has_patch:  1  
|  
---+
 There are two parts to this solution (because there are two things
 preventing correct report of errors).
 1. originally the 500 page showed a TemplateSyntaxError when a
 TemplateDoesNotExist error was being fired (due to an improper wrapping in
 debug.py).
 2. once that was fixed, the ExtendsNode assumed that if a
 TemplateDoesNotExist error was thrown while getting its parent template,
 its parent could not be found. As you can imagine, this is not the case if
 the parent template extends (or includes) a template that does not exist.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12212: inclusion_tag behavior on variable not in context is inconsistent

[Django]

#12212: inclusion_tag behavior on variable not in context is inconsistent
--+-
  Reporter:  Leo  | Owner:  Leo
Status:  assigned | Milestone:  1.2
 Component:  Template system  |   Version:  SVN
Resolution:   |  Keywords: 
 Stage:  Accepted | Has_patch:  1  
Needs_docs:  0|   Needs_tests:  0  
Needs_better_patch:  0|  
--+-
Changes (by Leo):

  * owner:  nobody => Leo
  * status:  new => assigned
  * has_patch:  0 => 1
  * milestone:  => 1.2

Comment:

 There's two ways I could see of solving this: document the fact that they
 do this or fix the behavior. The former is relatively simple if the core
 committers decide its better so the attached patch does the latter.

 Along the way I noticed that `simple_tag` has the same issue and fixed it
 as well. The patch includes doc changes and sets up tests for `simple_tag`
 and `inclusion_tag`.

 Adding this for consideration into 1.2.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12858: Callable default on DateField + custom date format = widget._has_changed always true, forms fail to validate

[Django]

#12858: Callable default on DateField + custom date format = widget._has_changed
always true, forms fail to validate
---+
  Reporter:  camillo   | Owner:  nobody  
Status:  closed| Milestone:  1.2 
 Component:  Forms |   Version:  SVN 
Resolution:  fixed |  Keywords:  dateinput format
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  1   
Needs_better_patch:  0 |  
---+
Comment (by jkocherhans):

 Actually, nevermind. 12698-backport.diff probably is the right fix because
 I don't think force_unicode on a datetime, date, or, time will use a
 locale-specific format. If I'm wrong about that, the fix applied to 1.1.X
 is incorrect.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Changeset] r12699 - in django/branches/releases/1.1.X: . django/forms tests/regressiontests/forms

[noreply]

Author: jkocherhans
Date: 2010-03-06 22:06:23 -0600 (Sat, 06 Mar 2010)
New Revision: 12699

Modified:
   django/branches/releases/1.1.X/
   django/branches/releases/1.1.X/django/forms/widgets.py
   django/branches/releases/1.1.X/tests/regressiontests/forms/widgets.py
Log:
[1.1.X] Fixed #12858. DateTime related widgets now handle custom formats 
properly in _has_changed. Backport of r12698 from trunk.



Property changes on: django/branches/releases/1.1.X
___
Name: svnmerge-integrated
   - 
/django/trunk:1-11500,11523,11527-11528,11531-11552,11554,11577,11579-11581,11588-11589,11591-11592,11596-11599,11601-11617,11619-11626,11628-11635,11637-11638,11643-11644,11648-11653,11656,11670,11678,11681,11684,11686,11688,11691,11693,11695,11697,11699,11701,11703,11705,11707,11714,11719,11732,11734,11740,11748,11751,11753,11756,11760,11800,11802,11808,11815,11817,11820,11822,11824,11826,11828,11831,11833,11835,11837,11839,11841,11844,11857,11864,11874,11876,11878,11885,11898,11901,11905,11909,11912,11914,11917,11938,11953,11961,11977,11979,11984,11986,11988,11990,11992,11994,11996,11998,12001,12004,12006,12011,12022,12024,12044-12045,12048,12054-12056,12059,12064,12066,12068,12070,12079,12086,12088,12104,12118,12132,12137-12138,12140-12141,12144,12150-12152,12220-12221,12229,12249,12253,12276,12282,12284,12293,12313,12317-12324,12333,12341,12343,12346,12353,12362,12379,12384,12398,12405,12408-12411,12419-12420,12423,12425-12426,12429,12434,12436,12439-12442,12448,12457,12461-12464,12467,12473,12475,12490,12492,12497-12498,12502,12513,12515-12516,12518,12523,12526,12528,12533,12535,12537,12539,12541,12548,12553,12556,12558-12560,12562,12567,12569-12570,12573,12576,12579,12581,12584,12616,12621-12622,12631,12648,12650,12652,12659,12661,12676,12679,12681,12683,12688,12696
   + 
/django/trunk:1-11500,11523,11527-11528,11531-11552,11554,11577,11579-11581,11588-11589,11591-11592,11596-11599,11601-11617,11619-11626,11628-11635,11637-11638,11643-11644,11648-11653,11656,11670,11678,11681,11684,11686,11688,11691,11693,11695,11697,11699,11701,11703,11705,11707,11714,11719,11732,11734,11740,11748,11751,11753,11756,11760,11800,11802,11808,11815,11817,11820,11822,11824,11826,11828,11831,11833,11835,11837,11839,11841,11844,11857,11864,11874,11876,11878,11885,11898,11901,11905,11909,11912,11914,11917,11938,11953,11961,11977,11979,11984,11986,11988,11990,11992,11994,11996,11998,12001,12004,12006,12011,12022,12024,12044-12045,12048,12054-12056,12059,12064,12066,12068,12070,12079,12086,12088,12104,12118,12132,12137-12138,12140-12141,12144,12150-12152,12220-12221,12229,12249,12253,12276,12282,12284,12293,12313,12317-12324,12333,12341,12343,12346,12353,12362,12379,12384,12398,12405,12408-12411,12419-12420,12423,12425-12426,12429,12434,12436,12439-12442,12448,12457,12461-12464,12467,12473,12475,12490,12492,12497-12498,12502,12513,12515-12516,12518,12523,12526,12528,12533,12535,12537,12539,12541,12548,12553,12556,12558-12560,12562,12567,12569-12570,12573,12576,12579,12581,12584,12616,12621-12622,12631,12648,12650,12652,12659,12661,12676,12679,12681,12683,12688,12696,12698

Modified: django/branches/releases/1.1.X/django/forms/widgets.py
===
--- django/branches/releases/1.1.X/django/forms/widgets.py  2010-03-07 
03:33:07 UTC (rev 12698)
+++ django/branches/releases/1.1.X/django/forms/widgets.py  2010-03-07 
04:06:23 UTC (rev 12699)
@@ -16,7 +16,8 @@
 from django.utils.encoding import StrAndUnicode, force_unicode
 from django.utils.safestring import mark_safe
 from django.utils import datetime_safe
-from datetime import time
+import time
+import datetime
 from util import flatatt
 from urlparse import urljoin
 
@@ -319,6 +320,14 @@
 return super(DateInput, self).render(name, value, attrs)
 
 def _has_changed(self, initial, data):
+# If our field has show_hidden_initial=True, initial will be a string
+# formatted by HiddenInput using formats.localize_input, which is not
+# necessarily the format used for this widget. Attempt to convert it.
+try:
+input_format = '%Y-%m-%d'
+initial = datetime.date(*time.strptime(initial, '%Y-%m-%d')[:3])
+except (TypeError, ValueError):
+pass
 return super(DateInput, 
self)._has_changed(self._format_value(initial), data)
 
 class DateTimeInput(Input):
@@ -343,6 +352,14 @@
 return super(DateTimeInput, self).render(name, value, attrs)
 
 def _has_changed(self, initial, data):
+# If our field has show_hidden_initial=True, initial will be a string
+# formatted by HiddenInput using formats.localize_input, which is not
+# necessarily the format used for this widget. Attempt to convert it.
+try:
+input_format = '%Y-%m-%d %H:%M:%S'
+initial = datetime.datetime(*time.strptime(initial, 
input_format)[:6])
+except (Typ

Re: [Django] #12116: needs_context for template filters

[Django]

#12116: needs_context for template filters
--+-
  Reporter:  Suor | Owner:  nobody  
 
Status:  new  | Milestone:  
 
 Component:  Template system  |   Version:  SVN 
 
Resolution:   |  Keywords:  template filters, 
context
 Stage:  Accepted | Has_patch:  1   
 
Needs_docs:  0|   Needs_tests:  1   
 
Needs_better_patch:  1|  
--+-
Comment (by subsume):

 one nag. can we change this to 'takes_context' to fit with templatetag
 version.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12427: cmemcache has been retired / add support for cmemcached

[Django]

#12427: cmemcache has been retired / add support for cmemcached
-+--
  Reporter:  UloPe   | Owner:  otherjacob
Status:  assigned| Milestone:
 Component:  Cache system|   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by otherjacob):

  * owner:  nobody => otherjacob
  * status:  new => assigned

Comment:

 Per the discussion on the mailing list, I'll be adding a
 PendingDeprecationWarning for 1.2, then working on a more involved
 solution + DeprecationWarning in 1.3, then removing it entirely (with
 pylibmc added on) for 1.4

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Changeset] r12698 - in django/trunk: django/forms tests/regressiontests/forms

[noreply]

Author: jkocherhans
Date: 2010-03-06 21:33:07 -0600 (Sat, 06 Mar 2010)
New Revision: 12698

Modified:
   django/trunk/django/forms/widgets.py
   django/trunk/tests/regressiontests/forms/widgets.py
Log:
Fixed #12858. DateTime related widgets now handle custom formats properly in 
_has_changed. Thanks for the initial patch, camillo.

Modified: django/trunk/django/forms/widgets.py
===
--- django/trunk/django/forms/widgets.py2010-03-07 01:52:48 UTC (rev 
12697)
+++ django/trunk/django/forms/widgets.py2010-03-07 03:33:07 UTC (rev 
12698)
@@ -10,8 +10,10 @@
 from django.utils.translation import ugettext
 from django.utils.encoding import StrAndUnicode, force_unicode
 from django.utils.safestring import mark_safe
-from django.utils import datetime_safe, formats
-from datetime import time
+from django.utils import formats
+import time
+import datetime
+from django.utils.formats import get_format
 from util import flatatt
 from urlparse import urljoin
 
@@ -313,6 +315,14 @@
 return super(DateInput, self).render(name, value, attrs)
 
 def _has_changed(self, initial, data):
+# If our field has show_hidden_initial=True, initial will be a string
+# formatted by HiddenInput using formats.localize_input, which is not
+# necessarily the format used for this widget. Attempt to convert it.
+try:
+input_format = get_format('DATE_INPUT_FORMATS')[0]
+initial = datetime.date(*time.strptime(initial, input_format)[:3])
+except (TypeError, ValueError):
+pass
 return super(DateInput, 
self)._has_changed(self._format_value(initial), data)
 
 class DateTimeInput(Input):
@@ -336,6 +346,14 @@
 return super(DateTimeInput, self).render(name, value, attrs)
 
 def _has_changed(self, initial, data):
+# If our field has show_hidden_initial=True, initial will be a string
+# formatted by HiddenInput using formats.localize_input, which is not
+# necessarily the format used for this widget. Attempt to convert it.
+try:
+input_format = get_format('DATETIME_INPUT_FORMATS')[0]
+initial = datetime.datetime(*time.strptime(initial, 
input_format)[:6])
+except (TypeError, ValueError):
+pass
 return super(DateTimeInput, 
self)._has_changed(self._format_value(initial), data)
 
 class TimeInput(Input):
@@ -359,6 +377,14 @@
 return super(TimeInput, self).render(name, value, attrs)
 
 def _has_changed(self, initial, data):
+# If our field has show_hidden_initial=True, initial will be a string
+# formatted by HiddenInput using formats.localize_input, which is not
+# necessarily the format used for this  widget. Attempt to convert it.
+try:
+input_format = get_format('TIME_INPUT_FORMATS')[0]
+initial = datetime.time(*time.strptime(initial, input_format)[3:6])
+except (TypeError, ValueError):
+pass
 return super(TimeInput, 
self)._has_changed(self._format_value(initial), data)
 
 class CheckboxInput(Widget):

Modified: django/trunk/tests/regressiontests/forms/widgets.py
===
--- django/trunk/tests/regressiontests/forms/widgets.py 2010-03-07 01:52:48 UTC 
(rev 12697)
+++ django/trunk/tests/regressiontests/forms/widgets.py 2010-03-07 03:33:07 UTC 
(rev 12698)
@@ -3,6 +3,7 @@
 >>> from django.forms import *
 >>> from django.forms.widgets import RadioFieldRenderer
 >>> from django.utils.safestring import mark_safe
+>>> from django.utils import formats
 >>> import datetime
 >>> import time
 >>> import re
@@ -1149,7 +1150,15 @@
 >>> w._has_changed(d, '17/09/2007 12:51')
 False
 
+Make sure a custom format works with _has_changed. The hidden input will use
+format.localize_input to display the initial value.
+>>> data = datetime.datetime(2010, 3, 6, 12, 0, 0)
+>>> custom_format = '%d.%m.%Y %H:%M'
+>>> w = DateTimeInput(format=custom_format)
+>>> w._has_changed(formats.localize_input(data), data.strftime(custom_format))
+False
 
+
 # DateInput ###
 
 >>> w = DateInput()
@@ -1182,6 +1191,15 @@
 >>> w._has_changed(d, '17/09/2007')
 False
 
+Make sure a custom format works with _has_changed. The hidden input will use
+format.localize_input to display the initial value.
+>>> data = datetime.date(2010, 3, 6)
+>>> custom_format = '%d.%m.%Y'
+>>> w = DateInput(format=custom_format)
+>>> w._has_changed(formats.localize_input(data), data.strftime(custom_format))
+False
+
+
 # TimeInput ###
 
 >>> w = TimeInput()
@@ -1217,6 +1235,15 @@
 >>> w._has_changed(t, '12:51')
 False
 
+Make sure a custom format works with _has_changed. The hidden input will use
+format.localize_input to display the initial value.
+>>> data = datetime.time

[Changeset] r12697 - in django/branches/releases/1.1.X: . django/db/models/fields tests/regressiontests/model_fields

[noreply]

Author: jkocherhans
Date: 2010-03-06 19:52:48 -0600 (Sat, 06 Mar 2010)
New Revision: 12697

Modified:
   django/branches/releases/1.1.X/
   django/branches/releases/1.1.X/django/db/models/fields/__init__.py
   django/branches/releases/1.1.X/tests/regressiontests/model_fields/tests.py
Log:
[1.1.X] Fixed #12913. Fields with choices now respect show_hidden_initial as a 
keyword argument to formfield. Backport of r12696 from trunk.



Property changes on: django/branches/releases/1.1.X
___
Name: svnmerge-integrated
   - 
/django/trunk:1-11500,11523,11527-11528,11531-11552,11554,11577,11579-11581,11588-11589,11591-11592,11596-11599,11601-11617,11619-11626,11628-11635,11637-11638,11643-11644,11648-11653,11656,11670,11678,11681,11684,11686,11688,11691,11693,11695,11697,11699,11701,11703,11705,11707,11714,11719,11732,11734,11740,11748,11751,11753,11756,11760,11800,11802,11808,11815,11817,11820,11822,11824,11826,11828,11831,11833,11835,11837,11839,11841,11844,11857,11864,11874,11876,11878,11885,11898,11901,11905,11909,11912,11914,11917,11938,11953,11961,11977,11979,11984,11986,11988,11990,11992,11994,11996,11998,12001,12004,12006,12011,12022,12024,12044-12045,12048,12054-12056,12059,12064,12066,12068,12070,12079,12086,12088,12104,12118,12132,12137-12138,12140-12141,12144,12150-12152,12220-12221,12229,12249,12253,12276,12282,12284,12293,12313,12317-12324,12333,12341,12343,12346,12353,12362,12379,12384,12398,12405,12408-12411,12419-12420,12423,12425-12426,12429,12434,12436,12439-12442,12448,12457,12461-12464,12467,12473,12475,12490,12492,12497-12498,12502,12513,12515-12516,12518,12523,12526,12528,12533,12535,12537,12539,12541,12548,12553,12556,12558-12560,12562,12567,12569-12570,12573,12576,12579,12581,12584,12616,12621-12622,12631,12648,12650,12652,12659,12661,12676,12679,12681,12683,12688
   + 
/django/trunk:1-11500,11523,11527-11528,11531-11552,11554,11577,11579-11581,11588-11589,11591-11592,11596-11599,11601-11617,11619-11626,11628-11635,11637-11638,11643-11644,11648-11653,11656,11670,11678,11681,11684,11686,11688,11691,11693,11695,11697,11699,11701,11703,11705,11707,11714,11719,11732,11734,11740,11748,11751,11753,11756,11760,11800,11802,11808,11815,11817,11820,11822,11824,11826,11828,11831,11833,11835,11837,11839,11841,11844,11857,11864,11874,11876,11878,11885,11898,11901,11905,11909,11912,11914,11917,11938,11953,11961,11977,11979,11984,11986,11988,11990,11992,11994,11996,11998,12001,12004,12006,12011,12022,12024,12044-12045,12048,12054-12056,12059,12064,12066,12068,12070,12079,12086,12088,12104,12118,12132,12137-12138,12140-12141,12144,12150-12152,12220-12221,12229,12249,12253,12276,12282,12284,12293,12313,12317-12324,12333,12341,12343,12346,12353,12362,12379,12384,12398,12405,12408-12411,12419-12420,12423,12425-12426,12429,12434,12436,12439-12442,12448,12457,12461-12464,12467,12473,12475,12490,12492,12497-12498,12502,12513,12515-12516,12518,12523,12526,12528,12533,12535,12537,12539,12541,12548,12553,12556,12558-12560,12562,12567,12569-12570,12573,12576,12579,12581,12584,12616,12621-12622,12631,12648,12650,12652,12659,12661,12676,12679,12681,12683,12688,12696

Modified: django/branches/releases/1.1.X/django/db/models/fields/__init__.py
===
--- django/branches/releases/1.1.X/django/db/models/fields/__init__.py  
2010-03-07 01:50:58 UTC (rev 12696)
+++ django/branches/releases/1.1.X/django/db/models/fields/__init__.py  
2010-03-07 01:52:48 UTC (rev 12697)
@@ -339,7 +339,7 @@
 for k in kwargs.keys():
 if k not in ('coerce', 'empty_value', 'choices', 'required',
  'widget', 'label', 'initial', 'help_text',
- 'error_messages'):
+ 'error_messages', 'show_hidden_initial'):
 del kwargs[k]
 defaults.update(kwargs)
 return form_class(**defaults)

Modified: 
django/branches/releases/1.1.X/tests/regressiontests/model_fields/tests.py
===
--- django/branches/releases/1.1.X/tests/regressiontests/model_fields/tests.py  
2010-03-07 01:50:58 UTC (rev 12696)
+++ django/branches/releases/1.1.X/tests/regressiontests/model_fields/tests.py  
2010-03-07 01:52:48 UTC (rev 12697)
@@ -26,6 +26,20 @@
 TwoImageFieldTests
 
 
+class BasicFieldTests(django.test.TestCase):
+def test_show_hidden_initial(self):
+"""
+Regression test for #12913. Make sure fields with choices respect
+show_hidden_initial as a kwarg to models.Field.formfield()
+"""
+choices = [(0, 0), (1, 1)]
+model_field = models.Field(choices=choices)
+form_field = model_field.formfield(show_hidden_initial=True)
+self.assertTrue(form_field.show_hidden_initial)
+
+form_field = model_field.formfield(show_hidden_initial=False)
+self.assertFalse(form_fiel

Re: [Django] #12913: Field.formfield() skips show_hidden_input parameter

[Django]

#12913: Field.formfield() skips show_hidden_input parameter
---+
  Reporter:  semenov   | Owner:  nobody
Status:  closed| Milestone:  1.2   
 Component:  Forms |   Version:  SVN   
Resolution:  fixed |  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  1 
Needs_better_patch:  0 |  
---+
Changes (by jkocherhans):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 Fixed by r12696.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Changeset] r12696 - in django/trunk: django/db/models/fields tests/regressiontests/model_fields

[noreply]

Author: jkocherhans
Date: 2010-03-06 19:50:58 -0600 (Sat, 06 Mar 2010)
New Revision: 12696

Modified:
   django/trunk/django/db/models/fields/__init__.py
   django/trunk/tests/regressiontests/model_fields/tests.py
Log:
Fixed #12913. Fields with choices now respect show_hidden_initial as a keyword 
argument to formfield. Thanks, semenov.

Modified: django/trunk/django/db/models/fields/__init__.py
===
--- django/trunk/django/db/models/fields/__init__.py2010-03-07 00:52:11 UTC 
(rev 12695)
+++ django/trunk/django/db/models/fields/__init__.py2010-03-07 01:50:58 UTC 
(rev 12696)
@@ -462,7 +462,7 @@
 for k in kwargs.keys():
 if k not in ('coerce', 'empty_value', 'choices', 'required',
  'widget', 'label', 'initial', 'help_text',
- 'error_messages'):
+ 'error_messages', 'show_hidden_initial'):
 del kwargs[k]
 defaults.update(kwargs)
 return form_class(**defaults)

Modified: django/trunk/tests/regressiontests/model_fields/tests.py
===
--- django/trunk/tests/regressiontests/model_fields/tests.py2010-03-07 
00:52:11 UTC (rev 12695)
+++ django/trunk/tests/regressiontests/model_fields/tests.py2010-03-07 
01:50:58 UTC (rev 12696)
@@ -26,6 +26,20 @@
 TwoImageFieldTests
 
 
+class BasicFieldTests(django.test.TestCase):
+def test_show_hidden_initial(self):
+"""
+Regression test for #12913. Make sure fields with choices respect
+show_hidden_initial as a kwarg to models.Field.formfield()
+"""
+choices = [(0, 0), (1, 1)]
+model_field = models.Field(choices=choices)
+form_field = model_field.formfield(show_hidden_initial=True)
+self.assertTrue(form_field.show_hidden_initial)
+
+form_field = model_field.formfield(show_hidden_initial=False)
+self.assertFalse(form_field.show_hidden_initial)
+
 class DecimalFieldTests(django.test.TestCase):
 def test_to_python(self):
 f = models.DecimalField(max_digits=4, decimal_places=2)

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11675: [patch] Support new memcached wrapper pylibmc

[Django]

#11675: [patch] Support new memcached wrapper pylibmc
--+-
  Reporter:  pipp...@yahoo.co.jp  | Owner:  otherjacob  
  
Status:  assigned | Milestone:  1.2 
  
 Component:  Cache system |   Version:  SVN 
  
Resolution:   |  Keywords:  cache pylibmc 
memcached.py
 Stage:  Accepted | Has_patch:  0   
  
Needs_docs:  0|   Needs_tests:  0   
  
Needs_better_patch:  0|  
--+-
Changes (by russellm):

  * stage:  Design decision needed => Accepted
  * milestone:  => 1.2

Comment:

 Putting back to 1.2; there has been some discussion about including a
 partial fix in 1.2 that would start the deprecation process for cmemcache.
 That won't close this ticket, but it should be addressed before 1.2 final.

 To that end, the mailing list discussion also resolved the design
 decision: we're going to add a new backend for pylibmc.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Changeset] r12695 - django/branches/releases/1.1.X/docs/topics

[noreply]

Author: ubernostrum
Date: 2010-03-06 18:52:11 -0600 (Sat, 06 Mar 2010)
New Revision: 12695

Modified:
   django/branches/releases/1.1.X/docs/topics/email.txt
Log:
[1.1.X] Fixed #13048: Corrected typo in email documentation. Backport of 
[12694] from trunk.

Modified: django/branches/releases/1.1.X/docs/topics/email.txt
===
--- django/branches/releases/1.1.X/docs/topics/email.txt2010-03-07 
00:51:29 UTC (rev 12694)
+++ django/branches/releases/1.1.X/docs/topics/email.txt2010-03-07 
00:52:11 UTC (rev 12695)
@@ -354,11 +354,11 @@
 Testing e-mail sending
 --
 
-The are times when you do not want Django to send e-mails at all. For example,
-while developing a website, you probably don't want to send out thousands of
-e-mails -- but you may want to validate that e-mails will be sent to the right
-people under the right conditions, and that those e-mails will contain the
-correct content.
+There are times when you do not want Django to send e-mails at
+all. For example, while developing a website, you probably don't want
+to send out thousands of e-mails -- but you may want to validate that
+e-mails will be sent to the right people under the right conditions,
+and that those e-mails will contain the correct content.
 
 The easiest way to test your project's use of e-mail is to use a "dumb" e-mail
 server that receives the e-mails locally and displays them to the terminal,

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Changeset] r12694 - django/trunk/docs/topics

[noreply]

Author: ubernostrum
Date: 2010-03-06 18:51:29 -0600 (Sat, 06 Mar 2010)
New Revision: 12694

Modified:
   django/trunk/docs/topics/email.txt
Log:
Fixed #13048: Corrected typo in email documentation.

Modified: django/trunk/docs/topics/email.txt
===
--- django/trunk/docs/topics/email.txt  2010-03-06 19:51:29 UTC (rev 12693)
+++ django/trunk/docs/topics/email.txt  2010-03-07 00:51:29 UTC (rev 12694)
@@ -567,11 +567,11 @@
 Testing e-mail sending
 ==
 
-The are times when you do not want Django to send e-mails at all. For example,
-while developing a website, you probably don't want to send out thousands of
-e-mails -- but you may want to validate that e-mails will be sent to the right
-people under the right conditions, and that those e-mails will contain the
-correct content.
+There are times when you do not want Django to send e-mails at
+all. For example, while developing a website, you probably don't want
+to send out thousands of e-mails -- but you may want to validate that
+e-mails will be sent to the right people under the right conditions,
+and that those e-mails will contain the correct content.
 
 The easiest way to test your project's use of e-mail is to use the ``console``
 e-mail backend. This backend redirects all e-mail to stdout, allowing you to

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11778: Patch to increase performance of escapejs

[Django]

#11778: Patch to increase performance of escapejs
--+-
  Reporter:  josephdrose  | Owner:  josephdrose
Status:  new  | Milestone: 
 Component:  Template system  |   Version:  SVN
Resolution:   |  Keywords: 
 Stage:  Accepted | Has_patch:  1  
Needs_docs:  0|   Needs_tests:  0  
Needs_better_patch:  0|  
--+-
Changes (by jkocherhans):

  * milestone:  1.2 =>

Comment:

 This isn't critical for the first 1.2 release. Bumping from the milestone.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11158: get_image_dimensions very slow after 1 call

[Django]

#11158: get_image_dimensions very slow after 1 call
-+--
  Reporter:  kua | Owner:  SAn  
  
Status:  new | Milestone:  1.2  
  
 Component:  Core framework  |   Version:  SVN  
  
Resolution:  |  Keywords:  get_image_dimensions, 
field, save, slow
 Stage:  Accepted| Has_patch:  1
  
Needs_docs:  0   |   Needs_tests:  0
  
Needs_better_patch:  1   |  
-+--
Changes (by jkocherhans):

  * needs_tests:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12247: update on empty queryset in which the update kwargs refer to inherited columns update all rows of base table

[Django]

#12247: update on empty queryset in which the update kwargs refer to inherited
columns update all rows of base table
---+
  Reporter:  jsmullyan | Owner:  matiasb
Status:  assigned  | Milestone:  1.2
 Component:  Database layer (models, ORM)  |   Version:  1.1
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  1  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Comment (by jkocherhans):

 The patch looks pretty good, and seems to fix the problem, but I wonder if
 the bug isn't another level down. This seems to be triggered when
 `self.related_ids` is `[]`, so we're essentially calling
 `query.add_filter(('pk__in', []))`. It seems like `pk__in=[]` should
 essentially be a no-op, but it sounds like it's actually selecting
 everything.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12986: SelectDateField doesn't repost data when USE_L10N = True and LANGUAGE_CODE = 'nl'

[Django]

#12986: SelectDateField doesn't repost data when USE_L10N = True and 
LANGUAGE_CODE
= 'nl'
---+
  Reporter:  w...@go2people.nl  | Owner:  nobody  
Status:  new   | Milestone:  1.2 
 Component:  Forms |   Version:  1.2-beta
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  1   
Needs_better_patch:  0 |  
---+
Changes (by walteralini):

  * owner:  walteralini => nobody
  * status:  assigned => new

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12986: SelectDateField doesn't repost data when USE_L10N = True and LANGUAGE_CODE = 'nl'

[Django]

#12986: SelectDateField doesn't repost data when USE_L10N = True and 
LANGUAGE_CODE
= 'nl'
---+
  Reporter:  w...@go2people.nl  | Owner:  walteralini
Status:  assigned  | Milestone:  1.2
 Component:  Forms |   Version:  1.2-beta   
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  1  
Needs_docs:  0 |   Needs_tests:  1  
Needs_better_patch:  0 |  
---+
Changes (by walteralini):

  * has_patch:  0 => 1
  * needs_tests:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11702: ForeignKey validation should check that to_field is unique

[Django]

#11702: ForeignKey validation should check that to_field is unique
---+
  Reporter:  physicsnick   | Owner:  
marcosmoyano
Status:  reopened  | Milestone:  1.2
 
 Component:  Database layer (models, ORM)  |   Version:  1.1
 
Resolution:|  Keywords:  pycamp2010 
 
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  1 |  
---+
Changes (by kmtracey):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 It's not fixed until patch is committed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12247: update on empty queryset in which the update kwargs refer to inherited columns update all rows of base table

[Django]

#12247: update on empty queryset in which the update kwargs refer to inherited
columns update all rows of base table
---+
  Reporter:  jsmullyan | Owner:  matiasb
Status:  assigned  | Milestone:  1.2
 Component:  Database layer (models, ORM)  |   Version:  1.1
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  1  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by matiasb):

  * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11920: Cannot access related field of an unsaved object if the object is from an inherited model

[Django]

#11920: Cannot access related field of an unsaved object if the object is from 
an
inherited model
---+
  Reporter:  zbyte64   | Owner: 
   
Status:  new   | Milestone:  1.2
   
 Component:  Database layer (models, ORM)  |   Version:  1.1
   
Resolution:|  Keywords:  related 
field doesnotexist
 Stage:  Accepted  | Has_patch:  0  
   
Needs_docs:  0 |   Needs_tests:  0  
   
Needs_better_patch:  0 |  
---+
Changes (by nessita):

  * owner:  nessita =>
  * status:  assigned => new

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11702: ForeignKey validation should check that to_field is unique

[Django]

#11702: ForeignKey validation should check that to_field is unique
---+
  Reporter:  physicsnick   | Owner:  
marcosmoyano
Status:  closed| Milestone:  1.2
 
 Component:  Database layer (models, ORM)  |   Version:  1.1
 
Resolution:  fixed |  Keywords:  pycamp2010 
 
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  1 |  
---+
Changes (by marcosmoyano):

  * status:  assigned => closed
  * resolution:  => fixed

Comment:

 New patch. Moved validation code to django.core.management.validation and
 add test suite.

 I think the validation could be clearear and simpler if we add a line like
 this:
 self.to_field = to_field
 in django.db.models.fields.related on ForeignKey __init__ method.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13041: Error on InlineModel Admin

[Django]

#13041: Error on InlineModel Admin
---+
  Reporter:  mdpetry   | Owner:  matiasb
Status:  closed| Milestone:  1.2
 Component:  django.contrib.admin  |   Version:  1.1
Resolution:  worksforme|  Keywords: 
 Stage:  Accepted  | Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by matiasb):

  * status:  assigned => closed
  * resolution:  => worksforme

Comment:

 I couldn't reproduce the bug (except for what stated in the comment
 above). You should provide additional information if you see the problem
 persists.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #13048: A typographical error in the Django documentation

[Django]

#13048: A typographical error in the Django documentation
---+
 Reporter:  aruseni|   Owner:  nobody
   Status:  new|   Milestone:
Component:  Uncategorized  | Version:  1.1   
 Keywords: |   Stage:  Unreviewed
Has_patch:  0  |  
---+
 http://docs.djangoproject.com/en/dev/topics/email/

 “The are times when you do not want Django to send e-mails at all.”

 There should be “There are” instead of “The are”.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12986: SelectDateField doesn't repost data when USE_L10N = True and LANGUAGE_CODE = 'nl'

[Django]

#12986: SelectDateField doesn't repost data when USE_L10N = True and 
LANGUAGE_CODE
= 'nl'
---+
  Reporter:  w...@go2people.nl  | Owner:  walteralini
Status:  assigned  | Milestone:  1.2
 Component:  Forms |   Version:  1.2-beta   
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by walteralini):

  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12986: SelectDateField doesn't repost data when USE_L10N = True and LANGUAGE_CODE = 'nl'

[Django]

#12986: SelectDateField doesn't repost data when USE_L10N = True and 
LANGUAGE_CODE
= 'nl'
---+
  Reporter:  w...@go2people.nl  | Owner:  walteralini
Status:  new   | Milestone:  1.2
 Component:  Forms |   Version:  1.2-beta   
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by walteralini):

  * owner:  anonymous => walteralini
  * status:  assigned => new

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12986: SelectDateField doesn't repost data when USE_L10N = True and LANGUAGE_CODE = 'nl'

[Django]

#12986: SelectDateField doesn't repost data when USE_L10N = True and 
LANGUAGE_CODE
= 'nl'
---+
  Reporter:  w...@go2people.nl  | Owner:  anonymous
Status:  assigned  | Milestone:  1.2  
 Component:  Forms |   Version:  1.2-beta 
Resolution:|  Keywords:   
 Stage:  Accepted  | Has_patch:  0
Needs_docs:  0 |   Needs_tests:  0
Needs_better_patch:  0 |  
---+
Changes (by anonymous):

  * owner:  nobody => anonymous
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12749: "Please correct the error below." when saving add model form with inline formset and no auto primary key.

[Django]

#12749: "Please correct the error below." when saving add model form with inline
formset and no auto primary key.
-+--
  Reporter:  chris.wessel...@cwi.nl  | Owner:  jkocherhans
Status:  assigned| Milestone:  1.2
 Component:  django.contrib.admin|   Version:  SVN
Resolution:  |  Keywords: 
 Stage:  Accepted| Has_patch:  1  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by jkocherhans):

  * owner:  nobody => jkocherhans
  * status:  new => assigned

Comment:

 I'm not quite sure how to fix this yet, but the fix should probably be in
 `ForeignKey.validate()`. Generally, when we're adding inline objects, the
 value of the FK to the parent object will be `None` since the parent
 hasn't been saved yet. If the value is `None`, the `ForeignKey` validation
 is skipped. However, in this case, the `ForeignKey` has a value of 1 since
 the Person object has already been saved. Person isn't the *real* parent
 object, but the real parent's primary key is a `ForeignKey` to Person.

 [12206] just rolled back part of model validation, but it was the part of
 model validation that allowed cases like this to pass. Reverting that
 isn't an option.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5025: Add a "truncate" template filter

[Django]

#5025: Add a "truncate" template filter
-+--
  Reporter:  SmileyChris | Owner:  nobody
Status:  reopened| Milestone:
 Component:  Template system |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by gabrielhurley):

 * cc: gabrielhurley (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #13047: es-ar locale formats should use raw strings

[Django]

#13047: es-ar locale formats should use raw strings
--+-
 Reporter:  faramirez |   Owner:  faramirez 
   Status:  new   |   Milestone:  1.2   
Component:  Translations  | Version:  1.2-beta  
 Keywords:  pycamp2010|   Stage:  Unreviewed
Has_patch:  1 |  
--+-
 This ticket is related to the Ticket #12980
 patch is attached.
 attached a sample project to verify the solution.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12247: update on empty queryset in which the update kwargs refer to inherited columns update all rows of base table

[Django]

#12247: update on empty queryset in which the update kwargs refer to inherited
columns update all rows of base table
---+
  Reporter:  jsmullyan | Owner:  matiasb
Status:  assigned  | Milestone:  1.2
 Component:  Database layer (models, ORM)  |   Version:  1.1
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Comment (by matiasb):

 After long debugging to find the issue, added patch to manage empty
 related_ids when building related_updates queries.
 Thanks to nessita for the previous debugging info and jsmullyan for the
 provided tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12028: Generic Inline doesn't validate unique_together

[Django]

#12028: Generic Inline doesn't validate unique_together
---+
  Reporter:  diverman  | Owner: 
 
Status:  new   | Milestone: 
 
 Component:  Contrib apps  |   Version:  SVN
 
Resolution:|  Keywords:  content type generic 
inline unique validation formset admin modeladmin model
 Stage:  Accepted  | Has_patch:  0  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by nessita):

  * owner:  nessita =>
  * status:  assigned => new

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11920: Cannot access related field of an unsaved object if the object is from an inherited model

[Django]

#11920: Cannot access related field of an unsaved object if the object is from 
an
inherited model
---+
  Reporter:  zbyte64   | Owner:  nessita
   
Status:  assigned  | Milestone:  1.2
   
 Component:  Database layer (models, ORM)  |   Version:  1.1
   
Resolution:|  Keywords:  related 
field doesnotexist
 Stage:  Accepted  | Has_patch:  0  
   
Needs_docs:  0 |   Needs_tests:  0  
   
Needs_better_patch:  0 |  
---+
Comment (by nessita):

 Even though the example is not correct (when creating the {{{new_parent}}}
 object, the old, saved {{{parent}}} instance is used to query the
 {{{baseline_set}}} instead of the unsaved {{{new_parent}}}), the problem
 still persists when doing:

 {{{
 #!python
 In [1]: from fix_11920.models import *

 In [2]: Parent().baseline_set
 Out[2]: 

 In [3]: Child().sibling_set
 ERROR: An unexpected error occurred while tokenizing input
 The following traceback may be corrupted or invalid
 The error message is: ('EOF in multi-line statement', (77, 0))

 ---
 DoesNotExist  Traceback (most recent call
 last)

 /home/nessita/pycon/test_project/ in ()

 /home/nessita/pycon/django-sprint/lib/python2.6/site-
 packages/django/db/models/fields/related.pyc in __get__(self, instance,
 instance_type)
 352
 353 return self.create_manager(instance,
 --> 354 self.related.model._default_manager.__class__)
 355
 356 def __set__(self, instance, value):

 /home/nessita/pycon/django-sprint/lib/python2.6/site-
 packages/django/db/models/fields/related.pyc in create_manager(self,
 instance, superclass)
 429 attname = rel_field.rel.get_related_field().name
 430 manager.core_filters = {'%s__%s' % (rel_field.name,
 attname):
 --> 431 getattr(instance, attname)}
 432 manager.model = self.related.model
 433

 /home/nessita/pycon/django-sprint/lib/python2.6/site-
 packages/django/db/models/fields/related.pyc in __get__(self, instance,
 instance_type)
 262 if self.field.null:
 263 return None
 --> 264 raise self.field.rel.to.DoesNotExist
 265 other_field = self.field.rel.get_related_field()
 266 if other_field.rel:

 DoesNotExist:
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12247: update on empty queryset in which the update kwargs refer to inherited columns update all rows of base table

[Django]

#12247: update on empty queryset in which the update kwargs refer to inherited
columns update all rows of base table
---+
  Reporter:  jsmullyan | Owner:  matiasb
Status:  assigned  | Milestone:  1.2
 Component:  Database layer (models, ORM)  |   Version:  1.1
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by matiasb):

  * owner:  => matiasb
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12627: If all fields are readonly or editable=False, their ModelForm is always valid and can raise exceptions

[Django]

#12627: If all fields are readonly or editable=False, their ModelForm is always
valid and can raise exceptions
---+
  Reporter:  KyleMac   | Owner:  nobody 
 
Status:  new   | Milestone:  1.2
 
 Component:  django.contrib.admin  |   Version:  SVN
 
Resolution:|  Keywords:  readonly_fields 
editable
 Stage:  Accepted  | Has_patch:  0  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by tin_nqn):

  * owner:  tin_nqn => nobody
  * status:  assigned => new

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12247: update on empty queryset in which the update kwargs refer to inherited columns update all rows of base table

[Django]

#12247: update on empty queryset in which the update kwargs refer to inherited
columns update all rows of base table
---+
  Reporter:  jsmullyan | Owner: 
Status:  new   | Milestone:  1.2
 Component:  Database layer (models, ORM)  |   Version:  1.1
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by nessita):

  * owner:  nessita =>
  * status:  assigned => new

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11920: Cannot access related field of an unsaved object if the object is from an inherited model

[Django]

#11920: Cannot access related field of an unsaved object if the object is from 
an
inherited model
---+
  Reporter:  zbyte64   | Owner:  nessita
   
Status:  assigned  | Milestone:  1.2
   
 Component:  Database layer (models, ORM)  |   Version:  1.1
   
Resolution:|  Keywords:  related 
field doesnotexist
 Stage:  Accepted  | Has_patch:  0  
   
Needs_docs:  0 |   Needs_tests:  0  
   
Needs_better_patch:  0 |  
---+
Changes (by nessita):

  * owner:  nobody => nessita
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12627: If all fields are readonly or editable=False, their ModelForm is always valid and can raise exceptions

[Django]

#12627: If all fields are readonly or editable=False, their ModelForm is always
valid and can raise exceptions
---+
  Reporter:  KyleMac   | Owner:  tin_nqn
 
Status:  assigned  | Milestone:  1.2
 
 Component:  django.contrib.admin  |   Version:  SVN
 
Resolution:|  Keywords:  readonly_fields 
editable
 Stage:  Accepted  | Has_patch:  0  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Comment (by tin_nqn):

 I've just could reproduce the bug. create a project ticket and app t12627

 {{{
 #models.py
 from django.db import models

 class Musician(models.Model):
 first_name = models.CharField(max_length=50)
 last_name = models.CharField(max_length=50)
 instrument = models.CharField(max_length=100)

 def __unicode__(self):
 return "%s %s" % (self.first_name, self.last_name)

 class Album(models.Model):
 artist = models.ForeignKey(Musician, editable=False)
 name = models.CharField(max_length=100, editable=False)
 release_date = models.DateField(editable=False)
 num_stars = models.IntegerField(editable=False)


 def __unicode__(self):
 return "%s by %s" % (self.name, self.artist)


 }}}

 {{{
 #admin.py
 from django.contrib import admin
 from ticket.t12627.models import Musician, Album

 class MusicianAdmin(admin.ModelAdmin):
 readonly_fields = ('first_name', 'last_name', 'instrument')

 class AlbumAdmin(admin.ModelAdmin):
 pass

 admin.site.register(Musician, MusicianAdmin)
 admin.site.register(Album, AlbumAdmin)
 }}}

 run admin and you can add blank Musicians and raise an IntegrityError if
 you try add an album

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11702: ForeignKey validation should check that to_field is unique

[Django]

#11702: ForeignKey validation should check that to_field is unique
---+
  Reporter:  physicsnick   | Owner:  
marcosmoyano
Status:  assigned  | Milestone:  1.2
 
 Component:  Database layer (models, ORM)  |   Version:  1.1
 
Resolution:|  Keywords:  pycamp2010 
 
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  1 |  
---+
Changes (by ramiro):

  * keywords:  => pycamp2010
  * needs_better_patch:  0 => 1
  * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13032: USE_THOUSAND_SEPARATOR breaks forms by formatting primary key values, causing error on save

[Django]

#13032: USE_THOUSAND_SEPARATOR breaks forms by formatting primary key values,
causing error on save
---+
  Reporter:  exo...@gmail.com  | Owner:  gonzalodelgado 
   
Status:  assigned  | Milestone:  1.2
   
 Component:  Internationalization  |   Version:  SVN
   
Resolution:|  Keywords:  formats l10n 
locale pycamp2010
 Stage:  Accepted  | Has_patch:  0  
   
Needs_docs:  0 |   Needs_tests:  0  
   
Needs_better_patch:  0 |  
---+
Changes (by apollo13):

 * cc: apollo13 (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13032: USE_THOUSAND_SEPARATOR breaks forms by formatting primary key values, causing error on save

[Django]

#13032: USE_THOUSAND_SEPARATOR breaks forms by formatting primary key values,
causing error on save
---+
  Reporter:  exo...@gmail.com  | Owner:  gonzalodelgado 
   
Status:  assigned  | Milestone:  1.2
   
 Component:  Internationalization  |   Version:  SVN
   
Resolution:|  Keywords:  formats l10n 
locale pycamp2010
 Stage:  Accepted  | Has_patch:  0  
   
Needs_docs:  0 |   Needs_tests:  0  
   
Needs_better_patch:  0 |  
---+
Changes (by jezdez):

  * component:  Uncategorized => Internationalization

Comment:

 Thanks for the bug report, exogen. Please provide us with more detail
 about your test environment.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11702: ForeignKey validation should check that to_field is unique

[Django]

#11702: ForeignKey validation should check that to_field is unique
---+
  Reporter:  physicsnick   | Owner:  
marcosmoyano
Status:  assigned  | Milestone:  1.2
 
 Component:  Database layer (models, ORM)  |   Version:  1.1
 
Resolution:|  Keywords: 
 
 Stage:  Accepted  | Has_patch:  0  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Comment (by marcosmoyano):

 A humble approach at related field initialization. Don't know how to write
 a test suite for this since it's on initialization. I've ran the test
 suite just to make sure nothing breaks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12592: language code for brazilian portuguese should be case insensitive.

[Django]

#12592: language code for brazilian portuguese should be case insensitive.
---+
  Reporter:  italomaia | Owner:  nobody
Status:  closed| Milestone:  1.2   
 Component:  Internationalization  |   Version:  SVN   
Resolution:  wontfix   |  Keywords:  pycamp2010
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by jjconti):

  * keywords:  => pycamp2010
  * status:  new => closed
  * resolution:  => wontfix

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12592: language code for brazilian portuguese should be case insensitive.

[Django]

#12592: language code for brazilian portuguese should be case insensitive.
---+
  Reporter:  italomaia | Owner:  nobody
Status:  new   | Milestone:  1.2   
 Component:  Internationalization  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by jjconti):

 I ran all the tests with a settings file having
 {{{
 LANGUAGE_CODE = 'es-AR'
 }}}
 And all ran ok.

 I also ran them with

 {{{
 LANGUAGE_CODE = 'es-AR'
 USE_I18N = True
 }}}
 And all ran ok too.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12151: UnicodeEncodeError from django.contrib.comments.views.utils line 41.

[Django]

#12151: UnicodeEncodeError from django.contrib.comments.views.utils line 41.
--+-
  Reporter:  mikl | Owner:  nobody
Status:  reopened | Milestone:  1.2   
 Component:  django.contrib.comments  |   Version:  SVN   
Resolution:   |  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  1|  
--+-
Changes (by Leo):

  * status:  closed => reopened
  * needs_better_patch:  0 => 1
  * resolution:  fixed =>

Comment:

 Regardless of the discussion in #11716, the patch for this bug should
 catch `ValidationError` as well since some of the fields in django throw
 that error on an invalid input and any field can be set as `primary_key`.`

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Changeset] r12693 - in django/trunk/docs: releases topics/forms

[noreply]

Author: jkocherhans
Date: 2010-03-06 13:51:29 -0600 (Sat, 06 Mar 2010)
New Revision: 12693

Modified:
   django/trunk/docs/releases/1.2.txt
   django/trunk/docs/topics/forms/modelforms.txt
Log:
Fixed #12896. Documented the new side-effects of ModelForm validation.

Modified: django/trunk/docs/releases/1.2.txt
===
--- django/trunk/docs/releases/1.2.txt  2010-03-06 19:17:29 UTC (rev 12692)
+++ django/trunk/docs/releases/1.2.txt  2010-03-06 19:51:29 UTC (rev 12693)
@@ -299,7 +299,17 @@
 introduced since 1.1, including ``csrf_protect``, ``cache_control`` and 
anything
 created using ``decorator_from_middleware``.
 
+``ModelForm.is_valid()`` and ``ModelForm.errors``
+-
 
+Much of the validation work for ModelForms has been moved down to the model
+level. As a result, the first time you call ``ModelForm.is_valid()``, access
+``ModelForm.errors`` or otherwise trigger form validation, your model will be
+cleaned in-place. This conversion used to happen when the model was saved. If
+you need an unmodified instance of your model, you should pass a copy to the
+``ModelForm`` constructor.
+
+
 .. _deprecated-features-1.2:
 
 ``BooleanField`` on MySQL

Modified: django/trunk/docs/topics/forms/modelforms.txt
===
--- django/trunk/docs/topics/forms/modelforms.txt   2010-03-06 19:17:29 UTC 
(rev 12692)
+++ django/trunk/docs/topics/forms/modelforms.txt   2010-03-06 19:51:29 UTC 
(rev 12693)
@@ -196,6 +196,19 @@
 name = forms.CharField(max_length=100)
 authors = forms.ModelMultipleChoiceField(queryset=Author.objects.all())
 
+The ``is_valid()`` method and ``errors``
+
+
+.. versionchanged:: 1.2
+
+The first time you call ``is_valid()`` or access the ``errors`` attribute of a
+``ModelForm`` has always triggered form validation, but as of Django 1.2, it
+will also trigger :ref:`model validation `. This has the
+side-effect of cleaning the model you pass to the ``ModelForm`` constructor.
+For instance, calling ``is_valid()`` on your form will convert any date fields
+on your model to actual date objects.
+
+
 The ``save()`` method
 -
 

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12876: maximum recursion error when caching querysets on models

[Django]

#12876: maximum recursion error when caching querysets on models
---+
  Reporter:  zbyte64   | Owner:  elachuni  
Status:  new   | Milestone:  1.2   
 Component:  Database layer (models, ORM)  |   Version:  1.2-beta  
Resolution:|  Keywords:  pycamp2010
 Stage:  Ready for checkin | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by Alex):

  * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12876: maximum recursion error when caching querysets on models

[Django]

#12876: maximum recursion error when caching querysets on models
---+
  Reporter:  zbyte64   | Owner:  elachuni  
Status:  new   | Milestone:  1.2   
 Component:  Database layer (models, ORM)  |   Version:  1.2-beta  
Resolution:|  Keywords:  pycamp2010
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by elachuni):

 The attached patch adds an optional argument 'memo' to clone, to be able
 to correctly implement deepcopy.

 Replying to [comment:3 elachuni]:
 > So, if the query contains a reference to a model instance that in turn
 contains a reference to a reference (...)

 Should have been a reference to a '''query''' here.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12778: InlineAdmin ignores inner Media class

[Django]

#12778: InlineAdmin ignores inner Media class
---+
  Reporter:  apollo13  | Owner:  nobody
Status:  new   | Milestone:  1.2   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by gonzalodelgado):

 I see your point. I don't find overriding forms to add media annoying
 though (perhaps I don't do it quite often).

 Maybe this should be discussed in [http://groups.google.com/group/django-
 developers django-developers]?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11675: [patch] Support new memcached wrapper pylibmc

[Django]

#11675: [patch] Support new memcached wrapper pylibmc
-+--
  Reporter:  pipp...@yahoo.co.jp | Owner:  otherjacob   
 
Status:  assigned| Milestone:   
 
 Component:  Cache system|   Version:  SVN  
 
Resolution:  |  Keywords:  cache pylibmc 
memcached.py
 Stage:  Design decision needed  | Has_patch:  0
 
Needs_docs:  0   |   Needs_tests:  0
 
Needs_better_patch:  0   |  
-+--
Changes (by apollo13):

  * milestone:  1.2 =>

Comment:

 1.2 is in bug fix mode, removing the milestone…

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13046: Argentinian Spanish translation patch

[Django]

#13046: Argentinian Spanish translation patch
+---
  Reporter:  matiasherranz  | Owner:  matiasherranz 
 
Status:  new| Milestone:  1.2   
 
 Component:  Translations   |   Version:  SVN   
 
Resolution: |  Keywords:  pycamp2010, djangosprint, 
cordoba, argentina, famaf
 Stage:  Unreviewed | Has_patch:  1 
 
Needs_docs:  0  |   Needs_tests:  0 
 
Needs_better_patch:  0  |  
+---
Changes (by matiasherranz):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Changeset] r12692 - in django/branches/releases/1.1.X: . django/db/models tests/modeltests/field_subclassing tests/regressiontests/defer_regress

[noreply]

Author: jkocherhans
Date: 2010-03-06 13:17:29 -0600 (Sat, 06 Mar 2010)
New Revision: 12692

Added:
   django/branches/releases/1.1.X/tests/modeltests/field_subclassing/fields.py
   django/branches/releases/1.1.X/tests/modeltests/field_subclassing/tests.py
Modified:
   django/branches/releases/1.1.X/
   django/branches/releases/1.1.X/django/db/models/query_utils.py
   django/branches/releases/1.1.X/tests/modeltests/field_subclassing/models.py
   django/branches/releases/1.1.X/tests/regressiontests/defer_regress/models.py
Log:
[1.1.X] Fixed #12734. Deferred fields will now be properly converted to python 
when accessed. Backport of r12579 from trunk.



Property changes on: django/branches/releases/1.1.X
___
Name: svnmerge-integrated
   - 
/django/trunk:1-11500,11523,11527-11528,11531-11552,11554,11577,11579-11581,11588-11589,11591-11592,11596-11599,11601-11617,11619-11626,11628-11635,11637-11638,11643-11644,11648-11653,11656,11670,11678,11681,11684,11686,11688,11691,11693,11695,11697,11699,11701,11703,11705,11707,11714,11719,11732,11734,11740,11748,11751,11753,11756,11760,11800,11802,11808,11815,11817,11820,11822,11824,11826,11828,11831,11833,11835,11837,11839,11841,11844,11857,11864,11874,11876,11878,11885,11898,11901,11905,11909,11912,11914,11917,11938,11953,11961,11977,11979,11984,11986,11988,11990,11992,11994,11996,11998,12001,12004,12006,12011,12022,12024,12044-12045,12048,12054-12056,12059,12064,12066,12068,12070,12079,12086,12088,12104,12118,12132,12137-12138,12140-12141,12144,12150-12152,12220-12221,12229,12249,12253,12276,12282,12284,12293,12313,12317-12324,12333,12341,12343,12346,12353,12362,12379,12384,12398,12405,12408-12411,12419-12420,12423,12425-12426,12429,12434,12436,12439-12442,12448,12457,12461-12464,12467,12473,12475,12490,12492,12497-12498,12502,12513,12515-12516,12518,12523,12526,12528,12533,12535,12537,12539,12541,12548,12553,12556,12558-12560,12562,12567,12569-12570,12573,12576,12581,12584,12616,12621-12622,12631,12648,12650,12652,12659,12661,12676,12679,12681,12683,12688

   + 
/django/trunk:1-11500,11523,11527-11528,11531-11552,11554,11577,11579-11581,11588-11589,11591-11592,11596-11599,11601-11617,11619-11626,11628-11635,11637-11638,11643-11644,11648-11653,11656,11670,11678,11681,11684,11686,11688,11691,11693,11695,11697,11699,11701,11703,11705,11707,11714,11719,11732,11734,11740,11748,11751,11753,11756,11760,11800,11802,11808,11815,11817,11820,11822,11824,11826,11828,11831,11833,11835,11837,11839,11841,11844,11857,11864,11874,11876,11878,11885,11898,11901,11905,11909,11912,11914,11917,11938,11953,11961,11977,11979,11984,11986,11988,11990,11992,11994,11996,11998,12001,12004,12006,12011,12022,12024,12044-12045,12048,12054-12056,12059,12064,12066,12068,12070,12079,12086,12088,12104,12118,12132,12137-12138,12140-12141,12144,12150-12152,12220-12221,12229,12249,12253,12276,12282,12284,12293,12313,12317-12324,12333,12341,12343,12346,12353,12362,12379,12384,12398,12405,12408-12411,12419-12420,12423,12425-12426,12429,12434,12436,12439-12442,12448,12457,12461-12464,12467,12473,12475,12490,12492,12497-12498,12502,12513,12515-12516,12518,12523,12526,12528,12533,12535,12537,12539,12541,12548,12553,12556,12558-12560,12562,12567,12569-12570,12573,12576,12579,12581,12584,12616,12621-12622,12631,12648,12650,12652,12659,12661,12676,12679,12681,12683,12688

Modified: django/branches/releases/1.1.X/django/db/models/query_utils.py
===
--- django/branches/releases/1.1.X/django/db/models/query_utils.py  
2010-03-06 19:01:47 UTC (rev 12691)
+++ django/branches/releases/1.1.X/django/db/models/query_utils.py  
2010-03-06 19:17:29 UTC (rev 12692)
@@ -182,11 +182,28 @@
 Retrieves and caches the value from the datastore on the first lookup.
 Returns the cached value.
 """
+from django.db.models.fields import FieldDoesNotExist
+
 assert instance is not None
 cls = self.model_ref()
 data = instance.__dict__
 if data.get(self.field_name, self) is self:
-data[self.field_name] = 
cls._base_manager.filter(pk=instance.pk).values_list(self.field_name, 
flat=True).get()
+# self.field_name is the attname of the field, but only() takes the
+# actual name, so we need to translate it here.
+try:
+cls._meta.get_field_by_name(self.field_name)
+name = self.field_name
+except FieldDoesNotExist:
+name = [f.name for f in cls._meta.fields
+if f.attname == self.field_name][0]
+# We use only() instead of values() here because we want the
+# various data coersion methods (to_python(), etc.) to be called
+# here.
+val = getattr(
+cls._base_manager.filter(pk=instance.pk).only(name).get(),
+self.field_name
+)
+   

Re: [Django] #12778: InlineAdmin ignores inner Media class

[Django]

#12778: InlineAdmin ignores inner Media class
---+
  Reporter:  apollo13  | Owner:  nobody
Status:  new   | Milestone:  1.2   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by apollo13):

 Might be, but then it should get documented. On the other hand it's nice
 to not override the form just to add a js/css file…

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13032: USE_THOUSAND_SEPARATOR breaks forms by formatting primary key values, causing error on save

[Django]

#13032: USE_THOUSAND_SEPARATOR breaks forms by formatting primary key values,
causing error on save
---+
  Reporter:  exo...@gmail.com  | Owner:  gonzalodelgado 
   
Status:  assigned  | Milestone:  1.2
   
 Component:  Uncategorized |   Version:  SVN
   
Resolution:|  Keywords:  formats l10n locale 
pycamp2010
 Stage:  Accepted  | Has_patch:  0  
   
Needs_docs:  0 |   Needs_tests:  0  
   
Needs_better_patch:  0 |  
---+
Comment (by gonzalodelgado):

 I hadn't set USE_L10N in settings.py, but I did that and tested again and
 still can't get the !AutoField to fail.

 Also, I wrote a form class holding all the buil-in numerical fields to
 test this and can't any of them to fail either:


 {{{
 class TestForm(forms.Form):
 intfield = forms.IntegerField(required=False)
 floatfield = forms.FloatField(required=False)
 decimalfield = forms.DecimalField(required=False)

 >>> from testapp.forms import TestForm
 >>> tf = TestForm({'intfield': '1,000', 'floatfield': '1,000',
 'decimalfield': '1,000' })
 >>> tf.is_valid()
 True
 >>> tf.cleaned_data
 {'floatfield': 1000.0, 'intfield': 1000, 'decimalfield': Decimal('1000')}
 >>> print tf
 Intfield:
 Floatfield:
 Decimalfield:

 }}}

 So data seems to be cleaned properly by numerical fields even when
 USE_THOUSAND_SEPARATOR is True and NUMBER_GROUPING isn't 0.

 I'm wondering what data did the original poster use and what the value for
 the NUMBER_GROUPING setting was.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12986: SelectDateField doesn't repost data when USE_L10N = True and LANGUAGE_CODE = 'nl'

[Django]

#12986: SelectDateField doesn't repost data when USE_L10N = True and 
LANGUAGE_CODE
= 'nl'
---+
  Reporter:  w...@go2people.nl  | Owner:  nobody  
Status:  new   | Milestone:  1.2 
 Component:  Forms |   Version:  1.2-beta
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by walteralini):

 I see the same problem when LANGUAGE_CODE is "fr" or "es". It's working
 for me for "en-us"

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #13046: Argentinian Spanish translation patch

[Django]

#13046: Argentinian Spanish translation patch
-+--
 Reporter:  matiasherranz|   Owner: 
 matiasherranz
   Status:  new  |   Milestone: 
 1.2  
Component:  Translations | Version: 
 SVN  
 Keywords:  pycamp2010, djangosprint, cordoba, argentina, famaf  |   Stage: 
 Unreviewed   
Has_patch:  1|  
-+--
 Completed the translation to Argentinian Spanish that was in
 conf/locale/es_AR/LC_MESSAGES/django.po

 Done by dariog and matiasherranz during the 2010 Django Sprint, in
 Córdoba, Argentina.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12778: InlineAdmin ignores inner Media class

[Django]

#12778: InlineAdmin ignores inner Media class
---+
  Reporter:  apollo13  | Owner:  nobody
Status:  new   | Milestone:  1.2   
 Component:  django.contrib.admin  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by gonzalodelgado):

 I'm surely missing something, but I don't see a need for having a Media
 class in an !InlineAdmin class since an instance's forms will be rendered
 in the same page of the AdminForm instance that contains it, and any media
 (CSS, Javascript) you want in that page should be included in your
 !AdminForm class definition.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12896: ModelForm.is_valid() and ModelForm.errors have backwards-incompatible side effects since model validation

[Django]

#12896: ModelForm.is_valid() and ModelForm.errors have backwards-incompatible 
side
effects since model validation
-+--
  Reporter:  lukeplant   | Owner:  jkocherhans
Status:  assigned| Milestone:  1.2
 Component:  Forms   |   Version:  1.1
Resolution:  |  Keywords: 
 Stage:  Design decision needed  | Has_patch:  0  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by jkocherhans):

  * owner:  nobody => jkocherhans
  * status:  new => assigned

Comment:

 `Model.full_clean()` modifies the model in-place. I hope no one will argue
 that's the wrong thing to do. So, to fix this I see a couple of solutions,
 both of which I think are unacceptable.

 1. Copy the instance. Copying could be an expensive operation, and if the
 developer really wants to do that, they can just explicitly do it
 themselves and pass the copy to the `ModeForm` constructor.

 2. Change the internals of `Model.full_clean()` to optionally not modify
 the model in place, and change `ModelForm` to use that option. I think
 this option is just needlessly confusing.

 I'll add a warning to the release notes and to the `ModelForm` docs.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Changeset] r12691 - django/trunk/tests/regressiontests/model_forms_regress

[noreply]

Author: jkocherhans
Date: 2010-03-06 13:01:47 -0600 (Sat, 06 Mar 2010)
New Revision: 12691

Modified:
   django/trunk/tests/regressiontests/model_forms_regress/tests.py
Log:
Removed a stray print from [12690]. Thanks for catching that, apollo13.
Just running up the commit count in less destructive ways than jacob. Move 
along.

Modified: django/trunk/tests/regressiontests/model_forms_regress/tests.py
===
--- django/trunk/tests/regressiontests/model_forms_regress/tests.py 
2010-03-06 18:42:56 UTC (rev 12690)
+++ django/trunk/tests/regressiontests/model_forms_regress/tests.py 
2010-03-06 19:01:47 UTC (rev 12691)
@@ -78,7 +78,6 @@
 
 class PublicationForm(forms.ModelForm):
 def clean(self):
-print self.cleaned_data
 self.cleaned_data['title'] = self.cleaned_data['title'].upper()
 return self.cleaned_data
 

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13045: Add change needed for internationalization machinery when begining an new proyect .

[Django]

#13045: Add change needed  for internationalization machinery when  begining an 
new
proyect .
--+-
  Reporter:  efmontes | Owner:  nobody
Status:  new  | Milestone:  1.2   
 Component:  django-admin.py  |   Version:  SVN   
Resolution:   |  Keywords:  pycamp2010
 Stage:  Unreviewed   | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Changes (by efmontes):

  * needs_better_patch:  => 0
  * has_patch:  0 => 1
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #3591: add support for custom app_label and verbose_name

[Django]

#3591: add support for custom app_label and verbose_name
-+--
  Reporter:  jkocherhans | Owner:  adrian
Status:  reopened| Milestone:
 Component:  Core framework  |   Version:  SVN   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  1 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by bronger):

 * cc: bron...@physik.rwth-aachen.de (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #13045: Add change needed for internationalization machinery when begining an new proyect .

[Django]

#13045: Add change needed  for internationalization machinery when  begining an 
new
proyect .
-+--
 Reporter:  efmontes |   Owner:  nobody
   Status:  new  |   Milestone:  1.2   
Component:  django-admin.py  | Version:  SVN   
 Keywords:  pycamp2010   |   Stage:  Unreviewed
Has_patch:  0|  
-+--
 Add change needed  for internationalization machinery when  begining an
 new proyect.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12876: maximum recursion error when caching querysets on models

[Django]

#12876: maximum recursion error when caching querysets on models
---+
  Reporter:  zbyte64   | Owner:  elachuni  
Status:  new   | Milestone:  1.2   
 Component:  Database layer (models, ORM)  |   Version:  1.2-beta  
Resolution:|  Keywords:  pycamp2010
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by ramiro):

  * keywords:  => pycamp2010
  * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Changeset] r12690 - in django/trunk: django/forms tests/regressiontests/model_forms_regress

[noreply]

Author: jkocherhans
Date: 2010-03-06 12:42:56 -0600 (Sat, 06 Mar 2010)
New Revision: 12690

Modified:
   django/trunk/django/forms/forms.py
   django/trunk/django/forms/models.py
   django/trunk/tests/regressiontests/model_forms_regress/tests.py
Log:
Fixed #12960. The return value of ModelForm.clean() is now applied to the 
model. Thanks for the report, krejcik.

Modified: django/trunk/django/forms/forms.py
===
--- django/trunk/django/forms/forms.py  2010-03-06 16:07:05 UTC (rev 12689)
+++ django/trunk/django/forms/forms.py  2010-03-06 18:42:56 UTC (rev 12690)
@@ -265,6 +265,7 @@
 return
 self._clean_fields()
 self._clean_form()
+self._post_clean()
 if self._errors:
 delattr(self, 'cleaned_data')
 
@@ -295,6 +296,13 @@
 except ValidationError, e:
 self._errors[NON_FIELD_ERRORS] = self.error_class(e.messages)
 
+def _post_clean(self):
+"""
+An internal hook for performing additional cleaning after form cleaning
+is complete. Used for model validation in model forms.
+"""
+pass
+
 def clean(self):
 """
 Hook for doing any extra form-wide cleaning after Field.clean() been

Modified: django/trunk/django/forms/models.py
===
--- django/trunk/django/forms/models.py 2010-03-06 16:07:05 UTC (rev 12689)
+++ django/trunk/django/forms/models.py 2010-03-06 18:42:56 UTC (rev 12690)
@@ -245,6 +245,10 @@
 # if initial was provided, it should override the values from instance
 if initial is not None:
 object_data.update(initial)
+# self._validate_unique will be set to True by BaseModelForm.clean().
+# It is False by default so overriding self.clean() and failing to call
+# super will stop validate_unique from being called.
+self._validate_unique = False
 super(BaseModelForm, self).__init__(data, files, auto_id, prefix, 
object_data,
 error_class, label_suffix, 
empty_permitted)
 
@@ -299,35 +303,32 @@
 return exclude
 
 def clean(self):
-self.validate_unique()
+self._validate_unique = True
 return self.cleaned_data
 
-def _clean_fields(self):
-"""
-Cleans the form fields, constructs the instance, then cleans the model
-fields.
-"""
-super(BaseModelForm, self)._clean_fields()
+def _post_clean(self):
+exclude = self._get_validation_exclusions()
 opts = self._meta
+
+# Update the model instance with self.cleaned_data.
 self.instance = construct_instance(self, self.instance, opts.fields, 
opts.exclude)
-exclude = self._get_validation_exclusions()
+
+# Clean the model instance's fields.
 try:
 self.instance.clean_fields(exclude=exclude)
 except ValidationError, e:
 self._update_errors(e.message_dict)
 
-def _clean_form(self):
-"""
-Runs the instance's clean method, then the form's. This is becuase the
-form will run validate_unique() by default, and we should run the
-model's clean method first.
-"""
+# Call the model instance's clean method.
 try:
 self.instance.clean()
 except ValidationError, e:
 self._update_errors({NON_FIELD_ERRORS: e.messages})
-super(BaseModelForm, self)._clean_form()
 
+# Validate uniqueness if needed.
+if self._validate_unique:
+self.validate_unique()
+
 def validate_unique(self):
 """
 Calls the instance's validate_unique() method and updates the form's

Modified: django/trunk/tests/regressiontests/model_forms_regress/tests.py
===
--- django/trunk/tests/regressiontests/model_forms_regress/tests.py 
2010-03-06 16:07:05 UTC (rev 12689)
+++ django/trunk/tests/regressiontests/model_forms_regress/tests.py 
2010-03-06 18:42:56 UTC (rev 12690)
@@ -72,6 +72,26 @@
 # by form.full_clean().
 self.assertEquals(form.instance.left, 1)
 
+# Regression test for #12960.
+# Make sure the cleaned_data returned from ModelForm.clean() is applied to the
+# model instance.
+
+class PublicationForm(forms.ModelForm):
+def clean(self):
+print self.cleaned_data
+self.cleaned_data['title'] = self.cleaned_data['title'].upper()
+return self.cleaned_data
+
+class Meta:
+model = Publication
+
+class ModelFormCleanTest(TestCase):
+def test_model_form_clean_applies_to_model(self):
+data = {'title': 'test', 'date_published': '2010-2-25'}
+form = PublicationForm(data)
+publication = form.save()
+self.assertEqual(publication.title, 'TEST')
+
 class FPForm(forms.ModelForm):
 class Meta:

Re: [Django] #11975: invalid sql returned from django.db.backends.sqlite3.DatabaseOperations.date_trunc_sql

[Django]

#11975: invalid sql returned from
django.db.backends.sqlite3.DatabaseOperations.date_trunc_sql
---+
  Reporter:  ako...@gmail.com  | Owner:  fgallina   
  
Status:  closed| Milestone:  1.2
  
 Component:  Database layer (models, ORM)  |   Version:  SVN
  
Resolution:  fixed |  Keywords:  sqlite 
DatabaseOperations
 Stage:  Accepted  | Has_patch:  1  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Changes (by fgallina):

  * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13041: Error on InlineModel Admin

[Django]

#13041: Error on InlineModel Admin
---+
  Reporter:  mdpetry   | Owner:  matiasb
Status:  assigned  | Milestone:  1.2
 Component:  django.contrib.admin  |   Version:  1.1
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by humitos):

 * cc: humi...@gmail.com (added)

Comment:

 I test this issue too, but I had different "". I created a sample app like
 this:

 ''models.py''
 {{{
 from django.db import models

 # Create your models here.

 class MyModel(models.Model):
 date = models.DateField()

 class OtherModel(models.Model):
 mymodel = models.ForeignKey(MyModel)
 name = models.CharField(max_length=50)

 class AnotherInlineModel(models.Model):
 mymode = models.ForeignKey(MyModel)
 date = models.DateField()
 another_date = models.DateField()
 name = models.CharField(max_length=25)
 }}}

 ''admin.py''
 {{{
 from django.contrib import admin

 from models import *

 class OtherModelAdmin(admin.TabularInline):
 model = OtherModel
 #date_hierachy = 'date'

 class AnotherInlineModelAdmin(admin.TabularInline):
 model = AnotherInlineModel
 #date_hierachy = 'date'

 class MyModelAdmin(admin.ModelAdmin):
 inlines = [
OtherModelAdmin,
AnotherInlineModelAdmin,
 ]

 admin.site.register(MyModel, MyModelAdmin)
 admin.site.register(OtherModel, OtherModelAdmin)
 }}}

 I've created a virtualenv to use Django 1.1 and I can't see the button
 link ''Add another...''

 But, if I use Django trunk (1.2 beta 1) I can see the link and everything
 work correctly.

 I think that this ticket isn't a bug.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11975: invalid sql returned from django.db.backends.sqlite3.DatabaseOperations.date_trunc_sql

[Django]

#11975: invalid sql returned from
django.db.backends.sqlite3.DatabaseOperations.date_trunc_sql
---+
  Reporter:  ako...@gmail.com  | Owner:  fgallina   
  
Status:  closed| Milestone:  1.2
  
 Component:  Database layer (models, ORM)  |   Version:  SVN
  
Resolution:  fixed |  Keywords:  sqlite 
DatabaseOperations
 Stage:  Accepted  | Has_patch:  0  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Changes (by fgallina):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 I was not able to reproduce this issue. My guess is that it was fixed in
 this revision[0].

 Attached is a patch which adds a test for this bug.

 [0]
 
http://code.djangoproject.com/changeset/12573/django/trunk/django/db/backends/sqlite3/base.py

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12876: maximum recursion error when caching querysets on models

[Django]

#12876: maximum recursion error when caching querysets on models
---+
  Reporter:  zbyte64   | Owner:  elachuni
Status:  new   | Milestone:  1.2 
 Component:  Database layer (models, ORM)  |   Version:  1.2-beta
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  0   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by elachuni):

  * owner:  nobody => elachuni

Comment:

 {{{django.db.models.sql.Query}}} defines a custom {{{__deepcopy__}}} that
 calls {{{self.clone()}}}, disregarding the provided memo dict.

 So, if the query contains a reference to a model instance that in turn
 contains a reference to a reference (as in this case), deepcopy will end
 up in an endless loop.

 The model itself could work around this problem by providing its own
 {{{__deepcopy__}}} implementation, that just didn't include the query.
 For the example in the bugreport:

 {{{
 #!python
 class TestModel(models.Model):
 def __deepcopy__(self, memo):
 return TestModel(id=self.id)
 
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12592: language code for brazilian portuguese should be case insensitive.

[Django]

#12592: language code for brazilian portuguese should be case insensitive.
---+
  Reporter:  italomaia | Owner:  nobody
Status:  new   | Milestone:  1.2   
 Component:  Internationalization  |   Version:  SVN   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Comment (by jjconti):

 I tried:

 {{{
 LANGUAGE_CODE = 'pt-BR'
 }}}


 in my settings.py file and when browsing the admin site all in written in
 Portuguese.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11158: get_image_dimensions very slow after 1 call

[Django]

#11158: get_image_dimensions very slow after 1 call
-+--
  Reporter:  kua | Owner:  SAn  
  
Status:  new | Milestone:  1.2  
  
 Component:  Core framework  |   Version:  SVN  
  
Resolution:  |  Keywords:  get_image_dimensions, 
field, save, slow
 Stage:  Accepted| Has_patch:  1
  
Needs_docs:  0   |   Needs_tests:  1
  
Needs_better_patch:  1   |  
-+--
Changes (by SAn):

  * owner:  nobody => SAn
  * needs_tests:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12945: url tag breaks on spaces between delimiting commas since [12503]

[Django]

#12945: url tag breaks on spaces between delimiting commas since [12503]
--+-
  Reporter:  jklaiho  | Owner:  coleifer  
Status:  assigned | Milestone:  1.2   
 Component:  Template system  |   Version:  SVN   
Resolution:   |  Keywords:  url tag pycamp2010
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  0|  
--+-
Changes (by dmoisset):

  * keywords:  url tag => url tag pycamp2010

Comment:

 If the "official" way to use arguments in the url tags is with spaces,
 documentation needs to be updated. The following patch:
  * Fixes the template mentioned by DrMeers (I checked the rest of the
 template and this one seems to be the only one with commas)
  * Fixes the docstring of the url tag to use spaces in the example
  * Updates the documentation to use spaces, and note that the old syntax
 is supported but deprecated.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12627: If all fields are readonly or editable=False, their ModelForm is always valid and can raise exceptions

[Django]

#12627: If all fields are readonly or editable=False, their ModelForm is always
valid and can raise exceptions
---+
  Reporter:  KyleMac   | Owner:  tin_nqn
 
Status:  assigned  | Milestone:  1.2
 
 Component:  django.contrib.admin  |   Version:  SVN
 
Resolution:|  Keywords:  readonly_fields 
editable
 Stage:  Accepted  | Has_patch:  0  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by tin_nqn):

  * owner:  nobody => tin_nqn
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12071: Numeric literals like "2." are incorrectly treated as Variables

[Django]

#12071: Numeric literals like "2." are incorrectly treated as Variables
-+--
  Reporter:  emulbreh| Owner:  nobody
Status:  new | Milestone:  1.2   
 Component:  Template system |   Version:  1.1   
Resolution:  |  Keywords:  pycamp2010
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by jjconti):

  * keywords:  => pycamp2010

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12071: Numeric literals like "2." are incorrectly treated as Variables

[Django]

#12071: Numeric literals like "2." are incorrectly treated as Variables
-+--
  Reporter:  emulbreh| Owner:  nobody
Status:  new | Milestone:  1.2   
 Component:  Template system |   Version:  1.1   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by jjconti):

 This is behaviour is explicitly coded in Django source code:
 
http://code.djangoproject.com/browser/django/trunk/django/template/__init__.py#L681

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13032: USE_THOUSAND_SEPARATOR breaks forms by formatting primary key values, causing error on save

[Django]

#13032: USE_THOUSAND_SEPARATOR breaks forms by formatting primary key values,
causing error on save
---+
  Reporter:  exo...@gmail.com  | Owner:  gonzalodelgado 
   
Status:  assigned  | Milestone:  1.2
   
 Component:  Uncategorized |   Version:  SVN
   
Resolution:|  Keywords:  formats l10n locale 
pycamp2010
 Stage:  Accepted  | Has_patch:  0  
   
Needs_docs:  0 |   Needs_tests:  0  
   
Needs_better_patch:  0 |  
---+
Changes (by gonzalodelgado):

 * cc: exo...@gmail.com (added)
  * keywords:  formats l10n locale => formats l10n locale pycamp2010

Comment:

 I'm not able to reproduce this. Here's what I did:

  * Created a test project and set `USE_THOUSAND_SEPARATOR = True` and
 `NUMBER_GROUPING = 2` in settings.py
  * Created a test app with the following models and admin classes

 {{{
 class MainTestModel(models.Model):
 name = models.CharField(max_length=100)

 class InlineTestModel(models.Model):
 number = models.IntegerField()
 main = models.ForeignKey(MainTestModel)

 class InlineTestAdmin(admin.TabularInline):
 model = InlineTestModel

 class MainTestAdmin(admin.ModelAdmin):
 model = MainTestModel
 inlines = [InlineTestAdmin]
 }}}

  * Tested creating instances of both models from the admin

 Objects are created flawlessly, it would be good if the original poster
 could paste the full stack trace that lead to the `invalid literal for
 int() with base 10: '2,978'` exception from an !AutoField as well as the
 `NUMBER_GROUPING` value used.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13041: Error on InlineModel Admin

[Django]

#13041: Error on InlineModel Admin
---+
  Reporter:  mdpetry   | Owner:  matiasb
Status:  assigned  | Milestone:  1.2
 Component:  django.contrib.admin  |   Version:  1.1
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Comment (by matiasb):

 After some debugging, I found it is a problem with the browser's cache and
 the javascript code.

 I created a sample app as described above. When running it in a project
 using django trunk, I noticed no problem. Then, I installed the app in a
 django 1.1 site (as the version reported in the ticket is 1.1), and in the
 admin section the action links for date fields were showing wrong, but
 with a hard refresh it was solved. After that, I ran again the project
 under trunk version, and finally that triggered the error reported.
 However, with a hard refresh everything worked perfectly well.

 This means it could be a problem related with cache of the admin
 javascript files for different django versions. I think it should be
 closed as invalid.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12980: locale formats should use raw strings

[Django]

#12980: locale formats should use raw strings
---+
  Reporter:  loewis| Owner:  nobody  
Status:  new   | Milestone:  1.2 
 Component:  Translations  |   Version:  1.2-beta
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Comment (by ramiro):

 Yes, this is something I had noted and tried to fix for `es_AR` in r12108
 (wasn't sure about going either the raw string or the backslash escaping
 route), although I forgot a `'\'` before a `'s'` in `DATETIME_FORMAT`. We
 will try to fix this with Fabián Ramirez during the March 6 sprint.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12071: Numeric literals like "2." are incorrectly treated as Variables

[Django]

#12071: Numeric literals like "2." are incorrectly treated as Variables
-+--
  Reporter:  emulbreh| Owner:  nobody
Status:  new | Milestone:  1.2   
 Component:  Template system |   Version:  1.1   
Resolution:  |  Keywords:
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Comment (by jjconti):

 This doen't look like a bug. BTW, docs are clear: "Variable names must
 consist of any letter (A-Z), any digit (0-9), an underscore or a dot."

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11702: ForeignKey validation should check that to_field is unique

[Django]

#11702: ForeignKey validation should check that to_field is unique
---+
  Reporter:  physicsnick   | Owner:  
marcosmoyano
Status:  assigned  | Milestone:  1.2
 
 Component:  Database layer (models, ORM)  |   Version:  1.1
 
Resolution:|  Keywords: 
 
 Stage:  Accepted  | Has_patch:  0  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by marcosmoyano):

  * owner:  nobody => marcosmoyano
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10650: Clarify use of MEDIA_ROOT in default settings.py

[Django]

#10650: Clarify use of MEDIA_ROOT in default settings.py
-+--
  Reporter:  tvon| Owner:  jjconti   
Status:  assigned| Milestone:  1.2   
 Component:  Documentation   |   Version:  1.0   
Resolution:  |  Keywords:  pycamp2010
 Stage:  Design decision needed  | Has_patch:  0 
Needs_docs:  0   |   Needs_tests:  0 
Needs_better_patch:  0   |  
-+--
Changes (by jjconti):

  * keywords:  => pycamp2010

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13032: USE_THOUSAND_SEPARATOR breaks forms by formatting primary key values, causing error on save

[Django]

#13032: USE_THOUSAND_SEPARATOR breaks forms by formatting primary key values,
causing error on save
---+
  Reporter:  exo...@gmail.com  | Owner:  gonzalodelgado 
Status:  assigned  | Milestone:  1.2
 Component:  Uncategorized |   Version:  SVN
Resolution:|  Keywords:  formats l10n locale
 Stage:  Accepted  | Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by gonzalodelgado):

  * owner:  nobody => gonzalodelgado
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #12247: update on empty queryset in which the update kwargs refer to inherited columns update all rows of base table

[Django]

#12247: update on empty queryset in which the update kwargs refer to inherited
columns update all rows of base table
---+
  Reporter:  jsmullyan | Owner:  nessita
Status:  assigned  | Milestone:  1.2
 Component:  Database layer (models, ORM)  |   Version:  1.1
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by nessita):

  * owner:  nobody => nessita
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #11975: invalid sql returned from django.db.backends.sqlite3.DatabaseOperations.date_trunc_sql

[Django]

#11975: invalid sql returned from
django.db.backends.sqlite3.DatabaseOperations.date_trunc_sql
---+
  Reporter:  ako...@gmail.com  | Owner:  fgallina   
  
Status:  new   | Milestone:  1.2
  
 Component:  Database layer (models, ORM)  |   Version:  SVN
  
Resolution:|  Keywords:  sqlite 
DatabaseOperations
 Stage:  Accepted  | Has_patch:  0  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Changes (by fgallina):

  * owner:  nobody => fgallina

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13041: Error on InlineModel Admin

[Django]

#13041: Error on InlineModel Admin
---+
  Reporter:  mdpetry   | Owner:  matiasb
Status:  assigned  | Milestone:  1.2
 Component:  django.contrib.admin  |   Version:  1.1
Resolution:|  Keywords: 
 Stage:  Accepted  | Has_patch:  0  
Needs_docs:  0 |   Needs_tests:  0  
Needs_better_patch:  0 |  
---+
Changes (by matiasb):

  * owner:  nobody => matiasb
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Changeset] r12689 - in django/branches/releases/1.1.X: . django/core tests/regressiontests/mail

[noreply]

Author: kmtracey
Date: 2010-03-06 10:07:05 -0600 (Sat, 06 Mar 2010)
New Revision: 12689

Modified:
   django/branches/releases/1.1.X/
   django/branches/releases/1.1.X/django/core/mail.py
   django/branches/releases/1.1.X/tests/regressiontests/mail/tests.py
Log:
[1.1.X] Fixed #6918, #12791: If an email message has an encoding, actually use 
that encoding to encode body and headers. Thanks for patch with tests oyvind.

Backport of r12683 and r12688 from trunk.




Property changes on: django/branches/releases/1.1.X
___
Name: svnmerge-integrated
   - 
/django/trunk:1-11500,11523,11527-11528,11531-11552,11554,11577,11579-11581,11588-11589,11591-11592,11596-11599,11601-11617,11619-11626,11628-11635,11637-11638,11643-11644,11648-11653,11656,11670,11678,11681,11684,11686,11688,11691,11693,11695,11697,11699,11701,11703,11705,11707,11714,11719,11732,11734,11740,11748,11751,11753,11756,11760,11800,11802,11808,11815,11817,11820,11822,11824,11826,11828,11831,11833,11835,11837,11839,11841,11844,11857,11864,11874,11876,11878,11885,11898,11901,11905,11909,11912,11914,11917,11938,11953,11961,11977,11979,11984,11986,11988,11990,11992,11994,11996,11998,12001,12004,12006,12011,12022,12024,12044-12045,12048,12054-12056,12059,12064,12066,12068,12070,12079,12086,12088,12104,12118,12132,12137-12138,12140-12141,12144,12150-12152,12220-12221,12229,12249,12253,12276,12282,12284,12293,12313,12317-12324,12333,12341,12343,12346,12353,12362,12379,12384,12398,12405,12408-12411,12419-12420,12423,12425-12426,12429,12434,12436,12439-12442,12448,12457,12461-12464,12467,12473,12475,12490,12492,12497-12498,12502,12513,12515-12516,12518,12523,12526,12528,12533,12535,12537,12539,12541,12548,12553,12556,12558-12560,12562,12567,12569-12570,12573,12576,12581,12584,12616,12621-12622,12631,12648,12650,12652,12659,12661,12676,12679,12681
   + 
/django/trunk:1-11500,11523,11527-11528,11531-11552,11554,11577,11579-11581,11588-11589,11591-11592,11596-11599,11601-11617,11619-11626,11628-11635,11637-11638,11643-11644,11648-11653,11656,11670,11678,11681,11684,11686,11688,11691,11693,11695,11697,11699,11701,11703,11705,11707,11714,11719,11732,11734,11740,11748,11751,11753,11756,11760,11800,11802,11808,11815,11817,11820,11822,11824,11826,11828,11831,11833,11835,11837,11839,11841,11844,11857,11864,11874,11876,11878,11885,11898,11901,11905,11909,11912,11914,11917,11938,11953,11961,11977,11979,11984,11986,11988,11990,11992,11994,11996,11998,12001,12004,12006,12011,12022,12024,12044-12045,12048,12054-12056,12059,12064,12066,12068,12070,12079,12086,12088,12104,12118,12132,12137-12138,12140-12141,12144,12150-12152,12220-12221,12229,12249,12253,12276,12282,12284,12293,12313,12317-12324,12333,12341,12343,12346,12353,12362,12379,12384,12398,12405,12408-12411,12419-12420,12423,12425-12426,12429,12434,12436,12439-12442,12448,12457,12461-12464,12467,12473,12475,12490,12492,12497-12498,12502,12513,12515-12516,12518,12523,12526,12528,12533,12535,12537,12539,12541,12548,12553,12556,12558-12560,12562,12567,12569-12570,12573,12576,12581,12584,12616,12621-12622,12631,12648,12650,12652,12659,12661,12676,12679,12681,12683,12688


Modified: django/branches/releases/1.1.X/django/core/mail.py
===
--- django/branches/releases/1.1.X/django/core/mail.py  2010-03-06 15:50:12 UTC 
(rev 12688)
+++ django/branches/releases/1.1.X/django/core/mail.py  2010-03-06 16:07:05 UTC 
(rev 12689)
@@ -69,8 +69,9 @@
 class BadHeaderError(ValueError):
 pass
 
-def forbid_multi_line_headers(name, val):
+def forbid_multi_line_headers(name, val, encoding):
 """Forbids multi-line headers, to prevent header injection."""
+encoding = encoding or settings.DEFAULT_CHARSET
 val = force_unicode(val)
 if '\n' in val or '\r' in val:
 raise BadHeaderError("Header values can't contain newlines (got %r for 
header %r)" % (val, name))
@@ -80,24 +81,34 @@
 if name.lower() in ('to', 'from', 'cc'):
 result = []
 for nm, addr in getaddresses((val,)):
-nm = str(Header(nm, settings.DEFAULT_CHARSET))
+nm = str(Header(nm.encode(encoding), encoding))
 result.append(formataddr((nm, str(addr
 val = ', '.join(result)
 else:
-val = Header(val, settings.DEFAULT_CHARSET)
+val = Header(val.encode(encoding), encoding)
 else:
 if name.lower() == 'subject':
 val = Header(val)
 return name, val
 
 class SafeMIMEText(MIMEText):
+
+def __init__(self, text, subtype, charset):
+self.encoding = charset
+MIMEText.__init__(self, text, subtype, charset)
+
 def __setitem__(self, name, val):
-name, val = forbid_multi_line_headers(name, val)
+name, val = forbid_multi_line_headers(name, val, self.encoding)
 MIMEText.__setitem__(self, name, val)
 
 class SafeMIMEMultipart(MIMEMultipart):
+
+

[Changeset] r12688 - in django/trunk: django/core/mail tests/regressiontests/mail

[noreply]

Author: kmtracey
Date: 2010-03-06 09:50:12 -0600 (Sat, 06 Mar 2010)
New Revision: 12688

Modified:
   django/trunk/django/core/mail/message.py
   django/trunk/tests/regressiontests/mail/tests.py
Log:
Fixed #6918: Adjusted the test in r12683 to more specifically look for what it 
is testing so it doesn't get thrown off by other minor differences in email 
ouput (hopefully). Also put a docstring back in its place.


Modified: django/trunk/django/core/mail/message.py
===
--- django/trunk/django/core/mail/message.py2010-03-06 11:21:48 UTC (rev 
12687)
+++ django/trunk/django/core/mail/message.py2010-03-06 15:50:12 UTC (rev 
12688)
@@ -55,8 +55,8 @@
 
 
 def forbid_multi_line_headers(name, val, encoding):
+"""Forbids multi-line headers, to prevent header injection."""
 encoding = encoding or settings.DEFAULT_CHARSET
-"""Forbids multi-line headers, to prevent header injection."""
 val = force_unicode(val)
 if '\n' in val or '\r' in val:
 raise BadHeaderError("Header values can't contain newlines (got %r for 
header %r)" % (val, name))

Modified: django/trunk/tests/regressiontests/mail/tests.py
===
--- django/trunk/tests/regressiontests/mail/tests.py2010-03-06 11:21:48 UTC 
(rev 12687)
+++ django/trunk/tests/regressiontests/mail/tests.py2010-03-06 15:50:12 UTC 
(rev 12688)
@@ -147,8 +147,10 @@
 >>> msg = EmailMultiAlternatives('Subject', text_content, 'f...@example.com', 
 >>> ['t...@example.com'])
 >>> msg.encoding = 'iso-8859-1'
 >>> msg.attach_alternative(html_content, "text/html")
->>> msg.message().as_string()
-'Content-Type: multipart/alternative; 
boundary="===...=="\nMIME-Version: 1.0\nSubject: Subject\nFrom: 
f...@example.com\nto: t...@example.com\ndate: ...\nMessage-ID: 
<...>\n\n--===...==\nContent-Type: text/plain; 
charset="iso-8859-1"\nMIME-Version: 1.0\nContent-Transfer-Encoding: 
quoted-printable\n\nFirstname S=FCrname is a great 
guy.\n--===...==\nContent-Type: text/html; 
charset="iso-8859-1"\nMIME-Version: 1.0\nContent-Transfer-Encoding: 
quoted-printable\n\nFirstname S=FCrname is a great 
guy.\n--===...==--'
+>>> msg.message().get_payload(0).as_string()
+'Content-Type: text/plain; charset="iso-8859-1"\nMIME-Version: 
1.0\nContent-Transfer-Encoding: quoted-printable\n\nFirstname S=FCrname is a 
great guy.'
+>>> msg.message().get_payload(1).as_string()
+'Content-Type: text/html; charset="iso-8859-1"\nMIME-Version: 
1.0\nContent-Transfer-Encoding: quoted-printable\n\nFirstname S=FCrname is a 
great guy.'
 
 # Handle attachments within an multipart/alternative mail correctly (#9367)
 # (test is not as precise/clear as it could be w.r.t. email tree structure,

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10650: Clarify use of MEDIA_ROOT in default settings.py

[Django]

#10650: Clarify use of MEDIA_ROOT in default settings.py
-+--
  Reporter:  tvon| Owner:  jjconti
Status:  assigned| Milestone:  1.2
 Component:  Documentation   |   Version:  1.0
Resolution:  |  Keywords: 
 Stage:  Design decision needed  | Has_patch:  0  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by jjconti):

  * owner:  nobody => jjconti
  * status:  new => assigned

Comment:

 Files to modify?

 django/conf/global_settings.py

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13038: readonly_fields in an Admin changeform don't have their name added as a HTML class

[Django]

#13038: readonly_fields in an Admin changeform don't have their name added as a
HTML class
---+
  Reporter:  andybak   | Owner:  javimansilla   

Status:  new   | Milestone:  1.2

 Component:  django.contrib.admin  |   Version:  1.2-beta   

Resolution:|  Keywords:  admin changeform 
readonly_field
 Stage:  Accepted  | Has_patch:  0  

Needs_docs:  0 |   Needs_tests:  0  

Needs_better_patch:  0 |  
---+
Changes (by anonymous):

  * owner:  nobody => javimansilla

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6918: Cannot set encoding of mail headers, only of message body

[Django]

#6918: Cannot set encoding of mail headers, only of message body
---+
  Reporter:  Grzegorz Lukasik   | Owner:  
serialx  
Status:  reopened  | Milestone: 
  
 Component:  django.core.mail  |   Version:  
SVN  
Resolution:|  Keywords:  
encoding mail headers
 Stage:  Design decision needed| Has_patch:  1  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Changes (by kmtracey):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 Test is causing a failure on the buildbots:
 http://buildbot.djangoproject.com/waterfall

 Near as I can tell the only significant difference in the output is that
 the test is expecting the multipart message to start:

 {{{
 Content-Type: multipart/alternative; boundary=
 }}}

 But instead is getting:

 {{{
 Content-Type: multipart/alternative;\n\tboundary=
 }}}

 Buildbots are ubutntu, running Pythons 2.4, 2.5, 2.6. Oddly enough the
 test worked on my Ubuntu (older) using Python 2.5.  Any clue what's
 causing this? I suppose we can just change the test to not care whether
 `multipart-alternative;` is followed by `\n\t` or not, since what we are
 really testing for is that the correct encoding has been used in the
 content

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13044: Small Spanish translation improvement

[Django]

#13044: Small Spanish translation improvement
---+
  Reporter:  leninyee  | Owner:  nobody  
Status:  new   | Milestone:  1.2 
 Component:  Translations  |   Version:  1.2-beta
Resolution:|  Keywords:  
 Stage:  Accepted  | Has_patch:  1   
Needs_docs:  0 |   Needs_tests:  0   
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * needs_better_patch:  => 0
  * needs_docs:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * milestone:  => 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13043: Default manage.py should print ImportError

[Django]

#13043: Default manage.py should print ImportError
+---
  Reporter:  sdolan | Owner:  nobody  
Status:  new| Milestone:  
 Component:  Uncategorized  |   Version:  1.2-beta
Resolution: |  Keywords:  
 Stage:  Accepted   | Has_patch:  1   
Needs_docs:  0  |   Needs_tests:  0   
Needs_better_patch:  0  |  
+---
Changes (by russellm):

  * stage:  Unreviewed => Accepted

Comment:

 This is something that falls in the general category of
 BetterErrorMessages.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13041: Error on InlineModel Admin

[Django]

#13041: Error on InlineModel Admin
---+
  Reporter:  mdpetry   | Owner:  nobody
Status:  new   | Milestone:  1.2   
 Component:  django.contrib.admin  |   Version:  1.1   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  0 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13040: Would like to add import statments for class documentation where needed

[Django]

#13040: Would like to add import statments for class documentation where needed
+---
  Reporter:  stherrien  | Owner:  nobody
Status:  closed | Milestone:
 Component:  Documentation  |   Version:  1.1   
Resolution:  wontfix|  Keywords:
 Stage:  Unreviewed | Has_patch:  1 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by russellm):

  * status:  new => closed
  * resolution:  => wontfix

Comment:

 Sphinx provides much better ways to do this. You don't need to manually
 include an include statement like the one you describe, you need to make
 the ".. class::" declaration fully qualified, or set the package context
 so that a classname-only declaration knows the right path.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #13038: readonly_fields in an Admin changeform don't have their name added as a HTML class

[Django]

#13038: readonly_fields in an Admin changeform don't have their name added as a
HTML class
---+
  Reporter:  andybak   | Owner:  nobody 

Status:  new   | Milestone:  1.2

 Component:  django.contrib.admin  |   Version:  1.2-beta   

Resolution:|  Keywords:  admin changeform 
readonly_field
 Stage:  Accepted  | Has_patch:  0  

Needs_docs:  0 |   Needs_tests:  0  

Needs_better_patch:  0 |  
---+
Changes (by russellm):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * needs_docs:  => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Changeset] r12687 - django/branches/releases/1.1.X/docs/howto

[noreply]

Author: ubernostrum
Date: 2010-03-06 05:21:48 -0600 (Sat, 06 Mar 2010)
New Revision: 12687

Modified:
   django/branches/releases/1.1.X/docs/howto/error-reporting.txt
Log:
[1.1.X] Fixed #11680: Added a note in the error-reporting documentation about 
basic e-mail configuration. Backport of [12686] from trunk.

Modified: django/branches/releases/1.1.X/docs/howto/error-reporting.txt
===
--- django/branches/releases/1.1.X/docs/howto/error-reporting.txt   
2010-03-06 11:20:50 UTC (rev 12686)
+++ django/branches/releases/1.1.X/docs/howto/error-reporting.txt   
2010-03-06 11:21:48 UTC (rev 12687)
@@ -23,6 +23,17 @@
 get a description of the error, a complete Python traceback, and details about
 the HTTP request that caused the error.
 
+.. note::
+
+   In order to send e-mail, Django requires a few settings telling it
+   how to connect to your mail server. At the very least, you'll need
+   to specify :setting:`EMAIL_HOST` and possibly
+   :setting:`EMAIL_HOST_USER` and :setting:`EMAIL_HOST_PASSWORD`,
+   though other settings may be also required depending on your mail
+   server's configuration. Consult :ref:`the Django settings
+   documentation ` for a full list of email-related
+   settings.
+
 By default, Django will send email from r...@localhost. However, some mail
 providers reject all email from this address. To use a different sender
 address, modify the :setting:`SERVER_EMAIL` setting.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Changeset] r12686 - django/trunk/docs/howto

[noreply]

Author: ubernostrum
Date: 2010-03-06 05:20:50 -0600 (Sat, 06 Mar 2010)
New Revision: 12686

Modified:
   django/trunk/docs/howto/error-reporting.txt
Log:
Fixed #11680: Added a note in the error-reporting documentation about basic 
e-mail configuration.

Modified: django/trunk/docs/howto/error-reporting.txt
===
--- django/trunk/docs/howto/error-reporting.txt 2010-03-06 11:11:55 UTC (rev 
12685)
+++ django/trunk/docs/howto/error-reporting.txt 2010-03-06 11:20:50 UTC (rev 
12686)
@@ -23,6 +23,17 @@
 get a description of the error, a complete Python traceback, and details about
 the HTTP request that caused the error.
 
+.. note::
+
+   In order to send e-mail, Django requires a few settings telling it
+   how to connect to your mail server. At the very least, you'll need
+   to specify :setting:`EMAIL_HOST` and possibly
+   :setting:`EMAIL_HOST_USER` and :setting:`EMAIL_HOST_PASSWORD`,
+   though other settings may be also required depending on your mail
+   server's configuration. Consult :ref:`the Django settings
+   documentation ` for a full list of email-related
+   settings.
+
 By default, Django will send email from r...@localhost. However, some mail
 providers reject all email from this address. To use a different sender
 address, modify the :setting:`SERVER_EMAIL` setting.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.