Re: [Django] #18742: Template tag length returns invalid value

2012-08-11 Thread Django
#18742: Template tag length returns invalid value
-+--
 Reporter:  lukaslipka@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by kmtracey):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Not sure what to do about this one. During the evaluation of the filter
 expression condition in the if tag, `blabla` is evaluated as a
 `TemplateLiteral`, which resolves the value in the context specifying
 `ignore_failures=True`:

 
https://github.com/django/django/blob/stable/1.4.x/django/template/defaulttags.py#L814

 With ignore_failures True, the value resolves to None instead of the empty
 string it would resolve to if ignore_failures was False. None as the value
 for the length filter causes length to return an empty string:

 
https://github.com/django/django/blob/stable/1.4.x/django/template/defaultfilters.py#L540

 Subsequently when evaluating `{{ blabla|length }}`, `blabla` is resolved
 with ignore_failures False, so it resolve to the empty string. And the
 length of the empty string is 0.

 Changing `TemplateLiteral` eval to not specify ignore_failures=True breaks
 a bunch of if tag template tests. Changing the length filter to return 0
 instead of the empty string for invalid inputs breaks a bunch of length
 filter tests. Whether either of these changes would break real code I'm
 not sure (length returning an empty string, in particular, seems an odd
 thing to me...though I can see how that may actually be used to display no
 output at all for non-existent data rather than 0...so I suspect changing
 that would in fact break things in some real code). Either of them does
 make the template fragment in the description behave sanely, but neither
 is backwards-compatible.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [Django] #10790: Too many joins in a comparison for NULL.

2012-08-11 Thread Django
#10790: Too many joins in a comparison for NULL.
-+-
 Reporter:  mtredinnick  |Owner:
 Type:  Bug  |  mtredinnick
Component:  Database layer   |   Status:  new
  (models, ORM)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by akaariai):

 I have now a working version of join trimming beforehand. The approach
 taken in setup_joins is this:
   1. Walk the lookup path, and turn it into "JoinPath" structures. The
 structures basically tell from which model we are coming from, and to
 which model we are going to, and using which fields. All different join
 types are converted to these simple join structures (m2m, generic relation
 joins etc).
   2. Trim non-necessary joins from the path. This is easy to do at this
 stage.
   3. Generate the actual joins. This again is pretty trivial, just call
 self.join() for the generated joins.

 I think it would be possible to get totally rid of trim_joins(), but it
 seems to do some special trimming which the trim in setup_joins() can't do
 currently. The trimming logic of setup_joins() could be improved easily.

 There were some complications related to generic relations. When fixing
 this I ended up removing the whole process_extra hack. Now the generic
 relations extra join restriction is appended directly into the join
 clause:
 {{{
 JOIN a on (a.id = b.object_id and b.content_type_id = xxx)
 }}}
 This should result in correctly working joins in .exclude() and LEFT OUTER
 JOIN cases, though I haven't added any tests.

 In addition I had to make the m2m through models pickleable. I don't know
 if the approach used was correct, but at least it works.

 Apart of the above there is one test failure. It is related to combining
 ORed queries. In short the combined query now uses LEFT JOIN for one join
 where INNER JOIN would be correct, and the reason for this is that pre-
 patch one join was added, then trimmed (so it was with refcount of 0 in
 the query), but now it is never even added to the query. I think I know
 how to fix this one, but haven't done so yet.

 In total I think the patch is a major cleanup to the join logic, and it
 should allow further improvements if the names_to_path call would be done
 already in add_filter (or even add_q) stage.

 However, there is very little chance this one can ever end up in 1.4. This
 is just too big of a patch. For 1.4 the correct approach will be to teach
 the trim_joins to just trim the extra joins.

 The new patch can be found from:
 https://github.com/akaariai/django/tree/new_10790

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [Django] #18739: {% widthratio %} fails on sql NULL objects

2012-08-11 Thread Django
#18739: {% widthratio %} fails on sql NULL objects
-+
 Reporter:  ja.geb@… |  Owner:  nobody
 Type:  Bug  | Status:  closed
Component:  Template system  |Version:  1.4
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |   Triage Stage:  Unreviewed
Has patch:  0|  Easy pickings:  0
UI/UX:  0|
-+
Changes (by Karen Tracey ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [759ae3c2dafe149485a15d9a3bc97527c1ac1163]:
 {{{
 #!CommitTicketReference repository=""
 revision="759ae3c2dafe149485a15d9a3bc97527c1ac1163"
 Fixed #18739 -- witdthratio behavior on None args

 Made behavior given None consistent with how non-numerics were handled.
 Thanks to ja@me.com for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[django/django] 759ae3: Fixed #18739 -- witdthratio behavior on None args

2012-08-11 Thread GitHub
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 759ae3c2dafe149485a15d9a3bc97527c1ac1163
  
https://github.com/django/django/commit/759ae3c2dafe149485a15d9a3bc97527c1ac1163
  Author: Karen Tracey 
  Date:   2012-08-11 (Sat, 11 Aug 2012)

  Changed paths:
M django/template/defaulttags.py
M tests/regressiontests/templates/tests.py

  Log Message:
  ---
  Fixed #18739 -- witdthratio behavior on None args

Made behavior given None consistent with how non-numerics were handled.
Thanks to ja@me.com for the report.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [Django] #18733: Form ids on as_table

2012-08-11 Thread Django
#18733: Form ids on as_table
-+--
 Reporter:  tturner  |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by kmtracey):

 * status:  new => closed
 * needs_docs:   => 0
 * resolution:   => wontfix
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 You can traverse the DOM in javascript and locate items that do not have
 ids relative to ones that do (or within containers external to this
 rendering that have classes or ids specified). So I think the statement
 that you cannot access certain parts of this rendering in javascript is
 not true, therefore I don't see the need to add all these ids in the
 rendering.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[django/django] 15fffc: [py3] Fixed reraising of exceptions

2012-08-11 Thread GitHub
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 15fffcc7510ec2bf0fafdc254206619a8ab0923f
  
https://github.com/django/django/commit/15fffcc7510ec2bf0fafdc254206619a8ab0923f
  Author: Claude Paroz 
  Date:   2012-08-11 (Sat, 11 Aug 2012)

  Changed paths:
M django/core/handlers/base.py
M django/db/models/query.py
M django/test/client.py

  Log Message:
  ---
  [py3] Fixed reraising of exceptions

reraise with second argument to None is not supported.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[django/django] be7f10: Decorated some tests that require tz support.

2012-08-11 Thread GitHub
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: be7f1099c61004bda8c491fc4e7aab9f8b2c8512
  
https://github.com/django/django/commit/be7f1099c61004bda8c491fc4e7aab9f8b2c8512
  Author: Karen Tracey 
  Date:   2012-08-11 (Sat, 11 Aug 2012)

  Changed paths:
M tests/modeltests/timezones/tests.py
M tests/regressiontests/generic_views/dates.py

  Log Message:
  ---
  Decorated some tests that require tz support.

This allows the test suite to run without errors on Windows.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[django/django] 7d0f88: [py3] Fixed JSON deserialization

2012-08-11 Thread GitHub
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 7d0f8831922535502569a5dda989dde339b4e491
  
https://github.com/django/django/commit/7d0f8831922535502569a5dda989dde339b4e491
  Author: Claude Paroz 
  Date:   2012-08-11 (Sat, 11 Aug 2012)

  Changed paths:
M django/core/serializers/json.py

  Log Message:
  ---
  [py3] Fixed JSON deserialization


  Commit: 66021033381f154ddf8a9ecf93fcbb41a7abda17
  
https://github.com/django/django/commit/66021033381f154ddf8a9ecf93fcbb41a7abda17
  Author: Claude Paroz 
  Date:   2012-08-11 (Sat, 11 Aug 2012)

  Changed paths:
M tests/modeltests/files/tests.py
M tests/regressiontests/decorators/tests.py
M tests/regressiontests/fixtures_regress/tests.py
M tests/regressiontests/forms/tests/models.py
M tests/regressiontests/generic_views/base.py
M tests/regressiontests/generic_views/dates.py
M tests/regressiontests/httpwrappers/tests.py
M tests/regressiontests/views/tests/shortcuts.py

  Log Message:
  ---
  [py3] Various minor syntax fixes in the test suite


  Commit: 900816464dbd7b1fcc009177f9de03791edc6e88
  
https://github.com/django/django/commit/900816464dbd7b1fcc009177f9de03791edc6e88
  Author: Claude Paroz 
  Date:   2012-08-11 (Sat, 11 Aug 2012)

  Changed paths:
M django/core/validators.py
M django/utils/html.py

  Log Message:
  ---
  [py3] Re-decoded string after idna encoding


Compare: https://github.com/django/django/compare/b82eb10b2605...900816464dbd

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [Django] #18754: staticfiles test failure under Windows

2012-08-11 Thread Django
#18754: staticfiles test failure under Windows
-+-
 Reporter:  kmtracey |Owner:  kmtracey
 Type:  Bug  |   Status:  closed
Component:  contrib.staticfiles  |  Version:  1.4
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:
Has patch:  0|  Unreviewed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Karen Tracey ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [b82eb10b2605477b3e583c9378257a9e6c8fd2ed]:
 {{{
 #!CommitTicketReference repository=""
 revision="b82eb10b2605477b3e583c9378257a9e6c8fd2ed"
 Fixed #18754 -- cache keys created by post_process

 Corrected to always generate the cache keys from file names with
 forward slashes, not backslashes.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[django/django] b82eb1: Fixed #18754 -- cache keys created by post_process

2012-08-11 Thread GitHub
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: b82eb10b2605477b3e583c9378257a9e6c8fd2ed
  
https://github.com/django/django/commit/b82eb10b2605477b3e583c9378257a9e6c8fd2ed
  Author: Karen Tracey 
  Date:   2012-08-11 (Sat, 11 Aug 2012)

  Changed paths:
M django/contrib/staticfiles/storage.py

  Log Message:
  ---
  Fixed #18754 -- cache keys created by post_process

Corrected to always generate the cache keys from file names with
forward slashes, not backslashes.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[Django] #18754: staticfiles test failure under Windows

2012-08-11 Thread Django
#18754: staticfiles test failure under Windows
---+--
   Reporter:  kmtracey |  Owner:  kmtracey
   Type:  Bug  | Status:  new
  Component:  contrib.staticfiles  |Version:  1.4
   Severity:  Normal   |   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+--
 Recording this in a ticket to explain the code change.

 {{{
 C:\Users\kmtracey\django\git-django\tests>runtests.py
 --settings=test_sqlite
 staticfiles_tests.TestCollectionCachedStorage.test_template_tag_return
 staticfiles_tests.TestCollectionSimpleCachedStorage.test_template_tag_return
 Creating test database for alias 'default'...
 Creating test database for alias 'other'...
 .F
 ==
 FAIL: test_template_tag_return
 (regressiontests.staticfiles_tests.tests.TestCollectionSimpleCachedStorage)
 --
 Traceback (most recent call last):
   File "C:\Users\kmtracey\django\git-
 django\tests\regressiontests\staticfiles_tests\tests.py", line 560, in
 test_template_tag_return
 "/static/test/file.deploy12345.txt")
   File "C:\Users\kmtracey\django\git-
 django\tests\regressiontests\staticfiles_tests\tests.py", line 101, in
 assertStaticRenders
 self.assertEqual(self.render_template(template, **kwargs), result)
 AssertionError: u'/static/test/file.dad0999e4f8f.txt' !=
 u'/static/test/file.deploy12345.txt'
 - /static/test/file.dad0999e4f8f.txt
 ?--  ^^^
 + /static/test/file.deploy12345.txt
 ? +++ ^


 --
 Ran 2 tests in 1.036s

 FAILED (failures=1)
 Destroying test database for alias 'default'...
 Destroying test database for alias 'other'...
 }}}

 Both tests test the static rendering of static file "test/file.txt"

 The 2nd test is finding something put in the cache by the first test.

 During test setUp, where collectstatic is being called, !CachedFilesMixin
 post_process is setting up the cache keys for found files by:

 {{{
 #!python
 # and then set the cache accordingly
 hashed_paths[self.cache_key(name)] = hashed_name
 }}}

 here name has backslashes on Windows. Later during the first test run the
 name looked for has forward slashes, the cache key generated is different
 than what was put in the cache by setUp, cache misses, and a value is set
 in the cache for the key value generated with the forward slash version of
 the name. The cache is not cleared between tests and the 2nd call to setUp
 again sets up the cache using the names with backslashes, but then when
 the 2nd test looks up the name with forward slashes it finds the value
 previously set by the 1st test.

 Fix is to replace backslashes with forward slashes in the name used for
 key generation in post_process. I think. If not someone with a better
 grasp of this code feel free to step in with the real fix.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [Django] #18753: Views should be given the instance namespace retrieved during the resolve process

2012-08-11 Thread Django
#18753: Views should be given the instance namespace retrieved during the 
resolve
process
-+-
 Reporter:  GaretJax |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (URLs)  |  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  namespace| Triage Stage:  Design
  current_app|  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by GaretJax):

 * needs_better_patch:   => 1
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Design decision needed


Comment:

 I already create a PR for this (it got rejected as explained in
 https://github.com/django/django/pull/260) but I can edit to comply with
 the requested points.

 Before proceeding though, I'd like to discuss the addition of the
 'current_app' attribute to the HttpRequest class. Someone sees a better
 way to design this?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[Django] #18753: Views should be given the instance namespace retrieved during the resolve process

2012-08-11 Thread Django
#18753: Views should be given the instance namespace retrieved during the 
resolve
process
-+---
 Reporter:  GaretJax |  Owner:  nobody
 Type:  New feature  | Status:  new
Component:  Core (URLs)  |Version:  1.4
 Severity:  Normal   |   Keywords:  namespace current_app
 Triage Stage:  Unreviewed   |  Has patch:  1
Easy pickings:  1|  UI/UX:  0
-+---
 During the URL resolving process, the instance namespace is returned as
 part of the match object but then never propagated to the final view or
 made available to other middlewares (see
 
https://github.com/django/django/blob/master/django/core/handlers/base.py#L103).

 This value could be made available to the view as part of the request
 object (an attribute?) or another way which does not involve a second
 resolve call. It can then also be used as a default value for the
 'current_app' argument of the 'render' shortcut or the RequestContext
 class.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [Django] #18091: Non-ASCII templates break `django-admin.py startproject --template=TEMPLATE`

2012-08-11 Thread Django
#18091: Non-ASCII templates break `django-admin.py startproject
--template=TEMPLATE`
-+-
 Reporter:  akaihola |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  master
  commands)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by apollo13):

 * cc: apollo13 (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [Django] #18091: Non-ASCII templates break `django-admin.py startproject --template=TEMPLATE`

2012-08-11 Thread Django
#18091: Non-ASCII templates break `django-admin.py startproject
--template=TEMPLATE`
-+-
 Reporter:  akaihola |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  master
  commands)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by apollo13):

 The patch in the current form causes the following test failures for me:
 {{{
 florian@apollo13:~/sources/django.git/tests$ PYTHONPATH=.. ./runtests.py
 --settings=test_sqlite admin_scripts
 Creating test database for alias 'default'...
 Creating test database for alias 'other'...
 
.FF..F...F.
 ==
 FAIL: test_custom_project_template
 (regressiontests.admin_scripts.tests.StartProject)
 Make sure the startproject management command is able to use a different
 project template
 --
 Traceback (most recent call last):
   File
 
"/home/florian/sources/django.git/tests/regressiontests/admin_scripts/tests.py",
 line 1444, in test_custom_project_template
 self.assertNoOutput(err)
   File
 
"/home/florian/sources/django.git/tests/regressiontests/admin_scripts/tests.py",
 line 159, in assertNoOutput
 self.assertEqual(len(stream), 0, "Stream should be empty: actually
 contains '%s'" % stream)
 AssertionError: Stream should be empty: actually contains
 'UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 47:
 ordinal not in range(128)
 '

 ==
 FAIL: test_custom_project_template_context_variables
 (regressiontests.admin_scripts.tests.StartProject)
 Make sure template context variables are rendered with proper values
 --
 Traceback (most recent call last):
   File
 
"/home/florian/sources/django.git/tests/regressiontests/admin_scripts/tests.py",
 line 1537, in test_custom_project_template_context_variables
 self.assertNoOutput(err)
   File
 
"/home/florian/sources/django.git/tests/regressiontests/admin_scripts/tests.py",
 line 159, in assertNoOutput
 self.assertEqual(len(stream), 0, "Stream should be empty: actually
 contains '%s'" % stream)
 AssertionError: Stream should be empty: actually contains
 'UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 47:
 ordinal not in range(128)
 '

 ==
 FAIL: test_no_escaping_of_project_variables
 (regressiontests.admin_scripts.tests.StartProject)
 Make sure template context variables are not html escaped
 --
 Traceback (most recent call last):
   File
 
"/home/florian/sources/django.git/tests/regressiontests/admin_scripts/tests.py",
 line 1554, in test_no_escaping_of_project_variables
 self.assertNoOutput(err)
   File
 
"/home/florian/sources/django.git/tests/regressiontests/admin_scripts/tests.py",
 line 159, in assertNoOutput
 self.assertEqual(len(stream), 0, "Stream should be empty: actually
 contains '%s'" % stream)
 AssertionError: Stream should be empty: actually contains
 'UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 47:
 ordinal not in range(128)
 '

 ==
 FAIL: test_template_dir_with_trailing_slash
 (regressiontests.admin_scripts.tests.StartProject)
 Ticket 17475: Template dir passed has a trailing path separator
 --
 Traceback (most recent call last):
   File
 
"/home/florian/sources/django.git/tests/regressiontests/admin_scripts/tests.py",
 line 1456, in test_template_dir_with_trailing_slash
 self.assertNoOutput(err)
   File
 
"/home/florian/sources/django.git/tests/regressiontests/admin_scripts/tests.py",
 line 159, in assertNoOutput
 self.assertEqual(len(stream), 0, "Stream should be empty: actually
 contains '%s'" % stream)
 AssertionError: Stream should be empty: actually contains
 'UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 47:
 ordinal not in range(128)
 '

 --
 Ran 147 te

Re: [Django] #18698: Package inputenc Error: Unicode char \u8:≥ not set up for use with LaTeX.

2012-08-11 Thread Django
#18698: Package inputenc Error: Unicode char \u8:≥ not set up for use with 
LaTeX.
---+
 Reporter:  simonb |Owner:  andrews
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by Florian Apolloner ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [4d9e4c64f1330fbdfe6a7931879deebf7154f403]:
 {{{
 #!CommitTicketReference repository=""
 revision="4d9e4c64f1330fbdfe6a7931879deebf7154f403"
 Fixed #18698 -- Configure latex to support '≥' in the docs.

 Thanks to simonb for the report and the initial patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[django/django] 4d9e4c: Fixed #18698 -- Configure latex to support '≥' i...

2012-08-11 Thread GitHub
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 4d9e4c64f1330fbdfe6a7931879deebf7154f403
  
https://github.com/django/django/commit/4d9e4c64f1330fbdfe6a7931879deebf7154f403
  Author: Florian Apolloner 
  Date:   2012-08-11 (Sat, 11 Aug 2012)

  Changed paths:
M docs/conf.py

  Log Message:
  ---
  Fixed #18698 -- Configure latex to support '≥' in the docs.

Thanks to simonb for the report and the initial patch.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [Django] #16715: Wrong JOIN with nested null-able foreign keys

2012-08-11 Thread Django
#16715: Wrong JOIN with nested null-able foreign keys
-+-
 Reporter:  sebastian|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  join, values,|  Needs documentation:  0
  nested, foreign key, null-able |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by akaariai):

 There is an additional cleanup done to add_filter available from:
 https://github.com/akaariai/django/tree/ticket16715_more

 The code generates less outer joins, but passes all tests. I have to still
 verify the queries where the amount of outer joins is altered and see that
 the generated queries are valid. So, this is currently mostly
 investigative work.

 However I am pretty sure there is something fishy going on in the
 add_fitlter join promotion. The problem is the assumed pairwise symmetry
 between the join_list and self.tables. As far as I understand this
 symmetry simply doesn't exist in general.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[django/django] 3eb28d: [py3] Used six.StringIO to simulate stdout buffer ...

2012-08-11 Thread GitHub
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 3eb28d011927a657cad1bf4463611a72c6bb1325
  
https://github.com/django/django/commit/3eb28d011927a657cad1bf4463611a72c6bb1325
  Author: Claude Paroz 
  Date:   2012-08-11 (Sat, 11 Aug 2012)

  Changed paths:
M tests/modeltests/invalid_models/tests.py
M tests/regressiontests/fixtures_regress/tests.py
M tests/regressiontests/m2m_through_regress/tests.py
M tests/regressiontests/staticfiles_tests/tests.py

  Log Message:
  ---
  [py3] Used six.StringIO to simulate stdout buffer in tests



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[django/django] 09c589: [py3] Used smart_str to prevent regressions in htt...

2012-08-11 Thread GitHub
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 09c589810d54ef14132084e34f4ef6133fdac3b9
  
https://github.com/django/django/commit/09c589810d54ef14132084e34f4ef6133fdac3b9
  Author: Claude Paroz 
  Date:   2012-08-11 (Sat, 11 Aug 2012)

  Changed paths:
M django/http/__init__.py

  Log Message:
  ---
  [py3] Used smart_str to prevent regressions in http handling



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[django/django] 22527a: [py3] Fixed str_prefix test utility

2012-08-11 Thread GitHub
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 22527a821bbca73a4900906be8b01c81a414ad95
  
https://github.com/django/django/commit/22527a821bbca73a4900906be8b01c81a414ad95
  Author: Claude Paroz 
  Date:   2012-08-11 (Sat, 11 Aug 2012)

  Changed paths:
M django/test/utils.py

  Log Message:
  ---
  [py3] Fixed str_prefix test utility


  Commit: f10a1b06416e59a66cc9c3c8437fe045cb0fb03c
  
https://github.com/django/django/commit/f10a1b06416e59a66cc9c3c8437fe045cb0fb03c
  Author: Claude Paroz 
  Date:   2012-08-11 (Sat, 11 Aug 2012)

  Changed paths:
M django/http/__init__.py
M django/http/multipartparser.py

  Log Message:
  ---
  [py3] Fixed Python 3 compatibility of http handling

* Using str() when Python 2 expects bytes and Python 3 Unicode
* Fixed reraise-ing syntax
* Fixed slicing of byte strings


Compare: https://github.com/django/django/compare/97fe70d30bdd...f10a1b06416e

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [Django] #18751: `BaseFormSet._should_delete_form` should use `form.cleaned_data`

2012-08-11 Thread Django
#18751: `BaseFormSet._should_delete_form` should use `form.cleaned_data`
--+
 Reporter:  charettes |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  formset   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by charettes):

 [https://code.djangoproject.com/attachment/ticket/10711/10711-2.diff this
 patch] looks better thank mines since you don't have to change the test
 suite and you reuse the `deleted_forms` code path.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[django/django] 97fe70: [py3] Used BytesIO to test request streams

2012-08-11 Thread GitHub
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 97fe70d30bddfa24bf5ef5d2148a1a5ae6bf54b2
  
https://github.com/django/django/commit/97fe70d30bddfa24bf5ef5d2148a1a5ae6bf54b2
  Author: Claude Paroz 
  Date:   2012-08-11 (Sat, 11 Aug 2012)

  Changed paths:
M tests/regressiontests/requests/tests.py

  Log Message:
  ---
  [py3] Used BytesIO to test request streams



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [Django] #10711: Add a hook for specifying whether a form in a formset should be deleted

2012-08-11 Thread Django
#10711: Add a hook for specifying whether a form in a formset should be deleted
-+-
 Reporter:  bretthoerner |Owner:
 Type:  New feature  |  jkocherhans
Component:  Forms|   Status:  closed
 Severity:  Normal   |  Version:
 Keywords:  admin forms formset  |   Resolution:  fixed
  deletion   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by claudep):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 I'm closing it as the original ticket subject is resolved
 (`_should_delete_form`). Cleaning up is tracked in #18751.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [Django] #18751: `BaseFormSet._should_delete_form` should use `form.cleaned_data`

2012-08-11 Thread Django
#18751: `BaseFormSet._should_delete_form` should use `form.cleaned_data`
--+
 Reporter:  charettes |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  formset   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by claudep):

 * stage:  Unreviewed => Accepted


Comment:

 Interestingly, I have uploaded a similar patch to #10711
 (https://code.djangoproject.com/attachment/ticket/10711/10711-2.diff). I
 will close it in favour of this one. Maybe there is something to merge
 between both patches?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




Re: [Django] #18750: contrib.admindocs coupled to contrib.sites

2012-08-11 Thread Django
#18750: contrib.admindocs coupled to contrib.sites
---+--
 Reporter:  yoyoma |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  master
 Severity:  Normal |   Resolution:  needsinfo
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by claudep):

 * status:  new => closed
 * needs_docs:   => 0
 * resolution:   => needsinfo
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 Sorry, I failed to reproduce the issue. Can you tell us what error you are
 getting and when?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.




[Django] #18752: Improve CBV Docs

2012-08-11 Thread Django
#18752: Improve CBV Docs
--+
 Reporter:  issackelly|  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Documentation |Version:  master
 Severity:  Normal|   Keywords:  CBV
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 https://github.com/django/django/pull/261

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.