Re: [Django] #18733: Form ids on as_table

[Django]

#18733: Form ids on as_table
-+--
 Reporter:  tturner  |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by kmtracey):

 * status:  reopened => closed
 * resolution:   => wontfix


Comment:

 I'm not sure what you are asking to be shown how to do so I'm at a loss to
 give you an example of how to do it. I suggest you ask a specific question
 for what you'd like to do on someplace like django-users or #django IRC.
 Neither CSS selectors nor javascript require that each and every element
 in the DOM have an id attached to it in order to apply styles or
 manipulate the elements with javascript. (And I rather suspect the
 suggested change creates invalid HTML by duplicating the same id values on
 multiple elements, though I have not confirmed that.)

 Please do not respond here with more specifics of what it is you'd like an
 example of. Trac is not the place for user support, which is what this is
 veering towards. There are many more productive places to ask for help
 with how to do things in Django. I'm very sure whatever it is you are
 trying to do is possible without adding ids to all the HTML elements
 generated by forms when output as tables.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18763: Shortcut to get users by permission

[Django]

#18763: Shortcut to get users by permission
--+--
 Reporter:  shelldweller  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by shelldweller):

 * cc: shelldweller (added)
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #18763: Shortcut to get users by permission

[Django]

#18763: Shortcut to get users by permission
--+
 Reporter:  shelldweller  |  Owner:  nobody
 Type:  New feature   | Status:  new
Component:  contrib.auth  |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 In my apps I often need to get the list of users who have a specific
 permission. But it seems there is no shortcut to do this in Django itself
 (unless I'm missing something obvious). And getting users by permission is
 slightly more complicated than may appear at first sight because user
 permission can be set at user level or at group level, and also we need to
 pay special attention to superusers.

 So I usually end up doing something like this:

 {{{
 from django.contrib.auth.models import User
 from django.db.models import Q

 def get_users_by_permission_q(permission_name, include_superusers=True):
 """ Returns the Q object suitable for querying users by permission. If
 include_superusers
 is true (default) all superusers will be also included. Otherwise
 only users with explicitely set permissions will be included. """
 (appname, codename) = permission_name.split(".")

 query = \
 Q(user_permissions__codename=codename,
 user_permissions__content_type__app_label=appname) | \
 Q(groups__permissions__codename=codename,
 groups__permissions__content_type__app_label=appname)

 if include_superusers:
 query |= Q(is_superuser=True)

 # The above query may return multiple instances of User objects if
 user
 # has overlapping permissions. Hence we are using a nested query by
 unique
 # user ids.
 return {'pk__in': User.objects.filter(query).distinct().values('pk')}

 def get_users_by_permission(permission_name, include_superusers=True):
 """ Returns the queryset of User objects with the given permission.
 Permission name
 is in the form appname.permission similar to the format
 required by django.contrib.auth.decorators.permission_required
 """
 return User.objects.filter( get_users_by_permission_q(permission_name,
 include_superusers) )
 }}}

 And them in my models.py:

 {{{
 class MyModel:
 my_fk_field = models.ForeignKey(User,
 limit_choices_to=dict(is_active=True, \
 *get_users_by_permission_q("myapp.change_my_model", False)))
 }}}

 Or in my views:
 {{{
 users = get_users_by_permission("myapp.change_my_model")
 }}}

 It would be nice to have something like this in
 django/contrib/auth/utils.py

 If this proposal gets accepted I can contribute a patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] a025b7: [py3] Fixed iterlists usage in QueryDict

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: a025b75f6c3021ab400224250defa2db37b8122c
  
https://github.com/django/django/commit/a025b75f6c3021ab400224250defa2db37b8122c
  Author: Claude Paroz 
  Date:   2012-08-13 (Mon, 13 Aug 2012)

  Changed paths:
M django/http/__init__.py

  Log Message:
  ---
  [py3] Fixed iterlists usage in QueryDict


  Commit: 363dbd920e9b77da83895598f0fc9f7f835df65d
  
https://github.com/django/django/commit/363dbd920e9b77da83895598f0fc9f7f835df65d
  Author: Claude Paroz 
  Date:   2012-08-13 (Mon, 13 Aug 2012)

  Changed paths:
M django/contrib/formtools/tests/__init__.py
M django/contrib/formtools/wizard/storage/base.py
M django/http/__init__.py

  Log Message:
  ---
  [py3] Fixed contrib.formtools tests


Compare: https://github.com/django/django/compare/b109ff8062f4...363dbd920e9b

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18340: formtools.utils.form_hmac is not consistent with unicode input

[Django]

#18340: formtools.utils.form_hmac is not consistent with unicode input
---+
 Reporter:  claudep|Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  contrib.formtools  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Claude Paroz ):

 In [b109ff8062f4bb225181ec462d69c9dd79339567]:
 {{{
 #!CommitTicketReference repository=""
 revision="b109ff8062f4bb225181ec462d69c9dd79339567"
 Replaced pickle by json in form_hmac calculation

 Refs #18340
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] b109ff: Replaced pickle by json in form_hmac calculation

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: b109ff8062f4bb225181ec462d69c9dd79339567
  
https://github.com/django/django/commit/b109ff8062f4bb225181ec462d69c9dd79339567
  Author: Claude Paroz 
  Date:   2012-08-13 (Mon, 13 Aug 2012)

  Changed paths:
M django/contrib/formtools/tests/__init__.py
M django/contrib/formtools/utils.py

  Log Message:
  ---
  Replaced pickle by json in form_hmac calculation

Refs #18340



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18762: Problem with url in templates

[Django]

#18762: Problem with url in templates
---+--
 Reporter:  jendxb@…   |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Documentation  |  Version:  1.4
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by anonymous):

 * type:  Bug => Uncategorized


Comment:

 Thanks for clarifying!

 I had started with the Tutorial from the Django homepage and later googled
 to look up the Tutorial page I had been on last and ended up on the "dev"
 version of the documenation and as both look absolutely similar i didn't
 recognize that there are two versions of the tutorial ...I am sure I'll
 not be the only one falling for this, as the only difference is the
 additional "/dev" in the page URL.

 Kudos btw to the person who wrote the Tutorial! One of the best I've ever
 seen.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18733: Form ids on as_table

[Django]

#18733: Form ids on as_table
-+--
 Reporter:  tturner  |Owner:  nobody
 Type:  New feature  |   Status:  reopened
Component:  Forms|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by tturner):

 * status:  closed => reopened
 * resolution:  wontfix =>


Comment:

 How messy django is here to help you develop and speed you up!!!

 It not just JavaScript that you need access.
 I have needed to change the CSS for some of the labels. For example I
 needed to change the font size.


 I am sure that I not the only one asking

 If you think you can do this without ids please show me an example.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18762: Problem with url in templates

[Django]

#18762: Problem with url in templates
---+--
 Reporter:  jendxb@…   |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  1.4
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by charettes):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 The 1.4.X release branch still rely on the old behaviour by default.

 I guess your report is against
 [https://docs.djangoproject.com/en/dev/intro/tutorial03/#removing-
 hardcoded-urls-in-templates this part] of the **development** version
 documentation. If you want this to work in 1.4.1 you must add a `{% load
 url from future %}` at the top of your template.

 Again, I advise you to read
 [https://docs.djangoproject.com/en/dev/releases/1.3/#changes-to-url-and-
 ssi the django 1.3 release note explaining this] to understand why you
 encounter this error.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #373: Add support for multiple-column primary keys

[Django]

#373: Add support for multiple-column primary keys
-+-
 Reporter:  jacob|Owner:  konk
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  database |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by cuboci):

 * cc: cuboci (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18762: Problem with url in templates

[Django]

#18762: Problem with url in templates
---+--
 Reporter:  jendxb@…   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by anonymous):

 * type:  Cleanup/optimization => Bug


Comment:

 This tells me:
 python -c "import django; print(django.get_version())"
 ...that I am running "1.4.1"

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18762: Problem with url in templates

[Django]

#18762: Problem with url in templates
-+-
 Reporter:  jendxb@… |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.4
Component:  Documentation|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by charettes):

 * needs_better_patch:   => 0
 * type:  Uncategorized => Cleanup/optimization
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Hi jendxb!

 You are likely reading development version documentation while using a
 version of django <=  1.4.

 The old behaviour of the `url` template tag will be officially deprecated
 in django 1.5 following the deprecation process described
 [https://docs.djangoproject.com/en/dev/releases/1.3/#changes-to-url-and-
 ssi in the django 1.3 release note].

 You should really convert your templates to use the new behaviour by
 adding the `{% load url from future %}` statement at the top of then.

 Thanks for reporting anyway.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 0dac73: Removed binary flag to open files for writing text...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 0dac73ebd733d9140476b66b81afa56c5b0f65b2
  
https://github.com/django/django/commit/0dac73ebd733d9140476b66b81afa56c5b0f65b2
  Author: Claude Paroz 
  Date:   2012-08-13 (Mon, 13 Aug 2012)

  Changed paths:
M django/core/management/commands/makemessages.py

  Log Message:
  ---
  Removed binary flag to open files for writing text content



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #18762: Problem with url in templates

[Django]

#18762: Problem with url in templates
---+
 Reporter:  jendxb@…   |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Documentation  |Version:  1.4
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 This:
 {{ poll.question
 }}
 ...does not work.

 But this:
 {{ poll.question
 }}
 does.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #18761: Strip fields' values consistently

[Django]

#18761: Strip fields' values consistently
--+
 Reporter:  vzima |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Forms |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 Currently, some fields strips values during validation and some do not.
 The state does not even clearly represents whether whitespace is valid
 part of field's value.

 || Field || Strips || Should strip ||
 || !CharField || no || no ||
 || !IntegerField || yes || yes ||
 || !FloatField || yes || yes ||
 || !DecimalField || yes || yes ||
 || !BaseTemporalField || yes || yes ||
 || !RegexField || no || no ||
 || !EmailField || yes || yes ||
 || URLField || no || '''yes''' ||
 || !BooleanField || no || ? ||
 || !NullBooleanField || no || ? ||
 || IPAddressField || no || '''yes''' ||
 || GenericIPAddressField || no || '''yes''' ||
 || !SlugField || no || '''yes''' ||

 Comments:
  * Spaces are not allowed in URLField, IPAddressField,
 GenericIPAddressField and !SlugField
  * Fairly unclear are boolean fields. IMHO if value to validate is string
 of whitespace characters, it should validate to !None/False as when
 represented by !TextInput user will see empty field.

 I have not check localised form fields but I expect more fields that can
 be safely trimmed.

 Maybe a good long-term solution would be list of filters (like validators)
 which would perform transformation to python object.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #10790: Too many joins in a comparison for NULL.

[Django]

#10790: Too many joins in a comparison for NULL.
-+-
 Reporter:  mtredinnick  |Owner:
 Type:  Bug  |  mtredinnick
Component:  Database layer   |   Status:  new
  (models, ORM)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by akaariai):

 milosu: I added comment to #17886, I think you are on right track but the
 patch needs some polish.

 For the idea of trimming joins before even adding them: it doesn't work.
 The reason is a query like this:
 {{{
 qs.filter(relatedf__isnull=True)
 }}}
 This will first create a LOUTER join to the relatedf. Then trim it away
 (that is, make its refcount 0). Now, later on if we need another join to
 relatedf we know to make it LOUTER, this could happen in queryset
 combining `(qs|qs.filter(relatedf__somecol=someval))` for example.

 So, we need to have the LOUTER trimmed join information available
 somewhere. Using my patch from above we could just move the join trimming
 to just after creating the joins, and pass the information about the need
 of LOUTER join to setup_joins. Now, we can immediately trim the non-needed
 joins, and in addition we have the information about LOUTER available. I
 tested this quickly and it works.

 The question now is if we need trim_joins() at all. If we do, then it
 might be better to just pass the information about the direction to
 trim_joins and modify it to do the join trimming properly. If we don't
 need trim_joins anymore, then doing the trimming in setup_joins seems like
 the correct approach.

 In any case the information about the need of having information about
 trimmed joins available needs to be documented in code.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17886: LOUTER join not promoted across filter expression

[Django]

#17886: LOUTER join not promoted across filter expression
-+-
 Reporter:  milosu   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:
  (models, ORM)  |  1.4-beta-1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by akaariai):

 * needs_better_patch:  0 => 1


Comment:

 The idea in the patch seems correct to me. Closely related to #16715 and
 #10790.

 However, the patch isn't to proper level (it is to {{{+++
 ../Django-1.4c1/django/db/models/sql/query.py}}}), and there are stylistic
 errors (tab before space, missing newline between the test method at
 least).

 I hope you can reformat the patch (using git is recommended) and repost it
 or link to github. If not, I think I will do that anyways, as to me it
 seems this patch is needed alongside #16715 for correct join promotions.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] d29757: Consistenly use _ as alias for ugettext_lazy in th...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: d2975718fe0585cad1ed1462cc4d65373a6c7bb0
  
https://github.com/django/django/commit/d2975718fe0585cad1ed1462cc4d65373a6c7bb0
  Author: Florian Apolloner 
  Date:   2012-08-13 (Mon, 13 Aug 2012)

  Changed paths:
M docs/topics/i18n/translation.txt

  Log Message:
  ---
  Consistenly use _ as alias for ugettext_lazy in the i18n docs.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #10790: Too many joins in a comparison for NULL.

[Django]

#10790: Too many joins in a comparison for NULL.
-+-
 Reporter:  mtredinnick  |Owner:
 Type:  Bug  |  mtredinnick
Component:  Database layer   |   Status:  new
  (models, ORM)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by milosu):

 Akaariai, could you please also check patch attached to ticket
 https://code.djangoproject.com/ticket/17886 with your latest patch from
 previous comment?

 I think they are closely related.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17566: RegexURLResolver.__repr__(self) is not unicode safe.

[Django]

#17566: RegexURLResolver.__repr__(self) is not unicode safe.
---+---
 Reporter:  otto   |Owner:  nobody
 Type:  Uncategorized  |   Status:  reopened
Component:  Core (URLs)|  Version:  1.4-alpha-1
 Severity:  Normal |   Resolution:
 Keywords:  unicode| Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---
Changes (by vitalije):

 * status:  closed => reopened
 * keywords:   => unicode
 * resolution:  needsinfo =>


Comment:

 I have noticed the same bug but I believe it is consequence of having
 app_name that has non ascii characters in it. May be that it is not
 supposed to have, but then, I couldn't find other way to display localised
 app_name in django's admin page. It is triggered only when I try to open
 missing link during the generation of technical_404_response. Here is a
 log:

 {{{
 Django version 1.4, using settings 'eprod.settings'
 Development server is running at http://192.168.1.195:8100/
 Quit the server with CONTROL-C.
 Traceback (most recent call last):
   File "/usr/lib/python2.7/wsgiref/handlers.py", line 85, in run
 self.result = application(self.environ, self.start_response)
   File "/usr/local/lib/python2.7/dist-
 packages/django/contrib/staticfiles/handlers.py", line 67, in __call__
 return self.application(environ, start_response)
   File "/usr/local/lib/python2.7/dist-
 packages/django/core/handlers/wsgi.py", line 241, in __call__
 response = self.get_response(request)
   File "/usr/local/lib/python2.7/dist-
 packages/django/core/handlers/base.py", line 146, in get_response
 response = debug.technical_404_response(request, e)
   File "/usr/local/lib/python2.7/dist-packages/django/views/debug.py",
 line 432, in technical_404_response
 'reason': smart_str(exception, errors='replace'),
   File "/usr/local/lib/python2.7/dist-packages/django/utils/encoding.py",
 line 116, in smart_str
 return str(s)
   File "/usr/local/lib/python2.7/dist-
 packages/django/core/urlresolvers.py", line 235, in __repr__
 return smart_str(u'<%s %s (%s:%s) %s>' % (self.__class__.__name__,
 self.urlconf_name, self.app_name, self.namespace, self.regex.pattern))
   File "/usr/local/lib/python2.7/dist-
 packages/django/core/urlresolvers.py", line 235, in __repr__
 return smart_str(u'<%s %s (%s:%s) %s>' % (self.__class__.__name__,
 self.urlconf_name, self.app_name, self.namespace, self.regex.pattern))
 UnicodeDecodeError: 'ascii' codec can't decode byte 0xd0 in position 18:
 ordinal not in range(128)
 }}}

 I hope this would help to solve the problem. In case that app_name has to
 be ascii then what is the proper way to force django admin application to
 show non-ascii applications names? In fact I would prefer to have plain
 ascii urls but display name or verbose_name or similar displayed in admin
 pages.
 Vitalije

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18755: admin site overlapping

[Django]

#18755: admin site overlapping
---+--
 Reporter:  senden9|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--

Comment (by senden9):

 Thanks. Was it just my problem or is it a bug?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18760: Make gettext and ugettext aliases

[Django]

#18760: Make gettext and ugettext aliases
-+-
 Reporter:  claudep  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:   |   Resolution:
  Internationalization   | Triage Stage:
 Severity:  Normal   |  Unreviewed
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by claudep):

 * has_patch:  0 => 1


Comment:

 Note that I didn't deprecate the ugettext/ungettext names yet. It might
 not be worth the trouble.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #18760: Make gettext and ugettext aliases

[Django]

#18760: Make gettext and ugettext aliases
+
   Reporter:  claudep   |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Internationalization  |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 In Python 3, there is no more gettext/ugettext, only gettext. Aymeric has
 already aliased ugettext to gettext in recent code when run on Python 3. I
 would suggest to go one step further and alias them even now on Python 2.
 I don't see any value to keep a gettext call that returns utf-8 encoded
 strings.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16715: Wrong JOIN with nested null-able foreign keys

[Django]

#16715: Wrong JOIN with nested null-able foreign keys
-+-
 Reporter:  sebastian|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  join, values,|  checkin
  nested, foreign key, null-able |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by akaariai):

 * stage:  Accepted => Ready for checkin


Comment:

 And the actual RFC mark...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16715: Wrong JOIN with nested null-able foreign keys

[Django]

#16715: Wrong JOIN with nested null-able foreign keys
-+-
 Reporter:  sebastian|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  join, values,|  Needs documentation:  0
  nested, foreign key, null-able |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by akaariai):

 I am marking this RFC (not the "more" version, just the base
 promote_joins() patch in comment:20). I am confident this one will improve
 the queryset generation code. I have been playing around with the patch
 from #10790, and it has become obvious that the current join promotion
 logic in add_filter() is complicated, and doesn't work well. This patch
 should make cleaning up that logic _much_ easier.

 If you have doubts about this patch and do not have time to review this
 patch just now, please make a note here. I aim to commit this one during
 next weekend.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17800: Empty settings.SECRET_KEY should raise an error

[Django]

#17800: Empty settings.SECRET_KEY should raise an error
-+---
 Reporter:  PaulM|Owner:  nobody
 Type:  Uncategorized|   Status:  closed
Component:  Core (Other) |  Version:  1.4-alpha-1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+---

Comment (by pjdelport):

 Reference documentation update for this change: #18759

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18759: Update SECRET_KEY setting's reference documentation

[Django]

#18759: Update SECRET_KEY setting's reference documentation
-+-
 Reporter:  pjdelport|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.4
Component:  Documentation|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by pjdelport):

 * needs_docs:   => 0
 * has_patch:  0 => 1
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 !GitHub pull request: [https://github.com/django/django/pull/265 265]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #18759: Update SECRET_KEY setting's reference documentation

[Django]

#18759: Update SECRET_KEY setting's reference documentation
--+
 Reporter:  pjdelport |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Documentation |Version:  1.4
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  1 |  UI/UX:  0
--+
 Context: #17800 made the {{{SECRET_KEY}}} setting required.

 The Django 1.4 release notes
 [https://docs.djangoproject.com/en/1.4/releases/1.4/#secret-key-setting-
 is-required detail this change], but the reference documentation doesn't
 mention it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 45baaa: [py3] Fixed encoding issues in cache key generatio...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 45baaabafb6cf911afad9ec63c86753b284f7269
  
https://github.com/django/django/commit/45baaabafb6cf911afad9ec63c86753b284f7269
  Author: Claude Paroz 
  Date:   2012-08-13 (Mon, 13 Aug 2012)

  Changed paths:
M django/core/cache/backends/base.py
M django/utils/cache.py
M tests/regressiontests/cache/tests.py

  Log Message:
  ---
  [py3] Fixed encoding issues in cache key generation



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #18758: non-DRY e-mail regex

[Django]

#18758: non-DRY e-mail regex
--+
 Reporter:  yedpodtrzitko |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Uncategorized |Version:  1.4
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  1 |  UI/UX:  0
--+
 There are two similar regexes having the same purpose (email validation).
 Keep only one of them.

 Occurences:

 django/core/validators.py, line 159:

 {{{
 email_re = re.compile(
 r"(^[-!#$%&'*+/=?^_`{}|~0-9A-Z]+(\.[-!#$%&'*+/=?^_`{}|~0-9A-Z]+)*"  #
 dot-atom
 # quoted-string, see also
 http://tools.ietf.org/html/rfc2822#section-3.2.5
 
r'|^"([\001-\010\013\014\016-\037!#-\[\]-\177]|\\[\001-\011\013\014\016-\177])*"'
 r')@((?:[A-Z0-9](?:[A-Z0-9-]{0,61}[A-Z0-9])?\.)+[A-Z]{2,6}\.?$)'  #
 domain
 r'|\[(25[0-5]|2[0-4]\d|[0-1]?\d?\d)(\.(25[0-5]|2[0-4]\d|[0-1]?\d?\d)){3}\]$',
 re.IGNORECASE)  # literal form, ipv4 address (SMTP 4.1.3)
 }}}

 django/contrib/auth/management/commands/createsuperuser.py, line 19:

 {{{
 EMAIL_RE = re.compile(
 r"(^[-!#$%&'*+/=?^_`{}|~0-9A-Z]+(\.[-!#$%&'*+/=?^_`{}|~0-9A-Z]+)*"  #
 dot-atom
 
r'|^"([\001-\010\013\014\016-\037!#-\[\]-\177]|\\[\001-\011\013\014\016-\177])*"'
 # quoted-string
 r')@(?:[A-Z0-9-]+\.)+[A-Z]{2,6}$', re.IGNORECASE)  # domain
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 5e958b: [py3] Avoided comparison with None value in formse...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 5e958b958b4b27082a393decf64ec573fa7454b2
  
https://github.com/django/django/commit/5e958b958b4b27082a393decf64ec573fa7454b2
  Author: Claude Paroz 
  Date:   2012-08-13 (Mon, 13 Aug 2012)

  Changed paths:
M django/forms/formsets.py

  Log Message:
  ---
  [py3] Avoided comparison with None value in formsets


  Commit: d774ad752d9844cb7a28fe338d4d711c8576ee6f
  
https://github.com/django/django/commit/d774ad752d9844cb7a28fe338d4d711c8576ee6f
  Author: Claude Paroz 
  Date:   2012-08-13 (Mon, 13 Aug 2012)

  Changed paths:
M django/core/context_processors.py
M django/middleware/csrf.py
M tests/regressiontests/csrf_tests/tests.py

  Log Message:
  ---
  [py3] Made csrf context processor return Unicode


Compare: https://github.com/django/django/compare/73f0f18c8fc0...d774ad752d98

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 73f0f1: [py3] Fixed admin_scripts tests

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 73f0f18c8fc04a03bbfb20794aabb95944c90f63
  
https://github.com/django/django/commit/73f0f18c8fc04a03bbfb20794aabb95944c90f63
  Author: Claude Paroz 
  Date:   2012-08-13 (Mon, 13 Aug 2012)

  Changed paths:
M tests/regressiontests/admin_scripts/tests.py

  Log Message:
  ---
  [py3] Fixed admin_scripts tests



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 6d6802: [py3] Removed filename encoding in file_uploads te...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 6d68022a274df2e19205d7313034cf6eb619f346
  
https://github.com/django/django/commit/6d68022a274df2e19205d7313034cf6eb619f346
  Author: Claude Paroz 
  Date:   2012-08-13 (Mon, 13 Aug 2012)

  Changed paths:
M tests/regressiontests/file_uploads/tests.py

  Log Message:
  ---
  [py3] Removed filename encoding in file_uploads test


  Commit: a06503d09b73fa2842ec79170b84453034fca904
  
https://github.com/django/django/commit/a06503d09b73fa2842ec79170b84453034fca904
  Author: Claude Paroz 
  Date:   2012-08-13 (Mon, 13 Aug 2012)

  Changed paths:
M AUTHORS
M django/test/client.py

  Log Message:
  ---
  [py3] Fixed content encoding in test client

Thanks Andrews Medina for the initial patch.


Compare: https://github.com/django/django/compare/1930b899bd69...a06503d09b73

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.