[Django] #21259: Wizard sets queryset instead of instance on InlineFormset

2013-10-11 Thread Django 
#21259: Wizard sets queryset instead of instance on InlineFormset
---+---
 Reporter:  banderkat@…|  Owner:  nobody
 Type:  Bug| Status:  new
Component:  contrib.formtools  |Version:  master
 Severity:  Normal |   Keywords:  wizard, InlineFormSet
 Triage Stage:  Unreviewed |  Has patch:  1
Easy pickings:  0  |  UI/UX:  0
---+---
 Because {{{InlineFormSet}}} subclasses {{{BaseModelFormSet}}}, the wizard
 thinks it's like any {{{BaseModelFormSet}}} and incorrectly initializes
 the form by setting the form's {{{queryset}}} instead of the form's
 {{{instance}}}.  An {{{InlineFormSet}}} needs to have its instance set to
 the parent model object instead.

 Currently, attempting to set {{{self.instance}}} for the
 {{{InlineFormSet}}} in the wizard's {{{get_form_instance}}} results in an
 {{{AttributeError}}} saying "object has no attribute 'none'" as the wizard
 attempts to set the form's queryset (instead of instance) with it's
 {{{self.instance}}}.

 I have a fix to propose here:
 
[https://github.com/flibbertigibbet/django/commit/885798aa250544bd5c6d3a7325dc5c20c0795f2c]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.ebde8dc15528f4b3ac6fd59f1fc09eb2%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 8f5d3d: [1.6.x] Fixed #15582 -- Documented how Transaction...

2013-10-11 Thread GitHub 
  Branch: refs/heads/stable/1.6.x
  Home:   https://github.com/django/django
  Commit: 8f5d3d16cb331915e397821efd6faf2700b2bc50
  
https://github.com/django/django/commit/8f5d3d16cb331915e397821efd6faf2700b2bc50
  Author: Tim Graham 
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
M docs/topics/testing/overview.txt

  Log Message:
  ---
  [1.6.x] Fixed #15582 -- Documented how TransactionTestCase.multi_db affects 
fixtures.

Thanks slinkp for the suggestion.

Backport of dd839a2dfd from master



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/5258940b6034d_7d84c0fd50104673%40hookshot-fe1-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15582: Docs don't mention that TestCase.multi_db affects test fixtures

2013-10-11 Thread Django 
#15582: Docs don't mention that TestCase.multi_db affects test fixtures
---+
 Reporter:  slinkp |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  1.2
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Tim Graham ):

 In [changeset:"8f5d3d16cb331915e397821efd6faf2700b2bc50"]:
 {{{
 #!CommitTicketReference repository=""
 revision="8f5d3d16cb331915e397821efd6faf2700b2bc50"
 [1.6.x] Fixed #15582 -- Documented how TransactionTestCase.multi_db
 affects fixtures.

 Thanks slinkp for the suggestion.

 Backport of dd839a2dfd from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.cf13aba3c3a7b9c94f1578ceda1fb810%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 2b8519: [1.5.x] Fixed #15582 -- Documented how Transaction...

2013-10-11 Thread GitHub 
  Branch: refs/heads/stable/1.5.x
  Home:   https://github.com/django/django
  Commit: 2b8519760e04ca0ef3c9989c36588dde93a8152a
  
https://github.com/django/django/commit/2b8519760e04ca0ef3c9989c36588dde93a8152a
  Author: Tim Graham 
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
M docs/topics/testing/overview.txt

  Log Message:
  ---
  [1.5.x] Fixed #15582 -- Documented how TransactionTestCase.multi_db affects 
fixtures.

Thanks slinkp for the suggestion.

Backport of dd839a2dfd from master



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/5258940e35191_6f17cabd541985f%40hookshot-fe2-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] dd839a: Fixed #15582 -- Documented how TransactionTestCase...

2013-10-11 Thread GitHub 
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: dd839a2dfd6a30474a2b367a4b3ce70b26c3f318
  
https://github.com/django/django/commit/dd839a2dfd6a30474a2b367a4b3ce70b26c3f318
  Author: Tim Graham 
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
M docs/topics/testing/overview.txt

  Log Message:
  ---
  Fixed #15582 -- Documented how TransactionTestCase.multi_db affects fixtures.

Thanks slinkp for the suggestion.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/525893fa6aef9_71588afd5421736c%40hookshot-fe2-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15582: Docs don't mention that TestCase.multi_db affects test fixtures

2013-10-11 Thread Django 
#15582: Docs don't mention that TestCase.multi_db affects test fixtures
---+
 Reporter:  slinkp |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  1.2
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"dd839a2dfd6a30474a2b367a4b3ce70b26c3f318"]:
 {{{
 #!CommitTicketReference repository=""
 revision="dd839a2dfd6a30474a2b367a4b3ce70b26c3f318"
 Fixed #15582 -- Documented how TransactionTestCase.multi_db affects
 fixtures.

 Thanks slinkp for the suggestion.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.f251f7d975de07acccd196a5d3f53657%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21200: Inconsistent handling of "PickleError" between cache backends

2013-10-11 Thread Django 
#21200: Inconsistent handling of "PickleError" between cache backends
-+
 Reporter:  t.chaumeny@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timo):

 * needs_docs:  0 => 1
 * needs_tests:  0 => 1


Comment:

 Could you add a regression test that demonstrates `PickleError` is raised
 when using `LocMemCache`. It probably also warrants a mention in the
 release notes as a backwards incompatible change.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.1a5e2ffdd9a9c3ed62378638e0993603%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] ad17d6: Fixed errors in 848101bf1736d1c01eb86968e85a14c746...

2013-10-11 Thread GitHub 
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: ad17d6a85fb75845b8a075e2617829834a9d1ffa
  
https://github.com/django/django/commit/ad17d6a85fb75845b8a075e2617829834a9d1ffa
  Author: Tim Graham 
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
M tests/validators/tests.py

  Log Message:
  ---
  Fixed errors in 848101bf1736d1c01eb86968e85a14c7466bb376



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/5258747d6b63e_2bcc797d54782bf%40hookshot-fe3-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21258: Spanish locale should accept %Y-%m-%d format for dates

2013-10-11 Thread Django 
#21258: Spanish locale should accept %Y-%m-%d format for dates
---+--
 Reporter:  pegler |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Uncategorized  |  Version:  master
 Severity:  Normal |   Resolution:  needsinfo
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by claudep):

 * status:  new => closed
 * resolution:   => needsinfo


Comment:

 `get_format` in `django.utils.formats.py` should automatically add ISO
 formats (hence %Y-%m-%d) in all localized formats. So if you think this
 doesn't work, could you please add some test or code snippet demonstrating
 the issue?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.04db7ad4e5af97f2a13c9ee57bf47a24%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 766fbd: [1.5.x] Minor edits to docs/topics/db/queries.txt.

2013-10-11 Thread GitHub 
  Branch: refs/heads/stable/1.5.x
  Home:   https://github.com/django/django
  Commit: 766fbd53cb6ae6b31c6b88848d3abb64d2881e72
  
https://github.com/django/django/commit/766fbd53cb6ae6b31c6b88848d3abb64d2881e72
  Author: Cody Scott 
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
M docs/topics/db/queries.txt

  Log Message:
  ---
  [1.5.x] Minor edits to docs/topics/db/queries.txt.

Backport of 8bfc7cc64c from master



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52585321863f9_27cb7add48957bf%40hookshot-fe4-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] f78786: [1.6.x] Minor edits to docs/topics/db/queries.txt.

2013-10-11 Thread GitHub 
  Branch: refs/heads/stable/1.6.x
  Home:   https://github.com/django/django
  Commit: f787869d8cac48a7cf1336c78ce5ec3b06729ab6
  
https://github.com/django/django/commit/f787869d8cac48a7cf1336c78ce5ec3b06729ab6
  Author: Cody Scott 
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
M docs/topics/db/queries.txt

  Log Message:
  ---
  [1.6.x] Minor edits to docs/topics/db/queries.txt.

Backport of 8bfc7cc64c from master



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/525853204cee9_2ae6b23d4c597cf%40hookshot-fe3-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 8bfc7c: Minor edits to docs/topics/db/queries.txt.

2013-10-11 Thread GitHub 
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 8bfc7cc64c4b45ccf9ad69564a5abd6b8105e28f
  
https://github.com/django/django/commit/8bfc7cc64c4b45ccf9ad69564a5abd6b8105e28f
  Author: Cody Scott 
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
M docs/topics/db/queries.txt

  Log Message:
  ---
  Minor edits to docs/topics/db/queries.txt.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/525852cdaeeaa_2b61799d48135667%40hookshot-fe3-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21188: Use DeprecationWarning subclasses for deprecated features

2013-10-11 Thread Django 
#21188: Use DeprecationWarning subclasses for deprecated features
--+
 Reporter:  akaariai  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by ajs):

 how about `DeprecationInDjango18Warning`. That keeps the same context that
 is used now and just adds a time when it will happen.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4691c708220708613b6bcaedef3bd327%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #7603: Add HttpRequest.get_scheme() (was: The Request object should have a "scheme" attribute)

2013-10-11 Thread Django 
#7603: Add HttpRequest.get_scheme()
---+
 Reporter:  nslater|Owner:  nslater
 Type:  New feature|   Status:  assigned
Component:  HTTP handling  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timo):

 * needs_better_patch:  0 => 1


Comment:

 Comments for improvement on the branch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.0fb1b0d20f0a21491a3ea0fd1383cf66%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21080: collectstatic post-processing fails for references inside comments

2013-10-11 Thread Django 
#21080: collectstatic post-processing fails for references inside comments
-+
 Reporter:  shreyas@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.staticfiles  |  Version:  1.5
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by glarrain):

 This bit me today. "Dumb" workaround: replace that `url` in your comments
 with `u r l`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.1ab230a078493135fba6b3c7a6760bc9%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #8918: FileField upload_to should not be required for custom backends

2013-10-11 Thread Django 
#8918: FileField upload_to should not be required for custom backends
-+-
 Reporter:  leahculver   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  File |  Version:  master
  uploads/storage|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  FileField, files,|  Needs documentation:  0
  upload, S3, upload_to  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by anonymous):

 Amazing. Thanks everyone!!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.3efb9741dd6da82095548557d6f0d691%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20244: PermissionsMixin should define related name of groups and user_permissions related name

2013-10-11 Thread Django 
#20244: PermissionsMixin should define related name of groups and 
user_permissions
related name
-+
 Reporter:  bdauvergne   |Owner:  andrewgodwin
 Type:  Bug  |   Status:  closed
Component:  contrib.auth |  Version:  1.5
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by mjtamlyn):

 During that migration point, it should be straightforwards enough to copy
 the two fields form PermissionsMixin into your custom model, add a
 `related_name`, and then remove them and re-add PermissionsMixin again
 afterwards. Its worth noting that the same problem you're experiencing
 would occur with any custom User model named User, irrespective of these
 changes. What the change guarantees is that when your transitional period
 is complete, django and other third party applications have a defined api
 to use if they require Group or Permission.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.1a054dee6c4307995dc45525a3bea4ac%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 848101: Added tests for URLValidator schemes.

2013-10-11 Thread GitHub 
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 848101bf1736d1c01eb86968e85a14c7466bb376
  
https://github.com/django/django/commit/848101bf1736d1c01eb86968e85a14c7466bb376
  Author: Sascha Peilicke 
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
M tests/validators/tests.py

  Log Message:
  ---
  Added tests for URLValidator schemes.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52583886cb6a8_71588afd54163298%40hookshot-fe2-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21241: Optimize the query generated for admin changelist filters

2013-10-11 Thread Django 
#21241: Optimize the query generated for admin changelist filters
-+-
 Reporter:  acdha|Owner:  charettes
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  contrib.admin|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timo):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.a0a89f46c54cd766e05b30d43a4d5d21%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #13252: Use the natural key instead of the primary key when serializing

2013-10-11 Thread Django 
#13252: Use the natural key instead of the primary key when serializing
-+-
 Reporter:  SmileyChris  |Owner:
 Type:  New feature  |  mtredinnick
Component:  Core |   Status:  closed
  (Serialization)|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e527c0b6d808cb8e4bedf79ded3dc4ad1a7e17a8"]:
 {{{
 #!CommitTicketReference repository=""
 revision="e527c0b6d808cb8e4bedf79ded3dc4ad1a7e17a8"
 Fixed #13252 -- Added ability to serialize with natural primary keys.

 Added ``--natural-foreign`` and ``--natural-primary`` options and
 deprecated the ``--natural`` option to the ``dumpdata`` management
 command.

 Added ``use_natural_foreign_keys`` and ``use_natural_primary_keys``
 arguments and deprecated the ``use_natural_keys`` argument to
 ``django.core.serializers.Serializer.serialize()``.

 Thanks SmileyChris for the suggestion.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.561082ae0b8831edb7cd8ca932183ad7%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] e527c0: Fixed #13252 -- Added ability to serialize with na...

2013-10-11 Thread GitHub 
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: e527c0b6d808cb8e4bedf79ded3dc4ad1a7e17a8
  
https://github.com/django/django/commit/e527c0b6d808cb8e4bedf79ded3dc4ad1a7e17a8
  Author: Tai Lee 
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
M django/core/management/commands/dumpdata.py
M django/core/serializers/base.py
M django/core/serializers/python.py
M django/core/serializers/xml_serializer.py
M docs/internals/deprecation.txt
M docs/ref/django-admin.txt
M docs/releases/1.7.txt
M docs/topics/serialization.txt
M tests/fixtures/tests.py
M tests/fixtures_regress/tests.py
M tests/serializers_regress/models.py
M tests/serializers_regress/tests.py

  Log Message:
  ---
  Fixed #13252 -- Added ability to serialize with natural primary keys.

Added ``--natural-foreign`` and ``--natural-primary`` options and
deprecated the ``--natural`` option to the ``dumpdata`` management
command.

Added ``use_natural_foreign_keys`` and ``use_natural_primary_keys``
arguments and deprecated the ``use_natural_keys`` argument to
``django.core.serializers.Serializer.serialize()``.

Thanks SmileyChris for the suggestion.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52582d779f240_6ee7ad9d5094189%40hookshot-fe2-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #12581: connection.queries should use a ring buffer to avoid large memory consumption under runserver

2013-10-11 Thread Django 
#12581: connection.queries should use a ring buffer to avoid large memory
consumption under runserver
-+-
 Reporter:  robhudson|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-
Changes (by pztrick):

 * cc: pztrick44@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.721fe6b2c5dbfd77a8f6876d7de7baf7%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20917: Change the password hashers when testing

2013-10-11 Thread Django 
#20917: Change the password hashers when testing
-+-
 Reporter:  mjtamlyn |Owner:
 Type:  New feature  |  ashchristopher
Component:  Testing framework|   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:   |   Resolution:
Has patch:  0| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by benoitbryon):

 I just released https://pypi.python.org/pypi/django-plainpasswordhasher,
 which is a no-op password hasher. Yes, very dangerous in production, but
 pretty quick for tests.

 I have no benchmark actually, but I guess "no encoding" is the fastest
 encoding implementation, isn't it?

 What about using it as default or recommended password hasher when running
 tests?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4c1b469ab0a9e6eb43e8d875d38f7d31%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21258: Spanish locale should accept %Y-%m-%d format for dates

2013-10-11 Thread Django 
#21258: Spanish locale should accept %Y-%m-%d format for dates
---+--
 Reporter:  pegler |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Uncategorized  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by pegler):

 * needs_better_patch:   => 0
 * version:  1.5 => master
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d233fac70fdfb523bccb335b6e020078%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21258: Spanish locale should accept %Y-%m-%d format for dates

2013-10-11 Thread Django 
#21258: Spanish locale should accept %Y-%m-%d format for dates
---+
 Reporter:  pegler |  Owner:  nobody
 Type:  Bug| Status:  new
Component:  Uncategorized  |Version:  1.5
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  1  |  UI/UX:  0
---+
 The Spanish formats file does not accept the -MM-DD format for dates.
 All the other language formats seem to accept this, as it is the ISO date
 format.  Is there a reason for this, or simply overlooked?

 
https://github.com/django/django/blob/1dae4ac1778f04805c0ed62c8debb13b281ba02b/django/conf/locale/es/formats.py#L19

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.6b3924d126480be07493ffc196525ed7%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21200: Inconsistent handling of "PickleError" between cache backends

2013-10-11 Thread Django 
#21200: Inconsistent handling of "PickleError" between cache backends
-+
 Reporter:  t.chaumeny@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by tchaumeny):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.368bbe9c6a163e9527301fd1c334c34d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21200: Inconsistent handling of "PickleError" between cache backends

2013-10-11 Thread Django 
#21200: Inconsistent handling of "PickleError" between cache backends
-+
 Reporter:  t.chaumeny@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by tchaumeny):

 The patch above makes `LocMemCache` stop failing silently in case of
 pickling error, which is consistent with other backends.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.f01e423a61fa80a10500135dff9a2188%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21253: PBKDF2 with cached HMAC key

2013-10-11 Thread Django 
#21253: PBKDF2 with cached HMAC key
-+-
 Reporter:  timo |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  contrib.auth |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timo):

 * stage:  Accepted => Ready for checkin


Comment:

 [https://github.com/django/django/pull/1724 Updated PR] that applies
 cleanly. Presumably RFC, but waiting for a review from Donald and/or Paul.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.42a22e82e0f22598a36ef15b42b65b8e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #6681: `admindocs` breaks compatibility with `docutils` when rendering reStructuredText

2013-10-11 Thread Django 
#6681: `admindocs` breaks compatibility with `docutils` when rendering
reStructuredText
-+-
 Reporter:  mtredinnick  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admindocs|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  restructuredtext | Triage Stage:  Accepted
  docutils   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by timo):

 Yes, it seems it would fix the issue although not yield the same result as
 before the first patch was committed. Originally the `` would appear
 in a `` since it's indented. That's not necessary or really
 desired in this case - I'm not sure if there's a use case that would
 benefit from preserving indentation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.a166d62c3bb03a04fd031012a32d0f5d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21257: ForeignKey on_delete functionality should traverse (cascade, ha ha) to the DB backend

2013-10-11 Thread Django 
#21257: ForeignKey on_delete functionality should traverse (cascade, ha ha) to 
the
DB backend
---+
 Reporter:  gcbirzan   |  Owner:  nobody
 Type:  New feature| Status:  new
Component:  Uncategorized  |Version:  master
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 By default, django creates FKs without an explicit ON DELETE on the
 backend. This, if nothing else, should be configurable. If for no other
 reason that when using some transaction isolation modes, the error
 returned by the backend will be the wrong one during concurrent
 modifications:

 Table b links to table a. You insert in table b a link to ID 1 in a, at
 the same time as you delete it from a.

 With the default (at least in PostgreSQL), in REPEATABLE READ, the error
 is IntegrityError, which is wrong, since in fact you should just retry the
 transaction. In lower isolation levels, the FK is deleted (as expected),
 though, granted the on delete signals are not called.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.1937a081e50737b921f03b3b7f42d11f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20244: PermissionsMixin should define related name of groups and user_permissions related name

2013-10-11 Thread Django 
#20244: PermissionsMixin should define related name of groups and 
user_permissions
related name
-+
 Reporter:  bdauvergne   |Owner:  andrewgodwin
 Type:  Bug  |   Status:  closed
Component:  contrib.auth |  Version:  1.5
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by antialiasis@…):

 This change makes it incredibly difficult to migrate from the default user
 model to a custom user model with permissions. Which, yes, I realize
 Django recommends against, but given projects and requirements change it
 should definitely be kept in mind that this might need to be possible.

 Various blogs and StackOverflow questions already describe how to migrate
 to a custom user model using South. These methods almost universally call
 for creating your custom user model while AUTH_USER_MODEL is still set to
 'auth.User', then performing a migration to one way or another get the
 users from the auth_user table into a table your new user model can use,
 and then switching AUTH_USER_MODEL over to the new model. However, with
 this change, you can't have two models that inherit from PermissionsMixin
 exist in your project at the same time at any point, because it doesn't
 pass model validation:


 {{{
 CommandError: One or more models did not validate:
 auth.user: Accessor for m2m field 'groups' clashes with related m2m field
 'Group.user_set'. Add a related_name argument
 to the definition for 'groups'.
 auth.user: Accessor for m2m field 'user_permissions' clashes with related
 m2m field 'Permission.user_set'. Add a related
 _name argument to the definition for 'user_permissions'.
 accounts.user: Accessor for m2m field 'groups' clashes with related m2m
 field 'Group.user_set'. Add a related_name
 argument to the definition for 'groups'.
 accounts.user: Accessor for m2m field 'user_permissions' clashes with
 related m2m field 'Permission.user_set'. Add
 a related_name argument to the definition for 'user_permissions'.
 }}}

 And without having both models active at the same time, South can't
 migrate data between them or otherwise do anything useful.

 Migrating to custom user models is already enough of a quagmire. Is there
 no way to avoid this headache without breaking third-party apps that use
 user_set/user in related queries?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.096bf6511bd1e2b0fb79540d96c7d8a7%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 945e03: Fixed #8918 -- Made FileField.upload_to optional.

2013-10-11 Thread GitHub 
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 945e033a6964c8c83c1c5ce5f188baf41a7a7701
  
https://github.com/django/django/commit/945e033a6964c8c83c1c5ce5f188baf41a7a7701
  Author: Tim Graham 
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
M django/core/management/validation.py
M docs/faq/usage.txt
M docs/ref/models/fields.txt
M docs/releases/1.7.txt
M tests/files/models.py
M tests/files/tests.py
M tests/invalid_models/invalid_models/models.py

  Log Message:
  ---
  Fixed #8918 -- Made FileField.upload_to optional.

Thanks leahculver for the suggestion and dc and vajrasky for work
on the patch.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/5257eb0c5bd0a_2b1f7e5d4c947d5%40hookshot-fe3-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #8918: FileField upload_to should not be required for custom backends

2013-10-11 Thread Django 
#8918: FileField upload_to should not be required for custom backends
-+-
 Reporter:  leahculver   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  File |  Version:  master
  uploads/storage|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  FileField, files,|  Needs documentation:  0
  upload, S3, upload_to  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"945e033a6964c8c83c1c5ce5f188baf41a7a7701"]:
 {{{
 #!CommitTicketReference repository=""
 revision="945e033a6964c8c83c1c5ce5f188baf41a7a7701"
 Fixed #8918 -- Made FileField.upload_to optional.

 Thanks leahculver for the suggestion and dc and vajrasky for work
 on the patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.3df3836625d8dca8d73ce3615f80fdf0%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] b67ab7: Fixed assorted flake8 errors.

2013-10-11 Thread GitHub 
  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: b67ab75e82ec59dd4eeca119eeaf570d7c88556c
  
https://github.com/django/django/commit/b67ab75e82ec59dd4eeca119eeaf570d7c88556c
  Author: Tim Graham 
  Date:   2013-10-11 (Fri, 11 Oct 2013)

  Changed paths:
M django/conf/locale/id/formats.py
M django/conf/locale/lv/formats.py
M django/contrib/gis/admin/options.py
M django/contrib/gis/gdal/geometries.py
M django/contrib/gis/gdal/srs.py
M django/contrib/gis/gdal/tests/test_geom.py
M django/contrib/gis/geos/polygon.py
M django/contrib/gis/geos/tests/test_geos_mutation.py
M django/contrib/gis/geos/tests/test_mutable_list.py
M django/contrib/gis/maps/google/gmap.py
M django/contrib/gis/tests/distapp/tests.py
M django/contrib/gis/tests/geoapp/tests.py
M django/contrib/gis/tests/layermap/tests.py
M django/contrib/gis/tests/test_geoforms.py
M django/contrib/gis/utils/wkt.py
M django/core/files/uploadhandler.py
M django/core/signing.py
M django/db/models/base.py
M django/db/models/fields/files.py
M django/dispatch/saferef.py
M django/forms/fields.py
M django/forms/widgets.py
M django/template/context.py
M django/templatetags/cache.py
M django/utils/autoreload.py
M extras/csrf_migration_helper.py
M tests/admin_changelist/tests.py
M tests/admin_inlines/tests.py
M tests/admin_widgets/urls.py
M tests/aggregation_regress/tests.py
M tests/cache/tests.py
M tests/expressions_regress/tests.py
M tests/forms_tests/tests/test_formsets.py
M tests/multiple_database/tests.py
M tests/or_lookups/tests.py
M tests/prefetch_related/tests.py
M tests/queries/tests.py
M tests/swappable_models/models.py

  Log Message:
  ---
  Fixed assorted flake8 errors.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/5257e029e5234_700db17d58529a8%40hookshot-fe2-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21256: Error in django.utils.datetime_safe.datetime.combine method

2013-10-11 Thread Django 
#21256: Error in django.utils.datetime_safe.datetime.combine method
+
 Reporter:  Łukasz  |  Owner:  nobody
 Type:  Bug | Status:  new
Component:  Utilities   |Version:  1.5
 Severity:  Normal  |   Keywords:
 Triage Stage:  Unreviewed  |  Has patch:  0
Easy pickings:  0   |  UI/UX:  0
+
 There seems to be an error in the `combine()` method of the
 `django.utils.datetime_safe.datetime` class. Current definition:

 {{{
 def combine(self, date, time):
 return datetime(date.year, date.month, date.day, time.hour,
 time.minute, time.microsecond, time.tzinfo)
 }}}

 The `time.second` value is not passed to the `datetime` constructor.
 Moreover, this method should be a ''classmethod'', like so:


 {{{
 @classmethod
 def combine(cls, date, time):
 return cls(date.year, date.month, date.day, time.hour,
 time.minute, time.second, time.microsecond, time.tzinfo)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.c6968ef5f83c6ac84de2fa45d9310f37%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.