date:20131207

Re: [Django] #21577: to_python() of django.db.models.fields.init.DateField not detecting datetime.date type

2013-12-07 Thread Django

#21577: to_python() of django.db.models.fields.__init__.DateField not detecting
datetime.date type
-+-
 Reporter:  anonymous|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.6
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  db database model|  Unreviewed
  date datetime dateparse to_python  |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by freshquiz):

 * cc: freshquiz (added)
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0662c187c36adff1595ef2b55f432be6%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21577: to_python() of django.db.models.fields.init.DateField not detecting datetime.date type

2013-12-07 Thread Django

#21577: to_python() of django.db.models.fields.__init__.DateField not detecting
datetime.date type
-+-
 Reporter:  anonymous|  Owner:  nobody
 Type:  Bug  | Status:  new
Component:  Database layer   |Version:  1.6
  (models, ORM)  |   Keywords:  db database model date
 Severity:  Normal   |  datetime dateparse to_python
 Triage Stage:  Unreviewed   |  Has patch:  0
Easy pickings:  0|  UI/UX:  0
-+-
 Stack trace of exception:

 {{{
 Traceback (most recent call last):

   ...db model save() call...

   File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py",
 line 545, in save
 force_update=force_update, update_fields=update_fields)
   File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py",
 line 573, in save_base
 updated = self._save_table(raw, cls, force_insert, force_update,
 using, update_fields)
   File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py",
 line 635, in _save_table
 forced_update)
   File "/usr/local/lib/python2.7/dist-packages/django/db/models/base.py",
 line 679, in _do_update
 return filtered._update(values) > 0
   File "/usr/local/lib/python2.7/dist-packages/django/db/models/query.py",
 line 507, in _update
 return query.get_compiler(self.db).execute_sql(None)
   File "/usr/local/lib/python2.7/dist-
 packages/django/db/models/sql/compiler.py", line 975, in execute_sql
 cursor = super(SQLUpdateCompiler, self).execute_sql(result_type)
   File "/usr/local/lib/python2.7/dist-
 packages/django/db/models/sql/compiler.py", line 771, in execute_sql
 sql, params = self.as_sql()
   File "/usr/local/lib/python2.7/dist-
 packages/django/db/models/sql/compiler.py", line 940, in as_sql
 val = field.get_db_prep_save(val, connection=self.connection)
   File "/usr/local/lib/python2.7/dist-
 packages/django/db/models/fields/__init__.py", line 350, in
 get_db_prep_save
 prepared=False)
   File "/usr/local/lib/python2.7/dist-
 packages/django/db/models/fields/__init__.py", line 803, in
 get_db_prep_value
 value = self.get_prep_value(value)
   File "/usr/local/lib/python2.7/dist-
 packages/django/db/models/fields/__init__.py", line 798, in get_prep_value
 return self.to_python(value)
   File "/usr/local/lib/python2.7/dist-
 packages/django/db/models/fields/__init__.py", line 756, in to_python
 parsed = parse_date(value)
   File "/usr/local/lib/python2.7/dist-packages/django/utils/dateparse.py",
 line 36, in parse_date
 match = date_re.match(value)
 TypeError: expected string or buffer
 }}}

 Database backend: PostgreSQL 9.1.1
 OS: Ubuntu 13.10 x86_64
 Python version: 2.7.5+

 I titled this ticket saying the problem is in the to_python() method of
 django.db.models.fields.`__`init`__`.DateField, because I did some
 investigation myself and analysed the type of the variable named "value"
 in parse_date() of dataparse.py and it is "datetime.date" type, where it
 should be of a string type. So if the type is "datetime.date", then why
 isn't the check on line 752 of
 django.db.models.fields.`__`init`__`.DateField passing?

 The line in question (752 of
 django.db.models.fields.`__`init`__`.DateField):
 {{{#!python
 if isinstance(value, datetime.date):
 }}}

 The strange thing is that I only have this issue when running "manage.py
 test" and running all my unit test files. If I run a single unit test file
 via the pattern flag "-p" on a test file where an exception is stemming
 from, it runs fine. Also, running my application does not produce any of
 these exceptions, so it's only running all the unit test files.

 Any ideas what is causing this?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.479ae314721eb82e2845dd2e44e26216%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] e2e248: Renamed first argument of class method to cls

2013-12-07 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: e2e2482391a4e7bd519be9b72e92ed00b2ab2f07
  
https://github.com/django/django/commit/e2e2482391a4e7bd519be9b72e92ed00b2ab2f07
  Author: maurycyp 
  Date:   2013-12-07 (Sat, 07 Dec 2013)

  Changed paths:
M django/contrib/humanize/tests.py

  Log Message:
  ---
  Renamed first argument of class method to cls


  Commit: d653c0bd2ea25a53ac5f76cb854cc1b3e083ea0e
  
https://github.com/django/django/commit/d653c0bd2ea25a53ac5f76cb854cc1b3e083ea0e
  Author: Alex Gaynor 
  Date:   2013-12-07 (Sat, 07 Dec 2013)

  Changed paths:
M django/contrib/humanize/tests.py

  Log Message:
  ---
  Merge pull request #2050 from maurycyp/master

Renamed first argument of class method to cls


Compare: https://github.com/django/django/compare/5c61b8519d8c...d653c0bd2ea2

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52a3c854d942_46f6d41d5454391%40hookshot-fe5-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21576: repr and len

2013-12-07 Thread Django

#21576: repr and len
-+-
 Reporter:  yakoub abaya |Owner:  nobody
 |   Status:  closed
 Type:  Uncategorized|  Version:  1.6
Component:  Documentation|   Resolution:  invalid
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by yakoub abaya ):

 yes, i apologize again .

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/091.ba09c990f77442d983c65647e619c17c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21576: repr and len

2013-12-07 Thread Django

#21576: repr and len
-+-
 Reporter:  yakoub abaya |Owner:  nobody
 |   Status:  closed
 Type:  Uncategorized|  Version:  1.6
Component:  Documentation|   Resolution:  invalid
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timo):

 I'm guessing it's a mistake in your code, but this isn't the place to get
 help with that. Here's a link to the proper channels.

 https://code.djangoproject.com/wiki/TicketClosingReasons/UseSupportChannels

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/091.c56fecc6f5d13c7c8f99bff3224c1403%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21576: repr and len

2013-12-07 Thread Django

#21576: repr and len
-+-
 Reporter:  yakoub abaya |Owner:  nobody
 |   Status:  closed
 Type:  Uncategorized|  Version:  1.6
Component:  Documentation|   Resolution:  invalid
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by yakoub abaya ):

 yes, sorry for this mistake .

 but on other topic, calling list produces this error "'QuerySet' object
 has no attribute 'META'"

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/091.b822296a6d8fd4da9395d937e0cdcbcc%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21576: repr and len

2013-12-07 Thread Django

#21576: repr and len
-+-
 Reporter:  yakoub abaya |Owner:  nobody
 |   Status:  closed
 Type:  Uncategorized|  Version:  1.6
Component:  Documentation|   Resolution:  invalid
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timo):

 * status:  new => closed
 * needs_better_patch:   => 0
 * resolution:   => invalid
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 You call these methods with the queryset as an argument. For example,
 `len(Entry.objects.all())`. This is just like `list()` below which has an
 example.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/091.9b2489ec708031e23d15b3f0f3dc27b1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18531: Remove obsolete geo sitemaps

2013-12-07 Thread Django

#18531: Remove obsolete geo sitemaps
--+
 Reporter:  claudep   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  GIS   |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"5c61b8519d8ce02e4308201f3e81fdc99ad80b58"]:
 {{{
 #!CommitTicketReference repository=""
 revision="5c61b8519d8ce02e4308201f3e81fdc99ad80b58"
 Fixed #18531 -- Deprecated Geo Sitemaps

 I've chosen a quick deprecation path, as Geo Sitemaps themselves
 are deprecated from some time now.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.64f281632f50d737e1033fa096f547de%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 5c61b8: Fixed #18531 -- Deprecated Geo Sitemaps

2013-12-07 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 5c61b8519d8ce02e4308201f3e81fdc99ad80b58
  
https://github.com/django/django/commit/5c61b8519d8ce02e4308201f3e81fdc99ad80b58
  Author: Claude Paroz 
  Date:   2013-12-07 (Sat, 07 Dec 2013)

  Changed paths:
M django/contrib/gis/sitemaps/views.py
M django/contrib/gis/tests/geoapp/test_sitemaps.py
M docs/internals/deprecation.txt
M docs/releases/1.7.txt

  Log Message:
  ---
  Fixed #18531 -- Deprecated Geo Sitemaps

I've chosen a quick deprecation path, as Geo Sitemaps themselves
are deprecated from some time now.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52a3895bc3143_70595c1d54602cf%40hookshot-fe1-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21576: repr and len

2013-12-07 Thread Django

#21576: repr and len
---+
 Reporter:  yakoub abaya   |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Documentation  |Version:  1.6
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 Queryset doesn't have methods len() and repr() as claimed under
 https://docs.djangoproject.com/en/1.6/ref/models/querysets/#when-
 querysets-are-evaluated

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.53c2b43f9237049bc82068b0c94d71ad%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21575: grammatical error in documentation

2013-12-07 Thread Django

#21575: grammatical error in documentation
---+--
 Reporter:  anonymous  |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Documentation  |  Version:  1.6
 Severity:  Normal |   Resolution:  wontfix
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by timo):

 * status:  new => closed
 * needs_better_patch:   => 0
 * resolution:   => wontfix
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Thank-you for the report. This could go either way, but I feel the current
 usage is ok.   [http://www.theguardian.com/news/datablog/2010/jul/16/data-
 plural-singular Quote] that summarizes how I feel:

   It's like agenda, a Latin plural that is now almost universally used as
 a singular. Technically the singular is datum/agendum, but we feel it
 sounds increasingly hyper-correct, old-fashioned and pompous to say "the
 data are".

 If someone else feels strongly about it, I won't object to changing it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.eeb7f8aa8ef4eecacf54ea6faa77747d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21473: Cookie based language detection no longer practical

2013-12-07 Thread Django

#21473: Cookie based language detection no longer practical
-+-
 Reporter:  ludwik   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  1.6
  Internationalization   |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by ramiro):

 See also #12794 and #15902.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.dad1e3a446d1b2cb045ab14c2ff0f281%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21575: grammatical error in documentation

2013-12-07 Thread Django

#21575: grammatical error in documentation
---+
 Reporter:  anonymous  |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Documentation  |Version:  1.6
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 You may have noticed the additional data (form-TOTAL_FORMS, form-
 INITIAL_FORMS and form-MAX_NUM_FORMS) that was required in the formset’s
 data above.

 should be

 You may have noticed the additional data that were required in the
 formset’s data above.

 in https://docs.djangoproject.com/en/dev/topics/forms/formsets/

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.9eea9e1812c8e71af9954cd87772a15a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11240: Compilemessages fails if a % character is at certain places in the .po file

2013-12-07 Thread Django

#11240: Compilemessages fails if a % character is at certain places in the .po 
file
-+-
 Reporter:  tback|Owner:
 Type:  Bug  |  garcia_marc
Component:   |   Status:  new
  Internationalization   |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by ramiro):

 I'm re-closing this ticket because the original issue was fixed two years
 ago.

 If you intend to follow-up please open a newer one with a clean slate.
 Make sure you take in account comments comment:28 and comment:30 in you
 analysis.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.c173ba4283363b65b4fa8f37d1403fb1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #11240: Compilemessages fails if a % character is at certain places in the .po file

2013-12-07 Thread Django

#11240: Compilemessages fails if a % character is at certain places in the .po 
file
-+-
 Reporter:  tback|Owner:
 Type:  Bug  |  garcia_marc
Component:   |   Status:  closed
  Internationalization   |  Version:  1.3
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by ramiro):

 * status:  new => closed
 * resolution:   => fixed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.961500e5e8ead981f4e428d45879a587%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15084: Unnecessary imports lead to ImportError

2013-12-07 Thread Django

* needs_docs: 0 => 1
* has_patch: 0 => 1
* needs_better_patch: 1 => 0

Comment:

Replying to [comment:26 akaariai]:
> Looking at the provided patch in this ticket - the pkgutil documentation
says that the get_loader() will import the module if it isn't already
imported. So, I fail to see what is the difference when using pkgutil
compared to import_module.
>
> To me it seems that as long as calling ugettext leads to importing other
apps, the importing of other apps will lead to circular imports. Is there
a way to get the module's path without doing imports?

See https://github.com/django/django/pull/2049 for an attempt to achieve
that using `imp.find_module()`.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/069.c0cfa5e8b3bfe7a85f2544e2dd4561a6%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18360: Database router example improvement

2013-12-07 Thread Django

#18360: Database router example improvement
-+-
 Reporter:  sbaechler|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  1.4
Component:  Documentation|   Resolution:  duplicate
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  multiple database|  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by claudep):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Router docs have been updated as part of fixing ticket #18657. Reopen with
 some concrete proposal if you find the docs still lacking.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.76e6cff8a595d154a2543bab49c8c468%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21473: Cookie based language detection no longer practical

2013-12-07 Thread Django

#21473: Cookie based language detection no longer practical
-+-
 Reporter:  ludwik   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  1.6
  Internationalization   |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by claudep):

 * stage:  Accepted => Ready for checkin


Comment:

 Patch looks good (and tests pass).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b667d4d5f5c9d6f00811bdc789b6e919%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21573: Cache regular expression for normalizing newlines in django.utils.text.normalize_newlines

2013-12-07 Thread Django

#21573: Cache regular expression for normalizing newlines in
django.utils.text.normalize_newlines
-+-
 Reporter:  vajrasky |Owner:  vajrasky
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Utilities|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  performance  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Baptiste Mispelon ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"a7cf48a2b7878bf98879f2963ab9a7d0e6493d9a"]:
 {{{
 #!CommitTicketReference repository=""
 revision="a7cf48a2b7878bf98879f2963ab9a7d0e6493d9a"
 Fixed #21573 -- Improved performance of utils.text.normalize_newlines.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.3cd379a28c8fbd912731c259c4baedf1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] a7cf48: Fixed #21573 -- Improved performance of utils.text...

2013-12-07 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: a7cf48a2b7878bf98879f2963ab9a7d0e6493d9a
  
https://github.com/django/django/commit/a7cf48a2b7878bf98879f2963ab9a7d0e6493d9a
  Author: Vajrasky Kok 
  Date:   2013-12-07 (Sat, 07 Dec 2013)

  Changed paths:
M django/utils/text.py

  Log Message:
  ---
  Fixed #21573 -- Improved performance of utils.text.normalize_newlines.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52a34af5e69bd_702210d3d5014127%40hookshot-fe1-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21573: Cache regular expression for normalizing newlines in django.utils.text.normalize_newlines

2013-12-07 Thread Django

#21573: Cache regular expression for normalizing newlines in
django.utils.text.normalize_newlines
-+-
 Reporter:  vajrasky |Owner:  vajrasky
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Utilities|   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  performance  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by bmispelon):

 * stage:  Accepted => Ready for checkin


Comment:

 Alright, let's go with `compiled_re` then (they're all in the same
 ballpark anyway).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.667d13b740eea41b6e8032436a30cc4a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21573: Cache regular expression for normalizing newlines in django.utils.text.normalize_newlines

2013-12-07 Thread Django

#21573: Cache regular expression for normalizing newlines in
django.utils.text.normalize_newlines
--+
 Reporter:  vajrasky  |Owner:  vajrasky
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Utilities |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  performance   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by vajrasky):

 Objection. I got different result in my machine (32 bit) with Fedora Core
 18.

 On Python 3.4 (Yeah):
 ||Function||Small||Medium||Big||
 ||original:||95 usec||625 usec||7.52 msec||
 ||simple_re:||33.6 usec||57 usec||281 usec||
 ||compiled_re:||27.2 usec||50.7 usec||273 usec||
 ||str_replace:||27.1 usec||51 usec||303 usec||

 But on Python 2.7, the {{{compiled_re}}} is still the winner:
 ||Function||Small||Medium||Big||
 ||original:||34.3 usec||231 usec||2.48 msec||
 ||simple_re:||17.6 usec||49.6 usec||343 usec||
 ||compiled_re:||14.6 usec||46.5 usec||342 usec||
 ||str_replace:||14 usec||53.3 usec||414 usec||

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.5b2ea98aa519001cf8beea921792%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 65faa8: Removed unneeded string normalization in contrib.a...

2013-12-07 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 65faa84de3fd3f42e938301574cccdec1578657d
  
https://github.com/django/django/commit/65faa84de3fd3f42e938301574cccdec1578657d
  Author: Claude Paroz 
  Date:   2013-12-07 (Sat, 07 Dec 2013)

  Changed paths:
M django/contrib/admin/helpers.py
M django/contrib/admin/views/main.py

  Log Message:
  ---
  Removed unneeded string normalization in contrib.admin

With Python 2.7 and up, named parameter keys are not limited to
bytestrings any longer. This mainly reverts 3bd384aa626.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52a337abdf0c0_6ed7fc5d5079971%40hookshot-fe1-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21482: Can not collectstatic with symlink option in Windows Vista (and Windows 7 and 8) platform

2013-12-07 Thread Django

#21482: Can not collectstatic with symlink option in Windows Vista (and Windows 
7
and 8) platform
-+
 Reporter:  vajrasky |Owner:  vajrasky
 Type:  New feature  |   Status:  assigned
Component:  contrib.staticfiles  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  windows  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by vajrasky):

 * cc: sky.kok@… (added)
 * needs_better_patch:  1 => 0
 * needs_docs:  1 => 0


Comment:

 Okay, I have updated the PR based on your request. Thanks!

 https://github.com/django/django/pull/2011

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1ce703081aaa7728fa0f2df07feaf946%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21573: Cache regular expression for normalizing newlines in django.utils.text.normalize_newlines

2013-12-07 Thread Django

#21573: Cache regular expression for normalizing newlines in
django.utils.text.normalize_newlines
--+
 Reporter:  vajrasky  |Owner:  vajrasky
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Utilities |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  performance   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by bmispelon):

 * stage:  Unreviewed => Accepted


Comment:

 (Oops, forgot to change the status of the ticket)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.530fe99a0db08f56aa252201a14a60b8%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21573: Cache regular expression for normalizing newlines in django.utils.text.normalize_newlines

2013-12-07 Thread Django

#21573: Cache regular expression for normalizing newlines in
django.utils.text.normalize_newlines
-+-
 Reporter:  vajrasky |Owner:  vajrasky
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Utilities|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  performance  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by bmispelon):

 I ran a small benchmark [1] with four variants:

 * The original function
 * The same function but with a simpler regexp (`r'\r\n|\r'` instead of
 `r'\r\n|\r|\n'`)
 * The original function with a compiled regexp
 * A function using `str.replace` instead of `re.sub`

 I tried each variant on 3 different sizes of text: small (~20 lines),
 medium (~200 lines), and big (~2000 lines).

 Here are the results (less is better):

 ||= =||=  Small  =||= Medium  =||=   Big=||
 ||= original=|| 19.2 usec || 141 usec  ||  1.65 msec ||
 ||= simple_re   =|| 7.42 usec || 14.8 usec ||  135 usec  ||
 ||= compiled_re =|| 6.15 usec || 13.8 usec ||  146 usec  ||
 ||= str_replace =|| 5.29 usec || 16.4 usec ||  130 usec  ||


 The `str.replace` looks like a clear winner to me so unless there are
 objections, I'll commit that one.

 [1] https://gist.github.com/bmispelon/7841287

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f138ac24d30cf7f87c7a1b061318599b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15742: Bug: Mark all does not contain full queryset when using intermidiate pages in Django admin

2013-12-07 Thread Django

#15742: Bug: Mark all does not contain full queryset when using intermidiate 
pages
in Django admin
-+-
 Reporter:  Herman S |Owner:  nobody
  |   Status:  new
 Type:  Bug  |  Version:  1.3
Component:  Documentation|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by gamesbook):

 Can anyone look at the Django source code and figure a fix, based on the
 discussions hosted at http://www.jpichon.net/blog/2010/08/django-admin-
 actions-and-intermediate-pages/ ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/094.5c8214bc30a7d450d339ddda849217f7%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21510: Admin change list search field is missing the "show all" link

2013-12-07 Thread Django

#21510: Admin change list search field is missing the "show all" link
-+-
 Reporter:  moritz.pfeiffer@…|Owner:  claudep
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  1.6
 Severity:  Release blocker  |   Resolution:
 Keywords:  search field show| Triage Stage:  Accepted
  all missing link   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-
Changes (by claudep):

 * needs_tests:  1 => 0


Comment:

 https://github.com/django/django/pull/2047

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/086.a1ad117cff174e178590e60af40dcf7d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] e7dcd4: Added extra newline for flake8.

2013-12-07 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: e7dcd40da29008070267828fc15f5dfc94493111
  
https://github.com/django/django/commit/e7dcd40da29008070267828fc15f5dfc94493111
  Author: Tim Graham 
  Date:   2013-12-07 (Sat, 07 Dec 2013)

  Changed paths:
M tests/view_tests/tests/test_debug.py

  Log Message:
  ---
  Added extra newline for flake8.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52a30f57c04f5_a4aaf7d50308a0%40hookshot-fe4-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] a8f455: Fixed #21555 -- Made ValidationError pickable.

2013-12-07 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: a8f4553aaecc7bc6775e0fd54f8c615c792b3d97
  
https://github.com/django/django/commit/a8f4553aaecc7bc6775e0fd54f8c615c792b3d97
  Author: Loic Bistuer 
  Date:   2013-12-07 (Sat, 07 Dec 2013)

  Changed paths:
M django/core/exceptions.py
A tests/validation/test_picklable.py

  Log Message:
  ---
  Fixed #21555 -- Made ValidationError pickable.

Thanks trac username zanuxzan for the report and original patch.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52a30f3d1cd46_1432111bd58137c%40hookshot-fe6-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21555: ValidationError is not picklable

2013-12-07 Thread Django

#21555: ValidationError is not picklable
--+-
 Reporter:  zanuxzan  |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Ready for checkin
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+-
Changes (by Loic Bistuer ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"a8f4553aaecc7bc6775e0fd54f8c615c792b3d97"]:
 {{{
 #!CommitTicketReference repository=""
 revision="a8f4553aaecc7bc6775e0fd54f8c615c792b3d97"
 Fixed #21555 -- Made ValidationError pickable.

 Thanks trac username zanuxzan for the report and original patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f21116165fd4c88b1ea9b5f96c533c71%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15053: Make templates more reusable by Improving template loading algorithm to avoid extending infinite recursion

2013-12-07 Thread Django

#15053: Make templates more reusable by Improving template loading algorithm to
avoid extending infinite recursion
-+
 Reporter:  pmartin  |Owner:  unaizalakain
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by apollo13):

 * cc: apollo13 (added)
 * needs_better_patch:  0 => 1


Comment:

 I think this patch needs a bit of improvement:
  * The errors are completely unintuitive: http://i.imgur.com/LQq65S5.png
 -- it can't find index.html although it obviously exists in the app-
 template loader
  * Loaders shouldn't get skipped, just templates; the reasoning for that
 is simple: One of the most common usecases for this feature will be that I
 have the admin and some app extending the admin; both of them will be in
 INSTALLED_APPS but should be able to extend each other.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.50e9438de10ad2168247baac5d01f574%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21510: Admin change list search field is missing the "show all" link

2013-12-07 Thread Django

#21510: Admin change list search field is missing the "show all" link
-+-
 Reporter:  moritz.pfeiffer@…|Owner:  claudep
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  1.6
 Severity:  Release blocker  |   Resolution:
 Keywords:  search field show| Triage Stage:  Accepted
  all missing link   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  1
Easy pickings:  0|
-+-
Changes (by claudep):

 * status:  new => assigned
 * owner:  nobody => claudep


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/086.5791a33c02e09e54e8649d46ec4b85df%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 45c0d2: [1.6.x] Fixed #21551 -- Reenabled loading fixtures...

2013-12-07 Thread GitHub

  Branch: refs/heads/stable/1.6.x
  Home:   https://github.com/django/django
  Commit: 45c0d2e1ce0fe024e4a80c9dde8263f5ff59d577
  
https://github.com/django/django/commit/45c0d2e1ce0fe024e4a80c9dde8263f5ff59d577
  Author: Claude Paroz 
  Date:   2013-12-07 (Sat, 07 Dec 2013)

  Changed paths:
M django/core/management/commands/loaddata.py
M docs/releases/1.6.1.txt
A tests/fixtures_regress/fixtures_1/inner/absolute.json
M tests/fixtures_regress/tests.py

  Log Message:
  ---
  [1.6.x] Fixed #21551 -- Reenabled loading fixtures from subdirectory

This was a regression in Django 1.6 that was only partially
restored in 839940f27f.
Thanks Jonas Haag for the report.
Backport of 41ebc4838d from master.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52a2ef17dd45e_70595c1d5455666%40hookshot-fe1-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21551: 1.6 regression: Can't load fixtures from subdir

2013-12-07 Thread Django

#21551: 1.6 regression: Can't load fixtures from subdir
-+-
 Reporter:  jonash   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  1.6
  commands)  |   Resolution:  fixed
 Severity:  Release blocker  | Triage Stage:  Accepted
 Keywords:  loaddata, fixtures   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by Claude Paroz ):

 In [changeset:"45c0d2e1ce0fe024e4a80c9dde8263f5ff59d577"]:
 {{{
 #!CommitTicketReference repository=""
 revision="45c0d2e1ce0fe024e4a80c9dde8263f5ff59d577"
 [1.6.x] Fixed #21551 -- Reenabled loading fixtures from subdirectory

 This was a regression in Django 1.6 that was only partially
 restored in 839940f27f.
 Thanks Jonas Haag for the report.
 Backport of 41ebc4838d from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d0e2edb0da41ecc14b34e68e6ec3228d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21551: 1.6 regression: Can't load fixtures from subdir

2013-12-07 Thread Django

#21551: 1.6 regression: Can't load fixtures from subdir
-+-
 Reporter:  jonash   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  1.6
  commands)  |   Resolution:  fixed
 Severity:  Release blocker  | Triage Stage:  Accepted
 Keywords:  loaddata, fixtures   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"41ebc4838d2b09e7f3ece8889e21492902b55dc8"]:
 {{{
 #!CommitTicketReference repository=""
 revision="41ebc4838d2b09e7f3ece8889e21492902b55dc8"
 Fixed #21551 -- Reenabled loading fixtures from subdirectory

 This was a regression in Django 1.6 that was only partially
 restored in 839940f27f.
 Thanks Jonas Haag for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.faed0a10c8ffac42f12205227e2c85fc%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 41ebc4: Fixed #21551 -- Reenabled loading fixtures from su...

2013-12-07 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 41ebc4838d2b09e7f3ece8889e21492902b55dc8
  
https://github.com/django/django/commit/41ebc4838d2b09e7f3ece8889e21492902b55dc8
  Author: Claude Paroz 
  Date:   2013-12-07 (Sat, 07 Dec 2013)

  Changed paths:
M django/core/management/commands/loaddata.py
M docs/releases/1.6.1.txt
A tests/fixtures_regress/fixtures_1/inner/absolute.json
M tests/fixtures_regress/tests.py

  Log Message:
  ---
  Fixed #21551 -- Reenabled loading fixtures from subdirectory

This was a regression in Django 1.6 that was only partially
restored in 839940f27f.
Thanks Jonas Haag for the report.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52a2eecc30a0_e8b9d5d50810c4%40hookshot-fe2-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20516: Allow use of prepared statements

2013-12-07 Thread Django

#20516: Allow use of prepared statements
-+-
 Reporter:  est  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  db, prepared |  Needs documentation:  0
  statement  |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by FunkyBob):

 One idea that struck me the other day-

 A prepared statement could yield a function with keyword arguments
 matching its bound parameters.

 Something like:

 s = MyModel.objects.filter(foo__bar=Param('able'),
 baz=Param('baker')).exclude(foo_quux=7)

 Though perhaps an explicit "prepare()" would be better, the Param
 arguments mark where to bind parameters, and what to call them.

 The, you can execute the query with:

 for my in s(able=1, baker="wibble")

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.830f419bfd0796a363a7eb851ef28cb4%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21568: ModelMultipleChoiceField + show_hidden_initial + has_changed = TypeError

2013-12-07 Thread Django

#21568: ModelMultipleChoiceField + show_hidden_initial + has_changed = TypeError
-+-
 Reporter:  dibrovsd@…   |Owner:  claudep
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.6
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
  ModelMultipleChoiceField   |  Needs documentation:  0
  show_hidden_initial|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by Claude Paroz ):

 In [changeset:"34c4b93c84e86665d66d0b31da8e30fd581d5b5f"]:
 {{{
 #!CommitTicketReference repository=""
 revision="34c4b93c84e86665d66d0b31da8e30fd581d5b5f"
 [1.6.x] Fixed #21568 -- Added missing ModelMultipleChoiceField to_python
 method

 Thanks dibrovsd at gmail.com for the report and Simon Charette
 for the review.
 Backport of 8a9c8bb90 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.f8c7a2dd7a0deefd27762c870e13513f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 34c4b9: [1.6.x] Fixed #21568 -- Added missing ModelMultipl...

2013-12-07 Thread GitHub

  Branch: refs/heads/stable/1.6.x
  Home:   https://github.com/django/django
  Commit: 34c4b93c84e86665d66d0b31da8e30fd581d5b5f
  
https://github.com/django/django/commit/34c4b93c84e86665d66d0b31da8e30fd581d5b5f
  Author: Claude Paroz 
  Date:   2013-12-07 (Sat, 07 Dec 2013)

  Changed paths:
M django/forms/models.py
M docs/releases/1.6.1.txt
M tests/model_forms_regress/tests.py

  Log Message:
  ---
  [1.6.x] Fixed #21568 -- Added missing ModelMultipleChoiceField to_python 
method

Thanks dibrovsd at gmail.com for the report and Simon Charette
for the review.
Backport of 8a9c8bb90 from master.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52a2e8a6cee08_700b981d5471439%40hookshot-fe1-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21568: ModelMultipleChoiceField + show_hidden_initial + has_changed = TypeError

2013-12-07 Thread Django

#21568: ModelMultipleChoiceField + show_hidden_initial + has_changed = TypeError
-+-
 Reporter:  dibrovsd@…   |Owner:  claudep
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.6
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
  ModelMultipleChoiceField   |  Needs documentation:  0
  show_hidden_initial|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by Claude Paroz ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8a9c8bb90736451e6bdea82723cbb23a695146fb"]:
 {{{
 #!CommitTicketReference repository=""
 revision="8a9c8bb90736451e6bdea82723cbb23a695146fb"
 Fixed #21568 -- Added missing ModelMultipleChoiceField to_python method

 Thanks dibrovsd at gmail.com for the report and Simon Charette
 for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.1f816b7424ccdc5ae5bdfadf4b539c18%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 8a9c8b: Fixed #21568 -- Added missing ModelMultipleChoiceF...

2013-12-07 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 8a9c8bb90736451e6bdea82723cbb23a695146fb
  
https://github.com/django/django/commit/8a9c8bb90736451e6bdea82723cbb23a695146fb
  Author: Claude Paroz 
  Date:   2013-12-07 (Sat, 07 Dec 2013)

  Changed paths:
M django/forms/models.py
M docs/releases/1.6.1.txt
M tests/model_forms_regress/tests.py

  Log Message:
  ---
  Fixed #21568 -- Added missing ModelMultipleChoiceField to_python method

Thanks dibrovsd at gmail.com for the report and Simon Charette
for the review.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52a2e850431a9_6331c7dd50624%40hookshot-fe3-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21574: Different behaviour in Python 2 and 3 when normalizing newlines with django.utils.text.normalize_newlines

2013-12-07 Thread Django

#21574: Different behaviour in Python 2 and 3 when normalizing newlines with
django.utils.text.normalize_newlines
---+--
 Reporter:  vajrasky   |Owner:  vajrasky
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--

Comment (by vajrasky):

 Or maybe when we give bytes to {{{normalize_newlines}}}, we will get
 bytes. But if it is string, then we'll get string. But I believe this will
 break backward compatibility. My vote is on banning bytes.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.86839d5f977efe37aed23ba5407d653e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21572: Add unit test for django.utils.text.normalize_newlines

2013-12-07 Thread Django

#21572: Add unit test for django.utils.text.normalize_newlines
-+-
 Reporter:  vajrasky |Owner:  vajrasky
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Uncategorized|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:
 Keywords:  test |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Vajrasky Kok ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"a1a26690b9c060e2ba1cf6437d5fa9b9a8952017"]:
 {{{
 #!CommitTicketReference repository=""
 revision="a1a26690b9c060e2ba1cf6437d5fa9b9a8952017"
 Fixed #21572 -- Added unit test for django.utils.text.normalize_newlines.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f2403b780cecb2667f9011ad49bf9706%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21572: Add unit test for django.utils.text.normalize_newlines

2013-12-07 Thread Django

#21572: Add unit test for django.utils.text.normalize_newlines
-+-
 Reporter:  vajrasky |Owner:  vajrasky
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Uncategorized|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:
 Keywords:  test |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"6d20a80d986848da5944904c7f91d6e002701ef1"]:
 {{{
 #!CommitTicketReference repository=""
 revision="6d20a80d986848da5944904c7f91d6e002701ef1"
 Merge pull request #2045 from vajrasky/ticket_21572

 Fixed #21572 -- Added unit test for
 django.utils.text.normalize_newlines...
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.6d609d856f770a99c881a5104225f2ce%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] a1a266: Fixed #21572 -- Added unit test for django.utils.t...

2013-12-07 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: a1a26690b9c060e2ba1cf6437d5fa9b9a8952017
  
https://github.com/django/django/commit/a1a26690b9c060e2ba1cf6437d5fa9b9a8952017
  Author: Vajrasky Kok 
  Date:   2013-12-07 (Sat, 07 Dec 2013)

  Changed paths:
M tests/utils_tests/test_text.py

  Log Message:
  ---
  Fixed #21572 -- Added unit test for django.utils.text.normalize_newlines.


  Commit: 6d20a80d986848da5944904c7f91d6e002701ef1
  
https://github.com/django/django/commit/6d20a80d986848da5944904c7f91d6e002701ef1
  Author: Claude Paroz 
  Date:   2013-12-07 (Sat, 07 Dec 2013)

  Changed paths:
M tests/utils_tests/test_text.py

  Log Message:
  ---
  Merge pull request #2045 from vajrasky/ticket_21572

Fixed #21572 -- Added unit test for django.utils.text.normalize_newlines...


Compare: https://github.com/django/django/compare/19b22d4f0e0e...6d20a80d9868

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/52a2e54da3d18_d79f05d4843529%40hookshot-fe2-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21574: Different behaviour in Python 2 and 3 when normalizing newlines with django.utils.text.normalize_newlines

2013-12-07 Thread Django

#21574: Different behaviour in Python 2 and 3 when normalizing newlines with
django.utils.text.normalize_newlines
---+--
 Reporter:  vajrasky   |Owner:  vajrasky
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by vajrasky):

 * status:  new => assigned
 * cc: sky.kok@… (added)
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * owner:  nobody => vajrasky
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4653eab4fbefe81f722fe75caa67baf5%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21574: Different behaviour in Python 2 and 3 when normalizing newlines with django.utils.text.normalize_newlines

2013-12-07 Thread Django

#21574: Different behaviour in Python 2 and 3 when normalizing newlines with
django.utils.text.normalize_newlines
+
 Reporter:  vajrasky|  Owner:  nobody
 Type:  Bug | Status:  new
Component:  Utilities   |Version:  master
 Severity:  Normal  |   Keywords:
 Triage Stage:  Unreviewed  |  Has patch:  0
Easy pickings:  1   |  UI/UX:  0
+
 Python 3.3:

 {{{
 >>> from django.utils.text import normalize_newlines
 >>> normalize_newlines("abc\r\ndef")
 'abc\ndef'
 >>> normalize_newlines(b"abc\r\ndef")
 Traceback (most recent call last):
   File "", line 1, in 
   File "/home/sky/Code/python/env/django/lib/python3.3/site-
 packages/django/utils/functional.py", line 213, in wrapper
 return func(*args, **kwargs)
   File "/home/sky/Code/python/env/django/lib/python3.3/site-
 packages/django/utils/text.py", line 252, in normalize_newlines
 return force_text(re.sub(r'\r\n|\r|\n', '\n', text))
   File "/usr/lib64/python3.3/re.py", line 170, in sub
 return _compile(pattern, flags).sub(repl, string, count)
 TypeError: can't use a string pattern on a bytes-like object
 }}}

 Python 2.7:

 {{{
 >>> from django.utils.text import normalize_newlines
 >>> normalize_newlines(u"abc\r\ndef")
 u'abc\ndef'
 >>> normalize_newlines("abc\r\ndef")
 u'abc\ndef'
 }}}

 I can produce the patch but I need to know who is in fault here: Python 2
 or Python 3? Should Python 2 rejects binary or should Python 3 accepts
 binary?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.933873036bc56aba8f025b78abc5c899%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21573: Cache regular expression for normalizing newlines in django.utils.text.normalize_newlines

2013-12-07 Thread Django

#21573: Cache regular expression for normalizing newlines in
django.utils.text.normalize_newlines
-+-
 Reporter:  vajrasky |Owner:  vajrasky
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Utilities|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  performance  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by vajrasky):

 * status:  new => assigned
 * cc: sky.kok@… (added)
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * owner:  nobody => vajrasky
 * needs_docs:   => 0
 * has_patch:  0 => 1


Comment:

 Here is the PR: https://github.com/django/django/pull/2046

 The unit test for normalize_newlines can be found in #21572.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.dc4e3f353da7210fe34eb9aed4ee8aac%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21573: Cache regular expression for normalizing newlines in django.utils.text.normalize_newlines

2013-12-07 Thread Django

#21573: Cache regular expression for normalizing newlines in
django.utils.text.normalize_newlines
--+-
 Reporter:  vajrasky  |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Utilities |Version:  master
 Severity:  Normal|   Keywords:  performance
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  1 |  UI/UX:  0
--+-
 This is the method:

 {{{
 def normalize_newlines(text):
 return force_text(re.sub(r'\r\n|\r|\n', '\n', text))
 normalize_newlines = allow_lazy(normalize_newlines, six.text_type)
 }}}


 It should be:

 {{{
 _newlines_re = re.compile(r'\r\n|\r|\r')
 def normalize_newlines(text):
 return force_text(_newlines_re.sub('\n', text))
 normalize_newlines = allow_lazy(normalize_newlines, six.text_type)
 }}}

 Things to be considered:
 * Do we use this method often in Django? If not, caching may not be
 necessary.
 * From http://docs.python.org/2/library/re.html#re.compile: The compiled
 versions of the most recent patterns passed to re.match(), re.search() or
 re.compile() are cached, so programs that use only a few regular
 expressions at a time needn’t worry about compiling regular expressions.
 * The performance gain maybe negligible.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.17bed9f9f8bd29a5d67e9ee1ddd4aceb%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21571: typo in model refernce page

2013-12-07 Thread Django

#21571: typo in model refernce page
---+--
 Reporter:  jfindlay@… |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Documentation  |  Version:  1.6
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by russellm):

 * status:  new => closed
 * needs_better_patch:   => 0
 * resolution:   => invalid
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 I don't see a typo here. The referenced paragraph is referring to a use
 case where you are breaking your database into shards. As far as I can
 make out, sharding is the right word, correctly spelled in this context.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.df7d1d258ecb333e68abba28a8febef8%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21572: Add unit test for django.utils.text.normalize_newlines

2013-12-07 Thread Django

#21572: Add unit test for django.utils.text.normalize_newlines
-+-
 Reporter:  vajrasky |Owner:  vajrasky
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Uncategorized|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  test |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by vajrasky):

 * status:  new => assigned
 * cc: sky.kok@… (added)
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * owner:  nobody => vajrasky
 * needs_docs:   => 0
 * has_patch:  0 => 1


Comment:

 Here is the PR: https://github.com/django/django/pull/2045

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.756ce904f31b477a1f4697d0cf01b0f1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21572: Add unit test for django.utils.text.normalize_newlines

2013-12-07 Thread Django

#21572: Add unit test for django.utils.text.normalize_newlines
--+
 Reporter:  vajrasky  |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Uncategorized |Version:  master
 Severity:  Normal|   Keywords:  test
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  1 |  UI/UX:  0
--+
 Currently there is no unit test for django.utils.text.normalize_newlines.

 [sky@localhost django]$ grep -R normalize_newlines tests/*
 [sky@localhost django]$

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.0a6c74ff57716c0f128d1e54e3df2363%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

53 matches

Mail list logo