date:20140306

Re: [Django] #22224: Non-nullable blank string-based model field validation doesn't prevent or clean `None`

2014-03-06 Thread Django

#4: Non-nullable blank string-based model field validation doesn't prevent 
or
clean `None`
-+-
 Reporter:  charettes|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by charettes):

 * has_patch:  0 => 1
 * component:  Uncategorized => Database layer (models, ORM)


Comment:

 See https://github.com/django/django/pull/2409

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.02f6a353ee856588741e226d92b34963%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #22224: Non-nullable blank string-based model field validation doesn't prevent or clean `None`

2014-03-06 Thread Django

[https://docs.djangoproject.com/en/dev/ref/models/fields/#django.db.models.Field.null
we discourage the use of NULLable string-based fields] the assumed way of
holding text that might be empty would be to use the `blank` option.

In this case I would expect `full_clean` to raise a `ValidationError` when
an empty non-nullable field is assigned `None`:

{{{#!python
from django.db import models

class A(models.Model):
b = models.CharField(blank=True)

a = A(b=None)
a.full_clean() # Passes
a.save() # Integrity error
}}}

Unfortunately specifying `blank=True` disable all validation against the
`b` field, leading to database integrity error upon calling `save()`. The
obvious solution here would be to override `A.clean` to convert `b` to an
empty string when it equals `None` but it strikes me as a non trivial
change for a quite common use case: correctly allowing a string-based
field to be empty.

This is not an issue when cleaning data retrieved from the usual
`application/form-url-encoded` `request.GET` or `request.POST` since an
empty value is always represented by the empty string. However, in the
case of an `application/json` encoded payload one may either provide
`None` or `''` (`null` or `''`) to express emptiness. Which will trigger
the issue described above.

Attaching a patch that special case the `empty_values` of non-nullable
string based fields based on the `empty_strings_allowed` flag. All tests
pass on Py7/SQLite3.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/052.6886655fe8cd9631a5b5508438bf60e8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22223: reverse() escapes unreserved characters

2014-03-06 Thread Django

#3: reverse() escapes unreserved characters
--+--
 Reporter:  erik.van.zijst@…  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Core (URLs)   |  Version:  1.6
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by erik.van.zijst@…):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Pull request: https://github.com/django/django/pull/2408

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/082.72e2f6b75391e2d59082eaaf010f8139%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #22223: reverse() escapes unreserved characters

2014-03-06 Thread Django

#3: reverse() escapes unreserved characters
--+
 Reporter:  erik.van.zijst@…  |  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  Core (URLs)   |Version:  1.6
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 Django's `django.core.urlresolvers.reverse()` seems to have changed its
 behavior in 1.6. It now runs the arguments through `urlquote()`, without
 specifying the safe characters for path components. As a result:

 on 1.4.10:
 {{{
 In [2]: reverse('test', args=['foo:bar'])
  Out[2]: '/foo:bar'
 }}}

 but on 1.6.2:
 {{{
 In [2]: reverse('test', args=['foo:bar'])
 Out[2]: '/foo%3Abar'
 }}}

 It would seem to me that this is a regression, as ":@-._~!$&'()*+,;=" are
 all allowed unescaped in path segments AFAIK.

 I'm bringing this up because it breaks certain OAuth 1 clients against
 Bitbucket.

 In some places we redirect to URLs whose path segment contains a ":".
 Prior to us upgrading to 1.6 the response's location header preserved that
 colon, but now it gets escaped, changing the URL (e.g.
 https://api.bitbucket.org/2.0/repositories/david/django-
 storages/pullrequests/51/diff redirecting to
 https://api.bitbucket.org/2.0/repositories/david/django-
 storages/diff/regadas/django-storages%3A069fd1d01fbf..f153a70ba254)

 In OAuth 1, requests are signed, including the request URL, but the
 RFC-5849 does not mandate any pre-processing of the URL. For several OAuth
 clients (including requests-oauthlib and python-oauth2) that means they
 compute the signature over a string that contains "%3A" instead of ":".

 On the server however, the request path automatically gets unquoted before
 it hits the middlewares and views. As our OAuth layer is a middleware that
 reconstructs the signature, it ends up computing over ":", yielding a
 different signature than the client, breaking authentication.

 This might be addressable by changing these OAuth clients to perform
 unquoting on the path segment, but a better solution would seem to make
 `urlresolvers.py:RegexURLResolver` respect the reserved characters for
 path segments and not escape what does not need to be escaped.

 I'll follow up with a pull request, unless there are strong feelings, or
 unwanted consequences of that approach.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d7ba0f45b3f298df8df7fc72945d2c90%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22217: ManyToManyField.through_fields docs mix up description of arguments

2014-03-06 Thread Django

#22217: ManyToManyField.through_fields docs mix up description of arguments
-+--
 Reporter:  dfunckt  |Owner:  dfunckt
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by loic84):

 * cc: loic@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.00d2b0b00781fc40e92fcd4da791c1aa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22217: ManyToManyField.through_fields docs mix up description of arguments

2014-03-06 Thread Django

#22217: ManyToManyField.through_fields docs mix up description of arguments
-+--
 Reporter:  dfunckt  |Owner:  dfunckt
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by loic84):

 I noticed that E332 was shadowed when `through_fields` was set, apparently
 it's fixed with this patch.

 Regarding the new `ValueError`, any reason it can't be made a system check
 as well?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4c85e4e76061a8f15c435e0969501286%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18731: "makemessages" management command should handle import aliases

2014-03-06 Thread Django

#18731: "makemessages" management command should handle import aliases
-+-
 Reporter:  diabeteman   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:  1.4
  commands)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  makemessages i18n|  Needs documentation:  0
  gettext|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timo):

 * stage:  Ready for checkin => Accepted


Comment:

 You need someone besides yourself to review the patch in order to mark it
 RFC, thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.a307648b16c5cf37b2c4dd8deae0155f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22070: Admin index shows mixed lowercase and capitalized app names when using contrib apps and old-style apps

2014-03-06 Thread Django

#22070: Admin index shows mixed lowercase and capitalized app names when using
contrib apps and old-style apps
-+-
 Reporter:  bendavis78   |Owner:
 Type:   |  jenkinsbr2
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  admin app-loading| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"ec675ed6ccd1ad80e289dc01275e225552c489a3"]:
 {{{
 #!CommitTicketReference repository=""
 revision="ec675ed6ccd1ad80e289dc01275e225552c489a3"
 Fixed #22070 -- Changed verbose_name for apps in django.contrib to use
 title case

 Thanks bendavis78 for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.4f67bf87b2159c6868113fb0b1c863e2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[django/django] ec675e: Fixed #22070 -- Changed verbose_name for apps in d...

2014-03-06 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: ec675ed6ccd1ad80e289dc01275e225552c489a3
  
https://github.com/django/django/commit/ec675ed6ccd1ad80e289dc01275e225552c489a3
  Author: James Jenkins <2.8li...@gmail.com>
  Date:   2014-03-06 (Thu, 06 Mar 2014)

  Changed paths:
M django/contrib/admin/apps.py
M django/contrib/admindocs/apps.py
M django/contrib/auth/apps.py
M django/contrib/comments/apps.py
M django/contrib/contenttypes/apps.py
M django/contrib/flatpages/apps.py
M django/contrib/formtools/apps.py
M django/contrib/humanize/apps.py
M django/contrib/messages/apps.py
M django/contrib/redirects/apps.py
M django/contrib/sessions/apps.py
M django/contrib/sitemaps/apps.py
M django/contrib/sites/apps.py
M django/contrib/staticfiles/apps.py
M django/contrib/syndication/apps.py
M django/contrib/webdesign/apps.py

  Log Message:
  ---
  Fixed #22070 -- Changed verbose_name for apps in django.contrib to use title 
case

Thanks bendavis78 for the report.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/53190821a7020_73e8725d44133154%40hookshot-fe2-cp1-prd.iad.github.net.mail.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16920: Models with GenericRelation are unnecessarily validated for clashes in reverse manager accessor

2014-03-06 Thread Django

Comment (by gabejackson):

after some more digging, this problem hasn't been solved – it only
vanished. Apparently, GenericRelations currently don't get check()'ed.
This may have gotten lost during implementation of the new checks
framework. the PR now contains 3 tests:
- One to test that related_name will raise a TypeError when defined on
GenericRelation
- One to test the OPs concern of defining the same model name in two
different apps - this no longer leads to a clash since we do not check
related_name clashes on GenericRelation anymore (changed this code)
- One to test that equal related_query_names still resolve in a clash when
one or more GenericRelations define the same related_query_name to the
same related object

PR is updated

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/063.c1eb0cf899c77d5497fe6b41c4eb7e61%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18731: "makemessages" management command should handle import aliases

2014-03-06 Thread Django

#18731: "makemessages" management command should handle import aliases
-+-
 Reporter:  diabeteman   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:  1.4
  commands)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  makemessages i18n|  checkin
  gettext|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by diabeteman):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


Comment:

 Gentle bump.

 I hope it is not too late for integration in 1.7 :-)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.7498e836c8250cefc9c6c748eb415df7%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 1232ac: Don't allow really long migration names

2014-03-06 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 1232acb88411f9c4327971c8edff1d191eb0f170
  
https://github.com/django/django/commit/1232acb88411f9c4327971c8edff1d191eb0f170
  Author: Andrew Godwin 
  Date:   2014-03-06 (Thu, 06 Mar 2014)

  Changed paths:
M django/db/migrations/autodetector.py

  Log Message:
  ---
  Don't allow really long migration names


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/5318e9fc6cd51_77bb85dd38936a4%40hookshot-fe2-cp1-prd.iad.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] e46e15: Fixed #22204: Bad circular-dep-breaking if more th...

2014-03-06 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: e46e15e5a17c1c42d01a343e7044d2d21588493d
  
https://github.com/django/django/commit/e46e15e5a17c1c42d01a343e7044d2d21588493d
  Author: Andrew Godwin 
  Date:   2014-03-06 (Thu, 06 Mar 2014)

  Changed paths:
M django/db/migrations/autodetector.py
M tests/migrations/test_autodetector.py

  Log Message:
  ---
  Fixed #22204: Bad circular-dep-breaking if more than one per run


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/5318e77e5f1d2_6c1cd6dd3c121210%40hookshot-fe2-cp1-prd.iad.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22204: migrations yield CircularDependencyError for simple model

2014-03-06 Thread Django

#22204: migrations yield CircularDependencyError for simple model
-+--
 Reporter:  gabejackson  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Migrations   |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  migrations   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by Andrew Godwin ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e46e15e5a17c1c42d01a343e7044d2d21588493d"]:
 {{{
 #!CommitTicketReference repository=""
 revision="e46e15e5a17c1c42d01a343e7044d2d21588493d"
 Fixed #22204: Bad circular-dep-breaking if more than one per run
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.234c51b5651776a79637202070d319f3%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22210: Saving Model instance to Float Field

2014-03-06 Thread Django

#22210: Saving Model instance to Float Field
-+-
 Reporter:  hphilip456@… |Owner:  anonymous
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.6
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by smeatonj):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.0ba846b0464925837f8c443cdfa4394b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22183: Migrations don't work with custom through table on M2M fields

2014-03-06 Thread Django

#22183: Migrations don't work with custom through table on M2M fields
-+-
 Reporter:  apollo13 |Owner:
 Type:  Bug  |  andrewgodwin
Component:  Migrations   |   Status:  new
 Severity:  Release blocker  |  Version:  master
 Keywords:  sql, migrations, |   Resolution:
  m2m| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by andrewgodwin):

 * status:  closed => new
 * resolution:  fixed =>


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.36b882de51e1c5308f82b2d1dd6fa423%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22183: Migrations don't work with custom through table on M2M fields

2014-03-06 Thread Django

#22183: Migrations don't work with custom through table on M2M fields
-+-
 Reporter:  apollo13 |Owner:
 Type:  Bug  |  andrewgodwin
Component:  Migrations   |   Status:  assigned
 Severity:  Release blocker  |  Version:  master
 Keywords:  sql, migrations, |   Resolution:
  m2m| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by andrewgodwin):

 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.9d466bd3e0b4aeb9ded343f636359e51%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 8ce3ea: Revert "Fixed #22183: Don't make a table for M2Ms ...

2014-03-06 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 8ce3ea687cfae0bc47fcf023cb1f523dae4664ef
  
https://github.com/django/django/commit/8ce3ea687cfae0bc47fcf023cb1f523dae4664ef
  Author: Andrew Godwin 
  Date:   2014-03-06 (Thu, 06 Mar 2014)

  Changed paths:
M django/db/backends/schema.py
M django/db/models/fields/related.py

  Log Message:
  ---
  Revert "Fixed #22183: Don't make a table for M2Ms with through="

This reverts commit 1562b9896f8f614ef40fd032b1ec777280b377c1.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/5318d1745366_6faa5d9d3c46385%40hookshot-fe2-cp1-prd.iad.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22183: Migrations don't work with custom through table on M2M fields

2014-03-06 Thread Django

#22183: Migrations don't work with custom through table on M2M fields
-+-
 Reporter:  apollo13 |Owner:
 Type:  Bug  |  andrewgodwin
Component:  Migrations   |   Status:  closed
 Severity:  Release blocker  |  Version:  master
 Keywords:  sql, migrations, |   Resolution:  fixed
  m2m| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Andrew Godwin ):

 In [changeset:"8ce3ea687cfae0bc47fcf023cb1f523dae4664ef"]:
 {{{
 #!CommitTicketReference repository=""
 revision="8ce3ea687cfae0bc47fcf023cb1f523dae4664ef"
 Revert "Fixed #22183: Don't make a table for M2Ms with through="

 This reverts commit 1562b9896f8f614ef40fd032b1ec777280b377c1.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.22931980d95c3d1596a5fda42499a25f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 1562b9: Fixed #22183: Don't make a table for M2Ms with thr...

2014-03-06 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 1562b9896f8f614ef40fd032b1ec777280b377c1
  
https://github.com/django/django/commit/1562b9896f8f614ef40fd032b1ec777280b377c1
  Author: Andrew Godwin 
  Date:   2014-03-06 (Thu, 06 Mar 2014)

  Changed paths:
M django/db/backends/schema.py
M django/db/models/fields/related.py

  Log Message:
  ---
  Fixed #22183: Don't make a table for M2Ms with through=


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/5318ce4493d1b_73e8725d4411934c%40hookshot-fe2-cp1-prd.iad.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22183: Migrations don't work with custom through table on M2M fields

2014-03-06 Thread Django

#22183: Migrations don't work with custom through table on M2M fields
-+-
 Reporter:  apollo13 |Owner:
 Type:  Bug  |  andrewgodwin
Component:  Migrations   |   Status:  closed
 Severity:  Release blocker  |  Version:  master
 Keywords:  sql, migrations, |   Resolution:  fixed
  m2m| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Andrew Godwin ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"1562b9896f8f614ef40fd032b1ec777280b377c1"]:
 {{{
 #!CommitTicketReference repository=""
 revision="1562b9896f8f614ef40fd032b1ec777280b377c1"
 Fixed #22183: Don't make a table for M2Ms with through=
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.baf713624bbedb97142ff33750651710%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22222: Broken link (flup)

2014-03-06 Thread Django

#2: Broken link (flup)
---+--
 Reporter:  anonymous  |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Documentation  |  Version:  1.6
 Severity:  Normal |   Resolution:  wontfix
 Keywords:  broken link| Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by bmispelon):

 * status:  new => closed
 * needs_docs:   => 0
 * resolution:   => wontfix
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 Hi,

 Yes, it seems the website is having some issues but a 500 error is
 probably just temporary.

 Let's give it a few days and if the site is still down, we can reopen this
 ticket and start looking for an alternative link.

 Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f93c309726329655fe97e57aef87c3e7%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #22222: Broken link (flup)

2014-03-06 Thread Django

#2: Broken link (flup)
---+-
 Reporter:  anonymous  |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Documentation  |Version:  1.6
 Severity:  Normal |   Keywords:  broken link
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  1  |  UI/UX:  0
---+-
 In this page
 (https://docs.djangoproject.com/en/1.6/howto/deployment/fastcgi/) I
 clicked the flup link of the "Prerequisite: flup" section and the page
 that it took me to was not working (error code 500).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.94a2bfac13f8f327ec46c628b02f17f6%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16920: Models with GenericRelation are unnecessarily validated for clashes in reverse manager accessor

2014-03-06 Thread Django

#16920: Models with GenericRelation are unnecessarily validated for clashes in
reverse manager accessor
-+-
 Reporter:  r1cky|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by gabejackson):

 Wrote two tests to cover this.

 On django 1.5.1:
 {{{
 gabejackson@jax: tests# PYTHONPATH=..:$PYTHONPATH python ./runtests.py
 --settings=test_sqlite generic_relations
 Creating test database for alias 'default'...
 Creating test database for alias 'other'...
 ..F...F..
 ==
 FAIL: test_generic_relation_related_name_not_allowed
 (generic_relations.tests.GenericRelationsTests)
 --
 Traceback (most recent call last):
   File
 
"/Users/gabejackson/Documents/pycharm/django-1.6.2/tests/generic_relations/tests.py",
 line 245, in test_generic_relation_related_name_not_allowed
 class InvalidGenericRelationModel(models.Model):
 AssertionError: TypeError not raised

 ==
 FAIL: test_multiple_gen_rel_with_same_class_name
 (generic_relations.tests.GenericRelationsTests)
 --
 Traceback (most recent call last):
   File
 
"/Users/gabejackson/Documents/pycharm/django-1.6.2/tests/generic_relations/tests.py",
 line 259, in test_multiple_gen_rel_with_same_class_name
 self.fail("validate() failed with: %s" % e)
 AssertionError: validate() failed with: One or more models did not
 validate:
 appone.post: Accessor for m2m field 'topic' clashes with related m2m field
 'Topic.post_set'. Add a related_name argument to the definition for
 'topic'.
 apptwo.post: Accessor for m2m field 'topic' clashes with related m2m field
 'Topic.post_set'. Add a related_name argument to the definition for
 'topic'.


 --
 Ran 9 tests in 0.107s

 FAILED (failures=2)
 Destroying test database for alias 'default'...
 Destroying test database for alias 'other'...
 }}}

 on master:
 {{{
 Testing against Django installed in '/Users/gabejackson/Documents/pycharm
 /django-generic-rel-reverse/django'
 Creating test database for alias 'default'...
 Creating test database for alias 'other'...
 .
 --
 Ran 25 tests in 0.210s

 OK
 Destroying test database for alias 'default'...
 Destroying test database for alias 'other'...
 }}}

 Pull Request is here: [https://github.com/django/django/pull/2407]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.e0b7a9e111a6cee109bf890dc87f190b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17642: min_num on admin inline formsets

2014-03-06 Thread Django

#17642: min_num on admin inline formsets
-+-
 Reporter:   |Owner:
  krzysztof.szczesny@…   |  asteinlein
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:  admin min_num| Triage Stage:  Accepted
  formsets   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-

Comment (by timo):

 I created a [https://github.com/django/django/pull/2406 pull request] from
 the branch and left some comments.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/086.2acb00ccced30a6e4cdaf78bb9ce4a8a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 34236e: Reworked ErrorDict.as_json() to prevent unnecessar...

2014-03-06 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 34236efc5e569ce7d42f7d52dd798e59f95457f8
  
https://github.com/django/django/commit/34236efc5e569ce7d42f7d52dd798e59f95457f8
  Author: Loic Bistuer 
  Date:   2014-03-06 (Thu, 06 Mar 2014)

  Changed paths:
M django/forms/utils.py

  Log Message:
  ---
  Reworked ErrorDict.as_json() to prevent unnecessary 
serialization/deserialization step.

Thanks @apollo13 for the suggestion. Refs #17413.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/5318b1bc3cb2f_9e21073d3888085%40hookshot-fe1-cp1-prd.iad.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17413: Serialization or getting non-HTML version of form errors is not easy

2014-03-06 Thread Django

#17413: Serialization or getting non-HTML version of form errors is not easy
-+-
 Reporter:  kmike|Owner:  loic84
 Type:  New feature  |   Status:  closed
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  form errors  | Triage Stage:  Ready for
  serialization  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Florian Apolloner ):

 In [changeset:"34236efc5e569ce7d42f7d52dd798e59f95457f8"]:
 {{{
 #!CommitTicketReference repository=""
 revision="34236efc5e569ce7d42f7d52dd798e59f95457f8"
 Reworked ErrorDict.as_json() to prevent unnecessary
 serialization/deserialization step.

 Thanks @apollo13 for the suggestion. Refs #17413.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.e61c484e1da67e4b4a3532c36621256e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16920: Models with GenericRelation are unnecessarily validated for clashes in reverse manager accessor

2014-03-06 Thread Django

#16920: Models with GenericRelation are unnecessarily validated for clashes in
reverse manager accessor
-+-
 Reporter:  r1cky|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by gabejackson):

 this was fixed by commit
 
[https://github.com/django/django/commit/97774429aeb54df4c09895c07cd1b09e70201f7d]
 as part of #19385

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.6cc331665b0fb911225eb97978d7f903%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22087: ModelForm Meta overrides are ignored by AdminReadonlyField

2014-03-06 Thread Django

#22087: ModelForm Meta overrides are ignored by AdminReadonlyField
---+
 Reporter:  bendavis78 |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by anonymous):

 Has there been any update on this?

 Thanks,
 Dan

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.a7db579a618d0628e7203218bcd46461%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21734: Admin doesn't catch ProtectedError

2014-03-06 Thread Django

Comment (by afuna):

It does not appear to the be the same as #19838; this ticket looks like
it's for "delete all selected" dropdown from the top of the page.

The good thing is, there does appear to be some protection in place
already. You have to go through an intermediate page to confirm, and if a
protected (nested) object is detected, then the button to confirm deletion
is simply not there, so you normally can't do a delete.

You can still trigger the ProtectedError by skipping the intermediate
page, that might be what happened here. The other possibility is that the
check for protected via get_deleted_objects is missing something (but
without more information that'll be harder to track down)

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/076.6ff240e5a6fd0465d54c22abb0525941%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22221: Wrong join promotion on ManyToManyField to self with an intermediate model.

2014-03-06 Thread Django

* status: new => closed
* resolution: => invalid

Comment:

The problem seems to be using the wrong direction in the query. The
rel_from_set in tony.friends.filter(rel_from_set...) refers to the
*friend's* rel_from_set. That is, it refers to Chris' rel_from_set, and
chris isn't the first friend in the relation. I believe the correct query
is tony.friend.filter(rel_to_set...). Closing as invalid, do reopen if my
analysis seems wrong.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.ffd61631746cd08aa1e2811ddbc44fbe%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22221: Wrong join promotion on ManyToManyField to self with an intermediate model.

2014-03-06 Thread Django

#1: Wrong join promotion on ManyToManyField to self with an intermediate 
model.
-+-
 Reporter:  loic84   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by akaariai):

 I don't see how this is a join promotion issue - why should joins be left
 joins in the generated SQL for the test case? Both joined fields are
 checked for equality in the WHERE clause. Left joins can't give more
 results as the WHERE clause can't match if either T4 or
 m2m_through_friendship are NULL.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.300196902011a0b5fb3ef62b162a081e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22070: Admin index shows mixed lowercase and capitalized app names when using contrib apps and old-style apps

2014-03-06 Thread Django

#22070: Admin index shows mixed lowercase and capitalized app names when using
contrib apps and old-style apps
-+-
 Reporter:  bendavis78   |Owner:
 Type:   |  jenkinsbr2
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin app-loading| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by jenkinsbr2):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.809864dd9b466c89efcb86b978dae852%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22210: Saving Model instance to Float Field

2014-03-06 Thread Django

#22210: Saving Model instance to Float Field
-+-
 Reporter:  hphilip456@… |Owner:  anonymous
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.6
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by anonymous):

 Hi,

 This is my initial pull request, please let me know if there is anything I
 need to adjust.
 https://github.com/django/django/pull/2404

 Regards,
 Dan

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.5e753fd20074ae6f0d1dd8de14f6e246%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22221: Wrong join promotion on ManyToManyField to self with an intermediate model.

2014-03-06 Thread Django

#1: Wrong join promotion on ManyToManyField to self with an intermediate 
model.
-+-
 Reporter:  loic84   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by loic84):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Failing testcase: https://github.com/loic/django/compare/ticket1.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.8f3c789bb3392ac164ecd2bd8c971062%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #22221: Wrong join promotion on ManyToManyField to self with an intermediate model.

2014-03-06 Thread Django

#1: Wrong join promotion on ManyToManyField to self with an intermediate 
model.
--+
 Reporter:  loic84|  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  Database layer (models, ORM)  |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 Generated SQL:

 {{{#!sql
 SELECT "m2m_through_personselfrefm2m"."id",
 "m2m_through_personselfrefm2m"."name"
 FROM "m2m_through_personselfrefm2m"
 INNER JOIN "m2m_through_friendship" ON (
 "m2m_through_personselfrefm2m"."id" = "m2m_through_friendship"."second_id"
 )
 INNER JOIN "m2m_through_friendship" T4 ON (
 "m2m_through_personselfrefm2m"."id" = T4."first_id" )
 WHERE ("m2m_through_friendship"."first_id" = 1 AND T4."reason" =
 'because')
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.6f34f84631249be995f0727930dc19a4%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #22220: reverse() documentation

2014-03-06 Thread Django

#0: reverse() documentation
+
   Reporter:  EvilDMP   |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Documentation |Version:  1.6
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 https://docs.djangoproject.com/en/dev/ref/urlresolvers/#reverse:

 {{{
 reverse(viewname[, urlconf=None, args=None, kwargs=None,
 current_app=None])
 viewname is either the function name (either a function reference, or the
 string version of the name, if you used that form in urlpatterns) or the
 URL pattern name.
 }}}

 I think this could be clearer.

 * there should be a link to an example of each of the different ways in
 the documentation (only "URL pattern name" is elucidated this way)
 * the phrase "function reference" is confusing;
 https://docs.djangoproject.com/en/dev/topics/http/urls/#passing-callable-
 objects-instead-of-strings speaks of "passing objects" for example and the
 same language should be used in both cases.

 And what if one creates a URL pattern name that's the also the string
 version of the view function name - which would win?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.8bcdb9c677cab67702ffa054f44c8895%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22185: CSRF cookie should be configurable

2014-03-06 Thread Django

#22185: CSRF cookie should be configurable
--+
 Reporter:  rogerhu   |  Owner:  nobody
 Type:  New feature   | Status:  closed
Component:  contrib.csrf  |Version:  master
 Severity:  Normal| Resolution:  fixed
 Keywords:|   Triage Stage:  Unreviewed
Has patch:  1 |  Easy pickings:  0
UI/UX:  0 |
--+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"9b729ddd8f2040722971ccfb3b12f7d8162633d1"]:
 {{{
 #!CommitTicketReference repository=""
 revision="9b729ddd8f2040722971ccfb3b12f7d8162633d1"
 Fixed #22185 -- Added settings.CSRF_COOKIE_AGE

 Thanks Paul McMillan for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.21b55c9ab8e47ba9fbe4d3db440ad326%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 9b729d: Fixed #22185 -- Added settings.CSRF_COOKIE_AGE

2014-03-06 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 9b729ddd8f2040722971ccfb3b12f7d8162633d1
  
https://github.com/django/django/commit/9b729ddd8f2040722971ccfb3b12f7d8162633d1
  Author: Roger Hu 
  Date:   2014-03-06 (Thu, 06 Mar 2014)

  Changed paths:
M django/conf/global_settings.py
M django/middleware/csrf.py
M docs/ref/contrib/csrf.txt
M docs/ref/settings.txt
M docs/releases/1.7.txt
M tests/csrf_tests/tests.py

  Log Message:
  ---
  Fixed #22185 -- Added settings.CSRF_COOKIE_AGE

Thanks Paul McMillan for the review.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/53187861c37ae_89c4cdd4491795%40hookshot-fe1-cp1-prd.iad.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21231: Limiting the number of variables and files that a POST request can contain

2014-03-06 Thread Django

#21231: Limiting the number of variables and files that a POST request can 
contain
---+
 Reporter:  epandurski@…   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  HTTP handling  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by tomchristie):

 @edevil - No, may as well keep those comments just against the PR.
 (They're not really *design* discussion stuff, just implementation
 details, so...)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.7125ed0e38662c525a282019fdb825ad%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22210: Saving Model instance to Float Field

2014-03-06 Thread Django

#22210: Saving Model instance to Float Field
-+-
 Reporter:  hphilip456@… |Owner:  anonymous
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.6
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by PirosB3):

 * status:  new => assigned
 * owner:  nobody => anonymous


Comment:

 Hi,

 Thanks for the information.
 I have managed to replicate the bug on a unit test and I have written a
 patch for it. The patch will be linked here soon. As it's my first patch,
 please let me know if anything is incorrect.

 Regards,
 Dan

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.d1cf246375dd0b688e727aa0e72ff1d2%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21231: Limiting the number of variables and files that a POST request can contain

2014-03-06 Thread Django

#21231: Limiting the number of variables and files that a POST request can 
contain
---+
 Reporter:  epandurski@…   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  HTTP handling  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by edevil):

 I have a few question regarding the pull request, which I left in the
 Github page. Should I post them here?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.b555daef849267eedd696aac39581dc9%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21231: Limiting the number of variables and files that a POST request can contain

2014-03-06 Thread Django

#21231: Limiting the number of variables and files that a POST request can 
contain
---+
 Reporter:  epandurski@…   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  HTTP handling  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by tomchristie):

 First pass pull request: https://github.com/django/django/pull/2403

 Having a single setting limiting the maximum memory for data in a request
 would address this sufficiently from my POV.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.dffde525966686c57b799d9c7e086a95%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20566: Store previous string in po files

2014-03-06 Thread Django

#20566: Store previous string in po files
--+
 Reporter:  nijel |Owner:  nobody
 Type:  New feature   |   Status:  closed
Component:  Internationalization  |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * status:  new => closed


Comment:

 Argh, sorry. Forgot to add ticket number in the fixing commit:

 [06efeae598c6dafbe56d2ea323a0dccdd5bf2b8e]

 Added --previous flag to msgmerge command used by makemessages

 Also took the opportunity to slightly refactor gettext options
 so as to ease customization by subclassing the command.
 Thanks Michal Čihař for the report and initial patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.80d91c1ac26e4620eda11cceaecbf8fd%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22218: Deprecate 'prefix' arg to django.conf.urls.patterns

2014-03-06 Thread Django

Comment (by mjtamlyn):

Agreed we should get rid of prefix. I've got some ideas around which
actually involve changing URLconfs and resolving/reversing more
completely. In particular, if we deprecate `prefix` on patterns, then at
least 50% of the use case of `url()` rather than `RegexURLResolver` is
unneeded.

On the topic of beginners, I've heard a number of complaints about the
fact the only built in method of producing urls is regexes. Whilst these
are very powerful, learning the (somewhat obscure) syntax of
`(?P\d+)` and remembering it every time you want to write a URL
is a non-trivial hurdle (and that's before you start on the differing
behaviour of `\w` on Py2/3). Perhaps we should include a solution similar
to https://github.com/oinopion/hurl

Another irritation of mine is `django.conf.urls` vs
`django.core.urlresolvers` - everything should live in `django.urls`.

Also, the syntax for `django.shortcuts.reverse` is much better than that
of `django.core.urlresolvers.reverse` - the `kwargs={}` pattern is
annoying as (generally) you don't use args in a urlpattern.

Other related issues (which may or may not be resolved) are:
- The sea of `handlerXXX` functions (and being able to customise these
dependent on the patterns - API views vs real views)
- The general weirdness of namespacing (currently a powerful solution but
90% of use cases don't need the complexity)
- The ability to decorate views at the patterns level (rather than each
view individually)
- Deprecate models.permalink
- Our "absolute urls" are not absolute
- Reversing by dotted path to view is just a bad idea

I haven't yet decided what the new API should look like, but a significant
advantage of putting it in `django.urls` is all the main public functions
can stay exactly as they are for deprecation and proxy to the new version.
People using `RegexURLResolver` directly might have issues, but that can
likely be worked around as well. This probably needs a django-dev
discussion.

For the sake of clarity, I'm not against fixing this ticket on its own, I
think there's some value in it. However I would like (at some point) to
"fix" url resolving in general. This whole section of the code base (and
its design) are very old, and it might be worth reworking the whole thing,
rather than adding type checking on first arguments for a while.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.1f0e3293e2a9637dce145800290bd91f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[django/django] 06efea: Added --previous flag to msgmerge command used by ...

2014-03-06 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 06efeae598c6dafbe56d2ea323a0dccdd5bf2b8e
  
https://github.com/django/django/commit/06efeae598c6dafbe56d2ea323a0dccdd5bf2b8e
  Author: Claude Paroz 
  Date:   2014-03-06 (Thu, 06 Mar 2014)

  Changed paths:
M django/core/management/commands/makemessages.py
M docs/ref/django-admin.txt
M docs/releases/1.7.txt

  Log Message:
  ---
  Added --previous flag to msgmerge command used by makemessages

Also took the opportunity to slightly refactor gettext options
so as to ease customization by subclassing the command.
Thanks Michal Čihař for the report and initial patch.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/53183e1189743_71c7579d38442a7%40hookshot-fe2-cp1-prd.iad.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22219: muscle care 25 0

2014-03-06 Thread Django

#22219: muscle care 25 0
---+--
 Reporter:  anonymous  |Owner:  nobody
 Type:  New feature|   Status:  closed
Component:  Uncategorized  |  Version:  1.6
 Severity:  Normal |   Resolution:  invalid
 Keywords:  Anabolic RX24  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by anonymous):

 * status:  new => closed
 * needs_docs:   => 0
 * resolution:   => invalid
 * needs_tests:   => 0
 * needs_better_patch:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b6773cd65e7c66da9f4ec3fe7356d338%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22213: Test failure: relative path in resolve_url

2014-03-06 Thread Django

#22213: Test failure: relative path in resolve_url
---+--
 Reporter:  afuna  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  1.6
 Severity:  Normal |   Resolution:  worksforme
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by afuna):

 It looks like it was the leftover .pyc files after all, thanks all, and
 sorry for the noise!


 For further context: `python tests/runtests.py` vs `cd tests; python
 runtests.py` didn't seem to have any bearing.  I originally ran into the
 test failure while running the test suite the normal way, and went to the
 toplevel directory so I could run `git bisect`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.5b8ce6a59ed7313f66c69eb2e44f3481%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22070: Admin index shows mixed lowercase and capitalized app names when using contrib apps and old-style apps

2014-03-06 Thread Django

#22070: Admin index shows mixed lowercase and capitalized app names when using
contrib apps and old-style apps
-+-
 Reporter:  bendavis78   |Owner:
 Type:   |  jenkinsbr2
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin app-loading| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by mjtamlyn):

 I think we should change the strings to be title case. Calling `title()`
 is a dead end - you might want the string to start with a lower case
 letter, eg `"mYk's Gallery"`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.3554d0245da33a6bdb27b807f16a73c4%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22213: Test failure: relative path in resolve_url

2014-03-06 Thread Django

#22213: Test failure: relative path in resolve_url
---+--
 Reporter:  afuna  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  1.6
 Severity:  Normal |   Resolution:  worksforme
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Keryn Knight ):

 * cc: django@… (added)


Comment:

 To provide some more context to my earlier comment, the user I was
 referring to was [http://django-irc-logs.com/2014/feb/20/#1473889
 __machine on IRC], which I think is the Trac user `mrmachine`. Meanwhile
 I've run `python tests/runtests.py resolve_url.tests.ResolveUrlTests` (ie:
 the unrecommended way of running it) on OSX 10.8.4 with Python 2.7.6 via
 Homebrew and am unable to replicate the error reported.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.95a109f2c9f4cda5b1c865d7719b091b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #22219: muscle care 25 0

2014-03-06 Thread Django

#22219: muscle care 25 0
---+---
 Reporter:  anonymous  |  Owner:  nobody
 Type:  New feature| Status:  new
Component:  Uncategorized  |Version:  1.6
 Severity:  Normal |   Keywords:  Anabolic RX24
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+---
 you know it might have some people my sis superficial goal achieving
 muscle is that I let myself down you know now people don't take me
 seriously all Vince says he's going [http://anabolicrx24rev.com/ Anabolic
 RX24]  to do something but he doesn’t do it so one on my core values in
 life is your word is your bond sake say you're going to do something do it
 so I make a lot of goals that Tom force me to live up to that are that %ah
 value of mine and that's you know I don't want to let myself down I don't
 wanna let other people while the back the part 2 we're going to be
 continuing to talk abouthot muscle building a fat burning foods and want
 to use anew analogy today in at a building a wall now our goal into build
 the longest and boxes while possible now the problemis is that as we're
 building this wall there’s people who are trying to break it down at the
 same rate that we're trying tobuild it up now that can meet us at the
 exact same point so basically we're trying to build this wall which is the
 equivalent of our muscles and there's people trying to break built break
 that wall down which is the equivalent are our workouts so to make that
 while bigger we can think up just trying to make it faster than the people
 who are breaking it down or we can think of things to do to prevent those
 people from stripping it down so that's going to prevent overall growth
 does that make sense so in today's video we are going to look at hot
 muscle building foods from outmuscle breakdown standpoint foods that
 prevent muscle breakdown such as healthy fats fruits and vegetables ready
 get started: next let's highlight some fruits I like to get the ball cover
 my own fruits from raspberries blackberries Rob blueberries and I
 primarily because they're loaded in antioxidants they help reduce
 inflammation your body promote recovery and they just taste good too so
 they'renice mix with your shakes I also need a lot about Apple's apples
 are loaded with vitamins and minerals also high in fiber they're
 veryconvenient so it's a great pre-workout meal as well bananas are
 excellent for pre workout meals are loaded in potassium is you know
 passing pools water into your muscles and up keeping yourmuscles fall for
 cell volume is important for muscle growth they're also very convenient
 now if youthink that bananas have a lot of the posse minimum are avocados
 how pockets for even I think three times more than banana so avocados arm
 is arm is a is probably themost powerful through all time and if you need
 at least one he’s a day you're missing out big time I had slowed in time
 to make a minerals that are responsible for cream make a mass on your body
 and their also are loaded with healthy fats so on if you know having at
 least one of these guys a day %uh start right away and they actually
 tastes really good as well across it over to the fax now and Dom we're
 looking at peanut butter specifically natural peanut butter and the reason
 that this is one the most muscle friendly foods at all times because its
 high-end monounsaturated fat not unhealthy fasts this is an excellent
 muscle-building food it’s really good to balk you up and I it's easy to
 consume and againsince its high mono-unsaturated fat you don't have to
 worry about that fat content it's also got a bit protein in there as well
 next dissolve oil 1 most powerful formsof healthy fat in existence all the
 oil has even more monounsaturated fat that an avocado does and
 http://anabolicrx24rev.com/

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.3b11faa85ea38ff75f4ab9a3ea3cc5a4%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

51 matches

Mail list logo