date:20141007

Re: [Django] #23589: Django 1.7 filter Q m2m bug

2014-10-07 Thread Django

#23589: Django 1.7 filter Q m2m bug
-+-
 Reporter:  Grafumbly|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:  invalid
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by akaariai):

 Yes, this was a bug in 1.6. This is an unfortunate bug, as you might have
 gotten correct results. That is, the query worked, but didn't match the
 documentation. The query produced results for
 
`.filter(Q(relatedobject__someparam=True)).filter(~Q(relatedobject__someparam=False))`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d327aa7a9be58656c40f992fd5dbbb31%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

2014-10-07 Thread Django

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Description changed by browniebroke:

Old description:

> There's quite a lot of unit tests that have been rewritten 1:1 from
> doctests. These tests tend to verify all aspects of a certain feature at
> once, they modify the state of the database throughout the whole test and
> by the end of the test no one really knows what the database state is
> supposed to be.
>
> For example,
> `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
> walks through most of the features supported by `GenericForeignKeys`, it
> is 130 lines long and in case the last assertion fails, you'll have to
> spend ridiculous amounts of time figuring out what happened.
>
> A likely incomplete list of similar tests:[[BR]]
> `modeltests.basic.ModelTest.test_lookup`[[BR]]
> `modeltests.basic.ModelTest.test_object_creation`[[BR]]
> ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
> `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
> `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
> `modeltests.defer.DeferTests.test_defer`[[BR]]
> `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
> `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
> `modeltests.files.FileStorageTests.test_files`[[BR]]
> ~~modeltests.get_or_create.GetOrCreateTests.test_get_or_create~~[[BR]]
> ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
> `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
> ~~modeltests.m2m_through.M2mThroughTests~~[[BR]]
> `modeltests.m2m_through_regress.M2MThroughTestCase`[[BR]]
> `modeltests.model_formsets.ModelFormsetTests`[[BR]]
> `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
> more than 500 lines!)[[BR]]
> `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
> `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
> `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
> `modeltests.signals.SignalTests.test_basic`
>
> I only went through modeltests/*/tests.py; I might have overlooked a few
> tests.
>
> This ticket is meant to track all of them; each time a test is updated,
> we can strike it out in the list above and once there is no item left, we
> can close this. The point is to make the test suite help developers as
> much as possible.

New description:

 There's quite a lot of unit tests that have been rewritten 1:1 from
 doctests. These tests tend to verify all aspects of a certain feature at
 once, they modify the state of the database throughout the whole test and
 by the end of the test no one really knows what the database state is
 supposed to be.

 For example,
 `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
 walks through most of the features supported by `GenericForeignKeys`, it
 is 130 lines long and in case the last assertion fails, you'll have to
 spend ridiculous amounts of time figuring out what happened.

 A likely incomplete list of similar tests:[[BR]]
 ~~modeltests.basic.ModelTest.test_lookup~~[[BR]]
 `modeltests.basic.ModelTest.test_object_creation`[[BR]]
 ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
 `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
 `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
 `modeltests.defer.DeferTests.test_defer`[[BR]]
 `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
 `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
 `modeltests.files.FileStorageTests.test_files`[[BR]]
 ~~modeltests.get_or_create.GetOrCreateTests.test_get_or_create~~[[BR]]
 ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
 `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
 ~~modeltests.m2m_through.M2mThroughTests~~[[BR]]
 `modeltests.m2m_through_regress.M2MThroughTestCase`[[BR]]
 `modeltests.model_formsets.ModelFormsetTests`[[BR]]
 `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
 more than 500 lines!)[[BR]]
 `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
 `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
 `modeltests.order_with_respect_to.OrderWithRespectTo

Re: [Django] #23616: 'GenericRel' object has no attribute 'get_related_field'

2014-10-07 Thread Django

#23616: 'GenericRel' object has no attribute 'get_related_field'
-+-
 Reporter:  ranjur   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  1.7
  contrib.contenttypes   |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  GenericRel, django   |  Unreviewed
  1.7, admin, get_related_field, |  Needs documentation:  0
  GenericRelation|  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by ranjur):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Old description:

> I have a model:
> #models.py
> class TaggedItem(models.Model):
> tag = models.SlugField()
> content_type = models.ForeignKey(ContentType)
> object_id = models.PositiveIntegerField()
> content_object = GenericForeignKey('content_type', 'object_id')
>
> def __str__(self):  # __unicode__ on Python 2
> return self.tag
>
> And model with GenericRelation
> class Bookmark(models.Model):
> url = models.URLField()
> tags = GenericRelation(TaggedItem)
>

> #admin.py
> class BookmarkAdmin(admin.ModelAdmin):
> list_filter = ('tags__tag')
>
> admin.site.register(models.Bookmark, BookmarkAdmin)
>
> It will list all the `tag` in the filter, but when I try to filter it
> throws error `'GenericRel' object has no attribute 'get_related_field'`
>
> Full stack:
> {{{
> AttributeError at /admin/app/bookmark
> 'GenericRel' object has no attribute 'get_related_field'
> Request Method: GET
> Request URL:
> http://127.0.0.1:8000/admin/app/bookmark/?q=&tags__tag__id__exact=1
> Django Version: 1.7
> Exception Type: AttributeError
> Exception Value:
> 'GenericRel' object has no attribute 'get_related_field'
> Exception Location: /home/user/virtual/test/local/lib/python2.7/site-
> packages/django/contrib/admin/options.py in lookup_allowed, line 416
> Python Executable:  /home/user/virtual/test/bin/python
> Python Version: 2.7.6
> Python Path:
> ['/home/user/projects/ptest',
>  '/home/user/virtual/test/local/lib/python2.7/site-
> packages/Pillow-2.5.1-py2.7-linux-x86_64.egg',
>  '/home/user/virtual/test/src/cmsplugin-bootstrap-carousel',
>  '/home/user/virtual/test/src/cmsplugin-contact',
>  '/home/user/virtual/test/src/django-faq',
>  '/home/user/virtual/test/src/python-varnish',
>  '/home/user/virtual/test/src/cmsplugin-text-ng',
>  '/home/user/virtual/test/src/django-balancer',
>  '/home/user/virtual/test/src/django-nose',
>  '/home/user/virtual/test/lib/python2.7',
>  '/home/user/virtual/test/lib/python2.7/plat-x86_64-linux-gnu',
>  '/home/user/virtual/test/lib/python2.7/lib-tk',
>  '/home/user/virtual/test/lib/python2.7/lib-old',
>  '/home/user/virtual/test/lib/python2.7/lib-dynload',
>  '/usr/lib/python2.7',
>  '/usr/lib/python2.7/plat-x86_64-linux-gnu',
>  '/usr/lib/python2.7/lib-tk',
>  '/home/user/virtual/test/local/lib/python2.7/site-packages',
>  '/home/user/virtual/test/local/lib/python2.7/site-packages/PIL',
>  '/home/user/virtual/test/local/lib/python2.7/site-
> packages/newrelic-2.28.0.26',
>  '/home/user/projects/y1/test']
> Server time:Wed, 8 Oct 2014 13:28:38 +0800
> Traceback Switch to copy-and-paste view
>
> /home/user/virtual/test/local/lib/python2.7/site-
> packages/django/core/handlers/base.py in get_response
> response = wrapped_callback(request, *callback_args,
> **callback_kwargs) ...
> ▶ Local vars
> /home/user/virtual/test/local/lib/python2.7/site-
> packages/django/contrib/admin/options.py in wrapper
> return self.admin_site.admin_view(view)(*args, **kwargs)
> ...
> ▶ Local vars
> /home/user/virtual/test/local/lib/python2.7/site-
> packages/django/utils/decorators.py in _wrapped_view
> response = view_func(request, *args, **kwargs) ...
> ▶ Local vars
> /home/user/virtual/test/local/lib/python2.7/site-
> packages/django/views/decorators/cache.py in _wrapped_view_func
> response = view_func(request, *args, **kwargs) ...
> ▶ Local vars
> /home/user/virtual/test/local/lib/python2.7/site-
> packages/django/contrib/admin/sites.py in inner
> return view(request, *args, **kwargs) ...
> ▶ Local vars
> /home/user/virtual/test/local/lib/python2.7/site-
> packages/django/utils/decorators.py in _wrapper
> return bound_func(*args, **kwargs) ...
> ▶ Local vars
> /home/user/virtual/test/local/lib/python2.7/site-
> packages/django/utils/decorators.py in _wrapped_view
> response = view_func(request, *args, **kwargs) ...
> ▶ Local vars
> /home/user/virtual/test/loc

[Django] #23616: 'GenericRel' object has no attribute 'get_related_field'

2014-10-07 Thread Django

#23616: 'GenericRel' object has no attribute 'get_related_field'
-+-
 Reporter:  ranjur   |  Owner:  nobody
 Type:  Bug  | Status:  new
Component:   |Version:  1.7
  contrib.contenttypes   |   Keywords:  GenericRel, django 1.7,
 Severity:  Normal   |  admin, get_related_field,
 Triage Stage:  Unreviewed   |  GenericRelation
Easy pickings:  0|  Has patch:  0
 |  UI/UX:  0
-+-
 I have a model:
 #models.py
 class TaggedItem(models.Model):
 tag = models.SlugField()
 content_type = models.ForeignKey(ContentType)
 object_id = models.PositiveIntegerField()
 content_object = GenericForeignKey('content_type', 'object_id')

 def __str__(self):  # __unicode__ on Python 2
 return self.tag

 And model with GenericRelation
 class Bookmark(models.Model):
 url = models.URLField()
 tags = GenericRelation(TaggedItem)


 #admin.py
 class BookmarkAdmin(admin.ModelAdmin):
 list_filter = ('tags__tag')

 admin.site.register(models.Bookmark, BookmarkAdmin)

 It will list all the `tag` in the filter, but when I try to filter it
 throws error `'GenericRel' object has no attribute 'get_related_field'`

 Full stack:
 {{{
 AttributeError at /admin/app/bookmark
 'GenericRel' object has no attribute 'get_related_field'
 Request Method: GET
 Request URL:
 http://127.0.0.1:8000/admin/app/bookmark/?q=&tags__tag__id__exact=1
 Django Version: 1.7
 Exception Type: AttributeError
 Exception Value:
 'GenericRel' object has no attribute 'get_related_field'
 Exception Location: /home/user/virtual/test/local/lib/python2.7/site-
 packages/django/contrib/admin/options.py in lookup_allowed, line 416
 Python Executable:  /home/user/virtual/test/bin/python
 Python Version: 2.7.6
 Python Path:
 ['/home/user/projects/ptest',
  '/home/user/virtual/test/local/lib/python2.7/site-
 packages/Pillow-2.5.1-py2.7-linux-x86_64.egg',
  '/home/user/virtual/test/src/cmsplugin-bootstrap-carousel',
  '/home/user/virtual/test/src/cmsplugin-contact',
  '/home/user/virtual/test/src/django-faq',
  '/home/user/virtual/test/src/python-varnish',
  '/home/user/virtual/test/src/cmsplugin-text-ng',
  '/home/user/virtual/test/src/django-balancer',
  '/home/user/virtual/test/src/django-nose',
  '/home/user/virtual/test/lib/python2.7',
  '/home/user/virtual/test/lib/python2.7/plat-x86_64-linux-gnu',
  '/home/user/virtual/test/lib/python2.7/lib-tk',
  '/home/user/virtual/test/lib/python2.7/lib-old',
  '/home/user/virtual/test/lib/python2.7/lib-dynload',
  '/usr/lib/python2.7',
  '/usr/lib/python2.7/plat-x86_64-linux-gnu',
  '/usr/lib/python2.7/lib-tk',
  '/home/user/virtual/test/local/lib/python2.7/site-packages',
  '/home/user/virtual/test/local/lib/python2.7/site-packages/PIL',
  '/home/user/virtual/test/local/lib/python2.7/site-
 packages/newrelic-2.28.0.26',
  '/home/user/projects/y1/test']
 Server time:Wed, 8 Oct 2014 13:28:38 +0800
 Traceback Switch to copy-and-paste view

 /home/user/virtual/test/local/lib/python2.7/site-
 packages/django/core/handlers/base.py in get_response
 response = wrapped_callback(request, *callback_args,
 **callback_kwargs) ...
 ▶ Local vars
 /home/user/virtual/test/local/lib/python2.7/site-
 packages/django/contrib/admin/options.py in wrapper
 return self.admin_site.admin_view(view)(*args, **kwargs)
 ...
 ▶ Local vars
 /home/user/virtual/test/local/lib/python2.7/site-
 packages/django/utils/decorators.py in _wrapped_view
 response = view_func(request, *args, **kwargs) ...
 ▶ Local vars
 /home/user/virtual/test/local/lib/python2.7/site-
 packages/django/views/decorators/cache.py in _wrapped_view_func
 response = view_func(request, *args, **kwargs) ...
 ▶ Local vars
 /home/user/virtual/test/local/lib/python2.7/site-
 packages/django/contrib/admin/sites.py in inner
 return view(request, *args, **kwargs) ...
 ▶ Local vars
 /home/user/virtual/test/local/lib/python2.7/site-
 packages/django/utils/decorators.py in _wrapper
 return bound_func(*args, **kwargs) ...
 ▶ Local vars
 /home/user/virtual/test/local/lib/python2.7/site-
 packages/django/utils/decorators.py in _wrapped_view
 response = view_func(request, *args, **kwargs) ...
 ▶ Local vars
 /home/user/virtual/test/local/lib/python2.7/site-
 packages/django/utils/decorators.py in bound_func
 return func.__get__(self, type(self))(*args2, **kwargs2)
 ...
 ▶ Local vars
 /home/user/virtual/test/local/lib/python2.7/site-
 packages/django/contrib/admin/options.py in changelist_view
 self.list_max_show_all, self.list_editable, self) ...
 ▶ Local vars
 /home/user/virtual/test/local/lib/python2.7/site-

Re: [Django] #23615: Naming a model Check causes Django's check framework to fail with an acception

2014-10-07 Thread Django

#23615: Naming a model Check causes Django's check framework to fail with an
acception
-+-
 Reporter:  bramd|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (System |  Version:  1.7
  checks)|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by collinanderson):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 I can't reproduce this. Is the Check model related to another model? Could
 you post a traceback?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.2468a22cb82c7687a061dd50a75a3bb5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23497: Admin System Checks do not run for custom AdminSite sites

2014-10-07 Thread Django

#23497: Admin System Checks do not run for custom AdminSite sites
--+
 Reporter:  amosson   |Owner:  amosson
 Type:  Bug   |   Status:  assigned
Component:  Core (System checks)  |  Version:  1.7
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by amosson):

 * owner:  nobody => amosson
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.15630f65771f2909bbc71e1146c26de4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23614: Altering unique_together sometimes missing deleted fields

2014-10-07 Thread Django

#23614: Altering unique_together sometimes missing deleted fields
+--
 Reporter:  Naddiseo|Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Naddiseo):

 * cc: github@… (added)
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.39ddc7af0edf48b850e77b29616db342%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #23615: Naming a model Check causes Django's check framework to fail with an acception

2014-10-07 Thread Django

#23615: Naming a model Check causes Django's check framework to fail with an
acception
--+
 Reporter:  bramd |  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  Core (System checks)  |Version:  1.7
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 This causes an SingleRelatedObjectDescriptor is not callable error.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.cf49ff4fd777b39e7790e7efd2dbe3c3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23613: django.utils.checksums is undocumented and unused

2014-10-07 Thread Django

#23613: django.utils.checksums is undocumented and unused
--+
 Reporter:  aaugustin |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Utilities |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * stage:  Unreviewed => Accepted


Comment:

 Looks good to me. We need a PR to update https://github.com/django/django-
 localflavor and then go through the deprecation in Django I suppose.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ee3a2fd8fa37874c103324aeed5dc7e0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[django/django] 0eccf8: Fixed misplaced test case.

2014-10-07 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 0eccf8fbea143234c9af3d290d41d5c315e714f9
  
https://github.com/django/django/commit/0eccf8fbea143234c9af3d290d41d5c315e714f9
  Author: Loic Bistuer 
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
M tests/get_or_create/tests.py

  Log Message:
  ---
  Fixed misplaced test case.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/5434654daead_66973f9abe0bf2a05008e%40hookshot-fe3-cp1-prd.iad.github.net.mail.
For more options, visit https://groups.google.com/d/optout.

[Django] #23614: Altering unique_together sometimes missing deleted fields

2014-10-07 Thread Django

#23614: Altering unique_together sometimes missing deleted fields
+
 Reporter:  Naddiseo|  Owner:  nobody
 Type:  Bug | Status:  new
Component:  Migrations  |Version:  1.7
 Severity:  Normal  |   Keywords:
 Triage Stage:  Unreviewed  |  Has patch:  0
Easy pickings:  0   |  UI/UX:  0
+
 Steps to reproduce:
 1. Create an App `spam`
 2. Create two models `spam.Eggs` and `spam.Spam`

 {{{
 #!python

 class Eggs(models.Model):
 pass


 class Spam(models.Model):
 class Meta:
 unique_together = (
('a', 'b'),
 )

 a = models.ForeignKey(Eggs)
 b = models.CharField(max_length=10)
 }}}

 3. Make migrations
 4. Create an App `ham`
 5. Create model `ham.Ham`

 {{{
 #!python
 class Ham(models.Model): pass
 }}}
 6. Add foreignkey to `Spam.Spam`: `c = models.ForeignKey('ham.Ham')`
 7. Make Migrations
 8. Delete field `Spam.a`
 9. Change `Spam.unique_together` to `('c', 'b')`
 10. Make Migrations
 11. Run migrations.

 Output:

 > django.db.models.fields.FieldDoesNotExist: Spam has no field named u'a'


 I think this might be related to issue #23505 since that is what I was
 actually trying to reproduce.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.791782896200d77c4e06329f068ac920%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[django/django] fa4b64: [1.7.x] Fixed #23611 -- update_or_create failing f...

2014-10-07 Thread GitHub

  Branch: refs/heads/stable/1.7.x
  Home:   https://github.com/django/django
  Commit: fa4b6482df08d308fe88044b8c8bf981c6225fb8
  
https://github.com/django/django/commit/fa4b6482df08d308fe88044b8c8bf981c6225fb8
  Author: André Ericson 
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
M django/contrib/contenttypes/fields.py
M django/db/models/fields/related.py
M docs/releases/1.7.1.txt
M tests/generic_relations/tests.py
M tests/get_or_create/models.py
M tests/get_or_create/tests.py

  Log Message:
  ---
  [1.7.x] Fixed #23611 -- update_or_create failing from a related manager

Added update_or_create to RelatedManager, ManyRelatedManager and
GenericRelatedObjectManager.
Added missing get_or_create to GenericRelatedObjectManager.

Conflicts:
tests/generic_relations/tests.py
tests/get_or_create/tests.py

Backport of ed37f7e979 from master


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/5434623c78429_66203fd9e83652c0935b4%40hookshot-fe1-cp1-prd.iad.github.net.mail.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23611: update_or_create doesn't retain related manager reference

2014-10-07 Thread Django

#23611: update_or_create doesn't retain related manager reference
-+-
 Reporter:  ryanhiebert  |Owner:  aericson
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by Loic Bistuer ):

 In [changeset:"fa4b6482df08d308fe88044b8c8bf981c6225fb8"]:
 {{{
 #!CommitTicketReference repository=""
 revision="fa4b6482df08d308fe88044b8c8bf981c6225fb8"
 [1.7.x] Fixed #23611 -- update_or_create failing from a related manager

 Added update_or_create to RelatedManager, ManyRelatedManager and
 GenericRelatedObjectManager.
 Added missing get_or_create to GenericRelatedObjectManager.

 Conflicts:
 tests/generic_relations/tests.py
 tests/get_or_create/tests.py

 Backport of ed37f7e979 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.8b2d3a9bc452241a1ad3d69d4e1c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[django/django] 8a4e9b: Add myself to AUTHORS and register authorship of e...

2014-10-07 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 8a4e9be3e561c3532bc06d63491736b075a35b2a
  
https://github.com/django/django/commit/8a4e9be3e561c3532bc06d63491736b075a35b2a
  Author: André Ericson 
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
M AUTHORS

  Log Message:
  ---
  Add myself to AUTHORS and register authorship of ed37f7e

This commit is a record that ed37f7e was my contribution.
Thanks Loic Bistuer for reviewing it.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/54345b4d121e9_684d3ffb805172bc92672%40hookshot-fe1-cp1-prd.iad.github.net.mail.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23611: update_or_create doesn't retain related manager reference

2014-10-07 Thread Django

#23611: update_or_create doesn't retain related manager reference
-+-
 Reporter:  ryanhiebert  |Owner:  aericson
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by Loic Bistuer ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"ed37f7e979186c99a6f351c289eb486461601d80"]:
 {{{
 #!CommitTicketReference repository=""
 revision="ed37f7e979186c99a6f351c289eb486461601d80"
 Fixed #23611 -- update_or_create failing from a related manager

 Added update_or_create to RelatedManager, ManyRelatedManager and
 GenericRelatedObjectManager.
 Added missing get_or_create to GenericRelatedObjectManager.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.ae33ba3209422e05b6ead58f62ae2dd8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[django/django] ed37f7: Fixed #23611 -- update_or_create failing from a re...

2014-10-07 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: ed37f7e979186c99a6f351c289eb486461601d80
  
https://github.com/django/django/commit/ed37f7e979186c99a6f351c289eb486461601d80
  Author: Loic Bistuer 
  Date:   2014-10-08 (Wed, 08 Oct 2014)

  Changed paths:
M django/contrib/contenttypes/fields.py
M django/db/models/fields/related.py
M docs/releases/1.7.1.txt
M tests/generic_relations/tests.py
M tests/get_or_create/tests.py

  Log Message:
  ---
  Fixed #23611 -- update_or_create failing from a related manager

Added update_or_create to RelatedManager, ManyRelatedManager and
GenericRelatedObjectManager.
Added missing get_or_create to GenericRelatedObjectManager.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/54344db9a9f89_68173fada24152a0113957%40hookshot-fe1-cp1-prd.iad.github.net.mail.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23449: Saving models with unsaved ForeignKey

2014-10-07 Thread Django

#23449: Saving models with unsaved ForeignKey
-+-
 Reporter:  pjrobertson  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by coder9042):

 From [https://code.djangoproject.com/ticket/10811 #10811]
 '..prefer failing early and loudly, by raising an exception when an
 unsaved object is assigned to a related field...'

 - First, it does not matter if `null=True` is set or not, if user is
 setting an unsaved object to a FK, its wrong so the user must be told that
 what he is doing is wrong.
 - Secondly, I don't think that bulk_create problem occurs because of that
 in the example you have given, its because `null=True` is not set so a FK
 value is required there and you haven't specified one.(correct me if I am
 wrong, p.s. the check for id runs only when FK object is not None.)
 - Thirdly, it is consistent with
 
[https://code.djangoproject.com/changeset/3190abcd75b1fcd660353da4001885ef82cbc596/
 3190abc] — a fix for the same problem for reverse one-to-one relations.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.92abfc9c27821050d045750064e498b2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #23613: django.utils.checksums is undocumented and unused

2014-10-07 Thread Django

#23613: django.utils.checksums is undocumented and unused
+
   Reporter:  aaugustin |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Utilities |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 This module provides a single function that implements the Luhn algorithm.
 It isn't documented and it isn't imported except in its own tests.

 I suspect it was used by django.contrib.localflavor and left behind when
 that application was split from Django. It should be moved to django-
 localflavor, shouldn't it?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.3b496d60eb3fe06dcde824c1188ebd81%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23611: update_or_create doesn't retain related manager reference

2014-10-07 Thread Django

#23611: update_or_create doesn't retain related manager reference
-+-
 Reporter:  ryanhiebert  |Owner:  aericson
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by aericson):

 Pull request updated.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.4e70a749581f851fc7a063007fdf0250%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23612: Relative fixture paths not working on Windows 8.1

2014-10-07 Thread Django

#23612: Relative fixture paths not working on Windows 8.1
---+
 Reporter:  alsoicode  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  windows fixtures   | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by collinanderson):

 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.fdc239b4d6f49d522843617616e45133%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23612: Relative fixture paths not working on Windows 8.1

2014-10-07 Thread Django

#23612: Relative fixture paths not working on Windows 8.1
---+
 Reporter:  alsoicode  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  windows fixtures   | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by alsoicode):

 I submitted a Pull Request with a fix:
 https://github.com/django/django/pull/3324

 Running the test suite yields no failures.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4b4585fc1e4e38339d321419d79d57fd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23612: Relative fixture paths not working on Windows 8.1

2014-10-07 Thread Django

#23612: Relative fixture paths not working on Windows 8.1
---+
 Reporter:  alsoicode  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  windows fixtures   | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by charettes):

 * version:  1.7 => master
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9703ffed22c51f13e899bec241be4b20%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23611: update_or_create doesn't retain related manager reference

2014-10-07 Thread Django

#23611: update_or_create doesn't retain related manager reference
-+-
 Reporter:  ryanhiebert  |Owner:  aericson
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by aericson):

 Replying to [comment:12 loic]:
 > It's missing from `GenericRelatedObjectManager`; note that
 `GenericRelatedObjectManager.get_or_create()` is missing too.
 >
 > Since it's a bug in a new feature, I think it's worthy of a backport.

 I'll be adding them to GenericRelatedObjectManager. Thanks

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.08c7d36c7a33076ab190b4bf160d62d1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23611: update_or_create doesn't retain related manager reference

2014-10-07 Thread Django

#23611: update_or_create doesn't retain related manager reference
-+-
 Reporter:  ryanhiebert  |Owner:  aericson
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by loic):

 * cc: loic (added)


Comment:

 It's missing from `GenericRelatedObjectManager`; note that
 `GenericRelatedObjectManager.get_or_create()` is missing too.

 Since it's a bug in a new feature, I think it's worthy of a backport.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.822c2085190c2e66c2cac45b09bb9322%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23612: Relative fixture paths not working on Windows 8.1

2014-10-07 Thread Django

#23612: Relative fixture paths not working on Windows 8.1
---+--
 Reporter:  alsoicode  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  1.7
 Severity:  Normal |   Resolution:
 Keywords:  windows fixtures   | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by alsoicode):

 How about changing line 183 to:


 {{{
 if os.path.sep in os.path.normpath(fixture_name):
 }}}

 That way it is still based on the path separator for the os. Paths to
 fixtures can still be written using `/` so they are consistent with other
 paths in Django like template and static file directories, where the
 documentation specifically states to use forward slashes.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c69af77cadac216f71251bc187cde277%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21794: No warning should be raised when defining an abstract model with no app_label

2014-10-07 Thread Django

#21794: No warning should be raised when defining an abstract model with no
app_label
-+-
 Reporter:  charettes|Owner:  aaugustin
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:  app-loading  |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timgraham):

 * stage:  Ready for checkin => Accepted


Comment:

 Loic's
 
[https://github.com/django/django/commit/2f65b8e14c03a6b43c11d5de791b8d4d91721777#commitcomment-5799847
 comment on the commit] also hasn't been addressed.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.053ab41a674d4d8fedd47dcb14fc255b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23522: reverse() should return a text string, not a byte string

2014-10-07 Thread Django

#23522: reverse() should return a text string, not a byte string
-+
 Reporter:  jdufresne|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (URLs)  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c1ef234e310fb984ced37eac8c8b90f5b6155e5f"]:
 {{{
 #!CommitTicketReference repository=""
 revision="c1ef234e310fb984ced37eac8c8b90f5b6155e5f"
 Fixed #23522 -- Changed reverse() to return a Unicode string; not bytes
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ac2ec9124d72738a8dffabf0b42fded4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[django/django] c1ef23: Fixed #23522 -- Changed reverse() to return a Unic...

2014-10-07 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: c1ef234e310fb984ced37eac8c8b90f5b6155e5f
  
https://github.com/django/django/commit/c1ef234e310fb984ced37eac8c8b90f5b6155e5f
  Author: Jon Dufresne 
  Date:   2014-10-07 (Tue, 07 Oct 2014)

  Changed paths:
M django/core/urlresolvers.py
M docs/releases/1.8.txt
M tests/urlpatterns_reverse/tests.py

  Log Message:
  ---
  Fixed #23522 -- Changed reverse() to return a Unicode string; not bytes


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/54341dc4baaad_2e013fb9c698d2c099255%40hookshot-fe4-cp1-prd.iad.github.net.mail.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23611: update_or_create doesn't retain related manager reference

2014-10-07 Thread Django

#23611: update_or_create doesn't retain related manager reference
-+-
 Reporter:  ryanhiebert  |Owner:  aericson
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by collinanderson):

 * stage:  Unreviewed => Accepted


Comment:

 Ahh. I forgot update_or_create was new. Not sure on backporting, but, in
 any case the pull request is correctly against master.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.94ac57c7bc78012670581b5c984fee1d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23589: Django 1.7 filter Q m2m bug

2014-10-07 Thread Django

#23589: Django 1.7 filter Q m2m bug
-+-
 Reporter:  Grafumbly|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:  invalid
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Grafumbly):

 The documentation hasn't changed but the behavior has. If this is working
 as intended in 1.7, is it a bug in 1.6 or does the documentation just need
 to be updated?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d1678d0ba2e9dddbeb6449198154157b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23611: update_or_create doesn't retain related manager reference

2014-10-07 Thread Django

#23611: update_or_create doesn't retain related manager reference
-+-
 Reporter:  ryanhiebert  |Owner:  aericson
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by aericson):

 I'm not exactly sure how the process works neither.

 Should I make a merge request against {{{ stable/1.7.x}}}?
 I believe the fix should apply to that aswell.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.822650fa01ed9fff32ac850ef81b0685%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23611: update_or_create doesn't retain related manager reference

2014-10-07 Thread Django

#23611: update_or_create doesn't retain related manager reference
-+-
 Reporter:  ryanhiebert  |Owner:  aericson
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by ryanhiebert):

 {{{update_or_create}}} was added in 1.7, but the behavior fixed in this
 patch has precedent in 1.6 with {{{get}}}, {{{get_or_create}}},
 {{{create}}}, and others.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.01cc6bc07e892378ed494d2339ddc4a8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #8165: When using can_order=True on formset, ordered_forms is not avaible when formset.is_valid() is false

2014-10-07 Thread Django

#8165: When using can_order=True on formset, ordered_forms is not avaible when
formset.is_valid() is false
-+-
 Reporter:  James Chua   |Owner:  zain
|   Status:  new
 Type:  New feature  |  Version:  master
Component:  Forms|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  formsets |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by timgraham):

 #21592 is a duplicate which has an incomplete patch and some discussion.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/090.db10a5b84e377749449b40060b687f81%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23611: update_or_create doesn't retain related manager reference

2014-10-07 Thread Django

#23611: update_or_create doesn't retain related manager reference
-+-
 Reporter:  ryanhiebert  |Owner:  aericson
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by aericson):

 I believe update_or_create was added at 1.7, wasn't it?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.c688fbf2c6642aa7c329fe2855b6dbce%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21592: formset.ordered_forms should try to return ordered forms if is_valid() is false

2014-10-07 Thread Django

#21592: formset.ordered_forms should try to return ordered forms if is_valid() 
is
false
-+-
 Reporter:  nickname123  |Owner:
 Type:  New feature  |   Status:  closed
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Closing as duplicate of #8165.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.0758f6691d08528124b8214e931e0bfa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[django/django] d1e87a: Refactored model lookup tests; refs #18586.

2014-10-07 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: d1e87aebf70dd035c98a0b0f0162c0a2c398598c
  
https://github.com/django/django/commit/d1e87aebf70dd035c98a0b0f0162c0a2c398598c
  Author: Browniebroke 
  Date:   2014-10-07 (Tue, 07 Oct 2014)

  Changed paths:
M AUTHORS
M tests/basic/tests.py

  Log Message:
  ---
  Refactored model lookup tests; refs #18586.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/54340f32aa857_759a3fc7f084329c30532%40hookshot-fe1-cp1-prd.iad.github.net.mail.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

2014-10-07 Thread Django

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"d1e87aebf70dd035c98a0b0f0162c0a2c398598c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="d1e87aebf70dd035c98a0b0f0162c0a2c398598c"
 Refactored model lookup tests; refs #18586.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.09066d3232c15a5e76c4c5f03639b355%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23612: Relative fixture paths not working on Windows 8.1

2014-10-07 Thread Django

#23612: Relative fixture paths not working on Windows 8.1
---+--
 Reporter:  alsoicode  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  1.7
 Severity:  Normal |   Resolution:
 Keywords:  windows fixtures   | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by alsoicode):

 I think the problem is with line 183 in loaddata.py. It's checking for
 `os.path.sep` which on Windows is `\`. Aren't we always supposed to use
 forward slashes `/` with Python on Windows? Changing `os.path.sep` to `/`
 allows the relative paths to work.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.abe929663a44457b5256d3a79edaeb5f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23611: update_or_create doesn't retain related manager reference

2014-10-07 Thread Django

#23611: update_or_create doesn't retain related manager reference
-+-
 Reporter:  ryanhiebert  |Owner:  aericson
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by collinanderson):

 It qualifies for a backport if only if 1.7 is behaving differently than
 version 1.6. What happens in version 1.6?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.94fab15f7bbe3fc409c5ac3d59d86c95%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23605: ORM neglects to use aliases it has set up when certain multiple subqueries are used

2014-10-07 Thread Django

#23605: ORM neglects to use aliases it has set up when certain multiple 
subqueries
are used
-+-
 Reporter:  ris  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  orm subquery alias   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by ris):

 (hooray! thank you)

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.b005eb4bd1e63328ff434c7f2aef7b01%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23612: Relative fixture paths not working on Windows 8.1

2014-10-07 Thread Django

Comment (by alsoicode):

That is correct. I took a look at the directories returned by
`fixture_dirs()` in `core/management/loaddata.py` and the paths are
correct, but it doesn't seem to be concatenating the paths correctly if I
specify a directory structure plus the file name.

The paths returned by `fixture_dirs()` are in: `C:\\path\\path\\path`
format.

Leaving the directory structure off entirely works as it picks up the
`products/fixtures/` directory, but you'd most likely run into issues if
there were fixtures with duplicate names.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.e3677cf7665c3cd74a7bac9d58876c77%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #5986: Custom form field order (was: Custom field order in newforms)

2014-10-07 Thread Django

#5986: Custom form field order
-+-
 Reporter:  emes |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  field order weight   | Triage Stage:
  form newforms  |  Unreviewed
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by collinanderson):

 * stage:  Design decision needed => Unreviewed
 * type:  Uncategorized => New feature


Comment:

 I haven't tried this myself, but would a syntax like this work?

 {{{
 class UserProfileForm(UserForm):
 first_name = forms.CharField(max_length=30, weight=-1)
 last_name = forms.CharField(max_length=30, weight=-1)
 username = UserForm.base_fields['username']
 password = UserForm.base_fields['password']
 password2 = UserForm.base_fields['password2']
 jabber_id = forms.EmailField()
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.959cd750ad109149e8a1120376e183b3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23612: Relative fixture paths not working on Windows 8.1

2014-10-07 Thread Django

#23612: Relative fixture paths not working on Windows 8.1
---+--
 Reporter:  alsoicode  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  1.7
 Severity:  Normal |   Resolution:
 Keywords:  windows fixtures   | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by charettes):

 * needs_docs:   => 0
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Old description:

> I have a Django 1.6.6 project that is not loading fixtures from relative
> paths using Python 2.7.8 on Windows 8.1. Works just fine in Linux.
>
> Example Test Case:
>
> # cart/tests.py
>
> class CartTestBase(TestCase):
> fixtures = ['products/fixtures/product_categories.json',
> 'products/fixtures/brands.json',
> 'products/fixtures/products.json']
>
> Which fits into a directory structure of:
>
> ecomm_app/
> cart/
> __init__.py
> models.py
> tests.py
> . . .
>
> products/
> fixtures/
> products/fixtures/product_categories.json
> products/fixtures/brands.json
> products/fixtures/products.json
> __init__.py
> models.py
> . . .
>
> The specific error message is:
>
> UserWarning: No fixture named 'products/fixtures/products' found.
> warnings.warn("No fixture named '%s' found." % fixture_name)
>
> The corresponding app modules are listed in `INSTALLED_APPS` and work
> fine otherwise. Specifying an absolute path does work, but obviously
> isn't cross-platform. Specifying a root-relative path does not work,
> e.g.: `/products/fixtures/brands.json`
>
> Moving the fixtures to `/cart/fixtures/` and referencing them by name
> only works.

New description:

 I have a Django 1.6.6 project that is not loading fixtures from relative
 paths using Python 2.7.8 on Windows 8.1. Works just fine in Linux.

 Example Test Case:

 {{{#!python
 # cart/tests.py

 class CartTestBase(TestCase):
 fixtures = ['products/fixtures/product_categories.json',
 'products/fixtures/brands.json', 'products/fixtures/products.json']
 }}}

 Which fits into a directory structure of:
 {{{
 ecomm_app/
 cart/
 __init__.py
 models.py
 tests.py
 . . .

 products/
 fixtures/
 products/fixtures/product_categories.json
 products/fixtures/brands.json
 products/fixtures/products.json
 __init__.py
 models.py
 . . .
 }}}

 The specific error message is:

 {{{
 UserWarning: No fixture named 'products/fixtures/products' found.
 warnings.warn("No fixture named '%s' found." % fixture_name)
 }}}

 The corresponding app modules are listed in `INSTALLED_APPS` and work fine
 otherwise. Specifying an absolute path does work, but obviously isn't
 cross-platform. Specifying a root-relative path does not work, e.g.:
 `/products/fixtures/brands.json`

 Moving the fixtures to `/cart/fixtures/` and referencing them by name only
 works.

--

Comment:

 First I assume the files in `products/fixtures/` are named `.json`
 and not `products/fixtures/.json`.

 I don't have Windows VM at hand but isn't it using backslashes (`\`) as
 directory separators?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.4981fbcad88344707526c8ba4b6bea1d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23584: makemessages only looks in the current folder

2014-10-07 Thread Django

#23584: makemessages only looks in the current folder
--+--
 Reporter:  edu2004eu |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  Translations  |  Version:  1.7
 Severity:  Normal|   Resolution:  needsinfo
 Keywords:  localization  | Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--

Comment (by edu2004eu):

 I did see that issue, and corrected my mistake, however the result was
 still the same. I also printed `self.ignore_patterns` and it doesn't
 contain the folder with my static files.

 I still believe it's to do with the line I originally posted, but I will
 try to create a minimal sample project with this issue and re-open.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a04fe8956b2c0297dd772907bce8eee1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #23612: Relative fixture paths not working on Windows 8.1

2014-10-07 Thread Django

#23612: Relative fixture paths not working on Windows 8.1
---+--
Reporter: alsoicode | Owner: nobody
Type: Bug| Status: new
Component: Testing framework |Version: 1.7
Severity: Normal | Keywords: windows fixtures
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
---+--
I have a Django 1.6.6 project that is not loading fixtures from relative
paths using Python 2.7.8 on Windows 8.1. Works just fine in Linux.

Example Test Case:

# cart/tests.py

class CartTestBase(TestCase):
fixtures = ['products/fixtures/product_categories.json',
'products/fixtures/brands.json',
'products/fixtures/products.json']

Which fits into a directory structure of:

ecomm_app/
cart/
__init__.py
models.py
tests.py
. . .

products/
fixtures/
products/fixtures/product_categories.json
products/fixtures/brands.json
products/fixtures/products.json
__init__.py
models.py
. . .

The specific error message is:

UserWarning: No fixture named 'products/fixtures/products' found.
warnings.warn("No fixture named '%s' found." % fixture_name)

The corresponding app modules are listed in `INSTALLED_APPS` and work fine
otherwise. Specifying an absolute path does work, but obviously isn't
cross-platform. Specifying a root-relative path does not work, e.g.:
`/products/fixtures/brands.json`

Moving the fixtures to `/cart/fixtures/` and referencing them by name only
works.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/052.0deb5e36892d79febf6fd30c9bb0d8c2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23611: update_or_create doesn't retain related manager reference

2014-10-07 Thread Django

#23611: update_or_create doesn't retain related manager reference
-+-
 Reporter:  ryanhiebert  |Owner:  aericson
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by ryanhiebert):

 Thank you @aericson. The PR is against master, and I'm unfamiliar with the
 process. How do changes like this that affect 1.7 get backported to the
 1.7 branch? Would this one qualify?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.db35a9fcd9233e0d5f1d5e4149862e7d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23449: Saving models with unsaved ForeignKey

2014-10-07 Thread Django

#23449: Saving models with unsaved ForeignKey
-+-
 Reporter:  pjrobertson  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by pjrobertson):

 @akaariai - OK I did create the issue, but I think it definitely is.

 For anybody else that has code with the same workflow as mine - create a
 django model.Model in memory, then save it later on - with this change our
 code will just break straight away. It also means that creating a
 `ForeignKey('something', null=True)` is essentially pointless as the
 problematic changes discussed here won't allow it.

 Finally, and an example I've just thought of now: `bulk_create` will no
 longer work:
 (Based on `ModelA` and `ModelB` in this issue:

 {{{
 model_bs = [ModelB(name=str(i)) for i in xrange(0,10)]
 ModelB.objects.bulk_create(model_bs)
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.8b7315093b6ab70c278bf335d8624117%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23589: Django 1.7 filter Q m2m bug

2014-10-07 Thread Django

#23589: Django 1.7 filter Q m2m bug
-+-
 Reporter:  Grafumbly|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:  invalid
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by akaariai):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 The interpretation of the query is that PrimaryObject must have a *single*
 relatedobject row for which (someparam=True AND NOT someparam=False).
 Obviously if someparam=True, then someparam is also not False for that
 row. The 1.7 results seem correct to me. (See
 https://docs.djangoproject.com/en/1.7/topics/db/queries/#spanning-multi-
 valued-relationships for how Django handles filters to multivalued
 relationships).

 I believe you will get correct results by using
 
`.filter(Q(relatedobject__someparam=True)).filter(~Q(relatedobject__someparam=False))`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.78b1441d71a0e1cdd0cc39678bb46bd2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23449: Saving models with unsaved ForeignKey

2014-10-07 Thread Django

#23449: Saving models with unsaved ForeignKey
-+-
 Reporter:  pjrobertson  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by akaariai):

 Is this really a release blocker?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.70cb10b8f997c562f493c9a42c79a3ad%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #5986: Custom field order in newforms

2014-10-07 Thread Django

#5986: Custom field order in newforms
-+-
 Reporter:  emes |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  field order weight   | Triage Stage:  Design
  form newforms  |  decision needed
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by mbertheau):

 * status:  closed => new
 * severity:   => Normal
 * type:   => Uncategorized
 * easy:   => 0
 * ui_ux:   => 0
 * resolution:  duplicate =>


Comment:

 This is not a dupe of #8164 since that only talks about and implements
 field ordering for ModelForms.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.3ff15a0e04bdcc1a5ce54b3a6cfee58e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23605: ORM neglects to use aliases it has set up when certain multiple subqueries are used

2014-10-07 Thread Django

#23605: ORM neglects to use aliases it has set up when certain multiple 
subqueries
are used
-+-
 Reporter:  ris  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  orm subquery alias   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by akaariai):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.477873843d62474191b15c7e26be210e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23605: ORM neglects to use aliases it has set up when certain multiple subqueries are used

2014-10-07 Thread Django

#23605: ORM neglects to use aliases it has set up when certain multiple 
subqueries
are used
-+-
 Reporter:  ris  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  orm subquery alias   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by akaariai):

 The problem was that django.db.models.sql.Query didn't have
 relabeled_clone() method. See PR3323 for proposed fix.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.81220ca316d038982e694a1fde61b3ba%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23605: ORM neglects to use aliases it has set up when certain multiple subqueries are used

2014-10-07 Thread Django

#23605: ORM neglects to use aliases it has set up when certain multiple 
subqueries
are used
-+-
 Reporter:  ris  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  orm subquery alias   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by ris):

 From IRC:

 {{{
  it is a bit hard to see if I am fixing the query to work as in
 PostgreSQL can parse the query, or actually produce correct results
  akaariai_: well, the inner double-NOT'ed subquery is to test for a
 ModelA object _all of whose_ ModelB objects conform to certain criteria
  those criteria being
  Q ( modelb__field_b0__gte = 100 / F (
 "modelb__modelc_fk__field_c0" ) ) & Q ( modelb__field_b1__exact = True )
  akaariai_: so it's saying "ModelA instances who have a ModelB
 instance that complies to X but _not_ ModelA instances that have any
 ModelB instances that _dont_ comply to X" (X = Q ( modelb__field_b0__gte =
 100 / F ( "modelb__modelc_fk__field_c0" ) ) & Q (
 modelb__field_b1__exact = True ) here)
  akaariai_: hence the odd double-negative-wrapped-subquery
  the outermost subquery .filter ( modelb__field_b1__exact = True ) is
 exactly the sort of appendage I'd like to be able to remove if I were able
 to test for Q-equality
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.6685fb28eaf17ccf8348c403ea78289a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[django/django] e9b85f: Added my bio to the core team.

2014-10-07 Thread GitHub

  Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: e9b85fd6264bf054091142e40b340a105554ad0a
  
https://github.com/django/django/commit/e9b85fd6264bf054091142e40b340a105554ad0a
  Author: Tom Christie 
  Date:   2014-10-07 (Tue, 07 Oct 2014)

  Changed paths:
M docs/internals/team.txt

  Log Message:
  ---
  Added my bio to the core team.


-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/5433db4d81d16_4e893ff6763e72c02854f%40hookshot-fe2-cp1-prd.iad.github.net.mail.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23610: Removing a null constraint can lead to race conditions with migrations

2014-10-07 Thread Django

#23610: Removing a null constraint can lead to race conditions with migrations
--+
Reporter: jarshwah |Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.7
Severity: Normal| Resolution:
Keywords: migrations| Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 |UI/UX: 0
--+
Changes (by loic):

* needs_better_patch: => 0
* component: Migrations => Documentation
* needs_tests: => 0
* needs_docs: => 0
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted

Comment:

There are many cases where old app code won't work after a migration
applied (e.g. adding a new column with `NOT NULL`, removing a column,
etc.). I reckon we should just document that people are expected to run
the new app code right after applying a migration.

There are certainly ways around it, but it's important people understand
that nothing special is done at the framework level.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.407f985fc074540ddbcd898b3cd49e65%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23609: Migration fails when removing a NULL constraint

2014-10-07 Thread Django

#23609: Migration fails when removing a NULL constraint
-+-
 Reporter:  Markush2010  |Owner:
 Type:  Uncategorized|  Markush2010
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
Has patch:  1|  Unreviewed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  1
 |UI/UX:  0
-+-

Comment (by Markush2010):

 Since there is no special handling for any database except SQLite in the
 `_alter_field()` schema alteration I didn't want to introduce one for
 PostgreSQL. Thus I ended up with the 4-way-default-alteration 1) Add a
 default for new incoming writes, 2) Update existing NULL rows with new
 default, 3) Replace NULL constraint with NOT NULL, 4) Drop the default
 again.

 I also updated the pull requested with the recent changes.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.4a624edd1829800a9052701734d1a35c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23605: ORM neglects to use aliases it has set up when certain multiple subqueries are used

2014-10-07 Thread Django

#23605: ORM neglects to use aliases it has set up when certain multiple 
subqueries
are used
-+-
 Reporter:  ris  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  orm subquery alias   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by akaariai):

 Smells like relabeled_clone problem. I'll investigate.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.023c2c2abc74d9f3728e512f4737bbf1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23605: ORM neglects to use aliases it has set up when certain multiple subqueries are used

2014-10-07 Thread Django

#23605: ORM neglects to use aliases it has set up when certain multiple 
subqueries
are used
-+-
 Reporter:  ris  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  orm subquery alias   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by ris):

 For what it's worth, this works in django 1.4 (ancient I know, but the
 last version we have in production right now).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.cbc2e16099041773f62a82443b8e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23611: update_or_create doesn't retain related manager reference

2014-10-07 Thread Django

#23611: update_or_create doesn't retain related manager reference
-+-
 Reporter:  ryanhiebert  |Owner:  aericson
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aericson):

 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.ff2831e815eb7b73396ae2dec56b879d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23611: update_or_create doesn't retain related manager reference

2014-10-07 Thread Django

#23611: update_or_create doesn't retain related manager reference
-+-
 Reporter:  ryanhiebert  |Owner:  aericson
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by aericson):

 @kswiat I have submitted a pull request at
 https://github.com/django/django/pull/3321 but let me know if you have any
 suggestions.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.9f5cbb5f94584cace2a0b8074139e919%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23611: update_or_create doesn't retain related manager reference

2014-10-07 Thread Django

#23611: update_or_create doesn't retain related manager reference
-+-
 Reporter:  ryanhiebert  |Owner:  aericson
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by kswiat):

 I would like to work on this one too, if You (aericson) have nothing
 against it. I have experienced similar problems with related managers
 recently and have done already some research.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.7c0ba1cac63717ac7e814c554f1b67b5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

61 matches

Mail list logo