Re: [Django] #24598: JsonResponse loses encoding support in Content-Type header

[Django]

#24598: JsonResponse loses encoding support in Content-Type header
---+--
 Reporter:  funkybob   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  HTTP handling  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by funkybob):

 Oops, forgot the second part of the patch:

 {{{
 @@ -470,11 +470,11 @@ class JsonResponse(HttpResponse):
  :param safe: Controls if only ``dict`` objects may be serialized.
 Defaults
to ``True``.
  """
 +default_content_type = 'application/json'

  def __init__(self, data, encoder=DjangoJSONEncoder, safe=True,
 **kwargs):
  if safe and not isinstance(data, dict):
  raise TypeError('In order to allow non-dict objects to be '
  'serialized set the safe parameter to False')
 -kwargs.setdefault('content_type', 'application/json')
  data = json.dumps(data, cls=encoder)
  super(JsonResponse, self).__init__(content=data, **kwargs)
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.94203c9424a6a6755c1d03104b5a202a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #24598: JsonResponse loses encoding support in Content-Type header

[Django]

#24598: JsonResponse loses encoding support in Content-Type header
-+
   Reporter:  funkybob   |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  HTTP handling  |Version:  1.8
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  1
Needs documentation:  1  |Needs tests:  1
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 By default when a content_type is not passed to HttpResponse it will
 create one from settings.DEFAULT_CONTENT_TYPE, and attach the encoding.

 So, when unspecified, the header will appear as:

 {{{
 Content-Type: text/html; encoding=utf-8
 }}}

 However, if you specify the content_type, this action is no taken.

 That's understandable in a "consenting adults" context, however the
 JsonResponse sets content_type using kwargs.setdefault, thus forcing the
 loss of encoding annotation in all responses.

 I propose instead that HttpResponseBase check for a
 ``default_content_type`` property to override
 settings.DEFAULT_CONTENT_TYPE, thus:


 {{{
 diff --git a/django/http/response.py b/django/http/response.py
 index c8d6930..40186b5 100644
 --- a/django/http/response.py
 +++ b/django/http/response.py
 @@ -54,8 +54,8 @@ class HttpResponseBase(six.Iterator):
  self._reason_phrase = reason
  self._charset = charset
  if content_type is None:
 -content_type = '%s; charset=%s' %
 (settings.DEFAULT_CONTENT_TYPE,
 -   self.charset)
 +content_type = getattr(self, 'default_content_type',
 settings.DEFAULT_CONTENT_TYPE)
 +content_type = '%s; charset=%s' % (content_type,
 self.charset)
  self['Content-Type'] = content_type
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.1a7eef387763a4c01089bf984f6fa197%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24593: Thousand separator not showing in ModelAdmin.readonly_fields (was: Thousand separator not showing in readonly fields)

[Django]

#24593: Thousand separator not showing in ModelAdmin.readonly_fields
-+-
 Reporter:  liwee|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:  Thousand separator   | Triage Stage:  Accepted
  readonly   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:   => 0
 * component:  Uncategorized => contrib.admin
 * needs_tests:   => 0
 * needs_docs:   => 0
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 I could reproduce this.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.9f95265467e38e296d6421afa9923566%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24582: ModelAdmin.delete_view(). List of items on level 3 not converted to html list

[Django]

#24582: ModelAdmin.delete_view(). List of items on level 3 not converted to html
list
---+--
 Reporter:  shultais   |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  contrib.admin  |  Version:  1.8
 Severity:  Normal |   Resolution:  worksforme
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 Please reopen if you can provide more detailed steps, thanks!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e0d7637f1b4fa0ebfffb8c665feca6c2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24544: core.files.images.get_image_dimensions broken on some valid PNG images

[Django]

#24544: core.files.images.get_image_dimensions broken on some valid PNG images
--+
 Reporter:  artscoop  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  File uploads/storage  |  Version:  1.7
 Severity:  Normal|   Resolution:  fixed
 Keywords:  PIL   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"2fc19b92387d4248c715edfbf38658238978abb6" 2fc19b92]:
 {{{
 #!CommitTicketReference repository=""
 revision="2fc19b92387d4248c715edfbf38658238978abb6"
 Fixed #24544 -- Fixed get_image_dimensions() on image buffers that Pillow
 fails to parse.

 Thanks Steve Kossouho for the report and original patch.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0b32ae4729caffab7f10084cc1ccffd6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24597: Documentation URLs are broken

[Django]

#24597: Documentation URLs are broken
---+--
 Reporter:  slimjim777 |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  1.8
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by timgraham):

 * status:  new => closed
 * needs_better_patch:   => 0
 * resolution:   => fixed
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Not sure of the root cause, but docs came back on the next update.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.50980faf0e86c83e52123d7aa37056b6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24547: Errors for paths for Model relationships in other apps can be misleading / confusing

[Django]

#24547: Errors for paths for Model relationships in other apps can be 
misleading /
confusing
-+-
 Reporter:  akulakov |Owner:  akulakov
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   |  worksforme
 Keywords:  error message,   | Triage Stage:  Accepted
  warning|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by akulakov):

 * status:  assigned => closed
 * resolution:   => worksforme


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0eef4a97e9bf5f5aff96bcb87bea0bcb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #24597: Documentation URLs are broken

[Django]

#24597: Documentation URLs are broken
---+
 Reporter:  slimjim777 |  Owner:  nobody
 Type:  Bug| Status:  new
Component:  Documentation  |Version:  1.8
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  1  |  UI/UX:  0
---+
 The Documentation link in the menu of djangoproject.com is broken:
 https://docs.djangoproject.com/en/1.8/ leads to a 404.

 Also, the subsequent help page (https://code.djangoproject.com/) links to
 the contribution guide, but that link is also broken:
 https://docs.djangoproject.com/en/1.8/internals/contributing/

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.2207a2dd7c7b9836f6f4341d89426a49%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24596: year_lookup_bounds_for_date_field should be evaluated via get_db_prep_value in get_db_prep_lookup

[Django]

#24596: year_lookup_bounds_for_date_field should be evaluated via 
get_db_prep_value
in get_db_prep_lookup
-+-
 Reporter:  nutztherookie|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Could you add a regression test for your patch to demonstrate what bug
 this fixes?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.3b7e8b74b1370eabeb5742eb798cf7eb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24596: year_lookup_bounds_for_date_field should be evaluated via get_db_prep_value in get_db_prep_lookup

[Django]

#24596: year_lookup_bounds_for_date_field should be evaluated via 
get_db_prep_value
in get_db_prep_lookup
--+
 Reporter:  nutztherookie |  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  Database layer (models, ORM)  |Version:  1.8
 Severity:  Normal| Resolution:
 Keywords:|   Triage Stage:  Unreviewed
Has patch:  1 |  Easy pickings:  0
UI/UX:  0 |
--+
Changes (by nutztherookie):

 * Attachment "0001-get_db_prep_value-on-year_lookup_bounds_for_date-
 dat.patch" added.


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.7e8b72e973a91f31cf0921a968d3e229%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #24596: year_lookup_bounds_for_date_field should be evaluated via get_db_prep_value in get_db_prep_lookup

[Django]

#24596: year_lookup_bounds_for_date_field should be evaluated via 
get_db_prep_value
in get_db_prep_lookup
--+
 Reporter:  nutztherookie |  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  Database layer (models, ORM)  |Version:  1.8
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  1
Easy pickings:  0 |  UI/UX:  0
--+
 I think the summary says it all..

 If i return `datetime.date` or `datetime.datetime` objects from my
 overwritten `year_lookup_bounds_for_date_field()` function they will not
 be casted to a corresponding string for the database to understand.

 i might be making a mistake some place else in my database driver, but my
 solution right now is attached here as a patch.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/056.372366614f139f4bad466c21e680f644%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24594: urlpatterns as list breaks template code

[Django]

#24594: urlpatterns as list breaks template code
---+--
 Reporter:  stephanm   |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  1.8
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by timgraham):

 * resolution:  worksforme => invalid


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.bf48ea5b1dc531ddb04989e0e424175d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24589: Allow usage of widgets (and maybe others) in GCBV (through ModelFormMixin)

[Django]

#24589: Allow usage of widgets (and maybe others) in GCBV (through 
ModelFormMixin)
---+--
 Reporter:  MarkusH|Owner:  nobody
 Type:  New feature|   Status:  closed
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:  wontfix
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 Feel free to raise it on the DevelopersMailingList for some more opinions.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.677c81eb0c23bdd2b443e60081e678bb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24429: Revise docs regarding non-int primary key on custom user models

[Django]

#24429: Revise docs regarding non-int primary key on custom user models
--+
 Reporter:  shadfc|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  1.8beta1
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by timgraham):

 For posterity, I didn't do any further investigation. Let's see if we get
 any reports about things that don't work.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.6bea32c283c65c11b9f09d03e8551729%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24429: Revise docs regarding non-int primary key on custom user models

[Django]

#24429: Revise docs regarding non-int primary key on custom user models
--+
 Reporter:  shadfc|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  1.8beta1
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"981e3b9394022810bd536474344e2f91c190b858" 981e3b9]:
 {{{
 #!CommitTicketReference repository=""
 revision="981e3b9394022810bd536474344e2f91c190b858"
 Fixed #24429 -- Doc'ed that Django 1.8 doesn't require an integer PK for
 custom user models.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.bcf15f7403bc352d8c31c03afe48b134%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24429: Revise docs regarding non-int primary key on custom user models

[Django]

#24429: Revise docs regarding non-int primary key on custom user models
--+
 Reporter:  shadfc|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  1.8beta1
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"993074d78d36875f984b5c2a53ef8a2547d392b5" 993074d]:
 {{{
 #!CommitTicketReference repository=""
 revision="993074d78d36875f984b5c2a53ef8a2547d392b5"
 [1.8.x] Fixed #24429 -- Doc'ed that Django 1.8 doesn't require an integer
 PK for custom user models.

 Backport of 981e3b9394022810bd536474344e2f91c190b858 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a38e389efa4dd12b86aebb310c27b55e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24595: alter field type on MySQL "forgets" nullability (and more)

[Django]

#24595: alter field type on MySQL "forgets" nullability (and more)
+--
 Reporter:  simonpercivall  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Could you check if this is a duplicate of #23678?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.2d67ec4a781ab738626be374bdfcf6b4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #24595: alter field type on MySQL "forgets" nullability (and more)

[Django]

#24595: alter field type on MySQL "forgets" nullability (and more)
+
 Reporter:  simonpercivall  |  Owner:  nobody
 Type:  Bug | Status:  new
Component:  Migrations  |Version:  1.7
 Severity:  Normal  |   Keywords:
 Triage Stage:  Unreviewed  |  Has patch:  0
Easy pickings:  0   |  UI/UX:  0
+
 A migration changing field type on MySQL will remove "NOT NULL" (and every
 other attribute) from the field. This is because MODIFY COLUMN on MySQL
 requires the whole field definition to be repeated, not just the type.

 So for instance:

 {{{
 class T(models.Model):
 field = models.SmallIntegerField()
 }}}

 will create a table:

 {{{
 CREATE TABLE `app_t` (
   ...
   `field` smallint(6) NOT NULL,
   ...
 ) ENGINE=InnoDB
 }}}

 Changing the field definition to:

 {{{
 ...
 field = models.IntegerField()
 ...
 }}}

 will create a migration:

 {{{
 ...
 migrations.AlterField(
 model_name='t',
 name='field',
 field=models.IntegerField(),
 )
 ...
 }}}

 resulting in the SQL

 {{{
 ALTER TABLE `app_t` MODIFY `field` integer
 }}}

 resulting in the table:

 {{{
 CREATE TABLE `app_t` (
   ...
   ``field` int(11) DEFAULT NULL,
   ...
 )
 }}}

 This applies to 1.7 through 1.8.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/057.db9759e84418355130fa5a91729be2e3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24594: urlpatterns as list breaks template code

[Django]

#24594: urlpatterns as list breaks template code
---+--
 Reporter:  stephanm   |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  1.8
 Severity:  Normal |   Resolution:  worksforme
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by stephanm):

 Hi,

 It was my mistake,  the old code i my project/urls.py
 contained:
 {{{#!py
 if settings.DEBUG:
 urlpatterns += staticfiles_urlpatterns()
 }}}

 and switching to the list form I changed the code to the '''wrong''' form:

 {{{#!py
 if settings.DEBUG:
 urlpatterns.append( staticfiles_urlpatterns() ) #THIS IS WRONG
 }}}

 I didn't realize that the old code was still OK because
 {{{staticfiles_urlpatterns()}}}
 returns a {{{list}}}.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.677a9c7d10242e4a9447918ee669acf2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22993: Drop skipIfCustomUser decorator

[Django]

#22993: Drop skipIfCustomUser decorator
-+-
 Reporter:  timo |Owner:  chrisjluc
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e37d52bd5eb98e6ddf61b766720583481d18bc2b" e37d52b]:
 {{{
 #!CommitTicketReference repository=""
 revision="e37d52bd5eb98e6ddf61b766720583481d18bc2b"
 Fixed #22993 -- Deprecated skipIfCustomUser decorator
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.b12938a122a7ce74e611861feb909d59%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24513: "... has no field named None" with M2MField when migrating

[Django]

#24513: "... has no field named None" with M2MField when migrating
-+-
 Reporter:  Kondou-ger   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Migrations   |  Version:  1.8
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  migrations, bug  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Markus Holtermann ):

 In [changeset:"9f632dc702a1b8b4c8044fb34bb3d5f2445dd4ee" 9f632dc]:
 {{{
 #!CommitTicketReference repository=""
 revision="9f632dc702a1b8b4c8044fb34bb3d5f2445dd4ee"
 [1.8.x] Fixed #24513 -- Made sure a model is only rendered once during
 reloads

 This also prevents state modifications from corrupting previous states.
 Previously, when a model defining a relation was unregistered first,
 clearing the cache would cause its related models' _meta to be cleared
 and would result in the old models losing track of their relations.

 Backport of 0385dad073270c37f8c4a5f13edce43f2a69ba8a from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.8184115786a09c4e82a18b216ceec1ae%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24578: prepare_database_save breaks some OneToOneField's in 1.8

[Django]

#24578: prepare_database_save breaks some OneToOneField's in 1.8
-+-
 Reporter:  dxiao2003|Owner:  timgraham
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/4462 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2e7ac385955bce2c7f4f31ce63da34df%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24513: "... has no field named None" with M2MField when migrating

[Django]

#24513: "... has no field named None" with M2MField when migrating
-+-
 Reporter:  Kondou-ger   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Migrations   |  Version:  1.8
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  migrations, bug  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Markus Holtermann ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"0385dad073270c37f8c4a5f13edce43f2a69ba8a" 0385dad]:
 {{{
 #!CommitTicketReference repository=""
 revision="0385dad073270c37f8c4a5f13edce43f2a69ba8a"
 Fixed #24513 -- Made sure a model is only rendered once during reloads

 This also prevents state modifications from corrupting previous states.
 Previously, when a model defining a relation was unregistered first,
 clearing the cache would cause its related models' _meta to be cleared
 and would result in the old models losing track of their relations.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.bb6b698f091756f9df7fe512e193f582%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24513: "... has no field named None" with M2MField when migrating

[Django]

#24513: "... has no field named None" with M2MField when migrating
-+-
 Reporter:  Kondou-ger   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:  migrations, bug  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by MarkusH):

 * needs_better_patch:  1 => 0
 * needs_docs:  1 => 0
 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.cbd527dc7d756f93e23c5c335b9bd1da%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24578: prepare_database_save breaks some OneToOneField's in 1.8

[Django]

#24578: prepare_database_save breaks some OneToOneField's in 1.8
-+-
 Reporter:  dxiao2003|Owner:  timgraham
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * owner:  nobody => timgraham
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f2ca7091de71bc50d4f0f86ef0e67a68%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24594: urlpatterns as list breaks template code

[Django]

#24594: urlpatterns as list breaks template code
---+--
 Reporter:  stephanm   |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  1.8
 Severity:  Normal |   Resolution:  worksforme
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by timgraham):

 * status:  new => closed
 * needs_better_patch:   => 0
 * resolution:   => worksforme
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 We will need more specific details about how to reproduce the error (such
 as a minimal project we can download). Please include only one "issue" per
 ticket as well.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a0e969948a7ea2baeecca7f9e63bf3e0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #24594: urlpatterns as list breaks template code

[Django]

#24594: urlpatterns as list breaks template code
---+
 Reporter:  stephanm   |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Uncategorized  |Version:  1.8
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 According to
 https://docs.djangoproject.com/en/1.8/releases/1.8/#django-conf-urls-
 patterns

 I switched a working project from
 {{{#!py
 urlpatterns = patterns('',
url(r'^$', 'myapp.views.index', name="home"),
 )
 }}}
 to
 {{{#!py
 urlpatterns = [ url(r'^$',  myapp.views.index, name="home"), ]
 }}}

 But now I get the exception:
 {{{
 Exception Type: AttributeError
 Exception Value:

 'list' object has no attribute 'regex'

 Exception Location: D:\Programme\python27\lib\site-
 packages\django\core\urlresolvers.py in _populate, line 298
 }}}

 Because I have the following code snippet in my html template:
 {{{
 {% url 'home' %}
 }}}
 
 '''Another item:''' In my settings.py I have
 {{{#!py
 LOGIN_URL = "/myapp/auth/login/"
 }}}
 which breaks too.
 This one works (at least) if I change it to:
 {{{#!py
 LOGIN_URL = "myapp.views.login"
 }}}

 System: I use python 2.7.9 (32 bit) on Windows 7 64 bit.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.5f1865a60ef6c070923af4afc2d47453%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24593: Thousand separator not showing in readonly fields

[Django]

#24593: Thousand separator not showing in readonly fields
-+
 Reporter:  liwee|  Owner:  nobody
 Type:  Uncategorized| Status:  new
Component:  Uncategorized|Version:  1.7
 Severity:  Normal   | Resolution:
 Keywords:  Thousand separator readonly  |   Triage Stage:  Unreviewed
Has patch:  0|  Easy pickings:  0
UI/UX:  0|
-+
Changes (by liwee):

 * Attachment "1.PNG" added.


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.683ae84ac25d80208e0aa9aeac9d12e8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #24593: Thousand separator not showing in readonly fields

[Django]

#24593: Thousand separator not showing in readonly fields
---+-
 Reporter:  liwee  |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Uncategorized  |Version:  1.7
 Severity:  Normal |   Keywords:  Thousand separator readonly
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+-
 I added the following to my form. Thousand separator appears in a normal
 integer field but missing from a readonly field.

 {{{
 class Meta:
 localized_fields = ('__all__')
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.9cbd5465c45f6127242e14652f7d5326%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.