Re: [Django] #20203: Impossible to have a descriptor named `objects` on an abstract model

[Django]

#20203: Impossible to have a descriptor named `objects` on an abstract model
-+-
 Reporter:  Alex |Owner:  coldmind
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  assigned => closed
 * resolution:   => fixed


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.d8157a9878aac8407638b83ed12c71d1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20203: Impossible to have a descriptor named `objects` on an abstract model

[Django]

#20203: Impossible to have a descriptor named `objects` on an abstract model
-+-
 Reporter:  Alex |Owner:  coldmind
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"c0cf73a57d7f77af348aeb854e7b4f670dc3cee7" c0cf73a]:
 {{{
 #!CommitTicketReference repository=""
 revision="c0cf73a57d7f77af348aeb854e7b4f670dc3cee7"
 Refs #20203 -- Allowed adding custom default manager to the model state

 If the only manager on the model is the default manager defined
 by Django (`objects = models.Manager()`), this manager will not
 be added to the model state. If it is custom, it needs to be
 passed to the model state.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.878b49391baddbe2034c2dce73bdb2d6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20203: Impossible to have a descriptor named `objects` on an abstract model

[Django]

#20203: Impossible to have a descriptor named `objects` on an abstract model
-+-
 Reporter:  Alex |Owner:  coldmind
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"c31bf8cb54e591e244abc951896ef5e4a089f38d" c31bf8c]:
 {{{
 #!CommitTicketReference repository=""
 revision="c31bf8cb54e591e244abc951896ef5e4a089f38d"
 Refs #20203 -- Added tests to check inherited custom default manager
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.0ed75c1fbd42a0d1b921657ab7a314a9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20271: PostgreSQL error: No operator matches the given name and argument type(s). You might need to add explicit type casts.

[Django]

#20271: PostgreSQL error: No operator matches the given name and argument 
type(s).
You might need to add explicit type casts.
-+-
 Reporter:  arctelix@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql, pk   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Shanto):

 * cc: shanto@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.6b9fdfa7718c4402251254900181e77a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21803: Support post-commit hooks

[Django]

#21803: Support post-commit hooks
-+-
 Reporter:  aaugustin|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1417bb4a1daf0f5635323241c8af1786%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20271: PostgreSQL error: No operator matches the given name and argument type(s). You might need to add explicit type casts.

[Django]

#20271: PostgreSQL error: No operator matches the given name and argument 
type(s).
You might need to add explicit type casts.
-+-
 Reporter:  arctelix@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql, pk   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by timgraham:

Old description:

> It seems this error is still around!
>
> Traceback (most recent call last):
>
>   File "/app/.heroku/src/django-tastypie/tastypie/resources.py", line
> 202, in wrapper
> response = callback(request, *args, **kwargs)
>
>   File "/app/.heroku/src/django-tastypie/tastypie/resources.py", line
> 441, in dispatch_list
> return self.dispatch('list', request, **kwargs)
>
>   File "/app/.heroku/src/django-tastypie/tastypie/resources.py", line
> 473, in dispatch
> response = method(request, **kwargs)
>
>   File "/app/.heroku/src/django-tastypie/tastypie/resources.py", line
> 1244, in get_list
> to_be_serialized = paginator.page()
>
>   File "/app/.heroku/src/django-tastypie/tastypie/paginator.py", line
> 186, in page
> count = self.get_count()
>
>   File "/app/.heroku/src/django-tastypie/tastypie/paginator.py", line
> 118, in get_count
> return self.objects.count()
>
>   File "/app/.heroku/python/lib/python2.7/site-
> packages/django/db/models/query.py", line 351, in count
> return self.query.get_count(using=self.db)
>
>   File "/app/.heroku/python/lib/python2.7/site-
> packages/django/db/models/sql/query.py", line 418, in get_count
> number = obj.get_aggregation(using=using)[None]
>
>   File "/app/.heroku/python/lib/python2.7/site-
> packages/django/db/models/sql/query.py", line 384, in get_aggregation
> result = query.get_compiler(using).execute_sql(SINGLE)
>
>   File "/app/.heroku/python/lib/python2.7/site-
> packages/django/db/models/sql/compiler.py", line 818, in execute_sql
> cursor.execute(sql, params)
>
>   File "/app/.heroku/python/lib/python2.7/site-
> packages/django/db/backends/postgresql_psycopg2/base.py", line 52, in
> execute
> return self.cursor.execute(query, args)
>
> DatabaseError: operator does not exist: integer = text LINE 1: ... INNER
> JOIN "django_comments" ON ("pins_pin"."id" = "django_...
>  ^
> HINT:  No operator matches the given name and argument type(s). You might
> need to add explicit type casts.

New description:

 It seems this error is still around!
 {{{
 Traceback (most recent call last):

   File "/app/.heroku/src/django-tastypie/tastypie/resources.py", line 202,
 in wrapper
 response = callback(request, *args, **kwargs)

   File "/app/.heroku/src/django-tastypie/tastypie/resources.py", line 441,
 in dispatch_list
 return self.dispatch('list', request, **kwargs)

   File "/app/.heroku/src/django-tastypie/tastypie/resources.py", line 473,
 in dispatch
 response = method(request, **kwargs)

   File "/app/.heroku/src/django-tastypie/tastypie/resources.py", line
 1244, in get_list
 to_be_serialized = paginator.page()

   File "/app/.heroku/src/django-tastypie/tastypie/paginator.py", line 186,
 in page
 count = self.get_count()

   File "/app/.heroku/src/django-tastypie/tastypie/paginator.py", line 118,
 in get_count
 return self.objects.count()

   File "/app/.heroku/python/lib/python2.7/site-
 packages/django/db/models/query.py", line 351, in count
 return self.query.get_count(using=self.db)

   File "/app/.heroku/python/lib/python2.7/site-
 packages/django/db/models/sql/query.py", line 418, in get_count
 number = obj.get_aggregation(using=using)[None]

   File "/app/.heroku/python/lib/python2.7/site-
 packages/django/db/models/sql/query.py", line 384, in get_aggregation
 result = query.get_compiler(using).execute_sql(SINGLE)

   File "/app/.heroku/python/lib/python2.7/site-
 packages/django/db/models/sql/compiler.py", line 818, in execute_sql
 cursor.execute(sql, params)

   File "/app/.heroku/python/lib/python2.7/site-
 packages/django/db/backends/postgresql_psycopg2/base.py", line 52, in
 execute
 return self.cursor.execute(query, args)

 DatabaseError: operator does not exist: integer = text LINE 1: ... INNER
 JOIN "django_comments" ON ("pins_pin"."id" = "django_...
  ^
 HINT:  No operator matches the given name and argument type(s). You might
 need to add 

Re: [Django] #20271: PostgreSQL error: No operator matches the given name and argument type(s). You might need to add explicit type casts.

[Django]

#20271: PostgreSQL error: No operator matches the given name and argument 
type(s).
You might need to add explicit type casts.
-+-
 Reporter:  arctelix@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql, pk   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by charettes):

 * status:  closed => new
 * resolution:  needsinfo =>


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.20a0a37564cadc0c2acf9df1cca73325%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20271: PostgreSQL error: No operator matches the given name and argument type(s). You might need to add explicit type casts.

[Django]

#20271: PostgreSQL error: No operator matches the given name and argument 
type(s).
You might need to add explicit type casts.
-+-
 Reporter:  arctelix@…   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  postgresql, pk   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by charettes):

 * version:  1.4 => master
 * stage:  Unreviewed => Accepted


Comment:

 Managed to reproduce with the provided patch against master.

 As Anssi said this looks hard to fix but I'm tentatively accepting.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.3523e47475a163b71d9800283e6ea740%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20271: PostgreSQL error: No operator matches the given name and argument type(s). You might need to add explicit type casts.

[Django]

#20271: PostgreSQL error: No operator matches the given name and argument 
type(s).
You might need to add explicit type casts.
-+-
 Reporter:  arctelix@…   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.4
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  postgresql, pk   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Shanto):

 * Attachment "generic_relations_regress-test_textlink_join.patch" added.


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.d767c9364040da28367918bdcfc3f663%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24995: MySQL error when renaming a primary key

[Django]

#24995: MySQL error when renaming a primary key
+
 Reporter:  EikeDehling |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.8
 Severity:  Normal  |   Resolution:
 Keywords:  rename mysql error  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * needs_tests:  1 => 0


Comment:

 The current test on the pull request doesn't appear to be a regression
 test as it passes even with the fix reverted.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.361a2281b7fc2e38d6e7b029135da7e2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25026: Should QueryDict accept "html json forms"?

[Django]

#25026: Should QueryDict accept "html json forms"?
---+--
 Reporter:  zauddelig  |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  HTTP handling  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by timgraham):

 I'm not sure what you meant by that last comment. Was it a reply to my
 comment or something unrelated?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a4862cb8e980db883b21aead228b5973%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25034: Remove attempts to access settings at import time

[Django]

#25034: Remove attempts to access settings at import time
--+
 Reporter:  evansd|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * component:  Uncategorized => Core (Other)


Comment:

 For `staticfiles`, I also couldn't find any docs of that attribute. We do
 suggest reference `settings.DEBUG` in urlpatterns though, e.g.
 {{{
 from django.conf import settings
 from django.contrib.staticfiles import views

 if settings.DEBUG:
 urlpatterns += [
 url(r'^static/(?P.*)$', views.serve),
 ]
 }}}
 so it may be counterintuitive to make the recommendation. I guess the
 distinction is Django itself vs. user projects. However, I wonder if we
 might just ignore the issue here until we improve static serving and make
 it usable in production as suggested [https://groups.google.com/d/topic
 /django-developers/N0KbgDeLuUE/discussion on django-developers]. Then we
 can simply drop `settings.DEBUG` and don't have to worry about backwards
 compatibility.

 How about making the `CACHES` exception a system check?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.04ce4e2b413902a668f9c85ba14b8914%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25034: Remove attempts to access settings at import time

[Django]

#25034: Remove attempts to access settings at import time
--+
 Reporter:  evansd|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by carljm):

 * stage:  Unreviewed => Accepted


Comment:

 I agree with Aymeric. Avoiding import time use of settings has been
 preferred for quite a while. There used to be many more cases of this but
 most have been fixed. These should be too.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.95eaafe28cb718945e41e7b4c5aeb187%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20597: Replace admin icons images by an icon font.

[Django]

#20597: Replace admin icons images by an icon font.
-+-
 Reporter:  loic84   |Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by rm_):

 * cc: riccardo.magliocchetti@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a842f27f2eaf7a06b4c5ffd697cb8bb5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25034: Remove attempts to access settings at import time

[Django]

#25034: Remove attempts to access settings at import time
-+-
 Reporter:  evansd   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Uncategorized|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by aaugustin):

 It would be nice if any Django module could be imported without requiring
 configured settings. That's why settings are lazily loaded in the first
 place. So I think it's a worthwhile design goal.

 The `urlpatterns` variable in `django.contrib.staticfiles.urls` allows
 `include('django.contrib.staticfiles.urls')` in an URLconf. I don't think
 that's documented. I couldn't get meaninfgul data on whether it's used in
 the wild. In doubt, we could deprecate it instead of removing it.

 I support refactoring the cache implementation to defer use of the
 `CACHES` setting. If needed, we could call initialization code from
 `django.setup()`. This isn't as bad at it may sound at first. Almost
 everything in Django is an app and apps have a documented start-up hook,
 `AppConfig.ready()`. The ORM isn't an app and its initialization is
 performed explicitly during app loading. The cache isn't an app either and
 could be initialized at the same point.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.36704946b5ebeb168393a79625c548e4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25018: Make simple_tag apply conditional_escape() to its output

[Django]

#25018: Make simple_tag apply conditional_escape() to its output
--+
 Reporter:  timgraham |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Template system   |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"aef2a0ec59301022354c043744a6a2fa13583aa1" aef2a0e]:
 {{{
 #!CommitTicketReference repository=""
 revision="aef2a0ec59301022354c043744a6a2fa13583aa1"
 Fixed #25018 -- Changed simple_tag to apply conditional_escape() to its
 output.

 This is a security hardening fix to help prevent XSS (and incorrect HTML)
 for the common use case of simple_tag.

 Thanks to Tim Graham for the review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8a8e88d3d7f5984c3c0f37924a5340a7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23791: Subqueries with non-"id" OneToOneField primary keys try to join against the wrong column name

[Django]

#23791: Subqueries with non-"id" OneToOneField primary keys try to join against 
the
wrong column name
-+-
 Reporter:  ris  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  orm primary_key  | Triage Stage:  Ready for
  OneToOneField subquery values  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"9ed82154bd0bd01c6195942db84302e791ad366f" 9ed8215]:
 {{{
 #!CommitTicketReference repository=""
 revision="9ed82154bd0bd01c6195942db84302e791ad366f"
 Fixed #23791 -- Corrected object type check for pk__in=qs

 When the pk was a relation field, qs.filter(pk__in=qs) didn't work.

 In addition, fixed Restaurant.objects.filter(place=restaurant_instance),
 where place is an OneToOneField and the primary key of Restaurant.

 A big thank you to Josh for review and to Tim for review and cosmetic
 edits.

 Thanks to Beauhurst for commissioning the work on this ticket.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.bed41f90ba04e7c6691194366c2275d9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #17914: reverse() does not support namespaced view references when passed a callable (was: reverse() does not support namespaced view references)

[Django]

#17914: reverse() does not support namespaced view references when passed a
callable
-+-
 Reporter:  Bradley Ayers|Owner:  nobody
    |
 Type:  Bug  |   Status:  new
Component:  Core (URLs)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/097.6d4db950a72ceaf193323bea8d20ea54%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25035: urlresolvers.reverse doesn't resolve a namespaced URL when passed a callable

[Django]

#25035: urlresolvers.reverse doesn't resolve a namespaced URL when passed a
callable
--+--
 Reporter:  adambrenecki  |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  Core (URLs)   |  Version:  master
 Severity:  Normal|   Resolution:  duplicate
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by timgraham):

 * status:  new => closed
 * needs_better_patch:   => 0
 * component:  Uncategorized => Core (URLs)
 * needs_tests:   => 0
 * type:  Uncategorized => Bug
 * needs_docs:   => 0
 * resolution:   => duplicate


Comment:

 Duplicate of #17914

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.65fe9513989a7a15ea82822b3603baeb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25034: Remove attempts to access settings at import time

[Django]

#25034: Remove attempts to access settings at import time
-+-
 Reporter:  evansd   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Uncategorized|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by coldmind):

 I don't see nothing wrong to use these imports.
 You can not use most of django features before configuring settings.
 If you will try to use some method, which is accessing settings inside
 without configuring settings, you will get the same effect.

 I'm not familiar with `staticfiles` package to say if this stuff with
 `urlpatterns` needed or not, so
 some core dev will give an answer to that.

 `if DEFAULT_CACHE_ALIAS not in settings.CACHES` '''is needed''' because
 code in this module relies on this check and you can not simply remove it
 without giving the alternative.
 Also, It is better to raise error about wrong configuration at the start
 than getting an error when trying to use cache stuff.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.66034cce90343c644823b646e2c9bc12%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25034: Remove attempts to access settings at import time

[Django]

#25034: Remove attempts to access settings at import time
-+-
 Reporter:  evansd   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Uncategorized|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by evansd):

 I think we're talking past each other here: I am saying that it would be
 better (though obviously not essential) if importing a module before
 configuring settings did not trigger an error. This is because import-time
 side effects are generally speaking to be avoided, and the specific case
 of evaluating settings at import time is discouraged by Django's own style
 guide (as linked above). Moreover I am claiming that neither of these two
 cases do anything particularly useful.

 The coverage report proves nothing: that file is loaded as part of the
 test run and so that line is of course evaluated but that doesn't show it
 is used by anything. The tests that exercise that file continue to pass
 and there is no mention in any of the docs for any Django version of
 importing `urlpatterns` from that file.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.62dc86e1a559d5045441f0ef908046fe%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25034: Remove attempts to access settings at import time

[Django]

#25034: Remove attempts to access settings at import time
-+-
 Reporter:  evansd   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Uncategorized|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by coldmind):

 That is what I'm saying, you're trying to import a module without
 configuring settings before.
 When django application will be runned, it can safely import this, because
 `django.setup()` must be called when configuring wsgi-application.
 I don't see use case when you need to import this django stuff outside of
 configured django environment.

 Also, you can not simply remove thinks you removed in you pull request,
 because these imports are needed.
 Second case is used:
 http://djangoci.com/view/coverage/job/django-coverage/HTML_Coverage_Report
 /_mnt_jenkinsdata_workspace_django-
 coverage_django_contrib_staticfiles_urls.html#n17
 The first one is not covered by tests, but I believe it can not be simply
 tested or simply test is missing.

 I lean to close this ticket as invalid, but lets wait for core dev
 decision.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.09b5e62414af0623675c19a44c88662b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25034: Remove attempts to access settings at import time

[Django]

#25034: Remove attempts to access settings at import time
-+-
 Reporter:  evansd   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Uncategorized|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by evansd):

 I don't think that's true. Here's a minimal case to reproduce:

 {{{
 $ python -c 'import django.core.cache'
 Traceback (most recent call last):
   File "", line 1, in 
   File "/home/dave/.virtualenvs/tmp-a5eec9fa521d379a/local/lib/python2.7
 /site-packages/django/core/cache/__init__.py", line 34, in 
 if DEFAULT_CACHE_ALIAS not in settings.CACHES:
   File "/home/dave/.virtualenvs/tmp-a5eec9fa521d379a/local/lib/python2.7
 /site-packages/django/conf/__init__.py", line 48, in __getattr__
 self._setup(name)
   File "/home/dave/.virtualenvs/tmp-a5eec9fa521d379a/local/lib/python2.7
 /site-packages/django/conf/__init__.py", line 42, in _setup
 % (desc, ENVIRONMENT_VARIABLE))
 django.core.exceptions.ImproperlyConfigured: Requested setting CACHES, but
 settings are not configured. You must either define the environment
 variable DJANGO_SETTINGS_MODULE or call settings.configure() before
 accessing settings.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e18fff9898f9c2e694c161140164e7de%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25034: Remove attempts to access settings at import time

[Django]

#25034: Remove attempts to access settings at import time
-+-
 Reporter:  evansd   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Uncategorized|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by coldmind):

 * cc: me@… (added)


Comment:

 Normal django WSGI-application need to call `django.setup()`, which is
 configuring settings.
 I believe your application somehow overrides what `django.setup()` in
 `wsgi.py` do, when you are applying your class
 (`DjangoWhiteNoise(application)`), so you're getting an error.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a8313e1c56ab6b4a18cdebf51773c442%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.