Re: [Django] #6630: Fieldsets for forms

[Django]

#6630: Fieldsets for forms
-+-
 Reporter:  Petr Marhoun |Owner:  nobody
 |
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  feature  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by lingfish):

 * cc: lingfish (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.438bc4bd192a35039a1fc161dac880d3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #6630: Fieldsets for forms

[Django]

#6630: Fieldsets for forms
-+-
 Reporter:  Petr Marhoun |Owner:  nobody
 |
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  feature  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-

Comment (by lingfish):

 Hi, forgive me, but I cannot work out of this has been implemented or not?
 I see carljm's comment, but it isn't clear if this is going anywhere, or
 if we have to patch manually?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.bb7aa32417423735934709963e32f43b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25302: BrokenLinkEmailsMiddleware shouldn't report 404s when Referer = URL

[Django]

#25302: BrokenLinkEmailsMiddleware shouldn't report 404s when Referer = URL
---+--
 Reporter:  aaugustin  |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  HTTP handling  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by aaugustin):

 Just to be clear: a 404 with a Referer equal to the current URL must be a
 false positive, because there's no way you can be coming from a page that
 doesn't exist.

 If the page disappeared between the previous and the current request, then
 the problem is solved, since the page containing the broken link no longer
 exists.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ac524178d205d628368d56f1f666d219%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #25302: BrokenLinkEmailsMiddleware shouldn't report 404s when Referer = URL

[Django]

#25302: BrokenLinkEmailsMiddleware shouldn't report 404s when Referer = URL
-+
   Reporter:  aaugustin  |  Owner:  nobody
   Type:  New feature| Status:  new
  Component:  HTTP handling  |Version:  1.8
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 Many dubious bots send a Referer header that is equal to the current URL,
 presumably to work around checks for empty Referer headers. Some of these
 bots are also poorly implemented and trigger a stupid amount of 404s.

 BrokenLinkEmailsMiddleware is smart enough not to report 404s without a
 Referer. I suggest to make it not report 404s when the Referer it equal to
 the current URL either.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.455e96535d15516a25c91432204fdfc1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24975: Add the ability to prefetch_related() from a model instance

[Django]

#24975: Add the ability to prefetch_related() from a model instance
-+-
 Reporter:  duduklein|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by duduklein):

 That seems to work very well. Thanks for addressing this issue.

 As far as I understand, this would prefetch
 {{{
 order.articles.all()
 }}}

 May be the docs could also specify how to prefetch other manager /
 queryset (filters).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ccbea5f68dd0179ffb3cc5cb402c52b4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24688: Add Oracle support for new-style GIS functions

[Django]

#24688: Add Oracle support for new-style GIS functions
-+
 Reporter:  claudep  |Owner:  jtiai
 Type:  New feature  |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by jtiai):

 * owner:  nobody => jtiai
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.56d259e56329da0d8a959ce79d3214c5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24688: Add Oracle support for new-style GIS functions

[Django]

#24688: Add Oracle support for new-style GIS functions
-+
 Reporter:  claudep  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  GIS  |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timgraham):

 * severity:  Normal => Release blocker


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4f0fd2010fb7347251cdcb16ac0e5705%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25299: Admin crash with the name of a reverse accessor in list_display (was: Backwards compatibility issue with list_display callable names)

[Django]

#25299: Admin crash with the name of a reverse accessor in list_display
-+-
 Reporter:  scoenye  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:  list_display | Triage Stage:  Accepted
  callable name  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * severity:  Normal => Release blocker
 * needs_better_patch:   => 0
 * component:  Uncategorized => contrib.admin
 * needs_tests:   => 0
 * needs_docs:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 This looks like a bug we should fix. Attaching a regression test for
 Django's test suite. Feel free to tackle it if you have some time.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e696ae450e09a9bf040dd3814b768b75%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25299: Admin crash with the name of a reverse accessor in list_display

[Django]

#25299: Admin crash with the name of a reverse accessor in list_display
-+-
 Reporter:  scoenye  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:  list_display | Triage Stage:  Accepted
  callable name  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * Attachment "25299-test.diff" added.


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.86a60828dae8358d5d54011e4bed69b0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25296: Failed Manager.create pollutes related models cache in 1.8.4

[Django]

#25296: Failed Manager.create pollutes related models cache in 1.8.4
-+-
 Reporter:  rubendura|Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 Apparently we cannot please all the people all the time when it comes to
 this issue. ;-)

 Do you have any suggestions about what change or release notes
 modification to make in Django?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.39c17e2f60d26c95538dbb138c7984c4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25297: makemessages doesn't detect the context of {% trans %} strings with a filter (was: The makemessages command does not detect the context of {% trans %} templatetags with a filter)

[Django]

#25297: makemessages doesn't detect the context of {% trans %} strings with a
filter
--+
 Reporter:  apocquet  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Internationalization  |  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 If this cannot be made to work for some reason, documenting the
 restriction may be helpful.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.2f7429d077a0524fda3ee9151c9f1201%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24590: Cache return value of `swappable_setting`

[Django]

#24590: Cache return value of `swappable_setting`
-+-
 Reporter:  knbk |Owner:  MarkusH
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by MarkusH):

 * needs_docs:  0 => 1
 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.0f9ae1d566732f3d8841f40f6e7fb894%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24590: Cache return value of `swappable_setting`

[Django]

#24590: Cache return value of `swappable_setting`
-+-
 Reporter:  knbk |Owner:  MarkusH
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by MarkusH):

 * status:  new => assigned
 * owner:  knbk => MarkusH


Comment:

 I updated the existing PR: https://github.com/django/django/pull/5176

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.ffb93004abc20c57136f20a12004ae05%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25292: "'str' object has no attribute '_meta'" crash in ManyToManyField.through_fields check (was: doesn't handle an error properly in ManyToManyField.through_fields)

[Django]

#25292: "'str' object has no attribute '_meta'" crash in
ManyToManyField.through_fields check
-+-
 Reporter:  thbarrons|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (System |  Version:  1.8
  checks)|
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3d6655e3e7d9a8a25086e74d76a94cf4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25200: Update tutorial screenshots for new admin theme

[Django]

#25200: Update tutorial screenshots for new admin theme
---+
 Reporter:  timgraham  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  1.9| Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by timgraham):

 This should wait until #20597 (replace admin icon images by SVG) is
 resolved.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.25e59275588f5f037b9dadebd1872c34%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20597: Replace admin icons images by inline SVG

[Django]

#20597: Replace admin icons images by inline SVG
-+-
 Reporter:  loic84   |Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  1.9  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by timgraham):

 * keywords:   => 1.9


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.6265861d1e206ae7ccd47f33ff82d1a5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #12952: Models history doesn't use verbose names

[Django]

#12952: Models history doesn't use verbose names
--+
 Reporter:  acangiano |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  1
--+

Comment (by timgraham):

 I left some comments for improvement on the pull request. Don't forget to
 uncheck "Patch needs improvement" on this ticket after you update it so it
 appears in the review queue, thanks!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c7f331b36457f24097d0e78d23d3cae3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25300: Add a test for BoundField.id_for_label

[Django]

#25300: Add a test for BoundField.id_for_label
--+
 Reporter:  timgraham |Owner:  mlorant
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7d60659e22c869149cc17f2568a8e073412ea219" 7d60659]:
 {{{
 #!CommitTicketReference repository=""
 revision="7d60659e22c869149cc17f2568a8e073412ea219"
 Fixed #25300 -- Added unit tests for BoundField.id_for_label
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b66931ea430812ac8f948a1138a87c1b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25040: get_related_models_recursive() cannot handle a model with a GenericFK

[Django]

#25040: get_related_models_recursive() cannot handle a model with a GenericFK
-+-
 Reporter:  kairichard   |Owner:
 |  kairichard
 Type:  Bug  |   Status:  closed
Component:  Migrations   |  Version:  1.8
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  migrations generic   | Triage Stage:  Ready for
  fk |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"26dcf739eaf5577c5072eb8c9ba1c5ac5605683f" 26dcf739]:
 {{{
 #!CommitTicketReference repository=""
 revision="26dcf739eaf5577c5072eb8c9ba1c5ac5605683f"
 Forwardported release note for refs #25040.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.b0006023e3a1a823b9fb1d526495bcd0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25040: get_related_models_recursive() cannot handle a model with a GenericFK

[Django]

#25040: get_related_models_recursive() cannot handle a model with a GenericFK
-+-
 Reporter:  kairichard   |Owner:
 |  kairichard
 Type:  Bug  |   Status:  closed
Component:  Migrations   |  Version:  1.8
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  migrations generic   | Triage Stage:  Ready for
  fk |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"181528726ed2e3f1457e13872c777d0447cc52b8" 1815287]:
 {{{
 #!CommitTicketReference repository=""
 revision="181528726ed2e3f1457e13872c777d0447cc52b8"
 [1.8.x] Fixed #25040 -- Fixed migrations state crash with
 GenericForeignKey

 Backport of 60f795c0608119cdb02d61d3eb59f34ebdb55754 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.6067184bb9086fcda07b4277757b6450%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25068: Metaclass conflict when doing createmigrations in ModelState.render

[Django]

#25068: Metaclass conflict when doing createmigrations in ModelState.render
-+-
 Reporter:  kosz85   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  metaclass conflict   | Triage Stage:  Accepted
  createmigrations   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 Marking as "Patch needs improvement" since the current pull request
 [https://github.com/django/django/pull/4968#issuecomment-133674517 results
 in a performance regression].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.569abd5330f245aefc8bf3cb27fe5486%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24743: Django 1.8.1 migrations are actually slower than 1.8?

[Django]

#24743: Django 1.8.1 migrations are actually slower than 1.8?
--+
 Reporter:  pzrq  |Owner:  MarkusH
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Migrations|  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by MarkusH):

 * Attachment "stats-master.pstats" added.


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.07d1507a37b6b32bdb88f99f032257ec%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24743: Django 1.8.1 migrations are actually slower than 1.8?

[Django]

#24743: Django 1.8.1 migrations are actually slower than 1.8?
--+
 Reporter:  pzrq  |Owner:  MarkusH
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Migrations|  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by MarkusH):

 * Attachment "stats-1.8.4.pstats" added.


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.1aaf4dd081db9a1fbecd5655f6b24aba%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24743: Django 1.8.1 migrations are actually slower than 1.8?

[Django]

#24743: Django 1.8.1 migrations are actually slower than 1.8?
--+
 Reporter:  pzrq  |Owner:  MarkusH
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Migrations|  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by MarkusH):

 I thought about giving the rendering another improvement, but before
 diving in I ran cProfile on the `rendering model states` phase on the
 current stable/1.8.x branch (0e3a8c22dfbbe06a9a81afb2593255293efdc87e) and
 master (97ac77e544f9b1d1f28c0f859bef8fbc195d81a5) with the following diff
 applied:

 {{{#!diff
 diff --git a/django/core/management/commands/migrate.py
 b/django/core/management/commands/migrate.py
 index d26fd3d..40dca0b 100644
 --- a/django/core/management/commands/migrate.py
 +++ b/django/core/management/commands/migrate.py
 @@ -219,7 +219,9 @@ class Command(BaseCommand):
  else:
  fake = options.get("fake")
  fake_initial = options.get("fake_initial")
 -executor.migrate(targets, plan, fake=fake,
 fake_initial=fake_initial)
 +import cProfile
 +cProfile.runctx('executor.migrate(targets, plan, fake=fake,
 fake_initial=fake_initial)', globals(), locals(),
 filename='/tmp/stats.pstats')
 +# executor.migrate(targets, plan, fake=fake,
 fake_initial=fake_initial)

  # Send the post_migrate signal, so individual apps can do
 whatever they need
  # to do at this point.
 diff --git a/django/db/migrations/executor.py
 b/django/db/migrations/executor.py
 index aeb021e..2c08ab3 100644
 --- a/django/db/migrations/executor.py
 +++ b/django/db/migrations/executor.py
 @@ -104,6 +104,7 @@ class MigrationExecutor(object):
  state = migration.mutate_state(state, preserve=do_run)
  if self.progress_callback:
  self.progress_callback("render_success")
 +return
  # Phase 2 -- Run the migrations
  for migration, backwards in plan:
  if not backwards:
 }}}

 This yield the attached pstats files with my "benchmark" repository
 https://github.com/MarkusH/django-migrations-benchmark. I put the output
 of the first ~40 rows into a gist (better readability):
 https://gist.github.com/MarkusH/0c5d30449cdf7f1961f6 . What one can see is
 a reduction by almost 50%.

 Can somebody confirm this improvement in one of their real world projects,
 please.

 This is on Python 3.4.3 on ArchLinux

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.5ce2819033907cd7ed04e2b002cedfd3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.