Re: [Django] #27119: full_clean() called too many times during formset validation

[Django]

#27119: full_clean() called too many times during formset validation
-+-
 Reporter:  Claude Paroz |Owner:  Karol
 Type:   |  Sztajerwald
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e7277c3ef4fc83d4a62d1d7e5ced617d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26789: ORM produces query with NULL instead of empty geometry

[Django]

#26789: ORM produces query with NULL instead of empty geometry
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  Bug  |   Status:  assigned
Component:  GIS  |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.ecf072a84201add39210ad19b7cd250a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27358: Add a system check for FileField upload_to starting with a slash

[Django]

#27358: Add a system check for FileField upload_to starting with a slash
-+-
 Reporter:  Tim Graham   |Owner:  Henry
 Type:   |  Dang
  Cleanup/optimization   |   Status:  closed
Component:  Core (System |  Version:  1.10
  checks)|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"e6262aaaf8066f2de8aadcc9561941ae64478cef" e6262aaa]:
 {{{
 #!CommitTicketReference repository=""
 revision="e6262aaaf8066f2de8aadcc9561941ae64478cef"
 Refs #27358 -- Removed invalid/unneeded FileField.upload_to in tests/docs.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.16737ac473badd9ada5c850920113baf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26543: Changelist actions don't redirect after failed action resulting in possible ERR_CACHE_MISS in next steps

[Django]

#26543: Changelist actions don't redirect after failed action resulting in 
possible
ERR_CACHE_MISS in next steps
-+-
 Reporter:  Emmanuelle   |Owner:  Adonys
  Delescolle |  Alea Boffill
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Adonys Alea Boffill):

 * needs_tests:  1 => 0


Comment:

 I added the `Selenium` tests and follow the suggestion of ``. This is the pull request
 [https://github.com/django/django/pull/7645]  .

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.1d95df31bcbc04468aa192c0ee6fc054%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27297: infinite AlterField migrations created for foreign key after case-only model name change

[Django]

#27297: infinite AlterField migrations created for foreign key after case-only
model name change
+
 Reporter:  Daniel Musketa  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by Anton Samarchyan):

 * needs_better_patch:  1 => 0
 * has_patch:  1 => 0


Comment:

 My patch used an incorrect approach. Need a new patch.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.576f1aa67900ed4fb8cb1af51884149b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27119: full_clean() called too many times during formset validation

[Django]

#27119: full_clean() called too many times during formset validation
-+-
 Reporter:  Claude Paroz |Owner:  Karol
 Type:   |  Sztajerwald
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * needs_tests:  1 => 0


Comment:

 Tests added in that [https://github.com/django/django/pull/7644 PR].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e38e68f5343beaa03133de4bbba9b4d8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23273: MigrationRecorder does not obey db_router allow_migrate rules

[Django]

#23273: MigrationRecorder does not obey db_router allow_migrate rules
+
 Reporter:  froomzy |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by Daniel van Flymen):

 Can you please have a look at http://stackoverflow.com/questions/40893868
 /using-redshift-as-an-additional-django-
 database?noredirect=1#comment69004673_40893868, which provides a decent
 use case for this bug.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4847680efe791f94662a7a1178a2cf3a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27558: Setting db_index=False on existing ForeignKey causes constraint to be recreated on MySQL (was: Setting db_index=False on existing ForeignKey causes constraint to be recreated)

[Django]

#27558: Setting db_index=False on existing ForeignKey causes constraint to be
recreated on MySQL
-+-
 Reporter:  Ed Morley|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  db-indexes, mysql| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


Comment:

 A less invasive fix for 1.10 is probably needed as the changing and adding
 of methods in that commit looks a bit risky for a stable release. The
 regression test can also be added to master.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7343a74c9243a10d0c79872ac03c3209%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27558: Setting db_index=False on existing ForeignKey causes constraint to be recreated

[Django]

#27558: Setting db_index=False on existing ForeignKey causes constraint to be
recreated
-+-
 Reporter:  Ed Morley|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  db-indexes, mysql| Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ed Morley):

 Ah thank you!

 Bisecting shows the redundant index issue was fixed as of:
 
https://github.com/django/django/commit/3f76d1402dac9c2993d588f996dc1c331edbc9a7

 Whilst the change to `add_field()` in `django/db/backends/base/schema.py`
 might look like a no-op (since the `_field_should_be_indexed()` method in
 that file does the same thing as the lines being replaced), it actually
 wasn't - since mysql overrides the base `self._field_should_be_indexed()`
 with it's own that handles `ForeignKey` properly:
 
https://github.com/django/django/blob/3f76d1402dac9c2993d588f996dc1c331edbc9a7/django/db/backends/mysql/schema.py#L54-L67

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.cfcbb145e4b44349760e78a941b96af3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27541: Provide hooks to override manifest file storage in ManifestFilesMixin

[Django]

#27541: Provide hooks to override manifest file storage in ManifestFilesMixin
-+
 Reporter:  Ryan Lopopolo|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.staticfiles  |  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Tim Graham):

 * needs_docs:  0 => 1
 * has_patch:  0 => 1
 * needs_tests:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 It might be fine, I've not done much work with that code to say if there
 might be a better design. Anyway, at least docs and tests are also needed.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e01a453264eaea6bde65865599ad7e2f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27548: Documentation missing section about adding your app to INSTALLED_APPS in settings

[Django]

#27548: Documentation missing section about adding your app to INSTALLED_APPS in
settings
+--
 Reporter:  nvrrdt  |Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  Documentation   |  Version:  1.10
 Severity:  Normal  |   Resolution:  needsinfo
 Keywords:  INSTALLED_APPS  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => needsinfo


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c23d3838f913bc2a13468ec9aba1056c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27557: Overzealous GEOSGeometry sub-subclasses casts

[Django]

#27557: Overzealous GEOSGeometry sub-subclasses casts
-+-
 Reporter:  Claude Paroz |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"cc9e4297019bcec9fe0fee2199aa30fb1f6e90b7" cc9e4297]:
 {{{
 #!CommitTicketReference repository=""
 revision="cc9e4297019bcec9fe0fee2199aa30fb1f6e90b7"
 Fixed #27557 -- Casted GEOSGeometry only when necessary

 Thanks Pete Flugstad for the report, and Tim Graham for the review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.5111b7e03418f3d53ec89b5bd69e6e2f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27473: Allow using Extract() with DurationField

[Django]

#27473: Allow using Extract() with DurationField
-+-
 Reporter:  Daniel Hahler|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f0277b57210ff10ff6b2f6d22340ccbb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27556: add Oracle support for IsValid function and isvalid lookup

[Django]

#27556: add Oracle support for IsValid function and isvalid lookup
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  New feature  |   Status:  closed
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"4464b9b9ad9da921f8b50b4e7e26bb4233e05ca0" 4464b9b9]:
 {{{
 #!CommitTicketReference repository=""
 revision="4464b9b9ad9da921f8b50b4e7e26bb4233e05ca0"
 Fixed #27556 -- Added Oracle support for IsValid function and isvalid
 lookup.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.075ddd86e3a22e901c03c2356f23ac86%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24245: Add introspection for database defaults

[Django]

#24245: Add introspection for database defaults
-+-
 Reporter:  Tim Graham   |Owner:  Tim
 |  Graham
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"e17f40f4b55f5bf624a190e67a0c83af4be043b8" e17f40f4]:
 {{{
 #!CommitTicketReference repository=""
 revision="e17f40f4b55f5bf624a190e67a0c83af4be043b8"
 Refs #24245 -- Added introspection for database defaults on Oracle.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.da64097a8e4d8f218881e90436beb2e4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27554: Queryset evaluation fails with mix of nested and flattened prefetches (AttributeError on RelatedManager)

[Django]

#27554: Queryset evaluation fails with mix of nested and flattened prefetches
(AttributeError on RelatedManager)
-+-
 Reporter:  Anthony Leontiev |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  prefetch | Triage Stage:  Accepted
  AttributeError prefetch_related|
  nested RelatedManager  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Vimarsh Chaturvedi):

 Hey guys,

 My first time posting here.

 I tried reproducing the bug, and was able to.
 I added the following cases as per Simon Charette's suggestion and Django
 didn't throw any exception.

 views.py
 {{{
 #Code in orinigal test project by Anthony Leontiev
 def setup():
 a = A.objects.create()
 b = B.objects.create()

 b.a = a
 b.save()

 d = D.objects.create()
 C.objects.create(b=b, d=d)


 #Succeeded: As reported above.
 def nested_prefetch(request, *args, **kwargs):
 setup()
 queryset = A.objects.all().prefetch_related(
 Prefetch(
 'b',
 queryset=B.objects.all().prefetch_related(
 Prefetch(
 'c',
 queryset=C.objects.all().prefetch_related(
 'd'
 )
 )
 )
 )
 )
 content = queryset[0].b.c.all()[0].d.pk
 return HttpResponse(content)

 #Failed: As reported above.
 def flat_prefetch(request, *args, **kwargs):
 setup()
 queryset = A.objects.all().prefetch_related(
 Prefetch(
 'b',
 queryset=B.objects.all().prefetch_related(
 Prefetch('c__d')
 )
 )
 )
 content = queryset[0].b.c.all()[0].d.pk
 return HttpResponse(content)

 #The following three cases were added by me
 #Failed: As expected.
 def flat_prefetch_one(request, *args, **kwargs):
 setup()
 queryset = A.objects.all().prefetch_related(
 Prefetch(
 'b',
 queryset=B.objects.all().prefetch_related('c__d')
 )
 )
 content = queryset[0].b.c.all()[0].d.pk
 return HttpResponse(content)

 #Succeeded: I  was expecting this and the following case to fail too, but
 they didn't.
 def flat_prefetch_two(request, *args, **kwargs):
 setup()
 queryset = A.objects.all().prefetch_related(
 Prefetch('b__c__d')
 )
 content = queryset[0].b.c.all()[0].d.pk
 return HttpResponse(content)

 #succeeded
 def flat_prefetch_three(request, *args, **kwargs):
 setup()
 queryset = A.objects.all().prefetch_related('b__c__d')
 content = queryset[0].b.c.all()[0].d.pk
 return HttpResponse(content)
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.926de2e6ca7483ab6e1e44a5105ba07a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27558: Setting db_index=False on existing ForeignKey causes constraint to be recreated

[Django]

#27558: Setting db_index=False on existing ForeignKey causes constraint to be
recreated
-+-
 Reporter:  Ed Morley|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  db-indexes, mysql| Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 If it's a big performance problem, we can likely consider a backport as
 long as the patch isn't too complex. Could you try bisecting to find the
 commit that fixed it?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c2f0d0ae820b25f68ec60182c5b0bd0f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27557: Overzealous GEOSGeometry sub-subclasses casts

[Django]

#27557: Overzealous GEOSGeometry sub-subclasses casts
-+-
 Reporter:  Claude Paroz |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e15169d2ca00abadbc97a7750d613e39%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27558: Setting db_index=False on existing ForeignKey causes constraint to be recreated

[Django]

#27558: Setting db_index=False on existing ForeignKey causes constraint to be
recreated
-+-
 Reporter:  Ed Morley|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  db-indexes, mysql| Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ed Morley):

 As a workaround in the meantime, I was thinking of replacing the auto-
 generated migration with something like:
 {{{#!python
 migrations.RunSQL(
 "DROP INDEX `` ON `foo_album`;",
 state_operations=[
 migrations.AlterField(
 model_name='album',
 name='artist',
 field=models.ForeignKey(db_index=False,
 on_delete=django.db.models.deletion.CASCADE, to='foo.Musician'),
 ),
 ],
 )
 }}}

 However I haven't yet figured out the best way to get the existing index
 name from Django.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.2cad2468fb5f0eec5b1a7cb20b1f230a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27556: add Oracle support for IsValid function and isvalid lookup

[Django]

#27556: add Oracle support for IsValid function and isvalid lookup
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  New feature  |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.22514415bfef73d5d399817adf52d0c4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #27558: Setting db_index=False on existing ForeignKey causes constraint to be recreated

[Django]

#27558: Setting db_index=False on existing ForeignKey causes constraint to be
recreated
-+-
   Reporter:  Ed Morley  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Database   |Version:  1.10
  layer (models, ORM)|
   Severity:  Normal |   Keywords:  db-indexes, mysql
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Using:
 * Django 1.10.3
 * MySQL 5.6

 STR:
 1) Start with this models.py:
 {{{#!python
 class Musician(models.Model):
 first_name = models.CharField(max_length=50)
 last_name = models.CharField(max_length=50)


 class Album(models.Model):
 artist = models.ForeignKey(Musician)
 name = models.CharField(max_length=100)

 class Meta:
 unique_together = ('artist', 'name')
 }}}

 2) Run `./manage.py makemigrations && ./manage.py migrate` to generate and
 apply the initial migration.
 3) Add `db_index=False` to the `ForeignKey` (to work around the duplicate
 index issue discussed [https://groups.google.com/forum/#!topic/django-
 developers/3ywugkcaxqs here]) - making it:
 {{{#!python
 artist = models.ForeignKey(Musician, db_index=False)
 }}}
 4) Run `./manage.py makemigrations`
 5) Run `./manage.py sqlmigrate  0002` to display the generated SQL

 Expected:
 Just the index is dropped.

 {{{#!sql
 BEGIN;
 --
 -- Alter field artist on album
 --
 DROP INDEX `foo_album_ca949605` ON `foo_album`;
 COMMIT;
 }}}

 Actual:

 The constraint is removed and re-added, which is time consuming since the
 constraint is an index in itself.

 {{{#!sql
 BEGIN;
 --
 -- Alter field artist on album
 --
 ALTER TABLE `foo_album` DROP FOREIGN KEY
 `foo_album_artist_id_66b4953c_fk_foo_musician_id`;
 DROP INDEX `foo_album_ca949605` ON `foo_album`;
 ALTER TABLE `foo_album` ADD CONSTRAINT
 `foo_album_artist_id_66b4953c_fk_foo_musician_id` FOREIGN KEY
 (`artist_id`) REFERENCES `foo_musician` (`id`);
 COMMIT;
 }}}

 Additional context:
 * The explicit `db_index=False` is needed to work around the duplicate
 index issue discussed [https://groups.google.com/forum/#!topic/django-
 developers/3ywugkcaxqs here].
 * The duplicate index issue appears to be fixed on master (not sure by
 what) causing this not to repro there.
 * I'm presuming the duplicate index isn't severe enough to warrant
 backporting, however dropping and re-adding the constraint seems pretty
 bad, so perhaps more worthy of a backport to 1.10.x?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.6576ba91863e1b8292ce44df44aa2610%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16859: CSRF Improvements

[Django]

#16859: CSRF Improvements
-+-
 Reporter:  Paul McMillan|Owner:  Paul
 Type:   |  McMillan
  Cleanup/optimization   |   Status:  new
Component:  CSRF |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * has_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.4d775e244cd39d058627027d8af63e71%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16859: CSRF Improvements

[Django]

#16859: CSRF Improvements
-+-
 Reporter:  Paul McMillan|Owner:  Paul
 Type:   |  McMillan
  Cleanup/optimization   |   Status:  new
Component:  CSRF |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"ddf169cdaca91e92dd5bfe6796bb6f38369ecb68" ddf169c]:
 {{{
 #!CommitTicketReference repository=""
 revision="ddf169cdaca91e92dd5bfe6796bb6f38369ecb68"
 Refs #16859 -- Allowed storing CSRF tokens in sessions.

 Major thanks to Shai for helping to refactor the tests, and to
 Shai, Tim, Florian, and others for extensive and helpful review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.6ddb77f6d108d25914d04012ae91e079%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27556: add Oracle support for IsValid function and isvalid lookup

[Django]

#27556: add Oracle support for IsValid function and isvalid lookup
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  New feature  |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.a0c6bfb7f717aa2db7c444ba2b9e57a0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27552: add docs/tests for GEOSGeometry.normalize()

[Django]

#27552: add docs/tests for GEOSGeometry.normalize()
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 Type:   |  Fedoseev
  Cleanup/optimization   |   Status:  closed
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"21322f92710a447708409f1fce52ee9d18752eaf" 21322f92]:
 {{{
 #!CommitTicketReference repository=""
 revision="21322f92710a447708409f1fce52ee9d18752eaf"
 Fixed #27552 -- Added docs/test for GEOSGeometry.normalize().
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.21d043faf7930a6cd45b1c899899e73a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27557: Overzealous GEOSGeometry sub-subclasses casts

[Django]

#27557: Overzealous GEOSGeometry sub-subclasses casts
--+
 Reporter:  Claude Paroz  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  GIS   |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Claude Paroz):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/7640 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.dfacfeb804ff7315b2cda943f8d93d5e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27543: AttributeError: '_Frame' object has no attribute 'f_back' / Django and celery error logging gone wrong

[Django]

#27543: AttributeError: '_Frame' object has no attribute 'f_back' / Django and
celery error logging gone wrong
-+-
 Reporter:  Simon Chenard|Owner:  (none)
 Type:  Bug  |   Status:  closed
Component:  Error reporting  |  Version:  1.10
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  celery logging   | Triage Stage:
  traceback  |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Chenard):

 In the end I couldn't completely understand the relationship between
 django and celery - but since it does only happens when celery is
 involved, it's most likely not a issue on Django's side.

 But for the record, if anyone else stumble on a similar case, what I did
 end up doing is sub-classing the AdminEmailHandler and use python's own
 traceback library, if the exception described earlier is raised.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.88a2b80850f01bd0f41d4fd3cd16d4ee%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #27557: Overzealous GEOSGeometry sub-subclasses casts

[Django]

#27557: Overzealous GEOSGeometry sub-subclasses casts
+
   Reporter:  Claude Paroz  |  Owner:  nobody
   Type:  Bug   | Status:  new
  Component:  GIS   |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Reported by Pete Flugstad in
 https://groups.google.com/forum/#!topic/geodjango/-tao0uPNYY8

 When writing a Point, Polygon, etc. subclass, the parent
 `GEOSGeometry._post_init` is force casting the instance to one of the
 hardcoded GEOSGeometry subclass, which breaks method overriding of the
 subclass.

 Example:
 {{{
 from django.contrib.gis.geos import Polygon

 class ExtendedPolygon(Polygon):
 def __init__(self, point_list, data=0 ):
 super(ExtendedPolygon, self).__init__(point_list)
 self._data = data

 def __str__(self):
 return "EXT_POLYGON - data: %d - %s" % (self._data, self.wkt )
 }}}

 {{{
 >>> from extpoly import ExtendedPolygon
 >>> points = ((-75.1, 34.3), (-74.9, 34.3), (-74.9, 34.4), (-75.1, 34.4),
 (-75.1, 34.3))
 >>> ex = ExtendedPolygon( points, altitude=123, speed=456, direction=789 )
 >>> print(ex)
 POLYGON ((-75.09 34.3, -74.91 34.3,
 -74.91 34.4, -75.09 34.4, -75.09
 34.3))
 >>> type(ex)
 
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.d3ad10beaed91547d6a42dbb4e4693e1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27556: add Oracle support for IsValid function and isvalid lookup

[Django]

#27556: add Oracle support for IsValid function and isvalid lookup
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  New feature  |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sergey Fedoseev):

 * has_patch:  0 => 1


Old description:



New description:

 [https://github.com/django/django/pull/7637 PR]

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.48e2d39309dde710465c245f3aa20ea2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27556: add Oracle support for IsValid function and isvalid lookup (was: add Oracle suppport for IsValid function and isvalid lookup)

[Django]

#27556: add Oracle support for IsValid function and isvalid lookup
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  New feature  |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sergey Fedoseev):

 * status:  new => assigned
 * owner:  nobody => Sergey Fedoseev


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.d955fb166cf1fe32588ec073e0225e0b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #27556: add Oracle suppport for IsValid function and isvalid lookup

[Django]

#27556: add Oracle suppport for IsValid function and isvalid lookup
---+
   Reporter:  Sergey Fedoseev  |  Owner:  nobody
   Type:  New feature  | Status:  new
  Component:  GIS  |Version:  master
   Severity:  Normal   |   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.22c03fead86d4fd07d774351c988da27%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.