Re: [Django] #23919: Cleanups for when we drop Python 2 compatibility

2017-01-28 Thread Django
#23919: Cleanups for when we drop Python 2 compatibility
--+
 Reporter:  Tim Graham|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Josh Smeaton):

 I had an attempt at dropping the creation_counter for model fields, but I
 *think* it might be more costly than the current method, considering so
 many things rely on the order being consistent. My attempt was here, with
 associated discussion I'll copy some of below:
 https://github.com/django/django/pull/7983

 > I'm not sure this is worth continuing with, at least not in the same
 way. Too many systems rely on the fields being ordered, which isn't going
 to be possible without maintaining another list of fields such as
 definition_order = []. This can be done for local fields, but then
 proxy/parent fields will need to be returned in the same definition order.
 This might be something like:

 {{{
 parent_fields + [field for field in self.definition_order if field in
 local_fields]
 }}}

 > Then we'd need to account for private and hidden fields. But what's the
 point? We'd now be storing a separate list of all field references for
 each model, rather than a counter (int) on each field, and reordering
 fields in _get_fields() whether or not they need to be ordered. Of course
 I'd be happy to see a better solution that worked, I'm just giving up on
 this particular method for the moment.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0f7fbe633f26c93287d58e37fbd4d2e3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27787: call_command() should validate the arguments it receives

2017-01-28 Thread Django
#27787: call_command() should validate the arguments it receives
-+-
 Reporter:  Tim Graham   |Owner:  Srinivas
 Type:   |  Reddy Thatiparthy
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Chandrakant Kumar):

 * needs_tests:  1 => 0


Comment:

 https://github.com/django/django/pull/7979

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d06b0cb6c9683a07ad7cfb1662d31165%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27683: Change default transaction isolation level to READ COMMITTED on MySQL

2017-01-28 Thread Django
#27683: Change default transaction isolation level to READ COMMITTED on MySQL
-+-
 Reporter:  Shai Berger  |Owner:  Shai
 Type:   |  Berger
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/7978 PR] to change the default
 isolation to read committed.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.1ea67bf421cdd72ec87af400e682476c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #23908: XHTML breaks admin site

2017-01-28 Thread Django
#23908: XHTML breaks admin site
-+-
 Reporter:  Brian May|Owner:  Anton
 |  Samarchyan
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 The consensus on the mailing list is toward deprecating the
 `DEFAULT_CONTENT_TYPE` setting. Do you have a use case that argues against
 that which you could add to the discussion, Brian?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.409330827979fc04f8f5faf35aaafdf7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #26708: Update the contributing tutorial to use GitHub workflow

2017-01-28 Thread Django
#26708: Update the contributing tutorial to use GitHub workflow
-+-
 Reporter:  Nina Zakharenko  |Owner:
 Type:   |  Subhrajyoti Sen
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"b183abfc8d09ecc1ee4ace4e0c6d11bd9d42b2fb" b183abf]:
 {{{
 #!CommitTicketReference repository=""
 revision="b183abfc8d09ecc1ee4ace4e0c6d11bd9d42b2fb"
 [1.11.x] Fixed #26708 -- Updated the contributing tutorial to use a GitHub
 workflow.

 Backport of f5bf11c72b267d717dd4379ec80f9f7c5185f80f from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.59fc0eb5729792411d571c1054e7e7a6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #26708: Update the contributing tutorial to use GitHub workflow

2017-01-28 Thread Django
#26708: Update the contributing tutorial to use GitHub workflow
-+-
 Reporter:  Nina Zakharenko  |Owner:
 Type:   |  Subhrajyoti Sen
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"a52b223f74eab7a6ddaa855c2ad30fde4cdf397a" a52b223]:
 {{{
 #!CommitTicketReference repository=""
 revision="a52b223f74eab7a6ddaa855c2ad30fde4cdf397a"
 [1.10.x] Fixed #26708 -- Updated the contributing tutorial to use a GitHub
 workflow.

 Backport of f5bf11c72b267d717dd4379ec80f9f7c5185f80f from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.d013566d5163f3d4abfe458ba8d5a164%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #26708: Update the contributing tutorial to use GitHub workflow

2017-01-28 Thread Django
#26708: Update the contributing tutorial to use GitHub workflow
-+-
 Reporter:  Nina Zakharenko  |Owner:
 Type:   |  Subhrajyoti Sen
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"f5bf11c72b267d717dd4379ec80f9f7c5185f80f" f5bf11c7]:
 {{{
 #!CommitTicketReference repository=""
 revision="f5bf11c72b267d717dd4379ec80f9f7c5185f80f"
 Fixed #26708 -- Updated the contributing tutorial to use a GitHub
 workflow.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.4edbb41bb6a0ec72162c63e5bfd40aa4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27790: Investigate increased memory usage in tests when calling migrate without available_apps set

2017-01-28 Thread Django
#27790: Investigate increased memory usage in tests when calling migrate without
available_apps set
--+
 Reporter:  Tim Graham|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"aa52e8b77b9680581ff47a0e5e8046ba289bd59f" aa52e8b7]:
 {{{
 #!CommitTicketReference repository=""
 revision="aa52e8b77b9680581ff47a0e5e8046ba289bd59f"
 [1.11.x] Refs #27790 -- Reverted "Removed available_apps on TestCase
 subclasses."

 This reverts commit 91023d79ec70df9289271e63a67675ee51e7dea8 as it
 increases memory usage for the test suite.

 Backport of 7d50d2bcb8a3cf3fea727174717ead7e6508e9e2 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e00b509435018fbbeb027ecfd40d145d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27753: Cleanups when no supported version of Django supports Python 2 anymore

2017-01-28 Thread Django
#27753: Cleanups when no supported version of Django supports Python 2 anymore
-+-
 Reporter:  Aymeric Augustin |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Claude Paroz:

Old description:

> Compatibility with Python 2 is currently being removed in master as part
> of the Django 2.0 development cycle: see #23919.
>
> However third-party apps may want to remain compatible with all supported
> version of Django and the corresponding versions of Python, which
> includes Python 2.
>
> To allow this, compatibility functions or modules aren't removed. They're
> still importable. They're usually just aliases or no-ops. Here's a list
> of things to deprecate and remove eventually:
>
> - django.utils.six
> - django.utils.lru_cache
> - django.utils._os.abspathu, upath, npath
> - django.utils.decorators.available_attrs
> - django.utils.encoding.python_2_unicode_compatible
> - django.utils.encoding.smart/force_text
> - django.utils.http.urlquote/urlquote_plus/urlunquote/urlunquote_plus
> ([https://github.com/django/django/pull/7906/commits/5861ce799ddb3f5912f9e16503d4239fa9d80e66
> unmerged commit])

New description:

 Compatibility with Python 2 is currently being removed in master as part
 of the Django 2.0 development cycle: see #23919.

 However third-party apps may want to remain compatible with all supported
 version of Django and the corresponding versions of Python, which includes
 Python 2.

 To allow this, compatibility functions or modules aren't removed. They're
 still importable. They're usually just aliases or no-ops. Here's a list of
 things to deprecate and remove eventually:

 - django.utils.six
 - django.utils.lru_cache
 - django.utils._os.abspathu, upath, npath
 - django.utils.decorators.available_attrs
 - django.utils.encoding.python_2_unicode_compatible
 - django.utils.encoding.smart/force_text
 - django.utils.http.urlquote/urlquote_plus/urlunquote/urlunquote_plus
 
([https://github.com/django/django/pull/7906/commits/5861ce799ddb3f5912f9e16503d4239fa9d80e66
 unmerged commit])
 - django.utils.safestring.SafeBytes

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b8b5857cd21afa10e5e1faab897d48c8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27790: Investigate increased memory usage in tests when calling migrate without available_apps set

2017-01-28 Thread Django
#27790: Investigate increased memory usage in tests when calling migrate without
available_apps set
--+
 Reporter:  Tim Graham|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"7d50d2bcb8a3cf3fea727174717ead7e6508e9e2" 7d50d2b]:
 {{{
 #!CommitTicketReference repository=""
 revision="7d50d2bcb8a3cf3fea727174717ead7e6508e9e2"
 Refs #27790 -- Reverted "Removed available_apps on TestCase subclasses."

 This reverts commit 91023d79ec70df9289271e63a67675ee51e7dea8 as it
 increases memory usage for the test suite.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.541ea5e701591baadfdaefee58194930%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #26993: Increase the length of the User model's last_name field to 150 characters

2017-01-28 Thread Django
#26993: Increase the length of the User model's last_name field to 150 
characters
-+-
 Reporter:  Malcolm Box  |Owner:  Thom
 Type:   |  Wiggers
  Cleanup/optimization   |   Status:  closed
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"d5b573d872bbe0d5825efaee2d41cb3cdc75417b" d5b573d]:
 {{{
 #!CommitTicketReference repository=""
 revision="d5b573d872bbe0d5825efaee2d41cb3cdc75417b"
 Fixed #26993 -- Increased User.last_name max_length to 150 characters.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.aa9e615296749106cd1d6f2e6d7f45c6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #27790: Investigate increased memory usage in tests when calling migrate without available_apps set

2017-01-28 Thread Django
#27790: Investigate increased memory usage in tests when calling migrate without
available_apps set
+
   Reporter:  Tim Graham|  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Migrations|Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 91023d79ec70df9289271e63a67675ee51e7dea8 increased memory usage of the
 test suite. I've created a [https://github.com/django/django/pull/7972 PR]
 to revert it but the root cause should be investigated.

 I added these lines at the end of `runtests.py` to measure memory usage
 (may be a naive solution):
 {{{
 import resource
 print(resource.getrusage(resource.RUSAGE_SELF).ru_maxrss / 1000)
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.6fce8440337d46e3e53868db384b831f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27130: Allow using the DjangoTemplates engine without configuring settings

2017-01-28 Thread Django
#27130: Allow using the DjangoTemplates engine without configuring settings
-+-
 Reporter:  Al Johri |Owner:  reficul31
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by reficul31):

 Thank you Aymeric for taking out the time and explaining the issue. I get
 the concept now. I guess an upgrade to the docs might help the other users
 see the it more clearly too.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6646972eeac85a28cd29de3814ff60b0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27789: Simplified get sequence value on Oracle.

2017-01-28 Thread Django
#27789: Simplified get sequence value on Oracle.
-+-
 Reporter:  felixxm  |Owner:  felixxm
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Ready for checkin


Comment:

 [https://github.com/django/django/pull/7975 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.1997ac74e380f030a28b7257e4424517%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27788: Drop support for Oracle < 12.1

2017-01-28 Thread Django
#27788: Drop support for Oracle < 12.1
-+-
 Reporter:  Tim Graham   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"0de0699d94ccd078c83eadef296a0d9ccd65a62f" 0de0699]:
 {{{
 #!CommitTicketReference repository=""
 revision="0de0699d94ccd078c83eadef296a0d9ccd65a62f"
 Fixed #27788 -- Dropped support for Oracle < 12.1.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.622f1225a556bde1634fe6c2a927a301%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27130: Allow using the DjangoTemplates engine without configuring settings

2017-01-28 Thread Django
#27130: Allow using the DjangoTemplates engine without configuring settings
-+-
 Reporter:  Al Johri |Owner:  reficul31
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Aymeric Augustin):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 Perhaps this analogy will help:

 django.template.Engine ~ sqlite3.connect
 django.template.backends.django.DjangoTemplates ~
 django.db.backends.sqlite3.base.DatabaseWrapper

 The two live in the same namespace for historical reasons. Moving the
 implementation of the engine outside of `django.template` would be
 backwards incompatible for no significant benefit.

 I wrote a
 [https://github.com/django/django/blob/master/django/template/__init__.py
 large docstring] to clarify which modules belong to the standalone
 template engine and which modules allow using arbitrary backends with a
 unified API. See also DEP 182.

 

 Replying to [comment:14 reficul31]:

 > I read over the docs of the django.template.engine and knew that it
 worked in standalone mode.

 If you think the docs could state more clearly that this is the API to use
 if you want to use the Django template engine in standalone mode, let's
 improve them.

 (Since it's hard to figure out how docs that you wrote yourself could be
 unclear to others, I'm not in the best position to do that.)

 > I thought the gist of the ticket was to provide DjangoTemplates with
 that functionality too.

 Unfortunately, it was incorrectly accepted based on a misunderstanding. It
 should have been closed as wontfix. I realized the problem only when I saw
 your PR.

 > I might be wrong but is it a functionality that could cause problems?

 Yes, it would worsen the problem that the existence of this ticket
 demonstrates.

 Even though the documentation is unambiguous, there's already some
 confusion between the concepts of "template engine" (any library that can
 render templates) and "template backend" (a thin integration layer for
 configuring a template engine from Django settings). Adding to the
 ambiguity by blurring the roles of Engine and DjangoTemplates would
 increase confusion.

 > Eg. For most of my projects I use DjangoTemplates backend and it would
 be nice if i could test my templates on it.

 DjangoTemplates is nothing more than an Engine configured from Django
 settings. Here's the whole implementation:

 {{{
 def __init__(self, params):
 params = params.copy()
 options = params.pop('OPTIONS').copy()
 options.setdefault('autoescape', True)
 options.setdefault('debug', settings.DEBUG)
 options.setdefault('file_charset', settings.FILE_CHARSET)
 libraries = options.get('libraries', {})
 options['libraries'] = self.get_templatetag_libraries(libraries)
 super().__init__(params)
 self.engine = Engine(self.dirs, self.app_dirs, **options)
 }}}

 and then there's a couple methods that forward to the corresponding
 methods on Engine.

 If your projet uses Django settings and the DjangoTemplates backend, then
 your tests should use Django settings as well, and there's no use making
 DjangoTemplates work without settings.

 If your projet doesn't use Django settings and configures an Engine in
 standalone mode, then you don't use DjangoTemplates, not does it make any
 sense, since you don't have Django settings.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4f6b233219f7168128874750247ee927%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27787: call_command() should validate the arguments it receives

2017-01-28 Thread Django
#27787: call_command() should validate the arguments it receives
-+-
 Reporter:  Tim Graham   |Owner:  Srinivas
 Type:   |  Reddy Thatiparthy
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * needs_tests:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e71b5f6425c2ccdb58b8a2ccaf60ed4b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #26993: Increase the length of the User model's last_name field to 150 characters

2017-01-28 Thread Django
#26993: Increase the length of the User model's last_name field to 150 
characters
-+-
 Reporter:  Malcolm Box  |Owner:  Thom
 Type:   |  Wiggers
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Thom Wiggers):

 As an aside: maybe it is a good idea to make this same change for first
 names. There's probably going to be someone who breaks the current limit,
 either with or without including middle names.

 E.g. there's some guy named "James  Bond"* according
 to [http://mentalfloss.com/article/18271/names-too-long-name-tags-even-
 comically-oversized-ones some clickbait site].

 Maybe this is more something for another mailing list discussion to reach
 some concensus though: in that case it's probably more something for a new
 issue.

 * I got hit by the spam filter.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.c056660bf002b1a0451d4e907f5a2902%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #26993: Increase the length of the User model's last_name field to 150 characters (was: Increase the length of the User model's last_name field to 100 characters)

2017-01-28 Thread Django
#26993: Increase the length of the User model's last_name field to 150 
characters
-+-
 Reporter:  Malcolm Box  |Owner:  Thom
 Type:   |  Wiggers
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Thom Wiggers):

 * needs_better_patch:  1 => 0


Comment:

 I have incorporated Tim's feedback. Details are available on the PR. Tim
 also suggested going for 150 chars, that's fine by me (edited title
 accordingly).

 I'm unsetting 'Patch needs improvement' as I think that should make it
 show up for review again in Trac.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.e448fca389ab9b4ab83b8da00dd30077%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27787: call_command() should validate the arguments it receives

2017-01-28 Thread Django
#27787: call_command() should validate the arguments it receives
-+-
 Reporter:  Tim Graham   |Owner:  Srinivas
 Type:   |  Reddy Thatiparthy
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Chandrakant Kumar):

 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/7976

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1a063003d74e7b38c954e08cd4e4117b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27604: Use set_signed_cookie for contrib.messages Cookie storage

2017-01-28 Thread Django
#27604: Use set_signed_cookie for contrib.messages Cookie storage
--+
 Reporter:  Anthony King  |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.messages  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by reficul31):

 * owner:  reficul31 => (none)
 * status:  assigned => new


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f8c2118673c9b293b6faced8ce8d0047%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #27789: Simplified get sequence value on Oracle.

2017-01-28 Thread Django
#27789: Simplified get sequence value on Oracle.
-+-
   Reporter:  felixxm|  Owner:  felixxm
   Type: | Status:  assigned
  Cleanup/optimization   |
  Component:  Database   |Version:  master
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+-
 I propose to use explicit
 {{{#!sql
 seq_value := sequence.nextval;
 }}}
 instead of
 {{{#!sql
 SELECT sequence.nextval INTO seq_value FROM dual
 }}}
 It is valid since Oracle 11g.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.31a5fd82986dceaa97345c57aff43b11%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27788: Drop support for Oracle < 12.1

2017-01-28 Thread Django
#27788: Drop support for Oracle < 12.1
-+-
 Reporter:  Tim Graham   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f3729c1ef0160bbd4fb517620f2468f0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.