date:20170407

Re: [Django] #28042: mimetype Fallback for attachments passed to EmailMessage.init removed

2017-04-07 Thread Django

#28042: mimetype Fallback for attachments passed to EmailMessage.__init__ 
removed
-+
 Reporter:  Dariusz Paluch   |Owner:  Nikolay
 Type:  Bug  |   Status:  closed
Component:  Core (Mail)  |  Version:  1.11
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by Tim Graham ):

 In [changeset:"734e6bb2b884eb4681954e1d0c01097fe167f558" 734e6bb2]:
 {{{
 #!CommitTicketReference repository=""
 revision="734e6bb2b884eb4681954e1d0c01097fe167f558"
 [1.11.x] Fixed #28042 -- Fixed crash when using a two-tuple in
 EmailMessage's attachments arg.

 Backport of dd001848920713fe616c03db6946762e8aa7c4e3 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.bd1548d401951e6b83373fa854f9a730%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28042: mimetype Fallback for attachments passed to EmailMessage.init removed

2017-04-07 Thread Django

#28042: mimetype Fallback for attachments passed to EmailMessage.__init__ 
removed
-+
 Reporter:  Dariusz Paluch   |Owner:  Nikolay
 Type:  Bug  |   Status:  closed
Component:  Core (Mail)  |  Version:  1.11
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"dd001848920713fe616c03db6946762e8aa7c4e3" dd00184]:
 {{{
 #!CommitTicketReference repository=""
 revision="dd001848920713fe616c03db6946762e8aa7c4e3"
 Fixed #28042 -- Fixed crash when using a two-tuple in EmailMessage's
 attachments arg.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b2a69f9de0e5f5cadda5cab1080b1599%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26605: Abstract model inheriting concrete model crashes migrations

2017-04-07 Thread Django

#26605: Abstract model inheriting concrete model crashes migrations
--+
 Reporter:  Sébastien Diemer  |Owner:  Ingo Klöcker
 Type:  Bug   |   Status:  closed
Component:  Migrations|  Version:  1.8
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * status:  assigned => closed
 * resolution:   => fixed


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.ea2feb30ef3855dc25da424fd1193b54%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28055: Staticfiles HashedFilesMixin postprocess optimization

2017-04-07 Thread Django

Comment (by David Sanders):

There definitely appears to be a duplicate delete and save around

[https://github.com/django/django/blob/master/django/contrib/staticfiles/storage.py#L304
line 304], I'm not sure how that slipped through code review. Must have
been introduced during some refactoring of the code.

It should be possible to clean up that section and trim the extra
delete/save. Might be possible to also drop a save if the hash hasn't
changed as well since the hash can be calculated from the ContentFile
without saving it to disk. Since the tests now expect the correct hashes
(and have a few more cases) as long as tests pass it should be fairly
safe. I don't have the time to look at it deeply, however.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.2eac75dd0db55138e0d7a7b5fa7c3fd0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28038: Cast regression in PostgresSQL using built-in lookups

2017-04-07 Thread Django

#28038: Cast regression in PostgresSQL using built-in lookups
-+-
 Reporter:  Peter J. Farrell |Owner:  Simon
 |  Charette 
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  postgres postgresql  | Triage Stage:  Ready for
  array_agg  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette ):

 In [changeset:"5d35e8eb0681161f5bc3c0dc2acee68c58786c79" 5d35e8eb]:
 {{{
 #!CommitTicketReference repository=""
 revision="5d35e8eb0681161f5bc3c0dc2acee68c58786c79"
 [1.11.x] Fixed #28038 -- Restored casting to text of builtin lookups on
 PostgreSQL.

 Reverted 658f1e8 which broke code using __icontains's implicit cast to
 ::text
 on ArrayField.

 Thanks Peter J. Farrell for the report.

 Backport of a354c69055fd818e612ce22eaa2da0576a4b89ee from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.afc9ac3ed164648aa51b722c6fd00013%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28038: Cast regression in PostgresSQL using built-in lookups

2017-04-07 Thread Django

#28038: Cast regression in PostgresSQL using built-in lookups
-+-
 Reporter:  Peter J. Farrell |Owner:  Simon
 |  Charette 
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  postgres postgresql  | Triage Stage:  Ready for
  array_agg  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette ):

 * owner:  (none) => Simon Charette 
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"a354c69055fd818e612ce22eaa2da0576a4b89ee" a354c690]:
 {{{
 #!CommitTicketReference repository=""
 revision="a354c69055fd818e612ce22eaa2da0576a4b89ee"
 Fixed #28038 -- Restored casting to text of builtin lookups on PostgreSQL.

 Reverted 658f1e8 which broke code using __icontains's implicit cast to
 ::text
 on ArrayField.

 Thanks Peter J. Farrell for the report.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.bc88843335efce9c01c070971c25cdc5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28055: Staticfiles HashedFilesMixin postprocess optimization

2017-04-07 Thread Django

#28055: Staticfiles HashedFilesMixin postprocess optimization
-+-
 Reporter:  Konrad Lisiczyński   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.staticfiles  |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:  staticfiles  | Triage Stage:  Accepted
  HashedFilesMixin post_process  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * cc: David Sanders (added)


Comment:

 David, maybe you could provide some guidance or explanations here.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.11a2237320c88aa4f15bf6cb181ac991%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28055: Staticfiles HashedFilesMixin postprocess optimization

2017-04-07 Thread Django

#28055: Staticfiles HashedFilesMixin postprocess optimization
-+-
 Reporter:  Konrad Lisiczyński   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.staticfiles  |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:  staticfiles  | Triage Stage:  Accepted
  HashedFilesMixin post_process  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


Comment:

 If you can propose a patch, optimizations would certainly be welcome.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.7ce4708fc90b9e0f7b02720b106c33f8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26605: Abstract model inheriting concrete model crashes migrations

2017-04-07 Thread Django

#26605: Abstract model inheriting concrete model crashes migrations
--+
 Reporter:  Sébastien Diemer  |Owner:  Ingo Klöcker
 Type:  Bug   |   Status:  assigned
Component:  Migrations|  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"67b2b1f116aceee12922d2a8ff832382bca7e8ad" 67b2b1f1]:
 {{{
 #!CommitTicketReference repository=""
 revision="67b2b1f116aceee12922d2a8ff832382bca7e8ad"
 Refs #26605 -- Added migrations state test for a swappable model
 inheriting an abstract model inheriting concrete model.

 Thanks Sébastien Diemer for the report and test.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.593778290f26d7f4116fa7ac7aadcf95%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #9071: Can't disable "add" popup links in the admin

2017-04-07 Thread Django

#9071: Can't disable "add" popup links in the admin
---+---
 Reporter:  Jacob  |Owner:  Dario Ocles
 Type:  New feature|   Status:  closed
Component:  contrib.admin  |  Version:  1.0
 Severity:  Normal |   Resolution:  worksforme
 Keywords:  pyconuk| Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+---

Comment (by Tim Graham):

 Not every use case can have a `ModelAdmin` attribute. To keep complexity
 under control, I think it's better to avoid adding one where an
 alternative exists.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.a02427aab3de4abf45c6888e53f27011%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28038: Cast regression in PostgresSQL using built-in lookups

2017-04-07 Thread Django

#28038: Cast regression in PostgresSQL using built-in lookups
-+-
 Reporter:  Peter J. Farrell |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  postgres postgresql  | Triage Stage:  Ready for
  array_agg  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Peter J. Farrell):

 Replying to [comment:3 Simon Charette]:
 > Anyway, here's the [https://github.com/django/django/pull/8317 PR].

 Thanks for the fix.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.ac4b5383eb8697928bc0d486fc2ae7e6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28055: Staticfiles HashedFilesMixin postprocess optimization

2017-04-07 Thread Django

#28055: Staticfiles HashedFilesMixin postprocess optimization
-+-
 Reporter:  klis87   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.staticfiles  |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:  staticfiles  | Triage Stage:
  HashedFilesMixin post_process  |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by klis87:

Old description:

> Django 1.11 refactored the way how collectstatic postprocessing is
> handled to calculate content based hashes and saving those files.
> Good point of this refactoring is, than now handling of nested css is
> done correctly, for example here, in style.css:
> {{{
> @import 'substyles.css';
>
> body {
>   background-color: green;
> }
> }}}
> when content of substyles.css in changed, the hash of substyles.css will
> also change, which at the same time will change the content of style.css
> (updated for example to @import 'substyles.some-hash.css';) and now
> Django will take into consideration by upgrading hash of style.css as
> well. This is good, and in previous versions of Django hash of style.css
> wouldnt be updated.
>
> However, the problem is, that HashedFilesMixin.postprocess is written in
> such a way, that adjustable_paths, so with the default implementation -
> css files - will be always saved 4 times! Below snippet take from django
> source code explains this:
>
> {{{
> ## Snippet from HashedFilesMixin.post_process
>
> # Do a single pass first. Post-process all files once, then repeat for
> # adjustable files.
> for name, hashed_name, processed, _ in self._post_process(paths,
> adjustable_paths, hashed_files):
> yield name, hashed_name, processed
>
> paths = {path: paths[path] for path in adjustable_paths}
> print('adjusted paths are', paths)
>
> for i in range(self.max_post_process_passes):
> substitutions = False
> for name, hashed_name, processed, subst in self._post_process(paths,
> adjustable_paths, hashed_files):
>

> ## Snippet from HashedFilesMixin._post_process
>
> if name in adjustable_paths:
> old_hashed_name = hashed_name
> content = original_file.read().decode(settings.FILE_CHARSET)
> for extension, patterns in iteritems(self._patterns):
> if matches_patterns(path, (extension,)):
> for pattern, template in patterns:
> converter = self.url_converter(name, hashed_files,
> template)
> try:
> content = pattern.sub(converter, content)
> except ValueError as exc:
> yield name, None, exc, False
> if hashed_file_exists:
> self.delete(hashed_name)
> # then save the processed result
> content_file = ContentFile(force_bytes(content))
> # Save intermediate file for reference
> saved_name = self._save(hashed_name, content_file)
> hashed_name = self.hashed_name(name, content_file)
>
> if self.exists(hashed_name):
> self.delete(hashed_name)
>
> saved_name = self._save(hashed_name, content_file)
> hashed_name = force_text(self.clean_name(saved_name))
> # If the file hash stayed the same, this file didn't change
> if old_hashed_name == hashed_name:
> substitutions = False
> processed = True
> }}}
>
> After looking at the above code carefully, you will see that all css will
> be saved 4 times, even when there is no point doing so in the first
> place, like for example when there is no @import statement in your css. I
> am also not sure why _save method is called twice in _postprocess.
>
> Generally it would't be maybe extremely big problem for staticstorage
> which extends local file storage, but for remote storages like AWS this
> is unacceptable in my opinion. It would be great to change postprocessing
> algorythm to reduce number of save calls to minimum.

New description:

 Django 1.11 refactored the way how collectstatic postprocessing is handled
 to calculate content based hashes and saving those files.
 Good point of this refactoring is, than now handling of nested css is done
 correctly, for example here, in style.css:
 {{{
 @import 'substyles.css';

 body {
   background-color: green;
 }
 }}}
 when content of substyles.css in changed, the hash of substyles.css will
 also change, which at the same time will change the content of style.css
 (updated for example to @import 'substyles.some-hash.css';) and now Django
 will take into consideration by upgrading hash of style.css as well. This
 is good, and in

[Django] #28055: Staticfiles HashedFilesMixin postprocess optimization

2017-04-07 Thread Django

#28055: Staticfiles HashedFilesMixin postprocess optimization
-+-
   Reporter:  klis87 |  Owner:  nobody
   Type: | Status:  new
  Cleanup/optimization   |
  Component: |Version:  1.11
  contrib.staticfiles|   Keywords:  staticfiles
   Severity:  Normal |  HashedFilesMixin post_process
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Django 1.11 refactored the way how collectstatic postprocessing is handled
 to calculate content based hashes and saving those files.
 Good point of this refactoring is, than now handling of nested css is done
 correctly, for example here, in style.css:
 {{{
 @import 'substyles.css';

 body {
   background-color: green;
 }
 }}}
 when content of substyles.css in changed, the hash of substyles.css will
 also change, which at the same time will change the content of style.css
 (updated for example to @import 'substyles.some-hash.css';) and now Django
 will take into consideration by upgrading hash of style.css as well. This
 is good, and in previous versions of Django hash of style.css wouldnt be
 updated.

 However, the problem is, that HashedFilesMixin.postprocess is written in
 such a way, that adjustable_paths, so with the default implementation -
 css files - will be always saved 4 times! Below snippet take from django
 source code explains this:

 {{{
 ## Snippet from HashedFilesMixin.post_process

 # Do a single pass first. Post-process all files once, then repeat for
 # adjustable files.
 for name, hashed_name, processed, _ in self._post_process(paths,
 adjustable_paths, hashed_files):
 yield name, hashed_name, processed

 paths = {path: paths[path] for path in adjustable_paths}
 print('adjusted paths are', paths)

 for i in range(self.max_post_process_passes):
 substitutions = False
 for name, hashed_name, processed, subst in self._post_process(paths,
 adjustable_paths, hashed_files):


 ## Snippet from HashedFilesMixin._post_process

 if name in adjustable_paths:
 old_hashed_name = hashed_name
 content = original_file.read().decode(settings.FILE_CHARSET)
 for extension, patterns in iteritems(self._patterns):
 if matches_patterns(path, (extension,)):
 for pattern, template in patterns:
 converter = self.url_converter(name, hashed_files,
 template)
 try:
 content = pattern.sub(converter, content)
 except ValueError as exc:
 yield name, None, exc, False
 if hashed_file_exists:
 self.delete(hashed_name)
 # then save the processed result
 content_file = ContentFile(force_bytes(content))
 # Save intermediate file for reference
 saved_name = self._save(hashed_name, content_file)
 hashed_name = self.hashed_name(name, content_file)

 if self.exists(hashed_name):
 self.delete(hashed_name)

 saved_name = self._save(hashed_name, content_file)
 hashed_name = force_text(self.clean_name(saved_name))
 # If the file hash stayed the same, this file didn't change
 if old_hashed_name == hashed_name:
 substitutions = False
 processed = True
 }}}

 After looking at the above code carefully, you will see that all css will
 be saved 4 times, even when there is no point doing so in the first place,
 like for example when there is no @import statement in your css. I am also
 not sure why _save method is called twice in _postprocess.

 Generally it would't be maybe extremely big problem for staticstorage
 which extends local file storage, but for remote storages like AWS this is
 unacceptable in my opinion. It would be great to change postprocessing
 algorythm to reduce number of save calls to minimum.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.f2d2c201e79f2a168216cd55eab8c7e0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #9071: Can't disable "add" popup links in the admin

2017-04-07 Thread Django

#9071: Can't disable "add" popup links in the admin
---+---
 Reporter:  Jacob  |Owner:  Dario Ocles
 Type:  New feature|   Status:  closed
Component:  contrib.admin  |  Version:  1.0
 Severity:  Normal |   Resolution:  worksforme
 Keywords:  pyconuk| Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+---

Comment (by Ryan Castner):

 I know this was closed due to inactivity and the ease of doing this, but I
 feel like the solution, while working and simple is not obvious and
 requires knowledge of the internals of how the admin works to figure out.

 A documented setting to attach to model admin like disable_add_related =
 ('field_name', ...) seems like it would be a better solution.

 The purpose of this is for non-technical admins who should have the
 ability to add a user but would be confused by the ability to add new
 users inline while modifying a page, likely if you are creating a new
 model with a foreign key to 'user' for instance, you don't want to be
 creating a new user at that time, so displaying the option can only serve
 to confuse the user

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.3c42b7189a3a966c803fdb635b56526f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28015: Add makemessages --add-location=full|file|never option

2017-04-07 Thread Django

#28015: Add makemessages --add-location=full|file|never option
-+-
 Reporter:  Ling-Xiao Yang   |Owner:  Ling-Xiao
 |  Yang
 Type:  New feature  |   Status:  assigned
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ling-Xiao Yang):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/8333 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.cfa5d0e64bccb0771fe3e51a36de62c3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27972: BaseSpatialField.geodetic should return SpatialReference.geographic

2017-04-07 Thread Django

#27972: BaseSpatialField.geodetic should return SpatialReference.geographic
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 Type:   |  Fedoseev
  Cleanup/optimization   |   Status:  closed
Component:  GIS  |  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"df8f1d018fcbf780e4e8eb98f550b2db6ad2d4c0" df8f1d01]:
 {{{
 #!CommitTicketReference repository=""
 revision="df8f1d018fcbf780e4e8eb98f550b2db6ad2d4c0"
 Fixed #27972 -- Made BaseSpatialField.geodetic() use
 SpatialReference.geographic.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.85317f4a3bb25fb296aa2b1d33d06431%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28054: After #26052 runserver returns response body for HTTP HEAD requests

2017-04-07 Thread Django

#28054: After #26052 runserver returns response body for HTTP HEAD requests
-+-
 Reporter:  Ed Morley|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  1.10
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  runserver| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * component:  HTTP handling => Core (Management commands)
 * stage:  Unreviewed => Accepted


Comment:

 Looks like another impetus for switching `runserver` to use another web
 server when feasible (#21978).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.90037b7a905e1ea072962322179e8818%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26052: Consider removing conditional_content_removal

2017-04-07 Thread Django

#26052: Consider removing conditional_content_removal
-+-
 Reporter:  Aymeric Augustin |Owner:  Susan Tan
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  HTTP handling|  Version:  1.9
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ed Morley):

 > Python's BaseHTTPRequestHandler (which runserver uses) also has
 discards the response content for 204 and 304 status codes

 Unfortunately the linked `BaseHTTPRequestHandler` handling appears to just
 be for error conditions (`send_error()`) so this change caused
 runserver.py to start returning a body for HTTP 200 HEAD requests.

 I've filed #28054.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c9a9a1d63fe6d6c486a9cda2a8972611%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28024: GEOSCoordSeq performance could be improved significantly by avoiding superfluous checks

2017-04-07 Thread Django

#28024: GEOSCoordSeq performance could be improved significantly by avoiding
superfluous checks
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 Type:   |  Fedoseev
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.a8dc1997f1189ad36cd516b4f882ed11%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28051: Index names are being overridden in ModelState

2017-04-07 Thread Django

#28051: Index names are being overridden in ModelState
-+-
 Reporter:  Markus Holtermann|Owner:  Markus
 |  Holtermann
 Type:  Bug  |   Status:  closed
Component:  Migrations   |  Version:  1.11
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"f9d2a20d7b6cbef24199332d28534e3e16fa20d9" f9d2a20d]:
 {{{
 #!CommitTicketReference repository=""
 revision="f9d2a20d7b6cbef24199332d28534e3e16fa20d9"
 [1.11.x] Fixed #28051 -- Made migrations respect Index's name argument.

 Thanks Marc Tamlyn for the report and Tim Graham for the review.

 Backport of d3cf75ec6fbdd2c1f1bb1e6ccb48d4de1da2952b from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.aa752f2b503e26479a2a140746eecbdc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28042: mimetype Fallback for attachments passed to EmailMessage.init removed

2017-04-07 Thread Django

#28042: mimetype Fallback for attachments passed to EmailMessage.__init__ 
removed
-+
 Reporter:  Dariusz Paluch   |Owner:  Nikolay
 Type:  Bug  |   Status:  new
Component:  Core (Mail)  |  Version:  1.11
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a8f80f6419514e3f7dea773e08235970%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28053: Allow fields to specify arbitrary indexes via db_index=Index()

2017-04-07 Thread Django

#28053: Allow fields to specify arbitrary indexes via db_index=Index()
-+-
 Reporter:  Marc Tamlyn  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  indexes migrations   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * type:  Uncategorized => New feature


Comment:

 WIP [https://github.com/django/django/pull/8322 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.01a79c2fff31fa21d46eb8cf2e8c2547%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28051: Index names are being overridden in ModelState

2017-04-07 Thread Django

#28051: Index names are being overridden in ModelState
-+-
 Reporter:  Markus Holtermann|Owner:  Markus
 |  Holtermann
 Type:  Bug  |   Status:  closed
Component:  Migrations   |  Version:  1.11
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"d3cf75ec6fbdd2c1f1bb1e6ccb48d4de1da2952b" d3cf75ec]:
 {{{
 #!CommitTicketReference repository=""
 revision="d3cf75ec6fbdd2c1f1bb1e6ccb48d4de1da2952b"
 Fixed #28051 -- Made migrations respect Index's name argument.

 Thanks Marc Tamlyn for the report and Tim Graham for the review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c49b14704ae96f6baa2b2b38b97c1206%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28054: After #26052 runserver returns response body for HTTP HEAD requests

2017-04-07 Thread Django

#28054: After #26052 runserver returns response body for HTTP HEAD requests
---+--
 Reporter:  Ed Morley  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  HTTP handling  |  Version:  1.10
 Severity:  Normal |   Resolution:
 Keywords:  runserver  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Ed Morley):

 Also this comment now seems incorrect:
 
https://github.com/django/django/blob/5d3b322dce452dd75e8602ced9f0d02f9d6a5837/django/middleware/http.py#L15-L19

 ...in that the body won't be empty as far as middleware is concerned for
 HEAD requests.

 The spec says entity tag validators can still be set for HEAD requests:
 https://tools.ietf.org/html/rfc7232#section-2.4

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c102d3bc02f53ce4a9932d2fc00b2716%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28054: After #26052 runserver returns response body for HTTP HEAD requests

2017-04-07 Thread Django

#28054: After #26052 runserver returns response body for HTTP HEAD requests
-+---
   Reporter:  Ed Morley  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  HTTP handling  |Version:  1.10
   Severity:  Normal |   Keywords:  runserver
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+---
 For compliance with RFC 2616, section 4.3, response bodies must not be
 returned for HEAD requests.

 In #26052, the stripping of the response bodies was removed from Django in
 favour of letting the server perform the body removal, since the common
 servers (gunicorn, mod_wsgi etc) already do so.

 However it appears that runserver does not strip the body, contrary to:
 
https://code.djangoproject.com/timeline?from=2016-04-23T20%3A26%3A34-05%3A00=second

 As such, starting in Django 1.10 the responses from runserver for HEAD
 requests are no longer compliant with the spec. (In certain configurations
 this also results in "Broken pipe" error messages in runserver output,
 since compliant user agents expect to be able to terminate the connection
 after the headers are sent.)

 STR:
 1) `mkvirtualenv django-test`
 2) `pip install 'Django>1.10,<1.11'`
 3) `django-admin startproject django-test`
 4) `cd django-test`
 5) `./manage.py runserver`
 6) In another terminal, run `curl -iX HEAD http://127.0.0.1:8000/`
 7) Observe response from curl

 Expected:
 {{{
 HTTP/1.0 200 OK
 Date: Fri, 07 Apr 2017 14:56:39 GMT
 Server: WSGIServer/0.2 CPython/3.4.5
 Content-Type: text/html
 X-Frame-Options: SAMEORIGIN
 }}}

 Actual:
 {{{
 HTTP/1.0 200 OK
 Date: Fri, 07 Apr 2017 14:56:39 GMT
 Server: WSGIServer/0.2 CPython/3.4.5
 Content-Type: text/html
 X-Frame-Options: SAMEORIGIN


 
 
   
   Welcome to
 Django
 ...
 }}}

 Tested with Python 2.7.13 and 3.4.5.
 Doesn't reproduce under Django 1.9.13.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.ca0858110b7e3d22258e9c70adcf5146%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28038: Cast regression in PostgresSQL using built-in lookups

2017-04-07 Thread Django

#28038: Cast regression in PostgresSQL using built-in lookups
-+-
 Reporter:  Peter J. Farrell |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  postgres postgresql  | Triage Stage:  Ready for
  array_agg  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.57a0e5deecc5991e61b231732fd548cb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28010: select_for_update() is too eager in presence of joins

2017-04-07 Thread Django

#28010: select_for_update() is too eager in presence of joins
-+-
 Reporter:  Ran Benita   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ran Benita):

 * has_patch:  0 => 1


Comment:

 I submitted a patch: https://github.com/django/django/pull/8330

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c31dac273486c9b035a706590f0ae54e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28046: Add tablespace support to Index class

2017-04-07 Thread Django

#28046: Add tablespace support to Index class
-+-
 Reporter:  Markus Holtermann|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.ec068b68d806ff7865c023924bae53ca%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28053: Allow fields to specify arbitrary indexes via db_index=Index()

2017-04-07 Thread Django

#28053: Allow fields to specify arbitrary indexes via db_index=Index()
-+-
 Reporter:  Marc Tamlyn  |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  indexes migrations   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Markus Holtermann):

 * needs_docs:  0 => 1
 * needs_tests:  0 => 1
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.232493029b4593d55e630eddf27c923c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28053: Allow fields to specify arbitrary indexes via db_index=Index()

2017-04-07 Thread Django

Syntax would look something like:

`HStoreField(db_index=GinIndex())`

Changes needed:
- Indexes won't necessarily receive fields initially.
- Fields are responsible for their own indexes. This is tackled here and
has implications for #27859, `_like` indexes on Postgres, and other
situations where we customise the indexes. It is possible, but I'm not
sure, that `Field.get_indexes()` could also handle unique conditions, but
I think it's better kept separately as not all databases consider
uniqueness to be an index.
- Change to `SchemaEditor.alter_field` so it receives the `to_model`, so
that the `Index` can resolve the correct column names. This is extra
important for `db_index` being a functional index (see #26167), although
that's not currently supported in the current data.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/051.0281a8187459259407f1413f15cee2a2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28052: Django inadvertently removes all indexes when switching to db_index=False

2017-04-07 Thread Django

#28052: Django inadvertently removes all indexes when switching to 
db_index=False
---+
 Reporter:  Markus Holtermann  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Migrations |  Version:  1.11
 Severity:  Release blocker|   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Markus Holtermann):

 * needs_docs:  0 => 1
 * has_patch:  0 => 1
 * needs_tests:  0 => 1


Comment:

 [https://github.com/django/django/pull/8329 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.1d7d49e923796393b7c8fc5b5a0a6850%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28050: TemplateSyntaxError should contain template name

2017-04-07 Thread Django

#28050: TemplateSyntaxError should contain template name
-+-
 Reporter:  Petr Dlouhý  |Owner:  kapil
 |  garg
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:  TemplateSyntaxError  | Triage Stage:  Accepted
  template   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by kapil garg):

 * status:  new => assigned
 * owner:  nobody => kapil garg


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.a2eff7b691571ec6b4952d647129dccc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28052: Django inadvertently removes all indexes when switching to db_index=False

2017-04-07 Thread Django

#28052: Django inadvertently removes all indexes when switching to 
db_index=False
-+
   Reporter:  Markus Holtermann  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Migrations |Version:  1.11
   Severity:  Release blocker|   Keywords:
   Triage Stage:  Accepted   |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 1. Create a model with `data = JSONField(db_index=True)`; makemigrations;
 migrate
 1. Add a `GinIndex(fields=['data'], name='foo')` to `_meta.indexes`;
 makemigrations; migrate
 1. Remove `db_index=True` from the `JSONField`; makemigrations; migrate

 After step 2 there will be a Gin index on the `data` column on the model.
 After step 3 there's _no_ index on the `data` column anymore.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.17d4625b57e64d03a1492165254b2b95%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28015: Add makemessages --add-location=full|file|never option

2017-04-07 Thread Django

#28015: Add makemessages --add-location=full|file|never option
-+-
 Reporter:  Ling-Xiao Yang   |Owner:  Ling-Xiao
 |  Yang
 Type:  New feature  |   Status:  assigned
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ling-Xiao Yang):

 * cc: ling-xiao.yang@… (added)
 * status:  new => assigned
 * owner:  nobody => Ling-Xiao Yang


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.eaf15f26081a1f1b31380d07a51bf36a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28047: QuerySet.filter() using the name of a OneToOneField primary key crashes

2017-04-07 Thread Django

#28047: QuerySet.filter() using the name of a OneToOneField primary key crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  regression   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * Attachment "28047-test.diff" added.


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.43278ad20b0f52184848d4bd4d187444%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28047: QuerySet.filter() using the name of a OneToOneField primary key crashes (was: Regression in query set against 1.10)

2017-04-07 Thread Django

#28047: QuerySet.filter() using the name of a OneToOneField primary key crashes
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  regression   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.99e3c03fe24c287eade47dbbaca5249f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28047: Regression in query set against 1.10

2017-04-07 Thread Django

#28047: Regression in query set against 1.10
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:  regression   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 Regression in 1bc249c2a67c24fcd28436c85388eff1d826e305.

 A test to reproduce is attached.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8e0cf90341fb7587e7fe4a7144c67835%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28051: Index names are being overridden in ModelState

2017-04-07 Thread Django

#28051: Index names are being overridden in ModelState
-+-
 Reporter:  Markus Holtermann|Owner:  Markus
 |  Holtermann
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.11
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.da73f679801ca74443ab549855a808f1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27881: Add "unified diff" output mode to diffsettings management command

2017-04-07 Thread Django

#27881: Add "unified diff" output mode to diffsettings management command
-+-
 Reporter:  Chris Lamb   |Owner:  Haris
 |  Ibrahim K. V.
 Type:  New feature  |   Status:  assigned
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Haris Ibrahim K. V.):

 * owner:  nobody => Haris Ibrahim K. V.
 * status:  new => assigned


Comment:

 Added documentation and here is the new PR:
 https://github.com/django/django/pull/8326

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.2f86d890c66fff9821bfed60c62c3ee7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22654: DecimalField and DECIMAL_SEPARATOR (in admin)

2017-04-07 Thread Django

#22654: DecimalField and DECIMAL_SEPARATOR (in admin)
--+--
 Reporter:  matija@…  |Owner:  Raphael Michel
 Type:  Bug   |   Status:  closed
Component:  Forms |  Version:  1.11
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--

Comment (by Claude Paroz):

 I think this change warrants a note in backwards incompatibilities:

 For example, with following settings:
 {{{
 LANGUAGE_CODE='de'
 USE_L10N=False
 USE_THOUSAND_SEPARATOR=True
 }}}

 Before: "1.345" => 1.345
 After: "1.345" => 1345

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.c8a870770aa4b321d608b4cf3912863f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #17419: Add a JSON template filter

2017-04-07 Thread Django

#17419: Add a JSON template filter
-+-
 Reporter:  Lau Bech Lauritzen   |Owner:  Aymeric
 |  Augustin
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  json template tag| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mateusz Jankowski):

 Replying to [comment:31 blighj]:
 > Would be happy to put together a pull request if there was support for
 this approach.

 Hi!  Are you still planning to work on it? I could contribute with
 extending your patch with tests, if you like.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.7ada34b176179a7d7cdf9401d05d6e03%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28051: Index names are being overridden in ModelState

2017-04-07 Thread Django

#28051: Index names are being overridden in ModelState
-+-
 Reporter:  Markus Holtermann|Owner:  Markus
 |  Holtermann
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.11
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Markus Holtermann):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/8328 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6e474d7ad990dbbe05786163dbb6a9af%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28051: Index names are being overridden in ModelState

2017-04-07 Thread Django

#28051: Index names are being overridden in ModelState
-+-
 Reporter:  Markus Holtermann|Owner:  Markus
 |  Holtermann
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.11
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Markus Holtermann):

 * status:  new => assigned
 * owner:  nobody => Markus Holtermann


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.76ee403e3cbb9b4f13228f8fb67db76d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28051: Index names are being overridden in ModelState

2017-04-07 Thread Django

#28051: Index names are being overridden in ModelState
-+
   Reporter:  Markus Holtermann  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Migrations |Version:  1.11
   Severity:  Release blocker|   Keywords:
   Triage Stage:  Accepted   |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 Despite setting the `name` attribute in the constructor of the `Index`
 class, the name is auto-generated in `ModelState`. This is unintentional
 as that name will then end up in the database

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.f3978e56afacc79ec48a9aeebe61b780%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28050: TemplateSyntaxError should contain template name

2017-04-07 Thread Django

#28050: TemplateSyntaxError should contain template name
-+-
 Reporter:  Petr Dlouhý  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:  TemplateSyntaxError  | Triage Stage:  Accepted
  template   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by kapil garg):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.3bcc84e020bbc244313946314e229388%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28049: ArrayField of IntegerField-s with Choices does not pass validation

2017-04-07 Thread Django

#28049: ArrayField of IntegerField-s with Choices does not pass validation
--+--
 Reporter:  Denis Sumin   |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  contrib.postgres  |  Version:  1.11
 Severity:  Normal|   Resolution:  duplicate
 Keywords:  arrayfield| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Marc Tamlyn):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 This appears to be a duplicate of #27161

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.3ebd2e927ac35e999ddf7cd31d827c22%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27777: File object does not consistently open itself in context manager use

2017-04-07 Thread Django

#2: File object does not consistently open itself in context manager use
-+-
 Reporter:  Raphael Gaschignard  |Owner:  Ingo
 Type:   |  Klöcker
  Cleanup/optimization   |   Status:  closed
Component:  File |  Version:  1.10
  uploads/storage|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Florian Apolloner ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c4536c4a54282cd89bc815b58cc3c73280712df1" c4536c4]:
 {{{
 #!CommitTicketReference repository=""
 revision="c4536c4a54282cd89bc815b58cc3c73280712df1"
 Fixed #2 -- Made File.open() work with the with statement (#8310)

 Fixed #2 -- Made File.open() work with the with statement
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.218d1b4c3ecb2cdbacb7f29341caed1c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23147: Sliced for-update queries do not work on Oracle

2017-04-07 Thread Django

#23147: Sliced for-update queries do not work on Oracle
-+-
 Reporter:  Shai Berger  |Owner:  felixxm
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  oracle   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"695d4dd7908ca32e118716b474c23b43727579d2" 695d4dd7]:
 {{{
 #!CommitTicketReference repository=""
 revision="695d4dd7908ca32e118716b474c23b43727579d2"
 Fixed #23147 -- Disabled a limit/offset on a query with select_for_update
 on Oracle.

 Thanks Shai Berger and Tim Graham for the reviews.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.74bd8967e5078bd39571e0b293d2f738%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28049: ArrayField of IntegerField-s with Choices does not pass validation

2017-04-07 Thread Django

#28049: ArrayField of IntegerField-s with Choices does not pass validation
--+--
 Reporter:  Denis Sumin   |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.postgres  |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:  arrayfield| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Denis Sumin):

 * component:  Uncategorized => contrib.postgres
 * type:  Uncategorized => Bug


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.411736ae35e45f92a95c95610aa5d88f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28050: TemplateSyntaxError should contain template name

2017-04-07 Thread Django

#28050: TemplateSyntaxError should contain template name
-+-
   Reporter:  Petr   |  Owner:  nobody
  Dlouhý |
   Type:  New| Status:  new
  feature|
  Component:  Template   |Version:  1.11
  system |   Keywords:  TemplateSyntaxError
   Severity:  Normal |  template
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 If there is an error in template, Django doesn't report the template name.
 It could be quite uneasy to find the buggy template in such case.

 e.g.: I have got following error:
 {{{
   File "/home/petr/soubory/programovani/Auto-
 mat/DPNK/dpnk/env/lib/python3.5/site-packages/django/template/base.py",
 line 509, in parse
 self.invalid_block_tag(token, command, parse_until)
   File "/home/petr/soubory/programovani/Auto-
 mat/DPNK/dpnk/env/lib/python3.5/site-packages/django/template/base.py",
 line 565, in invalid_block_tag
 get_text_list(["'%s'" % p for p in parse_until], 'or'),
 django.template.exceptions.TemplateSyntaxError: Invalid block tag on line
 127: 'endblock', expected 'empty' or 'endthumbnail'. Did you forget to
 register or load this tag?

 }}}
 It contains even line number, but I have no idea in which file.

 I think, it is not that difficult to include template name in the bug
 report. In my case I tried to debug the error call. In
 `django.template.base`, the `invalidb_block_tag` is called from `parse()`
 where the template name can be obtained from `self.origin.template_name`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.4c021080c2a1edcc929ba3f4a909ac67%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28045: Support phraseto_tsquery

2017-04-07 Thread Django

#28045: Support phraseto_tsquery
--+--
 Reporter:  Marc Tamlyn   |Owner:  (none)
 Type:  New feature   |   Status:  closed
Component:  contrib.postgres  |  Version:  master
 Severity:  Normal|   Resolution:  duplicate
 Keywords:  search| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Duplicate of #27899

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.2d5e1f420db15a31dfdeaf5842008ab5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28042: mimetype Fallback for attachments passed to EmailMessage.init removed

2017-04-07 Thread Django

#28042: mimetype Fallback for attachments passed to EmailMessage.__init__ 
removed
-+
 Reporter:  Dariusz Paluch   |Owner:  Nikolay
 Type:  Bug  |   Status:  new
Component:  Core (Mail)  |  Version:  1.11
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Tim Graham):

 * status:  closed => new
 * has_patch:  0 => 1
 * resolution:  fixed =>


Comment:

 The ticket is closed when the patch is merged. Please check "Has patch"
 when adding a pull request. See
 [https://docs.djangoproject.com/en/dev/internals/contributing/triaging-
 tickets/ Triaging Tickets] for workflow details.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b717d3a161b7b46b05c2e27a38aeff29%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27967: The autogenerated OneToOneField on multi table inheritance breaks the InlineAdminForm given UUID pk

2017-04-07 Thread Django

#27967: The autogenerated OneToOneField on multi table inheritance breaks the
InlineAdminForm given UUID pk
---+
 Reporter:  Robin Anupol   |Owner:  (none)
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.10
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by oyooyo):

 I wonder if this bug is somehow related to #27595
 The description reads different, it is said to occur in both PostgreSQL
 and SQLite - but just like #27595, the issue seems to somehow be related
 to multi-table inheritance with UUIDFields as primary keys.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.619ba9935a0a29babf637ab9a648fab0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28049: ArrayField of IntegerField-s with Choices does not pass validation

2017-04-07 Thread Django

#28049: ArrayField of IntegerField-s with Choices does not pass validation
-+
   Reporter:  denis-sumin|  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Uncategorized  |Version:  1.11
   Severity:  Normal |   Keywords:  arrayfield
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 I have an ArrayField with IntegerField inside, and the IntegerField has
 choices.
 Widgets return back a list of strings (instead of a list of integers).
 That is why the validation fails.
 I've found that changing ArrayField.to_python from this

 {{{
 def to_python(self, value):
 if isinstance(value, six.string_types):
 # Assume we're deserializing
 vals = json.loads(value)
 value = [self.base_field.to_python(val) for val in vals]
 return value
 }}}

 to something like this

 {{{
 def to_python(self, value):
 if isinstance(value, six.string_types):
 # Assume we're deserializing
 vals = json.loads(value)
 value = [self.base_field.to_python(val) for val in vals]
 elif isinstance(value, list):
 value = [self.base_field.to_python(val) for val in value]
 return value
 }}}

 fixes the problem.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/054.154eacbee925c12b7e69ac933a14aab9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13677: ModelFormSet may query wrong database backend

2017-04-07 Thread Django

#13677: ModelFormSet may query wrong database backend
--+
 Reporter:  Pierre Chifflier  |Owner:  Tobias Kunze
 Type:  Bug   |   Status:  assigned
Component:  Forms |  Version:  1.2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tobias Kunze):

 * status:  new => assigned
 * owner:  David Gouldin => Tobias Kunze


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d841bc2b2fedc55f87066dc4928b78fc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #13677: ModelFormSet may query wrong database backend

2017-04-07 Thread Django

#13677: ModelFormSet may query wrong database backend
-+-
 Reporter:  Pierre Chifflier |Owner:  David
 |  Gouldin
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tobias Kunze):

 * status:  closed => new
 * has_patch:  0 => 1
 * resolution:  worksforme =>


Comment:

 I'm sorry: I made a mistake in reproducing the issue and porting the patch
 to current Django. After porting the patch I can confirm that the
 regression test is valid. I'm not quite sure the implementation is what we
 want, but I'll push it and we can discuss the PR.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.891ae1ef16d0cde973237c9f4d26bcca%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28042: mimetype Fallback for attachments passed to EmailMessage.init removed

2017-04-07 Thread Django

#28042: mimetype Fallback for attachments passed to EmailMessage.__init__ 
removed
-+
 Reporter:  Dariusz Paluch   |Owner:  Nikolay
 Type:  Bug  |   Status:  closed
Component:  Core (Mail)  |  Version:  1.11
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Nikolay):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 https://github.com/django/django/pull/8323

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.91bce20cc1f3472c2e6d42b108d70eca%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26605: Abstract model inheriting concrete model crashes migrations

2017-04-07 Thread Django

#26605: Abstract model inheriting concrete model crashes migrations
--+
 Reporter:  Sébastien Diemer  |Owner:  Ingo Klöcker
 Type:  Bug   |   Status:  assigned
Component:  Migrations|  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Ingo Klöcker):

 Added [https://github.com/django/django/pull/8325 PR] with the test from
 the original PR.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.176c215217c51fd8f845d61974fb0993%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22654: DecimalField and DECIMAL_SEPARATOR (in admin)

2017-04-07 Thread Django

#22654: DecimalField and DECIMAL_SEPARATOR (in admin)
--+--
 Reporter:  matija@…  |Owner:  Raphael Michel
 Type:  Bug   |   Status:  closed
Component:  Forms |  Version:  1.11
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Florian Apolloner ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"bde814142a933bd96c3fa54a64cb1f74a575bb38" bde81414]:
 {{{
 #!CommitTicketReference repository=""
 revision="bde814142a933bd96c3fa54a64cb1f74a575bb38"
 Fixed #22654 -- Broken decimal validation
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.743984258d31cceee71e8c2ff0935b0c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26605: Abstract model inheriting concrete model crashes migrations

2017-04-07 Thread Django

#26605: Abstract model inheriting concrete model crashes migrations
--+
 Reporter:  Sébastien Diemer  |Owner:  Ingo Klöcker
 Type:  Bug   |   Status:  assigned
Component:  Migrations|  Version:  1.8
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Ingo Klöcker):

 * status:  new => assigned
 * owner:  (none) => Ingo Klöcker


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.726967ca0417e54f3966d57bfb7cce69%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27614: Store the DB used in the state before calling Model._save_table()

2017-04-07 Thread Django

#27614: Store the DB used in the state before calling Model._save_table()
-+-
 Reporter:  Joseph Kahn  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ingo Klöcker):

 * has_patch:  1 => 0


Comment:

 The pull request has been withdrawn.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.eade7780030928fd48857343ecd9e76d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27947: Document that model field error_messages don't carry over to forms

2017-04-07 Thread Django

#27947: Document that model field error_messages don't carry over to forms
-+-
 Reporter:  Jimmy Merrild Krag   |Owner:  Taavi
 Type:   |  Teska
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Rivo Laks):

 * stage:  Accepted => Ready for checkin


Comment:

 LGTM

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.9e30c285ca7489875b43c32d07b3af58%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27580: add special field for storing content types

2017-04-07 Thread Django

#27580: add special field for storing content types
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  New feature  |   Status:  assigned
Component:   |  Version:  master
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Sergey Fedoseev):

 Replying to [comment:5 Marten Kenbeek]:
 > Note that you shouldn't hardcode the `ContentType` class anywhere, or
 migrations will refer to the wrong model. Use `self.related_model` in the
 field, and `self.field.related_model` in the descriptor.

 Thanks for the hint!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.0ad6c05b2972d43cefdc5c0e7b9731f9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28041: Postgres prefix searching for full text search

2017-04-07 Thread Django

#28041: Postgres prefix searching for full text search
--+
 Reporter:  Joe Tsoi  |Owner:  Joe Tsoi
 Type:  New feature   |   Status:  assigned
Component:  contrib.postgres  |  Version:  1.10
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Joe Tsoi):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/8313 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f2a709234fc882f6d547af0b8bb858ba%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27967: The autogenerated OneToOneField on multi table inheritance breaks the InlineAdminForm given UUID pk

2017-04-07 Thread Django

#27967: The autogenerated OneToOneField on multi table inheritance breaks the
InlineAdminForm given UUID pk
---+
 Reporter:  Robin Anupol   |Owner:  (none)
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.10
 Severity:  Normal |   Resolution:
 Keywords:  admin  | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Marco Silva):

 added a test that reproduces the error, I think

 wip here
 https://github.com/marco-silva/django/tree/27967-inline-uuid-breaks

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.e59f5241537f14cdf635eddf8320d61a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28048: Generic date views don't work with related fields as date_field

2017-04-07 Thread Django

#28048: Generic date views don't work with related fields as date_field
-+-
 Reporter:  Lefteris Nikoltsios  |Owner:  Lefteris
 |  Nikoltsios
 Type:  Uncategorized|   Status:  assigned
Component:  Generic views|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Lefteris Nikoltsios):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/8307 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.0ad817c1bf615a5b1f0334b9e4fa51b7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28048: Generic date views don't work with related fields as date_field

2017-04-07 Thread Django

#28048: Generic date views don't work with related fields as date_field
-+-
   Reporter:  Lefteris   |  Owner:  Lefteris Nikoltsios
  Nikoltsios |
   Type: | Status:  assigned
  Uncategorized  |
  Component:  Generic|Version:  1.11
  views  |
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 For example if we have some models like that:

 {{{
 class Blog(models.Model):
 title = models.TextField()
 pubdate = models.DateField()

 class Article(models.Model):
 blog = models.ForeignKey(Blog)
 title = models.TextFIeld()
 pubdate = models.DateField()
 }}}

 the following view:

 {{{
 from django.views.generic.dates import MonthArchiveView

 from .models import Article


 class ArticleMonthArchiveView(MonthArchiveView):
 queryset = Article.objects.all()
 date_field = 'blog__pub_date'
 }}}

 will raise FieldDoesNotExist.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/054.5cc41a461597807814c1ee1408833edf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27580: add special field for storing content types

2017-04-07 Thread Django

#27580: add special field for storing content types
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  New feature  |   Status:  assigned
Component:   |  Version:  master
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Marten Kenbeek):

 Note that you shouldn't hardcode the `ContentType` class anywhere, or
 migrations will refer to the wrong model. Use `self.related_model` in the
 field, and `self.field.related_model` in the descriptor.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.b8682d6dbb733cbebb098016d5db3fed%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28044: Different logic in createsuperuser command between interactive and non-interactive mode

2017-04-07 Thread Django

#28044: Different logic in createsuperuser command between interactive and non-
interactive mode
-+-
 Reporter:  Sławek Ehlert|Owner:  Sławek
 Type:   |  Ehlert
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  createsuperuser  | Triage Stage:  Accepted
  management command |
Has patch:  0|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Markus Holtermann):

 * needs_docs:  0 => 1
 * type:  Uncategorized => Cleanup/optimization
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.01ba683911ebf5ffa4f35e2dc6701701%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28016: Command createsuperuser does not validate username when using --username

2017-04-07 Thread Django

#28016: Command createsuperuser does not validate username when using --username
-+-
 Reporter:  Ricardo S. A. Silva  |Owner:  Ricardo
 |  S. A. Silva
 Type:  Bug  |   Status:  assigned
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Markus Holtermann):

 This seems highly correlated to #28044 -- I feel like tackling #28044
 instead and marking this issue as a duplicate is a better option.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.b2e2f2b54894879203fee008163889aa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28047: Regression in query set against 1.10

2017-04-07 Thread Django

#28047: Regression in query set against 1.10
-+-
 Reporter:  Thierry Bastian  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  regression   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Ingo Klöcker:

Old description:

> I have this (simplified)
>
> from django.db import models
> class Foo(models.Model):
> class Meta:
> app_label = 'inventory'
> pass
>
> class Bar(models.Model):
> class Meta:
> app_label = 'inventory'
> foo = models.OneToOneField(Foo, primary_key=True,
> on_delete=models.CASCADE)
>

> Of course you need an app named inventory. But just use this and try to
> create a query set like this:
>
> Bar.objects.filter(foo__in=Foo.objects.all())
>
> Obviously I had different criteria.
>
> Creating that query set says:
> "django.core.exceptions.FieldError: Cannot resolve keyword 'foo' into
> field. Choices are: bar, id"
>
> That was working just fine in Django 1.10

New description:

 I have this (simplified)

 {{{#!python
 from django.db import models

 class Foo(models.Model):
 class Meta:
 app_label = 'inventory'
 pass

 class Bar(models.Model):
 class Meta:
 app_label = 'inventory'
 foo = models.OneToOneField(Foo, primary_key=True,
 on_delete=models.CASCADE)
 }}}

 Of course you need an app named inventory. But just use this and try to
 create a query set like this:

 {{{#!python
 Bar.objects.filter(foo__in=Foo.objects.all())
 }}}

 Obviously I had different criteria.

 Creating that query set says:
 "django.core.exceptions.FieldError: Cannot resolve keyword 'foo' into
 field. Choices are: bar, id"

 That was working just fine in Django 1.10

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.aa5b34272e071f53d334a521b6a8a75d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28037: Incorrect return type in QueryDict.items()/values() docs examples

2017-04-07 Thread Django

#28037: Incorrect return type in QueryDict.items()/values() docs examples
--+
 Reporter:  Daniel F Moisset  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Daniel F Moisset):

 * has_patch:  0 => 1


Comment:

 Thank you, created a PR: https://github.com/django/django/pull/8320

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.fc6905a50709ee21d16c904859329140%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28047: Regression in query set against 1.10

2017-04-07 Thread Django

#28047: Regression in query set against 1.10
-+-
   Reporter:  Thierry|  Owner:  nobody
  Bastian|
   Type:  Bug| Status:  new
  Component:  Database   |Version:  1.11
  layer (models, ORM)|
   Severity:  Normal |   Keywords:  regression
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 I have this (simplified)

 from django.db import models
 class Foo(models.Model):
 class Meta:
 app_label = 'inventory'
 pass

 class Bar(models.Model):
 class Meta:
 app_label = 'inventory'
 foo = models.OneToOneField(Foo, primary_key=True,
 on_delete=models.CASCADE)


 Of course you need an app named inventory. But just use this and try to
 create a query set like this:

 Bar.objects.filter(foo__in=Foo.objects.all())

 Obviously I had different criteria.

 Creating that query set says:
 "django.core.exceptions.FieldError: Cannot resolve keyword 'foo' into
 field. Choices are: bar, id"

 That was working just fine in Django 1.10

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.0ecbbcd22723ce225cd06743267c51da%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27808: Nested ArrayField with nullable base field generates invalid SQL

2017-04-07 Thread Django

#27808: Nested ArrayField with nullable base field generates invalid SQL
--+
 Reporter:  Josef Kolář   |Owner:  (none)
 Type:  Bug   |   Status:  new
Component:  contrib.postgres  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Marcus Gregersen):

 This is due to following bug in psycopg2
 https://github.com/psycopg/psycopg2/issues/325

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.1a2d8dfc58067c24920585a2ea51098a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28046: Add tablespace support to Index class

2017-04-07 Thread Django

#28046: Add tablespace support to Index class
-+-
   Reporter:  Markus |  Owner:  nobody
  Holtermann |
   Type:  New| Status:  new
  feature|
  Component:  Database   |Version:  master
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 For now, the `django.db.models.indexes.Index` class determines a non-
 default tablespace from its model field if the index is defined on a
 single field (`Field.db_tablespace`) or from a model's
 `_meta.db_tablespace` for multi-column indexes. Indexes on expressions,
 however, won't be able to identify which columns they refer to.

 The initial API design would be to add `db_tablespace` or `tablespace` as
 an attribute to the `Index` class and use that if provided, and fallback
 to the current behavior if not given.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.77c36d75a100cd8492c6c4f602078fbd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28033: Allow passing choices as a callable in a model field

2017-04-07 Thread Django

#28033: Allow passing choices as a callable in a model field
-+-
 Reporter:  Ian Foote|Owner:  Rémy
 |  Hubscher
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  choices  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Marco Silva):

 Replying to [comment:10 kapil garg]:
 > ''From
 
[https://docs.djangoproject.com/en/dev/ref/models/fields/#django.db.models.Field.choices
 django documentation]
 >
 >
 > "Note that choices can be any iterable object – not necessarily a list
 or tuple. This lets you construct choices dynamically. "--''
 >
 > I see now what is missing.
 >
 When building the patch doc changes, I found that particular line to be
 problematic, because it is folowed by "But if you find yourself hacking
 choices to be dynamic", so, does it let you contruct choices dynamically,
 or you have to hack choices?

 The current patch is just a way to cleanly have any iterator class(that
 can be used dynamicaly and provide the desired effect) be added on to the
 migrations file with its class name and not as the calculated choices
 list.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9602a9159b01bc38b62aa0ff26319256%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28033: Allow passing choices as a callable in a model field

2017-04-07 Thread Django

#28033: Allow passing choices as a callable in a model field
-+-
 Reporter:  Ian Foote|Owner:  Rémy
 |  Hubscher
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  choices  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Marco Silva):

 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.163374b971e649fd19ee85beff414813%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27644: Document FileSystemStorage.get_created_time() limitation on Unix

2017-04-07 Thread Django

#27644: Document FileSystemStorage.get_created_time() limitation on Unix
-+-
 Reporter:  Jonathan Verner  |Owner:  Ingo
 Type:   |  Klöcker
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ingo Klöcker):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/8319 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.8257319113b8d02bd5afe81979ea2d51%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28045: Support phraseto_tsquery

2017-04-07 Thread Django

#28045: Support phraseto_tsquery
+
   Reporter:  Marc Tamlyn   |  Owner:  (none)
   Type:  New feature   | Status:  new
  Component:  contrib.postgres  |Version:  master
   Severity:  Normal|   Keywords:  search
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 New feature in the FTS implementation in PG 9.6, searches for phrases
 instead of just individual words.

 See https://www.postgresql.org/docs/9.6/static/functions-textsearch.html

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.a5b037897e791e94d93d84b07549354c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27996: Add pgcrypto extension and GEN_RANDOM_UUID function to contrib.postgres

2017-04-07 Thread Django

#27996: Add pgcrypto extension  and GEN_RANDOM_UUID function to contrib.postgres
-+-
 Reporter:  Paolo Melchiorre |Owner:  Paolo
 |  Melchiorre
 Type:  New feature  |   Status:  assigned
Component:  contrib.postgres |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  uuid extension   | Triage Stage:  Ready for
  function random postgresql |  checkin
  cryptography   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Marc Tamlyn):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.efdd216ac90ea7333bfed1237b5d0c26%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28016: Command createsuperuser does not validate username when using --username

2017-04-07 Thread Django

#28016: Command createsuperuser does not validate username when using --username
-+-
 Reporter:  Ricardo S. A. Silva  |Owner:  Ricardo
 |  S. A. Silva
 Type:  Bug  |   Status:  assigned
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ricardo S. A. Silva):

 PR updated: Added checks for fields with **unique** constraint.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.6dbfc0ed88f2d7933f832fe03c88bd0c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

81 matches

Mail list logo