Re: [Django] #26600: map says a queryset is not iterable

[Django]

#26600: map says a queryset is not iterable
-+-
 Reporter:  ihucos   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  queryset iterator| Triage Stage:
  map|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Brian Hahn):

 I am also seeing this issue, and have to force the queryset into a list to
 workaround this error. Any plausible idea why this might be happening?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.3ef1f3753e7d86e7fd416a0b9321f64b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28600: Add prefetch related support to RawQuerySet

[Django]

#28600: Add prefetch related support to RawQuerySet
-+-
 Reporter:  Adnan Umer   |Owner:  Adnan
 |  Umer
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Adnan Umer):

 * owner:  (none) => Adnan Umer
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b051e9a27e9649cfcd9f9e6a11456152%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28898: autocomplete_fields doesn't support OneToOneField

[Django]

#28898: autocomplete_fields doesn't support OneToOneField
--+
   Reporter:  Lachlan Cannon  |  Owner:  nobody
   Type:  Bug | Status:  new
  Component:  contrib.admin   |Version:  2.0
   Severity:  Normal  |   Keywords:
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+
 I'm currently trying to port our projects to Django 2.0, and running into
 a problem dropping our old, outdated autocompletes for the new built in
 ones, as it appears not to support OneToOne fields.

 Looks like the offending line of code is here:
 
https://github.com/django/django/blob/master/django/contrib/admin/checks.py#L107

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.507591f57a76c61f51ddf6b27f2d45f2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28862: Removing a field from index_together/unique_together and from the model generates a migration that crashes

[Django]

#28862: Removing a field from index_together/unique_together and from the model
generates a migration that crashes
-+-
 Reporter:  Artem Maslovskiy |Owner:  Ramiro
 |  Morales
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  models migrations| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ramiro Morales):

 Forgot to say this happens in
 
`django.db.migrations.autodetector.MigrationAutodetector._optimize_migrations()`

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.e70c39db46842642128ac9f42a391ef9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28862: Removing a field from index_together/unique_together and from the model generates a migration that crashes

[Django]

#28862: Removing a field from index_together/unique_together and from the model
generates a migration that crashes
-+-
 Reporter:  Artem Maslovskiy |Owner:  Ramiro
 |  Morales
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  models migrations| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ramiro Morales):

 This is what I've found so far:

 It seems the optimization introduced in
 e470f311d654267ec86f9a6325ec500345b9dff2 (later refactored in
 49f4c9f4c61885189d136d7073c26ecc91b482b1) by which a sequence of schema
 migrations operations like this:

 {{{
 - AlterIndexTogether(index_together=['title', 'author', 'newfield'] ->
 index_together=['title', 'author'])
 - RemoveField('newfield')
 }}}

 gets swapped to

 {{{
 - RemoveField('newfield')
 - AlterIndexTogether(index_together=['title', 'author', 'newfield'] ->
 index_together=['title', 'author'])
 }}}

 This is because the `references_field()` method of
 `django.db.migrations.operations.AlterIndexTogether` considers only the
 final set of `index_together` fields to conclude  there is no overlap in
 field affected by the two operations. This reasoning might be valid when
 reordering operation sequences which involve e.g. `AddField`  But when
 it's interacting with `RemoveField` (and `RenameField`?) it needs to
 consider the _initial_ set of `index_together` fields instead.

 if it did, then it would discover it can't optimize the
 `AlterIndexTogether` to be after the `RemoveField` whcih is that the OP
 reports.

 Example is for `Meta.index_together` but affects also al least
 `Meta.unique_together` too. AFAICT fixing this might involve some non-
 trivial refactoring.

 I'm open to confirmation/rebuttal and to ideas on how this could be
 solved.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.3b539fa8c6d28e4554133f236f926bb8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28896: GeoDjango PointField fails to generate query if filtering on a NULL value

[Django]

#28896: GeoDjango PointField fails to generate query if filtering on a NULL 
value
-+-
 Reporter:  William Li   |Owner:  Sergey
 |  Fedoseev
 Type:  Bug  |   Status:  assigned
Component:  GIS  |  Version:  2.0
 Severity:  Release blocker  |   Resolution:
 Keywords:  PointField   | Triage Stage:  Accepted
  GeoDjango  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sergey Fedoseev):

 * status:  new => assigned
 * owner:  nobody => Sergey Fedoseev


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.76dfd6ae5633076c7d6fe82bfea040be%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28876: badly formed Table Index and constraint's name when `Meta.db_table` is set with quoted string

[Django]

#28876: badly formed Table Index and constraint's name when  `Meta.db_table` is 
set
with quoted string
-+-
 Reporter:  Carlos E. C. Leite   |Owner:  felixxm
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  constraints indexes  | Triage Stage:  Accepted
  db_table   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  assigned => closed
 * resolution:   => fixed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.a9531d5ae8206846c1fc6f52408fdb59%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28876: badly formed Table Index and constraint's name when `Meta.db_table` is set with quoted string

[Django]

#28876: badly formed Table Index and constraint's name when  `Meta.db_table` is 
set
with quoted string
-+-
 Reporter:  Carlos E. C. Leite   |Owner:  felixxm
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  constraints indexes  | Triage Stage:  Accepted
  db_table   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"1decd0197d241b27d54bb12eca04b7e89a9ccba6" 1decd019]:
 {{{
 #!CommitTicketReference repository=""
 revision="1decd0197d241b27d54bb12eca04b7e89a9ccba6"
 [1.11.x] Refs #28876 -- Fixed incorrect foreign key constraint name for
 models with quoted db_table.

 Thanks Simon Charette and Tim Graham for the review and Carlos E. C.
 Leite for the report.

 Backport of fc48047586a8f92262f55d9d2bfb976325844b23 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.ed7004752679d0db442ab1717930b9c3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28856: GenericForeignKey attributes create new instances on every access

[Django]

#28856: GenericForeignKey attributes create new instances on every access
--+
 Reporter:  Morgan Wahl   |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.contenttypes  |  Version:  1.10
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Morgan Wahl):

 I went ahead and made the PR so I could see test results.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.db2bad5b277924c74f1fccfa79500e5f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #8936: Add view (read-only) permission to admin

[Django]

#8936: Add view (read-only) permission to admin
---+
 Reporter:  simon  |Owner:  Olivier
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Olivier):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.b1e585f254edc334e79ad9174256d2cf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28646: Migration calls "CREATE INDEX" when one already exists when 'unique' field attribute is added (PostgreSQL)

[Django]

#28646: Migration calls "CREATE INDEX" when one already exists when 'unique' 
field
attribute is added (PostgreSQL)
-+-
 Reporter:  Hari - 何瑞理|Owner:  Tomer
 |  Chachamu
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  postgresql,migration,index |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tomer Chachamu):

 The test case given is incorrect, as Django always uses a fresh schema
 editor for each migration step:

 
https://github.com/django/django/blob/master/django/db/migrations/executor.py#L225

 This passes and is similar to other cases in
 {{{migrations/test_operations.py}}}:

 {{{

 def test_change_primary_key(self):
 # Create a model with two fields
 operation1 = migrations.CreateModel(
 'SimpleModel',
 [
 ("field1", models.SlugField(max_length=20,
 primary_key=True)),
 ("field2", models.SlugField(max_length=20)),
 ],
 )
 # Drop field1 primary key constraint - this doesn't fail
 operation2 = migrations.AlterField(
 "SimpleModel",
 "field1",
 models.SlugField(max_length=20, primary_key=False),
 )
 # Add a primary key constraint to field2 - this fails
 operation3 = migrations.AlterField(
 "SimpleModel",
 "field2",
 models.SlugField(max_length=20, primary_key=True),
 )

 project_state = ProjectState()
 new_state = project_state.clone()
 operation1.state_forwards("migrtest", new_state)
 with connection.schema_editor() as editor:
 operation1.database_forwards("migrtest", editor,
 project_state, new_state)
 project_state, new_state = new_state, new_state.clone()
 operation2.state_forwards("migrtest", new_state)
 with connection.schema_editor() as editor:
 operation2.database_forwards("migrtest", editor,
 project_state, new_state)
 project_state, new_state = new_state, new_state.clone()
 operation3.state_forwards("migrtest", new_state)
 with connection.schema_editor() as editor:
 operation3.database_forwards("migrtest", editor,
 project_state, new_state)
 }}}

 I'm going to try working off the original bug description to reproduce the
 bug.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e98a67a770864ae00821caeab06039f0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28876: badly formed Table Index and constraint's name when `Meta.db_table` is set with quoted string

[Django]

#28876: badly formed Table Index and constraint's name when  `Meta.db_table` is 
set
with quoted string
-+-
 Reporter:  Carlos E. C. Leite   |Owner:  felixxm
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  constraints indexes  | Triage Stage:  Accepted
  db_table   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"3e52fd7595f80ec162fc44798c29399b7e899b9b" 3e52fd7]:
 {{{
 #!CommitTicketReference repository=""
 revision="3e52fd7595f80ec162fc44798c29399b7e899b9b"
 [1.11.x] Refs #28876 -- Fixed incorrect class-based model index name
 generation for models with quoted db_table.

 Thanks Simon Charette and Tim Graham for the review and Carlos E. C.
 Leite for the report.

 Backport of f79d9a322c6008e5fada1453aebfb56afc316cc8 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.009b575ebca079877aa095bf7c78d6a2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28646: Migration calls "CREATE INDEX" when one already exists when 'unique' field attribute is added (PostgreSQL)

[Django]

#28646: Migration calls "CREATE INDEX" when one already exists when 'unique' 
field
attribute is added (PostgreSQL)
-+-
 Reporter:  Hari - 何瑞理|Owner:  Tomer
 |  Chachamu
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  postgresql,migration,index |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tomer Chachamu):

 * status:  new => assigned
 * cc: Tomer Chachamu (added)
 * owner:  nobody => Tomer Chachamu


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.40a7f6daa22cbc323fe23a6781e099f1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28885: Bottom parts of "Congratulations!" page cut off internationalized content

[Django]

#28885: Bottom parts of "Congratulations!" page cut off internationalized 
content
-+-
 Reporter:  Maciej Olko  |Owner:  Timothy
 |  Allen
 Type:  Bug  |   Status:  assigned
Component:  Core (Other) |  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  i18n, template,  | Triage Stage:  Accepted
  defaults   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-

Old description:

> Bottom parts (footer) of "Congratulations!" page[1] (rocket taking
> off/default urlconf) cut off text if it is too long. It happens for e.g.
> Russian and Lower Serbian languages. Screenshots:
> [[Image(https://screenshots.firefox.com/H4OzOchrVQCvNp5e/localhost)]]
> [[Image(https://screenshots.firefox.com/dG8BTsWHB4s0F2pL/localhost)]]
>
> For many other languages, the problem is more of just esthetic nature, as
> the padding to the bottom of page is not equal to the footer top ruler
> (if translations aren't one-liners in effect).
>
> The footer shouldn't have fixed height. I am afraid that some JavaScript
> is neccessary to calculate footer's height if we are about to keep the
> layout.
>
> [1] django/django/views/templates/default_urlconf.html

New description:

 Bottom parts (footer) of "Congratulations!" page[1] (rocket taking
 off/default urlconf) cut off text if it is too long. It happens for e.g.
 Russian and Lower Serbian languages. Screenshots:
 [[Image(https://screenshots.firefox.com/H4OzOchrVQCvNp5e/localhost)]]
 [[Image(https://screenshots.firefox.com/dG8BTsWHB4s0F2pL/localhost)]]

 For many other languages, the problem is more of just esthetic nature, as
 the padding to the bottom of page is not equal to padding to the footer
 top ruler (if translations aren't one-liners in effect).

 The footer shouldn't have fixed height. I am afraid that some JavaScript
 is neccessary to calculate footer's height if we are about to keep the
 layout.

 [1] django/django/views/templates/default_urlconf.html

--

Comment (by Maciej Olko):

 You can also test it with official Django translations, by just changing
 the [https://docs.djangoproject.com/en/1.11/ref/settings/#language-code
 LANGUAGE_CODE setting]. Language codes that have longest translations
 (AFAIK) are "ru" and "dsb".

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.05860e2953a03e08532c1e4352b44f0c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28876: badly formed Table Index and constraint's name when `Meta.db_table` is set with quoted string

[Django]

#28876: badly formed Table Index and constraint's name when  `Meta.db_table` is 
set
with quoted string
-+-
 Reporter:  Carlos E. C. Leite   |Owner:  felixxm
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  constraints indexes  | Triage Stage:  Accepted
  db_table   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"741711f8a28147f9d9d67a7a0aa7783dd238b1ea" 741711f8]:
 {{{
 #!CommitTicketReference repository=""
 revision="741711f8a28147f9d9d67a7a0aa7783dd238b1ea"
 [2.0.x] Refs #28876 -- Fixed incorrect foreign key constraint name for
 models with quoted db_table.

 Thanks Simon Charette and Tim Graham for the review and Carlos E. C.
 Leite for the report.

 Backport of fc48047586a8f92262f55d9d2bfb976325844b23 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.32b15366abed146404682b29f7c67209%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28876: badly formed Table Index and constraint's name when `Meta.db_table` is set with quoted string

[Django]

#28876: badly formed Table Index and constraint's name when  `Meta.db_table` is 
set
with quoted string
-+-
 Reporter:  Carlos E. C. Leite   |Owner:  felixxm
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  constraints indexes  | Triage Stage:  Accepted
  db_table   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"73ab7438668a65b1fe8e0df6351096c42a06fa08" 73ab743]:
 {{{
 #!CommitTicketReference repository=""
 revision="73ab7438668a65b1fe8e0df6351096c42a06fa08"
 [2.0.x] Refs #28876 -- Fixed incorrect class-based model index name
 generation for models with quoted db_table.

 Thanks Simon Charette and Tim Graham for the review and Carlos E. C.
 Leite for the report.

 Backport of f79d9a322c6008e5fada1453aebfb56afc316cc8 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.932e907751edb5ece95c6ab401a44be0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28876: badly formed Table Index and constraint's name when `Meta.db_table` is set with quoted string

[Django]

#28876: badly formed Table Index and constraint's name when  `Meta.db_table` is 
set
with quoted string
-+-
 Reporter:  Carlos E. C. Leite   |Owner:  felixxm
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  constraints indexes  | Triage Stage:  Accepted
  db_table   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"fc48047586a8f92262f55d9d2bfb976325844b23" fc48047]:
 {{{
 #!CommitTicketReference repository=""
 revision="fc48047586a8f92262f55d9d2bfb976325844b23"
 Refs #28876 -- Fixed incorrect foreign key constraint name for models with
 quoted db_table.

 Thanks Simon Charette and Tim Graham for the review and Carlos E. C.
 Leite for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.b2e35c5d8c0a4fb36070deb24be4fb2c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28876: badly formed Table Index and constraint's name when `Meta.db_table` is set with quoted string

[Django]

#28876: badly formed Table Index and constraint's name when  `Meta.db_table` is 
set
with quoted string
-+-
 Reporter:  Carlos E. C. Leite   |Owner:  felixxm
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  constraints indexes  | Triage Stage:  Accepted
  db_table   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"f79d9a322c6008e5fada1453aebfb56afc316cc8" f79d9a32]:
 {{{
 #!CommitTicketReference repository=""
 revision="f79d9a322c6008e5fada1453aebfb56afc316cc8"
 Refs #28876 -- Fixed incorrect class-based model index name generation for
 models with quoted db_table.

 Thanks Simon Charette and Tim Graham for the review and Carlos E. C.
 Leite for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.da1bd83246083e5734898602f7a0081f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28870: add support for serialization of `functools.partialmethod` objects in migrations

[Django]

#28870: add support for serialization of `functools.partialmethod` objects in
migrations
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  New feature  |   Status:  assigned
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tomer Chachamu):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.91104da3c556e132419fe706e6991fd7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28856: GenericForeignKey attributes create new instances on every access

[Django]

#28856: GenericForeignKey attributes create new instances on every access
--+
 Reporter:  Morgan Wahl   |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.contenttypes  |  Version:  1.10
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Morgan Wahl):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 This fix applied to 1.11 fails when the referenced object is a subclass of
 a subclass.

 I have regression test and fix for this situation here:

 https://github.com/django/django/compare/stable/1.11.x...addgene:mw/gfk-
 recursive-fix

 Should I open a PR?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.4a61477516a41797b70392e95bf6ca3e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27391: Support unittest.TestCase.debug() method

[Django]

#27391: Support unittest.TestCase.debug() method
-+-
 Reporter:  Pavel Savchenko  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Testing framework|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  unittest | Triage Stage:  Accepted
  SimpleTestCase debug   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Martin):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.553bdbeb1a8b0f86b47c5c4cc14d9884%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28877: Improve humanize’s |ordinal formatting

[Django]

#28877: Improve humanize’s |ordinal formatting
-+-
 Reporter:  Tzu-ping Chung   |Owner:  Tzu-ping
 |  Chung
 Type:  New feature  |   Status:  assigned
Component:  contrib.humanize |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e61393798c55a3d3bbfe4245b5671177%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28897: FieldError when performing custom action in Admin Interface IF data is sorted by an annotated field

[Django]

#28897: FieldError when performing custom action in Admin Interface IF data is
sorted by an annotated field
-+-
   Reporter:  coltonbh   |  Owner:  nobody
   Type:  Bug| Status:  new
  Component: |Version:  2.0
  contrib.admin  |   Keywords:  Admin Interface,
   Severity:  Normal |  Custom Action, Annotated Field,
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 A FieldError results if I try to perform a custom a custom action on data
 in the admin interface IF that data is sorted by an annotated field. The
 action is obviously not acting on an annotated field as those fields do
 not exist in the database, but raises a FieldError saying it 'Cannot
 resolve keyword 'field_that_data_is_currently_sorted_by' into field.' and
 then lists the choices for fields (all of which are the raw model fields,
 not the annotated fields in the custom queryset).

 My admin model:

 {{{
 @admin.register(Position)
 class PositionAdmin(admin.ModelAdmin):

 def __init__(self, *args, **kwargs):
 super().__init__(*args, **kwargs)

 def get_queryset(self, request):

 qs = super(PositionAdmin,
 self).get_queryset(request).prefetch_related(
 'orders').select_related(
 'portfolio', 'current_position').select_related(
 'current_position').annotate(
 Count('orders', distinct=True),
 Count('short_requests'),
 total_position_value=ExpressionWrapper(
 F('price') * F('quantity'),
 output_field=IntegerField()),
 diff_shares=Coalesce(
 F('quantity')
 - F('current_position__quantity'),
 F('quantity')),
 diff_value=ExpressionWrapper(
 F('diff_shares') * F('price'),
 output_field=IntegerField()),
 orders_with_errors=Count(
 Case(When(~Q(orders__error=''), then=1))),
 non_accepted_orders=Count(
 Case(When(Q(orders__status=''), then=1))),
 order_today=Count(
 Case(When(
 orders__created_at__gte=_brokerage_today_start(),
 then=1
 return qs

 # Custom Action
 def approve_position_for_trading(self, request, queryset):
 try:
 num_pos_approved = queryset.update(approved=True)
 except FieldError:
 self.message_user(
 request, "You cannot perform actions when you have sorted
 by "
 "this column. Please remove your column sortings and then
 try "
 "your action again.", level=messages.ERROR)
 else:
 if num_pos_approved == 1:
 message_bit = "1 position was was"
 else:
 message_bit = "%s positions were" % num_pos_approved
 self.message_user(
 request, "%s successfully approved for trading." %
 message_bit)
 }}}

 I had to write code to handle the error so that the user will know how to
 proceed. However, this seems like bad behavior. Django can successfully
 perform that action (changing the 'Approved' field to 'True') on the data
 if it is sorted by any core model field, or if sorted by no field at all.
 However, if the data is sorted by a field resulting from the annotation of
 my queryset, then I get the FieldError when I try to perform the action.
 This seems like a bug.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.ee8ade616c8c35460d3405b9ca36de0e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28896: GeoDjango PointField fails to generate query if filtering on a NULL value

[Django]

#28896: GeoDjango PointField fails to generate query if filtering on a NULL 
value
--+
 Reporter:  William Li|Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  GIS   |  Version:  2.0
 Severity:  Release blocker   |   Resolution:
 Keywords:  PointField GeoDjango  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * keywords:  QuerySet.extra PointField GeoDjango => PointField GeoDjango
 * cc: Sergey Fedoseev (added)
 * component:  Database layer (models, ORM) => GIS
 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 Bisected to 58da81a5a372a69f0bac801c412b57f3cce5f188. I would imagine that
 `__isnull=True` works, but we should either restore the old behavior of
 accepting `None` or document the backwards incompatibility.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.bfe74c075d832738a7b2f2de964f90b1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28884: RenameField crashes with AttributeError when renaming a ManyToManyField (sqlite3) (was: RenameField crashes with AttributeError when renaming a ManyToManyField)

[Django]

#28884: RenameField crashes with AttributeError when renaming a ManyToManyField
(sqlite3)
-+-
 Reporter:  Emanuele Di Giacomo  |Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  2.0
 Severity:  Release blocker  |   Resolution:
 Keywords:  sqlite3 sqlite   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ramiro Morales):

 * keywords:   => sqlite3 sqlite


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.499ccc85478b01c78ac6cb43c7787895%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28862: Removing a field from index_together/unique_together and from the model generates a migration that crashes

[Django]

#28862: Removing a field from index_together/unique_together and from the model
generates a migration that crashes
-+-
 Reporter:  Artem Maslovskiy |Owner:  Ramiro
 |  Morales
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  models migrations| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ramiro Morales):

 Replying to [comment:4 Tim Graham]:
 >  the order of operations changed in
 5c9c1e029d139bd3d5213804af2ed9f317cd0b86 (Django 1.9).

 Actually, that change was committed during the 1.8 development cycle.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.29f5bf8a8f5e157773bd76f11681297d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28862: Removing a field from index_together/unique_together and from the model generates a migration that crashes

[Django]

#28862: Removing a field from index_together/unique_together and from the model
generates a migration that crashes
-+-
 Reporter:  Artem Maslovskiy |Owner:  Ramiro
 |  Morales
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:  models migrations| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ramiro Morales):

 * owner:  nobody => Ramiro Morales
 * status:  new => assigned
 * version:  1.9 => 1.8


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.10f0382903ee3fdf374cd815fec5083c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28876: badly formed Table Index and constraint's name when `Meta.db_table` is set with quoted string

[Django]

#28876: badly formed Table Index and constraint's name when  `Meta.db_table` is 
set
with quoted string
-+-
 Reporter:  Carlos E. C. Leite   |Owner:  felixxm
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  constraints indexes  | Triage Stage:  Accepted
  db_table   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * version:  2.0 => 1.11


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.9a96d80aebf992aae73c99cf14bb6a40%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28895: serialized_rollback = True causes an IntgrityError in LiveServerTestCase

[Django]

#28895: serialized_rollback = True causes an IntgrityError in LiveServerTestCase
+--
 Reporter:  Lyra2108|Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  Testing framework   |  Version:  1.8
 Severity:  Normal  |   Resolution:  duplicate
 Keywords:  LiveServerTestCase  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Duplicate of #23727. Fixed in Django 1.9+ by
 d3fdaf907db6a5be4d0391532d7e65688c19e851. In the future, please try to
 verify bugs against the most recent Django release.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.2fe4fec0a90dd04868c8212a0d2cabc6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28885: Bottom parts of "Congratulations!" page cut off internationalized content

[Django]

#28885: Bottom parts of "Congratulations!" page cut off internationalized 
content
-+-
 Reporter:  Maciej Olko  |Owner:  Timothy
 |  Allen
 Type:  Bug  |   Status:  assigned
Component:  Core (Other) |  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  i18n, template,  | Triage Stage:  Accepted
  defaults   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Timothy Allen):

 * owner:  nobody => Timothy Allen
 * status:  new => assigned


Comment:

 We will tweak the design so it works in more languages, and test with
 Google Translate. Thanks for the catch!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c495ee0f5599698f964bac8279ea96db%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28896: GeoDjango PointField fails to generate query if filtering on a NULL value

[Django]

#28896: GeoDjango PointField fails to generate query if filtering on a NULL 
value
-+-
 Reporter:  William Li   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  QuerySet.extra   | Triage Stage:
  PointField GeoDjango   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by William Li):

 This is a suspicious commit, but I'm not well-versed enough in the query
 internals to know for sure:
 
https://github.com/django/django/commit/3b56f2191df0a437740182d49efe3be16c4d0d58

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.07cb4b763194e0c39503c68bf0f772d5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28886: Example included auth urls don't include accounts/ prefix assumed by much of the other documentation (was: Two different urls set are suggested for start with the authentication s

[Django]

#28886: Example included auth urls don't include accounts/ prefix assumed by 
much
of the other documentation
--+
 Reporter:  David Mugnai  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * type:  Uncategorized => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 [https://github.com/django/django/pull/9431 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1d12c95f9323b04a5ee131ca062a0787%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28896: GeoDjango PointField fails to generate query if filtering on a NULL value

[Django]

#28896: GeoDjango PointField fails to generate query if filtering on a NULL 
value
-+-
   Reporter:  William|  Owner:  nobody
  Li |
   Type:  Bug| Status:  new
  Component:  Database   |Version:  2.0
  layer (models, ORM)|   Keywords:  QuerySet.extra
   Severity:  Normal |  PointField GeoDjango
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Environment:
 * Python 3.6.3
 * postgres 9.6.6
 * Django 2.0

 Note: This was working under Django 1.11.7.

 {{{
 # models.py
 from django.contrib.gis.db import models

 class Restaurant(models.Model):
   location = models.PointField(blank=True, null=True, db_index=True)
 }}}


 {{{
 # tests.py
 from django.test import TestCase
 from restaurants.models import Restaurant


 class RestaurantTestCase(TestCase):
 def test_no_location(self):
 # Failing query
 Restaurant.objects.filter(location=None)
 }}}


 {{{
 $ python manage.py testCreating test database for alias 'default'...
 System check identified no issues (0 silenced).
 E
 ==
 ERROR: test_no_location (restaurants.tests.RestaurantTestCase)
 --
 Traceback (most recent call last):
   File "/home/wli/projects/point-field-bug/restaurants/tests.py", line 7,
 in test_no_location
 Restaurant.objects.filter(location=None)
   File "/home/wli/.envs/point-field-bug/lib/python3.6/site-
 packages/django/db/models/manager.py", line 82, in manager_method
 return getattr(self.get_queryset(), name)(*args, **kwargs)
   File "/home/wli/.envs/point-field-bug/lib/python3.6/site-
 packages/django/db/models/query.py", line 836, in filter
 return self._filter_or_exclude(False, *args, **kwargs)
   File "/home/wli/.envs/point-field-bug/lib/python3.6/site-
 packages/django/db/models/query.py", line 854, in _filter_or_exclude
 clone.query.add_q(Q(*args, **kwargs))
   File "/home/wli/.envs/point-field-bug/lib/python3.6/site-
 packages/django/db/models/sql/query.py", line 1252, in add_q
 clause, _ = self._add_q(q_object, self.used_aliases)
   File "/home/wli/.envs/point-field-bug/lib/python3.6/site-
 packages/django/db/models/sql/query.py", line 1276, in _add_q
 split_subq=split_subq,
   File "/home/wli/.envs/point-field-bug/lib/python3.6/site-
 packages/django/db/models/sql/query.py", line 1214, in build_filter
 condition = self.build_lookup(lookups, col, value)
   File "/home/wli/.envs/point-field-bug/lib/python3.6/site-
 packages/django/db/models/sql/query.py", line 1084, in build_lookup
 lookup = lookup_class(lhs, rhs)
   File "/home/wli/.envs/point-field-bug/lib/python3.6/site-
 packages/django/contrib/gis/db/models/lookups.py", line 23, in __init__
 super().__init__(lhs, rhs)
   File "/home/wli/.envs/point-field-bug/lib/python3.6/site-
 packages/django/db/models/lookups.py", line 18, in __init__
 self.rhs = self.get_prep_lookup()
   File "/home/wli/.envs/point-field-bug/lib/python3.6/site-
 packages/django/db/models/lookups.py", line 68, in get_prep_lookup
 return self.lhs.output_field.get_prep_value(self.rhs)
   File "/home/wli/.envs/point-field-bug/lib/python3.6/site-
 packages/django/contrib/gis/db/models/fields.py", line 188, in
 get_prep_value
 raise ValueError('Cannot use object with type %s for a spatial lookup
 parameter.' % type(obj).__name__)
 ValueError: Cannot use object with type NoneType for a spatial lookup
 parameter.

 --
 Ran 1 test in 0.005s

 FAILED (errors=1)
 Destroying test database for alias 'default'...

 }}}

 Workaround:
 {{{
 Restaurant.objects.extra(where=['location IS NULL'])
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/046.04078b331cacd86eb5fe0ffd3d0f74c0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28895: serialized_rollback = True causes an IntgrityError in LiveServerTestCase

[Django]

#28895: serialized_rollback = True causes an IntgrityError in LiveServerTestCase
-+-
   Reporter:  Lyra2108   |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Testing|Version:  1.8
  framework  |
   Severity:  Normal |   Keywords:  LiveServerTestCase
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Hey,

 the project I am working on creates a set of required objects e.g.
 Groups,... within the  database migrations. I would like this data also do
 be present, when I use LiveServerTestCases. But if I run the simple
 example below the 2nd test fails while the first is successful.
 If serialized_rollback = False, the tests fails like expected with a
 "DoesNotExist: Group matching query does not exist." exception.
 But if it is set to True, the exception changes to an integrity exception:
 {{{
 IntegrityError: duplicate key value violates unique constraint
 "django_content_type_app_label_45f3b1d93ec8c61c_uniq"
 DETAIL:  Key (app_label, model)=(contenttypes, contenttype) already
 exists.
 }}}

 Testcase:
 {{{
 from django.conf import settings
 from django.contrib.auth.models import Group
 from django.contrib.staticfiles.testing import StaticLiveServerTestCase


 class Test(StaticLiveServerTestCase):
 serialized_rollback = True

 @classmethod
 def setUpClass(cls):
 super(Test, cls).setUpClass()

 @classmethod
 def tearDownClass(cls):
 super(Test, cls).tearDownClass()

 def test_abc(self):
 group = Group.objects.get(name='groupname')
 assert group

 def test_def(self):
 group = Group.objects.get(name='groupname')
 assert group
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.d8931e9b66aefc2df7b5be0c0959d505%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28894: Invalid migrations caused by incorrect serialization of functools.partial()

[Django]

#28894: Invalid migrations caused by incorrect serialization of 
functools.partial()
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  closed
Component:  Migrations   |  Version:  1.9
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  functools partial| Triage Stage:
  migrations serialization   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 All right, I don't think it's worth adding a workaround to Django then.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.5b0477ca9323cbd8e26c6467a4c72331%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28836: Not nesting version of @atomic decorator

[Django]

#28836: Not nesting version of @atomic decorator
-+-
 Reporter:  Thomas Güttler   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * component:  Uncategorized => Database layer (models, ORM)
 * resolution:   => needsinfo
 * type:  Uncategorized => Cleanup/optimization


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.1d90dea1623ff341da7124396ce29241%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28893: Narrow dict.items() calls to .keys()/.items()

[Django]

#28893: Narrow dict.items() calls to .keys()/.items()
--+
 Reporter:  Дилян Палаузов|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Sergey Fedoseev):

 * cc: Sergey Fedoseev (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.cbf66b66416dcf87f23db262fa00bbac%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28894: Invalid migrations caused by incorrect serialization of functools.partial()

[Django]

#28894: Invalid migrations caused by incorrect serialization of 
functools.partial()
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  functools partial| Triage Stage:
  migrations serialization   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Nick Pope):

 Cool. Nice hack!

 I've just tried changing things to always have at least one keyword
 argument anyway.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9b7f6859f293e79533946cd52e69185c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28894: Invalid migrations caused by incorrect serialization of functools.partial()

[Django]

#28894: Invalid migrations caused by incorrect serialization of 
functools.partial()
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  functools partial| Triage Stage:
  migrations serialization   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 How about adding `**{}` to your code?
 {{{
 >>> print(functools.partial(int, '123', **{}).keywords)
 {}
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.636ba1a59a9ca84101b771bec19afc25%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28891: Document Origin's `loader` attribute (was: Origin's `loader` argument is not documented)

[Django]

#28891: Document Origin's `loader` attribute
--+
 Reporter:  Matthew Somerville|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted
 * type:  Uncategorized => Cleanup/optimization


Comment:

 The attribute was added in fc2147152637e21bc73f991b50fa06254af02739.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.f6ea9e059b06fa4c07b53173554c10e3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28892: Fixed header height in the admin site may break custom layouts (was: Fixed header height in the admin site)

[Django]

#28892: Fixed header height in the admin site may break custom layouts
---+
 Reporter:  Claude Paroz   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.9
 Severity:  Normal |   Resolution:
 Keywords:  css| Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Tim Graham):

 * version:  2.0 => 1.9
 * stage:  Unreviewed => Accepted


Old description:

> The new CSS rules for the admin header fixes the height to 40px. This is
> not nice for users customizing the header content (branding, usertools,
> userlinks blocks) with higher content. That content is then cut at 40px
> too.

New description:

 The
 
[https://github.com/django/django/commit/35901e64b043733acd1687734274553cf994511b#r26065458
 CSS rule] for the admin header fixes the height to 40px. This is not nice
 for users customizing the header content (branding, usertools, userlinks
 blocks) with higher content. That content is then cut at 40px too.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3464a8db0cef42630ce4833878bf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28894: Invalid migrations caused by incorrect serialization of functools.partial()

[Django]

#28894: Invalid migrations caused by incorrect serialization of 
functools.partial()
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  functools partial| Triage Stage:
  migrations serialization   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Nick Pope):

 Indeed - I know of the policies, it's just an awkward problem. I'm not
 sure... It might be possible to force everything through as keyword
 arguments because {{{args}}} is unaffected.

 I've updated the [[https://github.com/django/django/pull/9428|PR]] anyway
 so that it has a proper test...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.5dbf7c7586fd79456470c868939ff147%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28893: Narrow dict.items() calls to .keys()/.items()

[Django]

#28893: Narrow dict.items() calls to .keys()/.items()
--+
 Reporter:  Дилян Палаузов|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1
 * component:  Uncategorized => Core (Other)
 * stage:  Unreviewed => Accepted


Comment:

 `keys()` is generally unneeded. Something like `for name in
 tb_frame.f_locals` does an implicit keys; see
 21046e77734278cea871dce90bf29aa5b7b4. I guess you didn't test the
 patch as there's at least one mistake in `debug.py` that broke things.

 By the way, is there something preventing you from submitting patches on
 GitHub? If it's only the knowledge of how to to do, we have
 [https://docs.djangoproject.com/en/dev/intro/contributing/#committing-the-
 changes-in-the-patch a tutorial].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.ee4c33db37af8eefee1291fe0a9addf2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28883: Document that the uuid URL path converter requires lowercase letters (was: uuid URL path converter failed if UUID is anything but lowercase)

[Django]

#28883: Document that the uuid URL path converter requires lowercase letters
-+-
 Reporter:  Jean-Daniel  |Owner:  Daniel
 Type:   |  Leicht
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  uuid | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * type:  Bug => Cleanup/optimization
 * has_patch:  0 => 1
 * component:  Core (URLs) => Documentation
 * stage:  Unreviewed => Accepted


Comment:

 [https://github.com/django/django/pull/9429 Documentation PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.48bb435e93b46288fbade8e0d93fe5a2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28894: Invalid migrations caused by incorrect serialization of functools.partial()

[Django]

#28894: Invalid migrations caused by incorrect serialization of 
functools.partial()
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.9
 Severity:  Normal   |   Resolution:
 Keywords:  functools partial| Triage Stage:
  migrations serialization   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 I'm not sure if this merits fixing considering `functools.partial` support
 was added in Django 1.9 so this isn't a new or common (apparently)
 regression.  Also, regarding Python support, Django's policy is "We highly
 recommend and only officially support the latest release of each series."
 Can you workaround it in your project?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4c54597fa8f073b82e3301584f3cc28a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28894: Invalid migrations caused by incorrect serialization of functools.partial()

[Django]

#28894: Invalid migrations caused by incorrect serialization of 
functools.partial()
-+-
   Reporter:  Nick Pope  |  Owner:  Nick Pope
   Type:  Bug| Status:  assigned
  Component: |Version:  1.9
  Migrations |   Keywords:  functools partial
   Severity:  Normal |  migrations serialization
   Triage Stage: |  Has patch:  1
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 So this one was interesting... I ended up with a migration that contained
 something like this (reduced to a trivial example):

 {{{
 models.CharField(default=functools.partial(int, *('123', ), **None), ...)
 }}}

 The expected output should have been:

 {{{
 models.CharField(default=functools.partial(int, *('123', ), **{}), ...)
 }}}

 It boils down to the following issue:

 {{{
 # Python 2.7.6: Empty args working, empty keywords broken.
 >>> import functools
 >>> print(functools.partial(int, base=10).args)
 ()
 >>> print(functools.partial(int, '123').keywords)
 None
 }}}

 {{{
 # Python 2.7.14: Empty args working, empty keywords working.
 >>> import functools
 >>> print(functools.partial(int, base=10).args)
 ()
 >>> print(functools.partial(int, '123').keywords)
 {}
 }}}

 Scouring the release notes for Python, I found the following:

 "The keywords attribute of functools.partial is now always a
 dictionary."

 This was resolved in 2.7.10, 3.4.4 & 3.5.0.

 As Django 2.1 will only support Python 3.5 or later, this only needs to be
 backported to 1.11 and 2.0 and need not be applied to master.

 Pull request incoming...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.a795bdb77f9cdbd6365fe83de5f20f90%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28893: Narrow dict.items() calls to .keys()/.items()

[Django]

#28893: Narrow dict.items() calls to .keys()/.items()
-+-
 Reporter:  Дилян Палаузов   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Uncategorized|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Дилян Палаузов):

 * Attachment "narrow.patch" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.02130a6c9db8a8d5835fa96474e678a3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28893: Narrow dict.items() calls to .keys()/.items()

[Django]

#28893: Narrow dict.items() calls to .keys()/.items()
+
   Reporter:  Дилян Палаузов|  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Uncategorized |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/057.4e2d6a7d29579dbf7e87621c605418b6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28892: Fixed header height in the admin site

[Django]

#28892: Fixed header height in the admin site
-+
   Reporter:  Claude Paroz   |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  contrib.admin  |Version:  2.0
   Severity:  Normal |   Keywords:  css
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 The new CSS rules for the admin header fixes the height to 40px. This is
 not nice for users customizing the header content (branding, usertools,
 userlinks blocks) with higher content. That content is then cut at 40px
 too.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.a299f4b9e39d0ca69eb3832501a4af74%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28891: Origin's `loader` argument is not documented

[Django]

#28891: Origin's `loader` argument is not documented
--+
   Reporter:  Matthew Somerville  |  Owner:  nobody
   Type:  Uncategorized   | Status:  new
  Component:  Documentation   |Version:  1.11
   Severity:  Normal  |   Keywords:
   Triage Stage:  Unreviewed  |  Has patch:  1
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+
 This can cause an issue if you write a custom template loader that does
 not set loader when creating an `Origin()`, as e.g. the cached loader
 requires a loader parameter in order for its
 `origin.loader.get_contents(origin)` line to function.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.922cf21afb8685e8073ffaa161c08014%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28890: Broken layout due to whitespace in multiwidget rendering

[Django]

#28890: Broken layout due to whitespace in multiwidget rendering
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  whitespace,  | Triage Stage:  Accepted
  multiwidget, widgets   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"47681af34447e5d45f3fdb316497cdf9fbd0b7ce" 47681af3]:
 {{{
 #!CommitTicketReference repository=""
 revision="47681af34447e5d45f3fdb316497cdf9fbd0b7ce"
 [1.11.x] Fixed #28890 -- Removed newlines between MultiWidget's
 subwidgets.

 Regression in b52c73008a9d67e9ddbb841872dc15cdd3d6ee01.

 Backport of e014f91a70aa3ccdddb363a733c76e35597424fa from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.ee1fb6d65e4b9fa3f4fa665f51f767a1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28890: Broken layout due to whitespace in multiwidget rendering

[Django]

#28890: Broken layout due to whitespace in multiwidget rendering
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  whitespace,  | Triage Stage:  Accepted
  multiwidget, widgets   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"c1d57615ac60171a73e1922a48ebc27fe513357e" c1d57615]:
 {{{
 #!CommitTicketReference repository=""
 revision="c1d57615ac60171a73e1922a48ebc27fe513357e"
 [2.0.x] Fixed #28890 -- Removed newlines between MultiWidget's subwidgets.

 Regression in b52c73008a9d67e9ddbb841872dc15cdd3d6ee01.

 Backport of e014f91a70aa3ccdddb363a733c76e35597424fa from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.433e8d03c65c61adc9663d06be831cf5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28890: Broken layout due to whitespace in multiwidget rendering

[Django]

#28890: Broken layout due to whitespace in multiwidget rendering
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  whitespace,  | Triage Stage:  Accepted
  multiwidget, widgets   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e014f91a70aa3ccdddb363a733c76e35597424fa" e014f91]:
 {{{
 #!CommitTicketReference repository=""
 revision="e014f91a70aa3ccdddb363a733c76e35597424fa"
 Fixed #28890 -- Removed newlines between MultiWidget's subwidgets.

 Regression in b52c73008a9d67e9ddbb841872dc15cdd3d6ee01.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.d9da7a5e5ae191de77acb8700a946ac1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26974: Add support for Hash indexes (was: Support for Hash indexes)

[Django]

#26974: Add support for Hash indexes
-+-
 Reporter:  Akshesh Doshi|Owner:  Nick Pope
 Type:  New feature  |   Status:  assigned
Component:  contrib.postgres |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  hash, index, | Triage Stage:  Accepted
  postgres   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * component:  Database layer (models, ORM) => contrib.postgres
 * stage:  Unreviewed => Accepted


Comment:

 [https://github.com/django/django/pull/9424 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.af916f3e3766602af4f3e48d1d873783%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28883: uuid URL path converter failed if UUID is anything but lowercase

[Django]

#28883: uuid URL path converter failed if UUID is anything but lowercase
-+-
 Reporter:  Jean-Daniel  |Owner:  Daniel Leicht
 Type:  Bug  |   Status:  assigned
Component:  Core (URLs)  |  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  uuid | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jean-Daniel):

 A clean enough solution for my use case.

 That said, I think the uuid converter documentation should be updated to
 make it clear it expects lower case UUID (some people may need to parse
 upper case UUID and don't get why it fails).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.b1575b11b20c40104cfe5757c115e1d4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28887: Add support for SP-Gist indexes (was: Support for SP-Gist indexes)

[Django]

#28887: Add support for SP-Gist indexes
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  New feature  |   Status:  assigned
Component:  contrib.postgres |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  spgist, index,   | Triage Stage:  Accepted
  postgres   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


Old description:

> Add support for PostgreSQL SP-Gist indexes to
> {{{django.contrib.postgres}}}

New description:

 Add support for PostgreSQL SP-Gist indexes to `django.contrib.postgres`.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.209807a222b9c2a0812b917eb7b5a3e3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28890: Broken layout due to whitespace in multiwidget rendering

[Django]

#28890: Broken layout due to whitespace in multiwidget rendering
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  assigned
Component:  Forms|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:  whitespace,  | Triage Stage:  Accepted
  multiwidget, widgets   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.7d3b292dcf81efe67fd40b4516640940%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28877: Improve humanize’s |ordinal formatting

[Django]

#28877: Improve humanize’s |ordinal formatting
-+-
 Reporter:  Tzu-ping Chung   |Owner:  Tzu-ping
 |  Chung
 Type:  New feature  |   Status:  assigned
Component:  contrib.humanize |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.9c71777db57b83ec7744dbd8f3aba593%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms (was: Prevent double submission on admin forms)

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
--+
 Reporter:  Manuel Saelices   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * has_patch:  0 => 1
 * type:  Bug => Cleanup/optimization
 * needs_tests:  0 => 1


Comment:

 I found an article titled [http://www.the-art-of-
 web.com/javascript/doublesubmit/ JavaScript: Preventing Double Form
 Submission] which might be worth reviewing. In particular, it points out
 "Rather than simply disabling the button, we can also change the text so
 that people don't get confused."

 Did you consider trying to add some tests for the patch?

 I share Nick's concern on the pull request that this may have a good
 chance of causing some regression in unconsidered edge cases. I'm not sure
 if it's considered a best practice these days. The article suggests that
 some browsers (e.g. IE11) treat a double click as a single click.  It
 seems unfortunate if every project has to add something like this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.322bf1c01024d1883de2c58d5da7f27f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28885: Bottom parts of "Congratulations!" page cut off internationalized content

[Django]

#28885: Bottom parts of "Congratulations!" page cut off internationalized 
content
-+-
 Reporter:  Maciej Olko  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Other) |  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  i18n, template,  | Triage Stage:  Accepted
  defaults   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Claude Paroz):

 * cc: FlipperPA (added)
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.efd1640df56a93ab3ae51f3b5ac1de2a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28888: Index added to _meta.indexes with Meta.indexes=[] yields two equal addIndex() operations.

[Django]

#2: Index added to _meta.indexes with Meta.indexes=[] yields two equal
addIndex() operations.
-+-
 Reporter:  Jan Pieter   |Owner:  nobody
  Waagmeester|
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * component:  Migrations => Database layer (models, ORM)
 * type:  Uncategorized => Cleanup/optimization
 * stage:  Unreviewed => Someday/Maybe


Comment:

 Usually it's more effective to use the DevelopersMailingList to get
 feedback and consensus on design decisions as it reaches a wider audience
 than the ticket tracker.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.2c2837808b7dbc2ce057c684b886e798%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28888: Index added to _meta.indexes with Meta.indexes=[] yields two equal addIndex() operations.

[Django]

#2: Index added to _meta.indexes with Meta.indexes=[] yields two equal
addIndex() operations.
-+-
 Reporter:  Jan Pieter   |Owner:  nobody
  Waagmeester|
 Type:  Uncategorized|   Status:  new
Component:  Migrations   |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jan Pieter Waagmeester):

 I understand that "there's no documented support for adding indexes in
 `Field.contribute_to_class()`" and I'm open to suggestions to other
 solutions to add indexes with a field.

 But this seems the cleanest way to do it, and support seems to be almost
 there/halfway there. I'm willing to invest time to create a patch to fix
 this, but I'd like to have some degree of confidence that such a solution
 would be desirable functionality.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.5c79ea501b82b373aad2e6339b02da33%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28890: Broken layout due to whitespace in multiwidget rendering

[Django]

#28890: Broken layout due to whitespace in multiwidget rendering
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  Bug  |   Status:  assigned
Component:  Forms|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:  whitespace,  | Triage Stage:
  multiwidget, widgets   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Nick Pope):

 * Attachment "multiwidget-spacing-bug.png" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.89548160cd514578eea28c8fd21ad05f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28890: Broken layout due to whitespace in multiwidget rendering

[Django]

#28890: Broken layout due to whitespace in multiwidget rendering
-+-
   Reporter:  Nick Pope  |  Owner:  Nick Pope
   Type:  Bug| Status:  assigned
  Component:  Forms  |Version:  1.11
   Severity:  Normal |   Keywords:  whitespace,
   Triage Stage: |  multiwidget, widgets
  Unreviewed |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Since upgrading to 1.11, due to the addition of template-based widget
 rendering in #15667, I've experienced some form layouts breaking.

 This is due to the way that white-space is handled in the templates which
 was previously not an issue when strings were being joined in
 {{{MultiWidget.format_output()}}}.

 This may well affect more than {{{MultiWidget}}}.

 See the attached screenshot - top is how things looked before, bottom is
 how things look after upgrading to 1.11.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.e671338118670e89950086799c9d87ed%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28889: Prevent double submission on admin forms

[Django]

#28889: Prevent double submission on admin forms
-+
 Reporter:  Manuel Saelices  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Aymeric Augustin):

 * stage:  Unreviewed => Accepted


Comment:

 I think this is an improvement and the implementation looks reasonable.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.743edc7da34bf61716c92bb89198a143%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28883: uuid URL path converter failed if UUID is anything but lowercase

[Django]

#28883: uuid URL path converter failed if UUID is anything but lowercase
-+-
 Reporter:  Jean-Daniel  |Owner:  Daniel Leicht
 Type:  Bug  |   Status:  assigned
Component:  Core (URLs)  |  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  uuid | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Marten Kenbeek):

 The other converters accept upper- and lowercase, but they are not treated
 the same in general. E.g. DetailView does a case-sensitive lookup for the
 slug, so `/some-slug/` and `/Some-Slug/` do not refer to the same database
 object.

 You can quite easily override the UUID converter project-wide to accept
 upper- and lowercase UUIDs:

 {{{
 class CaseInsensitiveUUIDConverter(UUIDConverter):
 regex = '[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-
 fA-F]{4}-[0-9a-fA-F]{12}'

 register_converter(CaseInsensitiveUUIDConverter, 'uuid')
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.19e977dacf8499881d285fc36e0d6321%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28888: Index added to _meta.indexes with Meta.indexes=[] yields two equal addIndex() operations.

[Django]

#2: Index added to _meta.indexes with Meta.indexes=[] yields two equal
addIndex() operations.
-+-
 Reporter:  Jan Pieter   |Owner:  nobody
  Waagmeester|
 Type:  Uncategorized|   Status:  new
Component:  Migrations   |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jan Pieter Waagmeester):

 Possibly unrelated, but:

 When an initial migration is added without the index added to
 `cls._meta.indexes`, resulting in the output
 {{{
 ./manage.py makemigrations app
 Migrations for 'app':
   app/migrations/0001_initial.py
 - Create model Blog
 }}}

 No index is added, as expected.

 However, adding the index to `cls._meta.indexes` has no effect: `No
 changes detected in app 'app'`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ca398dddcdabd7991407d35d0e86f16b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28889: Prevent double submission on admin forms

[Django]

#28889: Prevent double submission on admin forms
-+--
 Reporter:  Manuel Saelices  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Old description:

> For fast clickers.

New description:

 For fast clickers.

--

Comment (by Manuel Saelices):

 Fixed on this Pull Request: https://github.com/django/django/pull/9425

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.10eee5a3f9b7e7ca57ef55547d64f0f7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28889: Prevent double submission on admin forms

[Django]

#28889: Prevent double submission on admin forms
---+
   Reporter:  Manuel Saelices  |  Owner:  nobody
   Type:  Bug  | Status:  new
  Component:  contrib.admin|Version:  1.11
   Severity:  Normal   |   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+
 For fast clickers.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.386964da24b13e4ce6db6389ad2133c6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28888: Index added to _meta.indexes with Meta.indexes=[] yields two equal addIndex() operations.

[Django]

#2: Index added to _meta.indexes with Meta.indexes=[] yields two equal
addIndex() operations.
-+-
 Reporter:  Jan Pieter   |Owner:  nobody
  Waagmeester|
 Type:  Uncategorized|   Status:  new
Component:  Migrations   |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Jan Pieter Waagmeester:

Old description:

> I use a custom field derived from
> `django.contrib.postgres.fields.JSONField`, which adds an `GinIndex` to
> `model._meta.indexes`:
> {{{
> from django.contrib.postgres.fields import JSONField
> from django.contrib.postgres.indexes import GinIndex
>
> class CustomJSONField(JSONField):
> def contribute_to_class(self, cls, name):
> super(CustomJSONField, self).contribute_to_class(cls, name)
>
> index = GinIndex(fields=[name])
> index.set_name_with_model(cls)
> cls._meta.indexes.append(index)
> }}}
>
> When used in a model like this,
> {{{
> class Blog(models.Model):
> title = models.CharField(max_length=100)
> json = CustomJSONField()
> }}}
>
> Migrations for model and index are created as expected:
> {{{
> ./manage.py --version
> 1.11.8
> ./manage.py makemigrations app
> Migrations for 'app':
>   app/migrations/0001_initial.py
> - Create model Blog
> - Create index app_blog_json_2cf556_gin on field(s) json of model
> blog
> }}}
>
> But when I add an empty list of indexes like this:
>
> {{{
> class Blog(models.Model):
> title = models.CharField(max_length=100)
> json = CustomJSONField()
>
> class Meta:
> indexes = []
> }}}
> two indexes are created:
>
> {{{
> rm -rf app/migrations
> ./manage.py --version
> 1.11.8
> ./manage.py makemigrations app
> Migrations for 'app':
>   app/migrations/0001_initial.py
> - Create model Blog
> - Create index app_blog_json_2cf556_gin on field(s) json of model
> blog
> - Create index app_blog_json_2cf556_gin on field(s) json of model
> blog
> }}}
>
> Which of course results in `django.db.utils.ProgrammingError: relation
> "app_blog_json_2cf556_gin" already exists`.

New description:

 I use a custom field derived from
 `django.contrib.postgres.fields.JSONField`, which adds an `GinIndex` to
 `model._meta.indexes`:
 {{{
 from django.contrib.postgres.fields import JSONField
 from django.contrib.postgres.indexes import GinIndex

 class CustomJSONField(JSONField):
 def contribute_to_class(self, cls, name):
 super(CustomJSONField, self).contribute_to_class(cls, name)

 index = GinIndex(fields=[name])
 index.set_name_with_model(cls)
 cls._meta.indexes.append(index)
 }}}

 When used in a model like this,
 {{{
 class Blog(models.Model):
 title = models.CharField(max_length=100)
 json = CustomJSONField()
 }}}

 Migrations for model and index are created as expected:
 {{{
 ./manage.py --version
 1.11.8
 ./manage.py makemigrations app
 Migrations for 'app':
   app/migrations/0001_initial.py
 - Create model Blog
 - Create index app_blog_json_2cf556_gin on field(s) json of model blog
 }}}

 But when I add an empty list of indexes to `class Meta` like this:

 {{{
 class Blog(models.Model):
 title = models.CharField(max_length=100)
 json = CustomJSONField()

 class Meta:
 indexes = []
 }}}
 two indexes are created:

 {{{
 rm -rf app/migrations
 ./manage.py --version
 1.11.8
 ./manage.py makemigrations app
 Migrations for 'app':
   app/migrations/0001_initial.py
 - Create model Blog
 - Create index app_blog_json_2cf556_gin on field(s) json of model blog
 - Create index app_blog_json_2cf556_gin on field(s) json of model blog
 }}}

 Which of course results in `django.db.utils.ProgrammingError: relation
 "app_blog_json_2cf556_gin" already exists`.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.f9b6ec76d4e56c727c51630164693296%40djangoproject.com.
For more options, visit 

[Django] #28888: Index added to _meta.indexes with Meta.indexes=[] yields two equal addIndex() operations.

[Django]

#2: Index added to _meta.indexes with Meta.indexes=[] yields two equal
addIndex() operations.
--+
   Reporter:  Jan Pieter Waagmeester  |  Owner:  nobody
   Type:  Uncategorized   | Status:  new
  Component:  Migrations  |Version:  1.11
   Severity:  Normal  |   Keywords:
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+
 I use a custom field derived from
 `django.contrib.postgres.fields.JSONField`, which adds an `GinIndex` to
 `model._meta.indexes`:
 {{{
 from django.contrib.postgres.fields import JSONField
 from django.contrib.postgres.indexes import GinIndex

 class CustomJSONField(JSONField):
 def contribute_to_class(self, cls, name):
 super(CustomJSONField, self).contribute_to_class(cls, name)

 index = GinIndex(fields=[name])
 index.set_name_with_model(cls)
 cls._meta.indexes.append(index)
 }}}

 When used in a model like this,
 {{{
 class Blog(models.Model):
 title = models.CharField(max_length=100)
 json = CustomJSONField()
 }}}

 Migrations for model and index are created as expected:
 {{{
 ./manage.py --version
 1.11.8
 ./manage.py makemigrations app
 Migrations for 'app':
   app/migrations/0001_initial.py
 - Create model Blog
 - Create index app_blog_json_2cf556_gin on field(s) json of model blog
 }}}

 But when I add an empty list of indexes like this:

 {{{
 class Blog(models.Model):
 title = models.CharField(max_length=100)
 json = CustomJSONField()

 class Meta:
 indexes = []
 }}}
 two indexes are created:

 {{{
 rm -rf app/migrations
 ./manage.py --version
 1.11.8
 ./manage.py makemigrations app
 Migrations for 'app':
   app/migrations/0001_initial.py
 - Create model Blog
 - Create index app_blog_json_2cf556_gin on field(s) json of model blog
 - Create index app_blog_json_2cf556_gin on field(s) json of model blog
 }}}

 Which of course results in `django.db.utils.ProgrammingError: relation
 "app_blog_json_2cf556_gin" already exists`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.87973ef6a467674c978e56432b43dfa7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28887: Support for SP-Gist indexes

[Django]

#28887: Support for SP-Gist indexes
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  New feature  |   Status:  assigned
Component:  contrib.postgres |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  spgist, index,   | Triage Stage:
  postgres   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Nick Pope):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6f0c80dbc9f74ce3c0e02323a5c555c5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26974: Support for Hash indexes

[Django]

#26974: Support for Hash indexes
-+-
 Reporter:  Akshesh Doshi|Owner:  Nick Pope
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  hash, index, | Triage Stage:
  postgres   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Nick Pope):

 * owner:  Akshesh Doshi => Nick Pope
 * keywords:  db-indexes => hash, index, postgres
 * stage:  Someday/Maybe => Unreviewed


Comment:

 As per my previous comment, hash indexes have been fixed in PostgreSQL 10.

 New pull request incoming...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.a172e170a63fbdb7725d428e0bf70d79%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28887: Support for SP-Gist indexes

[Django]

#28887: Support for SP-Gist indexes
-+-
   Reporter:  Nick Pope  |  Owner:  Nick Pope
   Type:  New| Status:  assigned
  feature|
  Component: |Version:  master
  contrib.postgres   |   Keywords:  spgist, index,
   Severity:  Normal |  postgres
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Add support for PostgreSQL SP-Gist indexes to
 {{{django.contrib.postgres}}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.74a5f606a703abe7e9d63003209e4d9a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28886: Two different urls set are suggested for start with the authentication subsystem

[Django]

#28886: Two different urls set are suggested for start with the authentication
subsystem
-+
   Reporter:  David Mugnai   |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Documentation  |Version:  1.11
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 In the "The login_required decorator" paragraph of the "Using the Django
 authentication system" guide is stated that the default url for the login
 view is "/accounts/login", but in the "Authentication Views" section all
 the examples don't use the "accounts/" part.

 I think  the examples should be changed to start with this code:
 {{{
 urlpatterns = [
 path('^accounts$', include('django.contrib.auth.urls')),
 ]
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.29aa61f204793fa2798232e1ecb31c38%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27392: Remove "Tests that", "Ensures that", etc. from test docstings

[Django]

#27392: Remove "Tests that", "Ensures that", etc. from test docstings
-+-
 Reporter:  Tim Graham   |Owner:  Harshit
 Type:   |  Agrawal
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Harshit Agrawal):

 * owner:  za => Harshit Agrawal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a267811c950943334c2125bf35bc5490%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28883: uuid URL path converter failed if UUID is anything but lowercase

[Django]

#28883: uuid URL path converter failed if UUID is anything but lowercase
-+-
 Reporter:  Jean-Daniel  |Owner:  Daniel Leicht
 Type:  Bug  |   Status:  assigned
Component:  Core (URLs)  |  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  uuid | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Daniel Leicht):

 As far as I understand their decision was to remove support for the
 general use of case insensitive URLs by using the Lmsu flags.
 If the author has a special use case (like matching a UUID) he can still
 use a regex like "[a-zA-Z]+" to match it.

 Btw, the string, slug & path converters were already case insensitive:

 {{{
 class StringConverter:
 regex = '[^/]+'

 def to_python(self, value):
 return value

 def to_url(self, value):
 return value

 class SlugConverter(StringConverter):
 regex = '[-a-zA-Z0-9_]+'


 class PathConverter(StringConverter):
 regex = '.+'


 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.421f4d56c1a167f52db0e453d0dd0640%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.