date:20171227

Re: [Django] #28867: Add a system check for a model property name that clashes with a foreign key id accessor

2017-12-27 Thread Django

#28867: Add a system check for a model property name that clashes with a foreign
key id accessor
-+-
 Reporter:  Michael  |Owner:
 Type:   |  shangdahao
  Cleanup/optimization   |   Status:  assigned
Component:  Core (System |  Version:  1.11
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by shangdahao):

 * status:  new => assigned
 * owner:  nobody => shangdahao


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.d5529b8a7c4259afcfd2f8c9cf7b7f8b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28867: Add a system check for a model property name that clashes with a foreign key id accessor

2017-12-27 Thread Django

#28867: Add a system check for a model property name that clashes with a foreign
key id accessor
--+
 Reporter:  Michael   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (System checks)  |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Description changed by shangdahao:

Old description:

> **Summary**
>
> Given a model with a foreign key field "foo", it would be helpful if
> Django warned users when they include a property in the model named
> "foo_id" in the same model.
>
> **Steps To Reproduce**
> - Implement a relationship that looks like Exhibit A
> - Create an instance of `Bar` using .create or FactoryBoy.
> - Observe the following stack trace that occurs in Exhibit B
>
> ** Expected Results**
> As a Django user, I expect the framework to warn me with a helpful error
> if I name a property method that doesn't play nice with Django's ORM.
>

>
> {{{
> // Exhibit A
>
> class Foo(models.Model):
>   pass
>
> Class Bar(model.Modal):
>   foo = models.FK(Foo)
>
>   @property
>   def foo_id(self):
> return self.foo.id
> }}}
>

>
> {{{
> // Exhibit B
> Traceback (most recent call last):
>   File "./manage.py", line 22, in 
> execute_from_command_line(sys.argv)
>   File "/usr/local/lib/python3.6/dist-
> packages/django/core/management/__init__.py", line 364, in
> execute_from_command_line
> utility.execute()
>   File "/usr/local/lib/python3.6/dist-
> packages/django/core/management/__init__.py", line 356, in execute
> self.fetch_command(subcommand).run_from_argv(self.argv)
>   File "/usr/local/lib/python3.6/dist-
> packages/django/core/management/base.py", line 283, in run_from_argv
> self.execute(*args, **cmd_options)
>   File "/usr/local/lib/python3.6/dist-
> packages/django/core/management/base.py", line 330, in execute
> output = self.handle(*args, **options)
>   File "/usr/local/lib/python3.6/dist-
> packages/django/core/management/commands/shell.py", line 101, in handle
> exec(sys.stdin.read())
>   File "", line 1, in 
>   File "/usr/local/lib/python3.6/dist-packages/factory/base.py", line 46,
> in __call__
> return cls.create(**kwargs)
>   File "/usr/local/lib/python3.6/dist-packages/factory/base.py", line
> 568, in create
> return cls._generate(enums.CREATE_STRATEGY, kwargs)
>   File "/usr/local/lib/python3.6/dist-packages/factory/base.py", line
> 505, in _generate
> return step.build()
>   File "/usr/local/lib/python3.6/dist-packages/factory/builder.py", line
> 279, in build
> kwargs=kwargs,
>   File "/usr/local/lib/python3.6/dist-packages/factory/base.py", line
> 314, in instantiate
> return self.factory._create(model, *args, **kwargs)
>   File "/usr/local/lib/python3.6/dist-packages/factory/django.py", line
> 165, in _create
> return manager.create(*args, **kwargs)
>   File "/usr/local/lib/python3.6/dist-
> packages/django/db/models/manager.py", line 85, in manager_method
> return getattr(self.get_queryset(), name)(*args, **kwargs)
>   File "/usr/local/lib/python3.6/dist-
> packages/django/db/models/query.py", line 392, in create
> obj = self.model(**kwargs)
>   File "/usr/local/lib/python3.6/dist-packages/django/db/models/base.py",
> line 555, in __init__
> _setattr(self, field.name, rel_obj)
>   File "/usr/local/lib/python3.6/dist-
> packages/django/db/models/fields/related_descriptors.py", line 253, in
> __set__
> setattr(instance, lh_field.attname, getattr(value, rh_field.attname))
> AttributeError: can't set attribute
> }}}

New description:

 **Summary**

 Given a model with a foreign key field "foo", it would be helpful if
 Django warned users when they include a property in the model named
 "foo_id" in the same model.

 **Steps To Reproduce**
 - Implement a relationship that looks like Exhibit A
 - Create an instance of `Bar` using .create or FactoryBoy.
 - Observe the following stack trace that occurs in Exhibit B

 ** Expected Results**
 As a Django user, I expect the framework to warn me with a helpful error
 if I name a property method that doesn't play nice with Django's ORM.



 {{{
 // Exhibit A

 class Foo(models.Model):
   pass

 class Bar(models.Model):
   foo = models.ForeignKey(Foo)

   @property
   def foo_id(self):
 return self.foo.id
 }}}



 {{{
 // Exhibit B
 Traceback (most recent call last):
   File "./manage.py", line 22, in 
 execute_from_command_line(sys.argv)
   File "/usr/local/lib/python3.6/dist-
 packages/django/core/manage

Re: [Django] #25817: Unable to rename a field reference in foreign key 'to_field'

2017-12-27 Thread Django

#25817: Unable to rename a field reference in foreign key 'to_field'
-+
 Reporter:  Simon Kelly  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  to_field rename  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Simon Charette):

 I added the remaining test coverage for `ForeignObject` while I was
 around. The patch should be ready for a final review.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9f35e3d6527a62eeaa7a00b91921c8c0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28841: rename GIS function ForceRHR to ForcePolygonCW

2017-12-27 Thread Django

#28841: rename GIS function ForceRHR to ForcePolygonCW
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 Type:   |  Fedoseev
  Cleanup/optimization   |   Status:  closed
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"aefe624c62639c189845803f0935fc29e20b5fb8" aefe624]:
 {{{
 #!CommitTicketReference repository=""
 revision="aefe624c62639c189845803f0935fc29e20b5fb8"
 Fixed #28841 -- Added ForcePolygonCW GIS function and deprecated ForceRHR.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.ad2ae25c98e2a6f10c03aab74833161f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28009: Document and test Field.empty_value for CharField subclasses

2017-12-27 Thread Django

#28009: Document and test Field.empty_value for CharField subclasses
-+-
 Reporter:  Matt Braymer-Hayes   |Owner:  Srinivas
 Type:   |  Reddy Thatiparthy
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Srinivas Reddy Thatiparthy):

 * owner:  (none) => Srinivas Reddy Thatiparthy
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.09806ea94d7e4814dfc0622b615ed8c5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28969: 400 error is 500 in production

2017-12-27 Thread Django

#28969: 400 error is 500 in production
---+--
 Reporter:  Mayaank Vadlamani  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Uncategorized  |  Version:  2.0
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => invalid
 * severity:  Release blocker => Normal


Comment:

 This ticket tracker is for reporting confirmed bugs in Django. Please see
 TicketClosingReasons/UseSupportChannels for ways to get help.  It's
 doubtful anyone will be able to help you if you don't provide a sample
 project that reproduces the problem..

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.cf69a14aa1b74f710806ef1f8874e37c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28117: loaddata raises ValueError with psycopg2 backend

2017-12-27 Thread Django

#28117: loaddata raises ValueError with psycopg2 backend
-+-
 Reporter:  Nicolas Kuttler  |Owner:  Srinivas
 Type:   |  Reddy Thatiparthy
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Management |  Version:  1.11
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Srinivas Reddy Thatiparthy):

 * owner:  nobody => Srinivas Reddy Thatiparthy
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.baabacc0568d63e139613b7dea84e60c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28967: Cast with FloatField rounds value to integer on MySQL

2017-12-27 Thread Django

#28967: Cast with FloatField rounds value to integer on MySQL
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"44908d4d9360f72b9511aa0a878458285ba326d4" 44908d4]:
 {{{
 #!CommitTicketReference repository=""
 revision="44908d4d9360f72b9511aa0a878458285ba326d4"
 Fixed #28967 -- Prevented Cast to FloatField from rounding to integer on
 MySQL.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.0b586f3cefb736f9f2318d21265872cf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28714: Add system checks for invalid model field names in Indexes

2017-12-27 Thread Django

#28714: Add system checks for invalid model field names in Indexes
-+-
 Reporter:  Gabriel  |Owner:
 Type:   |  shangdahao
  Cleanup/optimization   |   Status:  closed
Component:  Core (System |  Version:  1.11
  checks)|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  indexes, migrate,| Triage Stage:  Accepted
  makemigrations |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"f1aa58479cdc6051dd2e97feca2d584c43aee1e7" f1aa584]:
 {{{
 #!CommitTicketReference repository=""
 revision="f1aa58479cdc6051dd2e97feca2d584c43aee1e7"
 Fixed #28714 -- Added system checks for invalid model field names in
 Meta.indexes.

 Thanks Gabriel for the report and Adam Johnson for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.cefa2b2f315d72c758455aed25ae9b78%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28968: LiveServerTestCase prematurely closing HttpResponse with Django 2.0

2017-12-27 Thread Django

#28968: LiveServerTestCase prematurely closing HttpResponse with Django 2.0
---+--
 Reporter:  Alexander Todorov  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  HTTP handling  |  Version:  2.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Tim Graham):

 * cc: Tom Forbes (added)


Comment:

 It sounds similar to ac756f16c5bbbe544ad82a8f3ab2eac6cccdb62e. I'm not
 sure if anyone will be interested in debugging your project to find if
 Django is at fault.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.6ef1d25fd8d472fc228b8c3c270ac620%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28969: 400 error is 500 in production

2017-12-27 Thread Django

#28969: 400 error is 500 in production
-+
   Reporter:  Mayaank Vadlamani  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Uncategorized  |Version:  2.0
   Severity:  Release blocker|   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 When DEBUG=True all 404 errors work fine

 But when DEBUG=False every url that was a 404 in development is a 500
 error.
  Help!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.7f60c00debe853482dd2e95b14eaff6d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28968: LiveServerTestCase prematurely closing HttpResponse with Django 2.0

2017-12-27 Thread Django

#28968: LiveServerTestCase prematurely closing HttpResponse with Django 2.0
-+
   Reporter:  Alexander Todorov  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  HTTP handling  |Version:  2.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 I'm trying to migrate an existing project to Django 2.0 and I'm hitting a
 problem with some of our tests, all of the problematic tests are very
 similar in nature:

 1) They are all LiveServerTestCase based
 2) All of them have a XML-RPC client which issues requests to the Django
 app
 3) Using django-modern-rpc the application under test is able to execute a
 function and return a result
 3) All error out on the first request (most of the times) with traceback
 from the xmlrpc client module in Python telling me that that connection
 has been closed without a response.

 Here are the few data points I was able to collect:

 * Locally happens on both MySQL and SQLite but on SQLite less frequently,
 looks like a race condition. In Travis CI happens on SQLite but not on
 MySQL so go figure!
 * with a local MySQL instance I'm able to reproduce all the times
 * the root-cause seems to be in wsgiref.handlers.py::BaseHandler.run()
 which calls finish_response() which executes HttpResponse.close(). In
 run() there's also a comment about async servers and that they should not
 call .close() inside .finish_response()

 * if I modify Django's basehttp.py::ServerHandler.http_version to '1.0'
 all tests seem to pass regardless if we use a multi-threaded or single-
 threaded LiveServer!

 * This is on Python 3.5, RHEL 7 system.


 So it looks like the problem is with ServerHandler (presumably tests)
 wanting to use HTTP 1.1 but I can't narrow it down firther ATM.


 To reproduce you may checkout the code at
 https://github.com/kiwitcms/Kiwi;
 pip install -r requirements/devel.txt; pip install --upgrade Django and

 ./manage.py test --noinput  --settings=tcms.settings.test.mysql
 
tcms.xmlrpc.tests.test_logging.TestXMLRPCLogging.test_logging_with_authenticated_user

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.c89b77aee3d84bcdab5be7e3b9944789%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28965: Update cookie date format to follow RFC2616

2017-12-27 Thread Django

#28965: Update cookie date format to follow RFC2616
--+
 Reporter:  Alexey|Owner:  Alexey
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Utilities |  Version:  2.0
 Severity:  Normal|   Resolution:
 Keywords:  cookie| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Alexey):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/9499 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.28bbb5bdba577cff5e1afcbc9439b271%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28965: Update cookie date format to follow RFC2616

2017-12-27 Thread Django

#28965: Update cookie date format to follow RFC2616
--+
 Reporter:  Alexey|Owner:  Alexey
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Utilities |  Version:  2.0
 Severity:  Normal|   Resolution:
 Keywords:  cookie| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Alexey):

 * owner:  nobody => Alexey
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9fa351b42f610f85397749052ca187cb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28958: Admin changelist crashes when using query expression in the model's Meta.ordering or ModelAdmin.ordering

2017-12-27 Thread Django

#28958: Admin changelist crashes when using query expression in the model's
Meta.ordering or ModelAdmin.ordering
-+-
Reporter: Gabriel Amram|Owner: felixxm
Type: Bug | Status: closed
Component: contrib.admin| Version: 2.0
Severity: Release blocker | Resolution: fixed
Keywords: query expresssion, | Triage Stage: Accepted
ordering, admin, meta |
Has patch: 1| Needs documentation: 0
Needs tests: 0| Patch needs improvement: 0
Easy pickings: 0|UI/UX: 0
-+-

Comment (by Mariusz Felisiak ):

In [changeset:"8f67eeaef44ae8f1fcb51588a65f7818e4d7a967" 8f67eea]:
{{{
#!CommitTicketReference repository=""
revision="8f67eeaef44ae8f1fcb51588a65f7818e4d7a967"
[2.0.x] Refs #28958 -- Added a test for ModelAdmin with query expressions
in ordering.

This provides additional test coverage but isn't a regression test for
the ticket's issue.

Backport of 1d00923848d504c6132019492b8d5a6cdf8261db from master
}}}

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/071.5bcd23a4ad779986474bba7cfdccf4f4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28958: Admin changelist crashes when using query expression in the model's Meta.ordering or ModelAdmin.ordering

2017-12-27 Thread Django

#28958: Admin changelist crashes when using query expression in the model's
Meta.ordering or ModelAdmin.ordering
-+-
 Reporter:  Gabriel Amram|Owner:  felixxm
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  2.0
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  query expresssion,   | Triage Stage:  Accepted
  ordering, admin, meta  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"1d00923848d504c6132019492b8d5a6cdf8261db" 1d00923]:
 {{{
 #!CommitTicketReference repository=""
 revision="1d00923848d504c6132019492b8d5a6cdf8261db"
 Refs #28958 -- Added a test for ModelAdmin with query expressions in
 ordering.

 This provides additional test coverage but isn't a regression test for
 the ticket's issue.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.d2dc7422d49689cf7fd8699f1de58b0b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28948: CookieStorage performance issues

2017-12-27 Thread Django

#28948: CookieStorage performance issues
--+
 Reporter:  Michal Čihař  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.messages  |  Version:  2.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.ec558ac32b6f2a996cfbcdce59e76359%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28901: Document considerations with read committed isolation level and InnoDB

2017-12-27 Thread Django

#28901: Document considerations with read committed isolation level and InnoDB
-+-
 Reporter:  Dirkjan Ochtman  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Someday/Maybe


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.60413b353e7dc8df1f46ece6636fdebb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28858: Remove 'else' after 'return' or 'raise'

2017-12-27 Thread Django

#28858: Remove 'else' after 'return' or 'raise'
-+-
 Reporter:  Дилян Палаузов   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Someday/Maybe
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Someday/Maybe


Comment:

 The reporter already provided a patch and I created a
 [https://github.com/django/django/pull/9498 PR]. Opinions welcome.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.dacd03b346f4cb83319bc9cfa4c1e4fa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28900: QuerySet.values() and values_list() for union(), difference(), and intersection() queries fails with annotated subquery

2017-12-27 Thread Django

#28900: QuerySet.values() and values_list() for union(), difference(), and
intersection() queries fails with annotated subquery
-+-
 Reporter:  elliott-omosheye |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:  union, values| Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => duplicate


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.6a2eb27f408c0c247001e1883a9a2570%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28872: JSONField __in operator breaks when given a values_list()

2017-12-27 Thread Django

#28872: JSONField __in operator breaks when given a values_list()
--+
 Reporter:  Jerome Leclanche  |Owner:  (none)
 Type:  Bug   |   Status:  new
Component:  contrib.postgres  |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


Old description:

> Prerequisites
>
> 1. Create a model MyModel1 with the field `resource = JSONField()`.
> 2. Create another model MyModel2 with a field `id =
> CharField(max_length=255)`
>
> Reproduce by doing
> `MyModel1.objects.filter(resource__foo__id__in=MyModel2.objects.all().values_list("id"))`
>
> Expected result: Should look at MyModel1 for objects with `resource`
> matching `{"foo": {"id": }}`.
>
> Actual result:
>
> ERROR:  operator does not exist: jsonb = character varying
> LINE 1: ...AND ("resource" #> '{foo,id}') IN (SELECT...
>
> The actual issue is that when passing a values_list() to __in, the values
> list is not cast to jsonb (unlike when passing a text type). In the
> resulting sql, we can see `IN (SELECT U0."id" AS Col1 FROM mymodel2 U0
> ...)`. Wrapping `to_json(U0."id")` solves the issue.

New description:

 Prerequisites

 1. Create a model MyModel1 with the field `resource = JSONField()`.
 2. Create another model MyModel2 with a field `id =
 CharField(max_length=255)`

 Reproduce by doing
 
`MyModel1.objects.filter(resource__foo__id__in=MyModel2.objects.all().values_list("id"))`

 Expected result: Should look at MyModel1 for objects with `resource`
 matching `{"foo": {"id": }}`.

 Actual result:
 {{{
 ERROR:  operator does not exist: jsonb = character varying
 LINE 1: ...AND ("resource" #> '{foo,id}') IN (SELECT...
 }}}
 The actual issue is that when passing a `values_list()` to `__in`, the
 values list is not cast to jsonb (unlike when passing a text type). In the
 resulting sql, we can see `IN (SELECT U0."id" AS Col1 FROM mymodel2 U0
 ...)`. Wrapping `to_json(U0."id")` solves the issue.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.e4a6fb5c054b33e634617442e03fb0ba%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28967: Cast with FloatField rounds value to integer on MySQL

2017-12-27 Thread Django

#28967: Cast with FloatField rounds value to integer on MySQL
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Sergey Fedoseev):

 [https://github.com/django/django/pull/9497 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.e3f402667e413dbc7b8397ecf89341c2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28851: Support Open Ranges for Range Lookup - convert None to 'infinity'

2017-12-27 Thread Django

#28851: Support Open Ranges for Range Lookup - convert None to 'infinity'
-+-
 Reporter:  Sven R. Kunze|Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => needsinfo


Comment:

 Feel free to reopen if Simon's concerns are incorrect.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.ed5d3964dcac8d6696588dfc00118d29%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28805: Add a database function for RegexpReplace (was: Provide a new database function for RegexpReplace)

2017-12-27 Thread Django

#28805: Add a database function for RegexpReplace
-+-
 Reporter:  Joey Wilhelm |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


Comment:

 For a mergable patch, I think we would want both Oracle and PostgreSQL
 support.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.ed892f11c326e029a5451c89f3ae33d7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28752: Prevent django.setup() from running multiple times (was: django.setup() should not be runnable multiple times)

2017-12-27 Thread Django

#28752: Prevent django.setup() from running multiple times
--+
 Reporter:  pascal chambon|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * type:  Bug => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 I'm not completely sure if a change is feasible but I guess we could
 evaluate a patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.86c8be4bc2817c3027b7fe7995f5883e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28953: makemigrations with specified app label tries to connect to other databases that are not directly related

2017-12-27 Thread Django

#28953: makemigrations with specified app label tries to connect to other
databases
that are not directly related
-+-
Reporter: André Glatzl |Owner: nobody
Type: Bug | Status: closed
Component: Migrations | Version: 2.0
Severity: Normal | Resolution: needsinfo
Keywords: makemigrations | Triage Stage:
databases | Unreviewed
Has patch: 0| Needs documentation: 0
Needs tests: 0| Patch needs improvement: 0
Easy pickings: 0|UI/UX: 0
-+-
Changes (by Tim Graham):

* status: new => closed
* resolution: => needsinfo
* component: Uncategorized => Migrations

Comment:

I guess this is related to the migrations history consistency check (see
documentation in c93ac9cf42bff259ab71b70a89b693b9c38e4666). The need for a
change in Django isn't completely clear to me -- it sounds like you have
databases in your settings that you can't connect to. That doesn't sound
like a common use case, and I'm not convinced that Django should go to
great length to accommodate that setup. If you have a patch to share,
maybe we could reevaluate the idea.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.0be6a5c8acabe092880f689df67ab5a6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28964: RenameField after AddField after CreateModel in one operations list gives ProgrammingError: relation "field" does not exist

2017-12-27 Thread Django

#28964: RenameField after AddField after CreateModel in one operations list 
gives
ProgrammingError: relation "field" does not exist
--+--
 Reporter:  Matthew Pava  |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  Migrations|  Version:  1.11
 Severity:  Normal|   Resolution:  duplicate
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Please reopen, if needed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.104956f43d7c51af526e07993d17c941%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28967: Cast with FloatField rounds value to integer on MySQL

2017-12-27 Thread Django

#28967: Cast with FloatField rounds value to integer on MySQL
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.1467441342403332d795d3cc4851c924%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28958: Admin changelist crashes when using query expression in the model's Meta.ordering or ModelAdmin.ordering

2017-12-27 Thread Django

#28958: Admin changelist crashes when using query expression in the model's
Meta.ordering or ModelAdmin.ordering
-+-
 Reporter:  Gabriel Amram|Owner:  felixxm
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  2.0
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  query expresssion,   | Triage Stage:  Accepted
  ordering, admin, meta  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"b54302d2269e54cfc2a9594b1f3e652e1fd089ed" b54302d2]:
 {{{
 #!CommitTicketReference repository=""
 revision="b54302d2269e54cfc2a9594b1f3e652e1fd089ed"
 [2.0.x] Fixed #28958 -- Fixed admin changelist crash when using a query
 expression in the page's ordering.

 Thanks Tim Graham for the review.

 Backport of c8152137400b5932578cd1788b79560c9772e56b from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.909967c712a3932228cd8d0f24176601%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28920: AlterModelManagers migration is generated for all Models with custom Managers, which is not compatible with Django 1.8

2017-12-27 Thread Django

#28920: AlterModelManagers migration is generated for all Models with custom
Managers, which is not compatible with Django 1.8
--+--
Reporter: Michał Bońkowski |Owner: nobody
Type: Bug | Status: closed
Component: Migrations| Version: 1.11
Severity: Normal| Resolution: invalid
Keywords:| Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 |UI/UX: 0
--+--
Changes (by Tim Graham):

* status: new => closed
* resolution: => invalid

Comment:

The behavior changed in c0cf73a57d7f77af348aeb854e7b4f670dc3cee7 which
suggests the new behavior is desired.

To keep your migrations compatible with older versions of Django, you must
[https://docs.djangoproject.com/en/stable/topics/migrations/#supporting-
multiple-django-versions generate them with the oldest version of Django
that you wish to support], so I see no problem there.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.e88f50a6de7b79f1a60ed35e6f43093e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28958: Admin changelist crashes when using query expression in the model's Meta.ordering or ModelAdmin.ordering

2017-12-27 Thread Django

#28958: Admin changelist crashes when using query expression in the model's
Meta.ordering or ModelAdmin.ordering
-+-
 Reporter:  Gabriel Amram|Owner:  felixxm
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  2.0
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  query expresssion,   | Triage Stage:  Accepted
  ordering, admin, meta  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c8152137400b5932578cd1788b79560c9772e56b" c815213]:
 {{{
 #!CommitTicketReference repository=""
 revision="c8152137400b5932578cd1788b79560c9772e56b"
 Fixed #28958 -- Fixed admin changelist crash when using a query expression
 in the page's ordering.

 Thanks Tim Graham for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.0e7c0024df24e74afd3661c40d8af889%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28965: Update cookie date format to follow RFC2616

2017-12-27 Thread Django

#28965: Update cookie date format to follow RFC2616
--+
 Reporter:  Alexey|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Utilities |  Version:  2.0
 Severity:  Normal|   Resolution:
 Keywords:  cookie| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Alexey):

 For me it just cosmetic change.

 I think that there is no reason to support browser that is already
 unsupported.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.736f1d5523a08748ecb9b4757771f405%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28966: Document that the UUID URL path converter requires dashes

2017-12-27 Thread Django

#28966: Document that the UUID URL path converter requires dashes
--+
 Reporter:  Jahongir  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  2.0
 Severity:  Normal|   Resolution:  fixed
 Keywords:  urls  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"1b27374b0de49dd6afff80b730774bccc9551cc3" 1b27374b]:
 {{{
 #!CommitTicketReference repository=""
 revision="1b27374b0de49dd6afff80b730774bccc9551cc3"
 [2.0.x] Fixed #28966 -- Doc'd that the uuid URL path converter requires
 dashes

 Backport of 038ea4f8593618cf0f408f15f756f2145de0d40e from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.fe7dad97555041c2444b54050a9e853a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28966: Document that the UUID URL path converter requires dashes

2017-12-27 Thread Django

#28966: Document that the UUID URL path converter requires dashes
--+
 Reporter:  Jahongir  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  2.0
 Severity:  Normal|   Resolution:  fixed
 Keywords:  urls  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by GitHub ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"038ea4f8593618cf0f408f15f756f2145de0d40e" 038ea4f]:
 {{{
 #!CommitTicketReference repository=""
 revision="038ea4f8593618cf0f408f15f756f2145de0d40e"
 Fixed #28966 -- Doc'd that the uuid URL path converter requires dashes
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.9661826628b620d65ed497f4615572f2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28459: Improve performance of QuerySet

2017-12-27 Thread Django

#28459: Improve performance of QuerySet
-+-
 Reporter:  Sergey Fedoseev  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"ae1baa7d1d7fcb823e71ce9cb7c17de47ab2ff5e" ae1baa7d]:
 {{{
 #!CommitTicketReference repository=""
 revision="ae1baa7d1d7fcb823e71ce9cb7c17de47ab2ff5e"
 Refs #28459 -- Improved performance of loading DurationField on SQLite and
 MySQL.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.12dfd1599c3bf0ca48955881fbfd3e7f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #28967: Cast with FloatField rounds value to integer on MySQL

2017-12-27 Thread Django

#28967: Cast with FloatField rounds value to integer on MySQL
-+-
   Reporter:  Sergey |  Owner:  nobody
  Fedoseev   |
   Type:  Bug| Status:  new
  Component:  Database   |Version:  1.10
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 {{{
 In [6]: DurationModel.objects.annotate(f=models.functions.Cast(0.125,
 models.FloatField())).first().f
 Out[6]: 0.0

 In [7]: DurationModel.objects.annotate(f=models.functions.Cast(0.5,
 models.FloatField())).first().f
 Out[7]: 1.0
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.78e26a71638a704feb4b6276cdbfc88c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28967: Cast with FloatField rounds value to integer on MySQL

2017-12-27 Thread Django

#28967: Cast with FloatField rounds value to integer on MySQL
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 |  Fedoseev
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sergey Fedoseev):

 * owner:  nobody => Sergey Fedoseev
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.21c6920ae081cd6af8d8b3419d2c2821%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28965: Update cookie date format to follow RFC2616 (was: Wrong format for cookie 'expires')

2017-12-27 Thread Django

#28965: Update cookie date format to follow RFC2616
--+
 Reporter:  Alexey|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Utilities |  Version:  2.0
 Severity:  Normal|   Resolution:
 Keywords:  cookie| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Tim Graham):

 * type:  Bug => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 Hopefully nothing will break if we follow the newest RFC.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3f00effb3446580a6ca333ce4351af26%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28966: Document that the UUID URL path converter requires dashes (was: GUID without "-" is not recognized by url path)

2017-12-27 Thread Django

#28966: Document that the UUID URL path converter requires dashes
--+
 Reporter:  Jahongir  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  2.0
 Severity:  Normal|   Resolution:
 Keywords:  urls  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * type:  Bug => Cleanup/optimization
 * has_patch:  0 => 1
 * component:  Core (URLs) => Documentation
 * stage:  Unreviewed => Accepted


Comment:

 I think the same rationale as #28883 (only lower case letters are
 accepted) applies here as well.
 [https://github.com/django/django/pull/9496 PR] to document that rationale
 a bit more.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.861245a9ccd4228769943925912c3813%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28913: If MIGRATIONS_MODULES has a missing top-level package, proper error message is not displayed

2017-12-27 Thread Django

#28913: If MIGRATIONS_MODULES has a missing top-level package, proper error 
message
is not displayed
+
 Reporter:  oTree-org   |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.11
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.55afac31a8bbe8799c71e91c32f31d52%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28913: If MIGRATIONS_MODULES has a missing top-level package, proper error message is not displayed

2017-12-27 Thread Django

#28913: If MIGRATIONS_MODULES has a missing top-level package, proper error 
message
is not displayed
+--
 Reporter:  oTree-org   |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.11
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--

Comment (by oTree-org):

 Sure, I attached a sample project. Try running "python manage.py
 makemigrations foo" to reproduce the error.

 Repro steps, from scratch:

 - python manage.py startapp "foo"
 - Add "foo" to INSTALLED_APPS
 - Add a simple model in foo/models.py
 - Set:
 {{{
 MIGRATION_MODULES = {'foo': 'nonexisting_dir'}
 }}}
 - Run "python manage.py makemigrations foo".

 Expected: this should trigger the following error explaining that the
 'nonexisting_dir' package is missing and needs to be created first (this
 error message already exists in the source code but is unreachable because
 of faulty exception handling):

 {{{
 "Could not locate an appropriate location to create "
 "migrations package %s. Make sure the toplevel "
 "package exists and can be imported."
 }}}


 Actual result: uninformative error message

 {{{
 Traceback (most recent call last):
   File "C:\oTree\ve_dj11\lib\site-
 packages\django\core\management\commands\makemigrations.py", line 212, in
 write_migration_files
 migration_string = os.path.relpath(writer.path)
   File "C:\oTree\ve_dj11\lib\site-
 packages\django\db\migrations\writer.py", line 289, in path
 return os.path.join(self.basedir, self.filename)
   File "C:\oTree\ve_dj11\lib\site-
 packages\django\db\migrations\writer.py", line 256, in basedir
 base_module = import_module(".".join(existing_dirs))
   File
 
"C:\Users\wi\AppData\Local\Programs\Python\Python36-32\Lib\importlib\__init__.py",
 line 127, in import_module
 return _bootstrap._gcd_import(name[level:], package, level)
   File "", line 973, in _gcd_import
   File "", line 925, in _sanity_check
 ValueError: Empty module name
 }}}

 Without the proper error message, it's unclear how to fix the problem. I
 would not have guessed that the top-level package needs to exist; I would
 have expected "makemigrations foo" to create it for me.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.24c63ff80cbebbb5a720fc01ec7b5708%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28913: If MIGRATIONS_MODULES has a missing top-level package, proper error message is not displayed

2017-12-27 Thread Django

#28913: If MIGRATIONS_MODULES has a missing top-level package, proper error 
message
is not displayed
+--
 Reporter:  oTree-org   |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.11
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by oTree-org):

 * Attachment "bug28913.zip" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6e9c6a12761ecb07d54c2d2c8fb24aaf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28913: If MIGRATIONS_MODULES has a missing top-level package, proper error message is not displayed

2017-12-27 Thread Django

#28913: If MIGRATIONS_MODULES has a missing top-level package, proper error 
message
is not displayed
+--
 Reporter:  oTree-org   |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.11
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Tim Graham):

 * component:  Uncategorized => Migrations


Comment:

 Could you give a concrete example of the problem? I'm having difficulty
 translating your description into steps to reproduce.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.104403b5ade4516c6e0aab94bc47371b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28965: Wrong format for cookie 'expires'

2017-12-27 Thread Django

#28965: Wrong format for cookie 'expires'
---+--
 Reporter:  Alexey |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Utilities  |  Version:  2.0
 Severity:  Normal |   Resolution:
 Keywords:  cookie | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by Sergey Fedoseev):

 * cc: Sergey Fedoseev (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9007b71d7d0fe224d77667f9850820b2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28965: Wrong format for cookie 'expires'

2017-12-27 Thread Django

Comment (by Sergey Fedoseev):

`expires` cookie is defined by
[https://tools.ietf.org/html/rfc6265#section-5.2.1 RFC 6265 (April 2011)].
It says that server [https://tools.ietf.org/html/rfc6265#section-4.1.1
SHOULD] format `expires` cookie value as
[https://tools.ietf.org/html/rfc2616#section-3.3.1 rfc1123-date, defined
in RFC2616] (without hyphens). User agent
[https://tools.ietf.org/html/rfc6265#section-5.1.1 MUST] parse that value
more permissively, for example allow hyphens as delimiters.
Currently Django uses format defined by pre-RFC

"[https://web.archive.org/web/20020803110822/http://wp.netscape.com/newsref/std/cookie_spec.html
Netscape cookie specification]" mentioned in the
[https://tools.ietf.org/html/rfc6265#section-1 introduction of RFC 6265].
Perhaps IE understands only that format
https://blogs.msdn.microsoft.com/ieinternals/2009/08/20/internet-explorer-
cookie-internals-faq/.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.ef24af3efaafadaa6ebf7c6aca64034e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

45 matches

Mail list logo