Re: [Django] #29321: when instance.delete() while cause memory leak

[Django]

#29321: when instance.delete() while cause memory leak
-+-
 Reporter:  yywing   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by yywing):

 * component:  Uncategorized => Database layer (models, ORM)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.381afe009a580bf0d91621354f7a05bf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #29321: when instance.delete() while cause memory leak

[Django]

#29321: when instance.delete() while cause memory leak
-+
   Reporter:  yywing |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Uncategorized  |Version:  2.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 {{{
 class A(models.Model):
 xxx
 class B(models.Model):
 a = models.ForeignKey(A, on_delete=models.CASCADE)
 x
 class C(models.Model):
 b = models.ForeignKey(B, on_delete=models.CASCADE)
 xx
 A.objects.first().delete()
 }}}
 When I delete an instance of A, if A has is related with many B and B is
 related with many C, then it will cause memory leak.
 And I found django on_delete has no effect at SQL level.
 And I really want that when I delete A ,related B is deleted.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.33ed946f5754146a2506a054a9ef7c7f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29286: QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

[Django]

#29286: QuerySet.values_list() crashes when combining annotated and 
not-annotated
querysets with union().
-+-
 Reporter:  felixxm  |Owner:  felixxm
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.8a8a985f8ac825c052d53228682473c4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29320: Add an exception when an annotation alias matches a ForeignKey attname

[Django]

#29320: Add an exception when an annotation alias matches a ForeignKey attname
-+-
 Reporter:  Flávio Juvenal   |Owner:  Flávio
 |  Juvenal
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e1f13f15512ece2d8ea8c7bf9f704ce4286c2ffa" e1f13f15]:
 {{{
 #!CommitTicketReference repository=""
 revision="e1f13f15512ece2d8ea8c7bf9f704ce4286c2ffa"
 Fixed #29320 -- Added an exception when an annotation alias matches a
 ForeignKey attname.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.1b24961162e3975407df5c9a720be874%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29320: Add an exception when an annotation alias matches a ForeignKey attname (was: No exception when an Annotation alias matches a ForeignKey attname)

[Django]

#29320: Add an exception when an annotation alias matches a ForeignKey attname
-+-
 Reporter:  Flávio Juvenal   |Owner:  Flávio
 |  Juvenal
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.02952e9f7d00b4c8dd060e8e069a95d6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22538: Support for HTML5 Date and Time input fields

[Django]

#22538: Support for HTML5 Date and Time input fields
---+--
 Reporter:  me@…   |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Forms  |  Version:  1.6
 Severity:  Normal |   Resolution:  duplicate
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by W. Trevor King):

 * cc: W. Trevor King (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.10ffacaed9e992624fc8e61654735478%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11385: DateTimeField doesn't accept ISO 8601 formatted date string

[Django]

#11385: DateTimeField doesn't accept ISO 8601 formatted date string
-+
 Reporter:  Jani Tiainen |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  datetime orm format  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by W. Trevor King):

 * cc: W. Trevor King (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.8f6ba516242fc11240ecfd0f3817a24e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22538: Support for HTML5 Date and Time input fields

[Django]

#22538: Support for HTML5 Date and Time input fields
---+--
 Reporter:  me@…   |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Forms  |  Version:  1.6
 Severity:  Normal |   Resolution:  duplicate
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--

Comment (by W. Trevor King):

 For folks finding this (old) issue and wondering which issue this is a
 duplicate of, I'm guessing it's #16630 based on comment:2:ticket:21470
 closing a similar request for native type="date", etc.  There's also some
 related (and slightly more recent) discussion in #11385.

 And since
 
[https://github.com/django/django/commit/f1bdfbd24bcc76d21c4bf7442959bdf630ac4dec
 f1bdfbd2 (v1.5a)], you've been able to explicitly set `type` via `attrs`,
 so folks who want a specific input type can make that happen.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.5e8b069b444588ea4bc9e43f94fc5be3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

[Django]

#19580: Unify reverse foreign key and m2m unsaved model querying
-+-
 Reporter:  Anssi Kääriäinen |Owner:  Rajesh
 Type:   |  Veeranki
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Rajesh Veeranki):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.bae4c777020b5d795c2ded55abcc02c1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28553: Querysets: annotate() columns are forced into a certain position which may disrupt union()

[Django]

#28553: Querysets: annotate() columns are forced into a certain position which 
may
disrupt union()
-+-
 Reporter:  David Sanders|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Flávio Juvenal):

 I've stumbled upon a case in production where this limitation prevents me
 for making a useful query. I've been able to create a test to reproduce
 this problem.
 It works with sqlite but fails with postgres.

 Add this test to {{{tests/queries/test_qs_combinators.py}}}:
 {{{
 #!python
 from django.db.models import F, IntegerField, TextField, Value

 def test_union_with_two_annotated_values_on_different_models(self):
 qs1 = Number.objects.annotate(
 text_annotation=Value('Foo', TextField())
 ).values('text_annotation', 'num')
 qs2 = ReservedName.objects.annotate(
 int_annotation=Value(1, IntegerField()),
 ).values('name', 'int_annotation')
 self.assertEqual(qs1.union(qs2).count(), 10)
 }}}

 In current master (`78f8b80f9b215e50618375adce4c97795dabbb84`), running
 {{{./runtests.py --parallel=1 --settings=tests.test_postgres
 
queries.test_qs_combinators.QuerySetSetOperationTests.test_union_with_two_annotated_values_on_different_models}}}
 fails:
 {{{
 Testing against Django installed in 'django/django'
 Creating test database for alias 'default'...
 Creating test database for alias 'other'...
 System check identified no issues (1 silenced).
 E
 ==
 ERROR: test_union_with_two_annotated_values_on_different_models
 (queries.test_qs_combinators.QuerySetSetOperationTests)
 --
 Traceback (most recent call last):
   File "django/django/db/backends/utils.py", line 85, in _execute
 return self.cursor.execute(sql, params)
 psycopg2.ProgrammingError: UNION types integer and character varying
 cannot be matched
 LINE 1: ..._annotation" FROM "queries_number") UNION (SELECT "queries_r...
  ^


 The above exception was the direct cause of the following exception:

 Traceback (most recent call last):
   File "django/tests/queries/test_qs_combinators.py", line 140, in
 test_union_with_two_annotated_values_on_different_models
 self.assertEqual(qs1.union(qs2).count(), 10)
   File "django/django/db/models/query.py", line 382, in count
 return self.query.get_count(using=self.db)
   File "django/django/db/models/sql/query.py", line 494, in get_count
 number = obj.get_aggregation(using, ['__count'])['__count']
   File "django/django/db/models/sql/query.py", line 479, in
 get_aggregation
 result = compiler.execute_sql(SINGLE)
   File "django/django/db/models/sql/compiler.py", line 1054, in
 execute_sql
 cursor.execute(sql, params)
   File "django/django/db/backends/utils.py", line 68, in execute
 return self._execute_with_wrappers(sql, params, many=False,
 executor=self._execute)
   File "django/django/db/backends/utils.py", line 77, in
 _execute_with_wrappers
 return executor(sql, params, many, context)
   File "django/django/db/backends/utils.py", line 85, in _execute
 return self.cursor.execute(sql, params)
   File "django/django/db/utils.py", line 89, in __exit__
 raise dj_exc_value.with_traceback(traceback) from exc_value
   File "django/django/db/backends/utils.py", line 85, in _execute
 return self.cursor.execute(sql, params)
 django.db.utils.ProgrammingError: UNION types integer and character
 varying cannot be matched
 LINE 1: ..._annotation" FROM "queries_number") UNION (SELECT "queries_r...
  ^


 --
 Ran 1 test in 0.007s

 FAILED (errors=1)
 Destroying test database for alias 'default'...
 Destroying test database for alias 'other'...
 }}}

 My {{{tests/test_postgres.py}}} is:
 {{{
 DATABASES = {
 'default': {
 'ENGINE': 'django.db.backends.postgresql_psycopg2',
 'NAME': 'django-test',
 'HOST': '127.0.0.1',
 },
 'other': {
 'ENGINE': 'django.db.backends.postgresql_psycopg2',
 'NAME': 'django-test-other',
 }
 }

 SECRET_KEY = "django_tests_secret_key"

 # Use a fast 

Re: [Django] #29320: No exception when an Annotation alias matches a ForeignKey attname

[Django]

#29320: No exception when an Annotation alias matches a ForeignKey attname
-+-
 Reporter:  Flávio Juvenal   |Owner:  Flávio
 |  Juvenal
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Flávio Juvenal:

Old description:

> Looks like the solution for "#11256 Fail loudly and clearly when an
> Annotation alias matches a field name" doesn't consider foreign keys
> {{{attname}}}s, e.g. {{author_id}}.
>
> Here's a failing test, add it to aggregation_regress/tests.py:
> {{{
> #!python
> def test_fk_attname_conflict(self):
> msg = "The annotation 'contact_id' conflicts with a field on the
> model."
> with self.assertRaisesMessage(ValueError, msg):
> Book.objects.annotate(contact_id=F('publisher_id'))
> }}}
>
> PR here: https://github.com/django/django/pull/9873/files

New description:

 Looks like the solution for "#11256 Fail loudly and clearly when an
 Annotation alias matches a field name" doesn't consider foreign keys
 {{{attname}}}s, e.g. {{{author_id}}}.

 Here's a failing test, add it to aggregation_regress/tests.py:
 {{{
 #!python
 def test_fk_attname_conflict(self):
 msg = "The annotation 'contact_id' conflicts with a field on the
 model."
 with self.assertRaisesMessage(ValueError, msg):
 Book.objects.annotate(contact_id=F('publisher_id'))
 }}}

 PR here: https://github.com/django/django/pull/9873/files

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.9ca849637735accfafa43c6e6ce17ae5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29320: No exception when an Annotation alias matches a ForeignKey attname

[Django]

#29320: No exception when an Annotation alias matches a ForeignKey attname
-+-
 Reporter:  Flávio Juvenal   |Owner:  Flávio
 |  Juvenal
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Flávio Juvenal):

 * owner:  Flávio Juvenal => Flávio Juvenal


Old description:

> Looks like the solution for "#11256 Fail loudly and clearly when an
> Annotation alias matches a field name" doesn't consider foreign keys
> {{{attname}}}s, e.g. {{author_id}}.
>
> Here's a failing test, add it to aggregation_regress/tests.py:
> {{{
> #!python
> def test_fk_id_name_conflict(self):
> msg = "The annotation 'contact_id' conflicts with a field on the
> model."
> with self.assertRaisesMessage(ValueError, msg):
> Book.objects.annotate(contact_id=F('publisher_id'))
> }}}
>
> I'll make a PR soon.

New description:

 Looks like the solution for "#11256 Fail loudly and clearly when an
 Annotation alias matches a field name" doesn't consider foreign keys
 {{{attname}}}s, e.g. {{author_id}}.

 Here's a failing test, add it to aggregation_regress/tests.py:
 {{{
 #!python
 def test_fk_attname_conflict(self):
 msg = "The annotation 'contact_id' conflicts with a field on the
 model."
 with self.assertRaisesMessage(ValueError, msg):
 Book.objects.annotate(contact_id=F('publisher_id'))
 }}}

 PR here: https://github.com/django/django/pull/9873/files

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.e0f2c41ba7ce94e6b1e7523ec1d1fbbe%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #29320: No exception when an Annotation alias matches a ForeignKey attname

[Django]

#29320: No exception when an Annotation alias matches a ForeignKey attname
-+-
   Reporter:  Flávio |  Owner:  Flávio Juvenal
  Juvenal|
   Type:  Bug| Status:  assigned
  Component:  Database   |Version:  master
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  1
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Looks like the solution for "#11256 Fail loudly and clearly when an
 Annotation alias matches a field name" doesn't consider foreign keys
 {{{attname}}}s, e.g. {{author_id}}.

 Here's a failing test, add it to aggregation_regress/tests.py:
 {{{
 #!python
 def test_fk_id_name_conflict(self):
 msg = "The annotation 'contact_id' conflicts with a field on the
 model."
 with self.assertRaisesMessage(ValueError, msg):
 Book.objects.annotate(contact_id=F('publisher_id'))
 }}}

 I'll make a PR soon.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/047.c5d06bacd2ec507c8e2cdf5bf1e3e22d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29296: admindocs ViewIndexView crashes if a syndication Feed (or something without __qualname__) is configured

[Django]

#29296: admindocs ViewIndexView crashes if a syndication Feed (or something 
without
__qualname__) is configured
-+-
 Reporter:  Paul Donohue |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admindocs|  Version:  2.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"979253fce9c0bb6ee484a5a786d477a47545d972" 979253f]:
 {{{
 #!CommitTicketReference repository=""
 revision="979253fce9c0bb6ee484a5a786d477a47545d972"
 [1.11.x] Fixed #29296 -- Fixed crashes in admindocs when a view is a
 callable object.

 Backport of 33a0b7ac815588ed92dca215e153390af8bdbdda from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.97362c446d3a1200cd20dd974e71c9b9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29296: admindocs ViewIndexView crashes if a syndication Feed (or something without __qualname__) is configured

[Django]

#29296: admindocs ViewIndexView crashes if a syndication Feed (or something 
without
__qualname__) is configured
-+-
 Reporter:  Paul Donohue |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admindocs|  Version:  2.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"1ed31efb8753f6c4fd263033ddebc2f008e43a68" 1ed31efb]:
 {{{
 #!CommitTicketReference repository=""
 revision="1ed31efb8753f6c4fd263033ddebc2f008e43a68"
 [2.0.x] Fixed #29296 -- Fixed crashes in admindocs when a view is a
 callable object.

 Backport of 33a0b7ac815588ed92dca215e153390af8bdbdda from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.cab8ba98618129160e5343e076f32251%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29296: admindocs ViewIndexView crashes if a syndication Feed (or something without __qualname__) is configured

[Django]

#29296: admindocs ViewIndexView crashes if a syndication Feed (or something 
without
__qualname__) is configured
-+-
 Reporter:  Paul Donohue |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admindocs|  Version:  2.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"33a0b7ac815588ed92dca215e153390af8bdbdda" 33a0b7ac]:
 {{{
 #!CommitTicketReference repository=""
 revision="33a0b7ac815588ed92dca215e153390af8bdbdda"
 Fixed #29296 -- Fixed crashes in admindocs when a view is a callable
 object.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ffdc21a75799f0b2de1eae1f086e162d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29319: post_delete signals is sent before objects are deleted (was: post_delete signals is)

[Django]

#29319: post_delete signals is sent before objects are deleted
-+-
 Reporter:  Nicolas Ippolito |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.74228bcebdca8bd547569e22effe6f5b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29286: QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

[Django]

#29286: QuerySet.values_list() crashes when combining annotated and 
not-annotated
querysets with union().
-+-
 Reporter:  felixxm  |Owner:  felixxm
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Ready for checkin => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.90e45f71f18cd0d4d8b0097959cf5549%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29296: admindocs ViewIndexView crashes if a syndication Feed (or something without __qualname__) is configured

[Django]

#29296: admindocs ViewIndexView crashes if a syndication Feed (or something 
without
__qualname__) is configured
-+-
 Reporter:  Paul Donohue |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admindocs|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.30df2b4b431a9a0dd1110a551b2bce1c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29296: admindocs ViewIndexView crashes if a syndication Feed (or something without __qualname__) is configured

[Django]

#29296: admindocs ViewIndexView crashes if a syndication Feed (or something 
without
__qualname__) is configured
---+
 Reporter:  Paul Donohue   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admindocs  |  Version:  2.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Carlton Gibson):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.78e8c9d160800df9b7610a13bbf77789%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29319: post_delete signals is

[Django]

#29319: post_delete signals is
-+-
 Reporter:  Nicolas Ippolito |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 > The post_delete signals is sent before objects are really deleted.

 The `post_delete` signal is correctly sent once the objects are deleted
 from the database.

 > For exemple, for "Document" objects, the file is not yet removed in the
 file system...

 Django hasn't been deleting files referenced by `FileField` on model
 deletion [https://docs.djangoproject.com/en/2.0/releases/1.3/#deleting-a
 -model-doesn-t-delete-associated-files since Django 1.3].

 Please re-open with more details if I missed something.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.3059752a40dfe6eff9b623ab02e9b490%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29286: QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

[Django]

#29286: QuerySet.values_list() crashes when combining annotated and 
not-annotated
querysets with union().
-+-
 Reporter:  felixxm  |Owner:  felixxm
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.5a8b846cb9ae65557975d1abc4ebdf50%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29318: ValidationError has no attribute `error_list` if message is a dict, but Field.run_validators() depends on it

[Django]

#29318: ValidationError has no attribute `error_list` if message is a dict, but
Field.run_validators() depends on it
---+--
 Reporter:  Michael Käufl  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Core (Other)   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Simon Charette):

 I think that `Field.run_validators()` should not to handle `dict` based
 `ValidationError` as they should only be used to map concrete fields to
 errors in multi-fields cleaning functions (e.g. `Form.clean()`,
 `Model.clean()`). Since `Field` instances cannot have nested-fields I
 wouldn't expect `dict` to be handled.

 In your `JSONField` subclass example you're using an invalid `key` as your
 field mapping. This `key` doesn't map to any field and raising
 `ValidationError(f'Key {key} not allowed.')` within the field would be
 more appropriate.

 Keep in mind that errors have to be ultimately flattened to a `{field_name
 -> error_list}` map at the form/model level while a different model is
 used for DRF serializers since they have nested fields.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.00d692d1bc5c3e4186a02bc7ae2c60cb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #29319: post_delete signals is

[Django]

#29319: post_delete signals is
-+-
   Reporter:  nippo  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Database   |Version:  2.0
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 
https://github.com/django/django/blob/ee17bb8a67a9e7e688da6e6f4b3be1b3a69c09b0/django/db/models/deletion.py#L305


 The post_delete signals is sent before objects are really deleted. For
 exemple, for "Document" objects, the file is not yet removed in the file
 system...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.26c32582b17dea657568c765b6c6eac7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29286: QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

[Django]

#29286: QuerySet.values_list() crashes when combining annotated and 
not-annotated
querysets with union().
-+-
 Reporter:  felixxm  |Owner:  felixxm
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * has_patch:  0 => 1
 * version:  2.0 => 1.11


Comment:

 [https://github.com/django/django/pull/9872 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.63cfb245ae5017ebc07f0d9183efdf8a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29313: Add documentation for how to use F() expressions in combination with nulls_last

[Django]

#29313: Add documentation for how to use F() expressions in combination with
nulls_last
-+-
 Reporter:  drd0013  |Owner:  drd0013
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Documentation|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:  F Expression | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.adbbecfc4dcb2f757e3ada96454013de%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29305: GET or POST requests outside of the browser to the LiveServerTestCase server hang

[Django]

#29305: GET or POST requests outside of the browser to the LiveServerTestCase
server hang
---+--
 Reporter:  Santiago García|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  1.11
 Severity:  Normal |   Resolution:
 Keywords:  Test   | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Santiago García):

 Yes, it does work for me on Django 2.0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.af3d1b5a79a8968748fcec93d075b9c9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29318: ValidationError has no attribute `error_list` if message is a dict, but Field.run_validators() depends on it

[Django]

#29318: ValidationError has no attribute `error_list` if message is a dict, but
Field.run_validators() depends on it
---+--
 Reporter:  Michael Käufl  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Core (Other)   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Michael Käufl):

 Sure.  Consider a JSONField with an allowed list of keys:

 {{{
 if key not in allowed_keys:
 raise ValidationError({key: 'Not allowed.'})
 }}}

 We use these exceptions not only for the admin, but also for API error
 messages through django rest framework's [http://www.django-rest-
 framework.org/api-guide/exceptions/#custom-exception-handling custom
 exception handling].  This is also the reason, why we use the field's name
 in some other (therefore non-generic) validators.  Using the field's name
 as key in the error_dict, allows our front-end to display the error
 message at the affected field and not as a generic error message of the
 form.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a702ef746b4539271001a43ba9b1f738%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.