Re: [Django] #29834: Union queryset with ordering breaks on ordering with derived querysets

2018-11-01 Thread Django
#29834: Union queryset with ordering breaks on ordering with derived querysets
-+-
 Reporter:  Sergei Maertens  |Owner:  Can
 |  Sarıgöl
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  orm, union,  | Triage Stage:  Accepted
  ordering   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


Comment:

 Tests aren't passing.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.3862969bef151c650b45cfd4a1105a4a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29911: Standardize delete_cached_value API on model Fields

2018-11-01 Thread Django
#29911: Standardize delete_cached_value API on model Fields
-+-
 Reporter:  Taylor Hakes |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  2.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 Could you detail a bit more about what your use case looks like? It's not
 clear to me what changes in Django are needed to solve it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.62faccecc658b9f6c459abc14a5a5b48%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29912: Make CharField/TextField remove newlines from input (was: newlines in input type="text" fields)

2018-11-01 Thread Django
#29912: Make CharField/TextField remove newlines from input
-+-
 Reporter:  kukosk   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Forms|  Version:  2.1
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 I don't think there would be consensus for Django to modify input like
 that -- see ticket:6362#comment:43, for example. Remember that input might
 come from APIs as well. You could write to the DevelopersMailingList if
 you want to get other opinions.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.efc45b97d46d53cd99e95e2a26cd5b13%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29800: Django hangs when Content-Length has incorrect value

2018-11-01 Thread Django
#29800: Django hangs when Content-Length has incorrect value
+
 Reporter:  Alexander Charykov  |Owner:  (none)
 Type:  Bug |   Status:  new
Component:  HTTP handling   |  Version:  2.1
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by Zach Garwood):

 Replying to [comment:7 Patrik Sletmo]:

 > 2. Document the issue so that users are aware of its existence, and
 refer to the use of a reverse proxy. My suggestion is that it could be
 added here somehow https://docs.djangoproject.com/en/2.1/topics/security
 /#additional-security-topics.

 I think this is the best course of action.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.3250cdfc8eafede1b0322b336b86d9a5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #29912: newlines in input type="text" fields

2018-11-01 Thread Django
#29912: newlines in input type="text" fields
+
   Reporter:  kukosk|  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Forms |Version:  2.1
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 It seems to me Django should automatically remove newlines from input
 type="text" fields. Browsers seem to prevent users from entering newlines
 in those types of fields, but that's not something we should rely on, and
 the behaviour should be consistent between Django and web browsers. It
 seems to me it applies to almost all django.forms.widgets.Input widgets.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.2a537a1fa8675de691846f271144619a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #25251: Inconsistent availability of data migrations in TransactionTestCase when using --keepdb

2018-11-01 Thread Django
#25251: Inconsistent availability of data migrations in TransactionTestCase when
using --keepdb
-+-
 Reporter:  David Szotten|Owner:  Romain
 |  Garrigues
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.d9be1046122202c623485141992b7b0d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29911: Standardize delete_cached_value API on model Fields (was: Standardize `delete_cached_value API` on model Fields)

2018-11-01 Thread Django
#29911: Standardize delete_cached_value API on model Fields
-+-
 Reporter:  Taylor Hakes |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  2.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.f1e301467c1bcf5d3a90b23c3de9b7dd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29911: Standardize `delete_cached_value API` on model Fields (was: Standardize delete_cached_value API on model Fields)

2018-11-01 Thread Django
#29911: Standardize `delete_cached_value API` on model Fields
-+-
 Reporter:  Taylor Hakes |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  2.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Taylor Hakes:

Old description:

> I created a custom Django model field that is expensive to calculate and
> I store a cached value on the model. I am not able to clear the cache
> when some uses the refresh_from_db() method though, since there is no
> standard API to hook into it. It appears that there is a custom behavior
> for ForeignKey that calls the delete_cached_value function, if it detects
> it's a ForeignKey
>
> https://github.com/django/django/blob/master/django/db/models/base.py#L569
>
> It would be great to allow any custom Field to implement
> `delete_cached_value` and have it called inside refresh_from_db. What are
> your thoughts? I would be happy to submit a PR if this seems reasonable

New description:

 I created a custom Django model field that is expensive to calculate and I
 store a cached value on the model. I am not able to clear the cache when
 some uses the `refresh_from_db()` method though, since there is no
 standard API to hook into it. It appears that there is a custom behavior
 for `ForeignKey` that calls the `delete_cached_value` function, if it
 detects it's a `ForeignKey`

 https://github.com/django/django/blob/master/django/db/models/base.py#L569

 It would be great to allow any custom Field to implement
 `delete_cached_value` and have it called inside `refresh_from_db`. What
 are your thoughts? I would be happy to submit a PR if this seems
 reasonable

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.5467337c2be28daeb1c7d38907917e46%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #29911: Standardize delete_cached_value API on model Fields

2018-11-01 Thread Django
#29911: Standardize delete_cached_value API on model Fields
-+-
   Reporter:  Taylor |  Owner:  nobody
  Hakes  |
   Type:  New| Status:  new
  feature|
  Component:  Database   |Version:  2.1
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 I created a custom Django model field that is expensive to calculate and I
 store a cached value on the model. I am not able to clear the cache when
 some uses the refresh_from_db() method though, since there is no standard
 API to hook into it. It appears that there is a custom behavior for
 ForeignKey that calls the delete_cached_value function, if it detects it's
 a ForeignKey

 https://github.com/django/django/blob/master/django/db/models/base.py#L569

 It would be great to allow any custom Field to implement
 `delete_cached_value` and have it called inside refresh_from_db. What are
 your thoughts? I would be happy to submit a PR if this seems reasonable

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/055.188907ccaa1d5a3bb97d8ca1fc498fe1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27994: Document contrib.staticfiles.storage.ManifestFilesMixin

2018-11-01 Thread Django
#27994: Document contrib.staticfiles.storage.ManifestFilesMixin
-+-
 Reporter:  GabrielDumbrava  |Owner:  Theofanis
 |  Despoudis
 Type:  New feature  |   Status:  closed
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"082833c969e9da875a3edfd582fc2f8137aef52d" 082833c9]:
 {{{
 #!CommitTicketReference repository=""
 revision="082833c969e9da875a3edfd582fc2f8137aef52d"
 [2.1.x] Fixed #27994 -- Documented ManifestFilesMixin.

 Backport of 084536a9bec1237fabd63fe69a6c17806c9cde53 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.fda4518898fe10d5865ef2557e388a6a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27994: Document contrib.staticfiles.storage.ManifestFilesMixin

2018-11-01 Thread Django
#27994: Document contrib.staticfiles.storage.ManifestFilesMixin
-+-
 Reporter:  GabrielDumbrava  |Owner:  Theofanis
 |  Despoudis
 Type:  New feature  |   Status:  closed
Component:  Documentation|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"084536a9bec1237fabd63fe69a6c17806c9cde53" 084536a9]:
 {{{
 #!CommitTicketReference repository=""
 revision="084536a9bec1237fabd63fe69a6c17806c9cde53"
 Fixed #27994 -- Documented ManifestFilesMixin.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.d1399181cd94e82b8e5e809b9a4a40f4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29886: PostgreSQL's unaccent lookup doesn't work if standard_conforming_strings is off

2018-11-01 Thread Django
#29886: PostgreSQL's unaccent lookup doesn't work if 
standard_conforming_strings is
off
-+-
 Reporter:  Tom McClure  |Owner:  Jayantha
 |  Gumballi
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"dfcdc8992f8bbbf072cefa4d325fe5cac5316f3d" dfcdc899]:
 {{{
 #!CommitTicketReference repository=""
 revision="dfcdc8992f8bbbf072cefa4d325fe5cac5316f3d"
 Fixed #29886 -- Fixed unaccent lookup when PostgreSQL's
 standard_conforming_strings option is off.

 Thanks Tom McClure for the patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.22bf0b78ca5ea760b1a3c61f657ad899%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29886: PostgreSQL's unaccent lookup doesn't work if standard_conforming_strings is off (was: postgres expression comparisons not using proper escaping)

2018-11-01 Thread Django
#29886: PostgreSQL's unaccent lookup doesn't work if 
standard_conforming_strings is
off
-+-
 Reporter:  Tom McClure  |Owner:  Jayantha
 |  Gumballi
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  2.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Ready for checkin
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a574db8469d29c5a4703ef71e15071b1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29884: QuerySet.filter() with TruncBase functions not working as expected when USE_TZ= True (was: Queryset.filter with TruncBase functions not working as expected when USE_TZ= True)

2018-11-01 Thread Django
#29884: QuerySet.filter() with TruncBase functions not working as expected when
USE_TZ= True
-+-
 Reporter:  slide33  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * type:  Uncategorized => Bug


Comment:

 Can you provide tests for
 `tests/db_functions/datetime/test_extract_trunc.py`? It would be easier to
 evaluate the ticket with a patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.ad073e0774449400630939be051c57bd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29908: Foreign key isn't set on object after related set access if ForeignKey uses to_field

2018-11-01 Thread Django
#29908: Foreign key isn't set on object after related set access if ForeignKey 
uses
to_field
-+-
 Reporter:  Carsten Fuchs|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/10595

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.30ca0bdd4f24ddf03cdf3bec439ba32c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.