date:20190318

Re: [Django] #30158: Subquery expressions unnecessarily added to group by

2019-03-18 Thread Django

* needs_tests: 1 => 0

Comment:

Finally came up with an elegant solution. By changing
`Expression.get_group_by_cols`'s signature to accept an optional `alias`
parameter that is only provided when the annotated expression is being
explicitly grouped against. That allows `Subquery.get_group_by_cols` to
either return a reference to it's selected alias when grouped against or
no columns at all when it's not the case which is what this ticket is
tracking.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/070.7007e8e0d0bdbb03330c678d52fb72a6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30259: admin_order_field not working with properties

2019-03-18 Thread Django

#30259: admin_order_field not working with properties
---+
 Reporter:  Tobias Wiese   |Owner:  Jani Tiainen
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  2.1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by Jani Tiainen):

 * status:  new => assigned
 * owner:  nobody => Jani Tiainen
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.041e3879d368ab0c46f011b6309ffcc7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30209: Union with group by don't generate correct Subquery

2019-03-18 Thread Django

Comment (by Simon Charette):

> I'm not sure what exception class should be used here. TypeError?
Thoughts?

Good question. I know that
[https://docs.djangoproject.com/en/2.1/ref/models/querysets/#union we're
currently preventing some operations on combined querysets] so I'd try to
see what type of exception we're currently raising and stick to it to be
coherent. I think `.filter()` is disallowed for example. It's possible
that we simply crash though.

I think the best place to add this check would be in
`query.Queryset.annotate` just before `set_group_by`

[https://github.com/django/django/blob/418263c457636d3301f2068c47f09a0f42e15c52/django/db/models/query.py#L1052
is called] if an annotation contains aggregates.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/069.a15c14228d4ada6ed604db5050c929a7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30209: Union with group by don't generate correct Subquery

2019-03-18 Thread Django

Comment (by TKdka):

Replying to [comment:5 Simon Charette]:
> > I'm planning to make this a sub query pushdown as suggested. FYI, this
is my first contribution to the code base, so suggestions and feedback
would be most appreciated.
>
> TKdka, not to discourage you but this is certainly going to be a hard
first contribution as the ORM doesn't have any formalized API to perform
such pushdown yet. If that can provide you any guidance the most similar
code I can think of is in `django.db.models.sql.Query.get_aggregation`.

After looking into this, you are completely right that it's a big
endeavor. The difficult part is that the query needs to be manipulated
even after the annotate call, which is significantly different from the
aggregate example.

Therefore, I'll submit a small patch that raises an exception when this is
attempted.

I'm not sure what exception class should be used here. TypeError?
Thoughts?

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/069.864562f0230eea168053ec554d01db38%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30266: Migrating a model's default primary key to a BigAutoField causes Postgres sequence to lose owner

2019-03-18 Thread Django

#30266: Migrating a model's default primary key to a BigAutoField causes 
Postgres
sequence to lose owner
-+-
   Reporter:  Dolan  |  Owner:  nobody
  Antenucci  |
   Type:  Bug| Status:  new
  Component:  Database   |Version:  1.11
  layer (models, ORM)|
   Severity:  Normal |   Keywords:  postgres migration
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+-
 Note: I'm marking this as easy pickings, but feel free to change.

 == Summary of Issue ==
 Start with the following models (below assumes application name is
 "sandbox"):

 {{{#!python
 class Test1(models.Model):
 id = models.BigAutoField(primary_key=True)
 name = models.CharField(max_length=100)

 class Test2(models.Model):
 name = models.CharField(max_length=100)
 }}}

 After migrating, go the the `dbshell` and run `\d sandbox_test1_id_seq`
 and `\d sandbox_test2_id_seq`.  The results will include "Owned by:
 public.sandbox_test1.id" and "Owned by: public.sandbox_test2.id"
 respectively.

 Next, change Test2 to a `BigIntField`:

 {{{#!python
 class Test2(models.Model):
 id = models.BigAutoField(primary_key=True)
 name = models.CharField(max_length=100)
 }}}

 Make a new migration, migrate, and then go back to `dbshell` and run `\d
 sandbox_test2_id_seq`.  There will no longer be an owner listed for this
 sequence.

 == Result of this issue ==
 When using `loaddata` with fixtures on the `Test2` model, the sequence
 will not be incremented because the command Django uses to reset the
 sequence for the primary key fails.  Specifically, in the
 
[https://github.com/django/django/blob/master/django/db/backends/postgresql/operations.py#L157
 postgres backend], Django calls the postgres function
 `pg_get_serial_sequence(, )`, which returns nothing when
 the sequence is missing an owner.

 This can be verified in postgres shell via `select
 pg_get_serial_sequence('sandbox_test1', 'id');` and `select
 pg_get_serial_sequence('sandbox_test2', 'id');`

 The result is that after the fixture is loaded, any other inserts will
 fail because their primary keys will conflict with those in the fixture.

 == Potential fixes ==
 1. It seems like `makemigrations` should be setting the sequence owner, or
 using a different command to migrate so that the sequence owner
 information is not lost.  For example, the
 [https://www.postgresql.org/docs/10/datatype-numeric.html#DATATYPE-SERIAL
 postgres docs on serial columns] show that this can be done with `ALTER
 SEQUENCE tablename_colname_seq OWNED BY tablename.colname;`
 2. For tables already migrated and missing the owner information, perhaps
 the `makemigrations` command needs to confirm that the owner information
 is set correctly.
 3. Not a fan of this solution myself, but one could also change the
 sequence is reset the
 
[https://github.com/django/django/blob/master/django/db/backends/postgresql/operations.py#L157
 postgres backend] (i.e., not use `pg_get_serial_sequence`)

 Long-term, maybe `makemigrations` should be using postgres's SERIAL and
 BIGSERIAL field types, which automatically create the sequence and set the
 sequence owner.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.9357bc769183848130aa322c77ea1981%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29471: Set-Cookie response is cached for deleting invalid session cookies

2019-03-18 Thread Django

#29471: Set-Cookie response is cached for deleting invalid session cookies
-+-
 Reporter:  Duane Hutchins   |Owner:
 |  birthdaysgift
 Type:  Bug  |   Status:  assigned
Component:  contrib.sessions |  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  empty session cache  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.49e32c32c7a8821481fe4dec6c21a2b4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29471: Set-Cookie response is cached for deleting invalid session cookies

2019-03-18 Thread Django

#29471: Set-Cookie response is cached for deleting invalid session cookies
-+-
 Reporter:  Duane Hutchins   |Owner:
 |  birthdaysgift
 Type:  Bug  |   Status:  assigned
Component:  contrib.sessions |  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  empty session cache  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by birthdaysgift):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.70a8662e2d8950fb7238ffadb5aa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30265: Django Documentation - Advanced tutorial: How to write reusable app

2019-03-18 Thread Django

#30265: Django Documentation - Advanced tutorial: How to write reusable app
-+
   Reporter:  Abhishek Bera  |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Documentation  |Version:  2.1
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+
 In the [https://docs.djangoproject.com/en/2.1/intro/reusable-apps/]
 In the **Reusability Matters** section in the 3rd paragraph, it says, "In
 Tutorial 3, we saw how we could decouple polls from the project-level
 URLconf using an include."
 However, the only place where include is used is in Tutorial 1.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/054.ba04af80a12a38e034bfcfa6b4667f49%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

2019-03-18 Thread Django

#29379: Add autocomplete attribute to contrib.auth fields
--+--
 Reporter:  CHI Cheng |Owner:  Hasan Ramezani
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Hasan Ramezani):

 * needs_tests:  1 => 0


Comment:

 Tests added to PR!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.cc7b305271fa66edc5cac0488a038d72%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30249: Deprecate re-raising view exceptions from test client in tests

2019-03-18 Thread Django

#30249: Deprecate re-raising view exceptions from test client in tests
-+-
 Reporter:  Jon Dufresne |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * status:  new => closed
 * needs_better_patch:  0 => 1
 * resolution:   => needsinfo


Comment:

 Hey Jon.

 Looking at the PR, I don't think we **can** re-purpose
 `DEBUG_PROPAGATE_EXCEPTIONS` as per your suggestion, since it plays that
 "your web server (instead of Django) to generate “Internal Server Error”
 responses" role. (That's independent of also thinking that a flag on the
 client is the right place to have that switch.)

 The new `raise_request_exception` is targeting 3.0, so there's still time
 to make adjustments.

 Initial thought was something like...


 {{{
 from django import test


 class Client(test.Client):
 """Client subclass defaulting to raise_request_exception=False"""
 def __init__(self, enforce_csrf_checks=False,
 raise_request_exception=False, **defaults):
 super().__init__(enforce_csrf_checks, raise_request_exception,
 **defaults)


 class ClientMixin:
 client_class = Client
 }}}

 Where you just mixin using a appropriate client subclass. Maybe we could
 do something better making `client` a property or such? (Or similar...) —
 Really happy to think about suggestions here!

 **Maybe** we should take this opportunity to also switch the default
 behaviour from "yes, raise" to "no, don't", but personally I'd leave it
 how it is.

 I'm really happy if you want to take this to the mailing list to discuss.
 In the meantime I'm going as `needsinfo`, either on suggestions for
 improving the API, or whether we should change the default, or, indeed,
 whether we can/should/want to use the setting as you suggested.

 Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.05574d7a262654a25d0519ccff9ad179%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30179: Merging 3 or more media objects can throw unnecessary MediaOrderConflictWarnings

2019-03-18 Thread Django

#30179: Merging 3 or more media objects can throw unnecessary
MediaOrderConflictWarnings
---+
 Reporter:  Matt Westcott  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Carlton Gibson ):

 In [changeset:"19ab698937af39553ab63b102c50bafbe8f6edc5" 19ab6989]:
 {{{
 #!CommitTicketReference repository=""
 revision="19ab698937af39553ab63b102c50bafbe8f6edc5"
 [2.2.x] Fixed #30263 -- Doc'd changes to form Media sorting (refs #30179).

 Thanks to Tim Graham for review.
 Backport of 418263c457636d3301f2068c47f09a0f42e15c52 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ed811316b75794ad1722eaf4f9bece52%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30263: Mention the Media.merge change in the release notes

2019-03-18 Thread Django

#30263: Mention the Media.merge change in the release notes
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Carlton
 Type:   |  Gibson
  Cleanup/optimization   |   Status:  closed
Component:  Forms|  Version:  2.2
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson ):

 In [changeset:"19ab698937af39553ab63b102c50bafbe8f6edc5" 19ab6989]:
 {{{
 #!CommitTicketReference repository=""
 revision="19ab698937af39553ab63b102c50bafbe8f6edc5"
 [2.2.x] Fixed #30263 -- Doc'd changes to form Media sorting (refs #30179).

 Thanks to Tim Graham for review.
 Backport of 418263c457636d3301f2068c47f09a0f42e15c52 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.889db182540558932e2985b6a68de8cf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30179: Merging 3 or more media objects can throw unnecessary MediaOrderConflictWarnings

2019-03-18 Thread Django

#30179: Merging 3 or more media objects can throw unnecessary
MediaOrderConflictWarnings
---+
 Reporter:  Matt Westcott  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by GitHub ):

 In [changeset:"418263c457636d3301f2068c47f09a0f42e15c52" 418263c4]:
 {{{
 #!CommitTicketReference repository=""
 revision="418263c457636d3301f2068c47f09a0f42e15c52"
 Fixed #30263 -- Doc'd changes to form Media sorting (refs #30179).

 Thanks to Tim Graham for review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.fc92b3c5e18584710382b154362e8a88%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30263: Mention the Media.merge change in the release notes

2019-03-18 Thread Django

#30263: Mention the Media.merge change in the release notes
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Carlton
 Type:   |  Gibson
  Cleanup/optimization   |   Status:  closed
Component:  Forms|  Version:  2.2
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"418263c457636d3301f2068c47f09a0f42e15c52" 418263c4]:
 {{{
 #!CommitTicketReference repository=""
 revision="418263c457636d3301f2068c47f09a0f42e15c52"
 Fixed #30263 -- Doc'd changes to form Media sorting (refs #30179).

 Thanks to Tim Graham for review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d80cb4b24f0a7710de0e36e2868c9f06%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28431: default='' (non-bytestring) on BinaryField crashes some migration operations

2019-03-18 Thread Django

#28431: default='' (non-bytestring) on BinaryField crashes some migration
operations
+--
 Reporter:  James   |Owner:  Hasan Ramezani
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  1.10
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Hasan Ramezani):

 * owner:  Windson yang => Hasan Ramezani
 * has_patch:  0 => 1


Comment:

 System check for preventing default string value for BinaryField added
 based on @Claude Paroz suggestion

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.d765234afe4027537d76c8ba325018ab%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30253: Document how to order nulls in QuerySet.order_by()

2019-03-18 Thread Django

#30253: Document how to order nulls in QuerySet.order_by()
-+-
 Reporter:  Paul Wayper  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  2.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  documentation| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"1025e764291167f2f34a4d55bd3d043836e74250" 1025e764]:
 {{{
 #!CommitTicketReference repository=""
 revision="1025e764291167f2f34a4d55bd3d043836e74250"
 Fixed #30253 -- Doc'd how to order nulls in QuerySet.order_by().
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.2a896d1d6977584e5a8f19dae873e0ea%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30253: Document how to order nulls in QuerySet.order_by()

2019-03-18 Thread Django

#30253: Document how to order nulls in QuerySet.order_by()
-+-
 Reporter:  Paul Wayper  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  2.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  documentation| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"a48c0180f56316b0e32bf2f4a858d1e097eb1863" a48c018]:
 {{{
 #!CommitTicketReference repository=""
 revision="a48c0180f56316b0e32bf2f4a858d1e097eb1863"
 [2.2.x] Fixed #30253 -- Doc'd how to order nulls in QuerySet.order_by().

 Backport of 1025e764291167f2f34a4d55bd3d043836e74250 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e97098b02131578149879995b36fa2ca%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30263: Mention the Media.merge change in the release notes

2019-03-18 Thread Django

#30263: Mention the Media.merge change in the release notes
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Carlton
 Type:   |  Gibson
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  2.2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0ba71df858f90e4d3fb06a13d66e5821%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30263: Mention the Media.merge change in the release notes

2019-03-18 Thread Django

#30263: Mention the Media.merge change in the release notes
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Carlton
 Type:   |  Gibson
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  2.2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * needs_better_patch:  1 => 0
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.317306240f3b35aa79260d9e86e40c3f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30263: Mention the Media.merge change in the release notes

2019-03-18 Thread Django

#30263: Mention the Media.merge change in the release notes
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Carlton
 Type:   |  Gibson
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  2.2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8073c61f5c98890a5e65ae3e7f940919%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30263: Mention the Media.merge change in the release notes

2019-03-18 Thread Django

#30263: Mention the Media.merge change in the release notes
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Carlton
 Type:   |  Gibson
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  2.2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 [https://github.com/django/django/pull/11093 PR] with ≈suggestion from
 Matthias.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.801d3b96c76f3c1622ff9f8b12ce9f3c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

2019-03-18 Thread Django

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
--+
 Reporter:  Sanyam Khurana|Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Internationalization  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Carlton Gibson):

 * owner:  Mark Dawson => (none)
 * status:  assigned => new


Comment:

 I'm going to de-assign this because there's been progress, so that someone
 looking can pick it up.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.f42f2d80ecf55aa520c48556d28c40a4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30253: Document how to order nulls in QuerySet.order_by() (was: Add a note that `nulls_first` or `nulls_last` can be set in `order_by` using an F expression.)

2019-03-18 Thread Django

#30253: Document how to order nulls in QuerySet.order_by()
-+-
 Reporter:  Paul Wayper  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:  documentation| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * has_patch:  0 => 1
 * type:  New feature => Cleanup/optimization
 * stage:  Unreviewed => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.56169a3a9ba3e880fc77e70b287f2b13%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30264: "OverflowError: timestamp out of range for platform time_t" test failure on 32-bit platforms

2019-03-18 Thread Django

#30264: "OverflowError: timestamp out of range for platform time_t" test 
failure on
32-bit platforms
-+
 Reporter:  Chris Lamb   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Other) |  Version:  2.2
 Severity:  Release blocker  |   Resolution:
 Keywords:  overflow | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Tim Graham):

 * version:  master => 2.2
 * component:  Testing framework => Core (Other)
 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 We should either skip the test on 32-bit or pick a smaller value.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.cced91fcfb367990aa99d097a501954a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30264: "OverflowError: timestamp out of range for platform time_t" test failure on 32-bit platforms

2019-03-18 Thread Django

#30264: "OverflowError: timestamp out of range for platform time_t" test 
failure on
32-bit platforms
-+--
   Reporter:  Chris Lamb |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Testing framework  |Version:  master
   Severity:  Normal |   Keywords:  overflow
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+--
 In Debian we are seeing the following test failure on 32-bit platforms
 (not on 64-bit):

 {{{
 ==
 ERROR: test_parsing_year_less_than_70
 (utils_tests.test_http.HttpDateProcessingTests)
 --
 Traceback (most recent call last):
   File "/usr/lib/python3.7/unittest/case.py", line 59, in testPartExecutor
 yield
   File "/usr/lib/python3.7/unittest/case.py", line 615, in run
 testMethod()
   File "/build/python-django-2.2~beta1/tests/utils_tests/test_http.py",
 line 301, in test_parsing_year_less_than_70
 self.assertEqual(datetime.utcfromtimestamp(parsed), datetime(2050, 11,
 6, 8, 49, 37))
 OverflowError: timestamp out of range for platform time_t
 }}}

 This affects (at least) 2.2 beta 1 and was added in
 
https://github.com/django/django/commit/6b7f1c2530784ed6c6c1826688faaa08e3f786d9.

 Original filed by Andreas Beckmann at https://bugs.debian.org/924784

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.a24a795fbbbeecd51fbb4c245b3deae9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30263: Mention the Media.merge change in the release notes

2019-03-18 Thread Django

#30263: Mention the Media.merge change in the release notes
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Carlton
 Type:   |  Gibson
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  2.2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * owner:  nobody => Carlton Gibson
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9efa395c0f1a98e6a79b34e0e05da735%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30263: Mention the Media.merge change in the release notes

2019-03-18 Thread Django

Comment (by Matthias Kestenholz):

Thanks, both of you.

I'd add the sentence in the ticket description under the "forms" heading
and also mention the change under the "admin" heading, coupled with the
recommendation of adding `jquery.init.js` to the `js` list.

(It didn't confuse me this time since I authored the last change to
`Media.merge`. A hint with what-to-do / upgrading instructions would be
very helpful though. Upgrading instructions for breaking changes is a
thing I missed in the past, e.g. when `get_query_set` was changed to
`get_queryset` etc.)

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.06933df3026ff96d6370d9711d9f6184%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30263: Mention the Media.merge change in the release notes

2019-03-18 Thread Django

#30263: Mention the Media.merge change in the release notes
--+
 Reporter:  Matthias Kestenholz   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  2.2
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Carlton Gibson):

 Sorry. I misread the UI. I'll make a PR this PM. Thanks both.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f0fcf8b30589986feeda6c5902c04424%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30263: Mention the Media.merge change in the release notes

2019-03-18 Thread Django

#30263: Mention the Media.merge change in the release notes
--+
 Reporter:  Matthias Kestenholz   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  2.2
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Johannes Hoppe):

 Hi @Matthias,

 thanks for letting us know about this. I believe it's a good idea to add
 some documentation here. Since other might rely on implicit dependencies
 especially with the old merging warning.

 Since you encountered the issue, what would you suggest as documentation.
 What would have helped or pointed you into the right direction?

 Best,
 Joe

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.278f32de6a0c73271a212ae0fcfd321c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30263: Mention the Media.merge change in the release notes

2019-03-18 Thread Django

#30263: Mention the Media.merge change in the release notes
--+
 Reporter:  Matthias Kestenholz   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  2.2
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Matthias Kestenholz):

 Hey, that was me :)

 I'd appreciate it if you did the PR. I just thought I'd cc Johannes
 because of his involvement.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1c20bb2b5f58c351ae780e4ee2c4ad2a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30263: Mention the Media.merge change in the release notes

2019-03-18 Thread Django

#30263: Mention the Media.merge change in the release notes
--+
 Reporter:  Matthias Kestenholz   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  2.2
 Severity:  Release blocker   |   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Carlton Gibson):

 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 Hey Joe. Yep, fine. Do you want to make that PR? (I can do it quickly if
 you say no.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e32509ca4e392229707d32e6ed08b44b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28667: Documentation for extending UserCreationForm doesn't work with UserAdmin

2019-03-18 Thread Django

#28667: Documentation for extending UserCreationForm doesn't work with UserAdmin
-+-
 Reporter:  Nathanael Gordon |Owner:  (none)
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.auth |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:  add_fieldsets| Triage Stage:  Accepted
  UserAdmin UserCreationForm Custom  |
  Auth User Model|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * owner:  eadhina => (none)
 * status:  assigned => new


Comment:

 Given the lack of updates I'm going to de-assign this issue so someone
 else looking can pick it up.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.db5a4a7dc842fb10ce190ff702add5f7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30263: Mention the Media.merge change in the release notes

2019-03-18 Thread Django

#30263: Mention the Media.merge change in the release notes
+
Reporter: Matthias Kestenholz | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Forms |Version: 2.2
Severity: Normal| Keywords:
Triage Stage: Unreviewed| Has patch: 0
Needs documentation: 0 |Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
+
The Media merge change (#30179, #30153) has some potential of breaking
libraries which worked before. It would be nice to give a heads-up to
developers that they have to check their `Media` definitions.

The necessary change to django-content-editor was really small:
https://github.com/matthiask/django-content-
editor/commit/ed662db302fd74033ce62031bb11b6f8beddf249

Here's a draft for the release notes (I hope it helps -- I'm finding it
hard to keep it short while still providing an useful example)

Merging of media classes

The `Media` class merging algorithm has been changed to produce sensible
results when pairwise merging is insufficient. However, CSS and JavaScript
files which do not properly declare their dependencies may now be
reordered **before** their dependencies. This only ever worked by
accident.

The recommendation is to check all `Media` declarations for dependencies
and make those explicit. Just as an example, widgets depending on
`django.jQuery` should specify `js=["admin/js/jquery.init.js", ...]`

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/052.9568f1e8056326f8dd4cdc0e309eab77%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30231: Field's verbose_name is ignored in FilteredSelectMultiple widget for inlines created with "Add another" button

2019-03-18 Thread Django

#30231: Field's verbose_name is ignored in FilteredSelectMultiple widget for
inlines created with "Add another" button
-+
 Reporter:  Florian Schuler  |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+

Comment (by Florian Schuler):

 Replying to [comment:14 Tim Graham]:
 > Okay, I'll deassign the ticket then. Even trivial bug fixes require
 tests to prevent regressions.

 Hey Tim, Okay!
 Just noticed that the owner field of this ticket is now empty. Shouldn't
 it be "nobody" like the other new tickets so that other users can query
 for unassigned tickets by searching for owner "nobody"?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.ffc8a1d23725f6acc73991d70c8e322e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29697: Complex query crashes with "missing FROM-clause entry for table"

2019-03-18 Thread Django

#29697: Complex query crashes with "missing FROM-clause entry for table"
-+-
 Reporter:  Dmitry   |Owner:  Can
 |  Sarıgöl
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  2.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Can Sarıgöl):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.cd2261cbd2948ff8e39e22faabcd908e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30258: Failed to add CheckConstraint on IntegerRangeField

2019-03-18 Thread Django

#30258: Failed to add CheckConstraint on IntegerRangeField
-+-
 Reporter:  Tilman Koschnick |Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"883d87074dd916224e2436ecc3dad8dd80e87c16" 883d870]:
 {{{
 #!CommitTicketReference repository=""
 revision="883d87074dd916224e2436ecc3dad8dd80e87c16"
 [2.2.x] Fixed #30258 -- Adjusted postgres schema value quoting of ranges.

 Thanks Tilman Koschnick for the report and patch.

 Backport of 386d89ab55e620440d30590a8a104fe6d5eef830 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.2b53f9a364c95afe280cde184f082616%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30258: Failed to add CheckConstraint on IntegerRangeField

2019-03-18 Thread Django

#30258: Failed to add CheckConstraint on IntegerRangeField
-+-
 Reporter:  Tilman Koschnick |Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"386d89ab55e620440d30590a8a104fe6d5eef830" 386d89a]:
 {{{
 #!CommitTicketReference repository=""
 revision="386d89ab55e620440d30590a8a104fe6d5eef830"
 Fixed #30258 -- Adjusted postgres schema value quoting of ranges.

 Thanks Tilman Koschnick for the report and patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.9c96161a2e01a37602064c82c5b0df14%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30258: Failed to add CheckConstraint on IntegerRangeField

2019-03-18 Thread Django

#30258: Failed to add CheckConstraint on IntegerRangeField
-+-
 Reporter:  Tilman Koschnick |Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 Hey Simon, thanks for pulling this into the PR!

 > I still think it would be worthy to make ...

 Fancy creating a separate ticket (at your leisure)? 👍

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.2822d4e47dc74c819b06fe13466ecc9e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

38 matches

Mail list logo