Re: [Django] #20122: Pluralize filter sometimes returns singular form instead of an empty string for invalid inputs

[Django]

#20122: Pluralize filter sometimes returns singular form instead of an empty 
string
for invalid inputs
-+-
 Reporter:  Aymeric Augustin |Owner:  Tobias
 Type:   |  Kunze
  Cleanup/optimization   |   Status:  assigned
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tobias Kunze):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.762d27463712ee3834f57c9b8ae7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11929: manage.py dumpdata outputs YAML in unhelpful order

[Django]

#11929: manage.py dumpdata outputs YAML in unhelpful order
-+-
 Reporter:  sampablokuper|Owner:  Tobias
 Type:   |  Kunze
  Cleanup/optimization   |   Status:  closed
Component:  Core |  Version:  master
  (Serialization)|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Fixed in 5bc3123479bd97dc9d8a36fa9a3421a71063d1da.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.37aa1ec29017dfcadbcdceb4ab9c5167%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11929: manage.py dumpdata outputs YAML in unhelpful order

[Django]

#11929: manage.py dumpdata outputs YAML in unhelpful order
-+-
 Reporter:  sampablokuper|Owner:  Tobias
 Type:   |  Kunze
  Cleanup/optimization   |   Status:  closed
Component:  Core |  Version:  master
  (Serialization)|
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"a9b8898242cf2579ca5727ecab516ab761bce488" a9b88982]:
 {{{
 #!CommitTicketReference repository=""
 revision="a9b8898242cf2579ca5727ecab516ab761bce488"
 Refs #11929 -- Fixed ordering of test YAML dumps.

 Thanks Nick Pope for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.14ee7afdcd8bc4f574c0e59d3830a808%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20122: Pluralize filter sometimes returns singular form instead of an empty string for invalid inputs

[Django]

#20122: Pluralize filter sometimes returns singular form instead of an empty 
string
for invalid inputs
-+-
 Reporter:  Aymeric Augustin |Owner:  Tobias
 Type:   |  Kunze
  Cleanup/optimization   |   Status:  assigned
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"e3968df527c4d378677f4784fb1bc0c86950fcf8" e3968df5]:
 {{{
 #!CommitTicketReference repository=""
 revision="e3968df527c4d378677f4784fb1bc0c86950fcf8"
 Refs #20122 -- Corrected documentation of pluralize template filter.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.af2c09a67ff47f913ddf7c32291c9bee%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20122: Pluralize filter sometimes returns singular form instead of an empty string for invalid inputs

[Django]

#20122: Pluralize filter sometimes returns singular form instead of an empty 
string
for invalid inputs
-+-
 Reporter:  Aymeric Augustin |Owner:  Tobias
 Type:   |  Kunze
  Cleanup/optimization   |   Status:  closed
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e68361364906170db936d917ab5dd07262f537b6" e6836136]:
 {{{
 #!CommitTicketReference repository=""
 revision="e68361364906170db936d917ab5dd07262f537b6"
 Fixed #20122 -- Made pluralize template filter return '' on invalid input.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c357f22c4910a620a2ab8f70d4b54a07%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20122: Pluralize filter sometimes returns singular form instead of an empty string for invalid inputs

[Django]

#20122: Pluralize filter sometimes returns singular form instead of an empty 
string
for invalid inputs
-+-
 Reporter:  Aymeric Augustin |Owner:  Tobias
 Type:   |  Kunze
  Cleanup/optimization   |   Status:  closed
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"bf9e0e342da3ed2f74ee0ec34e75bdcbedde40a9" bf9e0e34]:
 {{{
 #!CommitTicketReference repository=""
 revision="bf9e0e342da3ed2f74ee0ec34e75bdcbedde40a9"
 [2.2.x] Refs #20122 -- Corrected documentation of pluralize template
 filter.

 Backport of e3968df527c4d378677f4784fb1bc0c86950fcf8 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5b42839c5d183c67539a33cf0513453e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30398: Check database connection's health before its reused

[Django]

#30398: Check database connection's health before its reused
-+-
 Reporter:  Przemysław Suliga|Owner:
 |  Przemysław Suliga
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_docs:  0 => 1
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.83225c880af2d3c466854c4cfcded5c8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30398: Check database connection's health before its reused

[Django]

#30398: Check database connection's health before its reused
-+-
 Reporter:  Przemysław Suliga|Owner:
 |  Przemysław Suliga
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ran Benita):

 Taking a risk of detracting the discussion a bit, but given Djagno's async
 future, wouldn't this be the time to revisit the decision to use
 persistent connections over a connection pool? For most async frameworks
 (we use gevent, but will be the same with ASGI), persistent connections
 don't work since async tasks are not reused like threads/processes,
 instead a task is spawned per request.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f43e9173f5dc90aa556834fe0814eaf2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30436: ForeignKey on_delete parameter should be validated

[Django]

#30436: ForeignKey on_delete parameter should be validated
-+
   Reporter:  Rémy Hubscher  |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Uncategorized  |Version:  2.2
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 If you set `on_delete=None` as a ForeignKey field parameter you might get
 the following error:

 {{{
   File "django/contrib/admin/options.py", line 1823, in
 get_deleted_objects
 return get_deleted_objects(objs, request, self.admin_site)
   File "django/contrib/admin/utils.py", line 134, in get_deleted_objects
 collector.collect(objs)
   File "django/contrib/admin/utils.py", line 197, in collect
 return super().collect(objs, source_attr=source_attr, **kwargs)
   File "django/db/models/deletion.py", line 221, in collect
 field.remote_field.on_delete(self, field, sub_objs, self.using)

 TypeError: 'NoneType' object is not callable
 }}}

 I believe that we could validate the on_delete value to prevent such
 behaviour. Or at least tell that None is not a valid on_delete value.

 Refs
 
https://docs.djangoproject.com/fr/2.2/ref/models/fields/#django.db.models.ForeignKey.on_delete

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.36e00cef2a2586884c6aced7b6bf3536%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30437: Why urlpatterns has to be a *Python list*?

[Django]

#30437: Why urlpatterns has to be a *Python list*?
-+
   Reporter:  isidentical|  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Documentation  |Version:  2.2
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 Why urlpatterns has to be a *Python list*? Doesn't all sequences (an
 object that implements collections.abc.Sequence interface) counts for
 that. IMO this description should change at url dispatching page. As a
 real example i'm using collections.UserList based pattern manager for it
 (can be found in [that
 
page](https://github.com/isidentical/Aspava/blob/f7d7953090574e30f45d300ab1d06b46b0e18142/social/urls.py#L5).)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/054.def258a51ddf1dd699c280e943c0596e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30437: Why urlpatterns has to be a *Python list*?

[Django]

#30437: Why urlpatterns has to be a *Python list*?
---+--
 Reporter:  isidentical|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Description changed by isidentical:

Old description:

> Why urlpatterns has to be a *Python list*? Doesn't all sequences (an
> object that implements collections.abc.Sequence interface) counts for
> that. IMO this description should change at url dispatching page. As a
> real example i'm using collections.UserList based pattern manager for it
> (can be found in [that
> page](https://github.com/isidentical/Aspava/blob/f7d7953090574e30f45d300ab1d06b46b0e18142/social/urls.py#L5).)

New description:

 Why urlpatterns has to be a *Python list*? Doesn't all sequences (an
 object that implements collections.abc.Sequence interface) counts for
 that. IMO this description should change at url dispatching page. As a
 real example i'm using collections.UserList based pattern manager for it
 (can be found in
 
[https://github.com/isidentical/Aspava/blob/f7d7953090574e30f45d300ab1d06b46b0e18142/social/urls.py#L5
 here])

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.62cae974abc22ce7c88f9ba8aeb2d166%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #14094: Cannot define CharField with unlimited length

[Django]

#14094: Cannot define CharField with unlimited length
-+-
 Reporter:  Daniel Miller|Owner:  Aron
 |  Podrigal
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Rich Rauenzahn):

 * cc: Rich Rauenzahn (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c82ed5fd558fc1804c9387b6aae0388f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30395: Document ModelForm specifying field class corresponding to model fields with choices.

[Django]

#30395: Document ModelForm specifying field class corresponding to model fields
with choices.
-+-
 Reporter:  Quentin  |Owner:  Tobias
 Type:   |  Kunze
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  ModelForm| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tobias Kunze):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.128c6f80c4a638697da12228b93cfea1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26834: MinValueValidator/MaxValueValidator not forwarded to form field for ModelForm

[Django]

#26834: MinValueValidator/MaxValueValidator not forwarded to form field for
ModelForm
-+-
 Reporter:  Sergei Maertens  |Owner:  Tobias
 |  Kunze
 Type:  Bug  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  MaxValueValidator,   | Triage Stage:  Accepted
  MinValueValidator, ModelForm,  |
  IntegerField   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tobias Kunze):

 * owner:  Sagar Nilesh Shah => Tobias Kunze
 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.07897eb0ce80d9c4aaa3f731ef18c9c3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30438: GeoDjango .SHP file Specifications

[Django]

#30438: GeoDjango .SHP file Specifications
-+-
   Reporter:  ryan-WORK  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  GIS|Version:  2.2
   Severity:  Normal |   Keywords:  Shapefile Geom
   Triage Stage: |  Admin
  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 When using GeoDjango I seem to run into errors with shapefiles other than
 the provided World Map `TM_WORLD_BORDERS-0.3`.

 What are the steps to create a shapefile with the propor fields that are
 needed to get the `geom` working within the admin?  Is there a way to
 document that in the GeoDjango tutorial?

 Currently the shapefiles that I have are not being shown in the Admin of
 GeoDjango after they are uploaded with the `Layer Mapping` examples
 provided by the tutorial.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.ad2ffef40e762a7605e530ea062b97fd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30438: GeoDjango .SHP file Specifications

[Django]

#30438: GeoDjango .SHP file Specifications
-+-
 Reporter:  ryan-WORK|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  2.2
 Severity:  Normal   |   Resolution:
 Keywords:  Shapefile Geom   | Triage Stage:
  Admin  |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by ryan-WORK):

 * Attachment "Screen Shot 2019-05-03 at 11.59.48 AM.png" added.

 Not working

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c78923a3835cfb53149f94f0ecb43952%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30438: GeoDjango .SHP file Specifications

[Django]

#30438: GeoDjango .SHP file Specifications
-+-
 Reporter:  ryan-WORK|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  2.2
 Severity:  Normal   |   Resolution:
 Keywords:  Shapefile Geom   | Triage Stage:
  Admin  |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by ryan-WORK):

 * Attachment "Screen Shot 2019-05-03 at 12.00.45 PM.png" added.

 Working as expected

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bb1fbd3d96853a689b3cfa9d33605ddf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30439: ngettext broken for certain locales due to catalog merging

[Django]

#30439: ngettext broken for certain locales due to catalog merging
+
   Reporter:  Michal Čihař  |  Owner:  nobody
   Type:  Bug   | Status:  new
  Component:  Internationalization  |Version:  2.2
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 When locales have different plural forms, the ngettext can be easily
 broken because it uses plural equation from the first loaded gettext
 catalog for all of them.

 For example in Czech locale, there are different plural equations being
 used even inside Django with either 3 or 4 plural forms. When the one with
 4 forms is loaded first, Django is looking for non existing plural in
 catalogs.

 Reproducer in Django 2.2.1:

 {{{

 >>> from django.utils import translation
 >>> translation.activate('cs')
 >>> translation.ngettext('This password is too short. It must contain at
 least %(min_length)d character.', 'This password is too short. It must
 contain at least %(min_length)d characters.', 1)
 'Heslo je příliš krátké. Musí mít délku aspoň %(min_length)d znak.'
 >>> translation.ngettext('This password is too short. It must contain at
 least %(min_length)d character.', 'This password is too short. It must
 contain at least %(min_length)d characters.', 10)
 'This password is too short. It must contain at least %(min_length)d
 characters.'
 }}}


 The second invocation is trying to find 4th plural in 3 plurals catalog.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.716a8b67511ac2abb3edeaf6b2b2b040%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30436: ForeignKey on_delete parameter should be validated

[Django]

#30436: ForeignKey on_delete parameter should be validated
---+--
 Reporter:  Rémy Hubscher  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by zeynel):

 IMO it would be unnecessary to add an extra check for `None` since it
 covers all options for `on_delete` explicitly in documentation:

   The possible values for on_delete are found in django.db.models:
   ...

 
https://docs.djangoproject.com/en/2.2/ref/models/fields/#django.db.models.ForeignKey.on_delete

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.41fd3713171e26cdda89f728bcc77d5e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30439: ngettext broken for certain locales due to catalog merging

[Django]

#30439: ngettext broken for certain locales due to catalog merging
-+-
 Reporter:  Michal Čihař |Owner:  Claude
 |  Paroz
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  2.2
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * status:  new => assigned
 * owner:  nobody => Claude Paroz
 * stage:  Unreviewed => Accepted


Comment:

 I'm partly responsible of this situation, because I'm not always merging
 translation files when only the plural string changes (essentially to save
 some .mo files which are the main cause of Django repository growing
 size). We are unfortunately completely dependent on Transifex about these
 plural string changes, which are not always desired by translation teams.

 Whatever, we should definitely commit all files with plural string
 changes.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.5a326a115f952eab4f32eb8639a55e1b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30439: ngettext broken for certain locales due to catalog merging

[Django]

#30439: ngettext broken for certain locales due to catalog merging
-+-
 Reporter:  Michal Čihař |Owner:  Claude
 |  Paroz
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  2.2
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz):

 Let's do that soon before the 2.2.2 release, so we can get new
 translations in the same commit.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.e1a55321617001decedcdf5ad556b3ea%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30440: "required" attribute is not removed if the browser doesn't supported ":valid" pseudo-selector in SelectFilter2.js

[Django]

#30440: "required" attribute is not removed if the browser doesn't supported
":valid" pseudo-selector in SelectFilter2.js
-+-
   Reporter:  BenMusch   |  Owner:  nobody
   Type: | Status:  new
  Uncategorized  |
  Component: |Version:  2.2
  contrib.admin  |   Keywords:  admin select
   Severity:  Normal |  selectfilter filteredselectfield
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+-
 The code in question:
 
https://github.com/django/django/blob/stable/2.2.x/django/contrib/admin/static/admin/js/SelectFilter2.js#L175

 If an error is thrown on line 181, the attribute is never removed. This
 leads to incorrect form validation when submitting.

 I believe this would be fixed by moving the
 "field.removeAttr('required');" outside of the try/catch block

 Steps to reproduce:

 1. Use a browser which does not support :valid pseudo-selector (I am using
 Chrome 73 on Mac)

 2. Open a page with the filtered multiple select field

 3. Submit the form without making any changes

 4. The browser will erroneously preform the "Missing required element"
 validation

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.512bd2dc75413de6915999abad20f78e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30439: ngettext broken for certain locales due to catalog merging

[Django]

#30439: ngettext broken for certain locales due to catalog merging
-+-
 Reporter:  Michal Čihař |Owner:  Claude
 |  Paroz
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  2.2
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Michal Čihař):

 The very same situation happens with third party app localization (this is
 where I noticed it first). I think it's not reasonable to expect
 everything will use same plural forms.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.0fade40180ff5093d4a6a7a232a3fff5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29062: "database table locked errors" when using sqlite in-memory database with LiveServerTestCase

[Django]

#29062: "database table locked errors" when using sqlite in-memory database with
LiveServerTestCase
-+-
 Reporter:  Juozas Masiulis  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Testing framework|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  sqlite, testing, | Triage Stage:  Accepted
  databases  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Daniel Hahler):

 Just a drive-by comment since I've seen a similar issue and found this:
 check/ensure that transactions are enabled (i.e. with pytest-django
 `transactional_db` instead of `db` should be used).
 Also check the code around
 
https://github.com/django/django/commit/bece837829eafbc22f2598dadf82c9a8364b085a
 #diff-5d7d8ead1a907fe91ffc121f830f2a49L1287.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.84f3a9b8dc241e46310c1e467233b2be%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30380: Support mysql query objects as strings in addition to bytes, for PyMySQL support.

[Django]

#30380: Support mysql query objects as strings in addition to bytes, for PyMySQL
support.
-+-
 Reporter:  Nathan Klug  |Owner:  felixxm
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by eavictor):

 Should we open another ticket with Django version 2.2.x and reference to
 this ticket number for backport ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.d7d7abc37fa1c92c30065222d52bb8d2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.