Re: [Django] #28520: Add --start-at/after options to runtests.py

[Django]

#28520: Add --start-at/after options to runtests.py
+--
 Reporter:  Marten Kenbeek  |Owner:  Hasan Ramezani
 Type:  New feature |   Status:  assigned
Component:  Core (Other)|  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Hasan Ramezani):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.43162c97a4ef7c832584db76606b6e4f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26431: translate_url() creates an incorrect URL when optional named groups are missing in the URL pattern

[Django]

#26431: translate_url() creates an incorrect URL when optional named groups are
missing in the URL pattern
---+---
 Reporter:  EugeneM|Owner:  Daniel Rios
 Type:  Bug|   Status:  assigned
Component:  Core (URLs)|  Version:  1.9
 Severity:  Normal |   Resolution:
 Keywords:  translate_url  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+---

Comment (by j-bernard):

 This also affects the set_language function.
 When changing language on a page with an URL pattern containing an
 optional group, the empty optional part is set to none and translating the
 page leads to a 404.
 The bug on translation did not exist back in 1.8, not sure when it was
 introduced. I'm on 2.2.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ccefa166f70d7cafa3afc0a2b8dac2bd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30530: url `path` accepts newlines in various places.

[Django]

#30530: url `path` accepts newlines in various places.
--+
   Reporter:  Sjoerd Job Postmus  |  Owner:  nobody
   Type:  Bug | Status:  new
  Component:  Core (URLs) |Version:  master
   Severity:  Normal  |   Keywords:
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+
 Consider the following simplified `urls.py`.

 {{{
 from django.http import HttpResponse
 from django.urls import path


 def path_view(request):
 return HttpResponse('===' + request.path + '===')


 def render_something(request, something):
 return HttpResponse('===' + something + '===')


 urlpatterns = [
 path('hello/', path_view),
 path('foo//bar/', render_something),
 ]
 }}}

 By accessing `http://localhost:8000/hello/%0a`, it's clear that the
 newline is accepted in the URL. This is because the underlying logic uses
 a `$` in the regular expression, instead of `\Z`..

 By accessing `http://localhost:8000/foo/hello%0aworld/bar/`, it's clear
 that the default `str` converter accepts anywhere in the segment. This is
 because it uses a negative match `[^/]+`, which happily accepts a newline
 character (both `%0a` and `%0d`).

 I propose changing the `$` to `\Z`, and the negative match to `[^/\r\n]+`.

 I would also suggest changing the documentation on the `re_path` to
 suggest `\Z` instead of `$`, though that may be more controversial.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.319aeec7234c60f3aed6ed0c88758425%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30529: SQLCompiler.as_sql should return parameters as a list (and not as a tuple)

[Django]

#30529: SQLCompiler.as_sql should return parameters as a list (and not as a 
tuple)
-+-
 Reporter:  Tobias Krönke|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tobias Krönke):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Tuples, it is. https://github.com/django/django/pull/11430

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.a3e6952ab28eaac13471cea2c621e722%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30521: Default error webpages are not correctly-formed html pages.

[Django]

#30521: Default error webpages are not correctly-formed html pages.
-+-
 Reporter:  Ruben Garcia |Owner:  Alexandre
 Type:   |  Varas
  Cleanup/optimization   |   Status:  assigned
Component:  Error reporting  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Alexandre Varas):

 * owner:  (none) => Alexandre Varas
 * status:  new => assigned


Comment:

 I'll start working on this ticket.

 Following @felixxm comment I'll see if a *simple* solution can be applied.

 My opinion is that Django should use the corresponding format or at least
 to be consistent with other responses.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.584e4f6d85bfcd541928a3b278227c74%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30529: SQLCompiler.as_sql should return parameters as a list (and not as a tuple)

[Django]

#30529: SQLCompiler.as_sql should return parameters as a list (and not as a 
tuple)
-+-
   Reporter:  Tobias |  Owner:  nobody
  Krönke |
   Type:  Bug| Status:  new
  Component:  Database   |Version:  2.2
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 As wished by Adam (https://github.com/adamchainz/django-
 mysql/issues/50#issuecomment-496665473) I will give it a try and do a PR
 to turn those tuples into lists. Even the method comments in
 https://github.com/django/django/blob/master/django/db/models/sql/compiler.py
 all state:

 Return the SQL string and **list** of parameters.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/047.76e9e1451a269d2106280bd7045e9a1a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30528: Django Admin adds Javascript in different sequences

[Django]

#30528: Django Admin adds Javascript in different sequences
-+-
   Reporter:  FreakyTea  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component: |Version:  2.1
  contrib.admin  |
   Severity:  Normal |   Keywords:  admin, inline, js
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Hi,

 we're using Django on a large scale intern company project. We found an
 issue with using inlines. On Creation of a new Model the Admin interface
 with inlines works fine (jQuery gets loaded on top of the page, inline.js
 follows way down in the head section).

 But after saving this model and reopening it, the inline.js is loaded
 directly after jQuery and posts following error:


 {{{
 TypeError: undefined is not an object (evaluating '$.fn')
 }}}


 I made a little workaround with my own javascript just calling the
 inline.js if that didn't load. But that can't be the solution.

 Do you know whats the problem or what we could do?

 Regards

 Fabian

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.a621d9cb44e52e21f9be22837ea00d01%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30511: Support Identity columns on PostgreSQL.

[Django]

#30511: Support Identity columns on PostgreSQL.
-+-
 Reporter:  Michael Kany |Owner:  Michael
 |  Kany
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgres generated   | Triage Stage:  Accepted
  identity   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Michael Kany):

 * owner:  nobody => Michael Kany
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.202a25f7ffaf1170229a2f11c7dc224a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30505: Ordering of Field.choices is significant for makemigrations

[Django]

#30505: Ordering of Field.choices is significant for makemigrations
-+-
 Reporter:  Marnanel Thurman |Owner:  Caio
 Type:   |  Ariede
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Caio Ariede):

 * has_patch:  0 => 1


Comment:

 new [https://github.com/django/django/pull/11429 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.cf1f50f96ea3afce5442f7aa95711c0e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30511: Support Identity columns on PostgreSQL.

[Django]

#30511: Support Identity columns on PostgreSQL.
-+-
 Reporter:  Michael Kany |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgres generated   | Triage Stage:  Accepted
  identity   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by felixxm):

 Sure, feel-free.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.18c0b87db6d6c082c30a1b8198a70152%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30511: Support Identity columns on PostgreSQL.

[Django]

#30511: Support Identity columns on PostgreSQL.
-+-
 Reporter:  Michael Kany |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgres generated   | Triage Stage:  Accepted
  identity   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Michael Kany):

 Thank you for accepting this feature.
 Can I now assign the ticket and make a pull request?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.20a3a740cc5a7cd1c007b6a63f93c0bf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28053: Allow fields to specify arbitrary indexes via db_index=Index()

[Django]

#28053: Allow fields to specify arbitrary indexes via db_index=Index()
-+-
 Reporter:  Marc Tamlyn  |Owner:  Can
 |  Sarıgöl
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  indexes migrations   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.680f36de4f10bbe07ac1cb627ab0549e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30520: ModelForm with field without label crashes when used in InlineModelAdmin.

[Django]

#30520: ModelForm with field without label crashes when used in 
InlineModelAdmin.
-+
 Reporter:  George Tantiras  |Owner:  Jones
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by felixxm):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/11427 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ce1e302b914f2b1b26167696cdf6dc7c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30511: Support Identity columns on PostgreSQL. (was: AutoField with postgres10/11 as generated identity.)

[Django]

#30511: Support Identity columns on PostgreSQL.
-+-
 Reporter:  Michael Kany |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgres generated   | Triage Stage:  Accepted
  identity   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * stage:  Unreviewed => Accepted


Comment:

 I tentatively accept this feature. IMO in basic implementation it doesn't
 have much value, but it can be helpful if we support all options:
 - `GENERATED ALWAYS` / `GENERATED BY DEFAULT` , and
 - sequence options `START WITH` and `INCREMENT BY`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.62b9ebc792a6fc655cdc89d2d2461cbd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30505: Ordering of Field.choices is significant for makemigrations

[Django]

#30505: Ordering of Field.choices is significant for makemigrations
-+-
 Reporter:  Marnanel Thurman |Owner:  Caio
 Type:   |  Ariede
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * has_patch:  1 => 0
 * type:  Bug => Cleanup/optimization


Comment:

 This should be clarified in documentation, maybe "{{{A
 :term:`sequence`}}}" instead of "{{{An iterable ...}}}" or a note about
 ordering.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a1bdc7f6d4efcbacbfcfdac405785bef%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30527: Problem with creating migrations for subclassed field changes

[Django]

#30527: Problem with creating migrations for subclassed field changes
-+-
   Reporter:  wfehr  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Core   |Version:  2.2
  (Management commands)  |
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 `makemigrations` gives out 'No changes detected' for changes on a sub-
 subclass of CharField (only tested with this field).

 When creating a field as seen below (DummyCharField), a new migration only
 gets created if `kwargs['max_length'] = 255` is wrapped inside an `if`.

 {{{#!python
 class BaseDummyCharField(models.CharField):
 def __init__(self, *args, **kwargs):
 if 'max_length' not in kwargs:
 kwargs['max_length'] = 64
 super().__init__(*args, **kwargs)


 class DummyCharField(BaseDummyCharField):
 def __init__(self, *args, **kwargs):
 # Without the if 'makemigrations' does not recognize changes.
 # Previous max_length (in initial migration) is 64.
 if 'max_length' not in kwargs:
 kwargs['max_length'] = 255
 super().__init__(*args, **kwargs)


 class DummyModel(models.Model):
 dummy = DummyCharField()
 }}}

 (Also reproducable in version 2.0.6, maybe others as well.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.e5786c1abc661b846057ffa9c2f09e9d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30493: GenericRelation and prefetch_related: wrong caching with cyclic prefetching.

[Django]

#30493: GenericRelation and prefetch_related: wrong caching with cyclic
prefetching.
-+-
 Reporter:  Finn Stutzenstein|Owner:  Can
 |  Sarıgöl
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  GenericRelation  | Triage Stage:  Accepted
  prefetch_related   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.163fae3bdef6d4177a45a259b7a09c3d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28520: Add --start-at/after options to runtests.py

[Django]

#28520: Add --start-at/after options to runtests.py
+--
 Reporter:  Marten Kenbeek  |Owner:  Hasan Ramezani
 Type:  New feature |   Status:  assigned
Component:  Core (Other)|  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+--
Changes (by felixxm):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.241fc1bd433deaf1420986c73fefe5da%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28520: Add --start-at/after options to runtests.py

[Django]

#28520: Add --start-at/after options to runtests.py
+--
 Reporter:  Marten Kenbeek  |Owner:  Hasan Ramezani
 Type:  New feature |   Status:  assigned
Component:  Core (Other)|  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+--
Changes (by felixxm):

 * needs_better_patch:  0 => 1
 * has_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.89be2a7d911f5fe935759b38301ec171%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30523: StatReloader does not update file times if notify_file_changed() is triggered.

[Django]

#30523: StatReloader does not update file times if notify_file_changed() is
triggered.
-+--
 Reporter:  Tom Forbes   |Owner:  Tom Forbes
 Type:  Bug  |   Status:  closed
Component:  Utilities|  Version:  2.2
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by Mariusz Felisiak ):

 In [changeset:"7089502b98f80e8dc1c8f6e85fb0620809aec30e" 7089502b]:
 {{{
 #!CommitTicketReference repository=""
 revision="7089502b98f80e8dc1c8f6e85fb0620809aec30e"
 [2.2.x] Fixed #30523 -- Fixed updating file modification times on seen
 files in auto-reloader when using StatReloader.

 Previously we updated the file mtimes if the file has not been seen
 before - i.e on the first iteration of the loop.

 If the mtime has been changed we triggered the notify_file_changed()
 method which in all cases except the translations will result in the
 process being terminated. To be strictly correct we need to update the
 mtime for either branch of the conditional.

 Regression in 6754bffa2b2df15a741008aa611c1bb0e8dff22b.

 Backport of 480492fe70b0bb7df61c00854dc8535c9d21ba64 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.86b8ca5634806afbddc5848f6b2e7a98%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30523: StatReloader does not update file times if notify_file_changed() is triggered.

[Django]

#30523: StatReloader does not update file times if notify_file_changed() is
triggered.
-+--
 Reporter:  Tom Forbes   |Owner:  Tom Forbes
 Type:  Bug  |   Status:  closed
Component:  Utilities|  Version:  2.2
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"480492fe70b0bb7df61c00854dc8535c9d21ba64" 480492fe]:
 {{{
 #!CommitTicketReference repository=""
 revision="480492fe70b0bb7df61c00854dc8535c9d21ba64"
 Fixed #30523 -- Fixed updating file modification times on seen files in
 auto-reloader when using StatReloader.

 Previously we updated the file mtimes if the file has not been seen
 before - i.e on the first iteration of the loop.

 If the mtime has been changed we triggered the notify_file_changed()
 method which in all cases except the translations will result in the
 process being terminated. To be strictly correct we need to update the
 mtime for either branch of the conditional.

 Regression in 6754bffa2b2df15a741008aa611c1bb0e8dff22b.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.f4b93269d31a0e8381d87dd021bd1355%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30526: migration to UUID id field doesn't properly convert integers (SQLite).

[Django]

#30526: migration to UUID id field doesn't properly convert integers (SQLite).
--+--
 Reporter:  Martin Baker  |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:  invalid
 Keywords:  UUID  | Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--

Comment (by Martin Baker):

 I guess to me this just seems like something Django should be able to
 automagically take care of. This seems like a semi-frequent use case: I
 made some objects, oh oops I want them to be non-sequential / UUID-y.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.7d39614b60b30a088828eaef87d57781%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30523: StatReloader does not update file times if notify_file_changed() is triggered.

[Django]

#30523: StatReloader does not update file times if notify_file_changed() is
triggered.
-+--
 Reporter:  Tom Forbes   |Owner:  Tom Forbes
 Type:  Bug  |   Status:  assigned
Component:  Utilities|  Version:  2.2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by felixxm):

 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 Regression in 6754bffa2b2df15a741008aa611c1bb0e8dff22b (2.2.1).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.6cc00f669f0d73ebf100aafb3b6b2666%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30523: StatReloader does not update file times if notify_file_changed() is triggered. (was: StatReloader does not update file times if notify_file_changed() is triggered)

[Django]

#30523: StatReloader does not update file times if notify_file_changed() is
triggered.
+--
 Reporter:  Tom Forbes  |Owner:  Tom Forbes
 Type:  Bug |   Status:  assigned
Component:  Utilities   |  Version:  2.2
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by felixxm):

 * stage:  Accepted => Unreviewed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.0a87085bddd93222f34d7a053b6c7eec%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30526: migration to UUID id field doesn't properly convert integers (SQLite). (was: migration to UUID id field doesn't properly convert integers (SQLite))

[Django]

#30526: migration to UUID id field doesn't properly convert integers (SQLite).
--+--
 Reporter:  Martin Baker  |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:  invalid
 Keywords:  UUID  | Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by felixxm):

 * status:  new => closed
 * version:  2.2 => master
 * resolution:   => invalid


Comment:

 Thanks for this report, however changing column data type is always a
 sensitive operation and you need to be aware of database caveats. SQLite
 doesn't have a native `UUID` data type, so Django handles it as a
 `char(32)`. Altering data type from `integer` to `char` is possible with
 auto-conversion that's why you didn't get any issue when running this
 migration. I don't think that there is much that Django can do here.

 To fix existing data you can add
 [https://docs.djangoproject.com/en/stable/topics/migrations/#data-
 migrations custom data migration] and use Python's
 `uuid.UUID(int=existing_pk)` to convert data from `int` to `UUID`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.58e0341c5c8b11187a1570f8ce9e0200%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30516: Autoreloader crashes on re-raising exceptions with custom signature.

[Django]

#30516: Autoreloader crashes on re-raising exceptions with custom signature.
-+--
 Reporter:  Alan Trick   |Owner:  Tom Forbes
 Type:  Bug  |   Status:  closed
Component:  Utilities|  Version:  2.2
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  autoreload   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by Mariusz Felisiak ):

 In [changeset:"ace0bec804d0bd74e1ecddbe3ea9a8b5b5d0a718" ace0bec8]:
 {{{
 #!CommitTicketReference repository=""
 revision="ace0bec804d0bd74e1ecddbe3ea9a8b5b5d0a718"
 [2.2.x] Fixed #30516 -- Fixed crash of autoreloader when re-raising
 exceptions with custom signature.

 Regression in c8720e7696ca41f3262d5369365cc1bd72a216ca.

 Backport of 0344565179527d80990e2247e3be7c04aa8c43c8 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.24d1fa788fa077c542ef24d8b07719f7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30516: Autoreloader crashes on re-raising exceptions with custom signature.

[Django]

#30516: Autoreloader crashes on re-raising exceptions with custom signature.
-+--
 Reporter:  Alan Trick   |Owner:  Tom Forbes
 Type:  Bug  |   Status:  closed
Component:  Utilities|  Version:  2.2
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  autoreload   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"0344565179527d80990e2247e3be7c04aa8c43c8" 0344565]:
 {{{
 #!CommitTicketReference repository=""
 revision="0344565179527d80990e2247e3be7c04aa8c43c8"
 Fixed #30516 -- Fixed crash of autoreloader when re-raising exceptions
 with custom signature.

 Regression in c8720e7696ca41f3262d5369365cc1bd72a216ca.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6831edb98b4944376c7b221e16430681%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.