Re: [Django] #31028: Use JavaScript classList API

[Django]

#31028: Use JavaScript classList API
-+-
 Reporter:  Jon Dufresne |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz):

 Jon, I like your cleanup work a lot!
 However, about the admin JavaScript code, I think we should more clearly
 state the minimal browser version supported. A quick search revealed this
 [https://docs.djangoproject.com/en/2.2/faq/admin/#what-browsers-are-
 supported-for-using-the-admin FAQ entry] which might be outdated by now.
 Read also [https://groups.google.com/forum/#!msg/django-
 developers/MN9nz5rJODY/MAIOEVKCAQAJ this django-developers thread]. I
 think we should make it clearer in the docs before continuing the cleanup
 work.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8f386ba4949d75f09e47b197aaa1d496%40djangoproject.com.

Re: [Django] #28469: Add additional response type subclasses

[Django]

#28469: Add additional response type subclasses
-+-
 Reporter:  Adam (Chainz)|Owner:  nobody
  Johnson|
 Type:  New feature  |   Status:  closed
Component:  HTTP handling|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"9f1ec9efc35bbb375c9cebb3e0d8c1b7be838338" 9f1ec9e]:
 {{{
 #!CommitTicketReference repository=""
 revision="9f1ec9efc35bbb375c9cebb3e0d8c1b7be838338"
 Fixed #28469 -- Doc'd how to create a custom HttpResponse subclass.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.11a3e941ebadfe2a7c19d738ae33a7f2%40djangoproject.com.

Re: [Django] #28469: Add additional response type subclasses

[Django]

#28469: Add additional response type subclasses
-+-
 Reporter:  Adam (Chainz)|Owner:  nobody
  Johnson|
 Type:  New feature  |   Status:  closed
Component:  HTTP handling|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"76e0846c90e872a04638a835b7c33b41874441d2" 76e0846c]:
 {{{
 #!CommitTicketReference repository=""
 revision="76e0846c90e872a04638a835b7c33b41874441d2"
 [3.0.x] Fixed #28469 -- Doc'd how to create a custom HttpResponse
 subclass.

 Backport of 9f1ec9efc35bbb375c9cebb3e0d8c1b7be838338 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.2116636f1f490958cc4d5656ac8c4eaa%40djangoproject.com.

Re: [Django] #28469: Add additional response type subclasses

[Django]

#28469: Add additional response type subclasses
-+-
 Reporter:  Adam (Chainz)|Owner:  nobody
  Johnson|
 Type:  New feature  |   Status:  closed
Component:  HTTP handling|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"ad56858e83c39f50612f635500a1a5df37b245d3" ad56858e]:
 {{{
 #!CommitTicketReference repository=""
 revision="ad56858e83c39f50612f635500a1a5df37b245d3"
 [2.2.x] Fixed #28469 -- Doc'd how to create a custom HttpResponse
 subclass.

 Backport of 9f1ec9efc35bbb375c9cebb3e0d8c1b7be838338 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.605477f4cae80a68811fac7262d581b0%40djangoproject.com.

Re: [Django] #20456: Easier unit testing for class-based views

[Django]

#20456: Easier unit testing for class-based views
---+--
 Reporter:  Benoît Bryon   |Owner:  Felipe Lee
 Type:  New feature|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  cbv test   | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Felipe Lee):

 * needs_better_patch:  1 => 0


Comment:

 Made the change a bit ago but I forgot I needed to come in here to remove
 the "Patch needs improvement" flag. Sorry about that.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.5679765ac6a8d221ce33f5100059f1b2%40djangoproject.com.

Re: [Django] #31006: Document how to escape a date/time format character for the |date and |time filters.

[Django]

#31006: Document how to escape a date/time format character for the |date and 
|time
filters.
-+-
 Reporter:  Baptiste Mispelon|Owner:  Ryan
 Type:   |  Cheley
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Ryan Cheley):

 Added example to 'time' as suggested by @felixxm here
 [https://github.com/django/django/pull/12128]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1fb66d3a0251fff95a99003f18868d0d%40djangoproject.com.

Re: [Django] #31027: Prefer DOM object properties over Element.getAttribute() and Element.setAttribute()

[Django]

#31027: Prefer DOM object properties over Element.getAttribute() and
Element.setAttribute()
-+-
 Reporter:  Jon Dufresne |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jon Dufresne):

 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/12138

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.82db5c563a156f8d4b800c4daa6a28a4%40djangoproject.com.

Re: [Django] #31028: Use JavaScript classList API

[Django]

#31028: Use JavaScript classList API
-+-
 Reporter:  Jon Dufresne |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jon Dufresne):

 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/12139

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6d2c05502c46541515757614f1471df1%40djangoproject.com.

[Django] #31028: Use JavaScript classList API

[Django]

#31028: Use JavaScript classList API
+
   Reporter:  Jon Dufresne  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  contrib.admin |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Some JavaScript code does string matching with the `.className`. This can
 be simplified with the newer `classList` API designed to add, remove, and
 check for classes in HTML elements.

 https://developer.mozilla.org/en-US/docs/Web/API/Element/classList

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.01894d16116a5af5a6a038f6f460fd49%40djangoproject.com.

[Django] #31027: Prefer DOM object properties over Element.getAttribute() and Element.setAttribute()

[Django]

#31027: Prefer DOM object properties over Element.getAttribute() and
Element.setAttribute()
+
   Reporter:  Jon Dufresne  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  contrib.admin |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Some JavaScript code uses `Element.getAttribute()` or
 `Element.setAttribute()` to access data that is available through a DOM
 object property. In general, the properties should be preferred as they
 are always normalized values and typed. The
 `getAttribute()`/`setAttribute()` are an abstraction over the serialized
 text representation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.85932744c295df401b61c34ba1272c7b%40djangoproject.com.

Re: [Django] #30998: Make it easier to use the model instance in ChoiceWidget.create_option()

[Django]

#30998: Make it easier to use the model instance in ChoiceWidget.create_option()
--+
 Reporter:  Jon Dufresne  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Jon Dufresne):

 * needs_docs:  1 => 0


Comment:

 Sounds good. I've documented the attribute and classes.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c70e3d77d0d2564887013f69e439a217%40djangoproject.com.

Re: [Django] #29942: viewsource links to contrib.auth.forms not appearing

[Django]

#29942: viewsource links to contrib.auth.forms not appearing
---+--
 Reporter:  Yemar Nevets   |Owner:  Hasan Ramezani
 Type:  Bug|   Status:  assigned
Component:  Documentation  |  Version:  2.1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Hasan Ramezani):

 * owner:  Prabakaran Kumaresshan => Hasan Ramezani
 * has_patch:  0 => 1


Comment:

 It is not only `contrib.auth.forms`. here are the missing source code
 files list.


 {{{
 django/db/models/fields/related_descriptors.html
 django/contrib/contenttypes/fields.html
 django/contrib/contenttypes/admin.html
 django/contrib/contenttypes/forms.html
 django/contrib/contenttypes/models.html
 django/contrib/admin/models.html
 django/contrib/admin/apps.html
 django/contrib/sessions/base_session.html
 django/contrib/auth/validators.html
 django/contrib/auth/views.html
 django/contrib/auth/mixins.html
 django/contrib/auth/middleware.html
 django/contrib/auth/backends.html
 django/contrib/auth/forms.html
 django/contrib/auth/models.html
 django/contrib/auth/base_user.html
 }}}

 from [https://www.sphinx-doc.org/en/master/usage/extensions/viewcode.html
 Sphinx viewcode extensions]: `Basically, viewcode extension will import
 the modules being linked to`.

 when Sphinx tries to do for example `import django.contrib.auth.forms`, it
 will get
 {{{
 django.core.exceptions.ImproperlyConfigured: Requested setting
 INSTALLED_APPS, but settings are not configured. You must either define
 the environment variable DJANGO_SETTINGS_MODULE or call
 settings.configure() before accessing settings.
 }}}


 So, I created a [https://github.com/django/django/pull/12135 PR] to load
 the apps in [https://github.com/django/django/blob/master/docs/conf.py].
 But the `docs ` test failed. But in my local machine, it works and missed
 source files generated successfully.

 I don't know this is a good solution or not. just a PR to start the
 discussion.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.e9ba290a2e23b3ffd0730f54c17cdbd6%40djangoproject.com.

Re: [Django] #31002: AttributeError when using a GIS filter against a subquery annotation.

[Django]

#31002: AttributeError when using a GIS filter against a subquery annotation.
-+-
 Reporter:  Vasileios Bouzas |Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  GIS  |  Version:  2.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.534104d5eb68f8b3df29d1f2616ff228%40djangoproject.com.

Re: [Django] #31026: Switch form rendering to template engine

[Django]

#31026: Switch form rendering to template engine
--+
 Reporter:  Johannes Hoppe|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Johannes Hoppe):

 Yes, I'll take some time next week to do some research.
 The default idea, is great. That would make it even more versatile, love
 it!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9bc92fde6435f877b19847cd8fd71e4d%40djangoproject.com.

Re: [Django] #31002: AttributeError when using a GIS filter against a subquery annotation. (was: Query on annotated spatial fields)

[Django]

#31002: AttributeError when using a GIS filter against a subquery annotation.
-+-
 Reporter:  Vasileios Bouzas |Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  GIS  |  Version:  2.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * status:  new => assigned
 * owner:  nobody => Simon Charette


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.88c3f23bb71c1e5b9566255c8a757ab6%40djangoproject.com.

Re: [Django] #31026: Switch form rendering to template engine

[Django]

#31026: Switch form rendering to template engine
--+
 Reporter:  Johannes Hoppe|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Simon Charette):

 * stage:  Unreviewed => Accepted


Comment:

 I think that it makes sense. It'd be great if you could do a bit of
 research on #15667 to figure if this was simply overlooked or if there was
 a reason for not doing it in the first place.

 I think there's also a ticket out there to allow `Form.__str__()` to use
 `as_p` or `as_ul` instead of `as_table` by default. If we were using
 template based rendering we could simply define a
 `django/forms/default.html` that `{% include "django/forms/table.html"
 %}`, use it in `.__str__()` and document that the former must be
 overridden to achieve the desired behaviour.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8bce6b5d57cb99d2c301c2a451d22bf1%40djangoproject.com.

Re: [Django] #31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode

[Django]

#31010: Add subdomains of localhost to ALLOWED_HOSTS in DEBUG mode
---+-
 Reporter:  thenewguy  |Owner:  thenewguy
 Type:  Uncategorized  |   Status:  assigned
Component:  Uncategorized  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+-
Changes (by Simon Charette):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 Hey there, thanks for your PR! Please don't mark your own patch ''Ready
 for Checking'', someone else has to review it and mark it accordingly. I
 left come comments for improvements on the PR.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.468faebcd453ad2757a941388154d47e%40djangoproject.com.

Re: [Django] #31026: Switch form rendering to template engine

[Django]

#31026: Switch form rendering to template engine
-+-
 Reporter:  Johannes Hoppe   |Owner:  nobody
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Johannes Hoppe):

 * has_patch:  0 => 1


Comment:

 I drafted something, to add more context, to what I am proposing:
 https://github.com/django/django/pull/12133/files

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.79253bf5bd7235650d9190b803b63639%40djangoproject.com.