Re: [Django] #29338: Can't use OuterRef in union Subquery

2020-02-03 Thread Django
#29338: Can't use OuterRef in union Subquery
-+-
 Reporter:  Matthew Pava |Owner:  felixxm
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * owner:  (none) => felixxm
 * needs_better_patch:  1 => 0
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b281b2cff1ddf1d408c1856c561ce178%40djangoproject.com.


Re: [Django] #31222: Typo in "Reporting bugs and requesting features" docs.

2020-02-03 Thread Django
#31222: Typo in "Reporting bugs and requesting features" docs.
-+-
 Reporter:  Vibhu Agarwal|Owner:  Vibhu
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by felixxm):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.ac2680feaf7df8ea41ea036c7018f69d%40djangoproject.com.


[Django] #31224: Add asynchronous views.

2020-02-03 Thread Django
#31224: Add asynchronous views.
+---
   Reporter:  felixxm   |  Owner:  Andrew Godwin
   Type:  New feature   | Status:  assigned
  Component:  Core (Other)  |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+---
 Add asynchronous views in Django (see
 [https://github.com/django/deps/blob/master/accepted/0009-async.rst#views-
 http-handling details]).

 Accepted based on
 [https://github.com/django/deps/blob/master/accepted/0009-async.rst DEP
 0009: Async-capable Django].

 [https://github.com/django/django/pull/11650 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.5e87cb6d38d40014d46bf9492c0d2ec1%40djangoproject.com.


[Django] #31225: Use slugify in get_valid_filename

2020-02-03 Thread Django
#31225: Use slugify in get_valid_filename
+
   Reporter:  Guillaume Thomas  |  Owner:  nobody
   Type:  Uncategorized | Status:  new
  Component:  Utilities |Version:  3.0
   Severity:  Normal|   Keywords:  text
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Django uses the function
 
[https://github.com/django/django/blob/6b178a3e930f72069f3cda2e6a09d1b320fc09ec/django/utils/text.py#L221-L232
 `get_valid_filename`] to get a 'clean filename' from any input string.

 Theoretically, this function only keeps unicode characters (underscore
 included), dashes (`-`) and points (`.`). It relies on the standard `re`
 package to match unicode characters.

 There are several forms of unicode normalization
 (https://docs.python.org/3.8/library/unicodedata.html#unicodedata.normalize)
 and after having done some tests, it appears that `re` only handle the NFC
 normalization.

 For instance:
 {{{
 import re
 import unicodedata

 re.match("^\w$", unicodedata.normalize("NFC", "é"), re.UNICODE)
 # <_sre.SRE_Match object; span=(0, 1), match='é'>

 re.match("^\w$", unicodedata.normalize("NFD", "é"), re.UNICODE)
 # None
 }}}

 This makes `get_valid_filename` behave differently according to the
 unicode normalization of the input string. Thus:
 {{{
 import unicodedata
 from django.utils.text import get_valid_filename

 get_valid_filename(unicodedata.normalize("NFC", "é"))
 # é

 get_valid_filename(unicodedata.normalize("NFD", "é"))
 # e
 }}}

 It appears that this normalization depends on the operating system. On
 MacOS, it uses a [https://ss64.com/osx/syntax-filenames.html nearly NFD].
 On Unix, it's NFC. In the end, for files coming from MacOS systems,
 filenames are "slugified" which is not the case for other operating
 systems. My feeling at this stage is that this complexity could be
 abstracted for the developer and have a "normalization independant"
 handling of strings for this function.

 I also think we could go further and force filenames to only contain ascii
 characters. This curiosity was found after we had an issue with our setup
 which consists of a django app behing a nginx. To retrieve private media
 files, django returns an empty http response and provide the internal
 filename with the
 [https://www.nginx.com/resources/wiki/start/topics/examples/x-accel/#x
 -accel-redirect `X-Accel-Redirect` header]. The problem was that nginx
 does not seem to like non ascii characters here.

 In the end, i think a lot of bug could be avoided by forcing a NFD
 normalization the in `get_valid_filename` function. It'd be roughly the
 same behaviour as `slugify` with `allow_unicode=False`

 What do you think?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/047.d9d33c08afa3c91f2f855f3ba6d80f1d%40djangoproject.com.


Re: [Django] #31225: Use NFD normalization in get_valid_filename (was: Use slugify in get_valid_filename)

2020-02-03 Thread Django
#31225: Use NFD normalization in get_valid_filename
--+--
 Reporter:  Guillaume Thomas  |Owner:  nobody
 Type:  Uncategorized |   Status:  new
Component:  Utilities |  Version:  3.0
 Severity:  Normal|   Resolution:
 Keywords:  text  | Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.57c357199799c6561f85f40f39978c67%40djangoproject.com.


Re: [Django] #29338: Can't use OuterRef in union Subquery

2020-02-03 Thread Django
#29338: Can't use OuterRef in union Subquery
-+-
 Reporter:  Matthew Pava |Owner:  felixxm
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.358601416833303b630ac165c8aa1d24%40djangoproject.com.


Re: [Django] #28905: Overhaul extra_requires to include more optional dependencies

2020-02-03 Thread Django
#28905: Overhaul extra_requires to include more optional dependencies
-+-
 Reporter:  Jaap Roes|Owner:  Rishabh
 Type:   |  Arya
  Cleanup/optimization   |   Status:  assigned
Component:  Packaging|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  setup optional   | Triage Stage:  Accepted
  dependencies packages  |
  requirements   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Rishabh Arya):

 * owner:  Nick Pope => Rishabh Arya


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.4d6711771ae256538091b2e308b9bf15%40djangoproject.com.


Re: [Django] #31222: Typo in "Reporting bugs and requesting features" docs.

2020-02-03 Thread Django
#31222: Typo in "Reporting bugs and requesting features" docs.
-+-
 Reporter:  Vibhu Agarwal|Owner:  Vibhu
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"1a09708dcb2f60ad5ca0a75b8de9619356f74ff6" 1a09708d]:
 {{{
 #!CommitTicketReference repository=""
 revision="1a09708dcb2f60ad5ca0a75b8de9619356f74ff6"
 Fixed #31222 -- Fixed typo in docs/internals/contributing/bugs-and-
 features.txt.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.4e19ef4cda77a565116c9629092907d2%40djangoproject.com.


Re: [Django] #31222: Typo in "Reporting bugs and requesting features" docs.

2020-02-03 Thread Django
#31222: Typo in "Reporting bugs and requesting features" docs.
-+-
 Reporter:  Vibhu Agarwal|Owner:  Vibhu
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"8ed5ac4eb42b036144072e94d88873c1eaef09cb" 8ed5ac4]:
 {{{
 #!CommitTicketReference repository=""
 revision="8ed5ac4eb42b036144072e94d88873c1eaef09cb"
 [3.0.x] Fixed #31222 -- Fixed typo in docs/internals/contributing/bugs-
 and-features.txt.

 Backport of 1a09708dcb2f60ad5ca0a75b8de9619356f74ff6 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.76722d782c7fa313790227770c306155%40djangoproject.com.


Re: [Django] #27604: Use set_signed_cookie for contrib.messages Cookie storage

2020-02-03 Thread Django
#27604: Use set_signed_cookie for contrib.messages Cookie storage
-+-
 Reporter:  Anthony King |Owner:  Craig
 Type:   |  Anderson
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.messages |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.743d85b87d28cdda76e5d8ba18a7da71%40djangoproject.com.


Re: [Django] #31225: Use NFD normalization in get_valid_filename(). (was: Use NFD normalization in get_valid_filename)

2020-02-03 Thread Django
#31225: Use NFD normalization in get_valid_filename().
-+-
 Reporter:  Guillaume Thomas |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Utilities|  Version:  3.0
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  text | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  new => closed
 * type:  Uncategorized => Cleanup/optimization
 * resolution:   => wontfix


Comment:

 Thanks for this ticket, however I don't think that Django should normalize
 filenames, the current behavior is tested and documented (see #16315 with
 a discussion and arguments against a similar change in
 `FileSystemStorage`). You can start a discussion on DevelopersMailingList
 if you don't agree.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.e54cab77b678d310b8711c64eb52bf03%40djangoproject.com.


[Django] #31226: Typo in "Submitting patches" docs.

2020-02-03 Thread Django
#31226: Typo in "Submitting patches" docs.
+
   Reporter:  Vibhu Agarwal |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Documentation |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 Documentation Link:
 https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
 /submitting-patches/#deprecating-a-feature

 Under **Deprecating a feature**:  First Line
 "''There are a **couple reasons** that code in Django might be
 deprecated:''"

 Problem: Missing preposition

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/056.03a239dba7520d50cca66c50269ab27f%40djangoproject.com.


Re: [Django] #31226: Typo in "Submitting patches" docs.

2020-02-03 Thread Django
#31226: Typo in "Submitting patches" docs.
-+-
 Reporter:  Vibhu Agarwal|Owner:  Vibhu
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Vibhu Agarwal):

 * owner:  nobody => Vibhu Agarwal
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.e1cd3baf9cc5af6bd990b98e9b62d3a1%40djangoproject.com.


Re: [Django] #31226: Typo in "Submitting patches" docs.

2020-02-03 Thread Django
#31226: Typo in "Submitting patches" docs.
-+-
 Reporter:  Vibhu Agarwal|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Vibhu Agarwal):

 * Attachment "django_doc_typo_ss.png" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.50645a2acfcd348a780e03745cc3bce4%40djangoproject.com.


Re: [Django] #31226: Typo in "Submitting patches" docs.

2020-02-03 Thread Django
#31226: Typo in "Submitting patches" docs.
-+-
 Reporter:  Vibhu Agarwal|Owner:  Vibhu
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Vibhu Agarwal):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.a503b9a23cddc9a1c6f81d9d77eab5c2%40djangoproject.com.


Re: [Django] #31221: HStoreField returns str instead of dict during tests. (was: HStoreField returns str instead of dict during tests)

2020-02-03 Thread Django
#31221: HStoreField returns str instead of dict during tests.
+--
 Reporter:  Michael Mulholland  |Owner:  (none)
 Type:  Bug |   Status:  closed
Component:  contrib.postgres|  Version:  master
 Severity:  Normal  |   Resolution:  needsinfo
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by felixxm):

 * status:  new => closed
 * type:  Uncategorized => Bug
 * version:  2.2 => master
 * resolution:   => needsinfo


Comment:

 Thanks for this ticket, however it works for me. This can be an issue in
 your custom `TestRunner`, is there any reason to not use
 `HStoreExtension()` in migrations instead of a custom `TestRunner`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.c377c9f01343f625fa77acd913659ecb%40djangoproject.com.


Re: [Django] #25313: Document how to migrate from a built-in User model to a custom User model

2020-02-03 Thread Django
#25313: Document how to migrate from a built-in User model to a custom User 
model
---+
 Reporter:  Carl Meyer |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Documentation  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Carsten Fuchs):

 Based on

   - Aymeric's [https://code.djangoproject.com/ticket/25313#comment:2
 approach above],
   - Tobias's blog post https://www.caktusgroup.com/blog/2019/04/26/how-
 switch-custom-django-user-model-mid-project/,
   - Vitor's blog post
 https://simpleisbetterthancomplex.com/tutorial/2016/07/26/how-to-reset-
 migrations.html

 I tried to write a summary. These steps worked well for me, although I'm
 sure there is room for improvement:


 == Assumptions

   - Your project doesn't have a custom user model yet.

   - All existing users must be kept.

   - There are no pending migrations and all existing migrations are
 applied.

   - It is acceptable that all previous migrations are lost and can no
 longer be unapplied, even if you use version control to checkout old
 commits that still have the migration files. This is the relevant downside
 of this approach.


 == Preparations

   - Make sure that ''any third party apps'' that refer to the Django User
 model only use the
 [https://docs.djangoproject.com/en/3.0/topics/auth/customizing
 /#referencing-the-user-model generic referencing methods].

   - Make sure that ''your own reusable apps'' (apps that are intended to
 be used by others) use the generic reference methods.

   - I suggest to ''not'' do the same with your project apps:
 The switch to a custom user model is only done once per project and
 never again.
 It is easier (and in my opinion also clearer) to change `from
 django.contrib.auth.models import User`
 to something else (as detailed below) than replacing it with generic
 references that are not needed in project code.

   - Make sure that you have a backup of your code and database!


 == Update the code

   - You can create the new user model in any existing app or a newly
 created one.
 My preference is to create a new app:
 {{{#!python
 ./manage.py startapp Accounts
 }}}
 I chose the name "Accounts", but any other name works as well.

   - Aymeric: „Create a custom user model identical to `auth.User`,
 call it `User` (so many-to-many tables keep the same name)
 and set `db_table='auth_user'` (so it uses the same table).“
 In `Accounts/models.py`:
 {{{#!python
 from django.contrib.auth.models import AbstractUser
 from django.db import models


 class User(AbstractUser):
 class Meta:
 db_table = 'auth_user'
 }}}

   - In `settings.py`, add the app to `INSTALLED_APPS` and update the
 `AUTH_USER_MODEL` setting:
 {{{#!python
 INSTALLED_APPS = (
 # ...
 'Accounts',
 )

 AUTH_USER_MODEL = 'Accounts.User'
 }}}

   - In your project code, replace all imports of the Django user model:
 {{{#!python
 from django.contrib.auth.models import User
 }}}
 with the new, custom one:
 {{{#!python
 from Accounts.models import User
 }}}

   - Delete all old migrations. (Beforehand, see if
 [https://code.djangoproject.com/ticket/25313#comment:14 comment 14] is
 relevant to you!)
 For example, in the project root:
 {{{#!sh
 find . -path "*/migrations/*.py" -not -name "__init__.py" -delete
 find . -path "*/migrations/*.pyc" -delete
 }}}

   - Create new migrations from scratch:
 {{{#!sh
 ./manage.py makemigrations
 }}}

   - Make any changes to your `admin.py` files as required.
 (I cannot give any solid information here, but this is not crucial for
 the result and so the details can still be reviewed later.)

   - Make sure that your testsuite completes successfully! (A fresh test
 database must be used, it cannot be kept from previous runs.)

   - At this point, the changes to the code are complete. This is a good
 time for a commit.

 Note that we're done – except that the new migration files mismatch the
 contents of the `django_migrations` table.

 (It may even be possible to serve your project at this point: It's easy to
 back off before the database is actually changed. ''Only'' do this if you
 understand that you ''cannot even touch'' the migrations system as long as
 the steps below are not completed!)


 == Update the database

   - Truncate the `django_migra

Re: [Django] #31221: HStoreField returns str instead of dict during tests.

2020-02-03 Thread Django
#31221: HStoreField returns str instead of dict during tests.
+--
 Reporter:  Michael Mulholland  |Owner:  (none)
 Type:  Bug |   Status:  closed
Component:  contrib.postgres|  Version:  master
 Severity:  Normal  |   Resolution:  needsinfo
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--

Comment (by Michael Mulholland):

 Replying to [comment:3 felixxm]:
 > is there any reason to not use `HStoreExtension()` in migrations instead
 of a custom `TestRunner`.

 Looks like that was my problem. The migrations for the app I work on were
 created with {{{makemigrations}}} and the original db user wasn't a
 superuser so they couldn't run {{{HStoreExtension}}} (the extension was
 being created externally). Upon closer inspection, the only other
 operation being run by {{{HStoreExtension}}} is clearing cached hstore
 oids. Adding {{{get_hstore_oids.cache_clear()}}} to my testrunner fixes
 the issue, though I'll probably just scrap the testrunner and add
 {{{HStoreExtension}}}.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.39eff4170cc81e6955e8df6ccf842777%40djangoproject.com.


Re: [Django] #31221: HStoreField returns str instead of dict during tests.

2020-02-03 Thread Django
#31221: HStoreField returns str instead of dict during tests.
+--
 Reporter:  Michael Mulholland  |Owner:  (none)
 Type:  Bug |   Status:  closed
Component:  contrib.postgres|  Version:  master
 Severity:  Normal  |   Resolution:  invalid
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by felixxm):

 * resolution:  needsinfo => invalid


Comment:

 Thanks for sharing the results of your investigation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.5588e15b73370a78f1126eb220d02c77%40djangoproject.com.


Re: [Django] #31226: Typo in "Submitting patches" docs.

2020-02-03 Thread Django
#31226: Typo in "Submitting patches" docs.
-+-
 Reporter:  Vibhu Agarwal|Owner:  Vibhu
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by felixxm):

 * stage:  Unreviewed => Accepted


Comment:

 [https://github.com/django/django/pull/12409 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.90cbd8592a248b77d4b63df1d49bf274%40djangoproject.com.


Re: [Django] #31210: Document backwards-compatible replacement for is_ajax().

2020-02-03 Thread Django
#31210: Document backwards-compatible replacement for is_ajax().
-+-
 Reporter:  Collin Anderson  |Owner:  Adam
 Type:   |  (Chainz) Johnson
  Cleanup/optimization   |   Status:  assigned
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Adam (Chainz) Johnson):

 * owner:  SUTHARRAM => Adam (Chainz) Johnson
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.c348b50ec5cef832a5b04584a428a9c0%40djangoproject.com.


[Django] #31227: Doing filter or exclude after an intersection

2020-02-03 Thread Django
#31227: Doing filter or exclude after an intersection
-+-
   Reporter:  acomanda   |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Database   |Version:  3.0
  layer (models, ORM)|
   Severity:  Release|   Keywords:
  blocker|
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 In the 2.2.x version it was possible to do first an intersection and after
 that a filter or exclude on the resulting query set.
 Now it leeds to an error.
 The error says
 django.db.utils.NotSupportedError: Calling QuerySet.filter() after
 intersection() is not supported.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.0598263bec4df125e9d8b149537e7e60%40djangoproject.com.


Re: [Django] #31227: Doing filter() or exclude() after an intersection(). (was: Doing filter or exclude after an intersection)

2020-02-03 Thread Django
#31227: Doing filter() or exclude() after an intersection().
-+-
 Reporter:  acomanda |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  new => closed
 * resolution:   => invalid
 * severity:  Release blocker => Normal


Comment:

 Yes it was possible to call `QuerySet.filter()/exclude()` after
 `QuerySet.intersection()/union()/difference()` but these calls were
 ignored, i.e. they didn't affect combined queries. That's why we decided
 to raise a descriptive error (see #27995).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f5d580707c68598b4774d63f170c27f5%40djangoproject.com.


Re: [Django] #31226: Typo in "Submitting patches" docs.

2020-02-03 Thread Django
#31226: Typo in "Submitting patches" docs.
-+-
 Reporter:  Vibhu Agarwal|Owner:  Vibhu
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"6f9ecc23f676e7a6f25d1a6cf830fe638a1eb589" 6f9ecc2]:
 {{{
 #!CommitTicketReference repository=""
 revision="6f9ecc23f676e7a6f25d1a6cf830fe638a1eb589"
 Fixed #31226 -- Fixed typo in docs/internals/contributing/writing-code
 /submitting-patches.txt.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.b0d13c80563a5b5789b3ab8bbf62ccbc%40djangoproject.com.


Re: [Django] #31226: Typo in "Submitting patches" docs.

2020-02-03 Thread Django
#31226: Typo in "Submitting patches" docs.
-+-
 Reporter:  Vibhu Agarwal|Owner:  Vibhu
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"0bf1330fe41e9a8ce04806c764fd5c90e1bafe5d" 0bf1330]:
 {{{
 #!CommitTicketReference repository=""
 revision="0bf1330fe41e9a8ce04806c764fd5c90e1bafe5d"
 [3.0.x] Fixed #31226 -- Fixed typo in docs/internals/contributing/writing-
 code/submitting-patches.txt.

 Backport of 6f9ecc23f676e7a6f25d1a6cf830fe638a1eb589 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.8b3292c3908f42883cfe0d65d0f0cdfa%40djangoproject.com.


[Django] #31228: SQLite does support DISTINCT on aggregate functions

2020-02-03 Thread Django
#31228: SQLite does support DISTINCT on aggregate functions
-+-
   Reporter:  André  |  Owner:  nobody
  Terra  |
   Type:  Bug| Status:  new
  Component:  Database   |Version:  3.0
  layer (models, ORM)|
   Severity:  Normal |   Keywords:  sqlite
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Contrary to what is suggested in
 
[https://github.com/django/django/blob/6f9ecc23f676e7a6f25d1a6cf830fe638a1eb589/django/db/backends/sqlite3/operations.py#L60
 lines 60-64] of `django.db.backends.sqlite3.operations.py`, SQLite does
 support DISTINCT on aggregate functions.

 One such example is GROUP_CONCAT, which is quite similar to PostgreSQL's
 STRING_AGG.

 I can't find any canonical links which provide a useful explanation of
 GROUP_CONCAT, but this should be good enough:
 https://www.w3resource.com/sqlite/aggregate-functions-and-grouping-
 group_concat.php

 I came across this issue when trying to create my own `GroupConcat`
 function subclassing `Aggregate` (similar to the
 
[https://github.com/django/django/blob/6f9ecc23f676e7a6f25d1a6cf830fe638a1eb589/django/contrib/postgres/aggregates/general.py#L53
 StringAgg implementation] from postgres) and noticed that skipping the
 check in `django.db.backends.sqlite3.operations.py` would allow my queries
 to run as advertised.

 My code for `GroupConcat` is:

 {{{
 from django.db.models import Value
 from django.db.models.aggregates import Aggregate

 class GroupConcat(Aggregate):
 function = 'GROUP_CONCAT'
 template = '%(function)s(%(distinct)s %(expressions)s)'
 allow_distinct = True

 def __init__(self, expression, delimiter=None, **extra):
 if delimiter is not None:
 self.allow_distinct = False
 delimiter_expr = Value(str(delimiter))
 super().__init__(expression, delimiter_expr, **extra)
 else:
 super().__init__(expression, **extra)

 def as_sqlite(self, compiler, connection, **extra_context):
 return super().as_sql(
 compiler, connection,
 function=self.function,
 template=self.template,
 **extra_context
 )
 }}}


 For the record, as the code above suggests, a separate issue is that
 GROUP_CONCAT only allows DISTINCT when a delimiter isn't specified.

 After some discussion on #django, an argument was raised in favor of
 changing the message to say "Django doesn't support...", but I would
 imagine that skipping the check entirely would simply result in an
 `OperationalError` for malformed queries while still allowing users to
 extend the ORM as needed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.9e4fe55569459c0640f81ab205ae0dee%40djangoproject.com.


[Django] #31229: Add setting to allow flexible session saving based on response codes

2020-02-03 Thread Django
#31229: Add setting to allow flexible session saving based on response codes
-+
   Reporter:  Vincent Wang   |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Uncategorized  |Version:  3.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 Inside
 django.contrib.sessions.middleware.SessionMiddleware.process_response
 
(https://github.com/django/django/blob/master/django/contrib/sessions/middleware.py),
 we have a line where we don't save the session of the request if the
 response status code is 500. The comment in the code refers to this issue:
 https://code.djangoproject.com/ticket/3881 where it's concluded that a 500
 code is most likely to indicate that it's an incomplete request and the
 response shouldn't save anything else.

 I would find it useful to be able to prevent saving of the session when
 the response status code is anything in the 5xx status code range. This
 would be possible if we implemented some setting that defaulted to include
 the status code 500, but allowed users to override it with a list of
 status codes where the session would not save.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.30b77ab1588aa56041cfbdb7d2905738%40djangoproject.com.


Re: [Django] #31229: Add setting to allow flexible session saving based on response codes

2020-02-03 Thread Django
#31229: Add setting to allow flexible session saving based on response codes
---+--
 Reporter:  Vincent Wang   |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Uncategorized  |  Version:  3.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Vincent Wang):

 * type:  Uncategorized => New feature


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1024ab1737ad770800c786b53a366246%40djangoproject.com.


Re: [Django] #31229: Add setting to allow flexible session saving based on response codes

2020-02-03 Thread Django
#31229: Add setting to allow flexible session saving based on response codes
--+--
 Reporter:  Vincent Wang  |Owner:  nobody
 Type:  Uncategorized |   Status:  new
Component:  contrib.sessions  |  Version:  3.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Vincent Wang):

 * type:  New feature => Uncategorized
 * component:  Uncategorized => contrib.sessions


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.9bac85061346f916d9439ede6c733feb%40djangoproject.com.


Re: [Django] #31228: DISTINCT with GROUP_CONCAT() and multiple expressions raises NotSupportedError on SQLite. (was: SQLite does support DISTINCT on aggregate functions)

2020-02-03 Thread Django
#31228: DISTINCT with  GROUP_CONCAT() and multiple expressions raises
NotSupportedError on SQLite.
-+-
 Reporter:  Andy Terra   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  sqlite   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * cc: Simon Charette (added)
 * version:  3.0 => master
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for this ticket. I agree that it shouldn't raise an error in some
 cases, but removing this check is not an option, IMO.

 Regression in bc05547cd8c1dd511c6b6a6c873a1bc63417b111.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5029cefdd81bf47b632355bac2c9556b%40djangoproject.com.


Re: [Django] #27604: Use set_signed_cookie for contrib.messages Cookie storage

2020-02-03 Thread Django
#27604: Use set_signed_cookie for contrib.messages Cookie storage
-+-
 Reporter:  Anthony King |Owner:  Craig
 Type:   |  Anderson
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.messages |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"bcc9fa25285f50fa5074fc43c7114d61bb79" bcc9fa25]:
 {{{
 #!CommitTicketReference repository=""
 revision="bcc9fa25285f50fa5074fc43c7114d61bb79"
 Refs #27604 -- Added CookieStorage.key_salt to allow customization.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6e42a1d371a5d0204b532df3959af8c8%40djangoproject.com.


Re: [Django] #27604: Use set_signed_cookie for contrib.messages Cookie storage

2020-02-03 Thread Django
#27604: Use set_signed_cookie for contrib.messages Cookie storage
-+-
 Reporter:  Anthony King |Owner:  Craig
 Type:   |  Anderson
  Cleanup/optimization   |   Status:  closed
Component:  contrib.messages |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8ae84156d62bfc24d71e65cfe4d5cb84b9b1bd91" 8ae8415]:
 {{{
 #!CommitTicketReference repository=""
 revision="8ae84156d62bfc24d71e65cfe4d5cb84b9b1bd91"
 Fixed #27604 -- Used the cookie signer to sign message cookies.

 Co-authored-by: Craig Anderson 
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1d44a1fd4702e8309dd3802258ba03c3%40djangoproject.com.


Re: [Django] #31230: Dynamic fieldset is not showing as per intended

2020-02-03 Thread Django
#31230: Dynamic fieldset is not showing as per intended
+--
 Reporter:  vishalrawat123  |Owner:  nobody
 Type:  Uncategorized   |   Status:  new
Component:  Uncategorized   |  Version:  2.2
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by vishalrawat123):

 * Attachment "Screenshot from 2020-02-04 11-11-44.png" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.eb29ecac73e805192067e14d0f70cb11%40djangoproject.com.


Re: [Django] #31230: Dynamic fieldset is not showing as per intended

2020-02-03 Thread Django
#31230: Dynamic fieldset is not showing as per intended
+--
 Reporter:  vishalrawat123  |Owner:  nobody
 Type:  Uncategorized   |   Status:  new
Component:  Uncategorized   |  Version:  2.2
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by vishalrawat123):

 * Attachment "Screenshot from 2020-02-04 11-17-32.png" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.bc1785ea84e093497b2870c59e1095aa%40djangoproject.com.


[Django] #31230: Dynamic fieldset is not showing as per intended

2020-02-03 Thread Django
#31230: Dynamic fieldset is not showing as per intended
--+
   Reporter:  vishalrawat123  |  Owner:  nobody
   Type:  Uncategorized   | Status:  new
  Component:  Uncategorized   |Version:  2.2
   Severity:  Normal  |   Keywords:
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+
 When i wants to show dynamic fieldset in admin panel according the user
 type of current admin panel user (staff or superuser)

 Sometime (on refreshing the page) It is not showing the field dynamic like
 in case of staff it shows the both approved_by_staff and approved_by_admin
 fields

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/057.26e1916cc5bffa8483a363c67e64e831%40djangoproject.com.