Re: [Django] #31368: Document Field.from_db_value()'s "expression" parameter. (was: Document from_db_value()'s "expression" parameter.)

[Django]

#31368: Document Field.from_db_value()'s "expression" parameter.
-+-
 Reporter:  Paolo Lammens|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:  documentation,   | Triage Stage:  Accepted
  missing|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1f959da7d1d2e34c789935fbcc4b3714%40djangoproject.com.

Re: [Django] #31368: Document from_db_value()'s "expression" parameter. (was: Missing documentation for `from_db_value`)

[Django]

#31368: Document from_db_value()'s "expression" parameter.
-+-
 Reporter:  Paolo Lammens|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:  documentation,   | Triage Stage:  Accepted
  missing|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * stage:  Unreviewed => Accepted


Comment:

 Django uses backend and field/expression converters. `expression` is a
 field or an expression and it's used by backend converters. All converters
 have the same signature that's why we keep the `expression` parameter in
 `Field.from_db_value()` and `Expression.convert_value()` signatures even
 if for them it's the same as `self`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.cd5fe5db8cb2f4309e0cd5e1be05ab70%40djangoproject.com.

Re: [Django] #31172: Note that yesno can be affected by extra spaces in translations.

[Django]

#31172: Note that yesno can be affected by extra spaces in translations.
-+-
 Reporter:  José Antonio Ruiz|Owner:  Hasan
 |  Ramezani
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Hasan Ramezani):

 * owner:  José Antonio Ruiz => Hasan Ramezani
 * status:  new => assigned
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c2d428915a023dc1e7191c382e332679%40djangoproject.com.

[Django] #31369: Deprecate NullBooleanField

[Django]

#31369: Deprecate NullBooleanField
-+-
   Reporter:  David  |  Owner:  nobody
  Smith  |
   Type: | Status:  new
  Cleanup/optimization   |
  Component:  Database   |Version:  3.0
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 #29227 allowed `BooleanField` to be null=true, a step towards deprecating
 `NullBooleanField`. #27917 also mentions an aim to deprecate this field.

 [https://github.com/django/django/pull/8467#discussion_r175504425
 Comments] on the PR discussed deprecating `NullBooleanField` with the
 conclusion being that we should wait a while. Now that we are almost 2
 years on, and with Django 4.0 being sometime away I suggest now is a good
 time to revisit this decision.

 This ticket therefore proposes we deprecate `NullBooleanField`. It would
 be good to also tidy up the associated fields / widgets e.g. #23681
 discussed deprecation of `NullBooleanSelect`

 Note: I was slightly unsure if this is best raised as a ticket or as a
 topic on the mailing list.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.3d60b6e91d67cd2db88bcdc1a66073b5%40djangoproject.com.

[Django] #31368: Missing documentation for `from_db_value`

[Django]

#31368: Missing documentation for `from_db_value`
-+-
   Reporter:  Paolo  |  Owner:  nobody
  Lammens|
   Type: | Status:  new
  Cleanup/optimization   |
  Component: |Version:  3.0
  Documentation  |   Keywords:  documentation,
   Severity:  Normal |  missing
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 The documentation on the semantics and usage for the `expression`
 parameter in the
 
[https://docs.djangoproject.com/en/3.0/ref/models/fields/#django.db.models.Field.from_db_value
 `from_db_value` converter] is nowhere to be found.

 The only two places that mention this method are the
 
[https://docs.djangoproject.com/en/3.0/ref/models/fields/#django.db.models.Field.from_db_value
 Model field reference] and the
 [https://docs.djangoproject.com/en/3.0/howto/custom-model-fields
 /#converting-values-to-python-objects "Writing custom model fields"
 guide], but neither mention what `expression` is or how it should be used.

 In fact, there is no specification for `value` or `connection` either, but
 at least the meaning of these parameters can be inferred.


 See also: https://stackoverflow.com/q/60560775/6117426

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.e966c240e6dc75fc14fbd710df4dd0e2%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Rohit Jha
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Rohit Jha):

 * owner:  (none) => Rohit Jha
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.797814512f1cece50155e15146cbbec4%40djangoproject.com.

Re: [Django] #29214: Invalid SQL generated when annotating a subquery with an outerref to an annotated field.

[Django]

#29214: Invalid SQL generated when annotating a subquery with an outerref to an
annotated field.
-+-
 Reporter:  Oskar Persson|Owner:  Chetan
 |  Khanna
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  queryset | Triage Stage:  Accepted
  annotations|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Chetan Khanna):

 Sorry, I forgot that. I got occupied with my GSoC application since the
 submissions have already started.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.bb7cc09127e7ea1d4011a558d4577b6c%40djangoproject.com.

Re: [Django] #31367: ImportError error while importing class from auth/mixin to auth/view. (was: ImportError error while importing class from auth/mixin to auth/view)

[Django]

#31367: ImportError error while importing class from auth/mixin to auth/view.
-+-
 Reporter:  Mehmet İnce  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 Thanks for this ticket, however `django.contrib.auth.mixins` contains
 [https://docs.djangoproject.com/en/3.0/topics/auth/default/ documented]
 mixins that can be used with CBVs. `SuccessURLAllowedHostsMixin` is not
 one of them, it's an internal mixin specific for login/logout views, so
 currently there is no need to import anything from
 `django.contrib.auth.mixins` in the `django.contrib.auth.views`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.2d2de7b72ef9656b965b42ba7141f7b6%40djangoproject.com.

Re: [Django] #31255: Migrations create a redundant RemoveField operation when deleting 2 models with related fields.

[Django]

#31255: Migrations create a redundant RemoveField operation when deleting 2 
models
with related fields.
--+
 Reporter:  Panagis Alisandratos  |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Migrations|  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  migration,optimizer   | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Rohit Jha):

 * owner:  Rohit Jha => (none)
 * status:  assigned => new


Comment:

 Sanskar Jaiswal: Please feel free to pick this

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f6fdccc6e325c56f909c3b58ea42f8b4%40djangoproject.com.

Re: [Django] #31367: ImportError error while importing class from auth/mixin to auth/view

[Django]

#31367: ImportError error while importing class from auth/mixin to auth/view
-+-
 Reporter:  Mehmet İnce  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mehmet İnce):

 * has_patch:  0 => 1
 * version:  3.0 => master


Comment:

 https://github.com/django/django/pull/12577/

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a3468ab4eb6a40282c0c0f6ef4638d50%40djangoproject.com.

Re: [Django] #29214: Invalid SQL generated when annotating a subquery with an outerref to an annotated field.

[Django]

#29214: Invalid SQL generated when annotating a subquery with an outerref to an
annotated field.
-+-
 Reporter:  Oskar Persson|Owner:  Chetan
 |  Khanna
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  queryset | Triage Stage:  Accepted
  annotations|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.07e1d92e81dbb1d84d29475ff29f6736%40djangoproject.com.

[Django] #31367: ImportError error while importing class from auth/mixin to auth/view

[Django]

#31367: ImportError error while importing class from auth/mixin to auth/view
+
   Reporter:  Mehmet İnce   |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  contrib.auth  |Version:  3.0
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 While I was doing some tests about discussion related to the
 [https://groups.google.com/forum/#!topic/django-developers/PUQQUHIxEXQ] ,
 I've realized that it's not possible to import class from
 django.contrib.auth.mixins to the django.contrib.auth.views .

 **Reproduce**

 Add following mixin to the auth/mixins.py
 {{{
 class LoginRequiredExemptMixin(object):
 login_required_exempt = True
 }}}

 And import it at auth/views.py and use it on one of the CBV. For instance
 LoginView.

 {{{
 from django.contrib.auth.mixins import LoginRequiredExemptMixin

 class LoginView(SuccessURLAllowedHostsMixin, FormView,
 LoginRequiredExemptMixin):
 """
 Display the login form and handle the login action.
 """
 }}}

 In that case, you will be seeing following ImportError


 {{{
   File "/Users/xxx/PycharmProjects/django/django/contrib/auth/mixins.py",
 line 4, in 
 from django.contrib.auth.views import redirect_to_login
   File "/Users/xxx/PycharmProjects/django/django/contrib/auth/views.py",
 line 13, in 
 from django.contrib.auth.mixins import LoginRequiredExemptMixin
 ImportError: cannot import name 'LoginRequiredExemptMixin' from
 'django.contrib.auth.mixins'
 (/Users/mince/PycharmProjects/django/django/contrib/auth/mixins.py)
 }}}

 **How To Fix**

 The reason of the error is mixins.py file have "django.contrib.auth.views
 import redirect_to_login" on line 4. Since the redirect_to_login is only
 used one place (handle_no_permission  function) in mixin.py we can remove
 the import from top of the file and call it right before usage of the
 imported function. For example as follow.

 {{{
 def handle_no_permission(self):
 if self.raise_exception or self.request.user.is_authenticated:
 raise PermissionDenied(self.get_permission_denied_message())
 from django.contrib.auth.views import redirect_to_login
 return redirect_to_login(self.request.get_full_path(),
 self.get_login_url(), self.get_redirect_field_name())


 }}}

 On the other hand, I think why we have **SuccessURLAllowedHostsMixin**
 class in auth/views.py file even though it's been called Mixin was related
 that import code in mixin.py too.

 By doing this changes we can even move **SuccessURLAllowedHostsMixin**
 class to the mixins.py file since it's only being used in auth/views.py.
 That little changes gives us flexibility to import mixings in the feature.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.ed2af1dd257a8295eb89bd1640e8c415%40djangoproject.com.

Re: [Django] #31340: Improve expression support for __search lookup and SearchQuery

[Django]

#31340: Improve expression support for __search lookup and SearchQuery
-+-
 Reporter:  Baptiste Mispelon|Owner:  Baptiste
 |  Mispelon
 Type:  New feature  |   Status:  closed
Component:  contrib.postgres |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"3baf92cf8230ad3a932986170fd07c8feae7ff2f" 3baf92cf]:
 {{{
 #!CommitTicketReference repository=""
 revision="3baf92cf8230ad3a932986170fd07c8feae7ff2f"
 Fixed #31340 -- Allowed query expressions in SearchQuery.value and
 __search lookup.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7c0a123bb1b9524e480bd958d75858d0%40djangoproject.com.

Re: [Django] #29131: Make the error message for ArrayField more user and translation-friendly

[Django]

#29131: Make the error message for ArrayField more user and translation-friendly
--+
 Reporter:  Vlada Macek   |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  closed
Component:  contrib.postgres  |  Version:  2.0
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  1
--+

Comment (by felixxm):

 I'm not sure what kind of change or documentation improvement we could do.
 These patches changed only error messages. Index and slice transforms
 still use 0-based indexing.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.bdf1057f60b1bf5af182f1edbe655f17%40djangoproject.com.

Re: [Django] #31366: GEOSGeometry fails on instance with GEOJson and srid not 4326. (was: GEOSGeometry fails on instance with GEOJson and srid not 4326)

[Django]

#31366: GEOSGeometry fails on instance with GEOJson and srid not 4326.
---+--
 Reporter:  Walter Lorenzetti  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  GIS|  Version:  master
 Severity:  Normal |   Resolution:  invalid
 Keywords:  Geodjango  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by felixxm):

 * status:  new => closed
 * version:  2.2 => master
 * resolution:   => invalid


Comment:

 It's
 [https://docs.djangoproject.com/en/3.0/ref/contrib/gis/geos/#geosgeometry
 documented] that ''"for the GeoJSON format, the SRID is set based on the
 crs member. If crs isn’t provided, the SRID defaults to 4326"''. So if you
 want to use GeoJSON with a different SRID you need to use `crs`, e.g.
 {{{
 {
   "type": "Point",
   "coordinates": [2, 49],
   "crs": {
 "type": "name",
 "properties": {
   "name": "urn:ogc:def:crs:EPSG::3857"
 }
   }
 }
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.6034d0074b867104fa5a14841aa8c2a0%40djangoproject.com.

Re: [Django] #29131: Make the error message for ArrayField more user and translation-friendly

[Django]

#29131: Make the error message for ArrayField more user and translation-friendly
--+
 Reporter:  Vlada Macek   |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  closed
Component:  contrib.postgres  |  Version:  2.0
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  1
--+

Comment (by Pavel Savchenko):

 This feature came as a surprise to us when we upgraded from 2.0 to 2.1, as
 we were relying on 0-index (i.e we were adding +1 manually to ).

 I guess it's too late for release notes (though we could mention it in
 3.1?), though we could also mention that it's 1-indexed in the related
 documentation here:

 
https://docs.djangoproject.com/en/3.0/ref/contrib/postgres/fields/#django.contrib.postgres.fields.ArrayField.base_field

 What do you think, shall we create a separate ticket for documenting this?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.110304021aa4f352b8fd4f38d71bb785%40djangoproject.com.

Re: [Django] #31340: Improve expression support for __search lookup and SearchQuery

[Django]

#31340: Improve expression support for __search lookup and SearchQuery
-+-
 Reporter:  Baptiste Mispelon|Owner:  Baptiste
 |  Mispelon
 Type:  New feature  |   Status:  assigned
Component:  contrib.postgres |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * version:  3.0 => master
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ff78db20394241dbccbd431f6f8eccc5%40djangoproject.com.

Re: [Django] #31363: Django humanize's intword filter does not accept negative numbers.

[Django]

#31363: Django humanize's intword filter does not accept negative numbers.
-+-
 Reporter:  jay20162016  |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  contrib.humanize |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"924c01ba095f7df9529a65c176a892a5c1624ec5" 924c01b]:
 {{{
 #!CommitTicketReference repository=""
 revision="924c01ba095f7df9529a65c176a892a5c1624ec5"
 Fixed #31363 -- Added support for negative integers to intword template
 filter.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.92b60f1b82608e4583684b67a2e84a26%40djangoproject.com.

Re: [Django] #31360: Is `request.csrf_processing_done` part of the public CSRF protection API?

[Django]

#31360: Is `request.csrf_processing_done` part of the public CSRF protection 
API?
-+-
 Reporter:  Jaap Roes|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  CSRF |  Version:  3.0
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jaap Roes):

 Hi Carlton,

 As I was typing that last sentence I considered just posting it on Stack
 Overflow instead. But the fist bit seemed appropriate as a Django ticket,
 sorry for the noise.

 As a note; the `requires_csrf_token` decorator only overrides `_reject` so
 the entire CSRF machinery is kept intact. The only difference is that
 `_reject` doesn't result in a 400 response. This makes it "safe" for me to
 make the assumption about `csrf_processing_done`.

 The issue now being that this relies on the implementation
 `requires_csrf_token` and `CsrfViewMiddleware` not changing too much
 between Django releases. Let's see what SO can come up with as a "safer"
 alternative ;)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.1dee691072d07c44efdf4c9e799cc1d9%40djangoproject.com.

Re: [Django] #31363: Django humanize's intword filter does not accept negative numbers.

[Django]

#31363: Django humanize's intword filter does not accept negative numbers.
-+-
 Reporter:  jay20162016  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.humanize |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.ec60d65e61181eaf01c31975ffac9ad1%40djangoproject.com.

Re: [Django] #31351: Need warning when UniqueConstraint with condition is used but supports_partial_indexes is False

[Django]

#31351: Need warning when UniqueConstraint with condition is used but
supports_partial_indexes is False
-+-
 Reporter:  Matthijs Kooijman|Owner:  Ichlasul
 Type:   |  Affan
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Ichlasul Affan):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.8bd98673f5c757e860b1ee88cb9c8bc6%40djangoproject.com.

[Django] #31366: GEOSGeometry fails on instance with GEOJson and srid not 4326

[Django]

#31366: GEOSGeometry fails on instance with GEOJson and srid not 4326
-+---
   Reporter:  Walter Lorenzetti  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  GIS|Version:  2.2
   Severity:  Normal |   Keywords:  Geodjango
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+---
 On creating a GEOSGeometry intance by a GEOJson string with a srid not
 4326, I obtain this error:
 coord = '{"type": "Point", "coordinates": [1, 1]}'

 {{{
 g = GEOSGeometry(coord, srid=3857)
 Traceback (most recent call last):
   File "", line 1, in 
   File "/home/envs/g3w_suite_dj22/lib/python3.6/site-
 packages/django/contrib/gis/geos/geometry.py", line 732, in __init__
 raise ValueError('Input geometry already has SRID: %d.' % input_srid)
 ValueError: Input geometry already has SRID: 4326.
 }}}

 So to fix it I use this not beautyfull solution:

 {{{
 g = GEOSGeometry(GEOSGeometry(coord).wkt, srid=3857)
 }}}

 Thanks in advance.
 W

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/054.8ca702193ed0d14148d0985e3c8f4865%40djangoproject.com.

Re: [Django] #31361: Fix admin invalid HTML5 empty action="" attribute.

[Django]

#31361: Fix admin invalid HTML5 empty action="" attribute.
-+-
 Reporter:  Jon Dufresne |Owner:  Jon
 Type:   |  Dufresne
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"3857a08bdb05e30f90f56a7dd0d505ad19f4c403" 3857a08b]:
 {{{
 #!CommitTicketReference repository=""
 revision="3857a08bdb05e30f90f56a7dd0d505ad19f4c403"
 Fixed #31361 -- Fixed invalid action="" in admin forms.

 The attribute action="" (empty string) on the  element is invalid
 HTML5. The spec (https://html.spec.whatwg.org/#attr-fs-action) says:

 > The action and formaction content attributes, if specified, must have
 > a value that is a valid non-empty URL potentially surrounded by
 > spaces.

 Emphasis on non-empty. The action attribute is allowed to be omitted, in
 which case the current URL is used which is the same behavior as now.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6d3a008d4d88dab56d094564c16d7c12%40djangoproject.com.

Re: [Django] #31361: Fix admin invalid HTML5 empty action="" attribute.

[Django]

#31361: Fix admin invalid HTML5 empty action="" attribute.
-+-
 Reporter:  Jon Dufresne |Owner:  Jon
 Type:   |  Dufresne
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c7db986cdd2e3e1895256e9962ff88b9%40djangoproject.com.