Re: [Django] #31451: Settings are cleaned insufficiently.

[Django]

#31451: Settings are cleaned insufficiently.
-+-
 Reporter:  Markus Holtermann|Owner:  Ichlasul
 Type:   |  Affan
  Cleanup/optimization   |   Status:  assigned
Component:  Error reporting  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ichlasul Affan):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.49cfb7fa44d4136be2599a3a4ca5b975%40djangoproject.com.

Re: [Django] #31451: Settings are cleaned insufficiently.

[Django]

#31451: Settings are cleaned insufficiently.
-+-
 Reporter:  Markus Holtermann|Owner:  Ichlasul
 Type:   |  Affan
  Cleanup/optimization   |   Status:  assigned
Component:  Error reporting  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ichlasul Affan):

 [https://github.com/django/django/pull/12700 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.2d53d5037d65f9428d46ec5daa1907c1%40djangoproject.com.

Re: [Django] #31451: Settings are cleaned insufficiently.

[Django]

#31451: Settings are cleaned insufficiently.
-+-
 Reporter:  Markus Holtermann|Owner:  Ichlasul
 Type:   |  Affan
  Cleanup/optimization   |   Status:  assigned
Component:  Error reporting  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ichlasul Affan):

 Do I need to change both versions? Or just create a single implementation
 for current master branch?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.58ab402c451de87bc374bddf1507d0b5%40djangoproject.com.

Re: [Django] #31451: Settings are cleaned insufficiently.

[Django]

#31451: Settings are cleaned insufficiently.
-+-
 Reporter:  Markus Holtermann|Owner:  Ichlasul
 Type:   |  Affan
  Cleanup/optimization   |   Status:  assigned
Component:  Error reporting  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ichlasul Affan):

 * owner:  (none) => Ichlasul Affan
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.63fd419ad88a421eba37a6c7241a2bae%40djangoproject.com.

Re: [Django] #31055: Omits test_ prefix from database name when running subset of tests

[Django]

#31055: Omits test_ prefix from database name when running subset of tests
-+-
 Reporter:  Matthijs Kooijman|Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  closed
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"e8d308892597e6abee5b94a77543a7ef7d34a655" e8d3088]:
 {{{
 #!CommitTicketReference repository=""
 revision="e8d308892597e6abee5b94a77543a7ef7d34a655"
 Refs #31055 -- Allowed database queries in
 invalid_models_tests.test_models.FieldNamesTests.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.698a21806e5ae774c7018d833de27093%40djangoproject.com.

Re: [Django] #31351: Need warning when UniqueConstraint with condition is used but supports_partial_indexes is False

[Django]

#31351: Need warning when UniqueConstraint with condition is used but
supports_partial_indexes is False
-+-
 Reporter:  Matthijs Kooijman|Owner:  Ichlasul
 Type:   |  Affan
  Cleanup/optimization   |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"53d229ff632c2a3e547f2820a94239f38ba4d4ac" 53d229ff]:
 {{{
 #!CommitTicketReference repository=""
 revision="53d229ff632c2a3e547f2820a94239f38ba4d4ac"
 Fixed #31351 -- Added system checks for partial indexes and unique
 constraints support.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.01a0ab910e0a08625763e135aa0a2963%40djangoproject.com.

Re: [Django] #20372: using registration/logged_out.html template overrides admin logout

[Django]

#20372: using registration/logged_out.html template overrides admin logout
-+-
 Reporter:  tomerz@… |Owner:  Alexis
 Type:   |  Bellido
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  1.5
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Hamed Fathi):

 The problem is same structure of template and registration folder for
 admin and our own app. When we use auth admin view at default it will go
 to the admin template folder and registration folder and render that html
 file. Am I right? or it works in an other way?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.d3a4e736d38b6cb95109ec6499b74a90%40djangoproject.com.

Re: [Django] #31451: Settings are cleaned insufficiently. (was: Settings are cleaned insufficiently)

[Django]

#31451: Settings are cleaned insufficiently.
--+
 Reporter:  Markus Holtermann |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Error reporting   |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by felixxm):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.64f6927bd9bfc0a7e6a246473fa38b40%40djangoproject.com.

Re: [Django] #31441: TabluarInline will not auto unhide/expand when classes = ['collapse'] and there is error during the saving process in django admin

[Django]

#31441: TabluarInline will not auto unhide/expand when classes = ['collapse'] 
and
there is error during the saving process in django admin
-+-
 Reporter:  Jian |Owner:  Hasan
 |  Ramezani
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin.TabularInline  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Hasan Ramezani):

 * has_patch:  0 => 1


Comment:

 I created a [https://github.com/django/django/pull/12697 PR] to address
 the first two options.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.770a8a3c55f6b0553c592b9b7f7f7e75%40djangoproject.com.

[Django] #31451: Settings are cleaned insufficiently

[Django]

#31451: Settings are cleaned insufficiently
+
   Reporter:  Markus Holtermann |  Owner:  (none)
   Type:  Cleanup/optimization  | Status:  new
  Component:  Error reporting   |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Posting publicly after checking with the rest of the security team.

 I just ran into a case where
 `django.views.debug.SafeExceptionReporterFilter.get_safe_settings()` would
 return several un-cleansed values. Looking at `cleanse_setting()` I
 realized that we
 
[https://github.com/django/django/blob/f5ede1cb6da473166d22c04dcbd8240e2a0f223d/django/views/debug.py#L91-L92
 only take care of `dict`s] but don't take other types of iterables into
 account but
 
[https://github.com/django/django/blob/f5ede1cb6da473166d22c04dcbd8240e2a0f223d/django/views/debug.py#L93-L94
 return them as-is].

 Example:

 In my settings.py I have this:

 {{{#!python
 MY_SETTING = {
 "foo": "value",
 "secret": "value",
 "token": "value",
 "something": [
 {"foo": "value"},
 {"secret": "value"},
 {"token": "value"},
 ],
 "else": [
 [
 {"foo": "value"},
 {"secret": "value"},
 {"token": "value"},
 ],
 [
 {"foo": "value"},
 {"secret": "value"},
 {"token": "value"},
 ],
 ]
 }
 }}}

 On Django 3.0 and below:

 {{{#!python
 >>> import pprint
 >>> from django.views.debug import get_safe_settings
 >>> pprint.pprint(get_safe_settings()["MY_SETTING"])
 {'else': [[{'foo': 'value'}, {'secret': 'value'}, {'token': 'value'}],
   [{'foo': 'value'}, {'secret': 'value'}, {'token': 'value'}]],
  'foo': 'value',
  'secret': '',
  'something': [{'foo': 'value'}, {'secret': 'value'}, {'token': 'value'}],
  'token': ''}
 }}}

 On Django 3.1 and up:

 {{{#!python
 >>> from django.views.debug import SafeExceptionReporterFilter
 >>> import pprint
 >>>
 pprint.pprint(SafeExceptionReporterFilter().get_safe_settings()["MY_SETTING"])
 {'else': [[{'foo': 'value'}, {'secret': 'value'}, {'token': 'value'}],
   [{'foo': 'value'}, {'secret': 'value'}, {'token': 'value'}]],
  'foo': 'value',
  'secret': '',
  'something': [{'foo': 'value'}, {'secret': 'value'}, {'token': 'value'}],
  'token': ''}
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.f6f3b5d9e2d50ef024ebba5be178d79b%40djangoproject.com.

Re: [Django] #31202: Bulk update suffers from poor performance with large numbers of models and columns

[Django]

#31202: Bulk update suffers from poor performance with large numbers of models 
and
columns
-+-
 Reporter:  Tom Forbes   |Owner:  Tom
 Type:   |  Forbes
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Florian Demmer):

 * cc: Florian Demmer (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.2a590cd4437280dafe115c79b82fb71f%40djangoproject.com.

[Django] #31450: Querying on ArrayField(PointField) returns string instead of list

[Django]

#31450: Querying on ArrayField(PointField) returns string instead of list
-+-
   Reporter:  nsangwan   |  Owner:  (none)
   Type:  Bug| Status:  new
  Component: |Version:  3.0
  contrib.postgres   |   Keywords:  ArrayField,
   Severity:  Normal |  PointField
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 The following code

 {{{
 from django.db import models
 from django.contrib.postgres.fields import ArrayField
 from django.contrib.gis.db.models import PointField


 class Foo(models.Model):
 bar = ArrayField(models.TextField)
 baz = ArrayField(PointField())
 }}}

 has this wrong behaviour:


 {{{
 x = Foo.objects.get(id=1)
 x.bar #  => ['Foo', 'Bar']
 x.baz #  => '{HexRepresentationofPoint1,HexRepresentationofPoint2}'
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.b99e9cb3dd2704a4d7d5d18e4e841974%40djangoproject.com.

Re: [Django] #31351: Need warning when UniqueConstraint with condition is used but supports_partial_indexes is False

[Django]

#31351: Need warning when UniqueConstraint with condition is used but
supports_partial_indexes is False
-+-
 Reporter:  Matthijs Kooijman|Owner:  Ichlasul
 Type:   |  Affan
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by felixxm):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.b1d3f9a2ad203a1265edac4d2d6188f2%40djangoproject.com.

Re: [Django] #21076: Offer the ability to store a hash of session IDs rather than the ID itself

[Django]

#21076: Offer the ability to store a hash of session IDs rather than the ID 
itself
--+
 Reporter:  Tim Graham|Owner:  Mark
 Type:  New feature   |   Status:  assigned
Component:  contrib.sessions  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Mark):

 Requesting feedback about naming convention (see
 [https://github.com/django/django/pull/8736#issuecomment-610986822 this PR
 comment]) to make a clear distinction between incoming "clear text"
 session keys and session keys that are stored in the sessions backend
 (potentially hashed, but not necessarily, depending on settings and
 existing session keys). My suggestion is to use the names `frontend_key`
 and `backend_key` respectively.

 Also requesting feedback concerning a refactor of the `SessionBase` API to
 DRY-up the session key conversion (see
 [https://github.com/django/django/pull/8736#issuecomment-611934012 this PR
 comment]).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.54c217d80a45a168e508e50666531eef%40djangoproject.com.

Re: [Django] #31448: Support HTML messages in send_mass_mail(). (was: Support HTML messages in send_mass_mail and EmailMessage)

[Django]

#31448: Support HTML messages in send_mass_mail().
+--
 Reporter:  Pepe Bawagan|Owner:  nobody
 Type:  New feature |   Status:  closed
Component:  Core (Mail) |  Version:  3.0
 Severity:  Normal  |   Resolution:  wontfix
 Keywords:  html_message, mail  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by felixxm):

 * status:  new => closed
 * has_patch:  1 => 0
 * resolution:   => wontfix
 * easy:  1 => 0


Comment:

 The API for `send_mass_mail()` is
 
[https://github.com/django/django/blob/090ca6512f514556394d4a8d321db7883f03e2a6/django/core/mail/__init__.py#L74-L75
 frozen] so we will not accept any new functionalities. Check also
 [https://docs.djangoproject.com/en/3.0/topics/email/#sending-multiple-
 emails docs] about sending multiple emails.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c6ef8994bc12aeb7903b178db78ff384%40djangoproject.com.

Re: [Django] #28305: AlterField migration tries to alter column that still has a foreign key contraint

[Django]

#28305: AlterField migration tries to alter column that still has a foreign key
contraint
-+-
 Reporter:  Andreas Backx|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Migrations   |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  mysql,   | Triage Stage:  Accepted
  onetoonefield, utf8mb4, foreign|
  key|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"f5ede1cb6da473166d22c04dcbd8240e2a0f223d" f5ede1cb]:
 {{{
 #!CommitTicketReference repository=""
 revision="f5ede1cb6da473166d22c04dcbd8240e2a0f223d"
 Refs #28305 -- Consolidated field referencing detection in migrations.

 This moves all the field referencing resolution methods to shared
 functions instead of duplicating efforts amongst state_forwards and
 references methods.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.e2a054bf0ca53221e2b9e7f1c24b9396%40djangoproject.com.

Re: [Django] #31447: ManifestStaticFilesStorage should have file exclude patterns.

[Django]

#31447: ManifestStaticFilesStorage should have file exclude patterns.
-+-
 Reporter:  Carsten Fuchs|Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  contrib.staticfiles  |  Version:  3.0
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carsten Fuchs):

 Okay! I thought this might be of general interest, but reconsidering I
 think you're right, this is better placed in a subclass. Thank you!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1b9b533078cf330a1ef65f780ba4e937%40djangoproject.com.

Re: [Django] #31447: ManifestStaticFilesStorage should have file exclude patterns.

[Django]

#31447: ManifestStaticFilesStorage should have file exclude patterns.
-+-
 Reporter:  Carsten Fuchs|Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  contrib.staticfiles  |  Version:  3.0
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by felixxm):

 Replying to [comment:2 Carsten Fuchs]:
 > Hello Felix,
 >
 > sorry, my description was probably not clear:
 > When we use `ManifestStaticFilesStorage`, the `collectstatic` command
 copies and creates static files such that the result is, for example:
 > {{{
 > usermanual.4b127df11c35.pdf
 > usermanual.pdf
 > }}}
 > In a template, using `{% static 'usermanual.pdf' %}`, links to
 `.../static/usermanual.4b127df11c35.pdf` are generated. What I intended
 with the above suggested `STATICFILES_MANIFEST_EXCLUDES` setting is to
 have only
 > {{{
 > usermanual.pdf
 > }}}
 > copied and `{% static 'usermanual.pdf' %}` generating a link to
 `.../static/usermanual.pdf`, just as if not the manifest, but the default
 `StaticFilesStorage` was used. (For all files not covered by
 `STATICFILES_MANIFEST_EXCLUDES`, the hashed paths should be used.)
 >
 > In contrast to that, `collectstatic --ignore` doesn't copy the ignored
 files at all, causing `{% static 'usermanual.pdf' %}` to raise an
 exception.

 You should be able to [https://docs.djangoproject.com/en/3.0/howto/custom-
 file-storage/#writing-a-custom-storage-system write a custom] subclass of
 
[https://docs.djangoproject.com/en/3.0/ref/contrib/staticfiles/#manifeststaticfilesstorage
 ManifestStaticFilesStorage] for this. We don't want to provide settings
 for customizing the `ManifestStaticFilesStorage` behavior.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ddbf854bb90c7ef226181c5ea1fa70dd%40djangoproject.com.

Re: [Django] #31447: ManifestStaticFilesStorage should have file exclude patterns.

[Django]

#31447: ManifestStaticFilesStorage should have file exclude patterns.
-+-
 Reporter:  Carsten Fuchs|Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  contrib.staticfiles  |  Version:  3.0
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carsten Fuchs):

 Hello Felix,

 sorry, my description was probably not clear:
 When we use `ManifestStaticFilesStorage`, the `collectstatic` command
 copies and creates static files such that the result is, for example:
 {{{
 usermanual.4b127df11c35.pdf
 usermanual.pdf
 }}}
 In a template, using `{% static 'usermanual.pdf' %}`, links to
 `.../static/usermanual.4b127df11c35.pdf` are generated. What I intended
 with the above suggested `STATICFILES_MANIFEST_EXCLUDES` setting is to
 have only
 {{{
 usermanual.pdf
 }}}
 copied and `{% static 'usermanual.pdf' %}` generating a link to
 `.../static/usermanual.pdf`, just as if not the manifest, but the default
 `StaticFilesStorage` was used. (For all files not covered by
 `STATICFILES_MANIFEST_EXCLUDES`, the hashed paths should be used.)

 In contrast to that, `collectstatic --ignore` doesn't copy the ignored
 files at all, causing `{% static 'usermanual.pdf' %}` to raise an
 exception.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4fdfde6be35b08a70b330bc312f909d3%40djangoproject.com.