date:20200428

Re: [Django] #31524: Stop minifying only some admin static assets

2020-04-28 Thread Django

#31524: Stop minifying only some admin static assets
--+
 Reporter:  Jon Dufresne  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


Comment:

 Yes, I think this is reasonable. (It's been slowly bubbling up my nag list
 for a while so... 👍)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.14de8db0a29a189a2b78ce8298746587%40djangoproject.com.

Re: [Django] #30400: Improve typography of user facing strings.

2020-04-28 Thread Django

#30400: Improve typography of user facing strings.
-+-
 Reporter:  Jon Dufresne |Owner:  Jon
 Type:   |  Dufresne
  Cleanup/optimization   |   Status:  closed
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"0dafadadb924e09ffd43287604cb4c2c6e353891" 0dafada]:
 {{{
 #!CommitTicketReference repository=""
 revision="0dafadadb924e09ffd43287604cb4c2c6e353891"
 Refs #30400 -- Improved typography of user facing strings in admin
 changelist.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8763f7a4d9c8300e510941ffdcaeb4e3%40djangoproject.com.

Re: [Django] #31522: FilteredSelectMultiple widget jumps to top when an option is added. (was: FilteredSelectMultiple widget jumps to top when an option is added)

2020-04-28 Thread Django

#31522: FilteredSelectMultiple widget jumps to top when an option is added.
-+-
 Reporter:  Shai Berger  |Owner:
 Type:   |  TapanGujjar
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-
Changes (by felixxm):

 * type:  Bug => Cleanup/optimization
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.a724ad2dc580dbdb1b748755966b4354%40djangoproject.com.

Re: [Django] #31523: Remove jQuery dependency from actions.js.

2020-04-28 Thread Django

#31523: Remove jQuery dependency from actions.js.
-+-
 Reporter:  Jon Dufresne |Owner:  Jon
 Type:   |  Dufresne
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * owner:  nobody => Jon Dufresne
 * status:  new => assigned
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8c719f6e2d4493fdf1827c77d4f10eb4%40djangoproject.com.

Re: [Django] #31521: test_parsing_rfc850 test failure on 32-bit platforms.

2020-04-28 Thread Django

#31521: test_parsing_rfc850 test failure on 32-bit platforms.
-+-
 Reporter:  Tomáš Chvátal|Owner:  Hasan
 Type:   |  Ramezani
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.7821a06b6606f9b5816087c995da16a6%40djangoproject.com.

Re: [Django] #31443: LoginRequiredMixin/AccessMixin bug with off-site LOGIN_URL

2020-04-28 Thread Django

#31443: LoginRequiredMixin/AccessMixin bug with off-site LOGIN_URL
+
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.auth|  Version:  3.0
 Severity:  Normal  |   Resolution:
 Keywords:  login required  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  1   |  Patch needs improvement:  0
Easy pickings:  1   |UI/UX:  0
+

Comment (by felixxm):

 Replying to [comment:4 minusf]:
 > ping?

 Please don't. Pinging doesn't help, you have to be patience.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.eb06488d2ed8c4d93e141795d24f2c4b%40djangoproject.com.

Re: [Django] #31524: Stop minifying only some admin static assets

2020-04-28 Thread Django

#31524: Stop minifying only some admin static assets
-+-
 Reporter:  Jon Dufresne |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jon Dufresne):

 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/12821

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b70b339bdd695ecd2b90d6a8c5053f0d%40djangoproject.com.

[Django] #31524: Stop minifying only some admin static assets

2020-04-28 Thread Django

#31524: Stop minifying only some admin static assets
+
   Reporter:  Jon Dufresne  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  contrib.admin |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Here is a list of JavaScript files in the admin app and their size:

 {{{
   20K django/contrib/admin/static/admin/js/admin/DateTimeShortcuts.js
   15K django/contrib/admin/static/admin/js/inlines.js
   13K django/contrib/admin/static/admin/js/SelectFilter2.js
  8.8K django/contrib/admin/static/admin/js/urlify.js
  7.6K django/contrib/admin/static/admin/js/calendar.js
  6.7K django/contrib/admin/static/admin/js/actions.js
  5.9K django/contrib/admin/static/admin/js/admin/RelatedObjectLookups.js
  5.4K django/contrib/admin/static/admin/js/core.js
  5.3K django/contrib/admin/static/admin/js/SelectBox.js
  5.2K django/contrib/admin/static/admin/js/inlines.min.js
  3.2K django/contrib/admin/static/admin/js/actions.min.js
  1.9K django/contrib/admin/static/admin/js/collapse.js
  1.5K django/contrib/admin/static/admin/js/prepopulate.js
  1.1K django/contrib/admin/static/admin/js/autocomplete.js
   911 django/contrib/admin/static/admin/js/collapse.min.js
   878 django/contrib/admin/static/admin/js/cancel.js
   674 django/contrib/admin/static/admin/js/change_form.js
   569 django/contrib/admin/static/admin/js/popup_response.js
   495 django/contrib/admin/static/admin/js/prepopulate_init.js
   379 django/contrib/admin/static/admin/js/prepopulate.min.js
   363 django/contrib/admin/static/admin/js/jquery.init.js
 }}}

 Some things to notice:

 1. Only 4 out of 17 files are minified.
 2. The largest file, DateTimeShortcuts.js, is only 20 KB.
 3. The largest file is also not included in the list of minified files.
 4. All uncompressed files are smaller than the size of the 3 font assets,
 each ~80 KB.
 5. All uncompressed files are smaller than the minified jQuery, ~87 KB.

 I'm not sure if there is a deliberate or historical reason that only a
 fraction of the static assets are minified, but it looks like it could be
 an oversight. The approach is inconsistent.

 Minifying is step a contributor must manually do. The documentation for
 doing so is here:

 https://docs.djangoproject.com/en/dev/internals/contributing/writing-
 code/javascript/#javascript-patches

 This is a step that is easy to forget, myself included. Whether or not one
 remembers to compress static assets will also affect the outcome of tests.

 I suggest we drop the minificaiton of admin files altogether. For such
 small files, it doesn't seem worth it to add a build step and
 inconsistently at that.

 In a typical production scenarios, the static assets will be cached and
 possibly compressed. Compressing static assets largely removes the size
 gains of minification. Additionally, there are third party apps to fill
 the role of static asset optimization.

 I think we should continue to distribute the vendored libraries minified,
 however as they are not manually handled during typical contributions.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.ea2300ee85e18d81264a88fcdefe1a34%40djangoproject.com.

Re: [Django] #31505: Document possible email address enumeration in PasswordResetView.

2020-04-28 Thread Django

#31505: Document possible email address enumeration in PasswordResetView.
-+-
 Reporter:  Mohammad Almazroa|Owner:  felixxm
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  3.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  User Enumeration | Triage Stage:  Accepted
  Security Bug   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mohammad Almazroa):

 Replying to [comment:13 Florian Apolloner]:
 > Replying to [comment:12 Mohammad Almazroa]:
 > > Question: why not fix PasswordResetView? documenting it is just not
 enough.
 >
 > Well, suggestions on fixes are welcome… Unless we want to change the
 reset view to enter the username (in which case we'd leak usernames
 instead), I do not see any obvious way on how to fix this.

 "you can use a 3rd party package that allows to send emails
 asynchronously" .. this is your solution and it's valid. why don't you
 make the reset view sends emails asynchronously?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d8b6438a97d1db21edca0e764b3e6f8e%40djangoproject.com.

Re: [Django] #31523: Remove jQuery dependency from actions.js.

2020-04-28 Thread Django

#31523: Remove jQuery dependency from actions.js.
-+-
 Reporter:  Jon Dufresne |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jon Dufresne):

 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/12820

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a9f34c960c39a0a68967b69b2428ea6c%40djangoproject.com.

[Django] #31523: Remove jQuery dependency from actions.js.

2020-04-28 Thread Django

#31523: Remove jQuery dependency from actions.js.
+
   Reporter:  Jon Dufresne  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  contrib.admin |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.8cabea6595a43c5167e4db65359b9a68%40djangoproject.com.

Re: [Django] #31522: FilteredSelectMultiple widget jumps to top when an option is added

2020-04-28 Thread Django

#31522: FilteredSelectMultiple widget jumps to top when an option is added
---+---
 Reporter:  Shai Berger|Owner:  TapanGujjar
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+---
Changes (by TapanGujjar):

 * owner:  nobody => TapanGujjar
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.3f2e01777fbb0641809318e4aafe5498%40djangoproject.com.

Re: [Django] #31521: test_parsing_rfc850 test failure on 32-bit platforms.

2020-04-28 Thread Django

#31521: test_parsing_rfc850 test failure on 32-bit platforms.
-+-
 Reporter:  Tomáš Chvátal|Owner:  Hasan
 Type:   |  Ramezani
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Hasan Ramezani):

 * owner:  nobody => Hasan Ramezani
 * status:  new => assigned
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.33341b7674cc6961ba9948df494468de%40djangoproject.com.

Re: [Django] #31443: LoginRequiredMixin/AccessMixin bug with off-site LOGIN_URL

2020-04-28 Thread Django

#31443: LoginRequiredMixin/AccessMixin bug with off-site LOGIN_URL
+
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.auth|  Version:  3.0
 Severity:  Normal  |   Resolution:
 Keywords:  login required  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  1   |  Patch needs improvement:  0
Easy pickings:  1   |UI/UX:  0
+

Comment (by minusf):

 ping?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e54acab336ea848b6e226c07bee8e492%40djangoproject.com.

Re: [Django] #31520: ManifestStaticFilesStorage should not raise ValueError on missing file when manifest_strict=False

2020-04-28 Thread Django

#31520: ManifestStaticFilesStorage should not raise ValueError on missing file 
when
manifest_strict=False
-+-
 Reporter:  thenewguy|Owner:  thenewguy
 Type:  Uncategorized|   Status:  assigned
Component:  contrib.staticfiles  |  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by thenewguy):

 @Carlton Gibson

 I left https://github.com/django/django/pull/12816 intact since it is what
 was originally discussed and I went ahead and submitted
 https://github.com/django/django/pull/12817 since I think it is the better
 fix.  Let me know what you'd like me to do.  Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.38cd46bfcdc5514f6234fbc5d1e03f19%40djangoproject.com.

Re: [Django] #27468: Move utils.crypto.salted_hmac() from SHA1 toward SHA256

2020-04-28 Thread Django

#27468: Move utils.crypto.salted_hmac() from SHA1 toward SHA256
-+-
 Reporter:  Tim Graham   |Owner:  Claude
 Type:   |  Paroz
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz):

 Mariusz, I attached a "very" WIP patch (no tests, no docs) I was working
 on some days ago. It might not even be the good approach, but feel free to
 get some inspiration if it has any merit. I'll happily review your
 version.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7ba9ada1c9b199c83450e261658c0948%40djangoproject.com.

Re: [Django] #27468: Move utils.crypto.salted_hmac() from SHA1 toward SHA256

2020-04-28 Thread Django

#27468: Move utils.crypto.salted_hmac() from SHA1 toward SHA256
-+-
 Reporter:  Tim Graham   |Owner:  Claude
 Type:   |  Paroz
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * Attachment "27468-sessions.diff" added.

 WIP patch for user sessions

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3826cb79036032b95a37d18db3acffab%40djangoproject.com.

Re: [Django] #29249: Make serializers consistently unicode by default.

2020-04-28 Thread Django

#29249: Make serializers consistently unicode by default.
-+-
 Reporter:  hakib|Owner:  Hasan
 |  Ramezani
 Type:  New feature  |   Status:  closed
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  dumpdata, unicode| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"68fc21b3784aa34c7ba5515ab02ef0c7b6ee856d" 68fc21b]:
 {{{
 #!CommitTicketReference repository=""
 revision="68fc21b3784aa34c7ba5515ab02ef0c7b6ee856d"
 Fixed #29249 -- Made JSON and YAML serializers use Unicode by default.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.ccca598840edf2106ea6e5ec310e4fe1%40djangoproject.com.

Re: [Django] #29249: Make serializers consistently unicode by default.

2020-04-28 Thread Django

#29249: Make serializers consistently unicode by default.
-+-
 Reporter:  hakib|Owner:  Hasan
 |  Ramezani
 Type:  New feature  |   Status:  assigned
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  dumpdata, unicode| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"8970bb4cfdc56cb90b84ff2154afe622c9e9eaf7" 8970bb4]:
 {{{
 #!CommitTicketReference repository=""
 revision="8970bb4cfdc56cb90b84ff2154afe622c9e9eaf7"
 Refs #29249 -- Added tests for serializing Unicode data with XML
 serializer.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.e8e5f07afe1b61de2fd67865167c9850%40djangoproject.com.

Re: [Django] #31520: ManifestStaticFilesStorage should not raise ValueError on missing file when manifest_strict=False

2020-04-28 Thread Django

#31520: ManifestStaticFilesStorage should not raise ValueError on missing file 
when
manifest_strict=False
-+-
 Reporter:  thenewguy|Owner:  thenewguy
 Type:  Uncategorized|   Status:  assigned
Component:  contrib.staticfiles  |  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by thenewguy):

 * component:  Uncategorized => contrib.staticfiles


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f202fb19cd414a3cfc1a889905698851%40djangoproject.com.

Re: [Django] #31520: ManifestStaticFilesStorage should not raise ValueError on missing file when manifest_strict=False

2020-04-28 Thread Django

#31520: ManifestStaticFilesStorage should not raise ValueError on missing file 
when
manifest_strict=False
---+-
 Reporter:  thenewguy  |Owner:  thenewguy
 Type:  Uncategorized  |   Status:  assigned
Component:  Uncategorized  |  Version:  3.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by thenewguy):

 * owner:  nobody => thenewguy
 * needs_better_patch:  1 => 0
 * status:  new => assigned
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.930f2f0beca217dd1a975effcac02977%40djangoproject.com.

Re: [Django] #1028: High-level feed framework should make more feed elements available

2020-04-28 Thread Django

#1028: High-level feed framework should make more feed elements available
-+
 Reporter:  James Bennett|Owner:  (none)
 Type:  New feature  |   Status:  new
Component:  contrib.syndication  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  djangocon| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by Tom Carrick):

 * owner:  Tom Carrick => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.4d2246b1748103ea3b1514bcea65ea1d%40djangoproject.com.

Re: [Django] #31520: ManifestStaticFilesStorage should not raise ValueError on missing file when manifest_strict=False

2020-04-28 Thread Django

#31520: ManifestStaticFilesStorage should not raise ValueError on missing file 
when
manifest_strict=False
---+
 Reporter:  thenewguy  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  3.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by thenewguy):

 Clean pull request now that I have less going on around me.  PR
 https://github.com/django/django/pull/12816

 Will submit the fix and mark ready for review once these tests complete
 showing failure

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.94b44bd7de0a0f9e27a8492acab23e18%40djangoproject.com.

Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-28 Thread Django

#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  3.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Andrew Godwin):

 I definitely endorse thread_sensitive on the close call - not sure why I
 didn't do it on master, but let's add it there. Database libraries are why
 that flag was added in the first place!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7109251484f189879c8a24022f0e14fa%40djangoproject.com.

Re: [Django] #21076: Offer the ability to store a hash of session IDs rather than the ID itself

2020-04-28 Thread Django

#21076: Offer the ability to store a hash of session IDs rather than the ID 
itself
--+
 Reporter:  Tim Graham|Owner:  Mark
 Type:  New feature   |   Status:  assigned
Component:  contrib.sessions  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mark):

 * needs_better_patch:  1 => 0


Comment:

 New PR: [https://github.com/django/django/pull/12814]

 Though the patch surely does still need improvement (documentation at the
 very least),
 I'm removing the 'Patch needs improvement' flag to get some feedback on
 the current implementation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.0c71a6d04d0742b62fbdaa44993fb03b%40djangoproject.com.

Re: [Django] #31520: ManifestStaticFilesStorage should not raise ValueError on missing file when manifest_strict=False

2020-04-28 Thread Django

#31520: ManifestStaticFilesStorage should not raise ValueError on missing file 
when
manifest_strict=False
---+
 Reporter:  thenewguy  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  3.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by thenewguy):

 Two things - maybe a different issue, but shouldn't we log an ERROR or at
 least WARNING that the file was missing from the manifest so that it can
 be handled?  Since we would be hashing the files on every call it isn't
 free.  TBH I think it probably makes more sense here not to hash at all
 and just return the unmodified name plus the error/warning message?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6efe465ae351e19016cae5c5e66c74ae%40djangoproject.com.

Re: [Django] #31505: Document possible email address enumeration in PasswordResetView.

2020-04-28 Thread Django

#31505: Document possible email address enumeration in PasswordResetView.
-+-
 Reporter:  Mohammad Almazroa|Owner:  felixxm
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  3.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  User Enumeration | Triage Stage:  Accepted
  Security Bug   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Florian Apolloner):

 Replying to [comment:12 Mohammad Almazroa]:
 > Question: why not fix PasswordResetView? documenting it is just not
 enough.

 Well, suggestions on fixes are welcome… Unless we want to change the reset
 view to enter the username (in which case we'd leak usernames instead), I
 do not see any obvious way on how to fix this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.57f5571ef1cb2ae2c51df1328669196d%40djangoproject.com.

Re: [Django] #31505: Document possible email address enumeration in PasswordResetView.

2020-04-28 Thread Django

#31505: Document possible email address enumeration in PasswordResetView.
-+-
 Reporter:  Mohammad Almazroa|Owner:  felixxm
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  3.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  User Enumeration | Triage Stage:  Accepted
  Security Bug   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mohammad Almazroa):

 Question: why not fix PasswordResetView? documenting it is just not
 enough.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.3d61b1077889734100f4fce350ee79c5%40djangoproject.com.

Re: [Django] #31522: FilteredSelectMultiple widget jumps to top when an option is added

2020-04-28 Thread Django

#31522: FilteredSelectMultiple widget jumps to top when an option is added
---+--
 Reporter:  Shai Berger|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+--
Changes (by Shai Berger):

 * type:  Uncategorized => Bug


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.590d04056b773ccc603130a5a09e58ef%40djangoproject.com.

Re: [Django] #20581: Support DEFERRABLE INITIALLY DEFERRED for UNIQUE constraints

2020-04-28 Thread Django

#20581: Support DEFERRABLE INITIALLY DEFERRED for UNIQUE constraints
-+-
 Reporter:  dmadeley@…   |Owner:  Ian Foote
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  db-indexes   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ian Foote):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/085.bc9d8388a1fc18a660454f563ae07bcd%40djangoproject.com.

Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-28 Thread Django

#31515: Django tries to reuse MySQL connections that have gone away with ASGI.
-+
 Reporter:  Braunson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  3.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by felixxm):

 After some investigation, I think we should close requests with
 `thread_sensitive=True` (that's an issue on master). Without this we do
 not hit connections in the main thread and `CONN_MAG_AGE=0` is not
 respected, Django reuses the same connection (from the same thread). I
 confirmed this checking `performance_schema.threads.THREAD_OS_ID`.

 With `thread_sensitve=True`, connections are closed after each request as
 expected:

 {{{
 diff --git a/django/core/handlers/asgi.py b/django/core/handlers/asgi.py
 index 82d2e1ab9d..3bc275bc44 100644
 --- a/django/core/handlers/asgi.py
 +++ b/django/core/handlers/asgi.py
 @@ -259,7 +259,7 @@ class ASGIHandler(base.BaseHandler):
  'body': chunk,
  'more_body': not last,
  })
 -await sync_to_async(response.close)()
 +await sync_to_async(response.close, thread_sensitive=True)()

  @classmethod
  def chunk_bytes(cls, data):
 }}}

 I'm not sure why it doesn't help in Django 3.0, there is probably an extra
 issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.360c7c0f018edcc5195fdb1ee1e59013%40djangoproject.com.

Re: [Django] #31515: Django tries to reuse MySQL connections that have gone away with ASGI.

2020-04-28 Thread Django

Comment (by Carlton Gibson):

OK, I can't yet pin the exact difference between stable/3.0.x and master,
but the issue looks at least partly to do with uvicorn.

I see a stable 20 connections opened. This ties in with what we saw on
#31134:

>I finally understood DB connection lifecycle and uvicorn workers. First
of all uvicorn for every worker starts 10 threads so for 2 workers there
will be 20 opened connections, for 10 workers it will be 100 connections.
>
>Django requires to have non-transactional requests to close the
connection after CONN_MAX_AGE and because when I set ATOMIC_REQUESTS to
True, Django will always leave the open connection but firstly when the
connection was open longer than CONN_MAX_AGE, Django will reestablish that
connection once again.
>[https://code.djangoproject.com/ticket/31134#comment:7 comment:7]

Running in WSGI mode, uvicorn still opens multiple DB connections, 10 it
seems — need to look at the number of workers there.

{{{
$ uvicorn --interface wsgi djangobug_repro.wsgi:application
}}}

VS the same thing with gunicorn, where we just have the single connection.

{{{
$ gunicorn djangobug_repro.wsgi:application
}}}

So **even** with WSGI uvicorn is behaving differently.

The reporter on #31134 concluded this was uvicorn's expected behaviour.
(I'd need to look at uvicorn's source code to determine that for myself.)

We need to investigate further the difference with master. We're calling
`response.close()` inside `sync_to_async` there. Adding that to
stable/3.0.x doesn't resolve this issue. We're looking at if, on master,
we need to use `tread_sensitive` there.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.fc2bcf6735f99415b14097f13c96ad1a%40djangoproject.com.

Re: [Django] #31522: FilteredSelectMultiple widget jumps to top when an option is added

2020-04-28 Thread Django

#31522: FilteredSelectMultiple widget jumps to top when an option is added
---+--
 Reporter:  Shai Berger|Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  1
---+--
Changes (by Shai Berger):

 * ui_ux:  0 => 1
 * component:  Uncategorized => contrib.admin
 * easy:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.1a5c0f67873c9f2aa785a05d3f359430%40djangoproject.com.

Re: [Django] #31522: FilteredSelectMultiple widget jumps to top when an option is added

2020-04-28 Thread Django

#31522: FilteredSelectMultiple widget jumps to top when an option is added
---+--
 Reporter:  Shai Berger|Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Shai Berger):

 * Attachment "multiselect.tgz" added.

 This project has a user "shai" with password "1" to log in to the admin in
 the included database

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.fa741ecf5462e62643d3d300cf594828%40djangoproject.com.

Re: [Django] #31521: test_parsing_rfc850 test failure on 32-bit platforms. (was: test_parsing_rfc850 fails on 32bit intel platforms)

2020-04-28 Thread Django

#31521: test_parsing_rfc850 test failure on 32-bit platforms.
--+
 Reporter:  scarabeusiv   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by felixxm):

 * component:  Testing framework => Core (Other)
 * version:  3.0 => master
 * easy:  0 => 1
 * type:  Uncategorized => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 Thanks, it's fixable (see similar ticket #30264). We can use dates from
 the previous century.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.d6935dbf9fd179fa6e60ae85ec350e7e%40djangoproject.com.

[Django] #31522: FilteredSelectMultiple widget jumps to top when an option is added

2020-04-28 Thread Django

#31522: FilteredSelectMultiple widget jumps to top when an option is added
-+
   Reporter:  Shai Berger|  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Uncategorized  |Version:  master
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 When using a FilteredSelectMultiple as a widget for a MultipleChoice
 field, typically the list of options is longer than what fits in the
 control. If the user then scrolls down, selects some options, and clicks
 the arrow to move them to the "chosen" box, then they are correctly added,
 but the "available" box scrolls to the top.

 It would be much nicer if the "available" box stayed where it was.

 At [https://www.matific.com Matific] where we encountered this, we
 monkeypatched the control's media to add a JavaScript file with this code:
 {{{
 (function($){
 if(!SelectBox)
 return;

 var oldRedisplay = SelectBox.redisplay;

 if(typeof oldRedisplay !== 'function')
 return;

 SelectBox.redisplay = function(id) {
 var top = $('#'+id).scrollTop(); //record current scroll
 var res = oldRedisplay.apply(this, arguments);
  $('#'+id).scrollTop(top); // Restore the scroll
 return res;
 };
 })(django.jQuery);
 }}}

 I'm attaching a minimal project to demonstrate it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/048.f145fed59c833017ae2a0d5358215286%40djangoproject.com.

[Django] #31521: test_parsing_rfc850 fails on 32bit intel platforms

2020-04-28 Thread Django

#31521: test_parsing_rfc850 fails on 32bit intel platforms
-+
   Reporter:  scarabeusiv|  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Testing framework  |Version:  3.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 As the test checks for date that is not supported there it simply
 overflows:
 {{{
 #!python
 [  405s] ERROR: test_parsing_rfc850
 (utils_tests.test_http.HttpDateProcessingTests) [] (rfc850str='Tuesday, 31-Dec-69 08:49:37 GMT')
 [  405s]
 --
 [  405s] Traceback (most recent call last):
 [  405s]   File "/usr/lib/python3.8/unittest/case.py", line 60, in
 testPartExecutor
 [  405s] yield
 [  405s]   File "/usr/lib/python3.8/unittest/case.py", line 582, in
 subTest
 [  405s] yield
 [  405s]   File
 "/home/abuild/rpmbuild/BUILD/Django-3.0.5/tests/utils_tests/test_http.py",
 line 340, in test_parsing_rfc850
 [  405s] self.assertEqual(datetime.utcfromtimestamp(parsed),
 expected_date)
 [  405s] OverflowError: timestamp out of range for platform time_t
 [  405s]
 [  405s]
 ==
 [  405s] ERROR: test_parsing_rfc850
 (utils_tests.test_http.HttpDateProcessingTests) [] (rfc850str='Wednesday, 31-Dec-70 08:49:37 GMT')
 [  405s]
 --
 [  405s] Traceback (most recent call last):
 [  405s]   File "/usr/lib/python3.8/unittest/case.py", line 60, in
 testPartExecutor
 [  405s] yield
 [  405s]   File "/usr/lib/python3.8/unittest/case.py", line 582, in
 subTest
 [  405s] yield
 [  405s]   File
 "/home/abuild/rpmbuild/BUILD/Django-3.0.5/tests/utils_tests/test_http.py",
 line 340, in test_parsing_rfc850
 [  405s] self.assertEqual(datetime.utcfromtimestamp(parsed),
 expected_date)
 [  405s] OverflowError: timestamp out of range for platform time_t
 [  405s]
 [  405s]
 --
 }}}

 I guess easiest is to skip those on if the platform is known to not
 support it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/054.2ff005dfd35ce9920ecf8bf305cf0e62%40djangoproject.com.

Re: [Django] #27468: Move utils.crypto.salted_hmac() from SHA1 toward SHA256

2020-04-28 Thread Django

#27468: Move utils.crypto.salted_hmac() from SHA1 toward SHA256
-+-
 Reporter:  Tim Graham   |Owner:  Claude
 Type:   |  Paroz
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by felixxm):

 Claude, are you going to work on the last point, i.e. user session auth
 hash? I would really like to close it in Django 3.1. I can prepare it if
 you're busy, just let me know. Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.047e718e40dfe3c9fae4f68b9e4d1e79%40djangoproject.com.

Re: [Django] #25712: Template overview documentation is not very approachable

2020-04-28 Thread Django

#25712: Template overview documentation is not very approachable
-+-
 Reporter:  Jacek Bzdak  |Owner:  David
 Type:   |  Smith
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * owner:  Jacek Bzdak => David Smith
 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1
 * version:  1.8 => master


Comment:

 [https://github.com/django/django/pull/12789 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.409ce82abc057b99478d30d9149e1563%40djangoproject.com.

Re: [Django] #31520: ManifestStaticFilesStorage should not raise ValueError on missing file when manifest_strict=False

2020-04-28 Thread Django

#31520: ManifestStaticFilesStorage should not raise ValueError on missing file 
when
manifest_strict=False
---+
 Reporter:  thenewguy  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  3.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Hi @thenewguy.

 I'll accept this provisionally, since it looks correct on read through —
 though I didn't yet run the test cases.

 Can you add your new tests to the PR (perhaps just as a first commit so
 it's easy to see those failing.)

 The suggested patch causes the existing tests to fail
 
`staticfiles_tests.test_storage.TestCollectionManifestStorage.test_missing_entry`,
 so can you adjust that too?

 Uncheck the flags when it's ready and I'll take a look.

 Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.80271bc479e825687f5afebbbe44a1da%40djangoproject.com.

40 matches

Mail list logo