Re: [Django] #31558: Support the use of boolean attribute on properties in the admin.

2020-05-12 Thread Django
#31558: Support the use of boolean attribute on properties in the admin.
-+-
 Reporter:  Alexandre Poitevin   |Owner:  Alexandre
 |  Poitevin
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Alexandre Poitevin):

 So I do really think I’ve tracked down the reason why it works with
 `short_description` and `admin_order_field`, but not with `boolean`.

 I don’t know if this is the good place to make some kind of code review
 (maybe in the dev mailist?), but anyway as a reference (at least for me):


 For `short_description`, the code is in
 `contrib.admin.utils.label_for_fields()`:

 {{{
 if hasattr(attr, "short_description"):
 label = attr.short_description
 elif (isinstance(attr, property) and
   hasattr(attr, "fget") and
   hasattr(attr.fget, "short_description")):
 label = attr.fget.short_description
 elif callable(attr):
 if attr.__name__ == "":
 label = "--"
 else:
 label = pretty_name(attr.__name__)
 else:
 label = pretty_name(name)
 }}}

 The `property` case is properly handled.

 For `admin_order_field`, it’s in
 `contrib.admin.views.main.get_ordering_fields()`:

 {{{
 if callable(field_name):
 attr = field_name
 elif hasattr(self.model_admin, field_name):
 attr = getattr(self.model_admin, field_name)
 else:
 attr = getattr(self.model, field_name)
 if isinstance(attr, property) and hasattr(attr, 'fget'):
 attr = attr.fget
 return getattr(attr, 'admin_order_field', None)
 }}}

 Same thing.

 But for `boolean`, it’s in
 `contrib.admin.templatetags.admin_list.items_for_result()`:

 {{{
 boolean = getattr(attr, 'boolean', False)
 result_repr = display_for_value(value,
 empty_value_display, boolean)
 }}}

 No special handling for properties…

 And `items_for_result()` has no test to begin with.

 The implementation of the feature seems easy, but I’m not sure about how
 to write a good test for that.
 I also think that the retrieving of these models’ fields “metadata” should
 be refactored to appear in one_place only.

 There is already a `lookup_field()` in `contrib.admin.utils` but it seems
 it’s not enough for `property` (and again no unit tests):

 {{{
 def lookup_field(name, obj, model_admin=None):
 opts = obj._meta
 try:
 f = _get_non_gfk_field(opts, name)
 except (FieldDoesNotExist, FieldIsAForeignKeyColumnName):
 # For non-field values, the value is either a method, property or
 # returned via a callable.
 if callable(name):
 attr = name
 value = attr(obj)
 elif hasattr(model_admin, name) and name != '__str__':
 attr = getattr(model_admin, name)
 value = attr(obj)
 else:
 attr = getattr(obj, name)
 if callable(attr):
 value = attr()
 else:
 value = attr
 f = None
 else:
 attr = None
 value = getattr(obj, name)
 return f, attr, value
 }}}

 I think (lots of “I think”) that I need to write tests for this before
 anything else.
 I just need some orientations in order to take care of this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.2b6d4fd20d34bb4886aa674f6671e507%40djangoproject.com.


Re: [Django] #31575: Document admin's requirement on django.template.context_processors.request context processor.

2020-05-12 Thread Django
#31575: Document admin's requirement on 
django.template.context_processors.request
context processor.
-+--
 Reporter:  Jon Dufresne |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by Jon Dufresne):

 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/12906

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.50cf8478e083e5d884d8a8a906b94cf0%40djangoproject.com.


[Django] #31575: Document admin's requirement on django.template.context_processors.request context processor.

2020-05-12 Thread Django
#31575: Document admin's requirement on 
django.template.context_processors.request
context processor.
---+
   Reporter:  Jon Dufresne |  Owner:  nobody
   Type:  Bug  | Status:  new
  Component:  contrib.admin|Version:  master
   Severity:  Release blocker  |   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+
 Since commit d24ba1be7a53a113d19e2860c03aff9922efec24, the admin templates
 use the implied `request` variable normally added by
 `django.template.context_processors.request`.

 As Django templates silence errors, this went unnoticed during testing,
 and won't immediately break the templates, but certain expected rendering
 features won't work.

 Django should document this change:

 - In the release notes (provide a deprecation period where it is a warning
 only)
 - In the admin docs
 - In the system check framework as a warning (but eventually an error)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.a9462097f02ec9c71327244c578d0276%40djangoproject.com.


Re: [Django] #31573: Support update().order_by() on MySQL.

2020-05-12 Thread Django
#31573: Support update().order_by() on MySQL.
-+-
 Reporter:  Gerben Morsink   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  update mysql order   | Triage Stage:  Accepted
  order_by   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette):

 For anyone interested in implementing this feature you'll have to override
 the `as_sql` and `pre_sql_setup` method of
 `django.db.models.sql.compiler.SQLUpdateCompiler` in
 `django.db.backends.mysql.compiler.SQLUpdateCompiler` to
 
[https://github.com/django/django/blob/d51e090db2110f016dbca1d794c0d379b3df551b/django/db/models/sql/compiler.py#L1535
 avoid clearing the ordering] and append the `ORDER BY` clause to
 `super().as_sql()[0]`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c2502ea602018abb9e08d04cea567746%40djangoproject.com.


Re: [Django] #31573: Support update().order_by() on MySQL. (was: QuerySet.update().order_by() not working as expected on MySQL)

2020-05-12 Thread Django
#31573: Support update().order_by() on MySQL.
-+-
 Reporter:  Gerben Morsink   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  update mysql order   | Triage Stage:  Accepted
  order_by   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * keywords:  queryset update => update mysql order order_by
 * type:  Bug => New feature
 * version:  2.2 => master
 * stage:  Unreviewed => Accepted


Comment:

 MySQL seems to be only supported engine to allow `UPDATE ... ORDER BY` so
 it doesn't seem to be standard.

 - https://www.postgresql.org/docs/current/sql-update.html
 - https://www.sqlite.org/draft/lang_update.html
 -
 https://docs.oracle.com/cd/B19306_01/appdev.102/b14261/update_statement.htm

 Since it's the documented way of dealing with the lack of deferrable
 unique constraint on MySQL I guess we could add support for it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.489066ea3e33a1c0eef921a3012967ff%40djangoproject.com.


Re: [Django] #31574: BUG: EmailMessage cannot mix tuples and lists as arguments

2020-05-12 Thread Django
#31574: BUG: EmailMessage cannot mix tuples and lists as arguments
-+--
 Reporter:  Dehorser |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Mail)  |  Version:  3.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+--
Description changed by Dehorser:

Old description:

> `EmailMessage` has fields `to`, `cc`, and `bcc` can be either tuples or
> lists. However, mixing tuples and lists errors at this method:
>
> {{{
> def recipients(self):
> return [email for email in (self.to + self.cc + self.bcc) if email]
> }}}
>
> Lists and tuples can't be added together.

New description:

 `EmailMessage` has fields `to`, `cc`, and `bcc` that can be either tuples
 or lists. However, mixing tuples and lists errors at this method:

 {{{
 def recipients(self):
 return [email for email in (self.to + self.cc + self.bcc) if email]
 }}}

 Lists and tuples can't be added together.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.72cbdc2c37fb6db68b317454d2e3c176%40djangoproject.com.


[Django] #31574: BUG: EmailMessage cannot mix tuples and lists as arguments

2020-05-12 Thread Django
#31574: BUG: EmailMessage cannot mix tuples and lists as arguments
---+
   Reporter:  Dehorser |  Owner:  nobody
   Type:  Bug  | Status:  new
  Component:  Core (Mail)  |Version:  3.0
   Severity:  Normal   |   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  1
  UI/UX:  0|
---+
 `EmailMessage` has fields `to`, `cc`, and `bcc` can be either tuples or
 lists. However, mixing tuples and lists errors at this method:

 {{{
 def recipients(self):
 return [email for email in (self.to + self.cc + self.bcc) if email]
 }}}

 Lists and tuples can't be added together.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.57c50553c18f94e3e50f89230f59d6e3%40djangoproject.com.


[Django] #31573: QuerySet.update().order_by() not working as expected on MySQL

2020-05-12 Thread Django
#31573: QuerySet.update().order_by() not working as expected on MySQL
-+-
   Reporter:  Gerben |  Owner:  nobody
  Morsink|
   Type:  Bug| Status:  new
  Component:  Database   |Version:  2.2
  layer (models, ORM)|
   Severity:  Normal |   Keywords:  queryset update
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 When a UniqueConstraint is used on an IntegerField and we want to update
 multiple rows of that field at once, we need to make sure we select the
 right order before the update, since MySQL does not support a deferred
 update (see: https://dev.mysql.com/doc/refman/5.7/en/update.html).

 I expected simply doing:

 qs.order_by('-integerfield').update(integerfield=F('integerfield')+1)
 would work, but it seems the Django ORM strips the order_by from the query
 before execution, it gives a django.db.utils.IntegrityError: (1062,
 "Duplicate entry '' for key 'integerfield'").

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.b05b8553486270e2bce96a4c2421ea08%40djangoproject.com.


Re: [Django] #31358: Increase default password salt size in BasePasswordHasher.

2020-05-12 Thread Django
#31358: Increase default password salt size in BasePasswordHasher.
--+
 Reporter:  Jon Moroney   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Utilities |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Jon Moroney):

 Any updates?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.48f1304668da16e6702599d65c4487b3%40djangoproject.com.


[Django] #31572: db luh ;

2020-05-12 Thread Django
#31572: db luh ;
-+
   Reporter:  abc|  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Uncategorized  |Version:  3.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 e glklg

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/046.05c2b35e291af1e187cb99c040e02abf%40djangoproject.com.


Re: [Django] #31570: Translations of one language in different territories can override each other

2020-05-12 Thread Django
#31570: Translations of one language in different territories can override each
other
-+-
 Reporter:  Shai Berger  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  2.2
  Internationalization   |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Shai Berger):

 The {{{else:}}} comes into play when the {{{TranslationCatalog}}} is still
 empty.

 And thanks for your own patience for all my hand-waving with no failing-
 test code to back it up yet...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.b354ea4f455dab50de2e78896b8e92a4%40djangoproject.com.


Re: [Django] #31570: Translations of one language in different territories can override each other

2020-05-12 Thread Django
#31570: Translations of one language in different territories can override each
other
-+-
 Reporter:  Shai Berger  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  2.2
  Internationalization   |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 > When the stars align "correctly", it is loaded in such a way that cat in
 cat.update in line 96 is the en catalog, and it is updated with the NZ
 translations when those are loaded, and then with the ZA translations when
 those are loaded. It is the same (is) dict that is then used for all three
 languages.

 OK, it's that bit I haven't pinned down as yet. A reproduce project would
 be super if you can. Otherwise I'll try again tomorrow.

 (I'm not/wasn't seeing how the `copy()` in the else branch on ln99 comes
 into play if the plurals compare equal...)

 Thanks for your patience with me. :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.9ab234c223b27dfb028a5d79db1d55c7%40djangoproject.com.


Re: [Django] #31570: Translations of one language in different territories can override each other

2020-05-12 Thread Django
#31570: Translations of one language in different territories can override each
other
-+-
 Reporter:  Shai Berger  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  2.2
  Internationalization   |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Shai Berger):

 The whole {{{TranslationCatalog}}} class is new in the fix for #30439.

 The issue is not about mis-comparing plural forms at all. The issue is
 incorrect handling, in that code, of the "base language" ({{{en}}})
 catalog. All the {{{en}}} variants have the same plural forms, of course,
 and they do compare equal. But the code fails to account for the fact that
 the {{{en}}} catalog is loaded for {{{en-NZ}}}. When the stars align
 "correctly", it is loaded in such a way that {{{cat}}} in {{{cat.update}}}
 in line 96 is the {{{en}}} catalog, and it is updated with the {{{NZ}}}
 translations when those are loaded, and then with the {{{ZA}}}
 translations when those are loaded. It is the same ({{{is}}}) dict that is
 then used for all three languages.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.a57c0a89da577c0c3fbca07c50d35221%40djangoproject.com.


Re: [Django] #10305: Add a form instantiation hook for contrib.admin add/change views

2020-05-12 Thread Django
#10305: Add a form instantiation hook for contrib.admin add/change views
-+-
 Reporter:  tangc|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  add_view,| Triage Stage:  Accepted
  change_view, ModelForm |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Romaric Pascal):

 I've ran into the exact same need and thought it'd be great if ModelAdmin
 had that `instanciate_form` hook.

 How does the following sound: The calls to `ModelForm(...)` inside
 
[https://github.com/django/django/blob/0668164b4ac93a5be79f5b87fae83c657124d9ab/django/contrib/admin/options.py#L1536
 _changeform_view] could be replaced by `self.get_form_instance(ModelForm,
 request, obj,...)` which would pass any arguments to the ModelForm, but
 allow developers to intercept the call and maybe set initial values of
 their own based on the request or the current object.

 Actually the `get_form_instance` default implementation could also be
 responsible for calling the `get_form` so that the signature doesn't
 require the form class to be passed (but that might be too many
 responsibilities for it and make things confusing).

 Would be happy to contribute the change if that was fitting :D

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.26c0da8d3a812e9a56444694a57d53ee%40djangoproject.com.


Re: [Django] #31570: Translations of one language in different territories can override each other

2020-05-12 Thread Django
#31570: Translations of one language in different territories can override each
other
-+-
 Reporter:  Shai Berger  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  2.2
  Internationalization   |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 Hey Shai. Thanks for the clarification.

 I was assuming that `en-NZ` and `en-ZA` have the same number of plural
 forms? (Is that correct?)

 If so, we shouldn't end up in the branch where your suggested/possible
 edit is. i.e. the catalogs should be merged as they were in the past...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.4dde0f8bf0a6b1c5fc83750883421aff%40djangoproject.com.


Re: [Django] #31570: Translations of one language in different territories can override each other

2020-05-12 Thread Django
#31570: Translations of one language in different territories can override each
other
-+-
 Reporter:  Shai Berger  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  2.2
  Internationalization   |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Shai Berger):

 I see that the problem description wasn't clear enough:

 We are working on a website for the K-6 range of schools and students. The
 "K" year (for "Kindergarten") is called "Year 1" in New Zealand, but
 "Grade R" in South Africa, and some Kiwis were pretty confused when they
 saw "Grade R" on the site.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.dc8ac2a8be071afad5aa430a48a1c62e%40djangoproject.com.


Re: [Django] #30503: ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host.

2020-05-12 Thread Django
#30503: ConnectionResetError: [WinError 10054] An existing connection was 
forcibly
closed by the remote host.
-+-
 Reporter:  Rajkumar Srinivasan  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:  invalid
 Keywords:  paytm payments   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 Is this not just the browser shutting the connection, after some time
 perhaps? (What’s the keep-alive timeout?)

 I see this kind of thing on macOS all the time:


 {{{
 [12/May/2020 10:29:46] "GET /admin/jsi18n/ HTTP/1.1" 200 5739
 [12/May/2020 10:29:46] "GET /static/admin/css/widgets.css HTTP/1.1" 200
 4096
 
 Exception happened during processing of request from ('127.0.0.1', 56275)
 Traceback (most recent call last):
   File
 "/Users/carlton/.pyenv/versions/3.6.0/lib/python3.6/socketserver.py", line
 639, in process_request_thread
 self.finish_request(request, client_address)
   File
 "/Users/carlton/.pyenv/versions/3.6.0/lib/python3.6/socketserver.py", line
 361, in finish_request
 self.RequestHandlerClass(request, client_address, self)
   File
 "/Users/carlton/.pyenv/versions/3.6.0/lib/python3.6/socketserver.py", line
 696, in __init__
 self.handle()
   File "/Users/carlton/Documents/Django-
 Stack/django/django/core/servers/basehttp.py", line 174, in handle
 self.handle_one_request()
   File "/Users/carlton/Documents/Django-
 Stack/django/django/core/servers/basehttp.py", line 182, in
 handle_one_request
 self.raw_requestline = self.rfile.readline(65537)
   File "/Users/carlton/.pyenv/versions/3.6.0/lib/python3.6/socket.py",
 line 586, in readinto
 return self._sock.recv_into(b)
 ConnectionResetError: [Errno 54] Connection reset by peer
 
 [12/May/2020 10:29:46] "GET /favicon.ico HTTP/1.1" 404 1972
 
 Exception happened during processing of request from ('127.0.0.1', 56276)
 Traceback (most recent call last):
   File
 "/Users/carlton/.pyenv/versions/3.6.0/lib/python3.6/socketserver.py", line
 639, in process_request_thread
 self.finish_request(request, client_address)
   File
 "/Users/carlton/.pyenv/versions/3.6.0/lib/python3.6/socketserver.py", line
 361, in finish_request
 self.RequestHandlerClass(request, client_address, self)
   File
 "/Users/carlton/.pyenv/versions/3.6.0/lib/python3.6/socketserver.py", line
 696, in __init__
 self.handle()
   File "/Users/carlton/Documents/Django-
 Stack/django/django/core/servers/basehttp.py", line 174, in handle
 self.handle_one_request()
   File "/Users/carlton/Documents/Django-
 Stack/django/django/core/servers/basehttp.py", line 182, in
 handle_one_request
 self.raw_requestline = self.rfile.readline(65537)
   File "/Users/carlton/.pyenv/versions/3.6.0/lib/python3.6/socket.py",
 line 586, in readinto
 return self._sock.recv_into(b)
 ConnectionResetError: [Errno 54] Connection reset by peer
 }}}

 It’s expected behaviour.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.d92df4fdf040996b25d4a8d724c6258d%40djangoproject.com.


Re: [Django] #31564: Django fails to return HttpResponse message on early response with large uploads. (was: Django fails to return HttpResponse message on early response with large uploads)

2020-05-12 Thread Django
#31564: Django fails to return HttpResponse message on early response with large
uploads.
-+-
 Reporter:  Jacob Crabtree   |Owner:  nobody
 Type:  Uncategorized|   Status:  closed
Component:  File |  Version:  3.0
  uploads/storage|
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:  Memory Error, Large  | Triage Stage:
  File Upload, HTTP 414  |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Thanks for this ticket, however I cannot reproduce this behavior on linux,
 it's probably some Windows issue that is not related to Django. You can
 try to use one of
 [https://code.djangoproject.com/wiki/TicketClosingReasons/UseSupportChannels
 support channels].

 Duplicate of #30503.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.65f13f183208520ded9a506d25777880%40djangoproject.com.


Re: [Django] #31570: Translations of one language in different territories can override each other

2020-05-12 Thread Django
#31570: Translations of one language in different territories can override each
other
-+-
 Reporter:  Shai Berger  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:   |  Version:  2.2
  Internationalization   |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 Hey Shai. Thanks for the report. 樂


 > In the case we've run into, users in New Zealand (en-NZ) received
 translations for South Africa (en-ZA).
 > ...
 > I will try to come up with a test later.

 Yes, please. I'm struggling to see where the issue is.

 I'm wondering if
 
[https://github.com/claudep/django/blob/6b840e55a29791529cb08faa8836fa4f6168642b/django/utils/translation/trans_real.py#L92-L97
 the test for the equivalence of the plural forms] is robust enough:

 {{{
 def update(self, trans):
 # Merge if plural function is the same, else prepend.
 for cat, plural in zip(self._catalogs, self._plurals):
 if trans.plural.__code__ == plural.__code__:
 cat.update(trans._catalog)
 break
else:
...
 }}}

 Q: What guarantees that the `__code__` object of the
 
[https://github.com/python/cpython/blob/a63c61168588937c482435d0432c753de4844c46/Lib/gettext.py#L176
 generated plural functions] evaluates equal or not? (Current status: no
 idea: it's not as simple as pointer address, but I can't yet find the
 implementation so... )

 There are a number of cases in the existing tests where we enter the
 different plural forms `else`-block, beyond the test added for #30439, so
 maybe there is a subtle behaviour change here. I'd be very grateful for
 that test to be able to pin it down.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.30be24d225f88276a421a41e9701637b%40djangoproject.com.


Re: [Django] #31563: Document edge case with uwsgi, wsgi.file_wrapper and BytesIO. (was: Document edge case with uwsgi, wsgi.file_wrapper and BytesIO)

2020-05-12 Thread Django
#31563: Document edge case with uwsgi, wsgi.file_wrapper and BytesIO.
-+-
 Reporter:  Sergei Maertens  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  3.0
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  wsgi.file_wrapper,   | Triage Stage:
  uwsgi, streaming responses |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 It's too niche IMO. We cannot document all caveats.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.f1d033ed4ee99fded0864b0fe4f4c241%40djangoproject.com.


Re: [Django] #30678: Confirm support for GDAL 3.0.

2020-05-12 Thread Django
#30678: Confirm support for GDAL 3.0.
-+-
 Reporter:  Yury Ryabov  |Owner:  Claude
 Type:   |  Paroz
  Cleanup/optimization   |   Status:  closed
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  GDAL, GIS| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"91e287cce0561b647e7b7fb96dd415567512f279" 91e287cc]:
 {{{
 #!CommitTicketReference repository=""
 revision="91e287cce0561b647e7b7fb96dd415567512f279"
 Refs #30678 -- Added support for GDAL 3.1.

 OSRSetAxisMappingStrategy() really returns void, so no errcheck is
 needed. Previously set errcheck was raising positive false exceptions
 on GDAL 3.1.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.361b73b3804460fa3eef97d4e850bb36%40djangoproject.com.


Re: [Django] #31571: Explain how to transform a geometry with GDAL 3 authority axis strategy. (was: Explain how to transform a geometry with GDAL 3 authority axis strategy)

2020-05-12 Thread Django
#31571: Explain how to transform a geometry with GDAL 3 authority axis strategy.
--+
 Reporter:  Claude Paroz  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by felixxm):

 * component:  GIS => Documentation
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6e1e13f250f9b36a431a7fea53c7e0a6%40djangoproject.com.


[Django] #31571: Explain how to transform a geometry with GDAL 3 authority axis strategy

2020-05-12 Thread Django
#31571: Explain how to transform a geometry with GDAL 3 authority axis strategy
+
   Reporter:  Claude Paroz  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  GIS   |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 GDAL 3 support was added in #30678. It was a bit of a rush to allow it to
 be part of Django 3.1. Now I suggest to complement that with some
 documentation explaining the axis interpretation differences with GDAL 3
 and how to transform a geometry using a SRS honoring the authority axis
 ordering.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.2b594d2e6828efbd3f8d530666dacf57%40djangoproject.com.


Re: [Django] #30678: Confirm support for GDAL 3.0.

2020-05-12 Thread Django
#30678: Confirm support for GDAL 3.0.
-+-
 Reporter:  Yury Ryabov  |Owner:  Claude
 Type:   |  Paroz
  Cleanup/optimization   |   Status:  closed
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  GDAL, GIS| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"58f1b07e49a98bb391c9e38b91f078ab2c302703" 58f1b07e]:
 {{{
 #!CommitTicketReference repository=""
 revision="58f1b07e49a98bb391c9e38b91f078ab2c302703"
 Fixed #30678 -- Added support for GDAL 3.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.9a075c03c34420c9962de15ed75f16c8%40djangoproject.com.


Re: [Django] #31569: Add support for GEOS 3.8.

2020-05-12 Thread Django
#31569: Add support for GEOS 3.8.
--+
 Reporter:  felixxm   |Owner:  felixxm
 Type:  Cleanup/optimization  |   Status:  closed
Component:  GIS   |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"17ea7cc9734a9849166d6c33bdbc38bfdd54" 17ea7cc9]:
 {{{
 #!CommitTicketReference repository=""
 revision="17ea7cc9734a9849166d6c33bdbc38bfdd54"
 Fixed #31569 -- Confirmed support for GEOS 3.8.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.46ba9b9e1ecbe9a4b55bea34750b22cd%40djangoproject.com.


Re: [Django] #31568: Alias used in aggregate filtering is incorrect.

2020-05-12 Thread Django
#31568: Alias used in aggregate filtering is incorrect.
-+-
 Reporter:  Gagaro   |Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Gagaro):

 Replying to [comment:1 Simon Charette]:
 > Thank you for your report. Did you manage to reproduce against Django
 3.0.5 as well? If it's the case could you try reducing your model set and
 queryset interactions to a minimal that still trigger the issue. That'll
 help tremendously in reproducing the regression and ensure it gets
 addressed in a timely manner. Thanks!

 I tried to reduce it as much as I could in my context without having to
 try with whole new models. Do you still need me to do that as felixxm
 apparently was able to reproduce it?

 Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.75bbfdef5a286789aae8d03a69b20e69%40djangoproject.com.


Re: [Django] #31566: Subquery in annotation is included by its alias and is not present in the SELECT

2020-05-12 Thread Django
#31566: Subquery in annotation is included by its alias and is not present in 
the
SELECT
-+-
 Reporter:  Gagaro   |Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Gagaro):

 I had tested it on 3.0.6 and stable/3.0.x branch. I didn't try it with two
 `annotate` but felixxm just did.

 Thanks for taking care of it so quickly.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c615c31c20ca9a87ffaa359fe537ba06%40djangoproject.com.


Re: [Django] #30678: Confirm support for GDAL 3.0.

2020-05-12 Thread Django
#30678: Confirm support for GDAL 3.0.
-+-
 Reporter:  Yury Ryabov  |Owner:  Claude
 Type:   |  Paroz
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  GDAL, GIS| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.3f9ab0c2a48c042e5fdb1082afdc74b6%40djangoproject.com.


Re: [Django] #31569: Add support for GEOS 3.8.

2020-05-12 Thread Django
#31569: Add support for GEOS 3.8.
--+
 Reporter:  felixxm   |Owner:  felixxm
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  GIS   |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by felixxm):

 * owner:  (none) => felixxm
 * status:  new => assigned
 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/12878 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9871ba4602364eca4ecd653ad9a13190%40djangoproject.com.


Re: [Django] #31569: Add support for GEOS 3.8.

2020-05-12 Thread Django
#31569: Add support for GEOS 3.8.
--+
 Reporter:  felixxm   |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  GIS   |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Description changed by felixxm:

Old description:

> Two tests fail with GEOS 3.8.1:
> {{{
> ==
> FAIL: test_diff_intersection_union
> (gis_tests.geoapp.test_functions.GISFunctionsTests)
> --
> Traceback (most recent call last):
>   File "/usr/lib/python3.6/unittest/case.py", line 59, in
> testPartExecutor
> yield
>   File "/usr/lib/python3.6/unittest/case.py", line 605, in run
> testMethod()
>   File "/repo/django/django/test/testcases.py", line 1215, in
> skip_wrapper
> return test_func(*args, **kwargs)
>   File "/repo/django/tests/gis_tests/geoapp/test_functions.py", line 569,
> in test_diff_intersection_union
> self.assertEqual(c.mpoly.intersection(geom), c.intersection)
>   File "/usr/lib/python3.6/unittest/case.py", line 829, in assertEqual
> assertion_func(first, second, msg=msg)
>   File "/usr/lib/python3.6/unittest/case.py", line 822, in
> _baseAssertEqual
> raise self.failureException(msg)
> AssertionError:  !=  object at 0x7f614c61e098>
>
> ==
> FAIL: test_intersection
> (gis_tests.geoapp.test_functions.GISFunctionsTests)
> --
> Traceback (most recent call last):
>   File "/usr/lib/python3.6/unittest/case.py", line 59, in
> testPartExecutor
> yield
>   File "/usr/lib/python3.6/unittest/case.py", line 605, in run
> testMethod()
>   File "/repo/django/django/test/testcases.py", line 1215, in
> skip_wrapper
> return test_func(*args, **kwargs)
>   File "/repo/django/tests/gis_tests/geoapp/test_functions.py", line 299,
> in test_intersection
> self.assertEqual(c.inter, expected)
>   File "/usr/lib/python3.6/unittest/case.py", line 829, in assertEqual
> assertion_func(first, second, msg=msg)
>   File "/usr/lib/python3.6/unittest/case.py", line 822, in
> _baseAssertEqual
> raise self.failureException(msg)
> AssertionError:  !=  object at 0x7f614c61e560>
> }}}

New description:

 ~~Two tests fail with GEOS 3.8.1:~~ Edit: My mistake I checked with wrong
 version.
 {{{
 ==
 FAIL: test_diff_intersection_union
 (gis_tests.geoapp.test_functions.GISFunctionsTests)
 --
 Traceback (most recent call last):
   File "/usr/lib/python3.6/unittest/case.py", line 59, in testPartExecutor
 yield
   File "/usr/lib/python3.6/unittest/case.py", line 605, in run
 testMethod()
   File "/repo/django/django/test/testcases.py", line 1215, in skip_wrapper
 return test_func(*args, **kwargs)
   File "/repo/django/tests/gis_tests/geoapp/test_functions.py", line 569,
 in test_diff_intersection_union
 self.assertEqual(c.mpoly.intersection(geom), c.intersection)
   File "/usr/lib/python3.6/unittest/case.py", line 829, in assertEqual
 assertion_func(first, second, msg=msg)
   File "/usr/lib/python3.6/unittest/case.py", line 822, in
 _baseAssertEqual
 raise self.failureException(msg)
 AssertionError:  != 

 ==
 FAIL: test_intersection
 (gis_tests.geoapp.test_functions.GISFunctionsTests)
 --
 Traceback (most recent call last):
   File "/usr/lib/python3.6/unittest/case.py", line 59, in testPartExecutor
 yield
   File "/usr/lib/python3.6/unittest/case.py", line 605, in run
 testMethod()
   File "/repo/django/django/test/testcases.py", line 1215, in skip_wrapper
 return test_func(*args, **kwargs)
   File "/repo/django/tests/gis_tests/geoapp/test_functions.py", line 299,
 in test_intersection
 self.assertEqual(c.inter, expected)
   File "/usr/lib/python3.6/unittest/case.py", line 829, in assertEqual
 assertion_func(first, second, msg=msg)
   File "/usr/lib/python3.6/unittest/case.py", line 822, in
 _baseAssertEqual
 raise self.failureException(msg)
 AssertionError:  != 
 }}}

--

-- 
Ticket URL: 
Django 

Re: [Django] #31568: Alias used in aggregate filtering is incorrect. (was: Alias used in aggregate filtering is incorrect)

2020-05-12 Thread Django
#31568: Alias used in aggregate filtering is incorrect.
-+-
 Reporter:  Gagaro   |Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for this ticket.

 Regression in 691def10a0197d83d2d108bd9043b0916d0f09b4.
 Reproduced at 46fe506445666d8097945f0c1e8be11cfd644b28.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b3860a7de7e7217cd9747a22b69ba615%40djangoproject.com.