Re: [Django] #31550: AssertionError raised by test_file_response method of ASGITest class.

[Django]

#31550: AssertionError raised by test_file_response method of ASGITest class.
-+-
 Reporter:  Yash Saini   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  HTTP handling|  Version:  3.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  ASGI tests   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => needsinfo


Comment:

 Hi Addison. This works for me. #32041 came up recently, which is related.

 If you can dig-in and come up with some more information we can look into
 it but short of a concrete analysis I'm not sure what we can do. What
 action are we to take? (The line in the tests is as it is because this was
 the behaviour we hit developing the feature…)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.fe9938c33060420de56abd1f735ac76f%40djangoproject.com.

Re: [Django] #32054: Signal disconnect not working with multiple decorators

[Django]

#32054: Signal disconnect not working with multiple decorators
-+-
 Reporter:  Ron  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  signals  | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Ron:

Old description:

> Here's my setup:
>

>
> {{{
> class MyModel(models.Model):
>  pass
>
> @receiver(post_save, sender=MyModel)
> @receiver(post_delete, sender=MyModel)
> def process_stuff(sender, instance, **kwargs):
> # to some magic
> pass
> }}}
>
> When I want to disconnect the post_save signal like this:
>
> {{{
> from django.db.models import signals
> signals.post_save.disconnect(
> receiver=process_stuff,
> sender=MyModel,
> }}}
>
> ... it does not work.
>
> If I comment out the second decorator with `post_delete`, it works.
>
> If I split this up and use two different functions, it works as well.
>
> I posted at StackOverflow (https://stackoverflow.com/q/64102708/1331671)
> and in some django groups, but no replies yet.
>
> Seems like a bug to me :(

New description:

 Here's my setup on django 3.0.10:


 {{{
 class MyModel(models.Model):
  pass

 @receiver(post_save, sender=MyModel)
 @receiver(post_delete, sender=MyModel)
 def process_stuff(sender, instance, **kwargs):
 # to some magic
 pass
 }}}

 When I want to disconnect the post_save signal like this:

 {{{
 from django.db.models import signals
 signals.post_save.disconnect(
 receiver=process_stuff,
 sender=MyModel,
 }}}

 ... it does not work.

 If I comment out the second decorator with `post_delete`, it works.

 If I split this up and use two different functions, it works as well.

 I posted at StackOverflow (https://stackoverflow.com/q/64102708/1331671)
 and in some django groups, but no replies yet.

 Seems like a bug to me :(

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.577394246be4744696eb363fee6e8b35%40djangoproject.com.

Re: [Django] #18995: String formatting error when passing floats as values in {% blocktrans %} tags

[Django]

#18995: String formatting error when passing floats as values in {% blocktrans 
%}
tags
-+-
 Reporter:  Bruno Renié  |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  closed
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"01a7af09b9d61aa66f5bf345fc32cc8f90ecb62a" 01a7af09]:
 {{{
 #!CommitTicketReference repository=""
 revision="01a7af09b9d61aa66f5bf345fc32cc8f90ecb62a"
 Fixed #18995 -- Made blocktranslate tag raise TemplateSyntaxError when
 plural count is not a number.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.d5b46056ed39f4e69858ca80b0e44792%40djangoproject.com.

Re: [Django] #18995: String formatting error when passing floats as values in {% blocktrans %} tags

[Django]

#18995: String formatting error when passing floats as values in {% blocktrans 
%}
tags
-+-
 Reporter:  Bruno Renié  |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.179b1612349a7447517d6f932df1d6fc%40djangoproject.com.

Re: [Django] #32045: Document that GenericRelation.remove()/clear() delete objects. (was: Removing item from GenericRelation deletes all items.)

[Django]

#32045: Document that GenericRelation.remove()/clear() delete objects.
-+-
 Reporter:  chgad|Owner:  Asjad
 Type:   |  Ahmed Khan
  Cleanup/optimization   |   Status:  new
Component:  Documentation|  Version:  3.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  closed => new
 * type:  Bug => Cleanup/optimization
 * component:  contrib.contenttypes => Documentation
 * version:  3.0 => 3.1
 * easy:  0 => 1
 * resolution:  needsinfo =>
 * stage:  Unreviewed => Accepted


Comment:

 `clear()` and `remove()` for `GenericRelation`s delete objects, this is
 how it works since its introduction in
 bca5327b21eb2e3ee18292cbe532d6d0071201d8 (it's mentioned in some comments
 [https://code.djangoproject.com/ticket/21174#comment:4 21174#comment:4],
 [https://code.djangoproject.com/ticket/21174#comment:6 21174#comment:6]
 and [https://docs.djangoproject.com/en/3.1/releases/1.7/#remove-and-clear-
 methods-of-related-managers Django 1.7 release notes]).

 I think we can add a note about this behavior of `clear()` and `remove()`
 to the [https://docs.djangoproject.com/en/3.1/ref/contrib/contenttypes
 /#reverse-generic-relations Reverse generic relations docs].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.241108eb3a24a7d4f783cc040b282ee5%40djangoproject.com.

Re: [Django] #32053: Accessibility issues with Congrats page for new projects

[Django]

#32053: Accessibility issues with Congrats page for new projects
---+--
 Reporter:  Thibaud Colas  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Core (Other)   |  Version:  3.1
 Severity:  Normal |   Resolution:
 Keywords:  accessibility, ui  | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Description changed by Thibaud Colas:

Old description:

> Similarly to [https://code.djangoproject.com/ticket/31617 #31617] about
> accessibility of the Django admin, there are a lot of small fixes /
> improvements that should be done to the accessibility of the "The install
> worked successfully! Congratulations!" page for new projects.
>
> I’ve audited it with a suite of tools and screen readers, with
> requirements from WCAG 2.1 AA in mind:
>
> - The V.Nu HTML validator
> - Axe v3 (via Accessibility Insights)
> - VoiceOver in Safari 13 on macOS 10.14
> - VoiceOver in Safari 14 on iOS 14
> - Manual keyboard testing in latest Chrome, Firefox, Safari on macOS
> 10.14
>
> Here is the list of issues I identified:
>
> -   Missing a `lang` attribute, so screen reader users would potentially
> have the page announced in the wrong language.
> -   It would be better for the page title to directly state what the page
> is about, and match the main heading.
> -   There shouldn’t be an `h2` used for the Django docs link – this isn’t
> a section of the page.
> -   The links in text are only distinguished by their color – this is
> problematic for colorblind users, who might not realize there are links.
> -   The main rocket launch visual should be hidden for screen reader
> users
> -   The animation should respect `@media (prefers-reduced-motion:
> reduce)` ([https://code.djangoproject.com/ticket/32051 #32051])
> -   The main heading should be a `h1` (the page has no h1 currently)
> -   The main paragraph text needs to pass color contrast checks
> -   SVG icons should be hidden for screen reader users.
> -   SVG icons in links should be set to `focusable="false"` for screen
> reader users in IE11
> -   (It would be nice for all text on the page to pass AAA contrast
> requirements, considering it’s such a simple page. Currently, the
> footer’s p tags only pass AA).
> -   For some reason the footer links don’t have a focus outline for me in
> Firefox & Safari
> -   Footer links shouldn’t be using h4 headings
> -   Text font size and line heights shouldn’t be defined in pixels, so
> users can resize text if desired
>
> I also made a recording of the VoiceOver testing for future reference:
> https://youtu.be/XB0Ft8tLMFg

New description:

 Similarly to [https://code.djangoproject.com/ticket/31617 #31617] about
 accessibility of the Django admin, there are a lot of small fixes /
 improvements that should be done to the accessibility of the "The install
 worked successfully! Congratulations!" page for new projects.

 I’ve audited it with a suite of tools and screen readers, with
 requirements from WCAG 2.1 AA in mind:

 - The V.Nu HTML validator
 - Axe 3.5 (via Accessibility Insights)
 - Color blind variant via Accessibility Insights
 - VoiceOver in Safari 13 on macOS 10.14
 - VoiceOver in Safari 14 on iOS 14
 - Manual keyboard testing in latest Chrome, Firefox, Safari on macOS 10.14
 - Manual zoom testing in Chrome, with browser-level zoom from 100% to 400%
 - Manual zoom testing in Chrome, with font size increase to Very Large

 Here is the list of issues I identified:

 -   Missing a `lang` attribute, so screen reader users would potentially
 have the page announced in the wrong language.
 -   It would be better for the page title to directly state what the page
 is about, and match the main heading.
 -   There shouldn’t be an `h2` used for the Django docs link – this isn’t
 a section of the page.
 -   The links in text are only distinguished by their color – this is
 problematic for colorblind users, who might not realize there are links.
 -   The main rocket launch visual should be hidden for screen reader users
 -   The animation should respect `@media (prefers-reduced-motion: reduce)`
 ([https://code.djangoproject.com/ticket/32051 #32051])
 -   The main heading should be a `h1` (the page has no h1 currently)
 -   The main paragraph text needs to pass color contrast checks
 -   SVG icons should be hidden for screen reader users.
 -   SVG icons in links should be set to `focusable="false"` for screen
 reader users in IE11
 -   (It would be nice for all text on the page to pass AAA contrast
 requirements, considering it’s such a simple page. Currently, the footer’s
 p tags o

[Django] #32053: Accessibility issues with Congrats page for new projects

[Django]

#32053: Accessibility issues with Congrats page for new projects
-+-
   Reporter:  Thibaud|  Owner:  nobody
  Colas  |
   Type:  Bug| Status:  new
  Component:  Core   |Version:  3.1
  (Other)|
   Severity:  Normal |   Keywords:  accessibility, ui
   Triage Stage: |  Has patch:  1
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  1  |
-+-
 Similarly to [https://code.djangoproject.com/ticket/31617 #31617] about
 accessibility of the Django admin, there are a lot of small fixes /
 improvements that should be done to the accessibility of the "The install
 worked successfully! Congratulations!" page for new projects.

 I’ve audited it with a suite of tools and screen readers, with
 requirements from WCAG 2.1 AA in mind:

 - The V.Nu HTML validator
 - Axe v3 (via Accessibility Insights)
 - VoiceOver in Safari 13 on macOS 10.14
 - VoiceOver in Safari 14 on iOS 14
 - Manual keyboard testing in latest Chrome, Firefox, Safari on macOS 10.14

 Here is the list of issues I identified:

 -   Missing a `lang` attribute, so screen reader users would potentially
 have the page announced in the wrong language.
 -   It would be better for the page title to directly state what the page
 is about, and match the main heading.
 -   There shouldn’t be an `h2` used for the Django docs link – this isn’t
 a section of the page.
 -   The links in text are only distinguished by their color – this is
 problematic for colorblind users, who might not realize there are links.
 -   The main rocket launch visual should be hidden for screen reader users
 -   The animation should respect `@media (prefers-reduced-motion: reduce)`
 ([https://code.djangoproject.com/ticket/32051 #32051])
 -   The main heading should be a `h1` (the page has no h1 currently)
 -   The main paragraph text needs to pass color contrast checks
 -   SVG icons should be hidden for screen reader users.
 -   SVG icons in links should be set to `focusable="false"` for screen
 reader users in IE11
 -   (It would be nice for all text on the page to pass AAA contrast
 requirements, considering it’s such a simple page. Currently, the footer’s
 p tags only pass AA).
 -   For some reason the footer links don’t have a focus outline for me in
 Firefox & Safari
 -   Footer links shouldn’t be using h4 headings
 -   Text font size and line heights shouldn’t be defined in pixels, so
 users can resize text if desired

 I also made a recording of the VoiceOver testing for future reference:
 https://youtu.be/XB0Ft8tLMFg

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/055.798aeb46b0c95cf9cf616d53c0022700%40djangoproject.com.

Re: [Django] #25370: Error display when makemigrations' field serializing fails with ValueError

[Django]

#25370: Error display when makemigrations' field serializing fails with 
ValueError
-+-
 Reporter:  torstenrudolf|Owner:  Tameesh
 Type:   |  Biswas
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Ram Parameswaran):

 This module (django/db/migrations/serializer.py) was overhauled and merged
 in 2016 (see https://github.com/django/django/pull/6059).
 Do you think a patch is still required?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.ae1ee3ad3dc456a6abf563ba6c5239a6%40djangoproject.com.

[Django] #32052: Change password link in UserAdmin is still available for the staff user's with 'change_user" permission and lack of 'change_password' one

[Django]

#32052: Change password link in UserAdmin is still available for the staff 
user's
with 'change_user" permission and lack of  'change_password' one
-+-
   Reporter:  Artem  |  Owner:  nobody
  Alemasov   |
   Type:  Bug| Status:  new
  Component: |Version:  3.1
  contrib.admin  |
   Severity:  Normal |   Keywords:  permissions, admin
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Despite the password row disappeared from the change_view in admin for
 user when the 'change_password' permission is removed. The user is still
 able manually navigate to change password form via
 ///admin/users/https://code.djangoproject.com/ticket/32052>
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.b41ff9ee09881470bdfe476a1ea10dc5%40djangoproject.com.

Re: [Django] #32051: Animation issues with rocket on Congrats new project page

[Django]

#32051: Animation issues with rocket on Congrats new project page
---+--
 Reporter:  Thibaud Colas  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Core (Other)   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  accessibility, ui  | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Description changed by Thibaud Colas:

Old description:

> There are a number of issues with the rocket animation shown on the
> Congrats page. In no specific order,
>
> - The page take up between 10 and 30% of my CPU to render the animations
> on a MacBook Pro from 2015.
> - Firefox has a different animation from other browsers, where the rocket
> `exhaust__line` extends further than it should.
> - For other browsers (tested in Chrome and Safari on macOS), the smoke is
> cropped to the sides because of root-level SVGs being `overflow: hidden`.
> - The animation doesn’t respect [`prefers-reduced-motion:
> reduce`](https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-
> reduced-motion) (more of an enhancement).
>
> I’ve taken a stab at addressing these, and cleaning up unused CSS and
> SVG, in https://github.com/django/django/pull/13463.

New description:

 There are a number of issues with the rocket animation shown on the
 Congrats page. In no specific order,

 - The page take up between 10 and 30% of my CPU to render the animations
 on a MacBook Pro from 2015.
 - Firefox has a different animation from other browsers, where the rocket
 `exhaust__line` extends further than it should.
 - For other browsers (tested in Chrome and Safari on macOS), the smoke is
 cropped to the sides because of root-level SVGs being `overflow: hidden`.
 - The animation doesn’t respect [https://developer.mozilla.org/en-
 US/docs/Web/CSS/@media/prefers-reduced-motion `prefers-reduced-motion:
 reduce`] (more of an enhancement).

 I’ve taken a stab at addressing these, and cleaning up unused CSS and SVG,
 in https://github.com/django/django/pull/13463.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.68b8299855aa0360043727a44894a858%40djangoproject.com.

Re: [Django] #32051: Animation issues with rocket on Congrats new project page

[Django]

#32051: Animation issues with rocket on Congrats new project page
---+--
 Reporter:  thibaudcolas   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Core (Other)   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  accessibility, ui  | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by thibaudcolas):

 * keywords:   => accessibility, ui
 * ui_ux:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.a2b74981ccd675b340c2f8577b034f71%40djangoproject.com.

Re: [Django] #32051: Animation issues with rocket on Congrats new project page (was: Animation issues with rocket on Congrats page)

[Django]

#32051: Animation issues with rocket on Congrats new project page
---+--
 Reporter:  Thibaud Colas  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Core (Other)   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.c908fade3d573f044486486d2c529bf1%40djangoproject.com.

Re: [Django] #32051: Animation issues with rocket on Congrats page

[Django]

#32051: Animation issues with rocket on Congrats page
---+--
 Reporter:  Thibaud Colas  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Core (Other)   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Thibaud Colas):

 * has_patch:  0 => 1


Old description:

> There are a number of issues with the rocket animation shown on the
> Congrats page. In no specific order,
>
> - The page take up between 10 and 30% of my CPU to render the animations
> on a MacBook Pro from 2015.
> - Firefox has a different animation from other browsers, where the rocket
> `exhaust__line` extends further than it should.
> - For other browsers (tested in Chrome and Safari on macOS), the smoke is
> cropped to the sides because of root-level SVGs being `overflow: hidden`.
> - The animation doesn’t respect [`prefers-reduced-motion:
> reduce`](https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-
> reduced-motion) (more of an enhancement).

New description:

 There are a number of issues with the rocket animation shown on the
 Congrats page. In no specific order,

 - The page take up between 10 and 30% of my CPU to render the animations
 on a MacBook Pro from 2015.
 - Firefox has a different animation from other browsers, where the rocket
 `exhaust__line` extends further than it should.
 - For other browsers (tested in Chrome and Safari on macOS), the smoke is
 cropped to the sides because of root-level SVGs being `overflow: hidden`.
 - The animation doesn’t respect [`prefers-reduced-motion:
 reduce`](https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-
 reduced-motion) (more of an enhancement).

 I’ve taken a stab at addressing these, and cleaning up unused CSS and SVG,
 in https://github.com/django/django/pull/13463.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.c43650dd567a2cb3118a2252f8753862%40djangoproject.com.

Re: [Django] #32051: Animation issues with rocket on Congrats page

[Django]

#32051: Animation issues with rocket on Congrats page
---+--
 Reporter:  Thibaud Colas  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Core (Other)   |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Thibaud Colas):

 * Attachment "32051-rocket-firefox.png" added.

 Screenshot of animation rendering in Firefox

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.a9cca7ac2b2517962332eb982950a838%40djangoproject.com.

Re: [Django] #32051: Animation issues with rocket on Congrats page

[Django]

#32051: Animation issues with rocket on Congrats page
--+--
 Reporter:  thibaudcolas  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by thibaudcolas):

 * Attachment "32051-rocket-animation-performance.gif" added.

 Screenshot of the Chrome DevTools showing CPU usage with the animation

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.4b049e0c935b68497b4aea6d085d62fd%40djangoproject.com.

Re: [Django] #32051: Animation issues with rocket on Congrats page

[Django]

#32051: Animation issues with rocket on Congrats page
--+--
 Reporter:  thibaudcolas  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by thibaudcolas):

 * Attachment "32051-rocket-safari.png" added.

 Screenshot of animation rendering in Safari

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.4c9ea5b47d437af68882ef7e306cc33b%40djangoproject.com.

[Django] #32051: Animation issues with rocket on Congrats page

[Django]

#32051: Animation issues with rocket on Congrats page
+
   Reporter:  thibaudcolas  |  Owner:  nobody
   Type:  Bug   | Status:  new
  Component:  Core (Other)  |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 There are a number of issues with the rocket animation shown on the
 Congrats page. In no specific order,

 - The page take up between 10 and 30% of my CPU to render the animations
 on a MacBook Pro from 2015.
 - Firefox has a different animation from other browsers, where the rocket
 `exhaust__line` extends further than it should.
 - For other browsers (tested in Chrome and Safari on macOS), the smoke is
 cropped to the sides because of root-level SVGs being `overflow: hidden`.
 - The animation doesn’t respect [`prefers-reduced-motion:
 reduce`](https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-
 reduced-motion) (more of an enhancement).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/055.49640455a28941ffe6dd31412a1cdd1a%40djangoproject.com.

Re: [Django] #18995: String formatting error when passing floats as values in {% blocktrans %} tags

[Django]

#18995: String formatting error when passing floats as values in {% blocktrans 
%}
tags
-+-
 Reporter:  Bruno Renié  |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * needs_better_patch:  1 => 0


Comment:

 Adjusted patch per review to allow floats and decimal.Decimal in addition
 to integers.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.b2b50d320f313ab467303cc13baa4ef2%40djangoproject.com.

Re: [Django] #32045: Removing item from GenericRelation deletes all items.

[Django]

#32045: Removing item from GenericRelation deletes all items.
-+-
 Reporter:  chgad|Owner:  Asjad
 |  Ahmed Khan
 Type:  Bug  |   Status:  closed
Component:   |  Version:  3.0
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jacob Walls):

 From the documentation on `clear()` directly below the docs linked in the
 issue description:

 "Note this doesn’t delete the related objects – it just disassociates
 them."


 It sounds like that's what you want, which is why I asked if you wanted
 `clear()` instead of `remove()`. If `clear()` gives you the behavior you
 want, I suggest this be accepted as a documentation ticket to clarify that
 `remove()` also removes from the database.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.abddfef347ab1164a23cf6ef6609352d%40djangoproject.com.

[Django] #32050: reverse() and request.get_full_path() escape URL paths differently

[Django]

#32050: reverse() and request.get_full_path() escape URL paths differently
-+-
   Reporter:  Jack   |  Owner:  nobody
  Cushman|
   Type:  Bug| Status:  new
  Component:  Core   |Version:  master
  (URLs) |   Keywords:  reverse,
   Severity:  Normal |  get_full_path, escape
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 `reverse()` and `request.get_full_path()` apply different escaping rules
 to the path section of URLs. `reverse()` applies `iri_to_uri` and escapes
 everything except `/#%[]=:;$&()+,!?*@'~`, while `get_full_path` applies
 `escape_uri_path` and escapes everything except `/:@&+$,-_.!~*'()`. (In
 other words, get_full_path() escapes some characters like semicolon that
 reverse() does not.) I'm not sure which rules are correct, but it seems
 like the two should escape URL paths the same way. In particular, maybe
 reverse() ought to apply escape_uri_path to its path section?

 Here's a one-file app that demonstrates the mismatch. Visiting
 localhost:8000/1/wrongtitle will successfully redirect to the correct
 title, but visiting localhost:8000/2/wrongtitle will start an infinite
 loop printing `/2/Some%20semicolon;.pdf does not match
 /2/Some%20semicolon%3B.pdf!` because the title contains a semicolon, which
 is escaped by get_full_path() but not by reverse().

 (I realize there are other ways to implement this demo program, but it
 highlights the underlying issue that the paths produced by the two
 functions should be escaped the same way, whichever way is correct.)

 {{{
 import sys

 from django.conf import settings
 from django.core.management import execute_from_command_line
 from django.core.wsgi import get_wsgi_application
 from django.http import HttpResponse, HttpResponseRedirect
 from django.urls import path, reverse

 settings.configure(ALLOWED_HOSTS=["*"], ROOT_URLCONF=__name__,
 SECRET_KEY="foo", DEBUG=True)

 files = {1: 'Some title.pdf', 2: 'Some semicolon;.pdf'}

 def deliver_file(request, file_id, title):
 correct_title = files[file_id]
 correct_url = reverse('deliver_file', args=[file_id, correct_title])
 if correct_url != request.get_full_path():
 print(f"{correct_url} does not match {request.get_full_path()}!")
 return HttpResponseRedirect(correct_url)
 return HttpResponse(correct_title)


 urlpatterns = [
 path("/", deliver_file, name='deliver_file'),
 ]

 app = get_wsgi_application()
 execute_from_command_line(sys.argv)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.1ef27591cedc8158566a6d5491a52778%40djangoproject.com.

Re: [Django] #32045: Removing item from GenericRelation deletes all items.

[Django]

#32045: Removing item from GenericRelation deletes all items.
-+-
 Reporter:  chgad|Owner:  Asjad
 |  Ahmed Khan
 Type:  Bug  |   Status:  closed
Component:   |  Version:  3.0
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by chgad):

 Replying to [comment:6 felixxm]:
 > Thanks for this ticket, however everything works for me with provided
 models:
 > {{{
 > class MyTests(TestCase):
 > def test_1(self):
 > p1 = MyProfile.objects.create(name='profile1')
 > p2 = MyProfile.objects.create(name='profile2')
 > photo1 = Photograph.objects.create(profile=p1)
 > photo2 = Photograph.objects.create(profile=p1)
 > photo3 = Photograph.objects.create(profile=p2)
 > self.assertEqual(Photograph.objects.count(), 3)
 > self.assertCountEqual(p1.photos.all(), [photo1, photo2])
 > self.assertCountEqual(p2.photos.all(), [photo3])
 > p1.photos.remove(photo1)
 > self.assertCountEqual(p1.photos.all(), [photo2])
 > self.assertCountEqual(p2.photos.all(), [photo3])
 > self.assertEqual(Photograph.objects.count(), 2)
 > }}}
 >
 > Can you provide a small sample project that reproduces this issue?

 That is what I'm describing. But `remove` should not delete the `photo1`
 entry. So with your example Test I expect the last assertion fail!

 As the docs. describe `remove` is expected to remove an entry from the
 Relation `p1.photos.all()` but keep it in the Database, unlinked to a
 profile.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.04e24d72c9365a248ff45f88e2b543e4%40djangoproject.com.

Re: [Django] #30422: Temporary files do not get deleted on canceled upload request.

[Django]

#30422: Temporary files do not get deleted on canceled upload request.
-+-
 Reporter:  drutalj  |Owner:  Sanskar
 |  Jaiswal
 Type:  Bug  |   Status:  assigned
Component:  File |  Version:  master
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c6256ccced487167e35a7edf2eff098d%40djangoproject.com.