Re: [Django] #13060: ManagementForm exception in case of bad prefix should be easier to understand

2020-10-13 Thread Django
#13060: ManagementForm exception in case of bad prefix should be easier to
understand
-+-
 Reporter:  Karel|Owner:  Manav
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  formset, | Triage Stage:  Accepted
  ValidationError, ManagementForm|
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * has_patch:  0 => 1
 * needs_tests:  0 => 1


Comment:

 [https://github.com/django/django/pull/13509 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.03674246e4c386cac9fc706255bb69be%40djangoproject.com.


Re: [Django] #20601: Incorrect separators when chaining floatformat to intcomma in some locales

2020-10-13 Thread Django
#20601: Incorrect separators when chaining floatformat to intcomma in some 
locales
-+-
 Reporter:  c.schmitt@…  |Owner:  Jacob
 |  Walls
 Type:  New feature  |   Status:  closed
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
  internationalization, humanize,|  checkin
  contrib, float, floatcomma |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"ac6c4260074de43a978e5c6553ef89441e1d6748" ac6c426]:
 {{{
 #!CommitTicketReference repository=""
 revision="ac6c4260074de43a978e5c6553ef89441e1d6748"
 Fixed #20601 -- Allowed forcing format with thousand separators in
 floatformat filter.

 Thanks Claude Paroz and Nick Pope for reviews.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.b5462bb9129888edbd8182174e91d959%40djangoproject.com.


Re: [Django] #31867: Inconsistency rendering hidden fields with view-only permissions in admin

2020-10-13 Thread Django
#31867: Inconsistency rendering hidden fields with view-only permissions in 
admin
-+-
 Reporter:  Antoine Humbert  |Owner:  Antoine
 |  Humbert
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:  admin hidden field   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Carlton Gibson):

 * needs_tests:  1 => 0


Comment:

 Updates on the PR, unchecking needs tests for another review.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.bc17a267407c3c18b4198b255a37f1c3%40djangoproject.com.


Re: [Django] #32088: Django Database Sessions - Can't Retrieve expire_date from request.session (SessionStore)

2020-10-13 Thread Django
#32088: Django Database Sessions - Can't Retrieve expire_date from 
request.session
(SessionStore)
-+-
 Reporter:  Nate Pinchot |Owner:  Pallav
 |  Parikh
 Type:  New feature  |   Status:  closed
Component:  contrib.sessions |  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 HI Nate, yes, thanks.

 In the end I think that's something you should add to a custom backend.
 There's no reason you can't store the value in load, as you suggest, but
 in 15 years it's not been needed and adding complexity to the API here
 isn't something I think we should do for such a niche case.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ba60cca1877a859e7dedebf53c77ff8d%40djangoproject.com.


Re: [Django] #20601: Incorrect separators when chaining floatformat to intcomma in some locales (was: Incorrect separators when chaining floatvalue to intcomma in some locales)

2020-10-13 Thread Django
#20601: Incorrect separators when chaining floatformat to intcomma in some 
locales
-+-
 Reporter:  c.schmitt@…  |Owner:  Jacob
 |  Walls
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
  internationalization, humanize,|  checkin
  contrib, float, floatcomma |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.9a28eaafbc10094b2c69b0d3f213ef72%40djangoproject.com.


Re: [Django] #32088: Django Database Sessions - Can't Retrieve expire_date from request.session (SessionStore)

2020-10-13 Thread Django
#32088: Django Database Sessions - Can't Retrieve expire_date from 
request.session
(SessionStore)
-+-
 Reporter:  Nate Pinchot |Owner:  Pallav
 |  Parikh
 Type:  New feature  |   Status:  closed
Component:  contrib.sessions |  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Unreviewed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.3dc36202f98b1bb7ac1baa8caaf650a3%40djangoproject.com.


Re: [Django] #32088: Django Database Sessions - Can't Retrieve expire_date from request.session (SessionStore)

2020-10-13 Thread Django
#32088: Django Database Sessions - Can't Retrieve expire_date from 
request.session
(SessionStore)
-+-
 Reporter:  Nate Pinchot |Owner:  Pallav
 |  Parikh
 Type:  New feature  |   Status:  closed
Component:  contrib.sessions |  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 Hi Nate.

 I'm struggling to see the use-case here.

 Sessions already expose methods to get and set the expiry, and these work
 perfectly well with DB backend:

 {{{
 >>> import datetime
 >>> from django.contrib.sessions.backends.db import SessionStore
 >>> session = SessionStore('some_session_key')
 >>> session.get_expiry_date()
 datetime.datetime(2020, 10, 27, 9, 2, 7, 300236, tzinfo=)
 >>> # Bump the expiry date. We could use any base date, but let's choose
 the existing session expiry:
 >>> session.set_expiry(session.get_expiry_date() + datetime.timedelta(7))
 >>> session.get_expiry_date()
 datetime.datetime(2020, 11, 3, 9, 10, 43, 930981, tzinfo=)
 >>> # Session will be saved with new expiry:
 >>> session.modified
 True
 }}}

 The example you link to has been in the docs since the very beginning
 21c4526557fb50b9b62f32065c7d3952ea35c5df — accessing the saved date on the
 model isn't really something you need to do — it's sole purpose is to act
 as an invalidator in the `get()` call.

 You'd be welcome to add extra code to a subclass but I can't see that it's
 something that we'd want to add to the code itself.
 Perhaps I'm missing something but I think we need to say `wontfix` here.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4dacde811251de46e8c9a5102874f1ac%40djangoproject.com.


Re: [Django] #20601: Incorrect separators when chaining floatvalue to intcomma in some locales

2020-10-13 Thread Django
#20601: Incorrect separators when chaining floatvalue to intcomma in some 
locales
-+-
 Reporter:  c.schmitt@…  |Owner:  Jacob
 |  Walls
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
  internationalization, humanize,|  checkin
  contrib, float, floatcomma |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/078.45c48b867d5a35f682fdbf2f95cf0c8e%40djangoproject.com.


Re: [Django] #32105: Allow overriding technical 500 page templates

2020-10-13 Thread Django
#32105: Allow overriding technical 500 page templates
-+-
 Reporter:  Aarni Koskela|Owner:  Aarni Koskela
 Type:  New feature  |   Status:  assigned
Component:  Error reporting  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * needs_docs:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Yep, seems reasonable. The new attributes will need docs and release
 notes.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.28255a5937c4d70d88c192076a4a36bc%40djangoproject.com.


Re: [Django] #32086: Misleading documentation on AccessMixin

2020-10-13 Thread Django
#32086: Misleading documentation on AccessMixin
-+-
 Reporter:  Remy |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  3.1
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 Hi Remy. I'm going to say wontfix here.

 The combination of `Mixin` and `view` here seems clear enough already to
 me:

 > ...the AccessMixin can be used to configure the behavior of a view when
 access is denied...

 Nonetheless, you're welcome to submit a PR with a proposed adjustment. If
 that looks clearer on review we can always reopen and Accept.
 I hope that seems fair.
 Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f1dc8028ab33f42ff02a1251fc81988e%40djangoproject.com.