Re: [Django] #32299: MiddlewareNotUsed leaves undesired side effects when loading middleware in ASGI context

[Django]

#32299: MiddlewareNotUsed leaves undesired side effects when loading middleware 
in
ASGI context
-+-
 Reporter:  Hubert Bielenia  |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  HTTP handling|  Version:  3.1
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8d98f12e6feb57e60e71db66e4e8e4f8%40djangoproject.com.

Re: [Django] #32294: fields.E305 is raised on ManyToManyFields with related_name='+' in models in different apps but with the same name.

[Django]

#32294: fields.E305 is raised on ManyToManyFields with related_name='+' in 
models
in different apps but with the same name.
-+-
 Reporter:  Aleksey Ruban|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * easy:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.2ccd8e261167e75b3ee81d0db1e9d2e0%40djangoproject.com.

Re: [Django] #32302: Permit migrations in non-namespace packages that don't have __file__

[Django]

#32302: Permit migrations in non-namespace packages that don't have __file__
-+-
 Reporter:  William Schwartz |Owner:  William
 Type:   |  Schwartz
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  migrations freezers  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.0d244a5af9fb4d13bd59f31039e827fa%40djangoproject.com.

Re: [Django] #32302: Permit migrations in non-namespace packages that don't have __file__

[Django]

#32302: Permit migrations in non-namespace packages that don't have __file__
-+-
 Reporter:  William Schwartz |Owner:  William
 Type:   |  Schwartz
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  migrations freezers  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * keywords:  migrations => migrations freezers
 * type:  New feature => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the rationale. Sounds reasonable.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.4ccb88456f101dd4b87c4b2fe518f573%40djangoproject.com.

Re: [Django] #32177: ManagementUtility instantiates CommandParser without passing already-computed prog argument

[Django]

#32177: ManagementUtility instantiates CommandParser without passing already-
computed prog argument
-+-
 Reporter:  William Schwartz |Owner:  William
 |  Schwartz
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  freezers | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * keywords:   => freezers


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.f736b6a6118964894b7106f18a3efd44%40djangoproject.com.

Re: [Django] #30950: Replace __file__ with importlib.resources

[Django]

#30950: Replace __file__ with importlib.resources
-+-
 Reporter:  John Vandenberg  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  freezers | Triage Stage:  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * keywords:   => freezers


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.84b6db32f9f91c60c732ca5f3fafd563%40djangoproject.com.

Re: [Django] #31358: Increase default password salt size in BasePasswordHasher.

[Django]

#31358: Increase default password salt size in BasePasswordHasher.
--+
 Reporter:  Jon Moroney   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * component:  Utilities => contrib.auth


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.fceb1262a9a4094cdce648df67d11351%40djangoproject.com.

Re: [Django] #32302: Permit migrations in non-namespace packages that don't have __file__

[Django]

#32302: Permit migrations in non-namespace packages that don't have __file__
-+-
 Reporter:  William Schwartz |Owner:  William
 |  Schwartz
 Type:  New feature  |   Status:  assigned
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  migrations   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by William Schwartz):

 * owner:  nobody => William Schwartz
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.49159f4f2504b5bcfe5a4bb4e1fa82d0%40djangoproject.com.

[Django] #32302: Permit migrations in non-namespace packages that don't have __file__

[Django]

#32302: Permit migrations in non-namespace packages that don't have __file__
+
   Reporter:  William Schwartz  |  Owner:  nobody
   Type:  New feature   | Status:  new
  Component:  Migrations|Version:  master
   Severity:  Normal|   Keywords:  migrations
   Triage Stage:  Unreviewed|  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 == Summary

 This feature request, for which I will post a PR shortly, aims to improve
 the specificity of the migration loader's check for and rejection of
 [http://www.python.org/dev/peps/pep-0420/ PEP-420] namespace packages. **I
 am NOT asking to allow namespace packages for apps' migrations.** I merely
 want to make the existing check more compliant with Python's documented
 import API. This would remove one impediment to using Django in so-called
 ''frozen'' Python environments (such as those mentioned in #30950) that do
 not set [https://docs.python.org/3/reference/import.html#__file__
 __file__] on ''regular'' packages by default.

 **This narrow proposal does not change Django's behavior at all for normal
 Python environments.** The only change for frozen environments is that
 Django will learn how to find existing migrations. In particular, at this
 time **I am not proposing to enable any other Django feature that does not
 already work in frozen environments**.

 I would love for this feature to land in Django 3.2.

 == Details

 I initially broached this idea on the [https://groups.google.com/g/django-
 developers/c/UXsG5xZNRgY django-developers mailing list]. This is my
 second ticket related to frozen Python environments, the first being
 #32177.

 The
 
[https://github.com/django/django/blob/2a76f4313423a3b91caade4fce71790630ef9152/django/db/migrations/loader.py#L91-L95
 current implementation] of the migration loader's no-namespace-package
 check in `django.db.migrations.loader.MigrationLoader.load_disk` skips
 searching for migrations in a module `m` if `getattr(m, '__file__', None)`
 is false.

 The trouble with this implementation is that namespace packages are not
 the only modules with no `__file__`. Indeed, the Python
 [https://docs.python.org/3/reference/import.html#__file__ documentation
 states] that

 > `__file__` is optional. If set, this attribute's value must be a string.
 The import system may opt to leave `__file__` unset if it has no semantic
 meaning (e.g. a module loaded from a database).

 However, Python's [https://docs.python.org/3/reference/import.html
 #namespace-packages documentation also states]

 > Namespace packages do not use an ordinary list for their `__path__`
 attribute. They instead use a custom iterable type

 The class of namespace packages' `__path__` in CPython is
 
[https://github.com/python/cpython/blob/4140f10a16f06c32fd49f9e21fb2a53abe7357f0/Lib/importlib/_bootstrap_external.py#L1158-L1217
 _NamespacePath], but that is a CPython implementation detail. Instead, I
 propose to augment `getattr(m, '__file__', None)` with `and
 isinstance(m.__path__, list)`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.d1de81d007bbb4dd36e143bb0e5508d3%40djangoproject.com.

Re: [Django] #32294: fields.E305 is raised on ManyToManyFields with related_name='+' in models in different apps but with the same name. (was: related_name='+' doesn't work for ManyToMany fields)

[Django]

#32294: fields.E305 is raised on ManyToManyFields with related_name='+' in 
models
in different apps but with the same name.
-+-
 Reporter:  Aleksey Ruban|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  3.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the report. It looks that `app_label` is missing in
 
[https://github.com/django/django/blob/c76d51b3ad34bc2ed2155054bfb283ef53beb26a/django/db/models/fields/related.py#L1619-L1623
 ManyToManyField.contribute_to_class()]:
 {{{
 self.remote_field.related_name = "_%s_%s_%s_+" % (cls._meta.app_label,
 cls.__name__.lower(), name)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.838b099e801d3e21697985c75eb22953%40djangoproject.com.

Re: [Django] #26602: Provide a way to manage grouping with RawSQL

[Django]

#26602: Provide a way to manage grouping with RawSQL
-+-
 Reporter:  Jamie Cockburn   |Owner:  Manav
 |  Agarwal
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  QuerySet.extra   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Manav Agarwal):

 I wrote the following test in the **BasicExpressionsTests** class in
 **expressions/test_regression.py**
 {{{
 def test_regression(self):
 companies =
 Company.objects.annotate(salary=RawSQL("SUM(num_chairs) OVER (ORDER BY
 num_employees)",[]))
 self.assertEqual(companies.count(),3)
 }}}
 And found that the error was not returned after
 
[https://github.com/django/django/commits/3f32154f40a855afa063095e3d091ce6be21f2c5]
 commit but was there in the code before this commit.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ecdf7e697887ac206ab2c6891f385189%40djangoproject.com.

Re: [Django] #28333: Filter and subquery for window expressions

[Django]

#28333: Filter and subquery for window expressions
-+-
 Reporter:  Mads Jensen  |Owner:  Manav
 |  Agarwal
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  window orm filter| Triage Stage:  Accepted
  subquery GSoC  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Manav Agarwal):

 I was looking throughout this issue and found that we had one such
 QueryWrapper class in 2.1 version.
 
([https://docs.djangoproject.com/en/2.1/_modules/django/db/models/query_utils/]).
 Anyone has any idea why it is not present in the latest releases?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.4ebe37601c6ca7a1a5085f9eac8c5c7c%40djangoproject.com.

Re: [Django] #31358: Increase default password salt size in BasePasswordHasher.

[Django]

#31358: Increase default password salt size in BasePasswordHasher.
--+
 Reporter:  Jon Moroney   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Utilities |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Mariusz Felisiak ):

 In [changeset:"c76d51b3ad34bc2ed2155054bfb283ef53beb26a" c76d51b3]:
 {{{
 #!CommitTicketReference repository=""
 revision="c76d51b3ad34bc2ed2155054bfb283ef53beb26a"
 Refs #31358 -- Fixed decoding salt in Argon2PasswordHasher.

 Argon2 encodes the salt as base64 for representation in the final hash
 output. To be able to accurately return the used salt from decode(),
 add padding, b64decode, and decode from latin1 (for the remote
 possibility that someone supplied a custom hash consisting solely of
 bytes -- this would require a manual construction of the hash though,
 Django's interface does not allow for that).
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c60ea06b275db24f4966b8c6ee1cb1bc%40djangoproject.com.

Re: [Django] #31358: Increase default password salt size in BasePasswordHasher.

[Django]

#31358: Increase default password salt size in BasePasswordHasher.
--+
 Reporter:  Jon Moroney   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Utilities |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Mariusz Felisiak ):

 In [changeset:"1b7086b2ea4c06d9c4b9233c166a16fe4390c877" 1b7086b]:
 {{{
 #!CommitTicketReference repository=""
 revision="1b7086b2ea4c06d9c4b9233c166a16fe4390c877"
 Refs #31358 -- Simplified Argon2PasswordHasher.must_update() by using
 decode().
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.d9521d5e1c490d51f2f1933aa8ef4699%40djangoproject.com.

Re: [Django] #32301: Raise CommandError when clearsessions is called on a backend not implementing clear_expired()

[Django]

#32301: Raise CommandError when clearsessions is called on a backend not
implementing clear_expired()
-+-
 Reporter:  Jacob Walls  |Owner:  François
 Type:   |  Freitag
  Cleanup/optimization   |   Status:  closed
Component:  contrib.sessions |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b11ec9a69ef626bd7aa22879145e9d74ea38a814" b11ec9a6]:
 {{{
 #!CommitTicketReference repository=""
 revision="b11ec9a69ef626bd7aa22879145e9d74ea38a814"
 Fixed #32301 -- Made clearsessions raise CommandError when clear_expired()
 is not implemented.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.233d22190a54d0557e059cebcde50963%40djangoproject.com.

Re: [Django] #32158: loaddata crashes on SQLite when table names are SQL keywords.

[Django]

#32158: loaddata crashes on SQLite when table names are SQL keywords.
-+-
 Reporter:  Scott Herriman   |Owner:  Chinmoy
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  3.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  loaddata SqlLite3| Triage Stage:  Ready for
  check_constraints  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"270072c4c231acd72a03534357a4aa59010e76ff" 270072c]:
 {{{
 #!CommitTicketReference repository=""
 revision="270072c4c231acd72a03534357a4aa59010e76ff"
 Fixed #32158 -- Fixed loaddata crash on SQLite when table/column names are
 SQL keywords.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f170c95b0b77bf6cfefc0e91d8ced08f%40djangoproject.com.