date:20210121

Re: [Django] #32338: Accessibility issues with Django forms RadioSelect and CheckboxSelectMultiple

2021-01-21 Thread Django

#32338: Accessibility issues with Django forms RadioSelect and
CheckboxSelectMultiple
-+-
 Reporter:  Thibaud Colas|Owner:  jcoombes
 Type:  Bug  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  forms, wcag|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by Claude Paroz):

 Note you should be aware of current work in #31026 (template-based
 rendering).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.d6625d8a2f48676a9b1054f86b6c8480%40djangoproject.com.

Re: [Django] #32360: Add system check that FILE_UPLOAD_TEMP_DIR exists when set

2021-01-21 Thread Django

#32360: Add system check that FILE_UPLOAD_TEMP_DIR exists when set
-+-
 Reporter:  Tim McCurrach|Owner:  Tim
 Type:   |  McCurrach
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Other) |  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.dd151217b44dbfbb626faac36c677bcf%40djangoproject.com.

Re: [Django] #32376: Allow destroy_test_db() not to fail if database doesn't exist (was: Allow destroy_test_db not to fail if database doesn't exist)

2021-01-21 Thread Django

#32376: Allow destroy_test_db() not to fail if database doesn't exist
-+-
 Reporter:  Mateusz Mandera  |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  3.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => wontfix
 * component:  Testing framework => Database layer (models, ORM)


Comment:

 > In our test setup we directly call `connection.creation.destroy_test_db`
 and the database that's meant to be dropped may or may not exist - the
 latter scenario is completely okay and shouldn't fail

 It's really unexpected that the database that you want to destroy doesn't
 exist, so an exception is desired. You can always handle it in your app,
 add a small wrapper, or
 [https://docs.djangoproject.com/en/3.1/ref/databases/#subclassing-the-
 built-in-database-backends subclass the built-in database backends].

 > destroy_test_db could take an additional optional argument, which if
 True, would cause IF EXISTS to be used in the query.

 This would require a separate logic on SQLite and Oracle, I don't think
 it's worth additional complexity. You can start a discussion on
 DevelopersMailingList if you don't agree.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.9b3863deab33b95029785679255535c5%40djangoproject.com.

Re: [Django] #32372: Improve consistency in "Related objects reference" docs.

2021-01-21 Thread Django

#32372: Improve consistency in "Related objects reference" docs.
-+-
 Reporter:  Jack Aitken  |Owner:  Jack
 Type:   |  Aitken
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  3.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"cc5ee23f74b765f35b4ba05a122eef576cedbb3b" cc5ee23f]:
 {{{
 #!CommitTicketReference repository=""
 revision="cc5ee23f74b765f35b4ba05a122eef576cedbb3b"
 [3.1.x] Fixed #32372 -- Made examples in related objects reference docs
 consistent.

 Backport of 725c549ae7a34d83447201da7190f8d71c7fc2fc from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.9240b317b57d4b4a9cc89e100e698008%40djangoproject.com.

Re: [Django] #32372: Improve consistency in "Related objects reference" docs.

2021-01-21 Thread Django

#32372: Improve consistency in "Related objects reference" docs.
-+-
 Reporter:  Jack Aitken  |Owner:  Jack
 Type:   |  Aitken
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  3.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"59c63c7f6b79ea9773aff34c53df3306e801800f" 59c63c7f]:
 {{{
 #!CommitTicketReference repository=""
 revision="59c63c7f6b79ea9773aff34c53df3306e801800f"
 [3.2.x] Fixed #32372 -- Made examples in related objects reference docs
 consistent.

 Backport of 725c549ae7a34d83447201da7190f8d71c7fc2fc from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.701db2627c5f19096cacf4c5ea8b1fe7%40djangoproject.com.

Re: [Django] #32372: Improve consistency in "Related objects reference" docs.

2021-01-21 Thread Django

#32372: Improve consistency in "Related objects reference" docs.
-+-
 Reporter:  Jack Aitken  |Owner:  Jack
 Type:   |  Aitken
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  3.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"725c549ae7a34d83447201da7190f8d71c7fc2fc" 725c549]:
 {{{
 #!CommitTicketReference repository=""
 revision="725c549ae7a34d83447201da7190f8d71c7fc2fc"
 Fixed #32372 -- Made examples in related objects reference docs
 consistent.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.ea58a7cbe983d6cdf94cf556a1fd285c%40djangoproject.com.

Re: [Django] #32378: Inconsistent exception raising syntax in documentation

2021-01-21 Thread Django

#32378: Inconsistent exception raising syntax in documentation
-+-
 Reporter:  johnthagen   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * type:  Uncategorized => Cleanup/optimization
 * resolution:   => invalid


Comment:

 Both versions work fine. I agree with Tim, it's not worth changing.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.e9eba3bcb07f6f21a687cad223e0c598%40djangoproject.com.

Re: [Django] #29606: Validate the type of ALLOWED_HOSTS

2021-01-21 Thread Django

#29606: Validate the type of ALLOWED_HOSTS
-+-
 Reporter:  rafis|Owner:  Octavio
 |  Peri
 Type:  New feature  |   Status:  assigned
Component:  Core (System |  Version:  master
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  allowed_hosts| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 Replying to [comment:18 Marius Räsener]:
 > So, what needs to be done to merge this and close the issue?

 The second step is to send PR via GitHub.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.1beb9157bf9abf6cde3485b10c0e15ba%40djangoproject.com.

Re: [Django] #32372: Improve consistency in "Related objects reference" docs.

2021-01-21 Thread Django

#32372: Improve consistency in "Related objects reference" docs.
-+-
 Reporter:  Jack Aitken  |Owner:  Jack
 Type:   |  Aitken
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  3.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Jack Aitken):

 * has_patch:  0 => 1


Comment:

 Thanks, Tim!

 PR was made here is the link: [https://github.com/django/django/pull/13926
 PR #13926]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.9663ea58778b1ad9db6162eff5d46399%40djangoproject.com.

Re: [Django] #32378: Inconsistent exception raising syntax in documentation

2021-01-21 Thread Django

#32378: Inconsistent exception raising syntax in documentation
---+--
 Reporter:  johnthagen |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--

Comment (by Tim Graham):

 If I had to choose a style, I wouldn't include unnecessary parentheses but
 I'm not sure it's even worth creating the noise in commit history as I
 don't think it's bothering anyone. I feel like this came up before but it
 may not have since there are some instances of unnecessary prantheses in
 Django's code itself - I only found one example in the docs:
 `topics/db/transactions.txt:raise SomeError()`).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.33bd65e00515282b2dadcf0b9f534361%40djangoproject.com.

Re: [Django] #32372: Improve consistency in "Related objects reference" docs.

2021-01-21 Thread Django

#32372: Improve consistency in "Related objects reference" docs.
-+-
 Reporter:  Jack Aitken  |Owner:  Jack
 Type:   |  Aitken
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  3.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham):

 Only the source files for the docs are stored in version control. You can
 build the docs locally for testing, but you shouldn't put anything from
 `docs/_build` in your commit.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.62ae1178b6c3790fb8316c6372399791%40djangoproject.com.

Re: [Django] #32377: Django duplicating block.super content

2021-01-21 Thread Django

#32377: Django duplicating block.super content
---+--
 Reporter:  jmarshall9120  |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  3.1
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Please see TicketClosingReasons/UseSupportChannels for ways to get help.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.dadeade5f876d09bcd2dfb530c2e4f2c%40djangoproject.com.

Re: [Django] #32378: Inconsistent exception raising syntax in documentation (was: Incorrect exception raising syntax in documentation)

2021-01-21 Thread Django

#32378: Inconsistent exception raising syntax in documentation
---+--
 Reporter:  johnthagen |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.b0c8852f9780b2142383cc17411704fe%40djangoproject.com.

Re: [Django] #32378: Incorrect exception raising syntax in documentation

2021-01-21 Thread Django

#32378: Incorrect exception raising syntax in documentation
---+--
 Reporter:  johnthagen |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--

Comment (by johnthagen):

 Looking into this closer, it looks like this is actually valid Python:
 https://docs.python.org/3/reference/simple_stmts.html#the-raise-statement

 "If it is a class, the exception instance will be obtained when needed by
 instantiating the class with no arguments."

 I'll leave the ticket open to see if the Django team wants to still fix
 this for style consistency purposes.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.d64a8c9215a144fb752e1c716b230b81%40djangoproject.com.

[Django] #32378: Incorrect exception raising syntax in documentation

2021-01-21 Thread Django

#32378: Incorrect exception raising syntax in documentation
-+
   Reporter:  johnthagen |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Documentation  |Version:  master
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+
 https://docs.djangoproject.com/en/dev/ref/views/#the-403-http-forbidden-
 view

 {{{
 from django.core.exceptions import PermissionDenied

 def edit(request, pk):
 if not request.user.is_staff:
 raise PermissionDenied
 # ...
 }}}

 Should that be `raise PermissionDenied()` to raise an instance?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.4c164495bf51dc5814f0a6b469d11d34%40djangoproject.com.

Re: [Django] #29606: Validate the type of ALLOWED_HOSTS

2021-01-21 Thread Django

#29606: Validate the type of ALLOWED_HOSTS
-+-
 Reporter:  rafis|Owner:  Octavio
 |  Peri
 Type:  New feature  |   Status:  assigned
Component:  Core (System |  Version:  master
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  allowed_hosts| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Marius Räsener):

 well, having a app running in production for several years now I never
 knew this exists :P
 but, whatever - that's my responsibility.
 Anyways, I don't have a strong opinion I just have an interest in closing
 this issue since I want to be some kind of contributor and head to the
 next issue.

 So, what needs to be done to merge this and close the issue?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.1df3f16102407c09924476cbff04fa1d%40djangoproject.com.

Re: [Django] #32372: Improve consistency in "Related objects reference" docs.

2021-01-21 Thread Django

Comment (by Jack):

Replying to [comment:2 Mariusz Felisiak]:

Apologies, this is my first contribution so I'm still learning a lot. I've
followed the [https://docs.djangoproject.com/en/3.1/internals/contributing
/new-contributors/ Advice for new contributors] as well as
[https://docs.djangoproject.com/en/3.1/internals/contributing/writing-
documentation/ Writing documentation]. I've now built the html files using
Sphinx but when I try to git add relations.html from
/docs/_build/html/ref/models I get an error:
{{{
The following paths are ignored by one of your .gitignore files:
docs/_build/html/ref/models/relations.html
}}}

Sorry! Any help you can give would be really appreciated.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.39c991b136fc93cf9865305079ec4f97%40djangoproject.com.

[Django] #32377: Django duplicating block.super content

2021-01-21 Thread Django

#32377: Django duplicating block.super content
-+
   Reporter:  jmarshall9120  |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Uncategorized  |Version:  3.1
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 using in template inheritance as in the docs
 [https://docs.djangoproject.com/en/3.1/howto/overriding-templates
 /#extending-an-overridden-template, here] I'm getting duplication as
 shown:

 [[Image(https://i.stack.imgur.com/UiKiv.png)]]

 In the above photo the commented Google Tag Manager text has been
 duplicated.  Obviously I would like to put the actual tag manager in
 there, but it's a simpler example this way.  Anything I put in my child
 template tag is duplicated when I call `{{ base.super }}`  I'm using
 Oscar, so here's my inheritance scheme.

 [https://github.com/django-oscar/django-
 oscar/blob/master/src/oscar/templates/oscar/base.html oscar/base.html]
 {{{
 #from oscar module
 #relevent sections only

 {% load i18n %}
 {% load static %}
 
 
 
 {% block tracking %}
 {# Default to using Google analytics #}
 {% include "oscar/partials/google_analytics.html" %}
{% endblock %}
 
 }}}

 my base override
 {{{
 # located in my procject at 'oscar/base.html'
 {% extends 'oscar/base.html' %}

 {% block tracking %}
 {{ block.super }}
 
 
 {% endblock %}
 }}}


 Below is anything else I think could be involved.  Any troubleshooting
 tips that would help me debug this would be welcome.

 my view
 {{{
 from django.http import HttpResponse
 from django.views.generic.base import TemplateView

 class BaseTestView(TemplateView):
 template_name = "oscar/base.html"
 }}}


 urls.py
 {{{
 from myurls import BaseTestView
 urlpatterns = [
 path('i18n/', include('django.conf.urls.i18n')),
 path('admin/', admin.site.urls),

 path('base_test', BaseTestView.as_view(), name='base+test'),

 ##OSCAR###
 path('', include(apps.get_app_config('oscar').urls[0])),
  ##WAGTAIL#
 path('cms/', include(wagtailadmin_urls)),
 path('documents/', include(wagtaildocs_urls)),
 path('pages/', include(wagtail_urls)),
 ] + static(settings.MEDIA_URL, document_root=settings.MEDIA_ROOT) \
 + static(settings.STATIC_URL, document_root=settings.STATIC_ROOT)
 }}}


 settings.py templates
 {{{
 TEMPLATES = [
 {
 'BACKEND': 'django.template.backends.django.DjangoTemplates',
 'DIRS': [
 location('templates'),
 ],
 'APP_DIRS': True,
 'OPTIONS': {
 'context_processors': [
 DEFAULT
 'django.template.context_processors.debug',
 'django.template.context_processors.request',
 'django.contrib.auth.context_processors.auth',
 'django.contrib.messages.context_processors.messages',

 DEFAULT
 # 'uniquesite.context_processors.metadata',

 OSCAR
 'oscar.apps.search.context_processors.search_form',
 'oscar.apps.checkout.context_processors.checkout',
 'oscar.apps.communication.notifications.context_processors.notifications',
 'oscar.core.context_processors.metadata',
 ],
 },
 },
 ]
 }}}


 There is a copy of this ticket on SO
 [https://stackoverflow.com/questions/65819831/django-duplicating-block-
 super-content/65823247 here]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/056.5243186e900d8dc1fb29856072dc%40djangoproject.com.

Re: [Django] #32367: models.W042 is raised on inherited manually specified primary key.

2021-01-21 Thread Django

#32367: models.W042 is raised on inherited manually specified primary key.
-+-
 Reporter:  אורי |Owner:  Hasan
 |  Ramezani
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"e45b944d69b6bacaccb22b351a76272aa4f93581" e45b944]:
 {{{
 #!CommitTicketReference repository=""
 revision="e45b944d69b6bacaccb22b351a76272aa4f93581"
 [3.2.x] Fixed #32367 -- Fixed system check for specifying type of auto-
 created primary keys for inherited PKs.

 Regression in b5e12d490af3debca8c55ab3c1698189fdedbbdb.

 Thanks אורי for the report.

 Backport of a03a36121d22c8784985c7e45727eddef6a3ea7f from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.c1a80358c6cd495ff65a228adf8d296a%40djangoproject.com.

Re: [Django] #32367: models.W042 is raised on inherited manually specified primary key.

2021-01-21 Thread Django

#32367: models.W042 is raised on inherited manually specified primary key.
-+-
 Reporter:  אורי |Owner:  Hasan
 |  Ramezani
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"a03a36121d22c8784985c7e45727eddef6a3ea7f" a03a3612]:
 {{{
 #!CommitTicketReference repository=""
 revision="a03a36121d22c8784985c7e45727eddef6a3ea7f"
 Fixed #32367 -- Fixed system check for specifying type of auto-created
 primary keys for inherited PKs.

 Regression in b5e12d490af3debca8c55ab3c1698189fdedbbdb.

 Thanks אורי for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.7114f7f9604c2a727eaac9a802d9c878%40djangoproject.com.

Re: [Django] #29606: Validate the type of ALLOWED_HOSTS

2021-01-21 Thread Django

#29606: Validate the type of ALLOWED_HOSTS
-+-
 Reporter:  rafis|Owner:  Octavio
 |  Peri
 Type:  New feature  |   Status:  assigned
Component:  Core (System |  Version:  master
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  allowed_hosts| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Adam Johnson):

 Personally I think a system check would be fine. We point users to run
 them during deployment in the deplyoment checklist:
 https://docs.djangoproject.com/en/3.1/howto/deployment/checklist/

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.28a4d1d28bd9b3f2f03b7d63ebb7668b%40djangoproject.com.

Re: [Django] #32338: Accessibility issues with Django forms RadioSelect and CheckboxSelectMultiple

2021-01-21 Thread Django

Comment (by jcoombes):

21/01/21

Okay, so I can reproduce this bug.
I found the relevant template which fills the content of a relevant widget
at:

django/django/forms/templates/django/forms/widgets/multiple_input.html
[The optional version of this template is at
.../django/forms/input_option.html]

This template is used to render the html form using:

django/django/forms/forms.py

BaseForm.as_p,
BaseForm.as_ul,
BaseForm.as_table.

I got stuck today - as_p, as_ul and as_table call _html_output() with
different parameters.
Changing _html_output() is risky as it would be easy to break single-
choice form fields. The code is already quite abstracted.

Easier approach:
Create and document a new method as_fieldset() for this new use case.
Avoid _html_output() entirely.

Harder approach:
Rewrite _html_output() to include the html tags necessary to render
RadioSelect and CheckboxSelectMultiple accessibly.
Avoid breaking existing code.

I think I will take the easier approach, but I'm open to feedback on how
to do it the harder way without introducing regressions.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/070.6b0375acc7f3c78306a0478a22b0012a%40djangoproject.com.

[Django] #32376: Allow destroy_test_db not to fail if database doesn't exist

2021-01-21 Thread Django

#32376: Allow destroy_test_db not to fail if database doesn't exist
-+
   Reporter:  Mateusz Mandera|  Owner:  nobody
   Type:  New feature| Status:  new
  Component:  Testing framework  |Version:  3.1
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 **The situation**
 In our test setup we directly call `connection.creation.destroy_test_db`
 and the database that's meant to be dropped may or may not exist - the
 latter scenario is completely okay and shouldn't fail

 **The Problem**
 _destroy_test_db uses `DROP DATABASE` query, meaning an exception is
 thrown if the database doesn't exist

 **A possible solution**
 destroy_test_db could take an additional optional argument, which if True,
 would cause `IF EXISTS` to be used in the query.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/057.fd5e22ba4e3634d9a7350a7740322605%40djangoproject.com.

[Django] #32375: Sitemap.protocol change default to 'https'?

2021-01-21 Thread Django

#32375: Sitemap.protocol change default to 'https'?
+
   Reporter:  Thomas Güttler|  Owner:  nobody
   Type:  New feature   | Status:  new
  Component:  contrib.sitemaps  |Version:  3.1
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 I think it is time to change the default of Sitemap.protocol to https.

 
https://docs.djangoproject.com/en/3.1/ref/contrib/sitemaps/#django.contrib.sitemaps.Sitemap.protocol

 Of course slowly with a clear deprecation timeline.

 What do you think?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.b7e33c689e80595f060aad4e1885a7da%40djangoproject.com.

Re: [Django] #32373: Broken translations since the introduction of TranslationCatalog

2021-01-21 Thread Django

Comment (by Hristo Gatsinski):

Hi, Carlton.

I'm so sorry for the trouble. It was getting late yesterday I didn't
bother to check if the issue exists in a fresh project. And it doesn't. I
started investigating it against my project and I found out that the cause
is not Django but django-filter. Before opening the ticket I tested my
third party libraries by downgrading them to the version prior to the
update but somehow I missed it. I also had to downgrade Django and maybe
this is how I got confused. Or maybe I just really wanted to find a
problem within Django and feel good for helping the community. Well, it
didn't turn out as I expected.

I created a fresh project with only django-filter installed, with a simple
test and CircleCI integration to verify the problem.

The repository is available here - https://github.com/gatsinski/django-
filters-translation-issue
The failing CI job can be found here -
https://app.circleci.com/pipelines/github/gatsinski/django-filters-
translation-issue/3/workflows/4e5e56b0-39a2-4f74-888e-e1fa0c7e090c/jobs/3

Tonight I will check the docs of django-filter and browse the changes to
see if there is something related between 2.2 and 2.4 and if not, I will
open another ticket there.

And once again, sorry for the trouble. I shouldn't open tickets that late.
Forget about this one and we will probably speak again on django-filter's
GitHub repo.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.900cf40739a00b6e044acbd130cac492%40djangoproject.com.

Re: [Django] #28905: Overhaul extra_requires to include more optional dependencies

2021-01-21 Thread Django

#28905: Overhaul extra_requires to include more optional dependencies
-+-
 Reporter:  Jaap Roes|Owner:  Nick Pope
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Packaging|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  setup optional   | Triage Stage:  Accepted
  dependencies packages  |
  requirements   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Nick Pope):

 * owner:  Rishabh Arya => Nick Pope


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.0564fbc452c4f9d53668f59f1c116d09%40djangoproject.com.

Re: [Django] #29606: Validate the type of ALLOWED_HOSTS

2021-01-21 Thread Django

#29606: Validate the type of ALLOWED_HOSTS
-+-
 Reporter:  rafis|Owner:  Octavio
 |  Peri
 Type:  New feature  |   Status:  assigned
Component:  Core (System |  Version:  master
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:  allowed_hosts| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Marius Räsener):

 I didn't see the PR earlier, thank you for pointing to it.

 Alright, so I could recreate or copy the PR, but there are things still
 open to discuss. Can someone point me in the right direction what Tim
 Graham is referring to?
 Like how could this be more helpful than a system check - maybe something
 that's hooked into a test run?

 (for a better understanding, I'm trying since yesterday my luck with "easy
 picking" issues to contribute something to Django - so please keep in mind
 I'm a beginner.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.eb763002c050f7854c018c1578499a22%40djangoproject.com.

Re: [Django] #32373: Broken translations since the introduction of TranslationCatalog

2021-01-21 Thread Django

#32373: Broken translations since the introduction of TranslationCatalog
-+-
 Reporter:  Hristo Gatsinski |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:   |  Version:  master
  Internationalization   |   Resolution:
 Severity:  Normal   |  worksforme
 Keywords:  translations | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 Hi Hristo

 Thanks for the report. Can I ask you to dig a bit more since I can't
 reproduce as described.

 Here's a full transcript showing, creation of a project with Django 3.0.4,
 with the expected result, but the same output for 3.0.5 and 3.1.5:

 {{{
 ~ $ mktmpenv
 created virtual environment CPython3.8.3.final.0-64 in 865ms
 ...
 This is a temporary environment. It will be deleted when you run
 'deactivate'.
 (tmp-1330abac7a589b8) ~/ve/tmp-1330abac7a589b8 $ pip install Django==3.0.4
 Collecting Django==3.0.4
   Using cached Django-3.0.4-py3-none-any.whl (7.5 MB)
 Collecting asgiref~=3.2
   Using cached asgiref-3.3.1-py3-none-any.whl (19 kB)
 Collecting pytz
   Using cached pytz-2020.5-py2.py3-none-any.whl (510 kB)
 Collecting sqlparse>=0.2.2
   Using cached sqlparse-0.4.1-py3-none-any.whl (42 kB)
 Installing collected packages: sqlparse, pytz, asgiref, Django
 Successfully installed Django-3.0.4 asgiref-3.3.1 pytz-2020.5
 sqlparse-0.4.1
 (tmp-1330abac7a589b8) ~/ve/tmp-1330abac7a589b8 $ django-admin startproject
 issue32373
 (tmp-1330abac7a589b8) ~/ve/tmp-1330abac7a589b8 $ cd issue32373/
 (tmp-1330abac7a589b8) ~/ve/tmp-1330abac7a589b8/issue32373 $ ./manage.py
 shell
 Python 3.8.3 (default, Jul 13 2020, 16:58:09)
 [Clang 10.0.1 (clang-1001.0.46.4)] on darwin
 Type "help", "copyright", "credits" or "license" for more information.
 (InteractiveConsole)
 >>> from django.utils import translation
 >>> translation.activate('bg')
 >>> translation.gettext('All')
 'Всички'
 >>>
 now exiting InteractiveConsole...
 (tmp-1330abac7a589b8) ~/ve/tmp-1330abac7a589b8/issue32373 $ pip install
 Django==3.0.5
 Collecting Django==3.0.5
   Using cached Django-3.0.5-py3-none-any.whl (7.5 MB)
 Requirement already satisfied: pytz in /Users/carlton/ve/tmp-
 1330abac7a589b8/lib/python3.8/site-packages (from Django==3.0.5) (2020.5)
 Requirement already satisfied: asgiref~=3.2 in /Users/carlton/ve/tmp-
 1330abac7a589b8/lib/python3.8/site-packages (from Django==3.0.5) (3.3.1)
 Requirement already satisfied: sqlparse>=0.2.2 in /Users/carlton/ve/tmp-
 1330abac7a589b8/lib/python3.8/site-packages (from Django==3.0.5) (0.4.1)
 Installing collected packages: Django
   Attempting uninstall: Django
 Found existing installation: Django 3.0.4
 Uninstalling Django-3.0.4:
   Successfully uninstalled Django-3.0.4
 Successfully installed Django-3.0.5
 (tmp-1330abac7a589b8) ~/ve/tmp-1330abac7a589b8/issue32373 $ ./manage.py
 shell
 Python 3.8.3 (default, Jul 13 2020, 16:58:09)
 [Clang 10.0.1 (clang-1001.0.46.4)] on darwin
 Type "help", "copyright", "credits" or "license" for more information.
 (InteractiveConsole)
 >>> from django.utils import translation
 >>> translation.activate('bg')
 >>> translation.gettext('All')
 'Всички'
 >>> import django
 >>> django.VERSION
 (3, 0, 5, 'final', 0)
 >>>
 now exiting InteractiveConsole...
 (tmp-1330abac7a589b8) ~/ve/tmp-1330abac7a589b8/issue32373 $ pip install -U
 Django
 Requirement already satisfied: Django in /Users/carlton/ve/tmp-
 1330abac7a589b8/lib/python3.8/site-packages (3.0.5)
 Collecting Django
   Using cached Django-3.1.5-py3-none-any.whl (7.8 MB)
 Requirement already satisfied: pytz in /Users/carlton/ve/tmp-
 1330abac7a589b8/lib/python3.8/site-packages (from Django) (2020.5)
 Requirement already satisfied: asgiref<4,>=3.2.10 in /Users/carlton/ve
 /tmp-1330abac7a589b8/lib/python3.8/site-packages (from Django) (3.3.1)
 Requirement already satisfied: sqlparse>=0.2.2 in /Users/carlton/ve/tmp-
 1330abac7a589b8/lib/python3.8/site-packages (from Django) (0.4.1)
 Installing collected packages: Django
   Attempting uninstall: Django
 Found existing installation: Django 3.0.5
 Uninstalling Django-3.0.5:
   Successfully uninstalled Django-3.0.5
 Successfully installed Django-3.1.5
 (tmp-1330abac7a589b8) ~/ve/tmp-1330abac7a589b8/issue32373 $ ./manage.py
 shell
 Python 3.8.3 (default, Jul 13 2020, 16:58:09)
 [Clang 10.0.1 (clang-1001.0.46.4)] on darwin
 Type "help", "copyright", "credits" or "license" for more information.

Re: [Django] #32367: models.W042 is raised on inherited manually specified primary key.

2021-01-21 Thread Django

#32367: models.W042 is raised on inherited manually specified primary key.
-+-
 Reporter:  אורי |Owner:  Hasan
 |  Ramezani
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 [https://github.com/django/django/pull/13925 Alternative PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.7a7367049c21691d577e8904d065315d%40djangoproject.com.

Re: [Django] #32338: Accessibility issues with Django forms RadioSelect and CheckboxSelectMultiple

Re: [Django] #32360: Add system check that FILE_UPLOAD_TEMP_DIR exists when set

Re: [Django] #32376: Allow destroy_test_db() not to fail if database doesn't exist (was: Allow destroy_test_db not to fail if database doesn't exist)

Re: [Django] #32372: Improve consistency in "Related objects reference" docs.

Re: [Django] #32372: Improve consistency in "Related objects reference" docs.

Re: [Django] #32372: Improve consistency in "Related objects reference" docs.

Re: [Django] #32378: Inconsistent exception raising syntax in documentation

Re: [Django] #29606: Validate the type of ALLOWED_HOSTS

Re: [Django] #32372: Improve consistency in "Related objects reference" docs.

Re: [Django] #32378: Inconsistent exception raising syntax in documentation

Re: [Django] #32372: Improve consistency in "Related objects reference" docs.

Re: [Django] #32377: Django duplicating block.super content

Re: [Django] #32378: Inconsistent exception raising syntax in documentation (was: Incorrect exception raising syntax in documentation)

Re: [Django] #32378: Incorrect exception raising syntax in documentation

[Django] #32378: Incorrect exception raising syntax in documentation

Re: [Django] #29606: Validate the type of ALLOWED_HOSTS

Re: [Django] #32372: Improve consistency in "Related objects reference" docs.

[Django] #32377: Django duplicating block.super content

Re: [Django] #32367: models.W042 is raised on inherited manually specified primary key.

Re: [Django] #32367: models.W042 is raised on inherited manually specified primary key.

Re: [Django] #29606: Validate the type of ALLOWED_HOSTS

Re: [Django] #32338: Accessibility issues with Django forms RadioSelect and CheckboxSelectMultiple

[Django] #32376: Allow destroy_test_db not to fail if database doesn't exist

[Django] #32375: Sitemap.protocol change default to 'https'?

Re: [Django] #32373: Broken translations since the introduction of TranslationCatalog

Re: [Django] #28905: Overhaul extra_requires to include more optional dependencies

Re: [Django] #29606: Validate the type of ALLOWED_HOSTS

Re: [Django] #32373: Broken translations since the introduction of TranslationCatalog

Re: [Django] #32367: models.W042 is raised on inherited manually specified primary key.

29 matches

Site Navigation

Mail list logo

Footer information