Re: [Django] #32438: Typo in "Testing tools" Documentation

[Django]

#32438: Typo in "Testing tools" Documentation
-+-
 Reporter:  Mark Grassi  |Owner:  David
 Type:   |  Smith
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by David Smith):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/14003 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4cf605088f1474db39bf58e4240af641%40djangoproject.com.

Re: [Django] #32416: LiveServerTestCase's ThreadedWSGIServer doesn't close database connections after each thread

[Django]

#32416: LiveServerTestCase's ThreadedWSGIServer doesn't close database 
connections
after each thread
---+
 Reporter:  Chris Jerdonek |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Mariusz Felisiak ):

 In [changeset:"91c243f80f36b6aa4ae20461b6914b63db81df17" 91c243f8]:
 {{{
 #!CommitTicketReference repository=""
 revision="91c243f80f36b6aa4ae20461b6914b63db81df17"
 Refs #32416 -- Added LiveServerThread.server_class to ease subclassing.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0d003dcf42ed3fbbf75e2a597e4d1fa7%40djangoproject.com.

Re: [Django] #26607: Add a hook to customize the admin's formsets parameters

[Django]

#26607: Add a hook to customize the admin's formsets parameters
-+-
 Reporter:  David Sanders|Owner:  Manav
 |  Agarwal
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin inline | Triage Stage:  Accepted
  formset initial|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


Comment:

 Per Nick's comments.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.73fb9cd7bf0871c07402260dadb50f0c%40djangoproject.com.

Re: [Django] #28135: simplify_regex() doesn't handle non-capturing groups

[Django]

#28135: simplify_regex() doesn't handle non-capturing groups
--+
 Reporter:  German M. Bravo   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admindocs |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by David Smith):

 * easy:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.2cfa568945d0160b25602d010d6a0cd0%40djangoproject.com.

Re: [Django] #6135: Introduce a short-cut for template filters that has needs_autoescape = True

[Django]

#6135: Introduce a short-cut for template filters that has needs_autoescape = 
True
-+
 Reporter:  anonymous|Owner:  (none)
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  autoescape   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by David Smith):

 * owner:  Seth Thoburn => (none)
 * status:  assigned => new
 * easy:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.103481a574d02a95d0e2f8402871ef82%40djangoproject.com.

Re: [Django] #28458: Add ModelMultipleChoiceField.validate_choices()

[Django]

#28458: Add ModelMultipleChoiceField.validate_choices()
---+
 Reporter:  Daniel Hahler  |Owner:  (none)
 Type:  New feature|   Status:  new
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+
Changes (by David Smith):

 * owner:  José Manuel Valdivia Romero => (none)
 * status:  assigned => new
 * easy:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f81d858fe6d634860b51ba26d4986c35%40djangoproject.com.

Re: [Django] #32437: LiveServerTestCase.setUpClass() doesn't clean up fully on failure

[Django]

#32437: LiveServerTestCase.setUpClass() doesn't clean up fully on failure
-+-
 Reporter:  Chris Jerdonek   |Owner:  Chris
 |  Jerdonek
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  2.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  LiveServerTestCase,setUpClass  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: Florian Apolloner, Tobias McNulty (added)
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.95d769ef401103e0b1868dd3f351abf3%40djangoproject.com.

Re: [Django] #32416: LiveServerTestCase's ThreadedWSGIServer doesn't close database connections after each thread

[Django]

#32416: LiveServerTestCase's ThreadedWSGIServer doesn't close database 
connections
after each thread
---+
 Reporter:  Chris Jerdonek |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Chris Jerdonek):

 I just filed [https://github.com/django/django/pull/14002 PR #14002] to
 let people customize the `ThreadedWSGIServer` used by `LiveServerThread`
 more easily. This is what I suggested above in
 [https://code.djangoproject.com/ticket/32416#comment:2 this comment].

 This will make it easier for people e.g. to implement workarounds whenever
 issues like the current one are found with the server used by
 `LiveServerThread`. (This is not the first time that the server used
 needed to be altered.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1e8dddf6f7a74f0f306699bbeb6ddea5%40djangoproject.com.

Re: [Django] #32417: LiveServerTestCase._tearDownClassInternal() has unneeded hasattr check

[Django]

#32417: LiveServerTestCase._tearDownClassInternal() has unneeded hasattr check
-+-
 Reporter:  Chris Jerdonek   |Owner:  Chris
 Type:   |  Jerdonek
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  2.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Chris Jerdonek):

 * owner:  nobody => Chris Jerdonek
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.131a779abce7aea87cb9a29dc18501b1%40djangoproject.com.

Re: [Django] #32438: Typo in "Testing tools" Documentation

[Django]

#32438: Typo in "Testing tools" Documentation
-+-
 Reporter:  Mark Grassi  |Owner:  David
 Type:   |  Smith
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by David Smith):

 * keywords:  typo =>
 * owner:  nobody => David Smith
 * status:  new => assigned
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0d6d6bdf266d4468969f55026a371e30%40djangoproject.com.

Re: [Django] #32271: Documentation consistency between display views and edit views

[Django]

#32271: Documentation consistency between display views and edit views
--+
 Reporter:  Carles Pina Estany|Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  3.1
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by David Smith):

 * owner:  Carles Pina Estany => (none)
 * status:  assigned => new
 * easy:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.a725d7961d09d3dc095fa62cd5d6525c%40djangoproject.com.

Re: [Django] #32437: LiveServerTestCase.setUpClass() doesn't clean up fully on failure

[Django]

#32437: LiveServerTestCase.setUpClass() doesn't clean up fully on failure
-+-
 Reporter:  Chris Jerdonek   |Owner:  Chris
 |  Jerdonek
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  2.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
  LiveServerTestCase,setUpClass  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Chris Jerdonek:

Old description:

> While working on #32417, I noticed in
> [https://code.djangoproject.com/ticket/32417#comment:6 this comment] that
> `LiveServerTestCase.setUpClass()` doesn't clean up all the way if
> `setUpClass()` errors out.
>
> Specifically, `LiveServerTestCase.setUpClass()`
> [https://github.com/django/django/blob/0963f184abd96800b76b19a6a181e1b544c7fafe/django/test/testcases.py#L1543-L1547
> looks like] this:
>
> {{{#!python
> @classmethod
> def setUpClass(cls):
> super().setUpClass()
> ...
> cls._live_server_modified_settings = modify_settings(
> ALLOWED_HOSTS={'append': cls.allowed_host},
> )
> ...
> if cls.server_thread.error:
> # Clean up behind ourselves, since tearDownClass won't get called
> in
> # case of errors.
> cls._tearDownClassInternal()
> raise cls.server_thread.error
> }}}
>
> But `_tearDownClassInternal()`
> [https://github.com/django/django/blob/0963f184abd96800b76b19a6a181e1b544c7fafe/django/test/testcases.py#L1559-L1568
> doesn't undo] the call to `modify_settings()`.
>
> I will post a PR shortly.

New description:

 While working on #32417, I noticed in
 [https://code.djangoproject.com/ticket/32417#comment:6 this comment] that
 `LiveServerTestCase.setUpClass()` doesn't clean up all the way if
 `setUpClass()` errors out.

 Specifically, `LiveServerTestCase.setUpClass()`
 
[https://github.com/django/django/blob/0963f184abd96800b76b19a6a181e1b544c7fafe/django/test/testcases.py#L1543-L1547
 looks like] this:

 {{{#!python
 @classmethod
 def setUpClass(cls):
 super().setUpClass()
 ...
 cls._live_server_modified_settings = modify_settings(
 ALLOWED_HOSTS={'append': cls.allowed_host},
 )
 cls._live_server_modified_settings.enable()
 ...
 if cls.server_thread.error:
 # Clean up behind ourselves, since tearDownClass won't get called
 in
 # case of errors.
 cls._tearDownClassInternal()
 raise cls.server_thread.error
 }}}

 But `_tearDownClassInternal()`
 
[https://github.com/django/django/blob/0963f184abd96800b76b19a6a181e1b544c7fafe/django/test/testcases.py#L1559-L1568
 doesn't undo] the call to `cls._live_server_modified_settings.enable()`.

 I will post a PR shortly.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e26cebdc9f84c8d3863f453fad86acb2%40djangoproject.com.

[Django] #32438: Typo in "Testing tools" Documentation

[Django]

#32438: Typo in "Testing tools" Documentation
+
   Reporter:  markgras  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Documentation |Version:  master
   Severity:  Normal|   Keywords:  typo
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 The documentation for the ''django.test.Client'' class in the "Testing
 tools" documentation incorrectly refers to keyword arguments as "keywords
 arguments" twice.

 It can be found on the Django website here:
 https://docs.djangoproject.com/en/3.1/topics/testing/tools/#django.test.Client
 It can be found in the master branch here:
 https://github.com/django/django/blob/master/docs/topics/testing/tools.txt#L112

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.9245f325cfd2ee02798fa6cc5cc5b238%40djangoproject.com.

Re: [Django] #26607: Add a hook to customize the admin's formsets parameters

[Django]

#26607: Add a hook to customize the admin's formsets parameters
-+-
 Reporter:  David Sanders|Owner:  Manav
 |  Agarwal
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin inline | Triage Stage:  Accepted
  formset initial|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Manav Agarwal):

 * needs_docs:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.4544d9063f14c04ef004308d109c446f%40djangoproject.com.

Re: [Django] #32437: LiveServerTestCase.setUpClass() doesn't clean up fully on failure

[Django]

#32437: LiveServerTestCase.setUpClass() doesn't clean up fully on failure
-+-
 Reporter:  Chris Jerdonek   |Owner:  Chris
 |  Jerdonek
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  2.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
  LiveServerTestCase,setUpClass  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Chris Jerdonek):

 * owner:  nobody => Chris Jerdonek
 * status:  new => assigned
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.fc666753905a1b3887038fce09bb841d%40djangoproject.com.

Re: [Django] #32417: LiveServerTestCase._tearDownClassInternal() has unneeded hasattr check

[Django]

#32417: LiveServerTestCase._tearDownClassInternal() has unneeded hasattr check
--+
 Reporter:  Chris Jerdonek|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  2.2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Chris Jerdonek):

 I posted here (#32437) the bug I mentioned in my previous comment. I will
 post a PR for the current issue only after a fix for that issue is merged.
 The reason is that I'd rather do the clean-up after the bug fix, since the
 clean-up overlaps the bug fix.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.12e935f2fb03c3ccdaf0c292b74d06e0%40djangoproject.com.

[Django] #32437: LiveServerTestCase.setUpClass() doesn't clean up fully on failure

[Django]

#32437: LiveServerTestCase.setUpClass() doesn't clean up fully on failure
-+-
   Reporter:  Chris  |  Owner:  nobody
  Jerdonek   |
   Type:  Bug| Status:  new
  Component:  Testing|Version:  2.2
  framework  |   Keywords:
   Severity:  Normal |  LiveServerTestCase,setUpClass
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 While working on #32417, I noticed in
 [https://code.djangoproject.com/ticket/32417#comment:6 this comment] that
 `LiveServerTestCase.setUpClass()` doesn't clean up all the way if
 `setUpClass()` errors out.

 Specifically, `LiveServerTestCase.setUpClass()`
 
[https://github.com/django/django/blob/0963f184abd96800b76b19a6a181e1b544c7fafe/django/test/testcases.py#L1543-L1547
 looks like] this:

 {{{#!python
 @classmethod
 def setUpClass(cls):
 super().setUpClass()
 ...
 cls._live_server_modified_settings = modify_settings(
 ALLOWED_HOSTS={'append': cls.allowed_host},
 )
 ...
 if cls.server_thread.error:
 # Clean up behind ourselves, since tearDownClass won't get called
 in
 # case of errors.
 cls._tearDownClassInternal()
 raise cls.server_thread.error
 }}}

 But `_tearDownClassInternal()`
 
[https://github.com/django/django/blob/0963f184abd96800b76b19a6a181e1b544c7fafe/django/test/testcases.py#L1559-L1568
 doesn't undo] the call to `modify_settings()`.

 I will post a PR shortly.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.6a48b2727f155921fab30f2ba435eef3%40djangoproject.com.

Re: [Django] #31700: Highlight destructive operations in makemigrations output

[Django]

#31700: Highlight destructive operations in makemigrations output
-+-
 Reporter:  Tom Forbes   |Owner:  Ramon Saraiva
 Type:  New feature  |   Status:  assigned
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ramon Saraiva):

 * owner:  nobody => Ramon Saraiva
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.b34344644c72da97a5e3508b0a4b86d3%40djangoproject.com.

Re: [Django] #32417: LiveServerTestCase._tearDownClassInternal() has unneeded hasattr check

[Django]

#32417: LiveServerTestCase._tearDownClassInternal() has unneeded hasattr check
--+
 Reporter:  Chris Jerdonek|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  2.2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Chris Jerdonek):

 I'm working on a PR for this, FYI. I think there might actually be a minor
 bug in `LiveServerTestCase`, so I'll be looking into confirming that prior
 to the clean-up I was proposing above.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a80f498d27286fc60c231181461b6594%40djangoproject.com.

Re: [Django] #30944: Change resuable apps docs to use setuptools declarative config

[Django]

#30944: Change resuable apps docs to use setuptools declarative config
-+-
 Reporter:  Jon Dufresne |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"a2fa2fa2f840350d23698df78bae5677c20cb623" a2fa2fa2]:
 {{{
 #!CommitTicketReference repository=""
 revision="a2fa2fa2f840350d23698df78bae5677c20cb623"
 Refs #30944 -- Added pyproject.toml in reusable apps docs.

 Related to f8f35e8c530aaf440fa8160327461460d79f6db2.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1895742828327044181e379fce735d55%40djangoproject.com.

Re: [Django] #30231: Field's verbose_name is ignored in FilteredSelectMultiple widget for inlines created with "Add another" button

[Django]

#30231: Field's verbose_name is ignored in FilteredSelectMultiple widget for
inlines created with "Add another" button
-+-
 Reporter:  Florian Schuler  |Owner:  David
 |  Smith
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.8f1dae6e72d2142a568e8c106b49f550%40djangoproject.com.

Re: [Django] #32433: Delete distinct produces an unexpected and potentially harmful SQL

[Django]

#32433: Delete distinct produces an unexpected and potentially harmful SQL
-+-
 Reporter:  egism|Owner:  egism
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  3.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  orm, delete, | Triage Stage:  Ready for
  distinct   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"aa1aed923b391b56d514be499c4ddf4b5110b377" aa1aed92]:
 {{{
 #!CommitTicketReference repository=""
 revision="aa1aed923b391b56d514be499c4ddf4b5110b377"
 [3.2.x] Fixed #32433 -- Added error message on QuerySet.delete() following
 distinct().

 Backport of 6307c3f1a123f5975c73b231e8ac4f115fd72c0d from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.ca38a8de988d9e3c8038d0025645ed0d%40djangoproject.com.

Re: [Django] #19102: Deletion using subqueries doesn't work for aggregates, extra or select_related

[Django]

#19102: Deletion using subqueries doesn't work for aggregates, extra or
select_related
-+-
 Reporter:  Anssi Kääriäinen |Owner:  Anssi
 |  Kääriäinen
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"98ce39b5a35c9d47b6c34764152fb3b1d2569c3e" 98ce39b5]:
 {{{
 #!CommitTicketReference repository=""
 revision="98ce39b5a35c9d47b6c34764152fb3b1d2569c3e"
 [3.2.x] Refs #19102 -- Removed flaky test
 Ticket19102Tests.test_ticket_19102_distinct_on.

 The subquery pushdown only happens because another table is involved in
 filter. It's not the distinct usage that causes the pushdown.

 The distinct('description').order_by('pk') expression is not valid
 because SELECT DISTINCT ON must match initial ORDER BY expressions
 which is not the case here.

 Backport of 4e8ecf0cb6ea36c45edb9cb86f0d63224e08097e from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.de779214891d44450dd43c470bbc77b0%40djangoproject.com.

Re: [Django] #25022: collectstatic create self-referential symlink

[Django]

#25022: collectstatic create self-referential symlink
-+-
 Reporter:  Aymeric Augustin |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.staticfiles  |  Version:  1.7
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => needsinfo


Comment:

 > This may end up as needsinfo...

 Reviewing this, I can't reproduce with the details, so I think 6 years
 later we can say that a test case or project showing the issue to be
 Django's is probably needed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.92d554491a9a6a8191b5d5780b257556%40djangoproject.com.

Re: [Django] #32433: Delete distinct produces an unexpected and potentially harmful SQL

[Django]

#32433: Delete distinct produces an unexpected and potentially harmful SQL
-+-
 Reporter:  egism|Owner:  egism
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  3.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  orm, delete, | Triage Stage:  Ready for
  distinct   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"6307c3f1a123f5975c73b231e8ac4f115fd72c0d" 6307c3f1]:
 {{{
 #!CommitTicketReference repository=""
 revision="6307c3f1a123f5975c73b231e8ac4f115fd72c0d"
 Fixed #32433 -- Added error message on QuerySet.delete() following
 distinct().
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.7c2113d61240f0bacd3b93ca521146a4%40djangoproject.com.

Re: [Django] #19102: Deletion using subqueries doesn't work for aggregates, extra or select_related

[Django]

#19102: Deletion using subqueries doesn't work for aggregates, extra or
select_related
-+-
 Reporter:  Anssi Kääriäinen |Owner:  Anssi
 |  Kääriäinen
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"4e8ecf0cb6ea36c45edb9cb86f0d63224e08097e" 4e8ecf0]:
 {{{
 #!CommitTicketReference repository=""
 revision="4e8ecf0cb6ea36c45edb9cb86f0d63224e08097e"
 Refs #19102 -- Removed flaky test
 Ticket19102Tests.test_ticket_19102_distinct_on.

 The subquery pushdown only happens because another table is involved in
 filter. It's not the distinct usage that causes the pushdown.

 The distinct('description').order_by('pk') expression is not valid
 because SELECT DISTINCT ON must match initial ORDER BY expressions
 which is not the case here.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.554754c1e0050c8d67d59ea0d15bd1ef%40djangoproject.com.