Re: [Django] #33433: Avoid calling resolve() when unnecessary in technical_404_response

2022-01-11 Thread Django
#33433: Avoid calling resolve() when unnecessary in technical_404_response
-+-
 Reporter:  Hrushikesh Vaidya|Owner:
 Type:   |  Hrushikesh Vaidya
  Cleanup/optimization   |   Status:  assigned
Component:  Core (URLs)  |  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.10d44f0973fb34f1148fbbc2de09c1dc%40djangoproject.com.


Re: [Django] #33433: Avoid calling resolve() when unnecessary in technical_404_response

2022-01-11 Thread Django
#33433: Avoid calling resolve() when unnecessary in technical_404_response
-+-
 Reporter:  Hrushikesh Vaidya|Owner:
 Type:   |  Hrushikesh Vaidya
  Cleanup/optimization   |   Status:  assigned
Component:  Core (URLs)  |  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Hrushikesh Vaidya):

 [https://github.com/django/django/pull/15305 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.5884d3c15bb7e1a6ef772339aaa1072c%40djangoproject.com.


Re: [Django] #33432: Missing comma in 'How to create CSV output'

2022-01-11 Thread Django
#33432: Missing comma in 'How to create CSV output'
---+-
 Reporter:  Zeilentaucher  |Owner:  Zeilentaucher
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  dev
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+-

Comment (by Mariusz Felisiak ):

 In [changeset:"89d88414dc69d04499e14f3614d42fcb820976b9" 89d8841]:
 {{{
 #!CommitTicketReference repository=""
 revision="89d88414dc69d04499e14f3614d42fcb820976b9"
 [4.0.x] Fixed #33432 -- Fixed typo in docs/howto/outputting-csv.txt.

 Backport of 658dc7045aaba548f908bb26a370eb89fb393bca from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.091cdcebc91edd1811f6abad681f1071%40djangoproject.com.


Re: [Django] #33432: Missing comma in 'How to create CSV output'

2022-01-11 Thread Django
#33432: Missing comma in 'How to create CSV output'
---+-
 Reporter:  Zeilentaucher  |Owner:  Zeilentaucher
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  dev
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"658dc7045aaba548f908bb26a370eb89fb393bca" 658dc704]:
 {{{
 #!CommitTicketReference repository=""
 revision="658dc7045aaba548f908bb26a370eb89fb393bca"
 Fixed #33432 -- Fixed typo in docs/howto/outputting-csv.txt.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.f0aa4e4f54a1e8e976eb1066fdc74d42%40djangoproject.com.


Re: [Django] #33433: Avoid calling resolve() when unnecessary in technical_404_response

2022-01-11 Thread Django
#33433: Avoid calling resolve() when unnecessary in technical_404_response
-+-
 Reporter:  Hrushikesh Vaidya|Owner:
 Type:   |  Hrushikesh Vaidya
  Cleanup/optimization   |   Status:  assigned
Component:  Core (URLs)  |  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Hrushikesh Vaidya
 * status:  new => assigned
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.09f2ea870f8f2960b149f3dcda91ce83%40djangoproject.com.


[Django] #33433: Avoid calling resolve() when unnecessary in technical_404_response

2022-01-11 Thread Django
#33433: Avoid calling resolve() when unnecessary in technical_404_response
+
   Reporter:  Hrushikesh Vaidya |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Core (URLs)   |Version:  4.0
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 As discussed in the comments of this
 [https://github.com/django/django/pull/15286#issuecomment-1008798626 PR],
 we can avoid calling `resolve(request.path)` in the
 `technical_404_response` if `request.resolver_match` is already set.

 This fix first checks if the resolver is `None` before calling
 `resolve()`, and avoids the call entirely if we have already resolved.
 {{{
 caller = ''
 if resolver_match is None:
 try:
 resolver_match = resolve(request.path)
 except Http404:
 pass

 if resolver_match is not None:
 caller = resolver_match._func_path
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/055.7c4e580fc9f944edd7a7ce423c4d8a68%40djangoproject.com.


Re: [Django] #33414: Diamond inheritance causes duplicated PK error when creating an object, if the primary key field has a default.

2022-01-11 Thread Django
#33414: Diamond inheritance causes duplicated PK error when creating an object, 
if
the primary key field has a default.
-+-
 Reporter:  Yu Li|Owner:  Yu Li
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette):

 Thank you for your detailed report.

 I haven't looked into the details of how this can be addressed but one
 thing is certain. When an instance of model class at the ''head'' of a
 diamond inheritance graph is saved the ORM knows that there isn't a reason
 to update involved tables/nodes more than once. In other words, creating a
 `BookReview` should only require 4 queries and not 6 and this issue
 predates babd4126853e48594b61e8db71a83d7bdd929b9c. I believe that's what
 we should focus on solving here as that will address this unfortunate
 collision while reducing the number of queries to a minimum.

 Test coverage for model diamond inheritance is limited given it's a rarely
 used feature and ''good'' core support for fields with Python generated
 defaults is also relatively recent so I'm not surprised we missed this
 relatively obscure edge case in #29129.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.2e7db472bcfb1929d6976a87cbc699db%40djangoproject.com.


Re: [Django] #33432: Missing comma in 'How to create CSV output'

2022-01-11 Thread Django
#33432: Missing comma in 'How to create CSV output'
---+-
 Reporter:  Zeilentaucher  |Owner:  Zeilentaucher
 Type:  Bug|   Status:  assigned
Component:  Documentation  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+-
Changes (by Zeilentaucher):

 * owner:  nobody => Zeilentaucher
 * status:  new => assigned
 * has_patch:  0 => 1
 * version:  4.0 => dev


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.45e0c9cbdc3251add68d134746950f70%40djangoproject.com.


Re: [Django] #33430: Calling command via `call_command` with option that is `required` and has set `dest` leads to an error

2022-01-11 Thread Django
#33430: Calling command via `call_command` with option that is `required` and 
has
set `dest` leads to an error
-+-
 Reporter:  Adam Mičuda  |Owner:  ravi
 |  kunwar
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  3.2
  commands)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 > But if the option is required the first call is not possible. I believe
 the behaviour should be consistent regardless of whether the option is
 required or not. What do you think?

 The current behavior is consistent. In the first call, i.e.
 {{{
 call_command('bug_report', **{ 'from': '2022-01-11' })
 }}}
 `from` is simply ignored, so an error is raised only when it's required.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.4788d53c28e85c42882b834cfadf75a6%40djangoproject.com.


Re: [Django] #33267: Add Hyperlink to related model in admin change form.

2022-01-11 Thread Django
#33267: Add Hyperlink to related model in admin change form.
+
 Reporter:  Thomas Güttler  |Owner:  Shubh Parmar
 Type:  New feature |   Status:  assigned
Component:  contrib.admin   |  Version:  3.2
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by Jacob Walls):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.d329329082260d95c0c5525dda6d2961%40djangoproject.com.


Re: [Django] #33430: Calling command via `call_command` with option that is `required` and has set `dest` leads to an error

2022-01-11 Thread Django
#33430: Calling command via `call_command` with option that is `required` and 
has
set `dest` leads to an error
-+-
 Reporter:  Adam Mičuda  |Owner:  ravi
 |  kunwar
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  3.2
  commands)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Adam Mičuda):

 Hi @Ravi,

 I'm sorry for not providing these informations. I use Python 3.9.6 and
 Django 3.2.10.


 Hi @Mariusz,
 Oh, you are right. Thank you. I have one note to this:  I think the
 behaviour is kind of confusing from dev experience.
 Lets have an option with the `dest` set, e.g.
 {{{
 parser.add_argument('--from', dest='from_')
 }}}
 It is possible to call `call_command` as
 {{{
 call_command('bug_report', **{ 'from': '2022-01-11' })
 }}}
 and
 {{{
 call_command('bug_report', **{ 'from_': '2022-01-11' })
 }}}
 either. But if the option is `required` the first call is not possible. I
 believe the behaviour should be consistent regardless of whether the
 option is required or not. What do you think?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e410a598c0ce4ec1ae4c1d82bfec97ca%40djangoproject.com.


Re: [Django] #33430: Calling command via `call_command` with option that is `required` and has set `dest` leads to an error

2022-01-11 Thread Django
#33430: Calling command via `call_command` with option that is `required` and 
has
set `dest` leads to an error
-+-
 Reporter:  Adam Mičuda  |Owner:  ravi
 |  kunwar
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  3.2
  commands)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * resolution:   => invalid


Comment:

 You should pass `dest` in `options` as
 [https://docs.djangoproject.com/en/dev/ref/django-admin/#running-
 management-commands-from-your-code documented]:

 > Some command options have different names when using `call_command()`
 instead of `django-admin` or `manage.py`. For example, `django-admin
 createsuperuser --no-input` translates to `call_command('createsuperuser',
 interactive=False)`. To find what keyword argument name to use for
 `call_command()`, check the command’s source code for the **`dest`**
 argument passed to `parser.add_argument()`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d63e2fcc4702a4f90e3d8ec3eea6ba82%40djangoproject.com.


Re: [Django] #33432: Missing comma in 'How to create CSV output'

2022-01-11 Thread Django
#33432: Missing comma in 'How to create CSV output'
---+
 Reporter:  Zeilentaucher  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  4.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the report. Would you like to prepare a patch?

 PS. For the future, no ticket is required for typos.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.8b78949e78cbdcf2ab2920eae2722378%40djangoproject.com.


Re: [Django] #33431: Regroup Violates Syntax Expectations

2022-01-11 Thread Django
#33431: Regroup Violates Syntax Expectations
-+--
 Reporter:  Caleb White  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Template system  |  Version:  3.2
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:  regroup  | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 We ask that you not create duplicate tickets but rather write to the
 DevelopersMailingList to make your case to revisit the wontfix decision.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.407fa858a6b4ef001755e025c26a5e6c%40djangoproject.com.


Re: [Django] #33430: Calling command via `call_command` with option that is `required` and has set `dest` leads to an error

2022-01-11 Thread Django
#33430: Calling command via `call_command` with option that is `required` and 
has
set `dest` leads to an error
-+-
 Reporter:  Adam Mičuda  |Owner:  ravi
 |  kunwar
 Type:  Bug  |   Status:  assigned
Component:  Core (Management |  Version:  3.2
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by ravi kunwar):

 hey Adam Mičuda
 whic python and django version you are using ??

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.7f547853893cdf37266fe74d22fb9418%40djangoproject.com.


[Django] #33432: Missing comma in 'How to create CSV output'

2022-01-11 Thread Django
#33432: Missing comma in 'How to create CSV output'
-+
   Reporter:  Zeilentaucher  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Documentation  |Version:  4.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+
 In the documentation, is a comma missing in the argument list

 File: docs/howto/outputting-csv.txt

 Is:

 {{{
 response = HttpResponse(
 content_type='text/csv'
 headers={'Content-Disposition': 'attachment;
 filename="somefilename.csv"'},
 )
 }}}

 should be:

 {{{
 response = HttpResponse(
 content_type='text/csv',
 headers={'Content-Disposition': 'attachment;
 filename="somefilename.csv"'},
 )
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/056.d0dae8795bbaf2ea7adca7fa71a89537%40djangoproject.com.


Re: [Django] #33430: Calling command via `call_command` with option that is `required` and has set `dest` leads to an error

2022-01-11 Thread Django
#33430: Calling command via `call_command` with option that is `required` and 
has
set `dest` leads to an error
-+-
 Reporter:  Adam Mičuda  |Owner:  ravi
 |  kunwar
 Type:  Bug  |   Status:  assigned
Component:  Core (Management |  Version:  3.2
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by ravi kunwar):

 * owner:  nobody => ravi kunwar
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.eef80366bc243ee6b18da918847dd9b2%40djangoproject.com.


[Django] #33431: Regroup Violates Syntax Expectations

2022-01-11 Thread Django
#33431: Regroup Violates Syntax Expectations
---+-
   Reporter:  Caleb White  |  Owner:  nobody
   Type:  Bug  | Status:  new
  Component:  Template system  |Version:  3.2
   Severity:  Normal   |   Keywords:  regroup
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+-
 I would like to re-report the following issue from 16 years ago:
 https://code.djangoproject.com/ticket/1461

 I hope that it is obvious why it would be useful to dynamically resolve
 this variable.

 I spent a long time trying to figure out why `group_key.grouper` was
 always `None` for me, and it's because the variable I'm using as the
 grouping token is being treated as a string rather than a variable.

 Honestly this seems like a serious design flaw in the template language
 itself - why are unquoted tokens ever treated as strings? How is the user
 of the template language supposed to know whether a given token will be
 resolved as a variable or treated as a literal string? This is very
 confusing and I can't find any explanation in the documentation of why
 this is the case. I can't think of any benefit gained by all of this
 ambiguity, so I imagine the only reason not to change this is going to be
 backwards compatibility.

 As far as I can tell, this bug is present in every version of Django.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.0d36c3aea8a37a7dc5f5da111ed66315%40djangoproject.com.


[Django] #33430: Calling command via `call_command` with option that is `required` and has set `dest` leads to an error

2022-01-11 Thread Django
#33430: Calling command via `call_command` with option that is `required` and 
has
set `dest` leads to an error
-+-
   Reporter:  micuda |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Core   |Version:  3.2
  (Management commands)  |
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Calling command via `call_command` with option that is `required` and has
 set `dest` leads to an error:

 "Error: the following arguments are required: "

 

 Code to simulate behaviour:

 {{{
 from django.core.management.base import BaseCommand, CommandParser

 class Command(BaseCommand):
 def add_arguments(self, parser: CommandParser):
 # parser.add_argument('--from') # OK
 # parser.add_argument('--from', dest='from_') # OK
 # parser.add_argument('--from', required=True) # OK
 parser.add_argument('--from', required=True, dest='from_') # leads
 to an error

 def handle(self, *args, **options):
 ...
 }}}

 and calling the command:

 {{{
 call_command('bug_report', **{ 'from': '2022-01-11' })
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.e879502ab4a56f3c3fff9f70938f866d%40djangoproject.com.


Re: [Django] #33379: Add minimum database version checks

2022-01-11 Thread Django
#33379: Add minimum database version checks
-+-
 Reporter:  Tim Graham   |Owner:  Hasan
 |  Ramezani
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Hasan Ramezani):

 * needs_better_patch:  1 => 0


Comment:

 I've added a new commit to the existing patch and moved the database
 version check to `init_connection_state`.
 Also, I've changed the tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a41a629d6b3faa11108cc210930ac4a5%40djangoproject.com.


Re: [Django] #32619: 'ManyToOneRel' object has no attribute 'get_limit_choices_to'

2022-01-11 Thread Django
#32619: 'ManyToOneRel' object has no attribute 'get_limit_choices_to'
---+--
 Reporter:  Seb G  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  contrib.admin  |  Version:  3.2
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Timothy Allen):

 For anyone who finds this ticket with the same error: this error will be
 triggered if you are using the third party Django admin packages `django-
 admin-autocomplete-filter` or `django-admin-rangefilter`. Upgrade to the
 latest versions (as of this writing, `django-admin-rangefilter==0.6.3` and
 `django-admin-autocomplete-filter==0.8.3`) and it should resolve the
 error.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.17e8b5e715ee2b5e7a99fddd6cc3e3ac%40djangoproject.com.


Re: [Django] #11715: If change mutable list "inlines" in one admin options then it will change "inlines" for all admin options.

2022-01-11 Thread Django
#11715: If change mutable list "inlines" in one admin options then it will 
change
"inlines" for all admin options.
-+-
 Reporter:  Alexander Ivanov |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  1.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  inlines admin| Triage Stage:  Ready for
  options|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"dc9deea8e85641695e489e43ed5d5638134c15c7" dc9deea8]:
 {{{
 #!CommitTicketReference repository=""
 revision="dc9deea8e85641695e489e43ed5d5638134c15c7"
 Fixed #11715 -- Changed default value of ModelAdmin.actions/inlines to
 empty tuples.

 This clarifies the intended pattern of overwriting the default value
 rather than mutating it.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.06994823c8265df5cfdc66156d48167c%40djangoproject.com.


Re: [Django] #13251: Add ability to know where an object was deleted from to pre/post delete signals

2022-01-11 Thread Django
#13251: Add ability to know where an object was deleted from to pre/post delete
signals
-+-
 Reporter:  skoom|Owner:  Marcelo
 |  Galigniana
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  signals  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Fixed by fa235004dd1423b129befe847bbf207808ca07ad.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.9b6b13143c9616d63fb842c6495be9bd%40djangoproject.com.


Re: [Django] #33267: Add Hyperlink to related model in admin change form.

2022-01-11 Thread Django
#33267: Add Hyperlink to related model in admin change form.
+
 Reporter:  Thomas Güttler  |Owner:  Shubh Parmar
 Type:  New feature |   Status:  assigned
Component:  contrib.admin   |  Version:  3.2
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by Shubh Parmar):

 PR: [https://github.com/django/django/pull/15301]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.d68d81cfcc8a47f990b97ed376af8e9e%40djangoproject.com.


Re: [Django] #33422: Document @isolate_apps

2022-01-11 Thread Django
#33422: Document @isolate_apps
--+
 Reporter:  Adam Johnson  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.76f579421599ed4049d04e0abfb38b72%40djangoproject.com.


Re: [Django] #11715: If change mutable list "inlines" in one admin options then it will change "inlines" for all admin options.

2022-01-11 Thread Django
#11715: If change mutable list "inlines" in one admin options then it will 
change
"inlines" for all admin options.
-+-
 Reporter:  Alexander Ivanov |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  1.1
 Severity:  Normal   |   Resolution:
 Keywords:  inlines admin| Triage Stage:  Ready for
  options|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.33854cbc064299629e54bf0573c8fbc1%40djangoproject.com.


Re: [Django] #33422: Document @isolate_apps

2022-01-11 Thread Django
#33422: Document @isolate_apps
-+-
 Reporter:  Adam Johnson |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Testing framework|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 I think documenting `@isolate_apps` is probably a good idea. (One
 alternative that I've used is a custom test-only app using Simon's
 `setup_test_app` idea/proposal on
 https://code.djangoproject.com/ticket/7835#comment:46 — but…)

 I agree we shouldn't document every caveat… Perhaps noting the more
 complex cases, and then we can come up with patterns as a group on the
 forum, and maybe address some of the issues as folks hit them 🤔

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.f94e7a39e6974b5901fed503fe715d44%40djangoproject.com.


Re: [Django] #33427: Add new flag in loaddata command that loads fixture without overriding existing objects with same primary key

2022-01-11 Thread Django
#33427: Add new flag in loaddata command that loads fixture without overriding
existing objects with same primary key
-+-
 Reporter:  Mohit Solanki|Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Core (Management |  Version:  dev
  commands)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  loaddata, fixture,   | Triage Stage:
  command|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => wontfix


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.70fb7b98b4c11eb4b1aa53c69d45bbe2%40djangoproject.com.


Re: [Django] #33427: Add new flag in loaddata command that loads fixture without overriding existing objects with same primary key

2022-01-11 Thread Django
#33427: Add new flag in loaddata command that loads fixture without overriding
existing objects with same primary key
-+-
 Reporter:  Mohit Solanki|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:  dev
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  loaddata, fixture,   | Triage Stage:
  command|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 Hi Mohit.

 I'm going to say wontfix here initially: I'm not sure there's much benefit
 in complicating `loaddata`; the thought is to create your own command if
 you need this, which is just what you've done — nice working sharing that.

 It may be that a post to the DevelopersMailingList or
 [https://forum.djangoproject.com Forum] would show more demand in which
 case we could re-open…
 Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.fd402884193f60354928e316add528a7%40djangoproject.com.


Re: [Django] #26760: Delete nonexistent migrations from django_migrations table

2022-01-11 Thread Django
#26760: Delete nonexistent migrations from django_migrations table
-+-
 Reporter:  Jarek Glowacki   |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  django_migrations| Triage Stage:  Accepted
  squash migrations  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.dde9722be992ff0b46cc8421cb32f409%40djangoproject.com.


Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

2022-01-11 Thread Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-+-
 Reporter:  Anssi Kääriäinen |Owner:  raydeal
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Ayush Joshi):

 raydeal if you are currently unable to work on this ticket then you can
 assign it to me.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8a75e61d299ad9d0c0d3d8f6807171cc%40djangoproject.com.