Re: [Django] #33434: Browser font resizing doesn’t work in Django admin due to pixel values

2022-01-14 Thread Django
#33434: Browser font resizing doesn’t work in Django admin due to pixel values
-+-
 Reporter:  Thibaud Colas|Owner:  ravi
 |  kunwar
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility, ux,   | Triage Stage:  Accepted
  wcag, admin, css   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by ravi kunwar):

 hey @Thibaud Colas , I have fixed bug related to point 2 and 3 but not
 sure how to proceed with point 1 and 4. Could you explain them further,
 (for point 1 It is not clear to me where to update document & for point 4
 we already have html base size as 16 px . . so what changes do we need
 here)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.864aa4ae3ae8a2a0c5bbde3f1c201dd0%40djangoproject.com.


Re: [Django] #26142: Provide a way for model formsets to disallow new object creation

2022-01-14 Thread Django
#26142: Provide a way for model formsets to disallow new object creation
-+
 Reporter:  Tim Graham   |Owner:  Vlad
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by Jacob Walls):

 * needs_docs:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7dc03affbb266a33722d2f7a766a84aa%40djangoproject.com.


Re: [Django] #33435: Subquery.as_sql() generates invalid SQL.

2022-01-14 Thread Django
#33435: Subquery.as_sql() generates invalid SQL.
-+-
 Reporter:  M1ha Shvn|Owner:  Mohamed
 Type:   |  Nabil Rady
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  subquery, as_sql | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mohamed Nabil Rady):

 * owner:  nobody => Mohamed Nabil Rady
 * status:  new => assigned
 * has_patch:  0 => 1
 * easy:  0 => 1


Comment:

 Pull request: https://github.com/django/django/pull/15320.

 Ran back-end tests and they went fine.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f46a4bd71fd4d731f94766e5a2a32a00%40djangoproject.com.


Re: [Django] #28135: simplify_regex() doesn't handle non-capturing groups

2022-01-14 Thread Django
#28135: simplify_regex() doesn't handle non-capturing groups
-+-
 Reporter:  German M. Bravo  |Owner:  Ayush
 Type:   |  Joshi
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admindocs|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"0a17666045de6739ae1c2ac695041823d5f827f7" 0a17666]:
 {{{
 #!CommitTicketReference repository=""
 revision="0a17666045de6739ae1c2ac695041823d5f827f7"
 Fixed #28135 -- Made simplify_regex() handle non-capturing groups.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.30c74a7fbee450798d6e122349cb0f0f%40djangoproject.com.


Re: [Django] #373: Add support for multiple-column primary keys

2022-01-14 Thread Django
#373: Add support for multiple-column primary keys
-+-
 Reporter:  Jacob|Owner:  raydeal
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  database | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by raydeal):

 I am digging in Dj ORM code and trying understand how FK works underneath.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.e17995595f289f19fe95bde76c6f1a7b%40djangoproject.com.


Re: [Django] #33442: contrib.gis.geoip does not support Country-Lite version from DBIP

2022-01-14 Thread Django
#33442: contrib.gis.geoip does not support Country-Lite version from DBIP
--+
 Reporter:  Nathan Humphreys  |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  GIS   |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Claude Paroz):

 * version:  4.0 => dev
 * type:  Bug => New feature
 * stage:  Unreviewed => Accepted


Comment:

 A patch is welcome. Unfortunately, per Django release policy, this will
 not enter 3.2.x, nor 4.0.x, as it's not a regression.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.28efa434143afa7a88fac221094e9c25%40djangoproject.com.


Re: [Django] #33442: contrib.gis.geoip does not support Country-Lite version from DBIP

2022-01-14 Thread Django
#33442: contrib.gis.geoip does not support Country-Lite version from DBIP
-+--
 Reporter:  DonkeyOatie  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Description changed by DonkeyOatie:

Old description:

> The
> {{{
> db_type
> }}}
> property of the geoip database metadata for the dbip (https://db-
> ip.com/db/lite.php) lite databases is being returned as "DBIP-Country-
> Lite"
>
> The check here then fails
>
> https://github.com/django/django/blob/stable/3.2.x/django/contrib/gis/geoip2/base.py#L107
>
> despite the database being in the mmdb format.
>
> I believe Django should support the (free) dbip lite databases as well as
> the commercial maxmind databases.
>
> Changing the above line to check for
>
> {{{
> if db_type.contains("Country"):
> ...
> }}}
>
> would be sufficient.  As would a second check to check for
>
> {{{
>  if db_type.endswith("Country-") or db_type.endswith("Country-Lite"):
> ...
> }}}
>
> A similar change would be required the the dbip City-Lite database to be
> supported.

New description:

 The
 {{{
 db_type
 }}}
 property of the geoip database metadata for the dbip (https://db-
 ip.com/db/lite.php) lite databases is being returned as "DBIP-Country-
 Lite"

 The check here then fails

 
https://github.com/django/django/blob/stable/3.2.x/django/contrib/gis/geoip2/base.py#L107

 despite the database being in the mmdb format.

 I believe Django should support the (free) dbip lite databases as well as
 the commercial maxmind databases.

 Changing the above line to check for

 {{{
 if db_type.contains("Country"):
 ...
 }}}

 would be sufficient.  As would a second check to check for

 {{{
  if db_type.endswith("Country") or db_type.endswith("Country-Lite"):
 ...
 }}}

 A similar change would be required the the dbip City-Lite database to be
 supported.

 I am happy to put in a pull request but I am also hoping we can find a way
 to get this into the 3.2.x branch as well as a future 4.x release if thats
 possible.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.a4ce4d24068dd18a48a38fe6a2d4bcd1%40djangoproject.com.


[Django] #33442: contrib.gis.geoip does not support Country-Lite version from DBIP

2022-01-14 Thread Django
#33442: contrib.gis.geoip does not support Country-Lite version from DBIP
---+
   Reporter:  DonkeyOatie  |  Owner:  nobody
   Type:  Bug  | Status:  new
  Component:  GIS  |Version:  4.0
   Severity:  Normal   |   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+
 The
 {{{
 db_type
 }}}
 property of the geoip database metadata for the dbip (https://db-
 ip.com/db/lite.php) lite databases is being returned as "DBIP-Country-
 Lite"

 The check here then fails

 
https://github.com/django/django/blob/stable/3.2.x/django/contrib/gis/geoip2/base.py#L107

 despite the database being in the mmdb format.

 I believe Django should support the (free) dbip lite databases as well as
 the commercial maxmind databases.

 Changing the above line to check for

 {{{
 if db_type.contains("Country"):
 ...
 }}}

 would be sufficient.  As would a second check to check for

 {{{
  if db_type.endswith("Country-") or db_type.endswith("Country-Lite"):
 ...
 }}}

 A similar change would be required the the dbip City-Lite database to be
 supported.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/054.d02551ddf557434820e0e4d43b6d903f%40djangoproject.com.


Re: [Django] #19580: Unify reverse foreign key and m2m unsaved model querying

2022-01-14 Thread Django
#19580: Unify reverse foreign key and m2m unsaved model querying
-+-
 Reporter:  Anssi Kääriäinen |Owner:  raydeal
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by raydeal):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.05d7a00d95a1af1f5ab7c69f4fbba012%40djangoproject.com.


Re: [Django] #25313: Document how to migrate from a built-in User model to a custom User model

2022-01-14 Thread Django
#25313: Document how to migrate from a built-in User model to a custom User 
model
---+
 Reporter:  Carl Meyer |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Documentation  |  Version:  1.8
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Thomas Grainger):

 I've used a custom management command to automate this - avoiding raw sql
 by using MigrationRecorder

 {{{
 from __future__ import annotations

 import argparse

 from django.contrib.contenttypes.models import ContentType
 from django.core.management import call_command
 from django.core.management.base import BaseCommand
 from django.db import DEFAULT_DB_ALIAS, connections
 from django.db.migrations.recorder import MigrationRecorder


 class Command(BaseCommand):
 """
 Custom management command for forcing the django custom user migration
 """

 help = "fake users.migrations.0001_initial and switch auth.User
 content types to users.User if required"

 def add_arguments(self, parser: argparse.ArgumentParser) -> None:
 parser.add_argument(
 "--database",
 default=DEFAULT_DB_ALIAS,
 help="Nominates a database to apply migrations for. Defaults
 to the 'default' database.",
 )

 def handle(self, *args: object, database: object = DEFAULT_DB_ALIAS,
 **options: object) -> None:
 """
 fake users.migrations.0001_initial and switch auth.User content
 types to users.User if required"
 """
 assert isinstance(database, str)
 connection = connections[database]
 recorder = MigrationRecorder(connection)
 recorded_migrations = recorder.applied_migrations()

 if (
 # not faked yet
 ("users", "0001_initial") not in recorded_migrations
 # django auth migrations have already been applied
 and ("auth", "0001_initial") in recorded_migrations
 ):
 # https://www.caktusgroup.com/blog/2019/04/26/how-switch-
 custom-django-user-model-mid-project/
 recorder.record_applied(app="users", name="0001_initial")
 ContentType.objects.filter(app_label="auth",
 model="user").update(app_label="users")

 call_command("migrate", database=database)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e081cc5da3ada0851f4c540b09b667c2%40djangoproject.com.


Re: [Django] #28135: simplify_regex() doesn't handle non-capturing groups

2022-01-14 Thread Django
#28135: simplify_regex() doesn't handle non-capturing groups
-+-
 Reporter:  German M. Bravo  |Owner:  Ayush
 Type:   |  Joshi
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admindocs|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.6195a5f3370605f52e729d667bcd502b%40djangoproject.com.


Re: [Django] #26220: Allow SingleObjectTemplateResponseMixin to get a template_name from form_class if it's a ModelForm

2022-01-14 Thread Django
#26220: Allow SingleObjectTemplateResponseMixin to get a template_name from
form_class if it's a ModelForm
+
 Reporter:  Guilhem Saurel  |Owner:  (none)
 Type:  New feature |   Status:  new
Component:  Generic views   |  Version:  1.9
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+
Changes (by Mariusz Felisiak):

 * owner:  Guilhem Saurel => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.b6d9c0c75bdce61426d101743ffba557%40djangoproject.com.


Re: [Django] #33441: Model Field.__hash__() should be immutable.

2022-01-14 Thread Django
#33441: Model Field.__hash__() should be immutable.
-+-
 Reporter:  Adam Johnson |Owner:  Adam
 |  Johnson
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"fdfa97fb166ef5065aa2b229f19cb4ce303084e5" fdfa97f]:
 {{{
 #!CommitTicketReference repository=""
 revision="fdfa97fb166ef5065aa2b229f19cb4ce303084e5"
 Fixed #33441 -- Restored immutability of models.Field.__hash__().

 Regression in 502e75f9ed5476ffe8229109acf0c23999d4b533.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.e99d9789bd4e6fde8c20d565a7658b13%40djangoproject.com.


Re: [Django] #33441: Model Field.__hash__() should be immutable.

2022-01-14 Thread Django
#33441: Model Field.__hash__() should be immutable.
-+-
 Reporter:  Adam Johnson |Owner:  Adam
 |  Johnson
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Adam Johnson):

 > Could you go into more detail about this statement? Fields meant to be
 assigned/bound to a model class should all be set after the app setup
 phase and no fields should be bound to a model class after this point so
 I'm struggling to come up with the plenty of uses in ORM expressions you
 are referring to. Just saying that providing concrete examples might help
 your case here.

 >  I'm also struggling with finding "plenty of uses", nevertheless it
 should not block this change .

 Sorry, I wasn't clear. I meant: There are plenty of uses for fields in ORM
 expressions. These *might* lead a user to create references to a field
 before/after they are assigned to a model class. I don't have a concrete
 example, and clearly it must be rare, since no one has reported a bug
 since Django 3.2. But, I don't think it's inconcievable that someone will
 try this at some point.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.2a464dd3211d7303e15015435d5bc2c5%40djangoproject.com.