Re: [Django] #33443: Conditions when PasswordResetView sends email should be listed more clearly

2022-01-16 Thread Django
#33443: Conditions when PasswordResetView sends email should be listed more 
clearly
-+-
 Reporter:  Brad |Owner:  Brad
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
  PasswordResetView,email|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b55ebe32417e0884b6b8b3e1bc0379033aa221af" b55ebe32]:
 {{{
 #!CommitTicketReference repository=""
 revision="b55ebe32417e0884b6b8b3e1bc0379033aa221af"
 Fixed #33443 -- Clarified when PasswordResetView sends an email.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.9409a3e279bfe86646ab25df2fb62e5b%40djangoproject.com.


Re: [Django] #33443: Conditions when PasswordResetView sends email should be listed more clearly

2022-01-16 Thread Django
#33443: Conditions when PasswordResetView sends email should be listed more 
clearly
-+-
 Reporter:  Brad |Owner:  Brad
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Documentation|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
  PasswordResetView,email|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.814f99140ace673411c9cc990144bb46%40djangoproject.com.


Re: [Django] #33445: MultiWidget doesn't call subwidgets' render() methods. (was: subwidget don't rendered correctly in Miltiwidget, if subwidget have own render method.)

2022-01-16 Thread Django
#33445: MultiWidget doesn't call subwidgets' render() methods.
-+-
 Reporter:  Maxim Danilov|Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Forms|  Version:  4.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  Forms, multiwidget,  | Triage Stage:
  subwidget render.  |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * cc: Matthias Kestenholz, David Smith (added)
 * type:  Bug => New feature
 * easy:  1 => 0
 * has_patch:  1 => 0
 * resolution:   => needsinfo


Comment:

 Thanks for this report, however it's not a bug, IMO. `MultiWidget` is also
 a normal `Widget` and getting context for subwidgets (as
 
[https://docs.djangoproject.com/en/4.0/ref/forms/widgets/#django.forms.MultiWidget.get_context
 documented]) should be sufficient for rendering. `render()` is a highly
 specialized method and I don't see why calling a custom `render()` for
 subwidgets would be necessary. Also, as far as I'm aware
 [https://github.com/django-ckeditor/django-
 
ckeditor/blob/50cd4aba9533c541e7d1ef5a4e67aed8c827f10c/ckeditor/widgets.py#L28-L137
 CKEditorWidget] doesn't have a `render()` method.

 What's your use case?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.326cd9328b6cb6251011e1c7797211cd%40djangoproject.com.


Re: [Django] #33443: Conditions when PasswordResetView sends email should be listed more clearly

2022-01-16 Thread Django
#33443: Conditions when PasswordResetView sends email should be listed more 
clearly
-+-
 Reporter:  Brad |Owner:  Brad
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Documentation|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  PasswordResetView,email|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Brad
 * status:  new => assigned
 * has_patch:  0 => 1
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.f9f63d50d3705fa5573b6d6a9b72b124%40djangoproject.com.


Re: [Django] #33444: Add an option with default answer for makemigrations questions. (was: Can "Do you rename" questioner can be executed with a default or optional parameter (y/N) ?)

2022-01-16 Thread Django
#33444: Add an option with default answer for makemigrations questions.
---+--
 Reporter:  liudaoqiangtj  |Owner:  nobody
 Type:  New feature|   Status:  closed
Component:  Migrations |  Version:  3.2
 Severity:  Normal |   Resolution:  wontfix
 Keywords:  --noinput  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 Thanks for this ticket, however I don't see a need for a new option. If
 you really want to answer `yes` to all the questions, you can use a
 separate command e.g. `yes` on Linux
 {{{
 $ yes | django-admin makemigrations
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.1a9c8ab2b100475f510dda1df85f5d8c%40djangoproject.com.


Re: [Django] #33434: Browser font resizing doesn’t work in Django admin due to pixel values

2022-01-16 Thread Django
#33434: Browser font resizing doesn’t work in Django admin due to pixel values
-+-
 Reporter:  Thibaud Colas|Owner:  ravi
 |  kunwar
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility, ux,   | Triage Stage:  Accepted
  wcag, admin, css   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/15321 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.1b65c187a5b36203374d73ea02553001%40djangoproject.com.


Re: [Django] #33444: Can "Do you rename" questioner can be executed with a default or optional parameter (y/N) ?

2022-01-16 Thread Django
#33444: Can "Do you rename" questioner can be executed with a default or 
optional
parameter (y/N) ?
---+--
 Reporter:  liudaoqiangtj  |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Migrations |  Version:  3.2
 Severity:  Normal |   Resolution:
 Keywords:  --noinput  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by alchermd):

 The existing flag "--no-input" seems to fit the bill here. Is there a
 reason why you think a separate parameter is a good idea?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.421f4c7133c698ac5a22275660177934%40djangoproject.com.


[Django] #33445: subwidget don't rendered correctly in Miltiwidget, if subwidget have own render method.

2022-01-16 Thread Django
#33445: subwidget don't rendered correctly in Miltiwidget, if subwidget have own
render method.
-+-
   Reporter:  Maxim  |  Owner:  nobody
  Danilov|
   Type:  Bug| Status:  new
  Component:  Forms  |Version:  4.0
   Severity:  Normal |   Keywords:  Forms, multiwidget,
   Triage Stage: |  subwidget render.
  Unreviewed |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+-
 Subwidget don't rendered correctly in Miltiwidget, if Subwidget have own
 render method.

 How i found it: In Multiwidget I use CKEditorWidget(forms.Textarea), whose
 have own render.

 How to reproduce error:

 Put MyWidget like a subwidget in multiwidget.
 {{{
 Class MyWidget(TextInput):
 def render(self, *args, **kwargs):
 print('hello world')
 return super().render(*args, **kwargs)
 }}}

 Nobody can see "Hello world" after Multiwidget render.

 How i patch it - add subwidget.render call in context.

 {{{
 # in Multiwidget:
 def get_context(self, name, value, attrs):
 ...
 context['widget']['subwidgets'] = (self.rednder_subwidget(subwidget,
 **subwidget_context) for subwidget, subwidget_context in zip(self.widgets,
 context['widget']['subwidgets']))
 ...

 # add
 @staticmethod
 def rednder_subwidget(subwidget, **kwargs):
 kwargs['render'] = lambda:
 mark_safe(subwidget.render(kwargs['name'], kwargs['value'],
 attrs=kwargs['attrs'], renderer=kwargs.get('renderer')))
 return kwargs

 in multiwitget template:
 {% spaceless %}{% for widget in widget.subwidgets %}{{widget.render}}{%
 endfor %}{% endspaceless %}
 }}}

 Other possibility - write in documentation: MultiWidget works only with
 native Built-in Django widgets.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.5b7b52cfe194fcad645558908d2df2a6%40djangoproject.com.


[Django] #33444: Can "Do you rename" questioner can be executed with a default or optional parameter (y/N) ?

2022-01-16 Thread Django
#33444: Can "Do you rename" questioner can be executed with a default or 
optional
parameter (y/N) ?
-+---
   Reporter:  liudaoqiangtj  |  Owner:  nobody
   Type:  New feature| Status:  new
  Component:  Migrations |Version:  3.2
   Severity:  Normal |   Keywords:  --noinput
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+---
 I am in Django 3.2.6.I execute the command  after  I rename a field in my
 table:
 "python manage.py makemigrations", I got a raised questioner with "Do you
 rename book.title to book.content (a BinaryField)? [y/N]? ",
  it required a command input "y", but I want to make a default param "y"
 in this command .
 Is there any plan to make a supplement to add a default or optional
 paramter  instead of a questioner of [y/N]?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/056.538fae254a002351f93dfa75f26c9a95%40djangoproject.com.