Re: [Django] #33671: Migrations crashes when adding/altering collations on indexed columns on Oracle.

2022-05-02 Thread Django
#33671: Migrations crashes when adding/altering collations on indexed columns on
Oracle.
--+
 Reporter:  Mariusz Felisiak  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Migrations|  Version:  4.0
 Severity:  Normal|   Resolution:
 Keywords:  oracle collation  | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018088b1aa75-bca84841-1ef8-424b-baac-998f46204569-00%40eu-central-1.amazonses.com.


Re: [Django] #33667: Django admin stylesheet ignores --header-branding-color variable.

2022-05-02 Thread Django
#33667: Django admin stylesheet ignores --header-branding-color variable.
-+-
 Reporter:  Mike DeSimone|Owner:
 Type:   |  Hrushikesh Vaidya
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  3.2
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
  css,stylesheet,admin   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"f74d4cae6dd6e64226a10c74f725e649bf736655" f74d4ca]:
 {{{
 #!CommitTicketReference repository=""
 revision="f74d4cae6dd6e64226a10c74f725e649bf736655"
 Fixed #33667 -- Used --header-branding-color for branding headers in
 admin.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180889d2083-3ef5de7d-9d2a-4dbd-904e-ce91fdeea5ad-00%40eu-central-1.amazonses.com.


Re: [Django] #33667: Django admin stylesheet ignores --header-branding-color variable.

2022-05-02 Thread Django
#33667: Django admin stylesheet ignores --header-branding-color variable.
-+-
 Reporter:  Mike DeSimone|Owner:
 Type:   |  Hrushikesh Vaidya
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  css,stylesheet,admin   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Hrushikesh Vaidya):

 * owner:  nobody => Hrushikesh Vaidya
 * status:  new => assigned
 * has_patch:  0 => 1


Comment:

 I've prepared a patch [https://github.com/django/django/pull/15652 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018088552820-4b9bab59-f4d8-4f18-94ff-50edf3618d58-00%40eu-central-1.amazonses.com.


Re: [Django] #33674: Timezones cause 500 errors to not email the site admin

2022-05-02 Thread Django
#33674: Timezones cause 500 errors to not email the site admin
-+--
 Reporter:  iragm|Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Error reporting  |  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Description changed by iragm:

Old description:

> I believe I have found a bug - my site was working great prior to adding
> support for localization/timezones and if a user encountered a 500
> internal server error, I'd get an email about it and could fix it.  I
> added support for timezones, and **stopped getting the alert emails** --
> and the users are no longer sent to my 500 page.
>
> Here's some information:
> * debug=True causes things to work correctly (no email sent, debug info
> displayed to the user)
> * this does not happen in a development environment at all as far as I
> can tell
> * I am using Channels and Daphne to serve content behind an Nginx reverse
> proxy
> * When 500 errors happen, the user gets redirected to a very generic
> Daphne "exception inside application" page.  Before you blame this on
> Daphne, please keep reading...
> * The error log traceback points to `site-
> packages/django/templatetags/tz.py`
>
> If I change this class to look as follows:
> {{{
> def render(self, context):
> try:
> with timezone.override(self.tz.resolve(context)):
> output = self.nodelist.render(context)
> return output
> except:
> return self.nodelist.render(context)
> }}}
> the correct 500 error page is rendered and the email goes out to me
> telling me where the error occurred.  That suggests to me that something
> in timezone.override isn't working as it should be.
>
> I could just make a PR with this but I am not really sure what
> consequences this change has.
>
> I know there's a lack of info in this, and I apologize in advance.
> Because I only see this issue on my production server, I have to take my
> whole site down to try to test and troubleshoot it.

New description:

 I believe I have found a bug - my site was working great prior to adding
 support for localization/timezones and if a user encountered a 500
 internal server error, I'd get an email about it and could fix it.  I
 added support for timezones, and **stopped getting the alert emails** --
 and the users are no longer sent to my 500 page.

 Here's some information:
 * debug=True causes things to work correctly (no email sent, debug info
 displayed to the user)
 * this does not happen in a development environment at all as far as I can
 tell
 * I am using Channels and Daphne to serve content behind an Nginx reverse
 proxy
 * Edit: using python3 manage.py runserver with debug=False returns the
 correct 500 page.  This issue is only happening when running with Daphne.
 * When 500 errors happen, the user gets redirected to a very generic
 Daphne "exception inside application" page.  Before you blame this on
 Daphne, please keep reading...
 * The error log traceback points to `site-
 packages/django/templatetags/tz.py`

 If I change this class to look as follows:
 {{{
 def render(self, context):
 try:
 with timezone.override(self.tz.resolve(context)):
 output = self.nodelist.render(context)
 return output
 except:
 return self.nodelist.render(context)
 }}}
 the correct 500 error page is rendered and the email goes out to me
 telling me where the error occurred.  That suggests to me that something
 in timezone.override isn't working as it should be.

 I could just make a PR with this but I am not really sure what
 consequences this change has.

 I know there's a lack of info in this, and I apologize in advance. Because
 I only see this issue on my production server, I have to take my whole
 site down to try to test and troubleshoot it.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180871d949d-ef024d5a-c022-4fca-850c-847151df7dfb-00%40eu-central-1.amazonses.com.


[Django] #33674: Timezones cause 500 errors to not email the site admin

2022-05-02 Thread Django
#33674: Timezones cause 500 errors to not email the site admin
---+
   Reporter:  iragm|  Owner:  (none)
   Type:  Bug  | Status:  new
  Component:  Error reporting  |Version:  4.0
   Severity:  Normal   |   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+
 I believe I have found a bug - my site was working great prior to adding
 support for localization/timezones and if a user encountered a 500
 internal server error, I'd get an email about it and could fix it.  I
 added support for timezones, and **stopped getting the alert emails** --
 and the users are no longer sent to my 500 page.

 Here's some information:
 * debug=True causes things to work correctly (no email sent, debug info
 displayed to the user)
 * this does not happen in a development environment at all as far as I can
 tell
 * I am using Channels and Daphne to serve content behind an Nginx reverse
 proxy
 * When 500 errors happen, the user gets redirected to a very generic
 Daphne "exception inside application" page.  Before you blame this on
 Daphne, please keep reading...
 * The error log traceback points to `site-
 packages/django/templatetags/tz.py`

 If I change this class to look as follows:
 {{{
 def render(self, context):
 try:
 with timezone.override(self.tz.resolve(context)):
 output = self.nodelist.render(context)
 return output
 except:
 return self.nodelist.render(context)
 }}}
 the correct 500 error page is rendered and the email goes out to me
 telling me where the error occurred.  That suggests to me that something
 in timezone.override isn't working as it should be.

 I could just make a PR with this but I am not really sure what
 consequences this change has.

 I know there's a lack of info in this, and I apologize in advance. Because
 I only see this issue on my production server, I have to take my whole
 site down to try to test and troubleshoot it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180871a6f40-aa64ca51-847c-48cf-b935-4b7da2fabb18-00%40eu-central-1.amazonses.com.


Re: [Django] #25612: django.contrib.auth should include support for 2fa out of the box

2022-05-02 Thread Django
#25612: django.contrib.auth should include support for 2fa out of the box
--+---
 Reporter:  Alex Gaynor   |Owner:  theExplorer
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+---
Changes (by theExplorer):

 * owner:  (none) => theExplorer
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701808659cde0-fb717ca8-7e37-460a-8d45-9bd591383651-00%40eu-central-1.amazonses.com.


Re: [Django] #33658: Document the "blank" argument of forms.ModelChoiceField.

2022-05-02 Thread Django
#33658: Document the "blank" argument of forms.ModelChoiceField.
-+-
 Reporter:  Carsten Fuchs|Owner:  Alokik
 Type:   |  Roy
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018085e6a3c0-74b395e2-36fa-425c-9d9b-55e4fe741787-00%40eu-central-1.amazonses.com.


Re: [Django] #33658: Document the "blank" argument of forms.ModelChoiceField.

2022-05-02 Thread Django
#33658: Document the "blank" argument of forms.ModelChoiceField.
-+-
 Reporter:  Carsten Fuchs|Owner:  Alokik
 Type:   |  Roy
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Alokik Roy):

 * needs_better_patch:  1 => 0


Comment:

 Implemented suggested changes

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018084d8a05b-081f9552-c562-4b07-a58e-de70bd6615e2-00%40eu-central-1.amazonses.com.


Re: [Django] #25105: Migrating multiple CharFields to null=False breaks on PostgreSQL

2022-05-02 Thread Django
#25105: Migrating multiple CharFields to null=False breaks on PostgreSQL
+-
 Reporter:  Daniel Roseman  |Owner:  David Wobrock
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  3.2
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by David Wobrock):

 * cc: David Wobrock (added)
 * owner:  nobody => David Wobrock
 * has_patch:  0 => 1
 * status:  new => assigned


Comment:

 Hi there,

 Here is a [https://github.com/django/django/pull/15650 PR] that tries to
 tackle the issue.

 Let me know what you think of the approach :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018084d0ef2f-ba7bb1be-9404-4da0-bb64-bfdd0ee0e4db-00%40eu-central-1.amazonses.com.


Re: [Django] #29538: Query Expression in ordering of a related object fails

2022-05-02 Thread Django
#29538: Query Expression in ordering of a related object fails
-+-
 Reporter:  wilhelmhb|Owner:  Alexandre
 |  Laplante
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  2.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  ordering, query  | Triage Stage:  Accepted
  expression, related object |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 After 8c5f9906c56ac72fc4f13218dd90bdf9bc8a248b it crashes with:
 {{{
 django.core.exceptions.FieldError: Cannot resolve keyword 'instrument'
 into field. Choices are: artist, artist_id, id, name, num_stars,
 release_date
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180849ad537-7ffc20d3-8b85-490d-b396-83510184620b-00%40eu-central-1.amazonses.com.


Re: [Django] #26318: Unexpected / duplicated queries on nested Prefetch queryset with repeated model

2022-05-02 Thread Django
#26318: Unexpected / duplicated queries on nested Prefetch queryset with 
repeated
model
-+-
 Reporter:  Anthony Leontiev |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:  queryset | Triage Stage:  Accepted
  prefetch_related duplicate |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Fixed by f5233dce309543c826224be9dfa9c9f4f855f73c. Duplicate of #32511.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180848cc312-d5d55abd-097d-4950-a65a-c3e7e475cb5c-00%40eu-central-1.amazonses.com.


Re: [Django] #33658: Document the "blank" argument of forms.ModelChoiceField.

2022-05-02 Thread Django
#33658: Document the "blank" argument of forms.ModelChoiceField.
-+-
 Reporter:  Carsten Fuchs|Owner:  Alokik
 Type:   |  Roy
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180844a5c1f-52411f4f-8c39-4e8c-a93a-7cfcfa79161e-00%40eu-central-1.amazonses.com.


Re: [Django] #33665: Add support for Postgres multirange

2022-05-02 Thread Django
#33665: Add support for Postgres multirange
--+--
 Reporter:  Tom Carrick   |Owner:  (none)
 Type:  New feature   |   Status:  closed
Component:  contrib.postgres  |  Version:  dev
 Severity:  Normal|   Resolution:  duplicate
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => duplicate
 * stage:  Accepted => Unreviewed


Comment:

 Thanks! I had a gut feeling that I'd seen it already 🤦. Let's close it as
 a duplicate of #33238. Please leave a comment in the original ticket. We
 can reopen it if you provides PoC that is maintainable.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018084146006-1d336ec7-afc3-4ffb-9056-615f57c10b4a-00%40eu-central-1.amazonses.com.


Re: [Django] #33665: Add support for Postgres multirange

2022-05-02 Thread Django
#33665: Add support for Postgres multirange
--+
 Reporter:  Tom Carrick   |Owner:  (none)
 Type:  New feature   |   Status:  new
Component:  contrib.postgres  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tom Carrick):

 I just found https://code.djangoproject.com/ticket/33238 for this issue
 but closed as wontfix. I didn't find it the first time because I searched
 for "multirange" rather than "multi range".

 Anyway I do think this can be implemented without too much of a
 maintenance burden. I have some ideas on the implementation but I haven't
 thought about it too closely.

 I just wanted to add this because I didn't see the original ticket so I'm
 not sure if this one should be closed as well.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070180840c5f45-9a12cf40-6ce5-4dda-bc54-45b6be89617c-00%40eu-central-1.amazonses.com.


Re: [Django] #33646: Adding async interface to QuerySet.

2022-05-02 Thread Django
#33646: Adding async interface to QuerySet.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Andrew
 |  Godwin
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  async| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"77926176b281b9c553c934e52acdd1c0377ea601" 77926176]:
 {{{
 #!CommitTicketReference repository=""
 revision="77926176b281b9c553c934e52acdd1c0377ea601"
 Refs #33646 -- Added RawModelIterable.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018083f960cd-e9552937-b4d0-4112-90b9-e3ad22d4127d-00%40eu-central-1.amazonses.com.


Re: [Django] #33646: Adding async interface to QuerySet.

2022-05-02 Thread Django
#33646: Adding async interface to QuerySet.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Andrew
 |  Godwin
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  async| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"271a8e73ee382bb487d15e97ffaa675d78869413" 271a8e7]:
 {{{
 #!CommitTicketReference repository=""
 revision="271a8e73ee382bb487d15e97ffaa675d78869413"
 Refs #33646 -- Made QuerySet.raw() async-compatible.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018083f96111-599e29ca-5eb0-42e4-ac0f-538dbdefe601-00%40eu-central-1.amazonses.com.


Re: [Django] #33413: Errors with db_collation – no propagation to foreignkeys

2022-05-02 Thread Django
#33413: Errors with db_collation – no propagation to foreignkeys
+-
 Reporter:  typonaut|Owner:  David Wobrock
 Type:  Bug |   Status:  closed
Component:  Migrations  |  Version:  3.2
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"aca9bb2a12b8985d0cb736d380db97439010cd98" aca9bb2a]:
 {{{
 #!CommitTicketReference repository=""
 revision="aca9bb2a12b8985d0cb736d380db97439010cd98"
 Fixed #33413 -- Made migrations propage collations to related fields.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018083ceec36-9a078f20-b782-4ea3-93e5-c604f7e6a0af-00%40eu-central-1.amazonses.com.


Re: [Django] #33673: PostgreSQL removes constraints when removing columns. (was: Django silently removes constraints when removing columns, then arbitrarily choses to include them in migrations)

2022-05-02 Thread Django
#33673: PostgreSQL removes constraints when removing columns.
+--
 Reporter:  George  |Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  Migrations  |  Version:  3.2
 Severity:  Normal  |   Resolution:  needsinfo
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => needsinfo


Comment:

 Thanks for the report, however PostgreSQL silently drops constraints, not
 Django itself. Unfortunately when you create migrations manually you must
 be aware of database-specific behavior and handle them on your own in most
 of cases. As far as I'm aware described use case (removing column to add
 it immediately in the same migration) is really unusual and not worth
 additional complexity and a performance regression for all users. Noticing
 that constraint is missing would require inspecting db constraints which
 is always quite expensive.

 Is there any reason you cannot handle this automatically with
 `AlterField()`?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018083c7e8b8-0850ad74-5acc-4c20-8b21-9880c219c93c-00%40eu-central-1.amazonses.com.