Re: [Django] #31788: Models migration with change field foreign to many and deleting unique together.

[Django]

#31788: Models migration with change field foreign to many and deleting unique
together.
+-
 Reporter:  budzichd|Owner:  David Wobrock
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  3.0
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-

Comment (by Mariusz Felisiak):

 Thanks for the investigation!

 > 2. Changing the topological sort, so that it preserves the input order
 as much as possible

 I think it's not doable. That's just how the topological sort works. I've
 checked with `graphlib.TopologicalSorter()` (Python 3.9+) and it works
 exactly the same.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018122d8f738-c7ef8bb7-e176-4984-b5cb-e38a9619c419-00%40eu-central-1.amazonses.com.

Re: [Django] #33759: Using subquery to filter a model delete generates a sub-optimal SQL

[Django]

#33759: Using subquery to filter a model delete generates a sub-optimal SQL
-+-
 Reporter:  Christofer Bertonha  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted


Comment:

 We could add a new feature flag to add an extra subquery only on MySQL:
 {{{#!diff
 diff --git a/django/db/backends/base/features.py
 b/django/db/backends/base/features.py
 index c54d30cf73..e8737aadc2 100644
 --- a/django/db/backends/base/features.py
 +++ b/django/db/backends/base/features.py
 @@ -12,6 +12,9 @@ class BaseDatabaseFeatures:
  allows_group_by_selected_pks = False
  empty_fetchmany_value = []
  update_can_self_select = True
 +# Does the backend support self-reference subqueries in the DELETE
 +# statement?
 +delete_can_self_reference_subquery = True

  # Does the backend distinguish between '' and None?
  interprets_empty_strings_as_nulls = False
 diff --git a/django/db/backends/mysql/features.py
 b/django/db/backends/mysql/features.py
 index 3ea3deeae3..848d891a84 100644
 --- a/django/db/backends/mysql/features.py
 +++ b/django/db/backends/mysql/features.py
 @@ -25,6 +25,7 @@ class DatabaseFeatures(BaseDatabaseFeatures):
  supports_slicing_ordering_in_compound = True
  supports_index_on_text_field = False
  supports_update_conflicts = True
 +delete_can_self_reference_subquery = False
  create_test_procedure_without_params_sql = """
  CREATE PROCEDURE test_procedure ()
  BEGIN
 diff --git a/django/db/models/sql/compiler.py
 b/django/db/models/sql/compiler.py
 index 9c7bd8ea1a..e57a43ac47 100644
 --- a/django/db/models/sql/compiler.py
 +++ b/django/db/models/sql/compiler.py
 @@ -1721,7 +1721,10 @@ class SQLDeleteCompiler(SQLCompiler):
  Create the SQL for this query. Return the SQL string and list of
  parameters.
  """
 -if self.single_alias and not
 self.contains_self_reference_subquery:
 +if self.single_alias and (
 +self.connection.features.delete_can_self_reference_subquery
 or
 +not self.contains_self_reference_subquery
 +):
  return self._as_sql(self.query)
  innerq = self.query.clone()
  innerq.__class__ = Query
 }}}

 Another issue is that `QuerySet.delete()` from the ticket description:
 {{{
 subquery = Comment.objects.filter(created_at__lt=datetime(2022, 6,
 1))[:1000]
 Comment.objects.filter(id__in=subquery).delete()
 ...
   File "site-packages/MySQLdb/connections.py", line 254, in query
 _mysql.connection.query(self, query)
 django.db.utils.NotSupportedError: (1235, "This version of MySQL doesn't
 yet support 'LIMIT & IN/ALL/ANY/SOME subquery'")
 }}}
 crashes on MySQL even with 4074f38e1dcc93b859bbbfd6abd8441c3bca36b3.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018122c0d8cd-ece375b4-40f9-4ddf-99c9-4053ab5b3c3b-00%40eu-central-1.amazonses.com.

Re: [Django] #33762: test_random_ordering not really testing randomization

[Django]

#33762: test_random_ordering not really testing randomization
-+-
 Reporter:  Sicong   |Owner:  Sicong
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Other) |  Version:
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * resolution:   => wontfix
 * component:  Testing framework => Core (Other)


Comment:

 > It's very unlikely that all 10 items generated with order_by("?") are
 the same.

 Unfortunately, it's still possible. I don't see much value in adding a
 non-deterministic flaky test.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018122a0f349-a0e47f96-406d-4d63-a7f7-d7ee3e243d1c-00%40eu-central-1.amazonses.com.

Re: [Django] #33761: Format migrations using black

[Django]

#33761: Format migrations using black
-+-
 Reporter:  Neil Panchal |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:  invalid
 Keywords:  black, formatting,   | Triage Stage:
  migrations |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 In Django 4.1+ migration files are formatted using the `black` command if
 it is present on your `PATH`, see
 [https://docs.djangoproject.com/en/dev/ref/django-admin/#black-formatting
 docs].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181229f52d9-e1717d30-bb10-4425-9c3a-37acc194515c-00%40eu-central-1.amazonses.com.

Re: [Django] #33762: test_random_ordering not really testing randomization

[Django]

#33762: test_random_ordering not really testing randomization
-+-
 Reporter:  Sicong   |Owner:  Sicong
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Testing framework|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sicong):

 * owner:  nobody => Sicong
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018121d55f2b-5a6c94a5-d504-4db1-b312-823544370c43-00%40eu-central-1.amazonses.com.

[Django] #33762: test_random_ordering not really testing randomization

[Django]

#33762: test_random_ordering not really testing randomization
+
   Reporter:  Sicong|  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Testing framework |Version:
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Unit test
 
[https://github.com/django/django/blob/6f73eb9d90cfec684529aab48d517e3d6449ba8c/tests/ordering/tests.py#L235
 test_random_ordering] only checks the length of result queryset. It's not
 checking if order_by("?") giving same result every time.

 My proposed solution is like this. It's very unlikely that all 10 items
 generated with order_by("?") are the same.
 {{{
 def test_random_ordering(self):
 """
 Use '?' to order randomly.
 """
 articles = []
 # Iterate 10 times, items in result set shouldn't be all the same
 for _ in range(10):
 articles.append(list(Article.objects.order_by("?")))

 self.assertNotEqual(articles.count(articles[0]), 10)

 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018121d5328b-c33583b2-2f2b-4e86-b2c0-735f67d64766-00%40eu-central-1.amazonses.com.

Re: [Django] #33758: make_random_password does not comply with AUTH_PASSWORD_VALIDATORS

[Django]

#33758: make_random_password does not comply with AUTH_PASSWORD_VALIDATORS
---+--
 Reporter:  Javier Torres  |Owner:  Sosshi
 Type:  Uncategorized  |   Status:  assigned
Component:  Uncategorized  |  Version:  4.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Sosshi):

 * owner:  nobody => Sosshi
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701812155985f-55a1a6b3-639d-47a0-8025-f000a95e394b-00%40eu-central-1.amazonses.com.

[Django] #33761: Format migrations using black

[Django]

#33761: Format migrations using black
-+-
   Reporter:  Neil   |  Owner:  nobody
  Panchal|
   Type:  New| Status:  new
  feature|
  Component: |Version:  dev
  Migrations |   Keywords:  black, formatting,
   Severity:  Normal |  migrations
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Now that Django has adopted black as the source code formatter, are there
 any plans for formatting Django migrations with black?

 Everytime I run `makemigrations`, I have to manually format them with
 black. IMO, we should look at generating and formatting migrations using
 black.

 Thoughts?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181210f11e6-278c8366-9f7e-45b6-9591-41c2d089260a-00%40eu-central-1.amazonses.com.

[Django] #33760: Allow setting session cookie name dynamically

[Django]

#33760: Allow setting session cookie name dynamically
+
   Reporter:  Dan Strokirk  |  Owner:  nobody
   Type:  New feature   | Status:  new
  Component:  contrib.sessions  |Version:  4.1
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Currently it's only possible to use a single session cookie, but it can be
 useful in a multi-tenant application to use multiple session cookies.

 Adding a new `get_cookie_name` or `get_cookie_params` method to the
 `SessionMiddleware` class might be one way to implement this, which means
 that you can then then use your own subclassed middleware to override it.

 If this seems like a reasonable feature to add I'd be glad to supply a
 patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018120fbb9df-fe1158b5-874f-43d1-965f-140dd973cdf1-00%40eu-central-1.amazonses.com.

Re: [Django] #33759: Using subquery to filter a model delete generates a sub-optimal SQL

[Django]

#33759: Using subquery to filter a model delete generates a sub-optimal SQL
-+-
 Reporter:  Christofer Bertonha  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: Simon Charette (added)
 * type:  Bug => Cleanup/optimization


Comment:

 This behavior was changed in 4074f38e1dcc93b859bbbfd6abd8441c3bca36b3 to
 prevent:
 {{{
 django.db.utils.NotSupportedError: (1235, "This version of MySQL doesn't
 yet support 'LIMIT & IN/ALL/ANY/SOME subquery'")
 }}}
 on MySQL. I have no idea for an alternative fix.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018120abda41-4a817c59-609f-4ebe-8151-a4f9c5f7a074-00%40eu-central-1.amazonses.com.

Re: [Django] #33742: GeoJSON serializer doesn't provide a mechanism to include the ID of a feature

[Django]

#33742: GeoJSON serializer doesn't provide a mechanism to include the ID of a
feature
-+-
 Reporter:  Samir Shah   |Owner:  Samir Shah
 Type:  New feature  |   Status:  closed
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"6f73eb9d90cfec684529aab48d517e3d6449ba8c" 6f73eb9]:
 {{{
 #!CommitTicketReference repository=""
 revision="6f73eb9d90cfec684529aab48d517e3d6449ba8c"
 Fixed #33742 -- Added id to GeoJSON serializer.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181207c5975-3c3ab73a-ad28-4330-b511-f07e8f1c8419-00%40eu-central-1.amazonses.com.

Re: [Django] #33757: django.test.Client.post documentation is wrong

[Django]

#33757: django.test.Client.post documentation is wrong
+--
 Reporter:  bastian-wattro  |Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  Documentation   |  Version:  4.0
 Severity:  Normal  |   Resolution:  invalid
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--

Comment (by Tim Graham):

 The example in the documentation initializes a client `c = Client()` while
 the snippet here uses `self.client`. It might that the latter version has
 some state attached to it (like a login) which makes the difference, but
 it's impossible to debug without some minimal example code. Please include
 that in future reports (and first confirm a bug in Django using support
 channels).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701812043e62e-2bfaf196-dda3-4bfa-ae2b-9921b3866335-00%40eu-central-1.amazonses.com.

Re: [Django] #32234: inspectdb should inform about composite keys.

[Django]

#32234: inspectdb should inform about composite keys.
-+-
 Reporter:  Damien   |Owner:  Anvesh
 Type:   |  Mishra
  Cleanup/optimization   |   Status:  closed
Component:  Core (Management |  Version:  3.1
  commands)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"9a3b7e5e2be751d28b8782ad23a63e1c75f27e24" 9a3b7e5e]:
 {{{
 #!CommitTicketReference repository=""
 revision="9a3b7e5e2be751d28b8782ad23a63e1c75f27e24"
 Refs #32234 -- Removed hardcoded IntegerField in inspectdb test.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181203fd8b4-ae68fb83-a6dc-4902-ba6c-aa4ee0a8e5c2-00%40eu-central-1.amazonses.com.

Re: [Django] #33757: django.test.Client.post documentation is wrong

[Django]

#33757: django.test.Client.post documentation is wrong
+--
 Reporter:  bastian-wattro  |Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  Documentation   |  Version:  4.0
 Severity:  Normal  |   Resolution:  invalid
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Thanks for the report, however it works for me, see also
 
[https://github.com/django/django/blob/d5bc36203057627f6f7d0c6dc97b31adde6f4313/tests/file_uploads/tests.py#L86-L93
 tests].

 > What worked was the (way more intuitive) ...

 This snippet is exactly the same as the version you think is not working
 樂

 If you're having trouble understanding how Django works, see
 TicketClosingReasons/UseSupportChannels for ways to get help.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701812034f2a6-c7607a43-fe8b-4a61-b2c2-4e3440060617-00%40eu-central-1.amazonses.com.

Re: [Django] #33759: Using subquery to filter a model delete generates a sub-optimal SQL (was: Using subquery to filter a model delete creates sub-optimal SQL)

[Django]

#33759: Using subquery to filter a model delete generates a sub-optimal SQL
-+-
 Reporter:  bertonha |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181201b6cce-a87294d9-0c70-42f9-b075-673e5d0f31c0-00%40eu-central-1.amazonses.com.

Re: [Django] #33759: Using subquery to filter a model delete creates sub-optimal SQL

[Django]

#33759: Using subquery to filter a model delete creates sub-optimal SQL
-+-
 Reporter:  bertonha |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by bertonha:

Old description:

> Taking in consideration the app of tutorial for demonstrate the issue.
> using postgresql as db.
>
> Executing this following code:
>
> {{{
> subquery = Comment.objects.filter(created_at__lt=datetime(2022, 6,
> 1))[:1000]
> Comment.objects.filter(id__in=subquery).delete()
> }}}
>
> Generates the following SQL:
>
> {{{
> DELETE FROM "comment" WHERE "comment"."id" IN (SELECT V0."id" FROM
> "comment" V0 WHERE V0."id" IN (SELECT U0."id" FROM "comment" U0 WHERE
> U0."created_at" < \'2022-06-01T00:00:00+00:00\'::timestamptz LIMIT 1000))
> }}}
>
> The inner **select V0** is completely unnecessary
>
> If a simple select with the same subquery is executed. It generates
> expected SQL query.
>
> {{{
> subquery = Comment.objects.filter(created_at__lt=datetime(2022, 6,
> 1))[:1000]
> comments = list( Comment.objects..filter(id__in=subquery) )
> }}}
>
> {{{
> SELECT * FROM "comment" WHERE "comment"."id" IN (SELECT U0."id" FROM
> "comment" U0 WHERE U0."created_at" <
> '2022-06-01T00:00:00+00:00'::timestamptz LIMIT 1000),
> }}}

New description:

 Taking in consideration the app of tutorial for demonstrate the issue.
 using postgresql as db.

 Executing this following code:

 {{{
 subquery = Comment.objects.filter(created_at__lt=datetime(2022, 6,
 1))[:1000]
 Comment.objects.filter(id__in=subquery).delete()
 }}}

 Generates the following SQL:

 {{{
 DELETE FROM "comment" WHERE "comment"."id" IN (SELECT V0."id" FROM
 "comment" V0 WHERE V0."id" IN (SELECT U0."id" FROM "comment" U0 WHERE
 U0."created_at" < '2022-06-01T00:00:00+00:00'::timestamptz LIMIT 1000))
 }}}

 The inner **select V0** is completely unnecessary

 If a simple select with the same subquery is executed. It generates
 expected SQL query.

 {{{
 subquery = Comment.objects.filter(created_at__lt=datetime(2022, 6,
 1))[:1000]
 comments = list( Comment.objects..filter(id__in=subquery) )
 }}}

 {{{
 SELECT * FROM "comment" WHERE "comment"."id" IN (SELECT U0."id" FROM
 "comment" U0 WHERE U0."created_at" <
 '2022-06-01T00:00:00+00:00'::timestamptz LIMIT 1000),
 }}}

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181201ab895-736400ca-20b3-4d5a-8aab-d70dcfd9ad56-00%40eu-central-1.amazonses.com.

Re: [Django] #33759: Using subquery to filter a model delete creates sub-optimal SQL

[Django]

#33759: Using subquery to filter a model delete creates sub-optimal SQL
-+-
 Reporter:  Christofer Bertonha  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Christofer Bertonha:

Old description:

> Taking in consideration the app of tutorial for demonstrate the issue.
> using postgresql as db.
>
> Executing this following code:
>
> {{{
> subquery = Comment.objects.filter(created_at__lt=datetime(2022, 6,
> 1))[:1000]
> Comment.objects..filter(id__in=subquery).delete()
> }}}
>
> Generates the following SQL:
>
> {{{
> DELETE FROM "comment" WHERE "comment"."id" IN (SELECT V0."id" FROM
> "comment" V0 WHERE V0."id" IN (SELECT U0."id" FROM "comment" U0 WHERE
> U0."created_at" < \'2022-06-01T00:00:00+00:00\'::timestamptz LIMIT 1000))
> }}}
>
> The inner **select V0** is completely unnecessary
>
> If a simple select with the same subquery is executed. It generates
> expected SQL query.
>
> {{{
> subquery = Comment.objects.filter(created_at__lt=datetime(2022, 6,
> 1))[:1000]
> comments = list( Comment.objects..filter(id__in=subquery) )
> }}}
>
> {{{
> SELECT * FROM "comment" WHERE "comment"."id" IN (SELECT U0."id" FROM
> "comment" U0 WHERE U0."created_at" <
> '2022-06-01T00:00:00+00:00'::timestamptz LIMIT 1000),
> }}}

New description:

 Taking in consideration the app of tutorial for demonstrate the issue.
 using postgresql as db.

 Executing this following code:

 {{{
 subquery = Comment.objects.filter(created_at__lt=datetime(2022, 6,
 1))[:1000]
 Comment.objects.filter(id__in=subquery).delete()
 }}}

 Generates the following SQL:

 {{{
 DELETE FROM "comment" WHERE "comment"."id" IN (SELECT V0."id" FROM
 "comment" V0 WHERE V0."id" IN (SELECT U0."id" FROM "comment" U0 WHERE
 U0."created_at" < \'2022-06-01T00:00:00+00:00\'::timestamptz LIMIT 1000))
 }}}

 The inner **select V0** is completely unnecessary

 If a simple select with the same subquery is executed. It generates
 expected SQL query.

 {{{
 subquery = Comment.objects.filter(created_at__lt=datetime(2022, 6,
 1))[:1000]
 comments = list( Comment.objects..filter(id__in=subquery) )
 }}}

 {{{
 SELECT * FROM "comment" WHERE "comment"."id" IN (SELECT U0."id" FROM
 "comment" U0 WHERE U0."created_at" <
 '2022-06-01T00:00:00+00:00'::timestamptz LIMIT 1000),
 }}}

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181201a1f94-736391aa-819f-4c92-8a06-7972e6613ed3-00%40eu-central-1.amazonses.com.

[Django] #33759: Using subquery to filter a model delete creates sub-optimal SQL

[Django]

#33759: Using subquery to filter a model delete creates sub-optimal SQL
-+-
   Reporter: |  Owner:  nobody
  Christofer Bertonha|
   Type:  Bug| Status:  new
  Component:  Database   |Version:  4.0
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Taking in consideration the app of tutorial for demonstrate the issue.
 using postgresql as db.

 Executing this following code:

 {{{
 subquery = Comment.objects.filter(created_at__lt=datetime(2022, 6,
 1))[:1000]
 Comment.objects..filter(id__in=subquery).delete()
 }}}

 Generates the following SQL:

 {{{
 DELETE FROM "comment" WHERE "comment"."id" IN (SELECT V0."id" FROM
 "comment" V0 WHERE V0."id" IN (SELECT U0."id" FROM "comment" U0 WHERE
 U0."created_at" < \'2022-06-01T00:00:00+00:00\'::timestamptz LIMIT 1000))
 }}}

 The inner **select V0** is completely unnecessary

 If a simple select with the same subquery is executed. It generates
 expected SQL query.

 {{{
 subquery = Comment.objects.filter(created_at__lt=datetime(2022, 6,
 1))[:1000]
 comments = list( Comment.objects..filter(id__in=subquery) )
 }}}

 {{{
 SELECT * FROM "comment" WHERE "comment"."id" IN (SELECT U0."id" FROM
 "comment" U0 WHERE U0."created_at" <
 '2022-06-01T00:00:00+00:00'::timestamptz LIMIT 1000),
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701812011c549-75e673df-0e95-4682-bb6e-f65f77288826-00%40eu-central-1.amazonses.com.

Re: [Django] #28897: QuerySet.update() raises FieldError on queryset ordered by an annotated field.

[Django]

#28897: QuerySet.update() raises FieldError on queryset ordered by an annotated
field.
-+-
 Reporter:  Colton Hicks |Owner:  David
 |  Wobrock
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  Admin Interface, | Triage Stage:  Accepted
  Custom Action, Annotated Field,|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by David Wobrock):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018120064909-619a64d8-53fb-499f-886d-feb6337717ac-00%40eu-central-1.amazonses.com.

[Django] #33758: make_random_password does not comply with AUTH_PASSWORD_VALIDATORS

[Django]

#33758: make_random_password does not comply with AUTH_PASSWORD_VALIDATORS
-+
   Reporter:  Jacatove   |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Uncategorized  |Version:  4.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 The usage of
 {{{
 User.objects.make_random_password()
 }}}
 is limited since the generated passwords are not valid because they were
 created without meeting the validators criteria.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811fb6f651-5dee78c0-130e-407d-9cf8-7f5539e466c2-00%40eu-central-1.amazonses.com.

[Django] #33757: django.test.Client.post documentation is wrong

[Django]

#33757: django.test.Client.post documentation is wrong
--+
   Reporter:  bastian-wattro  |  Owner:  nobody
   Type:  Bug | Status:  new
  Component:  Documentation   |Version:  4.0
   Severity:  Normal  |   Keywords:
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+
 Following
 
[https://docs.djangoproject.com/en/4.0/topics/testing/tools/#django.test.Client.post]
 with Django version 4.0.4 to write my first unit tests, I failed to upload
 a file.

 As described there, I tried
 {{{#!python
 with open('mal.csv', 'rb') as fp:
   self.client.post('/post/endpoint/', {'name': 'fred', 'attachment': fp})
 }}}
 And assumed that (as described there)
 > The name attachment here is not relevant; use whatever name your file-
 processing code expects.

 This made the test fail. Printing request.FILES returned:
 `]}>`

 What worked was the (way more intuitive)
 {{{#!python
 with open('mal.csv', 'rb') as fp:
   self.client.post('/post/entpoint/', {'name': 'fred', 'attachment': fp})
 # ]}>
 }}}

 I did not check:
 *  since when the documentation is obsolete
 * if this is intended behavior

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811f836673-9cbaa6d3-4343-4031-b445-0284573d25f9-00%40eu-central-1.amazonses.com.

Re: [Django] #33742: GeoJSON serializer doesn't provide a mechanism to include the ID of a feature

[Django]

#33742: GeoJSON serializer doesn't provide a mechanism to include the ID of a
feature
-+-
 Reporter:  Samir Shah   |Owner:  Samir Shah
 Type:  New feature  |   Status:  assigned
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811effe2a0-2e9cde71-8ce9-409f-a07b-27cbeb47f3ae-00%40eu-central-1.amazonses.com.

Re: [Django] #33753: Docs' Makefile doesn't support Sphinx 5+.

[Django]

#33753: Docs' Makefile doesn't support Sphinx 5+.
-+-
 Reporter:  Doug Hellmann|Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"a23c25d84a5b3d8f49edf53d329f565afcbfa1b9" a23c25d8]:
 {{{
 #!CommitTicketReference repository=""
 revision="a23c25d84a5b3d8f49edf53d329f565afcbfa1b9"
 [3.2.x] Fixed #33753 -- Fixed docs build on Sphinx 5+.

 Empty language is not supported anymore.
 Backport of 565ad5ace46aa1e2368450701cba45dd1a95a026 from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811ec3c45c-052506f4-b251-4b49-845a-8e5a59a2de64-00%40eu-central-1.amazonses.com.

Re: [Django] #33753: Docs' Makefile doesn't support Sphinx 5+.

[Django]

#33753: Docs' Makefile doesn't support Sphinx 5+.
-+-
 Reporter:  Doug Hellmann|Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"bc38eafc610b30cfce40859190c24e295baa9a4b" bc38eafc]:
 {{{
 #!CommitTicketReference repository=""
 revision="bc38eafc610b30cfce40859190c24e295baa9a4b"
 [4.0.x] Fixed #33753 -- Fixed docs build on Sphinx 5+.

 Empty language is not supported anymore.
 Backport of 565ad5ace46aa1e2368450701cba45dd1a95a026 from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811ec36be0-5bb66189-58d1-4c9d-8af5-72e1db357eed-00%40eu-central-1.amazonses.com.

Re: [Django] #33753: Docs' Makefile doesn't support Sphinx 5+.

[Django]

#33753: Docs' Makefile doesn't support Sphinx 5+.
-+-
 Reporter:  Doug Hellmann|Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"007a21b57696308f812a3249194fa815773c7c11" 007a21b5]:
 {{{
 #!CommitTicketReference repository=""
 revision="007a21b57696308f812a3249194fa815773c7c11"
 [4.1.x] Fixed #33753 -- Fixed docs build on Sphinx 5+.

 Empty language is not supported anymore.
 Backport of 565ad5ace46aa1e2368450701cba45dd1a95a026 from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811ec23107-11f6f588-4988-42a2-9a6b-5d861b7ac9e2-00%40eu-central-1.amazonses.com.

Re: [Django] #33753: Docs' Makefile doesn't support Sphinx 5+.

[Django]

#33753: Docs' Makefile doesn't support Sphinx 5+.
-+-
 Reporter:  Doug Hellmann|Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"565ad5ace46aa1e2368450701cba45dd1a95a026" 565ad5ac]:
 {{{
 #!CommitTicketReference repository=""
 revision="565ad5ace46aa1e2368450701cba45dd1a95a026"
 Fixed #33753 -- Fixed docs build on Sphinx 5+.

 Empty language is not supported anymore.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811ec1964c-372cef49-7575-4e30-8385-67e24c17cda9-00%40eu-central-1.amazonses.com.

Re: [Django] #27207: Replace with tag in admin templates

[Django]

#27207: Replace  with  tag in admin templates
--+
 Reporter:  Tim Graham|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  contrib.admin |  Version:  dev
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by GitHub ):

 In [changeset:"f3e2bb0833105f43efc0cc6f19c8465bc1b1a785" f3e2bb0]:
 {{{
 #!CommitTicketReference repository=""
 revision="f3e2bb0833105f43efc0cc6f19c8465bc1b1a785"
 Fixed #33750 -- Fixed timezone warning alignment with help texts.

 Previously help_text was wrapped in a paragraph, but the change to div
 broke the alignment, refs #27207.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811ea4aa11-872a0123-ee29-4895-9055-ab4a8769c953-00%40eu-central-1.amazonses.com.

Re: [Django] #33750: Use for timezone warning in admin

[Django]

#33750: Use  for timezone warning in admin
-+-
 Reporter:  Florian Demmer   |Owner:  Florian
 Type:   |  Demmer
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"f3e2bb0833105f43efc0cc6f19c8465bc1b1a785" f3e2bb0]:
 {{{
 #!CommitTicketReference repository=""
 revision="f3e2bb0833105f43efc0cc6f19c8465bc1b1a785"
 Fixed #33750 -- Fixed timezone warning alignment with help texts.

 Previously help_text was wrapped in a paragraph, but the change to div
 broke the alignment, refs #27207.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811ea4a9dc-691943bc-f29a-499b-96ce-f14ae4f4ae39-00%40eu-central-1.amazonses.com.

Re: [Django] #33750: Use for timezone warning in admin

[Django]

#33750: Use  for timezone warning in admin
-+-
 Reporter:  Florian Demmer   |Owner:  Florian
 Type:   |  Demmer
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Florian Demmer
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811e919853-448be518-e28b-47c8-b89b-ed3d1899f48d-00%40eu-central-1.amazonses.com.

Re: [Django] #33733: inspect.signature() returns incorrect signature on manager methods.

[Django]

#33733: inspect.signature() returns incorrect signature on manager methods.
-+-
 Reporter:  Shiva Kumar  |Owner:  Shiva
 Type:   |  Kumar
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"0982cf2a013be291356758a5577ecb3c9f047ba0" 0982cf2a]:
 {{{
 #!CommitTicketReference repository=""
 revision="0982cf2a013be291356758a5577ecb3c9f047ba0"
 Refs #33733 -- Added tests for attributes of manager methods.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811e90f99d-ab67057b-bec0-4185-b577-aafefdd9c938-00%40eu-central-1.amazonses.com.

Re: [Django] #33733: inspect.signature() returns incorrect signature on manager methods.

[Django]

#33733: inspect.signature() returns incorrect signature on manager methods.
-+-
 Reporter:  Shiva Kumar  |Owner:  Shiva
 Type:   |  Kumar
  Cleanup/optimization   |   Status:  closed
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"46efd03d2674084051f7ce04006e95520649a1ac" 46efd03d]:
 {{{
 #!CommitTicketReference repository=""
 revision="46efd03d2674084051f7ce04006e95520649a1ac"
 Fixed #33733 -- Preserved wrapper assignment for manager methods.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811e90f9f1-2708fe84-209c-4d54-a9d8-03fd5a59cb47-00%40eu-central-1.amazonses.com.

Re: [Django] #33733: inspect.signature() returns incorrect signature on manager methods.

[Django]

#33733: inspect.signature() returns incorrect signature on manager methods.
-+-
 Reporter:  Shiva Kumar  |Owner:  Shiva
 Type:   |  Kumar
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811e7182a8-fc21e26a-8598-4819-a061-08780edb02d0-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
-+-
 Reporter:  Carlton Gibson   |Owner:  Mehrdad
 Type:   |  Moradizadeh
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"2f974e3c1e8c2a74114b1e9f0e8257743c4d472c" 2f974e3]:
 {{{
 #!CommitTicketReference repository=""
 revision="2f974e3c1e8c2a74114b1e9f0e8257743c4d472c"
 [4.1.x] Refs #33697 -- Fixed multipart parsing of headers with double
 quotes and semicolons.

 See
 
https://github.com/python/cpython/commit/1ef0c0349e8fdb5415e21231cb42edbf232b742a

 Backport of 93cedc82f29076c824d476354527af1150888e4f from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811e6fbcd0-b6afd17b-e3e7-44d3-a268-43f588ae3003-00%40eu-central-1.amazonses.com.

Re: [Django] #33697: Cleanup duplication of HTTP header parsing in utils.http and multipart parser.

[Django]

#33697: Cleanup duplication of HTTP header parsing in utils.http and multipart
parser.
-+-
 Reporter:  Carlton Gibson   |Owner:  Mehrdad
 Type:   |  Moradizadeh
  Cleanup/optimization   |   Status:  assigned
Component:  Utilities|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"93cedc82f29076c824d476354527af1150888e4f" 93cedc8]:
 {{{
 #!CommitTicketReference repository=""
 revision="93cedc82f29076c824d476354527af1150888e4f"
 Refs #33697 -- Fixed multipart parsing of headers with double quotes and
 semicolons.

 See
 
https://github.com/python/cpython/commit/1ef0c0349e8fdb5415e21231cb42edbf232b742a
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811e6fbb5a-c0aa2a34-613a-493d-a921-a567504d995a-00%40eu-central-1.amazonses.com.

Re: [Django] #32234: inspectdb should inform about composite keys.

[Django]

#32234: inspectdb should inform about composite keys.
-+-
 Reporter:  Damien   |Owner:  Anvesh
 Type:   |  Mishra
  Cleanup/optimization   |   Status:  closed
Component:  Core (Management |  Version:  3.1
  commands)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"295249c901e13ec1703ada5c414cd97aba72f3e9" 295249c]:
 {{{
 #!CommitTicketReference repository=""
 revision="295249c901e13ec1703ada5c414cd97aba72f3e9"
 Fixed #32234 -- Made inspectdb inform about composite primary keys.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811e51a860-d7a3acb4-cd45-4920-8df5-3b366f293b77-00%40eu-central-1.amazonses.com.

Re: [Django] #28897: QuerySet.update() raises FieldError on queryset ordered by an annotated field.

[Django]

#28897: QuerySet.update() raises FieldError on queryset ordered by an annotated
field.
-+-
 Reporter:  Colton Hicks |Owner:  David
 |  Wobrock
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  Admin Interface, | Triage Stage:  Accepted
  Custom Action, Annotated Field,|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by David Wobrock):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811e356a3f-62e78b2a-7674-4902-a777-a44c0addbe59-00%40eu-central-1.amazonses.com.

Re: [Django] #32234: inspectdb should inform about composite keys.

[Django]

#32234: inspectdb should inform about composite keys.
-+-
 Reporter:  Damien   |Owner:  Anvesh
 Type:   |  Mishra
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Management |  Version:  3.1
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin
 * needs_tests:  1 => 0
 * needs_docs:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701811e0016a4-1c60bf5e-2a18-4eb6-8788-f9e5bc7b34c3-00%40eu-central-1.amazonses.com.