Re: [Django] #27236: Deprecate Model.Meta.index_together in favour of Model.Meta.indexes

[Django]

#27236: Deprecate Model.Meta.index_together in favour of Model.Meta.indexes
-+-
 Reporter:  Akshesh Doshi|Owner:  David
 Type:   |  Wobrock
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  index_together   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"57793b47657ace966ce8ce96d801ac0d85e5efc6" 57793b47]:
 {{{
 #!CommitTicketReference repository=""
 revision="57793b47657ace966ce8ce96d801ac0d85e5efc6"
 Refs #27236 -- Refactored out DeprecationForHistoricalMigrationMixin.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181dc5fb8cf-a4a898a1-5e04-49c2-8ce9-2b614ff72d29-00%40eu-central-1.amazonses.com.

Re: [Django] #27236: Deprecate Model.Meta.index_together in favour of Model.Meta.indexes

[Django]

#27236: Deprecate Model.Meta.index_together in favour of Model.Meta.indexes
-+-
 Reporter:  Akshesh Doshi|Owner:  David
 Type:   |  Wobrock
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  index_together   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"41019e48bbf082c985e6ba3bad34d118b903bff1" 41019e48]:
 {{{
 #!CommitTicketReference repository=""
 revision="41019e48bbf082c985e6ba3bad34d118b903bff1"
 Refs #27236 -- Added generic mechanism to handle the deprecation of
 migration operations.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181dc5fb8f8-857ff4a9-954f-47a8-9338-9dd0e4ece4fd-00%40eu-central-1.amazonses.com.

Re: [Django] #33832: Support M2M validation using signals

[Django]

#33832: Support M2M validation using signals
-+-
 Reporter:  ldeluigi |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:  invalid
 Keywords:  validation m2m   | Triage Stage:
  signal manytomany  |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => invalid
 * component:  Uncategorized => contrib.admin


Comment:

 Thanks for the ticket, however `IntegrityError`s are not masked anywhere
 in the admin and they shouldn't be. Moreover, signals are the last resort
 and could probably be avoided in you case. Please see
 TicketClosingReasons/UseSupportChannels for ways to get help with Django
 usage, because it's a support request as it stands.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181dc0d1dd5-1ae5ddae-67d3-4ee5-ac6e-b9286ee4fdd0-00%40eu-central-1.amazonses.com.

Re: [Django] #33833: Close button styling issues in admin forms’ submit row

[Django]

#33833: Close button styling issues in admin forms’ submit row
---+
 Reporter:  Thibaud Colas  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  4.0
 Severity:  Normal |   Resolution:
 Keywords:  button, focus  | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the report.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181dc02dfd2-bc9eeb2a-f16b-4182-bd8b-48894b5e3701-00%40eu-central-1.amazonses.com.

Re: [Django] #33833: Close button styling issues in admin forms’ submit row

[Django]

#33833: Close button styling issues in admin forms’ submit row
---+--
 Reporter:  Thibaud Colas  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  4.0
 Severity:  Normal |   Resolution:
 Keywords:  button, focus  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Description changed by Thibaud Colas:

Old description:

> Picked up as part of reviewing #33728 /
> [https://github.com/django/django/pull/15734 PR #15734] – in the admin’s
> `submit_line.html` / `submit-row`, the Close button is misaligned:
>
>  And it has an unexpected underline on focus:
>

>
> The misalignment & other spacing issues are particularly visible when
> there are multiple buttons displayed, though it’s not clear to me whether
> this actually happens in practice:
>

> ---
>
> To reproduce this, access a model form with a user who only has "View"
> permissions.

New description:

 Picked up as part of reviewing #33728 /
 [https://github.com/django/django/pull/15734 PR #15734] – in the admin’s
 `submit_line.html` / `submit-row`, the Close button is misaligned:

 [[Image(https://code.djangoproject.com/raw-attachment/ticket/33833/close-
 button-admin.png)]]

 And it has an unexpected underline on focus:

 [[Image(https://code.djangoproject.com/raw-attachment/ticket/33833/close-
 button-focus.png)]]

 The misalignment & other spacing issues are particularly visible when
 there are multiple buttons displayed, though it’s not clear to me whether
 this actually happens in practice:

 [[Image(https://code.djangoproject.com/raw-attachment/ticket/33833/close-
 button-group.png)]]

 This is also the case when buttons are displayed vertically in the
 "mobile" viewports.

 ---

 To reproduce this, access a model form with a user who only has "View"
 permissions.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181db736ae7-2db5eff8-5f2d-4bef-abdb-4db65f9e2a53-00%40eu-central-1.amazonses.com.

Re: [Django] #33833: Close button styling issues in admin forms’ submit row

[Django]

#33833: Close button styling issues in admin forms’ submit row
---+--
 Reporter:  Thibaud Colas  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  4.0
 Severity:  Normal |   Resolution:
 Keywords:  button, focus  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by Thibaud Colas):

 * Attachment "close-button-group.png" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181db71fe00-b99a8f13-b73a-4afb-a95b-4bd78fcc74f9-00%40eu-central-1.amazonses.com.

Re: [Django] #33833: Close button styling issues in admin forms’ submit row

[Django]

#33833: Close button styling issues in admin forms’ submit row
---+--
 Reporter:  Thibaud Colas  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  4.0
 Severity:  Normal |   Resolution:
 Keywords:  button, focus  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by Thibaud Colas):

 * Attachment "close-button-focus.png" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181db715d5b-07571245-2ddd-4fb9-b7b6-e63b554f85a0-00%40eu-central-1.amazonses.com.

Re: [Django] #33833: Close button styling issues in admin forms’ submit row

[Django]

#33833: Close button styling issues in admin forms’ submit row
---+--
 Reporter:  Thibaud Colas  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  4.0
 Severity:  Normal |   Resolution:
 Keywords:  button, focus  | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by Thibaud Colas):

 * Attachment "close-button-admin.png" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181db713ace-b1741e74-8358-45d3-89d2-2205ac1b34cd-00%40eu-central-1.amazonses.com.

[Django] #33833: Close button styling issues in admin forms’ submit row

[Django]

#33833: Close button styling issues in admin forms’ submit row
-+---
   Reporter:  Thibaud Colas  |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  contrib.admin  |Version:  4.0
   Severity:  Normal |   Keywords:  button, focus
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  1  |
-+---
 Picked up as part of reviewing #33728 /
 [https://github.com/django/django/pull/15734 PR #15734] – in the admin’s
 `submit_line.html` / `submit-row`, the Close button is misaligned:

  And it has an unexpected underline on focus:



 The misalignment & other spacing issues are particularly visible when
 there are multiple buttons displayed, though it’s not clear to me whether
 this actually happens in practice:


 ---

 To reproduce this, access a model form with a user who only has "View"
 permissions.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181db70cd87-e0cbcd29-2062-48d0-a872-a9a3465e7a55-00%40eu-central-1.amazonses.com.

Re: [Django] #33768: MySQL ordering of nulls last/first is broken in combination with UNION

[Django]

#33768: MySQL ordering of nulls last/first is broken in combination with UNION
-+-
 Reporter:  Florian Apolloner|Owner:  Aniruddh
 |  Singh
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette):

 Submitted a [https://github.com/django/django/pull/15831 PR] for further
 discussion on the subject.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d8ec1190-6fdd61e7-bfc7-46bc-9e54-2fd3c70eee3b-00%40eu-central-1.amazonses.com.

Re: [Django] #33829: BaseConstraint.deconstruct() and __eq__ operators don't take violation_error_message into account.

[Django]

#33829: BaseConstraint.deconstruct() and __eq__ operators don't take
violation_error_message into account.
-+-
 Reporter:  Mariusz Felisiak |Owner:  twidi
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.1
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by twidi):

 Here is the [https://github.com/django/django/pull/15828 Pull request]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d8a7a152-37ca5617-1cae-4ced-a1f3-d3b9474abaa2-00%40eu-central-1.amazonses.com.

[Django] #33832: Support M2M validation using signals

[Django]

#33832: Support M2M validation using signals
-+-
   Reporter:  ldeluigi   |  Owner:  nobody
   Type:  New| Status:  new
  feature|
  Component: |Version:  4.0
  Uncategorized  |   Keywords:  validation m2m
   Severity:  Normal |  signal manytomany
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 MyModel has one ManyToManyField that links to AnotherModel.


 For validation purposes I need to check the model after m2m relationships
 have been set with custom logic based on the db (I can't check it before
 m2m fields are populated)


 At the moment, I'm raising ValidationError inside a signal receiver:

 {{{
 @receiver(m2m_changed, sender=MyModel.relationship.through)
 def validator_from_signal(sender, instance, action, reverse, model,
 **kwargs):
 if action == 'post_add':
 if reverse and not check_reverse(instance):
 msg = f'AnotherModel {instance.id} violates validation
 checks.'
 logging.error(msg)
 raise ValidationError(msg)
 elif not reverse and not check(instance):
 msg = f'MyModel {instance.id} violates validation checks.'
 logging.error(msg)
 raise ValidationError(msg)
 }}}



 It works, thanks to the transaction behaviour which in case of exception
 rollbacks everything, but if the user submits a wrong MyModel or
 AnotherModel (because of ManyToMany illegal relationships), in particular
 with the Admin Form, they get a 500 internal server error. Which isn't
 very user friendly...


 I know this is the expected behaviour, but I'd like the Admin form to
 handle ValidationError(s) and/or IntegrityError(s) from signal as normal
 ValidationError. I can't implement this check inside the clean() method:
 1. because m2m fields are not populated on the database at that stage
 2. because it would only work for the admin form

 What do you think?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d8a53344-967d4cf9-fc62-4476-bebd-d624eddf6f3a-00%40eu-central-1.amazonses.com.

Re: [Django] #24731: ManyToMany model clean validation of related fields

[Django]

#24731: ManyToMany model clean validation of related fields
-+-
 Reporter:  blah73   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  ManyToMany clean | Triage Stage:
  validation |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by ldeluigi):

 I'd put a catch for ValidationError or IntegrityError inside the
 save_form_data method that would catch signals that throw them, for
 example the m2m_changed 'post_add'

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d89d48e0-a5173e53-5af5-4810-a59f-485a338329a4-00%40eu-central-1.amazonses.com.

Re: [Django] #33825: Stop allowing 'django.db.backends.postgresql_psycopg2' in DATABASES

[Django]

#33825: Stop allowing 'django.db.backends.postgresql_psycopg2' in DATABASES
-+-
 Reporter:  Maxim Danilov|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  db.backend   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Maxim Danilov):

 Replying to [comment:2 Carlton Gibson]:
 > OK, I'm going to say `wontfix` for now. I don't see the value of the
 disruption — I suspect a lot of people would need to update their settings
 if we removed the shim. That seems needlessly disruptive.
 >
 > Happy if someone wants to argue differently. (I'm a bit -0)
 >
 > I think reviewing this again for cleanup as a part of #33308 makes
 sense. (When adding Psycopg3 there's some gain to pay for the disruption
 so... 路‍♀️)

 if you suspect "a lot of people would need to update their settings if we
 removed the shim" - probably we can add warning in backend:

 {{{
 if backend_name == "django.db.backends.postgresql_psycopg2":
 # here we can put output warning for wrong named backend
 backend_name = "django.db.backends.postgresql"
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d88f1a2b-0a2ef995-8d07-4f22-842c-aa90cf722648-00%40eu-central-1.amazonses.com.

Re: [Django] #33831: How can I create model without primary_key

[Django]

#33831: How can I create model without primary_key
-+-
 Reporter:  007  |Owner:  nobody
 Type:  Uncategorized|   Status:  closed
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Please don't use Trac as a support channel. Closing per
 TicketClosingReasons/UseSupportChannels.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d87af1a9-de552a34-352a-4ca7-a9d0-b3bff3a5e02c-00%40eu-central-1.amazonses.com.

[Django] #33831: How can I create model without primary_key

[Django]

#33831: How can I create model without primary_key
-+-
   Reporter:  007|  Owner:  nobody
   Type: | Status:  new
  Uncategorized  |
  Component:  Database   |Version:  4.0
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 I have two models:
 {{{
 class Info(models.Model):
 name = models.CharField(verbose_name='name', max_length=128)

 class Meta:
 verbose_name = verbose_name_plural = "name"


 class Version(models.Model):
 id = None
 info = models.ForeignKey(Info, on_delete=models.DO_NOTHING,
 db_constraint=False)
 version = models.CharField(verbose_name='version number',
 max_length=128)

 class Meta:
 unique_together = ('version', 'info')
 verbose_name = verbose_name_plural = "name"
 }}}
 I want to add mysql PARTITION  to version.
 PARTITION  KEY must be included by all unique indexes.
 so I want to remove id like

 {{{
 CREATE TABLE `version` (
   `version` varchar(128) CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci
 NOT NULL,
   `package_id` bigint NOT NULL,
   UNIQUE KEY `version_version_package_id_fc0eb1b8_uniq`
 (`version`,`package_id`),
   KEY `version_package_id_2d2bab67` (`package_id`)
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci
 /*!50100 PARTITION BY KEY (package_id)
 PARTITIONS 32 */
 }}}
 How can I modify models to meet my needs

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d866ce89-32ad1dcf-62c6-4b39-9741-102e51db035d-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Horst Schneider):

 Replying to [comment:4 Carlton Gibson]:
 > Either that or we'd need a fix to #28172 maybe? See also #28526 — I
 wonder if there isn't a cluster of duplicates here? 樂

 Not really duplicates, right? #28172 seems to be a very specific different
 issue with filters and #28526 addresses the whole concept of logging
 missing template variables in such a verbose fashion.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d8362837-c27e49ba-b870-4a74-a69f-ebb98c457270-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Horst Schneider):

 Replying to [comment:5 Carlton Gibson]:
 > @Horst could you investigate setting a default (`False`) for disabled in
 ClearableFileInput for this case?

 Setting it both to `True` or `False` explicitly in the `attrs` does not
 trigger the `VariableDoesNotExist` exception to be logged. Only the
 absence of the `disabled` attribute on the `attrs` altogether triggers it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d8318dd7-35552674-bccd-4b91-819f-d0b08fe85236-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Carlton Gibson):

 @Horst could you investigate setting a default (`False`) for disabled in
 ClearableFileInput for this case?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d80fc3d1-dcc15aaf-c311-4bf0-8dcc-04b2869d4287-00%40eu-central-1.amazonses.com.

Re: [Django] #33781: Timezone warning visual regression.

[Django]

#33781: Timezone warning visual regression.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Carlton
 |  Gibson
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  dev
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Carlton Gibson ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"6f80050496780e2f8a65e2a4374dd6375c9fbfa5" 6f80050]:
 {{{
 #!CommitTicketReference repository=""
 revision="6f80050496780e2f8a65e2a4374dd6375c9fbfa5"
 Fixed #33781 -- Restored alignment for admin split-field timezone
 warnings.

 Regression in f3e2bb0833105f43efc0cc6f19c8465bc1b1a785.
 Refs #33750 and #27207.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d8014b24-7a939e5e-ac2d-432d-a7f3-e5afc56add4f-00%40eu-central-1.amazonses.com.

Re: [Django] #33750: Use for timezone warning in admin

[Django]

#33750: Use  for timezone warning in admin
-+-
 Reporter:  Florian Demmer   |Owner:  Florian
 Type:   |  Demmer
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by Carlton Gibson ):

 In [changeset:"6f80050496780e2f8a65e2a4374dd6375c9fbfa5" 6f80050]:
 {{{
 #!CommitTicketReference repository=""
 revision="6f80050496780e2f8a65e2a4374dd6375c9fbfa5"
 Fixed #33781 -- Restored alignment for admin split-field timezone
 warnings.

 Regression in f3e2bb0833105f43efc0cc6f19c8465bc1b1a785.
 Refs #33750 and #27207.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d8014b44-72444259-5488-4b78-aa14-d3138044318b-00%40eu-central-1.amazonses.com.

Re: [Django] #27207: Replace with tag in admin templates

[Django]

#27207: Replace  with  tag in admin templates
--+
 Reporter:  Tim Graham|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  contrib.admin |  Version:  dev
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Carlton Gibson ):

 In [changeset:"6f80050496780e2f8a65e2a4374dd6375c9fbfa5" 6f80050]:
 {{{
 #!CommitTicketReference repository=""
 revision="6f80050496780e2f8a65e2a4374dd6375c9fbfa5"
 Fixed #33781 -- Restored alignment for admin split-field timezone
 warnings.

 Regression in f3e2bb0833105f43efc0cc6f19c8465bc1b1a785.
 Refs #33750 and #27207.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d8014b75-ad7900ed-7193-4b84-8c2e-f0d33cfcf4c4-00%40eu-central-1.amazonses.com.

Re: [Django] #33781: Timezone warning visual regression.

[Django]

#33781: Timezone warning visual regression.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Carlton
 |  Gibson
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d7f2fef5-9fb6b937-3f18-403b-a0e5-045b82a420b2-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Carlton Gibson):

 Either that or we'd need a fix to #28172 maybe? See also #28526 — I wonder
 if there isn't a cluster of duplicates here? 樂

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d7f1ab01-1e595a4e-1ad5-4723-8bc9-1b7e601a9162-00%40eu-central-1.amazonses.com.

Re: [Django] #33781: Timezone warning visual regression.

[Django]

#33781: Timezone warning visual regression.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Carlton
 |  Gibson
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Carlton Gibson):

 * owner:  Yahya Ali => Carlton Gibson
 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/15830 PR] adjusting the CSS.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d7e23a51-2e43bae2-8871-4cd8-a59e-1c8e99bfa804-00%40eu-central-1.amazonses.com.

Re: [Django] #33718: Drop support for MySQL 5.7.

[Django]

#33718: Drop support for MySQL 5.7.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Mariusz
 Type:   |  Felisiak
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  0 => 1
 * version:  4.0 => dev


Comment:

 [https://github.com/django/django/pull/15829 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d7cd9b22-28be5557-d036-488d-baef-b46794b9d26d-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Horst Schneider):

 Although the problem is similar, the fix must be different here. We can
 not easily supply some default context from the outside here since the
 missing variable is in the `attrs` attribute of the checkbox widget.

 It is guaranteed by the base `Widget` that `attrs` will always be a `dict
 ` instance. But it is **not** guaranteed that the key `disabled` will
 always be present on the `attrs`, so we will mostly find it to be either
 missing or set to `True` (could as well be set to `False`, if the default
 is explicitly stated).

 I guess a proper fix would be something along the lines of

 {{{
 
 }}}

 (First checking if key is present, then checking its truthiness).

 Or is there a more idiomatic way to perform those checks?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d7c5bbac-7427a0f2-c46a-4562-91de-d867829e20a4-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Mariusz Felisiak):

 * type:  Uncategorized => Bug


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d7b086c8-4253bfb8-a89a-4109-b169-7195821d87f9-00%40eu-central-1.amazonses.com.

Re: [Django] #33825: Stop allowing 'django.db.backends.postgresql_psycopg2' in DATABASES

[Django]

#33825: Stop allowing 'django.db.backends.postgresql_psycopg2' in DATABASES
-+-
 Reporter:  Maxim Danilov|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  db.backend   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 OK, I'm going to say `wontfix` for now. I don't see the value of the
 disruption — I suspect a lot of people would need to update their settings
 if we removed the shim. That seems needlessly disruptive.

 Happy if someone wants to argue differently. (I'm a bit -0)

 I think reviewing this again for cleanup as a part of #33308 makes sense.
 (When adding Psycopg3 there's some gain to pay for the disruption so...
 路‍♀️)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d7a63f45-38b724d7-c48a-4544-89ce-cc214bfe371a-00%40eu-central-1.amazonses.com.

Re: [Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+
 Reporter:  Horst Schneider  |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  admin, template  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


Comment:

 OK, yes — a fix to suppress that, similar to #32681 would be welcome.
 Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d79b00b2-05981337-5278-48b7-a704-3c1fdc4d0086-00%40eu-central-1.amazonses.com.

[Django] #33830: Variable lookup errors are logged rendering 'clearable_file_input.html'

[Django]

#33830: Variable lookup errors are logged rendering 'clearable_file_input.html'
-+-
   Reporter:  Horst  |  Owner:  nobody
  Schneider  |
   Type: | Status:  new
  Uncategorized  |
  Component: |Version:  4.0
  contrib.admin  |
   Severity:  Normal |   Keywords:  admin, template
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 It seems like the fix to #31536 raised a problem similar to #32681: Not
 checking whether the `disabled` attribute actually exists on the `attrs`
 of the 'clear' checkbox widget causes a `VariableDoesNotExist` exception
 to be logged every time one of the patched `clearable_file_input.html`
 templates is rendered with a checkbox that has no `disabled` atrribute
 (i.e. is enabled):

 {{{
 [2022-07-06 10:06:03,452] DEBUG django.template base: Exception while
 resolving variable 'disabled' in template
 'admin/widgets/clearable_file_input.html'.
 Traceback (most recent call last):
   File "/home/horst/some_project/venv/lib/python3.10/site-
 packages/django/template/base.py", line 875, in _resolve_lookup
 current = current[bit]
 KeyError: 'disabled'

 During handling of the above exception, another exception occurred:

 Traceback (most recent call last):
   File "/home/horst/some_project/venv/lib/python3.10/site-
 packages/django/template/base.py", line 885, in _resolve_lookup
 current = getattr(current, bit)
 AttributeError: 'dict' object has no attribute 'disabled'

 During handling of the above exception, another exception occurred:

 Traceback (most recent call last):
   File "/home/horst/some_project/venv/lib/python3.10/site-
 packages/django/template/base.py", line 891, in _resolve_lookup
 current = current[int(bit)]
 ValueError: invalid literal for int() with base 10: 'disabled'

 During handling of the above exception, another exception occurred:

 Traceback (most recent call last):
   File "/home/horst/some_project/venv/lib/python3.10/site-
 packages/django/template/base.py", line 898, in _resolve_lookup
 raise VariableDoesNotExist(
 django.template.base.VariableDoesNotExist: Failed lookup for key
 [disabled] in {'id': 'id_document'}
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070181d7967486-04ce8b4a-36f3-4f84-ad74-a2abb73b0e9c-00%40eu-central-1.amazonses.com.