Re: [Django] #34170: Mitigate the BREACH attack

[Django]

#34170: Mitigate the BREACH attack
-+-
 Reporter:  Andreas Pelme|Owner:  Andreas
 |  Pelme
 Type:  New feature  |   Status:  assigned
Component:  HTTP handling|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  breach, htb, gzip| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Andreas Pelme):

 * needs_docs:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184adcc61f3-a3acca1b-28e7-446d-a921-12643ab34c55-00%40eu-central-1.amazonses.com.

Re: [Django] #33747: Display exception notes on the technical 500 debug page on Python 3.11+.

[Django]

#33747: Display exception notes on the technical 500 debug page on Python 3.11+.
-+-
 Reporter:  Adam Johnson |Owner:  Giebisch
 Type:  New feature  |   Status:  assigned
Component:  Error reporting  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184ada64088-635fa01d-065e-4d92-aff9-aaa29fb986c1-00%40eu-central-1.amazonses.com.

Re: [Django] #34182: Is there a reason only the headers are checked when using the csrf token?

[Django]

#34182: Is there a reason only the headers are checked when using the csrf 
token?
--+--
 Reporter:  Joon Hwan 김준환  |Owner:  nobody
 Type:  New feature   |   Status:  closed
Component:  CSRF  |  Version:  dev
 Severity:  Normal|   Resolution:  invalid
 Keywords:  csrf, cookie  | Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Mariusz Felisiak):

 * cc: Florian Apolloner (added)
 * status:  new => closed
 * resolution:   => invalid


Comment:

 As far as I'm aware, using only the cookie, is not sufficient. Quoting
 [https://code.djangoproject.com/ticket/23040#comment:1 Florian]: ''"Django
 compares the token from the cookie (which an attacker can't control) to
 the header/post-data which the attacker can control. Hence you will always
 need the cookie and the header or post-data."''

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184ad2b1c79-a1ef8aec-a72a-4eb4-8a72-00db577c42c8-00%40eu-central-1.amazonses.com.

Re: [Django] #29802: Allow skipping CSRF check for Referer header

[Django]

#29802: Allow skipping CSRF check for Referer header
-+-
 Reporter:  Aaron Hill   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  CSRF |  Version:  2.1
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
  csrf,https,hsts,referer|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => wontfix
 * stage:  Someday/Maybe => Unreviewed


Comment:

 Please first start a discussion on the DevelopersMailingList, where you'll
 reach a wider audience and see what other think, and
 [https://docs.djangoproject.com/en/stable/internals/contributing/bugs-and-
 features/#requesting-features follow the guidelines with regards to
 requesting features]. Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184ad1a134a-3f473932-b0c7-439d-a875-7cf01cd2e58a-00%40eu-central-1.amazonses.com.

Re: [Django] #34176: Annotation's original field-name can clash with result field name over aggregation

[Django]

#34176: Annotation's original field-name can clash with result field name over
aggregation
-+-
 Reporter:  Shai Berger  |Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184ad0f2fd7-537c8425-2646-42c1-aaae-48bde663fbe9-00%40eu-central-1.amazonses.com.

[Django] #34182: Is there a reason only the headers are checked when using the csrf token?

[Django]

#34182: Is there a reason only the headers are checked when using the csrf 
token?
+--
   Reporter:  Joon Hwan 김준환  |  Owner:  nobody
   Type:  New feature   | Status:  new
  Component:  CSRF  |Version:  dev
   Severity:  Normal|   Keywords:  csrf, cookie
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+--
 It seems unnatural to put the token back in the body while using the
 httponly option.
 If verify with a cookie (not x-csrftoken header), security is enhanced and
 it looks much cleaner.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184ac765eac-436e12c1-3cba-472c-8511-fe8d55a25dd5-00%40eu-central-1.amazonses.com.

Re: [Django] #33747: Display exception notes on the technical 500 debug page on Python 3.11+.

[Django]

#33747: Display exception notes on the technical 500 debug page on Python 3.11+.
-+
 Reporter:  Adam Johnson |Owner:  Giebisch
 Type:  New feature  |   Status:  assigned
Component:  Error reporting  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Giebisch):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184ab7c748c-a98d91c7-dda3-4ddf-b743-ededdbd5da89-00%40eu-central-1.amazonses.com.

Re: [Django] #34173: SessionMiddleware support 503 status code

[Django]

#34173: SessionMiddleware support 503 status code
-+-
 Reporter:  SessionIssue |Owner:  Abhinav
 Type:   |  Yadav
  Cleanup/optimization   |   Status:  closed
Component:  contrib.sessions |  Version:  4.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"17472c3304050fbbf7a65976ab7b392184d081d1" 17472c3]:
 {{{
 #!CommitTicketReference repository=""
 revision="17472c3304050fbbf7a65976ab7b392184d081d1"
 Fixed #34173 -- Skipped saving sessions on 5xx responses.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184aa1b6a50-774aebe5-019f-40ca-9d8c-e4822614222d-00%40eu-central-1.amazonses.com.

Re: [Django] #34180: Document that setting language in tests affects other tests

[Django]

#34180: Document that setting language in tests affects other tests
-+-
 Reporter:  Václav Řehák |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:  documentation i18n   | Triage Stage:  Accepted
  tests  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Raphaël Barrois):

 I'll add the results of the extra investigation I did in #34181 (sorry for
 not seeing this ticket, it wasn't here when I started writing mine ):

 - The issue happened with the fix for #5241 in
 
https://github.com/django/django/commit/aa089b106b6cfc9a47cd54a0f9eb44bd44811ed9
 - Django's `LocaleMiddleware` no longer calls `translation.deactivate()`
 as part of its request cleanup.

 However, the pattern shown here is very close to typical code used in
 tests, where strings marked for translation are tested against the value
 in the default locale.

 I feel that a documentation fix stating "Every test asserting on a string
 marked for translation should wrap said assertion with
 `translation.override`" wouldn't actually help users, as that would add a
 significant amount of boilerplate to test cases.

 If the recommended solution is to call `translation.deactivate()` in each
 test case' `tearDown`, I'd suggest including that in Django's source code.
 Another option could be for the test client to deactivate translations
 post-request when it detects that the `LocaleMiddleware` is enabled.
 Otherwise, we could also explore the possibility to restore the locale
 context in some post-request handler, server-side.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a9ff3fd5-48ca4380-8ae4-4414-9a8d-8f639b68efcb-00%40eu-central-1.amazonses.com.

Re: [Django] #34064: USE_THOUSAND_SEPARATOR docs clarification of override by locale

[Django]

#34064: USE_THOUSAND_SEPARATOR docs clarification of override by locale
-+-
 Reporter:  Tibor Leupold|Owner:  Tibor
 Type:   |  Leupold
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson ):

 In [changeset:"754c0c5c6cbabddbe2a8480f95e4dd8273ca6fa4" 754c0c5]:
 {{{
 #!CommitTicketReference repository=""
 revision="754c0c5c6cbabddbe2a8480f95e4dd8273ca6fa4"
 [4.1.x] Fixed #34064 -- Adjusted locale override wording in settings docs.

 Backport of 33f4de34e63c00616ed1624acdf9cd8adfaf33a6 from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a9fac87a-de19dfc1-aeb8-41f3-991e-974a256b57bc-00%40eu-central-1.amazonses.com.

Re: [Django] #34064: USE_THOUSAND_SEPARATOR docs clarification of override by locale

[Django]

#34064: USE_THOUSAND_SEPARATOR docs clarification of override by locale
-+-
 Reporter:  Tibor Leupold|Owner:  Tibor
 Type:   |  Leupold
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"33f4de34e63c00616ed1624acdf9cd8adfaf33a6" 33f4de34]:
 {{{
 #!CommitTicketReference repository=""
 revision="33f4de34e63c00616ed1624acdf9cd8adfaf33a6"
 Fixed #34064 -- Adjusted locale override wording in settings docs.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a9fa4c2b-a9c08e73-ba59-432d-b4c5-011001651208-00%40eu-central-1.amazonses.com.

Re: [Django] #34180: Document that setting language in tests affects other tests

[Django]

#34180: Document that setting language in tests affects other tests
-+-
 Reporter:  Václav Řehák |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:  documentation i18n   | Triage Stage:  Accepted
  tests  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 #34181 was a duplicate which found source of this behaviour:

 > Django's LocaleMiddleware only activates a translation, but doesn't
 deactivate it since #5241 / ​
 >
 
https://github.com/django/django/commit/aa089b106b6cfc9a47cd54a0f9eb44bd44811ed9.

 Given that this was for Django 1.6, ≈9 years ago now, I think we can
 consider it established behaviour.
 (Again, I think a note in the docs is likely option 1.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a9f7b7d1-6447ccce-6c55-4e2b-9c4e-01d700708616-00%40eu-central-1.amazonses.com.

Re: [Django] #34181: The active locale context can leak across tests when using LocaleMiddleware

[Django]

#34181: The active locale context can leak across tests when using 
LocaleMiddleware
-+-
 Reporter:  Raphaël Barrois  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:   |  Version:  4.1
  Internationalization   |
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Duplicate of #34180

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a9f3982a-41bd9211-d1c2-4477-9c9f-479c06310f84-00%40eu-central-1.amazonses.com.

Re: [Django] #34173: SessionMiddleware support 503 status code

[Django]

#34173: SessionMiddleware support 503 status code
-+-
 Reporter:  SessionIssue |Owner:  Abhinav
 Type:   |  Yadav
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.sessions |  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a9e57297-05522322-41d6-4e46-96d5-21b987035933-00%40eu-central-1.amazonses.com.

Re: [Django] #31949: Allow builtin view decorators to be applied directly to async views.

[Django]

#31949: Allow builtin view decorators to be applied directly to async views.
+-
 Reporter:  Michael Galler  |Owner:  Ben Lomax
 Type:  New feature |   Status:  assigned
Component:  Core (Other)|  Version:  3.1
 Severity:  Normal  |   Resolution:
 Keywords:  async   | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+-

Comment (by Carlton Gibson):

 Hey Ben.

 I think the shorter version would be that the `sync_async_wrapper` strikes
 me as overly complex. I think it would be much easier on the eye inlining
 the requisite code each time. I suspect for each decorator the needed code
 is minimal. That wouldn't be as DRY™, but it would exhibit better locality
 of behaviour, and be easier to maintain.

 An incremental way forward would be looking at a subset of the decorators.
 I suspect, the `contrib.auth` decorators are the ones I'm most likely to
 want to use first... 樂

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a9dbdb1c-1026cf24-3e04-484f-a85b-c6a9f9e63b79-00%40eu-central-1.amazonses.com.

[Django] #34181: The active locale context can leak across tests when using LocaleMiddleware

[Django]

#34181: The active locale context can leak across tests when using 
LocaleMiddleware
+
   Reporter:  Raphaël Barrois   |  Owner:  nobody
   Type:  Bug   | Status:  new
  Component:  Internationalization  |Version:  4.1
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Django's LocaleMiddleware only activates a translation, but doesn't
 deactivate it since #5241 /
 
https://github.com/django/django/commit/aa089b106b6cfc9a47cd54a0f9eb44bd44811ed9.

 This has an unwanted side-effect in tests:

 {{{
 class I18NTests(django.test.TestCase):
 def test_lang(self):
response = self.client.get("/", HTTP_LANGUAGE="fr-FR")

 def test_unrelated(self):
 # This value returns a string marked for translation
 context = some_helper()
 self.assertEqual("Hello folks", str(context["greeting"]))
 }}}

 If `test_lang` runs last, the test suite will succeed.
 However, if `test_lang` runs before the other, the test suite will fail:
 the locale context will still be set to `fr` from the execution of
 `LocaleMiddleware`.

 Most project with i18n enabled assume that all tests run under the
 project's default locale (i.e `LANGUAGE_CODE`), yet running some tests in
 other languages will fail.

 I can think of a few ways to address this:
 - **Documentation** Explain that tests should never check the text value
 of a returned function without setting an explicit translation context
 (but that's not exactly intuitive for users);
 - **Test-side fix** Adjust `django.test.Client` to restore the initial
 process locale after the request — or add that to the default `TestCase`
 tear-down;
 - **Server-side fix** find a way to deactivate the translation context
 when it is safe to do so.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a9d5c895-ac8ac3cd-3a8b-4bf2-b5a4-8d9d0e20e639-00%40eu-central-1.amazonses.com.

Re: [Django] #34064: USE_THOUSAND_SEPARATOR docs clarification of override by locale

[Django]

#34064: USE_THOUSAND_SEPARATOR docs clarification of override by locale
-+-
 Reporter:  Tibor Leupold|Owner:  Tibor
 Type:   |  Leupold
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a9d23cf0-d899811d-e681-41b6-aaee-d344e3bc2dad-00%40eu-central-1.amazonses.com.

Re: [Django] #34064: USE_THOUSAND_SEPARATOR docs clarification of override by locale

[Django]

#34064: USE_THOUSAND_SEPARATOR docs clarification of override by locale
-+-
 Reporter:  Tibor Leupold|Owner:  Tibor
 Type:   |  Leupold
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * owner:  nobody => Tibor Leupold
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a9d225ea-4b9149ff-a0b4-43c5-b50a-7111bfce5c1e-00%40eu-central-1.amazonses.com.

Re: [Django] #34064: USE_THOUSAND_SEPARATOR docs clarification of override by locale

[Django]

#34064: USE_THOUSAND_SEPARATOR docs clarification of override by locale
-+-
 Reporter:  Tibor Leupold|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * status:  closed => new
 * resolution:  wontfix =>
 * stage:  Unreviewed => Ready for checkin


Comment:

 [https://github.com/django/django/pull/16141 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a9d1d9cc-588c8973-6504-45bc-b638-21090eab7843-00%40eu-central-1.amazonses.com.

Re: [Django] #34173: SessionMiddleware support 503 status code

[Django]

#34173: SessionMiddleware support 503 status code
-+-
 Reporter:  SessionIssue |Owner:  Abhinav
 Type:   |  Yadav
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.sessions |  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Abhinav Yadav):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/16326 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a98c4b80-4083cdd7-7a7c-4125-bcf8-1ed2d800d33f-00%40eu-central-1.amazonses.com.

Re: [Django] #34110: Add InMemoryStorage

[Django]

#34110: Add InMemoryStorage
-+-
 Reporter:  Josh |Owner:  Francesco
 |  Panico
 Type:  New feature  |   Status:  assigned
Component:  File |  Version:  dev
  uploads/storage|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a97f4458-110f1b68-6c13-4b73-88dc-f251fbfbfb15-00%40eu-central-1.amazonses.com.

Re: [Django] #34180: Document that setting language in tests affects other tests

[Django]

#34180: Document that setting language in tests affects other tests
-+-
 Reporter:  Václav Řehák |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:  documentation i18n   | Triage Stage:  Accepted
  tests  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


Comment:

 Yes, this reproduces. Thanks!

 Expected behaviour was doc'd in 3c447b108ac70757001171f7a4791f493880bf5b.

 I wonder if this is a regression somewhere? It would be good to resolve as
 not merely a docs fix, since otherwise the `override` method (not using
 the LocaleMiddleware would be the only really feasible way.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a9584d60-592b10d3-30ef-4977-aa38-e23e90a90ae2-00%40eu-central-1.amazonses.com.

Re: [Django] #34176: Annotation's original field-name can clash with result field name over aggregation

[Django]

#34176: Annotation's original field-name can clash with result field name over
aggregation
-+-
 Reporter:  Shai Berger  |Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Paolo Melchiorre):

 * cc: Paolo Melchiorre (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a9370721-d88709c3-49db-4f1d-af12-ae68d5144378-00%40eu-central-1.amazonses.com.

[Django] #34180: Document that setting language in tests affects other tests

[Django]

#34180: Document that setting language in tests affects other tests
-+-
   Reporter:  Václav |  Owner:  nobody
  Řehák  |
   Type:  Bug| Status:  new
  Component: |Version:  4.1
  Documentation  |   Keywords:  documentation i18n
   Severity:  Normal |  tests
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 The testing documentation
 https://docs.djangoproject.com/en/4.1/topics/testing/tools/#setting-the-
 language suggests to set language in tests using a cookie or http header.
 But it is not obvious to the reader that doing so will switch the Django
 active language for all other subsequent tests.

 In our case we had random test failures in parallel run depending on the
 actual order of tests executed. This is easily reproducible with the
 following test file


 {{{
 from django.contrib.auth.forms import AuthenticationForm
 from django.test import TestCase

 class ViewTestCase(TestCase):
 def test_czech_request(self):
 self.client.get("/", HTTP_ACCEPT_LANGUAGE="cs-cz")


 class FormTestCase(TestCase):
 def test_form(self):
 f = AuthenticationForm(data={})
 self.assertEqual(f.errors['username'], ['This field is
 required.'])
 }}}

 This testsuite passes in normal run (form is tested before the view) but
 fails when running tests with --reverse as the view test switches Django
 to Czech language and the validation errors of the form are translated.

 I'm not sure if this can be fixed (should the test runner activate the
 default language before each test?) but I suggest to at least document it
 and probably recommend the user to activate the default language in
 tearDown method.


 {{{
 def tearDown(self):
 translation.activate(settings.LANGUAGE_CODE)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a930fd62-399ebde2-91fa-4f6d-bb6f-3f627e94e00d-00%40eu-central-1.amazonses.com.

Re: [Django] #29062: "database table locked errors" when using sqlite in-memory database with LiveServerTestCase

[Django]

#29062: "database table locked errors" when using sqlite in-memory database with
LiveServerTestCase
-+-
 Reporter:  Juozas Masiulis  |Owner:
 |  Christophe Baldy
 Type:  Bug  |   Status:  closed
Component:  Testing framework|  Version:  2.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  sqlite, testing, | Triage Stage:  Ready for
  databases  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"855f5a36e7c8e7a8ce3f62d6ef8c9ae3e073ae3d" 855f5a36]:
 {{{
 #!CommitTicketReference repository=""
 revision="855f5a36e7c8e7a8ce3f62d6ef8c9ae3e073ae3d"
 Fixed #29062 -- Prevented possibility of database lock when using
 LiveServerTestCase with in-memory SQLite database.

 Thanks Chris Jerdonek for the implementation idea.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a90e66bc-f5a9b556-c455-4f11-a76d-93a876d0f037-00%40eu-central-1.amazonses.com.

Re: [Django] #31949: Allow builtin view decorators to be applied directly to async views.

[Django]

#31949: Allow builtin view decorators to be applied directly to async views.
+-
 Reporter:  Michael Galler  |Owner:  Ben Lomax
 Type:  New feature |   Status:  assigned
Component:  Core (Other)|  Version:  3.1
 Severity:  Normal  |   Resolution:
 Keywords:  async   | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+-

Comment (by Ben Lomax):

 Thank you for your review, it's always very appreciated. I'll try to
 address each of your points as best as I understand things:

 1. **Complexity / forced implementation:** The utility function was my
 attempt to make the decorator function work more similarly to the mixin
 classes, which look for `process_request` and `process_response`
 attributes amongst others. However, it might be that we don't want
 decorator ''functions'' to mirror the decorator ''class'' pattern, and so
 I'm happy to move away from it.

 2. **Sync-only `process_X` functions:** As it stands, I would suggest that
 allowing for async passed-in functions (e.g. the `etag_func` argument of
 the `@condition` decorator) should be pushed back into a separate piece of
 work after this one. It seems to me that converting the builtin decorators
 to be async-able at the cost of only allowing sync functions to be passed
 to them is a good iterative step forward.

 3. **The `contrib.auth` decorators:** Fair point, I can cover those too.

 4. **`sync_and_async_middleware` never checked in functions:** Correct me
 if I've misunderstood this, but I thought that the decorator wasn't for
 internal use, but was used by external code as a way of knowing if the
 middleware could handle sync and/or async view functions. For example,
 when layering middleware it would help Django figure out if it needed to
 "adapt the request to fit the middleware's requirements" (as per [the
 docs](https://docs.djangoproject.com/en/4.1/topics/http/middleware
 /#asynchronous-support)).

 5. **async-switch inline:** I think this should be possible for any
 decorators which only act of the request. If a decorator needs to act on
 the response, we need to await the view to get the response, _and then_
 act on that response. If this isn't acceptable, we might be able to do
 something with partial functions perhaps, but that seems like a non-
 trivial jump in complexity.

 6. **implementation that adjusts the wrapped callback:** I'll be honest, I
 don't think I understand your suggestion here. Are you suggesting we
 somehow flag a `process_request` function to be run when the `BaseHandler`
 handles the async view? I think this would mean defining the response
 processing in the decorator, but not actually running it "within the
 decorator".

 A good follow up question feels like is: is there a way to break this work
 up logically to give partial functionality quicker? For example, only
 doing this for decorators which don't act on the view response?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a9037e17-8c3123c4-c802-4d88-8fe1-0de97780841c-00%40eu-central-1.amazonses.com.

Re: [Django] #33497: Database persistent connections do not work with ASGI in 4.0

[Django]

#33497: Database persistent connections do not work with ASGI in 4.0
-+-
 Reporter:  Stenkar  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  ASGI, Database,  | Triage Stage:  Accepted
  async  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Alex):

 * cc: Alex (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070184a8eaa05f-a7c91085-0875-4bdc-b87d-9808af8549bd-00%40eu-central-1.amazonses.com.