date:20221219

Re: [Django] #33735: Add asynchronous responses for use with an ASGI server

2022-12-19 Thread Django

#33735: Add asynchronous responses for use with an ASGI server
+--
 Reporter:  florianvazelle  |Owner:  Carlton Gibson
 Type:  New feature |   Status:  assigned
Component:  HTTP handling   |  Version:  4.0
 Severity:  Normal  |   Resolution:
 Keywords:  ASGI async  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701852e5f0c08-49430a8e-4029-4983-8e70-5dc2b1ce1549-00%40eu-central-1.amazonses.com.

Re: [Django] #33386: Autocomplete on refresh with Firefox interacts badly with ModelMultipleChoiceField in forms

2022-12-19 Thread Django

#33386: Autocomplete on refresh with Firefox interacts badly with
ModelMultipleChoiceField in forms
---+--
 Reporter:  Pietro Brenna  |Owner:  baravkareknath
 Type:  Bug|   Status:  assigned
Component:  Forms  |  Version:  3.2
 Severity:  Normal |   Resolution:
 Keywords:  firefox| Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by baravkareknath):

 * owner:  nobody => baravkareknath
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701852e0d6967-2dd8a9f0-2b71-4200-84f6-0ff5110f1707-00%40eu-central-1.amazonses.com.

Re: [Django] #34217: Migration removing a CheckConstraint results in ProgrammingError using MySQL < 8.0.16.

2022-12-19 Thread Django

#34217: Migration removing a CheckConstraint results in ProgrammingError using
MySQL < 8.0.16.
+
 Reporter:  Max Fisco   |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  4.1
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by Mariusz Felisiak):

 Replying to [comment:2 Max Fisco]:
 > Hi Mariusz,
 >
 > Thanks for the quick response! As far as the patch goes, I'd love to
 contribute (first time reporting a bug) but I think it'd be better to let
 someone else pick it up.
 >
 > I tried to by following along with
 [https://docs.djangoproject.com/en/dev/intro/contributing/#writing-your-
 first-patch-for-django]; however, I'm having some difficulty figuring out
 how to just get the tests to run using MySQL 5.7 in the first place .
 >
 > {{{
 >
 >   File "/Users/maxwellfisco/django-
 fork/django/django/db/backends/base/base.py", line 214, in
 check_database_version_supported
 > raise NotSupportedError(
 > django.db.utils.NotSupportedError: MySQL 8 or later is required (found
 5.7.40).
 > }}}

 Django 4.2 no longer supports MySQL < 8, so you need to use MySQL 8 to
 test against the current `main` branch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701852dbb606a-6889b043-8f7f-43b1-b58e-8d4a18ce672a-00%40eu-central-1.amazonses.com.

Re: [Django] #34217: Migration removing a CheckConstraint results in ProgrammingError using MySQL < 8.0.16.

2022-12-19 Thread Django

#34217: Migration removing a CheckConstraint results in ProgrammingError using
MySQL < 8.0.16.
+
 Reporter:  Max F.  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  4.1
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by Max F.):

 Hi Mariusz,

 Thanks for the quick response! As far as the patch goes, I'd love to
 contribute (first time reporting a bug) but I think it'd be better to let
 someone else pick it up.

 I tried to by following along with
 [https://docs.djangoproject.com/en/dev/intro/contributing/#writing-your-
 first-patch-for-django]; however, I'm having some difficulty figuring out
 how to just get the tests to run using MySQL 5.7 in the first place .

 {{{

   File "/Users/maxwellfisco/django-
 fork/django/django/db/backends/base/base.py", line 214, in
 check_database_version_supported
 raise NotSupportedError(
 django.db.utils.NotSupportedError: MySQL 8 or later is required (found
 5.7.40).
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701852c38939f-e5c9508f-8662-4143-9657-b9b2fb69a9de-00%40eu-central-1.amazonses.com.

Re: [Django] #33662: Choose which items are displayed per language in Sitemap

2022-12-19 Thread Django

#33662: Choose which items are displayed per language in Sitemap
-+-
 Reporter:  Roxane   |Owner:  Roxane
 Type:  New feature  |   Status:  closed
Component:  contrib.sitemaps |  Version:  4.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  sitemap  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"289e9a75afb52918a3efbdaf5e72f45a54089083" 289e9a7]:
 {{{
 #!CommitTicketReference repository=""
 revision="289e9a75afb52918a3efbdaf5e72f45a54089083"
 Fixed #33662 -- Allowed Sitemap to customize languages for each item.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701852a704a3d-8886a29b-6a68-4c64-ac8c-8f9975b525f8-00%40eu-central-1.amazonses.com.

Re: [Django] #33662: Choose which items are displayed per language in Sitemap

2022-12-19 Thread Django

#33662: Choose which items are displayed per language in Sitemap
-+-
 Reporter:  Roxane   |Owner:  Roxane
 Type:  New feature  |   Status:  assigned
Component:  contrib.sitemaps |  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  sitemap  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701852a282303-b4bbb3c4-87b4-4671-bdae-a5ae69267374-00%40eu-central-1.amazonses.com.

Re: [Django] #34165: migrate management command does not respect database parameter when adding Permissions.

2022-12-19 Thread Django

#34165: migrate management command does not respect database parameter when 
adding
Permissions.
--+
 Reporter:  Vasanth   |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  4.1
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Mariusz Felisiak):

 Replying to [comment:8 David Wobrock]:
 > I think `bulk_create` already sets the `_state.db` to the value passed
 in `.using()`, right?

 Yes, but it's a different issue, strictly related with `Permission` and
 its `content_type`. `get_content_type()` is trying to find a content type
 using `obj._state.db` so when we create a `Permission()` without
 `._state.db` it will first try to find a content type in the default db.

 > So would it be relevant to close the issue or is the bug really related
 to Django itself?

 IMO we should fix this for permissions.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018529e4da85-71521223-d335-46f3-86be-16a0ba2b873a-00%40eu-central-1.amazonses.com.

Re: [Django] #34165: migrate management command does not respect database parameter when adding Permissions.

2022-12-19 Thread Django

#34165: migrate management command does not respect database parameter when 
adding
Permissions.
--+
 Reporter:  Vasanth   |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  4.1
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by David Wobrock):

 * cc: David Wobrock (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018529b78cb3-77cfd99b-5d5d-4108-839d-59a851bff397-00%40eu-central-1.amazonses.com.

Re: [Django] #34165: migrate management command does not respect database parameter when adding Permissions.

2022-12-19 Thread Django

#34165: migrate management command does not respect database parameter when 
adding
Permissions.
--+
 Reporter:  Vasanth   |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  4.1
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by David Wobrock):

 Replying to [comment:3 Mariusz Felisiak]:
 > Thanks for this report, it's related with adding missing permissions. I
 was able to fix this by setting `_state.db`, however I'm not convinced
 that it's the best solution:
 > {{{#!diff
 > diff --git a/django/contrib/auth/management/__init__.py
 b/django/contrib/auth/management/__init__.py
 > index 0b5a982617..27fe0df1d7 100644
 > --- a/django/contrib/auth/management/__init__.py
 > +++ b/django/contrib/auth/management/__init__.py
 > @@ -94,12 +94,15 @@ def create_permissions(
 >  )
 >  .values_list("content_type", "codename")
 >  )
 > -
 > -perms = [
 > -Permission(codename=codename, name=name, content_type=ct)
 > -for ct, (codename, name) in searched_perms
 > -if (ct.pk, codename) not in all_perms
 > -]
 > +perms = []
 > +for ct, (codename, name) in searched_perms:
 > +if (ct.pk, codename) not in all_perms:
 > +permission = Permission()
 > +permission._state.db = using
 > +permission.codename = codename
 > +permission.name = name
 > +permission.content_type = ct
 > +perms.append(permission)
 >  Permission.objects.using(using).bulk_create(perms)
 >  if verbosity >= 2:
 >  for perm in perms:
 >
 > }}}
 >
 > Partly related to #29843.

 I think `bulk_create` already sets the `_state.db` to the value passed in
 `.using()`, right?
 Or is it in `bulk_create` that we require `_state.db` to be set earlier?
 In which case, we could perhaps change something inside of this method.


 Replying to [comment:5 Vasanth]:
 > After diving a bit deeper it turned out that the issue was with one of
 the libraries in my project which was not adapted for multi-DB. I've made
 a PR with changes on the django-admin-interface which resolved my issue.

 So would it be relevant to close the issue or is the bug really related to
 Django itself?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018529b69282-aa5076be-10e7-4a6f-94c8-56e0b04029e0-00%40eu-central-1.amazonses.com.

Re: [Django] #33620: Accessibility in pipeline

2022-12-19 Thread Django

Comment (by Tushar):

pa11y seems to be much better than using axe. pa11y can be called directly
from CLI on URLs, we can use axe-core as a pa11y runner, it can output a
decent formatted result, and have options to customize them even further.
Apart from that, I see pa11y-dashboard as well to visualize results if
needed.

After every UI change, writing a helper function that calls pa11y on the
current selenium instance will not take much effort.

I highly favour using the existing admin tests for accessibility as
compared to writing and maintaining accessibility tests.

One issue that I see with using pa11y as described above is redundancy in
pa11y results because every time we would call pa11y, it would scan the
whole page instead of only the new UI change.

pa11y has an option rootElement to only test a subset of DOM but this
would require the use of "#" id tag to identify the elements that I doubt
might be present on every UI piece of admin.

Other way than writing a whole accessibility testing suite is to iterate
overall the .html files in the project and run pa11y over them to generate
results. This might give us a lot of false positives like missing head tag
or title tags due to .html file being in jinja template format.

Let me know your thoughts on the above points before I go ahead with
something.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070185299f66cc-3f3eaa07-abe0-4b3d-8e1e-661aa00bd019-00%40eu-central-1.amazonses.com.

Re: [Django] #33735: Add asynchronous responses for use with an ASGI server

Re: [Django] #33386: Autocomplete on refresh with Firefox interacts badly with ModelMultipleChoiceField in forms

Re: [Django] #34217: Migration removing a CheckConstraint results in ProgrammingError using MySQL < 8.0.16.

Re: [Django] #34217: Migration removing a CheckConstraint results in ProgrammingError using MySQL < 8.0.16.

Re: [Django] #33662: Choose which items are displayed per language in Sitemap

Re: [Django] #33662: Choose which items are displayed per language in Sitemap

Re: [Django] #34165: migrate management command does not respect database parameter when adding Permissions.

Re: [Django] #34165: migrate management command does not respect database parameter when adding Permissions.

Re: [Django] #34165: migrate management command does not respect database parameter when adding Permissions.

Re: [Django] #33620: Accessibility in pipeline

10 matches

Site Navigation

Mail list logo

Footer information