Re: [Django] #34448: makemessages' --no-obsolete option is undocumented and untested.

2023-07-13 Thread Django
#34448: makemessages' --no-obsolete option is undocumented and untested.
-+-
 Reporter:  Tom Sparrow  |Owner:  Tushar
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Core (Management |  Version:  4.1
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070189532b3df9-d86cb413-fc4f-4510-8c0b-d185244ccc3d-00%40eu-central-1.amazonses.com.


Re: [Django] #34677: Django Admin built-in password reset feature has UI issues

2023-07-13 Thread Django
#34677: Django Admin built-in password reset feature has UI issues
-+-
 Reporter:  Yaniv Toledano   |Owner:  Priyank
 Type:   |  Panchal
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  1
-+-
Changes (by Priyank Panchal):

 * needs_docs:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070189531ab9f0-31cc2a5f-fadd-4228-8ad2-728a6613b595-00%40eu-central-1.amazonses.com.


Re: [Django] #34448: makemessages' --no-obsolete option is undocumented and untested.

2023-07-13 Thread Django
#34448: makemessages' --no-obsolete option is undocumented and untested.
-+-
 Reporter:  Tom Sparrow  |Owner:  Tushar
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Core (Management |  Version:  4.1
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/17070 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018952b478bd-2546b18e-6409-426b-9776-c5e3fbc5c68e-00%40eu-central-1.amazonses.com.


Re: [Django] #34709: charset should be ignored for the application/x-www-form-urlencoded content type.

2023-07-13 Thread Django
#34709: charset should be ignored for the application/x-www-form-urlencoded 
content
type.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  HTTP handling|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 Replying to [comment:4 Claude Paroz]:
 > I think it would be difficult to provide a sensible deprecation path
 (visible by devs, I mean), do you have a plan in mind?

 We could raise a warning when `self._encoding` is not `utf-8`, that it
 will be ignored in Django 6.0. I'm just not sure it's worth doing.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018952988a2e-c9b6e5cc-395b-47e1-8367-370d70334138-00%40eu-central-1.amazonses.com.


Re: [Django] #34699: Filtering on annotated TruncSecond expression gives unexpected result.

2023-07-13 Thread Django
#34699: Filtering on annotated TruncSecond expression gives unexpected result.
-+-
 Reporter:  Stefan   |Owner:  Francesco
 |  Panico
 Type:  Uncategorized|   Status:  assigned
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Natalia Bidart):

 Also @stefan, what database are you using in your example? Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070189520e6eac-20012dfb-3ba4-4b2b-8e72-f86b9300983d-00%40eu-central-1.amazonses.com.


Re: [Django] #34699: Filtering on annotated TruncSecond expression gives unexpected result.

2023-07-13 Thread Django
#34699: Filtering on annotated TruncSecond expression gives unexpected result.
-+-
 Reporter:  Stefan   |Owner:  Francesco
 |  Panico
 Type:  Uncategorized|   Status:  assigned
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Natalia Bidart):

 I've been trying to understand this report to properly triage it. From the
 docs for `Trunc` and derivatives, when describing
 [https://docs.djangoproject.com/en/4.2/ref/models/database-functions
 /#datetimefield-truncation DateTimeField truncation], the example given
 shows this:

 {{{
  >>> Experiment.objects.annotate(
 ... date=TruncDate("start_datetime"),
 ... day=TruncDay("start_datetime", tzinfo=melb),
 ... hour=TruncHour("start_datetime", tzinfo=melb),
 ... minute=TruncMinute("start_datetime"),
 ... second=TruncSecond("start_datetime"),
 ... ).values("date", "day", "hour", "minute", "second").get()
 {'date': datetime.date(2014, 6, 15),
  'day': datetime.datetime(2014, 6, 16, 0, 0,
 tzinfo=zoneinfo.ZoneInfo('Australia/Melbourne')),
  'hour': datetime.datetime(2014, 6, 16, 0, 0,
 tzinfo=zoneinfo.ZoneInfo('Australia/Melbourne')),
  'minute': 'minute': datetime.datetime(2014, 6, 15, 14, 30,
 tzinfo=timezone.utc),
  'second': datetime.datetime(2014, 6, 15, 14, 30, 50, tzinfo=timezone.utc)
 }
 }}}

 The text and examples seem to indicate that when the stored datetime is in
 a given timezone, that tz would be used in the truncation unless otherwise
 specified by the `tzinfo` param.

 @stefan, can you double check that the values for `published` are actually
 datetimes in the tz you configured you app?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070189520d743a-102a1706-be0e-40b1-b08a-a8de06bf6be8-00%40eu-central-1.amazonses.com.


Re: [Django] #34709: charset should be ignored for the application/x-www-form-urlencoded content type.

2023-07-13 Thread Django
#34709: charset should be ignored for the application/x-www-form-urlencoded 
content
type.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  HTTP handling|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz):

 I think it would be difficult to provide a sensible deprecation path
 (visible by devs, I mean), do you have a plan in mind?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701895092a0b9-a7b1017c-c9a2-42d2-b944-b0d70fb7d472-00%40eu-central-1.amazonses.com.


Re: [Django] #34448: makemessages' --no-obsolete option is undocumented and untested.

2023-07-13 Thread Django
#34448: makemessages' --no-obsolete option is undocumented and untested.
-+-
 Reporter:  Tom Sparrow  |Owner:  Tushar
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Core (Management |  Version:  4.1
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 Replying to [comment:6 Tushar]:
 > I will add it as a side note while documenting to add more clarity for
 users.

 We don't document bugs in other tools.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070189506448fa-673d0551-1b6d-4f09-b482-926d4c8f9f4e-00%40eu-central-1.amazonses.com.


Re: [Django] #34036: Low text contrast over light blue backgrounds in admin light theme

2023-07-13 Thread Django
#34036: Low text contrast over light blue backgrounds in admin light theme
-+-
 Reporter:  Thibaud Colas|Owner:  Mariana
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.0
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  color contrast, ux |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariana):

 * owner:  (none) => Mariana
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701895061192b-2088b4c2-d38d-441a-97b8-5e30470bec27-00%40eu-central-1.amazonses.com.


Re: [Django] #34448: makemessages' --no-obsolete option is undocumented and untested.

2023-07-13 Thread Django
#34448: makemessages' --no-obsolete option is undocumented and untested.
-+-
 Reporter:  Tom Sparrow  |Owner:  Tushar
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Core (Management |  Version:  4.1
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tushar):

 Yes, confirmed. This is an issue with `msgattrib`. I tried calling it
 directly and it failed to modify the `.po` files if every translation is
 obsolete. I will add it as a side note while documenting to add more
 clarity for users.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070189503271ce-56670334-2a8a-4f7d-bc0f-f8400c04b22d-00%40eu-central-1.amazonses.com.


Re: [Django] #34710: Infinite migrations using models.Choices

2023-07-13 Thread Django
#34710: Infinite migrations using models.Choices
---+--
 Reporter:  Div Shekhar|Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Migrations |  Version:  4.2
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Natalia Bidart):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Closing following latest comment from reporter.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701894fe99e46-ae4c8ba0-f0bd-4120-afaf-47a8caeb3f01-00%40eu-central-1.amazonses.com.


Re: [Django] #34710: Infinite migrations using models.Choices

2023-07-13 Thread Django
#34710: Infinite migrations using models.Choices
---+--
 Reporter:  Div Shekhar|Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Migrations |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Div Shekhar):

 My bad - you can close this out.

 I was thrown coming from django-model-utils's Choices and incorrectly
 assumed TextChoices had extra features I didn't need.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701894fd22b69-e1671623-5798-4c3c-a947-4ac71a85a405-00%40eu-central-1.amazonses.com.


Re: [Django] #28333: Filter and subquery for window expressions

2023-07-13 Thread Django
#28333: Filter and subquery for window expressions
-+-
 Reporter:  Mads Jensen  |Owner:  Simon
 |  Charette
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  window orm filter| Triage Stage:  Accepted
  subquery GSoC  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by master):

 My code was working till 3.2, but with
 
https://code.djangoproject.com/changeset/8c3046daade8d9b019928f96e53629b03060fe73,
 it doesn't anymore.

 Here is a simplified (no filter(), less annotate(), fake Value(), ...)
 demonstrator:
 {{{
 >>> from postman.models import Message
 >>> qs1=Message.objects.values_list('id').order_by()
 >>> print(qs1.query) # correct
 SELECT "postman_message"."id" FROM "postman_message"
 >>> qs2=Message.objects.values('thread').annotate(id=Value(2,
 IntegerField())).values_list('id').order_by()
 >>> print(qs2.query) # correct
 SELECT 2 AS "id" FROM "postman_message"
 >>> print(qs1.union(qs2).query) # will cause my problem
 SELECT "postman_message"."id" AS "col1" FROM "postman_message" UNION
 SELECT 2 AS "id" FROM "postman_message"
 }}}
 The noticeable point is the introduction of the alias `AS "col1"`, not
 compatible with the `id` in the second part.

 In the full code, the union is injected in another query, of the form
 `SELECT ... FROM ... INNER JOIN (the union) PM ON (... = PM.id)`
 So it leads to the error: `django.db.utils.OperationalError: no such
 column: PM.id`

 In db/models/sql/compiler.py, get_combinator_sql(), the call is imposed
 as: `as_sql(with_col_aliases=True)`

 I don't know how to solve this problem.
 Any advice?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701894f7378ea-32324be8-76ab-4ed6-8c64-1954fd9074bc-00%40eu-central-1.amazonses.com.


Re: [Django] #34710: Infinite migrations using models.Choices

2023-07-13 Thread Django
#34710: Infinite migrations using models.Choices
---+--
 Reporter:  Div Shekhar|Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Migrations |  Version:  4.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by David Sanders):

 Hi Div Shekhar,

 In order to get your example working you'd need to specify the type like
 so:

 {{{
 class CoinTossResult(models.Model):
 class CoinFace(str, models.Choices):
 ...
 }}}

 I don't think this is an issue with Django – though there may be some
 documentation updates that could make this clearer when defining custom
 `Choices` classes. I'll leave it up to felixx or nessita to decide whether
 this ticket is invalid 😊

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701894f1d48f6-83b385e3-b26f-4eb5-af6e-da37bad1e2db-00%40eu-central-1.amazonses.com.


[Django] #34710: Infinite migrations using models.Choices

2023-07-13 Thread Django
#34710: Infinite migrations using models.Choices
-+
   Reporter:  divtxt |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Migrations |Version:  4.2
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 Summary:
 - Infinite migrations generated when using enum which is subclass of
 models.Choices
 - Issue does NOT occur with models.TextChoices
 - Workaround: use default=EnumClass.SOME_VALUE**.value**

 

 Steps to reproduce:

 - In a new app, define the following model:

 {{{
 class CoinTossResult(models.Model):
 class CoinFace(models.Choices):
 HEADS = "h"
 TAILS = "t"

 result = models.CharField(
 max_length=1,
 choices=CoinFace.choices,
 default=CoinFace.HEADS,
 )
 }}}

 - Run makemigrations multiple times. After the initial migration, an extra
 migration is generated repeatedly:

 {{{
 (myapp) ~/work/myapp % ./manage.py makemigrations
 Migrations for 'foo':
   foo/migrations/0001_initial.py
 - Create model CoinTossResult

 (myapp) ~/work/myapp % ./manage.py makemigrations
 Migrations for 'foo':
   foo/migrations/0002_alter_cointossresult_result.py
 - Alter field result on cointossresult

 (myapp) ~/work/myapp % ./manage.py makemigrations
 Migrations for 'foo':
   foo/migrations/0003_alter_cointossresult_result.py
 - Alter field result on cointossresult

 (myapp) ~/work/myapp % ./manage.py makemigrations
 Migrations for 'foo':
   foo/migrations/0004_alter_cointossresult_result.py
 - Alter field result on cointossresult

 (myapp) ~/work/myapp % cat
 foo/migrations/0002_alter_cointossresult_result.py
 # Generated by Django 4.2.2 on 2023-07-13 11:00

 from django.db import migrations, models


 class Migration(migrations.Migration):

 dependencies = [
 ('foo', '0001_initial'),
 ]

 operations = [
 migrations.AlterField(
 model_name='cointossresult',
 name='result',
 field=models.CharField(choices=[('h', 'Heads'), ('t',
 'Tails')], default='h', max_length=1),
 ),
 ]

 (myapp) ~/work/myapp % diff
 foo/migrations/0002_alter_cointossresult_result.py
 foo/migrations/0003_alter_cointossresult_result.py
 9c9
 < ('foo', '0001_initial'),
 ---
 > ('foo', '0002_alter_cointossresult_result'),

 (myapp) ~/work/myapp % diff
 foo/migrations/0003_alter_cointossresult_result.py
 foo/migrations/0004_alter_cointossresult_result.py
 9c9
 < ('foo', '0002_alter_cointossresult_result'),
 ---
 > ('foo', '0003_alter_cointossresult_result'),
 }}}

 

 Same steps while using the workaround:

 {{{
 (myapp) ~/work/myapp % git diff
 diff --git a/foo/models.py b/foo/models.py
 index 50e0ad0..e553ad7 100644
 --- a/foo/models.py
 +++ b/foo/models.py
 @@ -8,5 +8,5 @@ class CoinTossResult(models.Model):
  result = models.CharField(
  max_length=1,
  choices=CoinFace.choices,
 -default=CoinFace.HEADS,
 +default=CoinFace.HEADS.value,
  )

 (myapp) ~/work/myapp % ./manage.py makemigrations foo
 Migrations for 'foo':
   foo/migrations/0001_initial.py
 - Create model CoinTossResult

 (myapp) ~/work/myapp % ./manage.py makemigrations foo
 No changes detected in app 'foo'
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701894f066ce1-ab46eef5-98f7-4abf-863d-69ab5080f514-00%40eu-central-1.amazonses.com.


Re: [Django] #34448: makemessages' --no-obsolete option is undocumented and untested.

2023-07-13 Thread Django
#34448: makemessages' --no-obsolete option is undocumented and untested.
-+-
 Reporter:  Tom Sparrow  |Owner:  Tushar
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Core (Management |  Version:  4.1
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 Replying to [comment:4 Tushar]:
 > Hey, I was playing around with the `--no-obsolete` option and found
 https://stackoverflow.com/a/49372926/12409303. This behavior is true,
 `.po` files are not updated if there are no `gettext` present, which means
 obsolete strings still remain there in the `.po` file. Is this the
 intended behaviour that has to be documented or is it a bug ?

 This looks like an issue in `msgattrib`, not in Django itself.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701894ed73cd2-97b3cc3d-7f6b-412b-aac1-3ca729476bc0-00%40eu-central-1.amazonses.com.


Re: [Django] #34709: charset should be ignored for the application/x-www-form-urlencoded content type.

2023-07-13 Thread Django
#34709: charset should be ignored for the application/x-www-form-urlencoded 
content
type.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  HTTP handling|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 The current behavior, even if not correct, is documented and tested.
 Should we use a deprecation path?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701894e7b0861-da7c7d6a-10c1-415e-a98d-f4a60ad4d567-00%40eu-central-1.amazonses.com.


Re: [Django] #34709: charset should be ignored for the application/x-www-form-urlencoded content type.

2023-07-13 Thread Django
#34709: charset should be ignored for the application/x-www-form-urlencoded 
content
type.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  HTTP handling|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Mariusz Felisiak:

Old description:

> `charset` parameter is
> [https://github.com/django/django/blob/02966a30dd31d2b9d35f8c481a448b9bf377895e/django/http/request.py#L379-L383
> used] in `application/x-www-urlencoded` content type. However, per
> [https://url.spec.whatwg.org/#application/x-www-form-urlencoded, the
> current spec] (check out RFC 1866) the content type `application/x-www-
> form-urlencoded` does not have a `charset` and should be treated as
> UTF-8.
>
> Thanks Eki Xu for the report.

New description:

 `charset` parameter is
 
[https://github.com/django/django/blob/02966a30dd31d2b9d35f8c481a448b9bf377895e/django/http/request.py#L379-L383
 used] in `application/x-www-urlencoded` content type. However, per
 [https://url.spec.whatwg.org/#application/x-www-form-urlencoded the
 current spec] (check out RFC 1866) the content type `application/x-www-
 form-urlencoded` does not have a `charset` and should be treated as UTF-8.

 Thanks Eki Xu for the report.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701894e634b2c-a15bc522-d772-4a6a-85a6-edac26d600c4-00%40eu-central-1.amazonses.com.


Re: [Django] #34709: charset should be ignored for the application/x-www-form-urlencoded content type.

2023-07-13 Thread Django
#34709: charset should be ignored for the application/x-www-form-urlencoded 
content
type.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  HTTP handling|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 See related ticket #5076.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701894e62bb06-a06ed10f-aa89-49b9-8c62-32dfd645cf11-00%40eu-central-1.amazonses.com.


[Django] #34709: charset should be ignored for the application/x-www-form-urlencoded content type.

2023-07-13 Thread Django
#34709: charset should be ignored for the application/x-www-form-urlencoded 
content
type.
-+-
   Reporter:  Mariusz|  Owner:  Mariusz Felisiak
  Felisiak   |
   Type:  Bug| Status:  assigned
  Component:  HTTP   |Version:  4.2
  handling   |
   Severity:  Normal |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 `charset` parameter is
 
[https://github.com/django/django/blob/02966a30dd31d2b9d35f8c481a448b9bf377895e/django/http/request.py#L379-L383
 used] in `application/x-www-urlencoded` content type. However, per
 [https://url.spec.whatwg.org/#application/x-www-form-urlencoded, the
 current spec] (check out RFC 1866) the content type `application/x-www-
 form-urlencoded` does not have a `charset` and should be treated as UTF-8.

 Thanks Eki Xu for the report.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701894e43db70-506f2e81-d37a-47ff-94f9-ff700a1d67ec-00%40eu-central-1.amazonses.com.