date:20240108

Re: [Django] #34949: Fails to create unique constraints

2024-01-08 Thread Django

#34949: Fails to create unique constraints
-+-
 Reporter:  Roman Odaisky|Owner:  Jordan
 |  Bae
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 I'm not really sure what do we want to achieve in this ticket.

 > Under no circumstances should Django quietly decline to create a unique
 constraint.

 It doesn't. Django has system checks for all unsupported options
 `models.W036` -> `models.W040` so none of them is silently omitted.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ced3bd201-913e3be4-1899-480d-991e-39928c75a0cc-00%40eu-central-1.amazonses.com.

Re: [Django] #5865: cycle template tag should accept a single argument

2024-01-08 Thread Django

#5865: cycle template tag should accept a single argument
-+
 Reporter:  Gary Wilson  |Owner:  munhitsu
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by Alexander Lazarević):

 Is this still considered a desirable feature?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ced374075-d2d9bec9-e902-4d20-8b00-12f91f23fb53-00%40eu-central-1.amazonses.com.

Re: [Django] #15611: Readonly fields not hidden during create

2024-01-08 Thread Django

#15611: Readonly fields not hidden during create
-+
 Reporter:  Noah Kantrowitz  |Owner:  (none)
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  1.2
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * needs_better_patch:  1 => 0
 * has_patch:  1 => 0
 * resolution:   => fixed
 * type:  Bug => New feature


Comment:

 Customization options are now available, and they are better than hiding
 readonly fields all the time. Closing as "fixed".

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ced29b771-dcdb9a1a-7fd8-4ec4-a0b6-2f8f99e5f040-00%40eu-central-1.amazonses.com.

Re: [Django] #34949: Fails to create unique constraints

2024-01-08 Thread Django

#34949: Fails to create unique constraints
-+-
 Reporter:  Roman Odaisky|Owner:  Jordan
 |  Bae
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jordan Bae):

 * cc: Jordan Bae (added)
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ced1e0626-ada34456-42ba-4e00-9424-eb88ae5d4579-00%40eu-central-1.amazonses.com.

Re: [Django] #34949: Fails to create unique constraints

2024-01-08 Thread Django

#34949: Fails to create unique constraints
-+-
 Reporter:  Roman Odaisky|Owner:  Jordan
 |  Bae
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jordan Bae):

 Thanks for sharing ur thought. Currently I am trying to update two
 changes.
 when i check 4options related this issue with below code

 {{{
 class Ticket34949(models.Model):
 a = models.IntegerField()
 b = models.IntegerField()
 c = models.IntegerField()
 d = models.IntegerField()
 e = models.IntegerField()
 f = models.IntegerField()

 class Meta:
 constraints = [
 models.UniqueConstraint(fields=['a'], name='unique_a'),
 models.UniqueConstraint(fields=['b'], name='unique_b_c',
 include=['c']),
 models.UniqueConstraint(fields=['d'], name='unique_d_e',
 deferrable=models.Deferrable.DEFERRED),
 models.UniqueConstraint(fields=['e'], name='unique_e',
 nulls_distinct=False),
 models.UniqueConstraint(fields=['f'], name='unique_f',
 opclasses=['varchar_pattern_ops'])
 ]
 }}}

 Django makes only a,f unique constraints in MySQL.
 I think opclasses, include are option for optimization. so it needs to
 make unique constraints as David said.
 And nulls_distinct, deferrable are related to unique constraints behavior.
 so, Django shouldn't make unique constraints. so, my actions are below two
 items.
 1) fix includes
 2) update documents for distinguishing between opclasses, include and
 nulls_distinct, deferrable.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cecd9f3f8-0afabb2d-32d7-4259-bbdb-02dca7fd9a52-00%40eu-central-1.amazonses.com.

Re: [Django] #35096: Error messages in admin forms with class "wide" misaligned

2024-01-08 Thread Django

#35096: Error messages in admin forms with class "wide" misaligned
-+-
 Reporter:  Fabian Braun |Owner:  Fabian
 |  Braun
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cec98e2fe-9104418d-76b8-4aa7-9ce4-8980566cf1a3-00%40eu-central-1.amazonses.com.

Re: [Django] #35096: Error messages in admin forms with class "wide" misaligned

2024-01-08 Thread Django

#35096: Error messages in admin forms with class "wide" misaligned
-+
 Reporter:  Fabian Braun |Owner:  Fabian Braun
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  dev
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Mariusz Felisiak):

 * cc: Tom Carrick (added)
 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the report.

 Regression in be06c39abe80ca650e37810d16d15ff60e8c9727 (LTR) and
 b34a4771a3d4cd7829a1f38a0f6a7a0da519a724 (RTL).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cec8e2623-b79ffa35-5f1f-49af-bb22-318cfb1506d0-00%40eu-central-1.amazonses.com.

Re: [Django] #35097: Undocumented behaviour change of utils.dateparse.parse_datetime

2024-01-08 Thread Django

#35097: Undocumented behaviour change of utils.dateparse.parse_datetime
---+--
 Reporter:  David Wobrock  |Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Utilities  |  Version:  4.0
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Thanks for the report, however, I'd treat pre-Django 4.0 behavior as a bug
 here and we don't document bugfixes.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cec7ad7c6-1af79b00-95f6-4f7d-b347-1466ec69bc1e-00%40eu-central-1.amazonses.com.

Re: [Django] #35085: Import of PyATS breaks runserver reloader

2024-01-08 Thread Django

#35085: Import of PyATS breaks runserver reloader
--+--
 Reporter:  Andy Norwood  |Owner:  nobody
 Type:  Bug   |   Status:  closed
Component:  Utilities |  Version:  4.2
 Severity:  Normal|   Resolution:  needsinfo
 Keywords:| Triage Stage:  Unreviewed
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--

Comment (by Andy Norwood):

 An update from Cisco PyATS team:

 
 ''Hi Andy,''

 ''Thanks for reaching out. I believe this was done to create a singleton
 object for the pyATS configuration data that is used by the pyATS code in
 several places.''

 ''Using the sys.modules structure for a non-module is a hack done a long
 time ago, we will review alternative options to handle this in the pyATS
 code.''

 ''Regards,''

 ''Dave''
 

 Sounds like the ball is in their court to resolve the 'hack'.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ceb683d92-827bb5ca-951c-493d-86c4-62a0008b0a3f-00%40eu-central-1.amazonses.com.

Re: [Django] #35096: Error messages in admin forms with class "wide" misaligned

2024-01-08 Thread Django

#35096: Error messages in admin forms with class "wide" misaligned
---+
 Reporter:  Fabian Braun   |Owner:  Fabian Braun
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Fabian Braun):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ceb2e42be-cecec5d2-9c49-499a-9475-f8ef3113d1d5-00%40eu-central-1.amazonses.com.

[Django] #35097: Undocumented behaviour change of utils.dateparse.parse_datetime

2024-01-08 Thread Django

#35097: Undocumented behaviour change of utils.dateparse.parse_datetime
-+
   Reporter:  David Wobrock  |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Utilities  |Version:  4.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 Hey,

 A bit late to the party, but in 4.0, we introduced a patch that changed
 the behaviour of `django.utils.dateparse.parse_datetime`.
 In very short, on Django 3.2
 {{{
 >>> from django.utils.dateparse import parse_datetime
 >>> parse_datetime('2023-01-01')
 # Returns None
 }}}

 And on Django 4.0,
 {{{
 >>> from django.utils.dateparse import parse_datetime
 >>> parse_datetime('2023-01-01')
 datetime.datetime(2023, 1, 1, 0, 0)
 }}}

 The change was introduced in
 
[https://github.com/django/django/commit/f35ab74752adb37138112657c1bc8b91f50e799b
 f35ab74752adb37138112657c1bc8b91f50e799b], which relates to #32892.
 The initial ticket considers mainly `parse_time` and `parse_date`, but not
 the impacts on `parse_datetime`.

 I think this behaviour is valid, since a date without time can be
 considered a valid datetime object, with 0 as time values.
 But since this change was not documented, I wanted to report it somewhere,
 because I couldn't find any other reference to it :)

 Though I'm not sure this is the best way to share this information, so
 feel free to close the ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ceb27860a-89d4e767-6708-4b57-adbf-c450c7f5e684-00%40eu-central-1.amazonses.com.

Re: [Django] #35096: Error messages in admin forms with class "wide" misaligned

2024-01-08 Thread Django

#35096: Error messages in admin forms with class "wide" misaligned
---+
 Reporter:  Fabian Braun   |Owner:  Fabian Braun
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Description changed by Fabian Braun:

Old description:

> The admin allows customizing the styling of fieldsets. "wide" is a
> documented class for a fieldset. It widens the width of the label column
> from 160px to 200px.
>
> Alas, if the form has errors, the error messages stay indented at 160px
> not 200px:
> []

New description:

 The admin allows customizing the styling of fieldsets. "wide" is a
 documented class for a fieldset. It widens the width of the label column
 from 160px to 200px.

 Alas, if the form has errors, the error messages stay indented at 160px
 not 200px:
 [[Image(https://code.djangoproject.com/raw-attachment/ticket/35096/admin-
 wide.jpg)]]

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ceb1fa56e-3c734e99-0c73-4116-b4bc-b661618b6a02-00%40eu-central-1.amazonses.com.

Re: [Django] #35096: Error messages in admin forms with class "wide" misaligned

2024-01-08 Thread Django

#35096: Error messages in admin forms with class "wide" misaligned
---+
 Reporter:  Fabian Braun   |Owner:  Fabian Braun
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Fabian Braun):

 * Attachment "admin-wide.jpg" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ceb1e143c-fa29b706-503a-4120-b36c-3b4141f87343-00%40eu-central-1.amazonses.com.

[Django] #35096: Error messages in admin forms with class "wide" misaligned

2024-01-08 Thread Django

#35096: Error messages in admin forms with class "wide" misaligned
-+--
   Reporter:  Fabian Braun   |  Owner:  Fabian Braun
   Type:  Bug| Status:  assigned
  Component:  contrib.admin  |Version:  dev
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+--
 The admin allows customizing the styling of fieldsets. "wide" is a
 documented class for a fieldset. It widens the width of the label column
 from 160px to 200px.

 Alas, if the form has errors, the error messages stay indented at 160px
 not 200px:
 []

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ceb1d6dab-3bafefaf-f845-413e-863b-6e06ed6ddcd0-00%40eu-central-1.amazonses.com.

Re: [Django] #35095: Monetary values in Switzerland discrepancy

2024-01-08 Thread Django

#35095: Monetary values in Switzerland discrepancy
--+
 Reporter:  Andrea Angelini   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Internationalization  |  Version:  5.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * cc: Silvan Spross (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cead7543d-bb6f66df-cd95-4bcf-8f3c-e6c947b0a0e0-00%40eu-central-1.amazonses.com.

Re: [Django] #35095: Monetary values in Switzerland discrepancy

2024-01-08 Thread Django

#35095: Monetary values in Switzerland discrepancy
--+
 Reporter:  Andrea Angelini   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Internationalization  |  Version:  5.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * type:  Uncategorized => Cleanup/optimization
 * easy:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 > What I pointed out is that, **for monetary numbers**, the documentation
 says "a comma is used as the thousand separator", whilst the comment in
 format says "the THOUSAND_SEPARATOR is a ' (single quote)".

 OK, but it's not something that Django uses, so it's just a real minor
 typo in docs/comments.

 For the future, that kind of cleanups doesn't require a ticket, feel-free
 to check sources and submit PR.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cead538d8-5dd10c47-597e-4535-8ff9-1f64f1f52087-00%40eu-central-1.amazonses.com.

Re: [Django] #17688: No m2m_changed signal sent to when referenced object is deleted

2024-01-08 Thread Django

#17688: No m2m_changed signal sent to when referenced object is deleted
-+-
 Reporter:  jblaine@…|Owner:
 |  jorgecarleitao
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by ITJamie):

 pretty sure this is still an active issue. it was reported on
 https://github.com/netbox-community/netbox/issues/14079 when change_log
 didn't log changes of deletes on related m2m objects.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ceacfae7b-dfb956a1-817f-402c-afbc-5b562562e964-00%40eu-central-1.amazonses.com.

Re: [Django] #35095: Monetary values in Switzerland discrepancy

2024-01-08 Thread Django

#35095: Monetary values in Switzerland discrepancy
-+-
 Reporter:  Andrea Angelini  |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:   |  Version:  5.0
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Andrea Angelini):

 * status:  closed => new
 * resolution:  invalid =>


Comment:

 I agree with you that for non-monetary numbers, the documentation and the
 code match.

 What I pointed out is that, **for monetary numbers**, the documentation
 says "a comma is used as the thousand separator", whilst the comment in
 format says "the THOUSAND_SEPARATOR is a ' (single quote)".

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ceacee444-8e12d9b1-d916-4787-ab0f-172ec4e054c8-00%40eu-central-1.amazonses.com.

Re: [Django] #33481: Clarify remove_stale_contenttypes data loss warning

2024-01-08 Thread Django

#33481: Clarify remove_stale_contenttypes data loss warning
-+-
 Reporter:  Johannes Maron   |Owner:  Syed
 Type:   |  Waheed
  Cleanup/optimization   |   Status:  closed
Component:   |  Version:  dev
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"415982be105380af5116692a2f6e91c8092803fb" 415982b]:
 {{{
 #!CommitTicketReference repository=""
 revision="415982be105380af5116692a2f6e91c8092803fb"
 Fixed #33481 -- Clarified remove_stale_contenttypes data loss warning.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ceaccf89e-7ee51cb8-c984-4e95-b398-429dc08c0db0-00%40eu-central-1.amazonses.com.

Re: [Django] #35095: Monetary values in Switzerland discrepancy

2024-01-08 Thread Django

#35095: Monetary values in Switzerland discrepancy
-+-
 Reporter:  Andrea Angelini  |Owner:  nobody
 Type:  Uncategorized|   Status:  closed
Component:   |  Version:  5.0
  Internationalization   |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: Claude Paroz (added)
 * resolution:   => invalid
 * status:  new => closed
 * component:  Documentation => Internationalization


Comment:

 As far as I'm aware, both the documentation and comments match.

 > # These are the separators for **non-monetary numbers**. For monetary
 numbers,
 > # the DECIMAL_SEPARATOR is a . (decimal point) and the
 THOUSAND_SEPARATOR is a
 > # ' (single quote).
 > DECIMAL_SEPARATOR = ","
 > THOUSAND_SEPARATOR = "\xa0"  # non-breaking space

 So for non-monetary numbers, a comma is used for decimal and a space for
 thousand separators, exactly the same format is
 [https://docs.djangoproject.com/en/5.0/topics/i18n/formatting
 /#switzerland-german documented].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ceacbe59e-45393ad9-ee11-43b3-8889-f1c5a64f9c51-00%40eu-central-1.amazonses.com.

Re: [Django] #35059: ASGI server leaves stale DB connections

2024-01-08 Thread Django

#35059: ASGI server leaves stale DB connections
-+-
 Reporter:  James Thorniley  |Owner:  James
 |  Thorniley
 Type:  Bug  |   Status:  assigned
Component:  HTTP handling|  Version:  5.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * needs_better_patch:  0 => 1


Comment:

 Setting patch needs improvements following the latest batch of review
 comments made by Carlton.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ceac30deb-c1281787-a330-45c4-b78e-47b8b9529a88-00%40eu-central-1.amazonses.com.

Re: [Django] #32819: Fields’ help text and errors should be associated with input

2024-01-08 Thread Django

#32819: Fields’ help text and errors should be associated with input
-+-
 Reporter:  Thibaud Colas|Owner:  David
 |  Smith
 Type:  Bug  |   Status:  assigned
Component:  Forms|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility, ui,   | Triage Stage:  Accepted
  forms  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Natalia Bidart):

 * needs_better_patch:  0 => 1


Comment:

 Setting as patch needs improvement because the docs for when a custom
 `aria-describedby` is given definitely needs more details/clarification
 about what the user should do to properly customize the attribute for help
 text and errors.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ceac0ebc6-32cf1d75-1b34-46cb-9ecf-3841895e1323-00%40eu-central-1.amazonses.com.

[Django] #35095: Monetary values in Switzerland discrepancy

2024-01-08 Thread Django

#35095: Monetary values in Switzerland discrepancy
---+
   Reporter:  Andrea Angelini  |  Owner:  nobody
   Type:  Uncategorized| Status:  new
  Component:  Documentation|Version:  5.0
   Severity:  Normal   |   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+
 At this link (https://docs.djangoproject.com/en/5.0/topics/i18n/formatting
 /#switzerland-german) the documentation says:

 Switzerland (German) [...] For monetary values, **a comma is used as the
 thousand separator** and a decimal point for the decimal separator.

 At this link
 
(https://github.com/django/django/blob/main/django/conf/locale/de_CH/formats.py)
 the comment says:

 For monetary numbers, the DECIMAL_SEPARATOR is a . (decimal point) and
 **the THOUSAND_SEPARATOR is a ' (single quote)**.

 Unfortunately I'm not familiar with the `de_CH` locale, therefore I can't
 say which one is correct.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ceab66ae5-d6c8bc01-2174-49e8-8d4b-aa90e51c794b-00%40eu-central-1.amazonses.com.

Re: [Django] #34044: Admin app search filter appears in nav sidebar but not on admin homepage

2024-01-08 Thread Django

#34044: Admin app search filter appears in nav sidebar but not on admin homepage
---+--
 Reporter:  Hugo Herter|Owner:  Hisham Mahmood
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by Hisham Mahmood):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ceab15b01-2698009d-81a1-4abd-beb0-dcd79c8d20f6-00%40eu-central-1.amazonses.com.

Re: [Django] #34977: Turn link to change password form in admin user change form into a button

2024-01-08 Thread Django

#34977: Turn link to change password form in admin user change form into a 
button
-+-
 Reporter:  Fabian Braun |Owner:  Fabian
 Type:   |  Braun
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.auth |  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  1
-+-

Comment (by Natalia Bidart):

 I added some review comments proposing a slightly different approach:
 instead of having either a link or a button *in* the help text, I would
 like that we separate the help text legend from the "convenience shortcut"
 to hint the admin user where they can act regarding the password.

 I'd like the accessibility team's input, I attached a possible diff to the
 [https://github.com/django/django/pull/17489#issuecomment-1879361460
 linked PR].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cea9e0ff9-8a43af6d-c9e4-4b2a-8005-7ceb1d49dde7-00%40eu-central-1.amazonses.com.

Re: [Django] #33481: Clarify remove_stale_contenttypes data loss warning

2024-01-08 Thread Django

#33481: Clarify remove_stale_contenttypes data loss warning
-+-
 Reporter:  Johannes Maron   |Owner:  Syed
 Type:   |  Waheed
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  dev
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cea79ddab-afff9c57-7250-49d5-8268-b8ccdcd3b504-00%40eu-central-1.amazonses.com.

Re: [Django] #35033: EmailMessage repeats header if provided via the headers kwargs

2024-01-08 Thread Django

#35033: EmailMessage repeats header if provided via the headers kwargs
+-
 Reporter:  Aalekh Patel|Owner:  Salvo Polizzi
 Type:  Bug |   Status:  assigned
Component:  Core (Mail) |  Version:  dev
 Severity:  Normal  |   Resolution:
 Keywords:  email, headers  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


Comment:

 We need to find
 [https://github.com/django/django/pull/17642#issuecomment-1875327543
 answers] before this PR will be reviewable again. We cannot review PR if
 we are not sure what we want to achieve. I don't see any discussion on the
 forum or the mailing list, or any answers for my questions.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cea58e5aa-85764f30-b2ba-40fb-8bf6-3e79c8280c48-00%40eu-central-1.amazonses.com.

Re: [Django] #35033: EmailMessage repeats header if provided via the headers kwargs

2024-01-08 Thread Django

#35033: EmailMessage repeats header if provided via the headers kwargs
+-
 Reporter:  Aalekh Patel|Owner:  Salvo Polizzi
 Type:  Bug |   Status:  assigned
Component:  Core (Mail) |  Version:  dev
 Severity:  Normal  |   Resolution:
 Keywords:  email, headers  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by Salvo Polizzi):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cea46209b-8b7c5443-37bb-44da-9830-ecb9ce4edff7-00%40eu-central-1.amazonses.com.

Re: [Django] #16281: ContentType.get_object_for_this_type using wrong database for creating object

2024-01-08 Thread Django

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-+-
 Reporter:  tfrydrychewicz@… |Owner:  bcail
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  dev
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:
 Keywords:  contenttype, object  | Triage Stage:  Accepted
  get_object_for_this_type,  |
  database, multiple |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by bcail):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cea459a5c-fcde450a-e934-4fcf-b634-7fedef0395aa-00%40eu-central-1.amazonses.com.

Re: [Django] #34044: Admin app search filter appears in nav sidebar but not on admin homepage

2024-01-08 Thread Django

#34044: Admin app search filter appears in nav sidebar but not on admin homepage
---+--
 Reporter:  Hugo Herter|Owner:  Hisham Mahmood
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by Hisham Mahmood):

 * owner:  SanjayBisht96 => Hisham Mahmood
 * needs_better_patch:  1 => 0


Comment:

 Pull request: https://github.com/django/django/pull/17709

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cea06efc8-fdcf2195-4ffb-47a0-9505-263787898d9c-00%40eu-central-1.amazonses.com.

Re: [Django] #33481: Clarify remove_stale_contenttypes data loss warning

2024-01-08 Thread Django

#33481: Clarify remove_stale_contenttypes data loss warning
-+-
 Reporter:  Johannes Maron   |Owner:  Syed
 Type:   |  Waheed
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  dev
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ce9d7164a-ddc0de73-87a9-409b-87f5-0f98259ac57a-00%40eu-central-1.amazonses.com.

Re: [Django] #34949: Fails to create unique constraints

2024-01-08 Thread Django

#34949: Fails to create unique constraints
-+-
 Reporter:  Roman Odaisky|Owner:  Jordan
 |  Bae
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Roman Odaisky):

 Perhaps the easiest way of implementing this would be something along the
 lines of
 {{{
 class Meta:
 constraints = [
 models.UniqueConstraint(fields=["e"], include=["f"],
 if_has_features=["supports_covering_indexes"]),
 models.UniqueConstraint(fields=["e"],
 unless_has_features=["supports_covering_indexes"]),
 ]
 indexes = [
 models.Index(fields=["e", "f"],
 unless_has_features=["supports_covering_indexes"]),
 ]
 }}}
 The only question that would remain would be, what if the DB gains support
 for a feature it previously lacked.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ce994212b-f768c6df-fc02-42f2-9875-ee26d75c3140-00%40eu-central-1.amazonses.com.

Re: [Django] #33481: Clarify remove_stale_contenttypes data loss warning

2024-01-08 Thread Django

#33481: Clarify remove_stale_contenttypes data loss warning
-+-
 Reporter:  Johannes Maron   |Owner:  Syed
 Type:   |  Waheed
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  dev
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Syed Waheed):

 PR - https://github.com/django/django/pull/17707

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ce95d09f1-2fc629d6-3f42-4a20-98bf-312a77ae7ab2-00%40eu-central-1.amazonses.com.

Re: [Django] #35087: DisallowedModelAdminLookup raised when filtering on a ForeignKey not listed in list_filters

2024-01-08 Thread Django

#35087: DisallowedModelAdminLookup raised when filtering on a ForeignKey not 
listed
in list_filters
-+-
 Reporter:  Maxime Lorant|Owner:  Sarah
 |  Boyce
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  5.0
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  admin filters| Triage Stage:  Ready for
  foreignkey |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"4cba6748a640a158a26a0a0d11597b393bdd3883" 4cba6748]:
 {{{
 #!CommitTicketReference repository=""
 revision="4cba6748a640a158a26a0a0d11597b393bdd3883"
 [5.0.x] Fixed #35087 -- Reallowed filtering against foreign keys not
 listed in ModelAdmin.list_filters.

 Regression in f80669d2f5a5f1db9e9b73ca893fefba34f955e7.

 Backport of a9094ec1f43dca7f2a649327afcd5e6226b4959c from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ce94043db-2b4d3c8e-e228-426c-91c9-ef06aad1e593-00%40eu-central-1.amazonses.com.

Re: [Django] #35087: DisallowedModelAdminLookup raised when filtering on a ForeignKey not listed in list_filters

2024-01-08 Thread Django

#35087: DisallowedModelAdminLookup raised when filtering on a ForeignKey not 
listed
in list_filters
-+-
 Reporter:  Maxime Lorant|Owner:  Sarah
 |  Boyce
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  5.0
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  admin filters| Triage Stage:  Ready for
  foreignkey |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"a9094ec1f43dca7f2a649327afcd5e6226b4959c" a9094ec1]:
 {{{
 #!CommitTicketReference repository=""
 revision="a9094ec1f43dca7f2a649327afcd5e6226b4959c"
 Fixed #35087 -- Reallowed filtering against foreign keys not listed in
 ModelAdmin.list_filters.

 Regression in f80669d2f5a5f1db9e9b73ca893fefba34f955e7.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ce93fe50a-33e8dde8-fc95-4429-bfe5-c26092a44b0a-00%40eu-central-1.amazonses.com.

Re: [Django] #35059: ASGI server leaves stale DB connections

2024-01-08 Thread Django

#35059: ASGI server leaves stale DB connections
-+-
 Reporter:  James Thorniley  |Owner:  James
 |  Thorniley
 Type:  Bug  |   Status:  assigned
Component:  HTTP handling|  Version:  5.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * owner:  nobody => James Thorniley
 * needs_better_patch:  1 => 0
 * has_patch:  0 => 1
 * status:  new => assigned


Comment:

 Assigning to James following the proposed PR.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ce92a3fa1-52bf9e90-e0b8-4b7c-869a-379c75717070-00%40eu-central-1.amazonses.com.

Re: [Django] #35090: Enforce uniqueness on custom path converters

2024-01-08 Thread Django

#35090: Enforce uniqueness on custom path converters
--+
 Reporter:  Adam Johnson  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (URLs)   |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Natalia Bidart):

 I'm not sure I understand the desired fix: is it to prevent any converter
 registered name overlap (ie a dynamic check at the time of project load)?
 or just a check against the Django/default's converters?

 Would there be a way to override registered converters?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ce928198d-1a5e8a3e-36b7-493d-879f-ed7057911e18-00%40eu-central-1.amazonses.com.

Re: [Django] #35093: Allow SQL injection characters in QuerySet.annotate() aliases

2024-01-08 Thread Django

#35093: Allow SQL injection characters in QuerySet.annotate() aliases
-+-
 Reporter:  Eyal Segal   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  3.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  ORM, annotations | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Eyal Segal:

Old description:

> Encountered a limitation in Django ORM when using annotations with column
> aliases containing special characters like apostrophes or spaces. For
> example:
>
> `Model.objects.annotate(**{"VALUE_WITH_APOSTROPHE'-2":
> Count('attribute_name')})`
>
> This generates a `ValueError: Column aliases cannot contain whitespace
> characters, quotation marks, semicolons, or SQL comments.` While SQL
> syntax allows such aliases, Django ORM does not, leading to a lack of
> flexibility and unexpected errors in ORM interactions.
>
> Impact:
> - Causes flow errors during higher-level ORM interactions.
> - Limits application of ORM to real-world naming use cases.
> - Decreases reliability and user experience when special characters are
> present.
>
> Proposed Solution:
> Enhance the ORM's handling of annotate aliases to allow common special
> characters, aligning with real-world naming scenarios. Options could
> include:
> - Automatically transforming aliases before passing to SQL.
> - Configurable rules for "safe" special characters at the ORM level.
>
> Interested in community and maintainers' perspectives on potential
> solutions to provide ORM-level flexibility for end-user applications.
> Looking forward to contributing to the discussion and development of this
> feature.

New description:

 Encountered a limitation in Django ORM when using annotations with column
 aliases containing special characters like apostrophes or spaces. For
 example:

 `Model.objects.annotate(**{"VALUE_WITH_APOSTROPHE'-2":
 Count('attribute_name')})`

 This generates a `ValueError: Column aliases cannot contain whitespace
 characters, quotation marks, semicolons, or SQL comments.` While SQL
 syntax allows such value for fields, Django ORM does not, leading to a
 lack of flexibility and unexpected errors in ORM interactions.

 Impact:
 - Causes flow errors during higher-level ORM interactions.
 - Limits application of ORM to real-world naming use cases.
 - Decreases reliability and user experience when special characters are
 present.

 Proposed Solution:
 Enhance the ORM's handling of annotate aliases to allow common special
 characters, aligning with real-world naming scenarios. Options could
 include:
 - Automatically transforming aliases before passing to SQL.
 - Configurable rules for "safe" special characters at the ORM level.

 Interested in community and maintainers' perspectives on potential
 solutions to provide ORM-level flexibility for end-user applications.
 Looking forward to contributing to the discussion and development of this
 feature.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ce91bd38a-5fbb32a0-a885-4d47-8abd-d9a3e980f8c9-00%40eu-central-1.amazonses.com.

Re: [Django] #35094: Add pure Python dbshell fallback

2024-01-08 Thread Django

#35094: Add pure Python dbshell fallback
-+-
 Reporter:  Jake Howard  |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Core (Management |  Version:  5.0
  commands)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:  sqlite dbshell in-   | Triage Stage:
  memory |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jake Howard):

 > How would you like to share the same in-memory database as e.g.
 runserver?

 Sadly, you couldn't - but at least it'd make testing any of the
 bootstrapping during startup easier, and quickly checking any data.

 > It sounds like a third-party package is the best way to proceed

 On reflection, I agree!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ce9178d1f-a2cf6c7c-d795-4f5e-8701-d55c4daf2085-00%40eu-central-1.amazonses.com.

Re: [Django] #35094: Add pure Python dbshell fallback (was: Add pure Python `dbshell` fallback)

2024-01-08 Thread Django

* status: new => closed
* resolution: => wontfix
* component: Database layer (models, ORM) => Core (Management commands)

Comment:

Thanks for this ticket, however I don't see much burnout in installing
database clients if users want to use database in a shell. It's also not
something that needs to be shipped by Django itself. It sounds like a
third-party package is the best way to proceed so that people can try it
out and then approaching the DevelopersMailingList to reach a wider
audience and see what other think.

> which can easily be adapted and made generic for all database engines.

I don't think it is, but you may prove that I'm wrong. The devil is in the
details.

> Doing this has a side benefit of also giving support for a dbshell for
in-memory SQLite connections, which are currently misleading through
dbshell, as it doesn't reuse the same connection that Django does, meaning
any database bootstrapping done during startup (best-practice aside) is
lost. An in-process connection reuses the same connnection, and thus
allows access to that in-memory database.

I'm not sure how would you like to achieve this, `dbshell` is a management
command. How would you like to share the same in-memory database as e.g.
`runserver`?

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018ce9103642-fb753d84-98e5-44a2-b9a4-c649e367de60-00%40eu-central-1.amazonses.com.

[Django] #35094: Add pure Python `dbshell` fallback

2024-01-08 Thread Django

#35094: Add pure Python `dbshell` fallback
-+-
Reporter: Jake | Owner: nobody
Howard |
Type: New| Status: new
feature|
Component: Database |Version: 5.0
layer (models, ORM)| Keywords: sqlite dbshell in-
Severity: Normal | memory
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 |Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-+-
`dbshell` attempts to shell out to the client tooling for the relevant
database engine (`sqlite3`, `psql` etc) for `dbshell`. If the tooling
isn't installed, it can't shell. However, for a more naive shell
implementation, it would be simple to pipe commands through to
`connection.cursor().execute` and get at least some of the benefit without
needing to install the client command-line tooling.

Whilst this wouldn't have the client-side magic (eg backslash commands in
Postgres or `.` commands in sqlite), nor tab complete, it can still be a
lot more useful than nothing. An implementation of this shipped in Python
3.12 for SQLite
(https://github.com/python/cpython/blob/main/Lib/sqlite3/__main__.py),
which can easily be adapted and made generic for all database engines.

Doing this has a side benefit of also giving support for a `dbshell` for
in-memory SQLite connections, which are currently misleading through
`dbshell`, as it doesn't reuse the same connection that Django does,
meaning any database bootstrapping done during startup (best-practice
aside) is lost. An in-process connection reuses the same connnection, and
thus allows access to that in-memory database.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018ce8fc80dd-21577af9-507c-4e4e-9f67-ce38af639a45-00%40eu-central-1.amazonses.com.

Re: [Django] #34852: Django Unit Tests break when using replicated MySQL Cluster v8.0.28

2024-01-08 Thread Django

#34852: Django Unit Tests break when using replicated MySQL Cluster v8.0.28
+--
 Reporter:  Aaron Blair |Owner:  Can Huynh
 Type:  Bug |   Status:  closed
Component:  Testing framework   |  Version:  4.1
 Severity:  Normal  |   Resolution:  invalid
 Keywords:  Test MySQL Cluster  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Mariusz Felisiak):

 * status:  assigned => closed
 * resolution:   => invalid
 * easy:  1 => 0
 * stage:  Accepted => Unreviewed


Comment:

 The `django.db.backends.mysql` backend has its own implementation of
 `DatabaseFeatures.supports_transactions` and doesn't use the default one.
 I don't think there is anything to fix in Django itself.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ce8e9b065-3b5ea56f-1af9-4975-acdb-07a46ba08d64-00%40eu-central-1.amazonses.com.

Re: [Django] #16281: ContentType.get_object_for_this_type using wrong database for creating object

2024-01-08 Thread Django

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-+-
 Reporter:  tfrydrychewicz@… |Owner:  bcail
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  dev
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:
 Keywords:  contenttype, object  | Triage Stage:  Accepted
  get_object_for_this_type,  |
  database, multiple |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ce8729792-20aeec2a-50ab-4a94-96a1-6e4d3dee1588-00%40eu-central-1.amazonses.com.

Re: [Django] #35090: Enforce uniqueness on custom path converters

2024-01-08 Thread Django

#35090: Enforce uniqueness on custom path converters
--+
 Reporter:  Adam Johnson  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (URLs)   |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted


Comment:

 OK, let's have it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ce8695d39-65988fb7-1181-4f48-81b1-99f1047f0f70-00%40eu-central-1.amazonses.com.

Re: [Django] #35074: Altering spatial_index does not actually create/drop the index

2024-01-08 Thread Django

#35074: Altering spatial_index does not actually create/drop the index
--+
 Reporter:  Mário Falcão  |Owner:  Mário Falcão
 Type:  Bug   |   Status:  assigned
Component:  GIS   |  Version:  4.2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ce84af2f0-bb5682fe-8d1b-468f-aa87-f6cce72fc7b0-00%40eu-central-1.amazonses.com.

Re: [Django] #35087: DisallowedModelAdminLookup raised when filtering on a ForeignKey not listed in list_filters

2024-01-08 Thread Django

#35087: DisallowedModelAdminLookup raised when filtering on a ForeignKey not 
listed
in list_filters
-+-
 Reporter:  Maxime Lorant|Owner:  Sarah
 |  Boyce
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Release blocker  |   Resolution:
 Keywords:  admin filters| Triage Stage:  Ready for
  foreignkey |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ce839e9c9-a5a3c747-456e-4e50-8a72-c2a8cf5923de-00%40eu-central-1.amazonses.com.

46 matches

Mail list logo