Re: [Django] #35102: Performance regression on Model.objects.count() between Django 4.2 and 5.0

[Django]

#35102: Performance regression on Model.objects.count() between Django 4.2 and 
5.0
---+--
 Reporter:  Anthony Shaw   |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Mariusz Felisiak):

 Thanks for the report, I think we could make it faster by avoiding cloning
 every time:
 {{{#!diff
 diff --git a/django/db/models/expressions.py
 b/django/db/models/expressions.py
 index c20de5995a..80b8fc8e6a 100644
 --- a/django/db/models/expressions.py
 +++ b/django/db/models/expressions.py
 @@ -404,8 +404,9 @@ class BaseExpression:
  def replace_expressions(self, replacements):
  if replacement := replacements.get(self):
  return replacement
 +if not (source_expressions := self.get_source_expressions()):
 +return self
  clone = self.copy()
 -source_expressions = clone.get_source_expressions()
  clone.set_source_expressions(
  [
  expr.replace_expressions(replacements) if expr else None

 }}}
 Does it work for you?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf787a27f-578e2632-e359-4498-ae65-5df5521fe96c-00%40eu-central-1.amazonses.com.

Re: [Django] #35102: Performance regression on Model.objects.count() between Django 4.2 and 5.0

[Django]

#35102: Performance regression on Model.objects.count() between Django 4.2 and 
5.0
---+--
 Reporter:  Anthony Shaw   |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Anthony Shaw):

 This is the commit that added the extra call tree
 
https://github.com/django/django/commit/2ee01747c32a7275a7a1a5f7862acba7db764921

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf72a0499-910da0c8-f2cc-45f7-a258-9a1274c128b6-00%40eu-central-1.amazonses.com.

Re: [Django] #35102: Performance regression on Model.objects.count() between Django 4.2 and 5.0

[Django]

#35102: Performance regression on Model.objects.count() between Django 4.2 and 
5.0
---+--
 Reporter:  Anthony Shaw   |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Anthony Shaw):

 * Attachment "exp-query_count" added.

 Profile for Django 5.1-dev

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf723115c-7e44d684-c73d-430e-ae0b-e1deab545463-00%40eu-central-1.amazonses.com.

Re: [Django] #35102: Performance regression on Model.objects.count() between Django 4.2 and 5.0

[Django]

#35102: Performance regression on Model.objects.count() between Django 4.2 and 
5.0
---+--
 Reporter:  Anthony Shaw   |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Uncategorized  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Anthony Shaw):

 * Attachment "con-query_count" added.

 Profile for Django 4.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf722d2fc-91812472-7ab7-4d0d-919e-81f0649ad6ce-00%40eu-central-1.amazonses.com.

[Django] #35102: Performance regression on Model.objects.count() between Django 4.2 and 5.0

[Django]

#35102: Performance regression on Model.objects.count() between Django 4.2 and 
5.0
-+
   Reporter:  Anthony Shaw   |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Uncategorized  |Version:  5.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 I was running the djangobench tool against the 4.2 and 5.0.1 tags (and
 main to verify) and noticed that some of the benchmarks had significant
 regressions.

 The one I wanted to highlight is `query_count`. The other two with
 regressions were model creation and query_annotate.

 `djangobench --control 4.2 --experiment 5.0.1 query_count -p profiles`

 The profile for both versions shows that in v5, get_aggregation has an
 additional call to replace_expressions which spends a lot of time in the
 slow inspect module. In the profile reports I collected this accounts for
 the 30-40% performance regression on the count aggregation query.

 Performance regressions with new features are expected, but I wanted to
 raise this because the [ASV environment for
 Django](https://github.com/django/django-asv) seemed to have missed some
 of these regressions when all of the benchmarks suddenly ran faster.

 I've attached profiles for 4.2 and 5.0.1 which can be opened using
 something like snakeviz

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf7225367-d3320fe8-2138-4014-852f-b3fc84867716-00%40eu-central-1.amazonses.com.

Re: [Django] #28404: Django admin empty_value/empty_value_display doesn't check for empty strings

[Django]

#28404: Django admin empty_value/empty_value_display doesn't check for empty
strings
-+-
 Reporter:  Mark Koh |Owner:  Alexander
 |  Lazarević
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  empty value display  | Triage Stage:  Accepted
  admin charfield|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Alexander Lazarević):

 * has_patch:  0 => 1


Comment:

 Additional PR https://github.com/django/django/pull/17720

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf6e2b83c-c712622a-5978-4b93-a4b5-86aa7795ec25-00%40eu-central-1.amazonses.com.

Re: [Django] #16281: ContentType.get_object_for_this_type using wrong database for creating object

[Django]

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-+-
 Reporter:  tfrydrychewicz@… |Owner:  bcail
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  dev
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:
 Keywords:  contenttype, object  | Triage Stage:  Accepted
  get_object_for_this_type,  |
  database, multiple |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf6da03f8-19b36f76-ca28-4f07-8e9a-0b75e35e0718-00%40eu-central-1.amazonses.com.

Re: [Django] #35095: Monetary values in Switzerland discrepancy

[Django]

#35095: Monetary values in Switzerland discrepancy
-+-
 Reporter:  Andrea Angelini  |Owner:
 Type:   |  NeilPen2005
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  5.0
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by NeilPen2005):

 * owner:  nobody => NeilPen2005
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf58dc352-bdb312d6-51f2-4d14-b403-b9541557d3b5-00%40eu-central-1.amazonses.com.

Re: [Django] #28404: Django admin empty_value/empty_value_display doesn't check for empty strings

[Django]

#28404: Django admin empty_value/empty_value_display doesn't check for empty
strings
-+-
 Reporter:  Mark Koh |Owner:  Alexander
 |  Lazarević
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  empty value display  | Triage Stage:  Accepted
  admin charfield|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * status:  closed => new
 * has_patch:  1 => 0
 * resolution:  fixed =>
 * stage:  Ready for checkin => Accepted


Comment:

 Agreed, let's reopen.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf51667cb-e6e90558-41d8-44c4-920d-9c3e06bf4209-00%40eu-central-1.amazonses.com.

Re: [Django] #34769: JSONField key/path transforms tests fail on Oracle 21c.

[Django]

#34769: JSONField key/path transforms tests fail on Oracle 21c.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  oracle json  | Triage Stage:  Accepted
  jsonfield  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8d2c16252e78a0fae2356ead3a7b3f879a653046" 8d2c162]:
 {{{
 #!CommitTicketReference repository=""
 revision="8d2c16252e78a0fae2356ead3a7b3f879a653046"
 Fixed #34769 -- Fixed key transforms on Oracle 21c+.

 Oracle 21c introduced support for primivites in JSON fields that
 caused changes in handling them by JSON_QUERY/JSON_VALUE functions.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf4f69004-0b7ce4ad-65bd-4150-a69b-824e59a10ed8-00%40eu-central-1.amazonses.com.

Re: [Django] #16281: ContentType.get_object_for_this_type using wrong database for creating object

[Django]

#16281: ContentType.get_object_for_this_type using wrong database for creating
object
-+-
 Reporter:  tfrydrychewicz@… |Owner:  bcail
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  dev
  contrib.contenttypes   |
 Severity:  Normal   |   Resolution:
 Keywords:  contenttype, object  | Triage Stage:  Accepted
  get_object_for_this_type,  |
  database, multiple |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by bcail):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf4d4cc94-506ece56-53ab-42aa-a1d2-54941e0ebc83-00%40eu-central-1.amazonses.com.

Re: [Django] #35101: docker-compose exec web python manage.py createsuperuser service "web" is not running

[Django]

#35101: docker-compose exec web python manage.py createsuperuser service "web" 
is
not running
---+--
 Reporter:  eddhyne|Owner:  nobody
 Type:  Uncategorized  |   Status:  closed
Component:  Uncategorized  |  Version:  5.0
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 The Django projct has no affiliation with ch3-postgresql. See
 TicketClosingReasons/UseSupportChannels or seek help from that project.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf4919b0f-75e134ba-d20c-4b63-8fa4-81b9114e1988-00%40eu-central-1.amazonses.com.

[Django] #35101: docker-compose exec web python manage.py createsuperuser service "web" is not running

[Django]

#35101: docker-compose exec web python manage.py createsuperuser service "web" 
is
not running
-+
   Reporter:  eddhyne|  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Uncategorized  |Version:  5.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 Working on ch3-postgresql ran docker build .  then docker-compose up -d
 and when I run PS Z:\Docker+Django\EdsDesktop\code\ch3-postgresql> docker-
 compose exec web python manage.py createsuperuser  I get "web" is not
 running

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf47d17df-ca9ec011-fe35-4c32-9390-b2216be81598-00%40eu-central-1.amazonses.com.

Re: [Django] #34044: Admin app search filter appears in nav sidebar but not on admin homepage

[Django]

#34044: Admin app search filter appears in nav sidebar but not on admin homepage
---+--
 Reporter:  Hugo Herter|Owner:  Hisham Mahmood
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by Natalia Bidart):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf47591a8-8669ed99-e094-45fc-8149-c8dba3b10059-00%40eu-central-1.amazonses.com.

Re: [Django] #35095: Monetary values in Switzerland discrepancy

[Django]

#35095: Monetary values in Switzerland discrepancy
--+
 Reporter:  Andrea Angelini   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Internationalization  |  Version:  5.0
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by HimaTeju):

 Replying to [comment:3 Mariusz Felisiak]:
 > > What I pointed out is that, **for monetary numbers**, the
 documentation says "a comma is used as the thousand separator", whilst the
 comment in format says "the THOUSAND_SEPARATOR is a ' (single quote)".
 >
 > OK, but it's not something that Django uses, so it's just a real minor
 typo in docs/comments.
 >
 > For the future, that kind of cleanups doesn't require a ticket, feel-
 free to check sources and submit PR.

 Hii! I am very new to open source, and I want to fix this typo, please
 help me out. So where exactly is the typo? In the documentation or the
 comments?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf42d87b9-f8176152-f2fd-49e0-b0d9-99690f35ce56-00%40eu-central-1.amazonses.com.

Re: [Django] #35098: ValidationError is being converted into a 500 Internal Server Error response

[Django]

#35098: ValidationError is being converted into a 500 Internal Server Error
response
---+--
 Reporter:  Yawar Quadir Amin  |Owner:  (none)
 Type:  Bug|   Status:  closed
Component:  Error reporting|  Version:  5.0
 Severity:  Normal |   Resolution:  invalid
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--

Comment (by Yawar Quadir Amin):

 As I mentioned yesterday, I already solved the issue on my end with a
 couple lines of code changes. Thanks for your concern. I am happy to read
 any documentation but it seems there is nothing to document because this
 is a universal behaviour. Yet when I raise a `RequestValidationError` in a
 FastAPI handler, it is converted into a 422 Unprocessable Entity response.

 Since this is fine, nothing further from my side. Thanks for your
 attention.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf410138b-a3ba50fb-c1c3-4541-98d3-f44c66363d15-00%40eu-central-1.amazonses.com.

Re: [Django] #35100: Simplify initialization of databases in the GeoIP2 wrapper

[Django]

#35100: Simplify initialization of databases in the GeoIP2 wrapper
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  geoip2   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Nick Pope):

 * needs_better_patch:  1 => 0


Comment:

 Rebased and fixed tests after #35092.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf36933d7-8361fcaf-7b84-4eaf-96cb-2423e5a77e6a-00%40eu-central-1.amazonses.com.

Re: [Django] #35090: Enforce uniqueness on custom path converters

[Django]

#35090: Enforce uniqueness on custom path converters
--+
 Reporter:  Adam Johnson  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (URLs)   |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Salvo Polizzi):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf35e5c58-d045d9e5-5875-4ccd-bc85-cec65b2d9bb2-00%40eu-central-1.amazonses.com.

Re: [Django] #35100: Simplify initialization of databases in the GeoIP2 wrapper

[Django]

#35100: Simplify initialization of databases in the GeoIP2 wrapper
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  geoip2   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf33bc48b-cfee516f-ae11-41ac-8f56-dd470f635ce8-00%40eu-central-1.amazonses.com.

Re: [Django] #28404: Django admin empty_value/empty_value_display doesn't check for empty strings

[Django]

#28404: Django admin empty_value/empty_value_display doesn't check for empty
strings
-+-
 Reporter:  Mark Koh |Owner:  Alexander
 |  Lazarević
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  empty value display  | Triage Stage:  Ready for
  admin charfield|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by Alexander Lazarević):

 I'm afraid my PR might not have been complete. I just tried something like
 this:


 {{{
 @admin.register(SomeModel)
 class SomeModelAdmin(admin.ModelAdmin):
 list_display = (
 "name",
 "description",
 "my_description",
 )
 empty_value_display = "-empty-"

 @admin.display(empty_value="-very empty-")
 def my_description(self, obj):
 return ""  # obj.description
 }}}

 and it did not show the "-very empty-" string.


 I guess this needs to be changed as well:

 {{{
 def display_for_value(value, empty_value_display, boolean=False):
 from django.contrib.admin.templatetags.admin_list import _boolean_icon

 if boolean:
 return _boolean_icon(value)

 elif value is None:  <-
 return empty_value_display

 elif isinstance(value, bool):
 return str(value)
 ...
 }}}

 Can somebody please confirm this? Sorry for not seeing it earlier ...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf33ad719-d8a601f3-e750-46fd-883a-87018fd97e20-00%40eu-central-1.amazonses.com.

Re: [Django] #35100: Simplify initialization of databases in the GeoIP2 wrapper

[Django]

#35100: Simplify initialization of databases in the GeoIP2 wrapper
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  geoip2   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf330ebb9-7c50a5c4-dacc-45af-b631-9badd11b283b-00%40eu-central-1.amazonses.com.

Re: [Django] #35092: Expose additional data in responses from geoip2 queries.

[Django]

#35092: Expose additional data in responses from geoip2 queries.
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  New feature  |   Status:  closed
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  geoip2   | Triage Stage:  Ready for checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"f50184a84b885f4474d5030af968195219a360b9" f50184a8]:
 {{{
 #!CommitTicketReference repository=""
 revision="f50184a84b885f4474d5030af968195219a360b9"
 Fixed #35092 -- Exposed extra fields for GeoIP2.country() and
 GeoIP2.city() responses.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf31073b0-adb81d51-0ca9-45d7-bfc0-b034573e7fae-00%40eu-central-1.amazonses.com.

Re: [Django] #35100: Simplify initialization of databases in the GeoIP2 wrapper

[Django]

#35100: Simplify initialization of databases in the GeoIP2 wrapper
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  geoip2   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Nick Pope):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/17718 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf30db788-595816e5-5c72-4530-978c-b18953721255-00%40eu-central-1.amazonses.com.

[Django] #35100: Simplify initialization of databases in the GeoIP2 wrapper

[Django]

#35100: Simplify initialization of databases in the GeoIP2 wrapper
-+-
   Reporter:  Nick Pope  |  Owner:  Nick Pope
   Type: | Status:  assigned
  Cleanup/optimization   |
  Component:  GIS|Version:  dev
   Severity:  Normal |   Keywords:  geoip2
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 The initialization of the wrapper around the GeoIP2 databases is
 overcomplicated and should be simplified.

 Currently when calling `GeoIP2.city()` and `GeoIP2.country()` the city and
 country databases will be used respectively, but this is unnecessary as
 the country database is merely a subset of the city database. It should be
 possible to provide a path and attempt to open a database from three
 possible candidates: `path`, `path / city`, and `path / country`. While a
 minor incompatibility in that the city database may be used instead, this
 also reduces the potential for mixing data from two different databases
 where one might be outdated.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf30c13c0-bd04fbd4-fe4a-4262-87c9-199dc9764232-00%40eu-central-1.amazonses.com.

Re: [Django] #34769: JSONField key/path transforms tests fail on Oracle 21c.

[Django]

#34769: JSONField key/path transforms tests fail on Oracle 21c.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  oracle json  | Triage Stage:  Accepted
  jsonfield  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/17717 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf30bf778-55ea0100-f899-4ba0-82bd-b4a4a44c6b62-00%40eu-central-1.amazonses.com.

Re: [Django] #35092: Expose additional data in responses from geoip2 queries.

[Django]

#35092: Expose additional data in responses from geoip2 queries.
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:  New feature  |   Status:  assigned
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  geoip2   | Triage Stage:  Ready for checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf30668eb-317658fa-f630-40b9-9240-91cba99b719c-00%40eu-central-1.amazonses.com.

Re: [Django] #35099: Combining QuerySets with "|" or "&" mutates right-hand side.

[Django]

#35099: Combining QuerySets with "|" or "&" mutates right-hand side.
-+-
 Reporter:  Alan |Owner:  Alan
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  5.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Alan
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf2f1fe3f-12e90748-2a95-4686-ab6f-ed5dad6fe60a-00%40eu-central-1.amazonses.com.

Re: [Django] #34769: JSONField key/path transforms tests fail on Oracle 21c.

[Django]

#34769: JSONField key/path transforms tests fail on Oracle 21c.
-+-
 Reporter:  Mariusz Felisiak |Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  4.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  oracle json  | Triage Stage:  Accepted
  jsonfield  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Mariusz Felisiak
 * status:  new => assigned


Comment:

 I'm finally figured out how to fix this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf2c8297a-809c6174-a409-41e6-b5a5-ed0caa4efba7-00%40eu-central-1.amazonses.com.

Re: [Django] #35099: Combining QuerySets with "|" or "&" mutates right-hand side.

[Django]

#35099: Combining QuerySets with "|" or "&" mutates right-hand side.
-+-
 Reporter:  Alan |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  5.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 > Regarding the patch, I've never contributed to Django, so it may take
 quite a while for me to get familiar with what's required. If you could
 point me to the key resources on how to do that, I may take a shot on a
 weekend.

 Great, thanks! I'd recommend joining our [https://discord.gg/xcRH6mN4fa
 Discord server] and asking on the `#contributing-getting-started` channel,
 folks are very helpful there.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf2c20014-3b93890a-184b-4324-906e-36d46162007b-00%40eu-central-1.amazonses.com.

Re: [Django] #35099: Combining QuerySets with "|" or "&" mutates right-hand side.

[Django]

#35099: Combining QuerySets with "|" or "&" mutates right-hand side.
-+-
 Reporter:  Alan |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  5.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Alan):

 Replying to [comment:2 Mariusz Felisiak]:
 > Does it work for you? Would you like to prepare a patch? (a regression
 test is required).

 It does work for me, the test now passes correctly after applying cloning
 the rhs.

 Regarding the patch, I've never contributed to Django, so it may take
 quite a while for me to get familiar with what's required. If you could
 point me to the key resources on how to do that, I may take a shot on a
 weekend.

 I found a "Submitting a patches" in Django doc. I need more guidance on
 how to cover this case with regression tests. I would highly appreciate
 some references to take a look at.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf2bbb607-e028afbe-77ea-48f8-bb38-d92fe0521ee4-00%40eu-central-1.amazonses.com.

Re: [Django] #33497: Database persistent connections do not work with ASGI in 4.0

[Django]

#33497: Database persistent connections do not work with ASGI in 4.0
-+-
 Reporter:  Stenkar  |Owner:  Sarah
 |  Boyce
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  4.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  ASGI, Database,  | Triage Stage:  Accepted
  async  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Dmytro Litvinov):

 * cc: Dmytro Litvinov (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf2b08337-4636b835-40f7-4242-8718-7b75fcaaefed-00%40eu-central-1.amazonses.com.

Re: [Django] #28404: Django admin empty_value/empty_value_display doesn't check for empty strings

[Django]

#28404: Django admin empty_value/empty_value_display doesn't check for empty
strings
-+-
 Reporter:  Mark Koh |Owner:  Alexander
 |  Lazarević
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  empty value display  | Triage Stage:  Ready for
  admin charfield|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by Alexander Lazarević):

 Yeah! Thanks for your support, Mariusz!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf2a63bbe-ca82a4d1-6be5-4415-b326-68910f7381b9-00%40eu-central-1.amazonses.com.

Re: [Django] #35099: Combining QuerySets with "|" or "&" mutates right-hand side. (was: Combining QuerySets with "|" or "&" produce side effects affecting further queries)

[Django]

#35099: Combining QuerySets with "|" or "&" mutates right-hand side.
-+-
 Reporter:  Alan |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  5.0
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the report.This is caused by
 
[https://github.com/django/django/blob/9b02ad91ead3db75036be981bab2083aebc993a6/django/db/models/sql/query.py#L688
 bumping prefixes], we should probably clone `rhs` before doing this, e.g.
 {{{#!diff
 diff --git a/django/db/models/sql/query.py b/django/db/models/sql/query.py
 index a79d66eb21..5539f35b1c 100644
 --- a/django/db/models/sql/query.py
 +++ b/django/db/models/sql/query.py
 @@ -685,6 +685,7 @@ class Query(BaseExpression):
  # except if the alias is the base table since it must be present
 in the
  # query on both sides.
  initial_alias = self.get_initial_alias()
 +rhs = rhs.clone()
  rhs.bump_prefix(self, exclude={initial_alias})

  # Work out how to relabel the rhs aliases, if necessary.
 }}}
 Does it work for you? Would you like to prepare a patch? (a regression
 test is required).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf28767ae-e23ab235-aafa-4716-92ff-2636d1d193fa-00%40eu-central-1.amazonses.com.

Re: [Django] #28404: Django admin empty_value/empty_value_display doesn't check for empty strings

[Django]

#28404: Django admin empty_value/empty_value_display doesn't check for empty
strings
-+-
 Reporter:  Mark Koh |Owner:  Alexander
 |  Lazarević
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  empty value display  | Triage Stage:  Ready for
  admin charfield|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"9b02ad91ead3db75036be981bab2083aebc993a6" 9b02ad9]:
 {{{
 #!CommitTicketReference repository=""
 revision="9b02ad91ead3db75036be981bab2083aebc993a6"
 Fixed #28404 -- Made displaying values in admin respect Field's
 empty_values.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf277e686-a3ed7338-b1e3-4ec9-bc5a-1c65919a9c57-00%40eu-central-1.amazonses.com.

Re: [Django] #5865: cycle template tag should accept a single argument

[Django]

#5865: cycle template tag should accept a single argument
-+-
 Reporter:  Gary Wilson  |Owner:  Alexander
 |  Lazarević
 Type:  New feature  |   Status:  assigned
Component:  Template system  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Alexander Lazarević):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0
 * needs_docs:  1 => 0


Comment:

 For the new PR I'm going to remove "Needs documentation", "Needs tests"
 and "Patch needs improvement". Please set these flags again if required
 (or I should have left them set in the first place).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018cf272c309-20ddb240-045f-4e9f-b66b-58a16bcfa412-00%40eu-central-1.amazonses.com.