Re: [Django] #35172: intcomma adds leading comma for string-based 3-digit number with at least 1 decimal place.

2024-02-06 Thread Django
#35172: intcomma adds leading comma for string-based 3-digit number with at 
least 1
decimal place.
-+-
 Reporter:  Warwick Brown|Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  contrib.humanize |  Version:  3.2
 Severity:  Release blocker  |   Resolution:
 Keywords:  humanize intcomma| Triage Stage:  Accepted
  comma decimal places   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_docs:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d8270022e-d33fed02-b496-4876-afa2-a5483d4a6a22-00%40eu-central-1.amazonses.com.


Re: [Django] #30686: Improve utils.text.Truncator &co to use a full HTML parser.

2024-02-06 Thread Django
#30686: Improve utils.text.Truncator &co to use a full HTML parser.
---+---
 Reporter:  Thomas Hooper  |Owner:  David Smith
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---
Comment (by Mariusz Felisiak ):

 In [changeset:"70f39e46f86b946c273340d52109824c776ffb4c" 70f39e4]:
 {{{#!CommitTicketReference repository=""
 revision="70f39e46f86b946c273340d52109824c776ffb4c"
 Refs #30686 -- Fixed text truncation for negative or zero lengths.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d8268c97a-4cd28b66-3c67-4e36-91b2-4fe6d8a53dcf-00%40eu-central-1.amazonses.com.


Re: [Django] #35171: Update the django 'congrats' page that is shown after a fresh install of django

2024-02-06 Thread Django
#35171: Update the django 'congrats' page that is shown after a fresh install of
django
-+-
 Reporter:  Alexander Lazarević  |Owner:  Alexander
 Type:   |  Lazarević
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Alexander Lazarević
 * status:  new => assigned
 * stage:  Unreviewed => Accepted

Comment:

 Sounds good, thanks.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d826709b0-752c6502-24f9-47fc-aa27-6c5361d68384-00%40eu-central-1.amazonses.com.


Re: [Django] #35172: intcomma adds leading comma for string-based 3-digit number with at least 1 decimal place.

2024-02-06 Thread Django
#35172: intcomma adds leading comma for string-based 3-digit number with at 
least 1
decimal place.
-+-
 Reporter:  Warwick Brown|Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  contrib.humanize |  Version:  3.2
 Severity:  Release blocker  |   Resolution:
 Keywords:  humanize intcomma| Triage Stage:  Accepted
  comma decimal places   |
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_docs:  0 => 1
 * has_patch:  0 => 1

Comment:

 [https://github.com/django/django/pull/17833 PR]
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d820200fa-1c15dc49-40ca-4fad-b2fe-d2027a1419ff-00%40eu-central-1.amazonses.com.


Re: [Django] #35172: intcomma adds leading comma for string-based 3-digit number with at least 1 decimal place.

2024-02-06 Thread Django
#35172: intcomma adds leading comma for string-based 3-digit number with at 
least 1
decimal place.
-+-
 Reporter:  Warwick Brown|Owner:  Mariusz
 |  Felisiak
 Type:  Bug  |   Status:  assigned
Component:  contrib.humanize |  Version:  3.2
 Severity:  Release blocker  |   Resolution:
 Keywords:  humanize intcomma| Triage Stage:  Accepted
  comma decimal places   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Mariusz Felisiak
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d81f0638e-f8f08226-23eb-4869-81c7-aa8e3ede6130-00%40eu-central-1.amazonses.com.


Re: [Django] #35172: intcomma adds leading comma for string-based 3-digit number with at least 1 decimal place. (was: intcomma patch in CVE-2024-24680 causing leading comma when provided string-based

2024-02-06 Thread Django
#35172: intcomma adds leading comma for string-based 3-digit number with at 
least 1
decimal place.
-+-
 Reporter:  Warwick Brown|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.humanize |  Version:  3.2
 Severity:  Release blocker  |   Resolution:
 Keywords:  humanize intcomma| Triage Stage:  Accepted
  comma decimal places   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: Natalia Bidart, Adam Johnson (added)
 * summary:
 intcomma patch in CVE-2024-24680 causing leading comma when provided
 string-based 3-digit number with at least 1 decimal place
 =>
 intcomma adds leading comma for string-based 3-digit number with at
 least 1 decimal place.
 * severity:  Normal => Release blocker
 * version:  4.2 => 3.2
 * stage:  Unreviewed => Accepted

Comment:

 Great catch! Thanks for the report.

 Regression in 55519d6cf8998fe4c8f5c8abffc2b10a7c3d14e9.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d81dc5a8a-dac36d4d-2f5d-45f8-807b-5d5ab561652f-00%40eu-central-1.amazonses.com.


Re: [Django] #35172: intcomma patch in CVE-2024-24680 causing leading comma when provided string-based 3-digit number with at least 1 decimal place

2024-02-06 Thread Django
#35172: intcomma patch in CVE-2024-24680 causing leading comma when provided
string-based 3-digit number with at least 1 decimal place
-+-
 Reporter:  Warwick Brown|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.humanize |  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  humanize intcomma| Triage Stage:
  comma decimal places   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Warwick Brown):

 * type:  Uncategorized => Bug

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d81ca544f-c7601aee-74c7-4185-8746-086cc7b903f3-00%40eu-central-1.amazonses.com.


[Django] #35172: intcomma patch in CVE-2024-24680 causing leading comma when provided string-based 3-digit number with at least 1 decimal place

2024-02-06 Thread Django
#35172: intcomma patch in CVE-2024-24680 causing leading comma when provided
string-based 3-digit number with at least 1 decimal place
-+-
   Reporter:  Warwick|  Owner:  nobody
  Brown  |
   Type: | Status:  new
  Uncategorized  |
  Component: |Version:  4.2
  contrib.humanize   |   Keywords:  humanize intcomma
   Severity:  Normal |  comma decimal places
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 I'm running (4, 2, 10, 'final', 0)

 Just discovered that the patch to intcomma made in CVE-2024-24680 is
 causing numbers to appear with a leading comma when they're 3 digits (ie
 between 100 and 999) with at least 1 decimal place

 {{{#!python
 In [34]: intcomma('111')
 Out[34]: '111'

 In [35]: intcomma('111.1')
 Out[35]: ',111.1'

 In [36]: intcomma('99.1')
 Out[36]: '99.1'

 In [37]: intcomma('999.1')
 Out[37]: ',999.1'
 }}}

 I note there doesn't appear to be a test in
 `tests/humanize_tests/tests.py` for the case of a string "111.1"

 I encountered this because I use `{{ price|floatformat:2|intcomma }}` in
 templates, thus floatformat is providing a string to intcomma.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d81c9f3c3-18724ff2-d120-4b59-b4ef-9633a8792c63-00%40eu-central-1.amazonses.com.


Re: [Django] #34901: Add async interface to contrib.sessions

2024-02-06 Thread Django
#34901: Add async interface to contrib.sessions
--+--
 Reporter:  Jon Janzen|Owner:  Jon Janzen
 Type:  New feature   |   Status:  assigned
Component:  contrib.sessions  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:  async | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Jon Janzen):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d812fedd9-d98f3dd3-f5cc-4ea5-87ec-c4538b07408f-00%40eu-central-1.amazonses.com.


Re: [Django] #35171: Update the django 'congrats' page that is shown after a fresh install of django

2024-02-06 Thread Django
#35171: Update the django 'congrats' page that is shown after a fresh install of
django
-+-
 Reporter:  Alexander Lazarević  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Alexander Lazarević:

Old description:

> Most of this has been discussed in https://forum.djangoproject.com/t
> /changing-the-congrats-page/27557
>
> A demo of the page can be seen here: https://congrats.e11bits.com
>
> Mainly this move the header to the center of the page and adds a django
> logo in the center as well.

New description:

 Most of this has been discussed in https://forum.djangoproject.com/t
 /changing-the-congrats-page/27557

 A demo of the page can be seen here: https://congrats.e11bits.com

 Mainly this moves the header to the center of the page and adds a django
 logo in the center as well.

--
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d8070245d-85bf343a-182b-4ab6-af77-5bf70310bf3e-00%40eu-central-1.amazonses.com.


Re: [Django] #35171: Update the django 'congrats' page that is shown after a fresh install of django

2024-02-06 Thread Django
#35171: Update the django 'congrats' page that is shown after a fresh install of
django
-+-
 Reporter:  Alexander Lazarević  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Alexander Lazarević:

Old description:

> Most of this has been discussed in https://forum.djangoproject.com/t
> /changing-the-congrats-page/27557
>
> A demo of the page can be seen here: htps://congrats.e11bits.com
>
> Mainly this move the header to the center of the page and adds a django
> logo in the center as well.

New description:

 Most of this has been discussed in https://forum.djangoproject.com/t
 /changing-the-congrats-page/27557

 A demo of the page can be seen here: https://congrats.e11bits.com

 Mainly this move the header to the center of the page and adds a django
 logo in the center as well.

--
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d806fc511-9c3dd1a5-8f86-46a4-95d5-76101278a43d-00%40eu-central-1.amazonses.com.


Re: [Django] #35171: Update the django 'congrats' page that is shown after a fresh install of django

2024-02-06 Thread Django
#35171: Update the django 'congrats' page that is shown after a fresh install of
django
-+-
 Reporter:  Alexander Lazarević  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by Alexander Lazarević:

Old description:

> Most of this has been discussed in https://forum.djangoproject.com/t
> /changing-the-congrats-page/27557
>
> A demo of the page can be seen here: congrats.e11bits.com
>
> Mainly this move the header to the center of the page and adds a django
> logo in the center as well.

New description:

 Most of this has been discussed in https://forum.djangoproject.com/t
 /changing-the-congrats-page/27557

 A demo of the page can be seen here: htps://congrats.e11bits.com

 Mainly this move the header to the center of the page and adds a django
 logo in the center as well.

--
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d806f869d-bfa9d720-8187-4f71-82a0-8c8fbaa66ffb-00%40eu-central-1.amazonses.com.


[Django] #35171: Update the django 'congrats' page that is shown after a fresh install of django

2024-02-06 Thread Django
#35171: Update the django 'congrats' page that is shown after a fresh install of
django
+
   Reporter:  Alexander Lazarević   |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Core (Other)  |Version:  dev
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Most of this has been discussed in https://forum.djangoproject.com/t
 /changing-the-congrats-page/27557

 A demo of the page can be seen here: congrats.e11bits.com

 Mainly this move the header to the center of the page and adds a django
 logo in the center as well.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d806dad3c-6a616540-5951-47e7-9886-30a984f3586d-00%40eu-central-1.amazonses.com.


Re: [Django] #35044: Accessing a deferred field clears reverse relations

2024-02-06 Thread Django
#35044: Accessing a deferred field clears reverse relations
-+-
 Reporter:  Adam Johnson |Owner:  Giannis
 |  Terzopoulos
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Giannis Terzopoulos):

 * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7ffd5939-6357bf36-3684-46c9-9ca8-80acbf1fc609-00%40eu-central-1.amazonses.com.


Re: [Django] #10743: Support lookup separators in ModelAdmin.list_display

2024-02-06 Thread Django
#10743: Support lookup separators in ModelAdmin.list_display
-+-
 Reporter:  mrts |Owner:  Tom
 |  Carrick
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  efficient-admin, | Triage Stage:  Ready for
  list_display   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by GitHub ):

 In [changeset:"3e820d10f81ea9d0576633734c2ebd2621575cbe" 3e820d10]:
 {{{#!CommitTicketReference repository=""
 revision="3e820d10f81ea9d0576633734c2ebd2621575cbe"
 Refs #10743 -- Removed leftover comment in
 tests/admin_changelist/tests.py.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7ff94584-c14df68e-27ff-4cd7-b8fd-d4bbbdca8e63-00%40eu-central-1.amazonses.com.


Re: [Django] #35044: Accessing a deferred field clears reverse relations

2024-02-06 Thread Django
#35044: Accessing a deferred field clears reverse relations
-+-
 Reporter:  Adam Johnson |Owner:  Giannis
 |  Terzopoulos
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Giannis Terzopoulos):

 Thank you both! I opened a PR for this
 [https://github.com/django/django/pull/17831 PR]

 I've added tests for `defer()` and `only()` for relations/private fields
 and updated the `refresh_from_db()` accordingly. I also added a couple of
 tests with the `fields` kwarg specified.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7ff7e3cd-a1669f37-5b4d-4842-a096-5203c63f0a48-00%40eu-central-1.amazonses.com.


Re: [Django] #30686: Improve utils.text.Truncator &co to use a full HTML parser.

2024-02-06 Thread Django
#30686: Improve utils.text.Truncator &co to use a full HTML parser.
---+---
 Reporter:  Thomas Hooper  |Owner:  David Smith
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  dev
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---
Comment (by Mariusz Felisiak ):

 In [changeset:"48a469395191e87d3b84ad35bae2c8b53d91ed61" 48a46939]:
 {{{#!CommitTicketReference repository=""
 revision="48a469395191e87d3b84ad35bae2c8b53d91ed61"
 Refs #30686 -- Improved test coverage of Truncator.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7fd6aeb7-182fe970-d461-403e-ae7b-1575d4508242-00%40eu-central-1.amazonses.com.


Re: [Django] #35167: JSONFIeld get_db_prep_value being called with `Cast` types

2024-02-06 Thread Django
#35167: JSONFIeld get_db_prep_value being called with `Cast` types
-+
 Reporter:  Samantha Hughes  |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Error reporting  |  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  JSONField| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Comment (by Samantha Hughes):

 Thanks, the quick response is really appreciated. Any idea if this will
 make it to a 4.2 patch or will we need to upgrade to ~5?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7fd637a5-37fec560-4014-4fbb-b793-985f9d96e489-00%40eu-central-1.amazonses.com.


[Django] #35170: LocaleMiddleware unexpectedly causes messages to be consumed under certain circumstances

2024-02-06 Thread Django
#35170: LocaleMiddleware unexpectedly causes messages to be consumed under 
certain
circumstances
+
   Reporter:  Sylvain Fankhauser|  Owner:  nobody
   Type:  Bug   | Status:  new
  Component:  Internationalization  |Version:  5.0
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Adding a message (with the messages contrib module) to the request and
 then redirecting the user to an internationalized route without the
 language prefix and a custom 404 template that consumes messages will
 consume messages from the request, even though no 404 response is sent
 back to the client.

 I have set up a minimal reproduction project here:
 https://github.com/sephii/django-localemiddleware-bug

 To reproduce this problem, you’ll need:

 1. An internationalized route (eg. `urlpatterns +=
 i18n_patterns(path("foo/", views.foo))`)
 2. A view that adds a message to the request (eg.
 `messages.success(request, "Hello world")`) and then redirects to the
 internationalized route without a language prefix
 3. A 404.html template that consumes the request messages (eg. `{% for
 message in messages %}{{ message }}{% endfor %}`)

 Visiting the view defined in point 2 will result in a 302 to /foo/, which,
 because of the 404.html template, will consume the message added by the
 view in point 2 before redirecting to /en/foo/ (which won’t have any
 message left to consume).

 The bug is not in LocaleMiddleware per se, but is related to the way
 LocaleMiddleware works: by catching any 404 and checking if it matches an
 internationalized route, and if so redirecting to the correct route, but
 at this point the 404 response has been rendered.

 Ideally the only response Django should create is the redirect, and no 404
 should be rendered.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7f1c7724-75ef5c8c-26c4-4474-9005-b8b3d194bc7a-00%40eu-central-1.amazonses.com.


Re: [Django] #21961: Add support for database-level cascading options

2024-02-06 Thread Django
#21961: Add support for database-level cascading options
-+-
 Reporter:  Christophe Pettus|Owner:  Akash
 |  Kumar Sen
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Roman Donchenko):

 * cc: Roman Donchenko (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7ee52896-a6c7b03c-b342-4487-860e-eb3566895f09-00%40eu-central-1.amazonses.com.


Re: [Django] #29725: Inefficient SQL generated when counting a ManyToMany

2024-02-06 Thread Django
#29725: Inefficient SQL generated when counting a ManyToMany
-+-
 Reporter:  Gavin Wahl   |Owner:  ontowhee
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Comment (by ontowhee):

 I have removed the changes involving chaining all().
 [https://github.com/django/django/pull/17811 PR]
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7ecc4255-69d96393-537e-4735-bf87-5b9911ce227a-00%40eu-central-1.amazonses.com.


Re: [Django] #35169: updated asgi handler for disconnects does not process ROOT_PATH

2024-02-06 Thread Django
#35169: updated asgi handler for disconnects does not process ROOT_PATH
-+-
 Reporter:  Michael Smith|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  asgi, handler,   | Triage Stage:
  root_path  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Carlton Gibson):

 @Michael. `set_script_prefix` targets a `Local`, so if we change thread
 maybe the value gets lost, but I'm not seeing yet how that can be
 happening (in anything related to
 1d1ddffc27cd55c011298cd09bfa4de3fa73cf7a) — Happy to have a look once
 you've got a reproduce. Thanks!
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7e87ffc2-efa4bd4a-22b3-4293-bb7a-e5cd08bba05c-00%40eu-central-1.amazonses.com.


Re: [Django] #35169: updated asgi handler for disconnects does not process ROOT_PATH

2024-02-06 Thread Django
#35169: updated asgi handler for disconnects does not process ROOT_PATH
-+-
 Reporter:  Michael Smith|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  asgi, handler,   | Triage Stage:
  root_path  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Michael Smith):

 It may be that process_request does not need scope but just
 run_get_response. I will determine what exactly is needed with the
 regression test
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7e7dc605-a3903e56-ed99-4c90-94c8-9d6d7dd51187-00%40eu-central-1.amazonses.com.


Re: [Django] #35169: updated asgi handler for disconnects does not process ROOT_PATH

2024-02-06 Thread Django
#35169: updated asgi handler for disconnects does not process ROOT_PATH
-+-
 Reporter:  Michael Smith|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  asgi, handler,   | Triage Stage:
  root_path  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Michael Smith):

 I will add a regression test
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7e7a6798-82cefb3c-3cfa-4968-b602-be58fb24bf29-00%40eu-central-1.amazonses.com.


Re: [Django] #35169: updated asgi handler for disconnects does not process ROOT_PATH

2024-02-06 Thread Django
#35169: updated asgi handler for disconnects does not process ROOT_PATH
-+-
 Reporter:  Michael Smith|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  asgi, handler,   | Triage Stage:
  root_path  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Mariusz Felisiak):

 > all i can say is that when we upgraded to django 5 from 4.2.9

 Are you sure that it's not related with the `uvicorn` update?

 > I used git bisect to identify the specific commit that caused this.

 Can you add a regression test? You had to have one to actually bisect.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7e6dca0c-0cc266ca-45e0-4568-9af8-c366187b781c-00%40eu-central-1.amazonses.com.


Re: [Django] #35169: updated asgi handler for disconnects does not process ROOT_PATH

2024-02-06 Thread Django
#35169: updated asgi handler for disconnects does not process ROOT_PATH
-+-
 Reporter:  Michael Smith|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  asgi, handler,   | Triage Stage:
  root_path  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Michael Smith):

 all i can say is that when we upgraded to django 5 from 4.2.9, all the
 template url references outside of static files lost their root_path
 prefixes. By making these changes I was able to get the root_path passed
 back to the templates. If you have another way to resolve this, please but
 I have not been able to get the ROOT_PATH from uvicorn asgi server passed
 back to our application without this. I used git bisect to identify the
 specific commit that caused this. And by adding the scope, it restored the
 django 4 behavior.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7e67e149-2d26ea9a-a05f-47f8-9323-9398a4c0d8c5-00%40eu-central-1.amazonses.com.


Re: [Django] #35169: updated asgi handler for disconnects does not process ROOT_PATH

2024-02-06 Thread Django
#35169: updated asgi handler for disconnects does not process ROOT_PATH
-+-
 Reporter:  Michael Smith|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  asgi, handler,   | Triage Stage:
  root_path  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Carlton Gibson):

 Root path handling was adjusted in Uvicorn just recently.
 https://github.com/encode/uvicorn/pull/2213
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7e66e647-247b6a7a-db5f-411f-a405-583bb675d5a9-00%40eu-central-1.amazonses.com.


Re: [Django] #35169: updated asgi handler for disconnects does not process ROOT_PATH

2024-02-06 Thread Django
#35169: updated asgi handler for disconnects does not process ROOT_PATH
-+-
 Reporter:  Michael Smith|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  asgi, handler,   | Triage Stage:
  root_path  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: Carlton Gibson (added)
 * status:  new => closed
 * resolution:   => needsinfo

Comment:

 Thanks for the report, however, I'm puzzled, `process_request()` has never
 accepted or passed a `scope` (even before
 1d1ddffc27cd55c011298cd09bfa4de3fa73cf7a), so how this can be a
 regression? Also, `scope` is an element of `request` so why you need to
 pass it separately and call `set_script_prefix()`. This should be already
 handled by
 
[https://github.com/django/django/blob/9cefdfc43f0bae696b56fa5a0bf22346f85a/django/core/handlers/asgi.py#L172-L190
 ASGIHandler].
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7e5c3cfa-41efdfdd-6ff0-48f0-86b1-90da421c40ce-00%40eu-central-1.amazonses.com.


Re: [Django] #35169: updated asgi handler for disconnects does not process ROOT_PATH (was: updates asgi handler for disconnects does not process ROOT_PATH)

2024-02-06 Thread Django
#35169: updated asgi handler for disconnects does not process ROOT_PATH
-+-
 Reporter:  Michael Smith|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  asgi, handler,   | Triage Stage:
  root_path  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Michael Smith):

 * summary:  updates asgi handler for disconnects does not process ROOT_PATH
 => updated asgi handler for disconnects does not process ROOT_PATH

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7e322370-25f5fa04-dfe5-49bc-8739-2f60cf5e6307-00%40eu-central-1.amazonses.com.


Re: [Django] #35169: updates asgi handler for disconnects does not process ROOT_PATH

2024-02-06 Thread Django
#35169: updates asgi handler for disconnects does not process ROOT_PATH
-+-
 Reporter:  Michael Smith|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Other) |  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  asgi, handler,   | Triage Stage:
  root_path  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Michael Smith):

 Replying to [ticket:35169 Michael Smith]:
 > as a result of this PR, https://github.com/django/django/pull/16603, a
 root path, in this case, set via uvicornm is not handled in the response.
 >
 > I have created a small PR to fix this issue at
 https://github.com/msmitherdc/django/pull/1.

 django pr is https://github.com/django/django/pull/17828
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7e317522-bec42888-c337-4040-96b1-cee1ceccf315-00%40eu-central-1.amazonses.com.


[Django] #35169: updates asgi handler for disconnects does not process ROOT_PATH

2024-02-06 Thread Django
#35169: updates asgi handler for disconnects does not process ROOT_PATH
-+-
   Reporter:  Michael|  Owner:  nobody
  Smith  |
   Type:  Bug| Status:  new
  Component:  Core   |Version:  5.0
  (Other)|   Keywords:  asgi, handler,
   Severity:  Normal |  root_path
   Triage Stage: |  Has patch:  1
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 as a result of this PR, https://github.com/django/django/pull/16603, a
 root path, in this case, set via uvicornm is not handled in the response.

 I have created a small PR to fix this issue at
 https://github.com/msmitherdc/django/pull/1.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7e2151f3-df8d902d-b159-42df-90dd-daad6d8014a8-00%40eu-central-1.amazonses.com.


Re: [Django] #28646: Migration calls "CREATE INDEX" when one already exists when 'unique' field attribute is added (PostgreSQL)

2024-02-06 Thread Django
#28646: Migration calls "CREATE INDEX" when one already exists when 'unique' 
field
attribute is added (PostgreSQL)
-+-
 Reporter:  Hari - 何瑞理|Owner:  bcail
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  postgresql,migration,index,#djangocph|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7e081be2-6f850fce-de89-4d80-9e37-6143d1381fec-00%40eu-central-1.amazonses.com.


Re: [Django] #34917: Links in the Django admin should be underlined. (was: Links within text in the Django admin are difficult to identify)

2024-02-06 Thread Django
#34917: Links in the Django admin should be underlined.
-+-
 Reporter:  Dmitriy Chukhin  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:
  anchor |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * status:  closed => new
 * type:  Bug => Cleanup/optimization
 * summary:  Links within text in the Django admin are difficult to identify
 => Links in the Django admin should be underlined.
 * resolution:  duplicate =>
 * stage:  Unreviewed => Someday/Maybe

Comment:

 Reopen for adding underline to links in the admin.

 Marking as "Someday/Maybe" pending a discussion by the Accessibility Team
 to determine the scope of required changes.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d7da1b399-b5ca8138-6b1f-49cc-b18b-0b21f53f4a0f-00%40eu-central-1.amazonses.com.